@financial-times/dotcom-middleware-asset-loader 7.3.0 → 7.3.2

package/package.json

@@ -1,17 +1,16 @@
 {
   "name": "@financial-times/dotcom-middleware-asset-loader",
-  "version": "7.3.0",
+  "version": "7.3.2",
   "description": "",
   "main": "dist/node/index.js",
   "types": "src/index.ts",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
-    "tsc": "../../node_modules/.bin/tsc --incremental",
     "clean": "npm run clean:dist && npm run clean:node_modules",
     "clean:dist": "rm -rf dist",
     "clean:node_modules": "rm -rf node_modules",
+    "build:node": "tsc",
     "build": "npm run build:node",
-    "build:node": "npm run tsc -- --module commonjs --outDir ./dist/node",
     "dev": "npm run build:node -- --watch",
     "preinstall": "[ \"$INIT_CWD\" != \"$PWD\" ] || npm_config_yes=true npx check-engine"
   },
@@ -19,7 +18,7 @@
   "author": "",
   "license": "MIT",
   "dependencies": {
-    "@financial-times/dotcom-server-asset-loader": "^7.3.0",
+    "@financial-times/dotcom-server-asset-loader": "file:../../packages/dotcom-server-asset-loader",
     "express": "^4.16.4"
   },
   "devDependencies": {
@@ -32,6 +31,10 @@
     "node": ">= 14.0.0",
     "npm": "7.x || 8.x"
   },
+  "files": [
+    "dist/",
+    "src/"
+  ],
   "repository": {
     "type": "git",
     "repository": "https://github.com/Financial-Times/dotcom-page-kit.git",
@@ -41,4 +44,4 @@
   "volta": {
     "extends": "../../package.json"
   }
-}
+}

package/src/__test__/createMiddleware.spec.ts

@@ -0,0 +1,35 @@
+import subject from '../createMiddleware'
+import httpMocks from 'node-mocks-http'
+
+let instance
+let request
+let response
+let next
+
+jest.mock('@financial-times/dotcom-server-asset-loader')
+
+describe('dotcom-middleware-asset-loader/src/createMiddleware', () => {
+  beforeEach(() => {
+    instance = subject({})
+    request = httpMocks.createRequest({ app: { locals: {} } })
+    response = httpMocks.createResponse()
+    next = jest.fn()
+  })
+
+  afterEach(() => {
+    instance = null
+    request = null
+    response = null
+    next = null
+  })
+
+  it('calls the fallthrough function', () => {
+    instance(request, response, next)
+    expect(next).toHaveBeenCalled()
+  })
+
+  it('adds an instance of the asset loader to response.locals', () => {
+    instance(request, response, next)
+    expect(response.locals.assetLoader).toBeDefined()
+  })
+})

package/src/__test__/index.spec.ts

@@ -0,0 +1,42 @@
+import { init } from '../index'
+
+let instanceWithStaticHost
+let instanceNoStaticHost
+
+jest.mock('@financial-times/dotcom-server-asset-loader')
+
+describe('dotcom-middleware-asset-loader', () => {
+  beforeEach(() => {
+    instanceWithStaticHost = init({ hostStaticAssets: true })
+    instanceNoStaticHost = init({ hostStaticAssets: false })
+  })
+
+  afterEach(() => {
+    instanceWithStaticHost = null
+    instanceNoStaticHost = null
+  })
+
+  it('returns an array of handler functions', () => {
+    expect(instanceWithStaticHost).toBeInstanceOf(Array)
+
+    instanceWithStaticHost.forEach((item) => {
+      expect(item).toBeInstanceOf(Function)
+    })
+  })
+
+  describe('with hostStaticAssets enabled', () => {
+    it('returns multiple handlers', () => {
+      expect(instanceWithStaticHost).toHaveLength(2)
+    })
+
+    it('returns an instance of the router', () => {
+      expect(instanceWithStaticHost[1].name).toEqual('router')
+    })
+  })
+
+  describe('without hostStaticAssets enabled', () => {
+    it('returns one handler', () => {
+      expect(instanceNoStaticHost).toHaveLength(1)
+    })
+  })
+})