@financial-times/dotcom-build-code-splitting 11.3.0 → 12.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@financial-times/dotcom-build-code-splitting",
-  "version": "11.3.0",
+  "version": "12.0.0",
   "description": "",
   "main": "dist/node/index.js",
   "types": "dist/node/index.d.ts",
@@ -17,17 +17,13 @@
   "author": "",
   "license": "MIT",
   "peerDependencies": {
-    "webpack": "^4.39.2"
+    "webpack": "5.x"
   },
   "dependencies": {
     "assign-deep": "^1.0.1",
-    "disable-tree-shaking-for-chunk-plugin": "^1.1.0",
+    "disable-tree-shaking-for-chunk-plugin": "^2.0.0",
     "get-package-name": "^1.1.0",
-    "memoize-one": "^5.0.4",
-    "reliable-module-ids-plugin": "^1.0.1"
-  },
-  "devDependencies": {
-    "@types/webpack": "^4.41.7"
+    "memoize-one": "^5.0.4"
   },
   "engines": {
     "node": "18.x || 20.x || 22.x"

package/src/__test__/index.spec.ts

@@ -1,5 +1,5 @@
 import { promisify } from 'util'
-import webpack, { Configuration as WebpackConfiguration, Stats } from 'webpack'
+import webpack, { Configuration as WebpackConfiguration } from 'webpack'
 import path from 'path'
 import { PageKitCodeSplittingPlugin } from '../index'
 
@@ -17,12 +17,16 @@ describe('dotcom-build-code-splitting', () => {
       },
       plugins: [new PageKitCodeSplittingPlugin()]
     }
-    const result = (await webpackAsync([webpackConfig])) as { stats: [Stats] }
+    const result = await webpackAsync([webpackConfig])
+    if (!result) {
+      throw new Error('No webpack result')
+    }
 
     const stats = result.stats[0].toJson()
     if (!stats) {
       throw new Error('No stats')
     }
+
     const files = stats.assets?.map((asset) => asset.name) as string[]
     expect(files.find((file) => file.includes('privacy-components'))).toBeTruthy()
   })

package/src/index.ts

@@ -1,5 +1,4 @@
 import assignDeep from 'assign-deep'
-import ReliableModuleIdsPlugin from 'reliable-module-ids-plugin'
 import type webpack from 'webpack'
 
 import {
@@ -19,11 +18,9 @@ export class PageKitCodeSplittingPlugin {
           name: 'webpack-runtime'
         },
         splitChunks: {
-          chunks: 'all'
-        },
-        // We're going to implement our own algorithm so don't double effort
-        moduleIds: false,
-        chunkIds: 'named'
+          chunks: 'all',
+          name: compiler.options.mode === 'development' ? 'vendors' : false
+        }
       }
     }
 
@@ -92,8 +89,6 @@ export class PageKitCodeSplittingPlugin {
       usedInUnknownWay: true
     })
 
-    new ReliableModuleIdsPlugin().apply(compiler)
-
     assignDeep(
       compiler.options,
       addInitialCodeSplitting,