@final-commerce/common 2.0.16 → 2.0.18-beta.1

package/bin/gate-save.mjs

@@ -3,8 +3,7 @@
  * gate-save — pre-commit hook.
  *
  * 1. Runs lint-staged over modified surfaces.
- * 2. Scans staged .ts/.tsx/.js files for TODO comments that lack a Jira ticket
- *    reference (e.g. "// TODO: do something FI-123").  Bare TODOs block commit.
+ * 2. Syncs i18n bundles when the repo opts in via the fc-i18n package.json key.
  *
  * Exits 0 on success, 1 on any gate failure.
  *
@@ -48,7 +47,6 @@ if (stagedResult.status !== 0) {
   fail(`Could not enumerate staged files:\n${stagedResult.stderr.trim()}`);
 }
 
-const CODE_EXTS = /\.(ts|tsx|mts|cts|js|mjs|cjs|jsx)$/;
 const VERSION_BUMP_FILES = /^(package\.json|package-lock\.json|yarn\.lock)$/;
 
 const allStaged = stagedResult.stdout
@@ -61,8 +59,6 @@ if (allStaged.length > 0 && allStaged.every((f) => VERSION_BUMP_FILES.test(f)))
   process.exit(0);
 }
 
-const codeFiles = allStaged.filter((f) => CODE_EXTS.test(f) && !f.startsWith('bin/'));
-
 // ── 1. lint-staged ────────────────────────────────────────────────────────────
 
 info('Running lint-staged…');
@@ -74,64 +70,16 @@ if (lintResult.status !== 0) {
 
 ok('lint-staged passed.');
 
-// ── 2. TODO scanner ──────────────────────────────────────────────────────────
-
-info('Scanning staged files for bare TODOs…');
-
-// A Jira-style ticket reference: one or more uppercase letters, a dash, and digits.
-const JIRA_REF_RE = /[A-Z]+-\d+/;
-// Matches any TODO annotation (case-insensitive), with optional owner parens.
-const TODO_LINE_RE = /TODO(?:\s*\([^)]*\))?\s*[:：]?\s+(.+)/i;
-
-const violations = [];
-
-for (const file of codeFiles) {
-  // Read the staged blob, not the working-tree file, to avoid false positives
-  // from unstaged edits made after the last `git add`.
-  const blobResult = capture(`git show :${file}`);
-  if (blobResult.status !== 0) continue;
-
-  const lines = blobResult.stdout.split('\n');
-
-  for (let i = 0; i < lines.length; i++) {
-    const match = lines[i].match(TODO_LINE_RE);
-    if (match && !JIRA_REF_RE.test(lines[i])) {
-      violations.push({ file, line: i + 1, text: lines[i].trim() });
-    }
-  }
-}
-
-if (violations.length > 0) {
-  process.stderr.write(
-    '\x1b[31m✖  Bare TODOs detected — each TODO must carry a Jira ticket reference:\x1b[0m\n',
-  );
-
-  const byFile = violations.reduce((acc, v) => {
-    (acc[v.file] ??= []).push(v);
-    return acc;
-  }, {});
-
-  for (const [file, items] of Object.entries(byFile)) {
-    process.stderr.write(`\x1b[33m\n   ${file}\x1b[0m\n`);
-    items.forEach(({ line, text }) => {
-      process.stderr.write(`\x1b[90m     ${String(line).padStart(4)}  ${text}\x1b[0m\n`);
-    });
-  }
-
-  process.stderr.write(
-    '\x1b[90m\n   Example fix:  // TODO: refactor this FI-999\x1b[0m\n',
-  );
-  fail(`${violations.length} bare TODO(s) must be resolved before committing.`);
-}
-
-ok('No bare TODOs detected.');
-
-// ── 3. i18n sync ──────────────────────────────────────────────────────────────
+// ── 2. i18n sync ──────────────────────────────────────────────────────────────
 
 const pkgJsonPath = resolve(process.cwd(), 'package.json');
 if (existsSync(pkgJsonPath)) {
   let rootPkg;
-  try { rootPkg = JSON.parse(readFileSync(pkgJsonPath, 'utf8')); } catch { /* ignore */ }
+  try {
+    rootPkg = JSON.parse(readFileSync(pkgJsonPath, 'utf8'));
+  } catch {
+    /* ignore */
+  }
 
   if (rootPkg?.['fc-i18n']?.slug) {
     info('Running i18n sync…');

package/bin/gate-setup.mjs

@@ -114,15 +114,6 @@ function writeHook(name, content) {
 writeHook('pre-commit', 'npx gate-save');
 writeHook('pre-push', 'npx gate-done');
 
-const prepareCommitMsgHook = join(huskyDir, 'prepare-commit-msg');
-if (existsSync(prepareCommitMsgHook)) {
-  skip('.husky/prepare-commit-msg');
-} else {
-  writeFileSync(prepareCommitMsgHook, readFileSync(join(import.meta.dirname, 'prepare-commit-msg.sh'), 'utf8'), 'utf8');
-  chmodSync(prepareCommitMsgHook, 0o755);
-  ok('Created .husky/prepare-commit-msg');
-}
-
 writeHook('commit-msg', 'npx --no -- commitlint --edit "$1"');
 
 // ── 6. package.json mutations ─────────────────────────────────────────────────
@@ -157,7 +148,7 @@ if (!pkg['lint-staged']) {
   ok('Added lint-staged config to package.json');
 }
 
-// devDependencies — add husky, lint-staged, commitlint, and jira hook if missing.
+// devDependencies — add husky, lint-staged, and commitlint if missing.
 pkg.devDependencies ??= {};
 const devDepsToAdd = [
   ['husky', '^9.0.0'],

package/bin/gate-start.mjs

@@ -3,22 +3,18 @@
  * gate-start — Developer session initialiser.
  *
  * 1. Verifies @final-commerce/common in node_modules matches latest registry release.
- * 2. Prompts for (or accepts via arg/env) a Jira ticket ID.
  *
- * Branch checkout is handled by the tasks-manager workspace tooling.
+ * Branch checkout and ticket tracking are handled by the tasks-manager workspace tooling.
  *
  * Usage:
- *   gate-start [TICKET-ID]
- *   JIRA_TICKET_ID=FI-1234 gate-start
+ *   gate-start
  */
 
 import { spawnSync } from 'node:child_process';
-import { createInterface } from 'node:readline';
 import { existsSync, readFileSync } from 'node:fs';
 import { resolve } from 'node:path';
 
 const PKG_NAME = '@final-commerce/common';
-const TICKET_RE = /^[A-Z]+-\d+$/;
 
 // ── helpers ──────────────────────────────────────────────────────────────────
 
@@ -39,16 +35,6 @@ function ok(msg) {
   process.stdout.write(`\x1b[32m✔  ${msg}\x1b[0m\n`);
 }
 
-function ask(question) {
-  return new Promise((resolve) => {
-    const rl = createInterface({ input: process.stdin, output: process.stdout });
-    rl.question(question, (answer) => {
-      rl.close();
-      resolve(answer.trim());
-    });
-  });
-}
-
 // ── 1. upstream version check ─────────────────────────────────────────────────
 
 info(`Checking ${PKG_NAME} upstream version…`);
@@ -84,18 +70,4 @@ if (localVersion !== latestVersion) {
   );
 }
 
-ok(`${PKG_NAME}@${localVersion} is current.`);
-
-// ── 2. Jira ticket ID ─────────────────────────────────────────────────────────
-
-let ticketId = (process.env.JIRA_TICKET_ID ?? process.argv[2] ?? '').toUpperCase();
-
-if (!ticketId) {
-  ticketId = (await ask('\nJira ticket ID (e.g. FI-1234): ')).toUpperCase();
-}
-
-if (!TICKET_RE.test(ticketId)) {
-  fail(`"${ticketId}" is not a valid Jira ticket ID. Expected format: PROJECT-123`);
-}
-
-ok(`Ticket ${ticketId} confirmed. Ready to work.`);
+ok(`${PKG_NAME}@${localVersion} is current. Ready to work.`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@final-commerce/common",
-  "version": "2.0.16",
+  "version": "2.0.18-beta.1",
   "description": "Shared utilities, types, constants, and engineering governance configs for the Final Commerce platform.",
   "homepage": "https://github.com/Final-Commerce/common#readme",
   "bugs": {

package/bin/prepare-commit-msg.sh

@@ -1,16 +0,0 @@
-#!/usr/bin/env sh
-
-BRANCH=$(git symbolic-ref --short HEAD 2>/dev/null)
-if [ -z "$BRANCH" ]; then exit 0; fi
-
-# Skip protected branches
-if echo "$BRANCH" | grep -qE '^(main|master|develop|pre-prod|release-staging.*)$'; then exit 0; fi
-
-TICKET=$(echo "$BRANCH" | grep -oE '[A-Z]+-[0-9]+' | head -1)
-if [ -z "$TICKET" ]; then exit 0; fi
-
-MSG_FILE="$1"
-CURRENT=$(cat "$MSG_FILE")
-if echo "$CURRENT" | grep -q "$TICKET"; then exit 0; fi
-
-awk -v ticket="[$TICKET]" 'NR==1{print $0 " " ticket; next}{print}' "$MSG_FILE" > "$MSG_FILE.tmp" && mv "$MSG_FILE.tmp" "$MSG_FILE"