@final-commerce/command-frame 0.6.0-staging3.2 → 0.6.0-staging3.4

package/dist/CommonTypes.d.ts

@@ -1,5 +1,5 @@
 export * from './common-types';
-import type { Tax, Tip, Address, MetadataItem, PosDataItem, CartFeeTaxEntry, CartFeeItem, CartDiscountItem, OrderNote, NonRevenueItem, DiscountDetail, FeeDetail, DiscountLineItem, FeeLineItem, LineItem, TipPayment, RefundedTipPayment, PaymentMethod, Discount, CustomFee, Summary, CustomSale, RefundedCustomSale, RefundItem, RefundedLineItem, ActiveStation, ActiveSession, ActiveOutlet, ActiveUser, ActiveUserRole, ActiveOrder, ActiveCart, ActivePark, ActiveCompany, ActiveCustomSales, ActiveProduct, ActiveCustomer, FullProduct, ProductVariant, Inventory, ResolvedModifier, ResolvedModifierChoice, ModifierSelectionType, ModifierSelection, ModifierChoiceSelection, OrderLineItemModifier, CustomerNote, Attribute, AttributeOption, Category, Transaction, ActiveSplitPayment } from '@final-commerce/common/pos-types';
+import type { Tax, Tip, Address, MetadataItem, PosDataItem, CartFeeTaxEntry, CartFeeItem, CartDiscountItem, OrderNote, NonRevenueItem, DiscountDetail, FeeDetail, DiscountLineItem, FeeLineItem, LineItem, TipPayment, RefundedTipPayment, PaymentMethod, Discount, CustomFee, Summary, CustomSale, RefundedCustomSale, RefundItem, RefundedLineItem, ActiveStation, ActiveSession, ActiveOutlet, ActiveUser, ActiveUserRole, ActiveOrder, ActiveCart, ActivePark, ActiveCompany, ActiveCustomSales, ActiveProduct, ActiveCustomer, FullProduct, ProductVariant, Inventory, ResolvedModifier, ResolvedModifierChoice, ModifierSelectionType, ModifierSelection, ModifierChoiceSelection, CartLineModifier, OrderLineItemModifier, CustomerNote, Attribute, AttributeOption, Category, Transaction, ActiveSplitPayment } from '@final-commerce/common/pos-types';
 export { CurrencyCode, ProductType as CFProductType, UserTypes as CFUserTypes } from '@final-commerce/common';
 /** Open record used as a base for active entities. */
 export type CFActiveEntity = Record<string, unknown>;
@@ -27,6 +27,8 @@ export type CFOrderLineItemModifier = OrderLineItemModifier;
 /** Cart-line modifier answer (pre-pricing) — `CFActiveProduct.modifierSelections`. */
 export type CFModifierSelection = ModifierSelection;
 export type CFModifierChoiceSelection = ModifierChoiceSelection;
+/** One selected choice PRICED onto a cart line — `CFActiveProduct.modifiers` (not the resolved stack). */
+export type CFCartLineModifier = CartLineModifier;
 export type CFActiveProduct = ActiveProduct;
 export type CFCustomer = ActiveCustomer;
 export type CFActiveCustomer = ActiveCustomer;

package/dist/actions/add-product-to-cart/mock.js

@@ -1,4 +1,4 @@
-import { MOCK_CART, MOCK_PRODUCTS, mockPublishEvent } from '../../demo/database';
+import { MOCK_CART, MOCK_PRODUCTS, buildCartLineModifiers, mockPublishEvent } from '../../demo/database';
 import { extendPrice, isValidQuantity, resolveUnit } from '@final-commerce/common';
 export const mockAddProductToCart = async (params) => {
     console.log('[Mock] addProductToCart called', params);
@@ -53,11 +53,17 @@ export const mockAddProductToCart = async (params) => {
         note: note,
         // discount/fee could be added here to mock object if CFActiveProduct supports it
     };
-    // Mock modifier handling: echo selections onto the line; a real host resolves the
-    // product's modifiers, validates required/min/max in units, and prices each choice
-    // (fee-level money: not in grossSales, not reduced by the product discount).
+    // The spread above copied the PRODUCT's `modifiers` — a ResolvedModifier[] menu — into a
+    // field that means "the choices this line carries" (CartLineModifier[]). Two different
+    // shapes, one name. Drop it before anything reads the line, or every surface renders the
+    // whole catalogue as if the cashier had picked all of it.
+    delete activeProduct.modifiers;
+    // Keep the raw answers AND the priced rows, the same pair the real host writes. The cart
+    // TOTAL is deliberately left alone: like a product fee (see add-product-fee), per-line
+    // money is not accumulated by this mock — `total` stays Σ extendPrice(price, quantity).
     if (params?.modifiers?.length) {
         activeProduct.modifierSelections = params.modifiers;
+        activeProduct.modifiers = buildCartLineModifiers(product.modifiers, params.modifiers, product.taxTable);
     }
     MOCK_CART.products.push(activeProduct);
     // Recalculate totals. extendPrice, not a raw multiply: a fractional quantity times an

package/dist/actions/set-product-modifier-selections/mock.js

@@ -1,4 +1,4 @@
-import { MOCK_CART } from "../../demo/database";
+import { MOCK_CART, MOCK_PRODUCTS, buildCartLineModifiers } from "../../demo/database";
 export const mockSetProductModifierSelections = async (params) => {
     console.log("[Mock] setProductModifierSelections called", params);
     if (!params?.selections) {
@@ -11,7 +11,9 @@ export const mockSetProductModifierSelections = async (params) => {
         };
     }
     // Write the selections onto the mock cart line (last line when no internalId).
-    // The mock does not re-run rule validation or repricing — the real host does.
+    // The mock does not re-run rule VALIDATION — the real host does — but it does reprice,
+    // because a replacement that left the old rows and the old money behind would make the
+    // cart disagree with itself the moment a cashier edits a line.
     const line = params.internalId
         ? MOCK_CART.products.find((p) => p.internalId === params.internalId)
         : MOCK_CART.products[MOCK_CART.products.length - 1];
@@ -24,7 +26,13 @@ export const mockSetProductModifierSelections = async (params) => {
             timestamp: new Date().toISOString()
         };
     }
+    // Full replacement — passing [] clears the rows. The line drops the product's resolved
+    // stack when it is built, so the menu is re-read from the catalogue to price against.
+    // Cart totals are not touched, for the same reason addProductToCart does not move them
+    // for modifiers: this mock does not accumulate per-line money.
+    const source = MOCK_PRODUCTS.find((product) => product._id === line.id);
     line.modifierSelections = params.selections;
+    line.modifiers = buildCartLineModifiers(source?.modifiers, params.selections, source?.taxTable);
     return {
         success: true,
         internalId: line.internalId,

package/dist/demo/database.d.ts

@@ -2,7 +2,7 @@
  * Mock Database for Standalone/Demo Mode
  * Stores mock data that mimics the Render environment
  */
-import { CFActiveCompany, CFActiveUser, CFActiveStation, CFActiveOutlet, CFActiveOrder, CFCustomer, CFProduct, CFActiveCart, CFCategory, CFActiveProduct, CFSession, CFActiveRefundDetails, CFSmartGridLayout } from '../CommonTypes';
+import { CFActiveCompany, CFActiveUser, CFActiveStation, CFActiveOutlet, CFActiveOrder, CFCustomer, CFProduct, CFActiveCart, CFCategory, CFActiveProduct, CFSession, CFActiveRefundDetails, CFSmartGridLayout, CFCartLineModifier, CFModifierSelection, CFResolvedModifier } from '../CommonTypes';
 export * from './mocks';
 /** Replace mock catalog / context data in place (same array references mock handlers use). */
 export interface MockDatabaseConfig {
@@ -87,3 +87,21 @@ export declare const createOrderFromCart: (paymentType: string, amount: number,
  * open with `amountToBeCharged` reset to what's left, and returns null.
  */
 export declare const applyMockPayment: (amount: number, paymentType: string, processor?: string) => CFActiveOrder | null;
+/**
+ * Price the cashier's raw modifier answers into the rows a CART line carries (FT-0010).
+ *
+ * Here rather than in an action folder because two mocks need it — addProductToCart and
+ * setProductModifierSelections — and this module is already where the shared mock helpers
+ * live (`safeSerialize`, `resetMockCart`, `mockPublishEvent`).
+ *
+ * Note the two shapes that share the name `modifiers` and are NOT interchangeable:
+ * `FullProduct.modifiers` is `ResolvedModifier[]` (the menu — question + every choice),
+ * `ActiveProduct.modifiers` is `CartLineModifier[]` (one row per CHOSEN choice). The mock
+ * builds a cart line by spreading the product, so the menu must be stripped off the line
+ * before anything reads it, or every surface renders the catalogue as if it were picked.
+ *
+ * Names and unitPrice are snapshotted, as the real host does — a later rename never
+ * rewrites an open cart. No `total`: a cart row is per line UNIT, and the host extends it.
+ * Rule validation (required/min/max) is deliberately not mocked; the real host owns it.
+ */
+export declare const buildCartLineModifiers: (menu: CFResolvedModifier[] | undefined, selections: CFModifierSelection[] | undefined, productTaxTableId?: string) => CFCartLineModifier[];

package/dist/demo/database.js

@@ -914,3 +914,51 @@ export const applyMockPayment = (amount, paymentType, processor = 'cash') => {
     mockPublishEvent('payments', 'payment-done', { order });
     return order;
 };
+/**
+ * Price the cashier's raw modifier answers into the rows a CART line carries (FT-0010).
+ *
+ * Here rather than in an action folder because two mocks need it — addProductToCart and
+ * setProductModifierSelections — and this module is already where the shared mock helpers
+ * live (`safeSerialize`, `resetMockCart`, `mockPublishEvent`).
+ *
+ * Note the two shapes that share the name `modifiers` and are NOT interchangeable:
+ * `FullProduct.modifiers` is `ResolvedModifier[]` (the menu — question + every choice),
+ * `ActiveProduct.modifiers` is `CartLineModifier[]` (one row per CHOSEN choice). The mock
+ * builds a cart line by spreading the product, so the menu must be stripped off the line
+ * before anything reads it, or every surface renders the catalogue as if it were picked.
+ *
+ * Names and unitPrice are snapshotted, as the real host does — a later rename never
+ * rewrites an open cart. No `total`: a cart row is per line UNIT, and the host extends it.
+ * Rule validation (required/min/max) is deliberately not mocked; the real host owns it.
+ */
+export const buildCartLineModifiers = (menu, selections, productTaxTableId) => {
+    if (!menu?.length || !selections?.length)
+        return [];
+    const byModifier = new Map(menu.map((modifier) => [modifier._id, modifier]));
+    const rows = [];
+    for (const selection of selections) {
+        const modifier = byModifier.get(selection.modifierId);
+        if (!modifier)
+            continue;
+        const byChoice = new Map(modifier.choices.map((choice) => [choice._id, choice]));
+        for (const picked of selection.choices ?? []) {
+            const choice = byChoice.get(picked.choiceId);
+            // `quantity` is units per ONE line unit; 0 means "not chosen" and carries no row.
+            if (!choice || !(picked.quantity > 0))
+                continue;
+            rows.push({
+                modifierId: modifier._id,
+                modifierName: modifier.name,
+                choiceId: choice._id,
+                choiceName: choice.name,
+                // The cart's display label, like CustomFee.label — "Toppings - Avocado".
+                label: `${modifier.name} - ${choice.name}`,
+                unitPrice: choice.price,
+                quantity: picked.quantity,
+                // Modifier tax follows the parent product's table, as a fee's does.
+                ...(productTaxTableId ? { taxTableId: productTaxTableId } : {}),
+            });
+        }
+    }
+    return rows;
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@final-commerce/command-frame",
-  "version": "0.6.0-staging3.2",
+  "version": "0.6.0-staging3.4",
   "description": "Commands Frame library",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -57,7 +57,7 @@
     "ignoreBranchesMissingTickets": true
   },
   "dependencies": {
-    "@final-commerce/common": "2.2.3-staging3.2"
+    "@final-commerce/common": "2.2.3-staging3.3"
   },
   "devDependencies": {
     "@commitlint/cli": "^19.0.0",