@final-commerce/command-frame 0.11.0-preprod.1 → 0.11.0-preprod.3

package/dist/actions/void-order/mock.js

@@ -1,17 +1,27 @@
 import { MOCK_ORDERS, mockPublishEvent } from '../../demo/database';
-// Payment states in which an order is still open — mirrors the runtime gate
-// (kaching's OPEN_PAYMENT_STATES / handler.ts). Anything outside this set
-// (paid, partially_refunded, refunded, voided, or unknown) is ORDER_NOT_VOIDABLE.
+// Mirrors the runtime gate (kaching's void-order/handler.ts): an order is
+// voidable while it is still OPEN, or when it is PAID but was never fulfilled
+// (still in the kitchen). Anything else (a handed-over paid order,
+// partially_refunded, refunded, voided, or unknown) is ORDER_NOT_VOIDABLE.
 const OPEN_PAYMENT_STATES = ['unpaid', 'payment_pending', 'partially_paid'];
+const UNFULFILLED_STATES = ['draft', 'pending', 'on_hold'];
+// No orderId means the order in the cart, never just any order: the runtime refuses an
+// id-less void unless the order is the live cart's (a finished sale kept for receipts is
+// not), and a legacy order with no cart flag counts only while it is still open. The demo
+// has no stations, so the flag alone decides.
+const isCartOrder = (o) => o.inCart != null
+    ? o.inCart.active
+    : OPEN_PAYMENT_STATES.includes(o.paymentState) &&
+        (o.fulfillmentState ? o.fulfillmentState === 'draft' : o.status === 'in-cart');
 export const mockVoidOrder = async (params) => {
     console.log('[Mock] voidOrder called', params);
-    const order = params?.orderId ? MOCK_ORDERS.find((o) => o._id === params.orderId) : MOCK_ORDERS[0];
+    const order = params?.orderId ? MOCK_ORDERS.find((o) => o._id === params.orderId) : MOCK_ORDERS.find(isCartOrder);
     if (!order) {
-        throw new Error(`Order with ID ${params?.orderId} not found`);
+        throw new Error(params?.orderId ? `Order with ID ${params.orderId} not found` : 'No order selected. Please provide orderId.');
     }
     const orderId = order._id;
-    // Only OPEN orders are voidable — mirror the runtime gate.
-    if (!OPEN_PAYMENT_STATES.includes(order.paymentState)) {
+    const paidUnfulfilled = order.paymentState === 'paid' && UNFULFILLED_STATES.includes(order.fulfillmentState);
+    if (!OPEN_PAYMENT_STATES.includes(order.paymentState) && !paidUnfulfilled) {
         throw new Error(`ORDER_NOT_VOIDABLE: order ${orderId} is '${order.paymentState}' — use the refund flow for completed orders`);
     }
     const hasCapturedLegs = (order.paymentMethods?.length ?? 0) > 0;

package/dist/actions/void-order/types.d.ts

@@ -1,6 +1,9 @@
 export type VoidOrderOutcome = 'voided' | 'refunded';
 export interface VoidOrderParams {
-    /** Order to void; defaults to the active order. */
+    /**
+     * Order to void. Omit for the live cart's order (resumed, or part-paid). A finished
+     * sale kept for receipts after payment is not the cart's order — pass its id.
+     */
     orderId?: string;
     /**
      * Optional cashier-facing reason. Recorded on both branches — the void audit
@@ -15,7 +18,8 @@ export interface VoidOrderResponse {
     orderId: string;
     /**
      * `voided`   — nothing was captured; pure state transition to voided × cancelled.
-     * `refunded` — captured split legs were refunded to their original tenders;
+     * `refunded` — captured payments (a deposit / split legs, or the whole
+     *              payment of a paid order never fulfilled) were refunded to their original tenders;
      *              order lands refunded × cancelled (financially equivalent to a
      *              void, but the capture + payout stay on the audit trail).
      */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@final-commerce/command-frame",
-  "version": "0.11.0-preprod.1",
+  "version": "0.11.0-preprod.3",
   "description": "Commands Frame library",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -57,7 +57,7 @@
     "ignoreBranchesMissingTickets": true
   },
   "dependencies": {
-    "@final-commerce/common": "2.7.0-preprod.1"
+    "@final-commerce/common": "2.8.0-preprod.2"
   },
   "devDependencies": {
     "@commitlint/cli": "^19.0.0",