@fin.cx/skr 1.2.1 → 1.2.2

package/readme.plan.md

@@ -18,7 +18,7 @@ TypeScript module implementing SKR03 and SKR04 German accounting standards for d
   - [ ] @push.rocks/smartdata
   - [ ] @git.zone/tstest (dev dependency)
 - [ ] Create tsconfig.json based on @push.rocks/smarthash pattern
-- [ ] Create npmextra.json for additional configuration
+- [ ] Create .smartconfig.json for additional configuration
 - [ ] Create .gitignore file
 - [ ] Create directory structure
   - [ ] ts/ directory for source code

package/ts/00_commitinfo_data.ts

@@ -3,6 +3,6 @@
  */
 export const commitinfo = {
   name: '@fin.cx/skr',
-  version: '1.2.1',
+  version: '1.2.2',
   description: 'SKR03 and SKR04 German accounting standards for double-entry bookkeeping'
 }

package/ts/index.ts

@@ -1,16 +1,44 @@
 export * from './skr.types.js';
-export * from './skr.classes.account.js';
-export * from './skr.classes.transaction.js';
-export * from './skr.classes.journalentry.js';
-export * from './skr.classes.chartofaccounts.js';
-export * from './skr.classes.ledger.js';
-export * from './skr.classes.reports.js';
-export * from './skr.api.js';
-export * from './skr03.data.js';
-export * from './skr04.data.js';
-export * from './skr.export.js';
-export * from './skr.export.ledger.js';
-export * from './skr.export.accounts.js';
-export * from './skr.export.balances.js';
-export * from './skr.export.pdf.js';
-export * from './skr.security.js';
+export { Account } from './skr.classes.account.js';
+export { Transaction } from './skr.classes.transaction.js';
+export { JournalEntry } from './skr.classes.journalentry.js';
+export { ChartOfAccounts } from './skr.classes.chartofaccounts.js';
+export { Ledger } from './skr.classes.ledger.js';
+export { Reports } from './skr.classes.reports.js';
+export { SkrApi } from './skr.api.js';
+export { SKR03_ACCOUNTS, SKR03_ACCOUNT_CLASSES } from './skr03.data.js';
+export { SKR04_ACCOUNTS, SKR04_ACCOUNT_CLASSES } from './skr04.data.js';
+export { SkrExport } from './skr.export.js';
+export type {
+  IExportOptions,
+  IExportMetadata,
+  IBagItManifest,
+  IDocumentIndex,
+} from './skr.export.js';
+export { LedgerExporter } from './skr.export.ledger.js';
+export type {
+  ITransactionDataExport,
+  IJournalEntryExport,
+  IJournalEntryLineExport,
+  ILedgerEntry,
+  ILedgerLine,
+  IDocumentRef,
+} from './skr.export.ledger.js';
+export { AccountsExporter } from './skr.export.accounts.js';
+export type {
+  IAccountDataExport,
+  IAccountExportRow,
+} from './skr.export.accounts.js';
+export { BalancesExporter } from './skr.export.balances.js';
+export type {
+  IAccountBalanceExport,
+  IBalanceExportRow,
+} from './skr.export.balances.js';
+export { PdfReportGenerator } from './skr.export.pdf.js';
+export type { IPdfReportOptions } from './skr.export.pdf.js';
+export { SecurityManager } from './skr.security.js';
+export type {
+  ISigningOptions,
+  ISignatureResult,
+  ITimestampResponse,
+} from './skr.security.js';

package/ts/plugins.ts

@@ -3,26 +3,63 @@ import * as smartdata from '@push.rocks/smartdata';
 import * as smartunique from '@push.rocks/smartunique';
 import * as smarttime from '@push.rocks/smarttime';
 import * as smartlog from '@push.rocks/smartlog';
-import * as smartfile from '@push.rocks/smartfile';
+import * as smartfsModule from '@push.rocks/smartfs';
 import * as smarthash from '@push.rocks/smarthash';
 import * as smartpath from '@push.rocks/smartpath';
-import * as smartpdf from '@push.rocks/smartpdf';
+import * as path from 'path';
 
 // third party
-import * as nodeForge from 'node-forge';
 import { MerkleTree } from 'merkletreejs';
-import * as einvoice from '@fin.cx/einvoice';
 
-export { 
-  smartdata, 
-  smartunique, 
-  smarttime, 
-  smartlog, 
-  smartfile, 
-  smarthash, 
-  smartpath, 
-  smartpdf,
-  nodeForge,
+const smartfs = new smartfsModule.SmartFs(
+  new smartfsModule.SmartFsProviderNode(),
+);
+
+const smartfile = {
+  fs: {
+    ensureDir: async (dirPath: string): Promise<void> => {
+      await smartfs.directory(dirPath).create();
+    },
+    toBuffer: async (filePath: string): Promise<Buffer> => {
+      return (await smartfs.file(filePath).read()) as Buffer;
+    },
+    toStringSync: async (filePath: string): Promise<string> => {
+      return (await smartfs.file(filePath).encoding('utf8').read()) as string;
+    },
+    fileExists: async (filePath: string): Promise<boolean> => {
+      return await smartfs.file(filePath).exists();
+    },
+    listFileTree: async (dirPath: string, pattern: string): Promise<string[]> => {
+      const suffix = pattern.replace(/^\*\*\/\*/, '');
+      try {
+        const entries = await smartfs.directory(dirPath).recursive().list();
+        return entries
+          .filter((entry) => entry.isFile && entry.path.endsWith(suffix))
+          .map((entry) => path.relative(dirPath, entry.path));
+      } catch (error) {
+        if (error instanceof Error && error.message.includes('ENOENT')) {
+          return [];
+        }
+        throw error;
+      }
+    },
+  },
+  memory: {
+    toFs: async (content: string | Buffer, filePath: string): Promise<void> => {
+      await smartfs.directory(path.dirname(filePath)).create();
+      await smartfs.file(filePath).write(content);
+    },
+  },
+};
+
+export {
+  smartdata,
+  smartunique,
+  smarttime,
+  smartlog,
+  smartfs,
+  smartfile,
+  smarthash,
+  smartpath,
   MerkleTree,
-  einvoice
 };

package/ts/skr.api.ts

@@ -534,6 +534,10 @@ export class SkrApi {
    */
   private async generatePdfReports(exporter: SkrExport, options: IExportOptions): Promise<void> {
     if (!this.reports) throw new Error('Reports not initialized');
+    const skrType = this.currentSKRType;
+    if (!skrType) {
+      throw new Error('API not initialized. Call initialize() first.');
+    }
 
     const pdfOptions: IPdfReportOptions = {
       companyName: options.companyInfo?.name || 'Unternehmen',
@@ -554,19 +558,19 @@ export class SkrApi {
       const trialBalance = await this.reports.getTrialBalance({
         dateFrom: options.dateFrom,
         dateTo: options.dateTo,
-        skrType: this.currentSKRType
+        skrType,
       });
 
       const incomeStatement = await this.reports.getIncomeStatement({
         dateFrom: options.dateFrom,
         dateTo: options.dateTo,
-        skrType: this.currentSKRType
+        skrType,
       });
 
       const balanceSheet = await this.reports.getBalanceSheet({
         dateFrom: options.dateFrom,
         dateTo: options.dateTo,
-        skrType: this.currentSKRType
+        skrType,
       });
 
       // Generate PDFs
@@ -702,7 +706,7 @@ export class SkrApi {
         const transaction = await this.postTransaction(transactions[i]);
         results.push(transaction);
       } catch (error) {
-        errors.push({ index: i, error: error.message });
+        errors.push({ index: i, error: error instanceof Error ? error.message : String(error) });
       }
     }
 
@@ -735,7 +739,7 @@ export class SkrApi {
         const account = await this.createAccount(accounts[i]);
         results.push(account);
       } catch (error) {
-        errors.push({ index: i, error: error.message });
+        errors.push({ index: i, error: error instanceof Error ? error.message : String(error) });
       }
     }
 

package/ts/skr.classes.account.ts

@@ -2,68 +2,86 @@ import * as plugins from './plugins.js';
 import { getDb, getDbSync } from './skr.database.js';
 import type { TAccountType, TSKRType, IAccountData } from './skr.types.js';
 
-const { SmartDataDbDoc, svDb, unI, index, searchable } = plugins.smartdata;
+declare abstract class SmartDataDbDocBase {
+  public save(): Promise<void>;
+  public delete(): Promise<void>;
+  public static getInstance<T>(
+    this: new (...args: any[]) => T,
+    query: Record<string, any>,
+  ): Promise<T | null>;
+  public static getInstances<T>(
+    this: new (...args: any[]) => T,
+    query: Record<string, any>,
+  ): Promise<T[]>;
+}
+
+const SmartDataDbDoc = plugins.smartdata.SmartDataDbDoc as unknown as typeof SmartDataDbDocBase;
+const Collection = plugins.smartdata.Collection as any;
+const svDb = plugins.smartdata.svDb as any;
+const unI = plugins.smartdata.unI as any;
+const index = plugins.smartdata.index as any;
+const searchable = plugins.smartdata.searchable as any;
 
-@plugins.smartdata.Collection(() => getDbSync())
-export class Account extends SmartDataDbDoc<Account, Account> {
+@Collection(() => getDbSync())
+export class Account extends SmartDataDbDoc {
   @unI()
-  public id: string;
+  public id!: string;
 
   @svDb()
   @index()
-  public accountNumber: string;
+  public accountNumber!: string;
 
   @svDb()
   @searchable()
-  public accountName: string;
+  public accountName!: string;
 
   @svDb()
   @index()
-  public accountClass: number;
+  public accountClass!: number;
 
   @svDb()
-  public accountGroup: number;
+  public accountGroup!: number;
 
   @svDb()
-  public accountSubgroup: number;
+  public accountSubgroup!: number;
 
   @svDb()
-  public accountType: TAccountType;
+  public accountType!: TAccountType;
 
   @svDb()
   @index()
-  public skrType: TSKRType;
+  public skrType!: TSKRType;
 
   @svDb()
   @searchable()
-  public description: string;
+  public description!: string;
 
   @svDb()
-  public vatRate: number;
+  public vatRate!: number;
 
   @svDb()
-  public balance: number;
+  public balance!: number;
 
   @svDb()
-  public debitTotal: number;
+  public debitTotal!: number;
 
   @svDb()
-  public creditTotal: number;
+  public creditTotal!: number;
 
   @svDb()
-  public isActive: boolean;
+  public isActive!: boolean;
 
   @svDb()
-  public isSystemAccount: boolean;
+  public isSystemAccount!: boolean;
 
   @svDb()
-  public isAutomaticAccount: boolean;
+  public isAutomaticAccount!: boolean;
 
   @svDb()
-  public createdAt: Date;
+  public createdAt!: Date;
 
   @svDb()
-  public updatedAt: Date;
+  public updatedAt!: Date;
 
   constructor(data?: Partial<IAccountData>) {
     super();

package/ts/skr.classes.chartofaccounts.ts

@@ -262,6 +262,9 @@ export class ChartOfAccounts {
    * Search accounts
    */
   public async searchAccounts(searchTerm: string): Promise<Account[]> {
+    if (!this.skrType) {
+      throw new Error('SKR type not set. Initialize SKR03 or SKR04 first.');
+    }
     return await Account.searchAccounts(searchTerm, this.skrType);
   }
 
@@ -287,10 +290,11 @@ export class ChartOfAccounts {
 
     // Apply text search if provided
     if (filter?.searchTerm) {
-      const lowerSearchTerm = filter.searchTerm.toLowerCase();
+      const searchTerm = filter.searchTerm;
+      const lowerSearchTerm = searchTerm.toLowerCase();
       return accounts.filter(
         (account) =>
-          account.accountNumber.includes(filter.searchTerm) ||
+          account.accountNumber.includes(searchTerm) ||
           account.accountName.toLowerCase().includes(lowerSearchTerm) ||
           account.description.toLowerCase().includes(lowerSearchTerm),
       );
@@ -468,9 +472,10 @@ export class ChartOfAccounts {
           await this.createCustomAccount(accountData);
           importedCount++;
         } catch (error) {
+          const errorMessage = error instanceof Error ? error.message : String(error);
           this.logger.log(
             'warn',
-            `Failed to import account ${parts[0]}: ${error.message}`,
+            `Failed to import account ${parts[0]}: ${errorMessage}`,
           );
         }
       }

package/ts/skr.classes.journalentry.ts

@@ -13,67 +13,85 @@ import type {
   IJournalEntryLine,
 } from './skr.types.js';
 
-const { SmartDataDbDoc, svDb, unI, index, searchable } = plugins.smartdata;
+declare abstract class SmartDataDbDocBase {
+  public save(): Promise<void>;
+  public delete(): Promise<void>;
+  public static getInstance<T>(
+    this: new (...args: any[]) => T,
+    query: Record<string, any>,
+  ): Promise<T | null>;
+  public static getInstances<T>(
+    this: new (...args: any[]) => T,
+    query: Record<string, any>,
+  ): Promise<T[]>;
+}
+
+const SmartDataDbDoc = plugins.smartdata.SmartDataDbDoc as unknown as typeof SmartDataDbDocBase;
+const Collection = plugins.smartdata.Collection as any;
+const svDb = plugins.smartdata.svDb as any;
+const unI = plugins.smartdata.unI as any;
+const index = plugins.smartdata.index as any;
+const searchable = plugins.smartdata.searchable as any;
 
-@plugins.smartdata.Collection(() => getDbSync())
-export class JournalEntry extends SmartDataDbDoc<JournalEntry, JournalEntry> {
+@Collection(() => getDbSync())
+export class JournalEntry extends SmartDataDbDoc {
   @unI()
-  public id: string;
+  public id!: string;
 
   @svDb()
   @index()
-  public journalNumber: string;
+  public journalNumber!: string;
 
   @svDb()
   @index()
-  public date: Date;
+  public date!: Date;
 
   @svDb()
   @searchable()
-  public description: string;
+  public description!: string;
 
   @svDb()
   @index()
-  public reference: string;
+  public reference!: string;
 
   @svDb()
-  public lines: IJournalEntryLine[];
+  public lines!: IJournalEntryLine[];
 
   @svDb()
   @index()
-  public skrType: TSKRType;
+  public skrType!: TSKRType;
 
   @svDb()
-  public totalDebits: number;
+  public totalDebits!: number;
 
   @svDb()
-  public totalCredits: number;
+  public totalCredits!: number;
 
   @svDb()
-  public isBalanced: boolean;
+  public isBalanced!: boolean;
 
   @svDb()
   @index()
-  public status: 'draft' | 'posted' | 'reversed';
+  public status!: 'draft' | 'posted' | 'reversed';
 
   @svDb()
-  public transactionIds: string[];
+  public transactionIds!: string[];
 
   @svDb()
   @index()
-  public period: string;
+  public period!: string;
 
   @svDb()
-  public fiscalYear: number;
+  public fiscalYear!: number;
 
   @svDb()
-  public createdAt: Date;
+  public createdAt!: Date;
 
   @svDb()
-  public postedAt: Date;
+  public postedAt!: Date | null;
 
   @svDb()
-  public createdBy: string;
+  public createdBy!: string;
 
   constructor(data?: Partial<IJournalEntry>) {
     super();
@@ -240,7 +258,7 @@ export class JournalEntry extends SmartDataDbDoc<JournalEntry, JournalEntry> {
       try {
         await Account.validateAccountForPosting(line.accountNumber, this.skrType);
       } catch (error) {
-        validationErrors.push(error.message);
+        validationErrors.push(error instanceof Error ? error.message : String(error));
         continue; // Skip further validation for this line
       }
 
@@ -329,7 +347,7 @@ export class JournalEntry extends SmartDataDbDoc<JournalEntry, JournalEntry> {
         date: this.date,
         debitAccount: debitLines[0].accountNumber,
         creditAccount: creditLines[0].accountNumber,
-        amount: debitLines[0].debit,
+        amount: debitLines[0].debit || 0,
         description: this.description,
         reference: this.reference,
         skrType: this.skrType,

package/ts/skr.classes.reports.ts

@@ -410,7 +410,20 @@ export class Reports {
       isActive: true,
     });
 
-    const ledgerEntries = [];
+    const ledgerEntries: Array<{
+      accountNumber: string;
+      accountName: string;
+      accountType: string;
+      entries: Array<{
+        date: Date;
+        reference: string;
+        description: string;
+        debit: number;
+        credit: number;
+        balance: number;
+      }>;
+      finalBalance: number;
+    }> = [];
 
     for (const account of accounts) {
       const transactions = await this.getAccountTransactions(
@@ -420,7 +433,14 @@ export class Reports {
 
       if (transactions.length > 0) {
         let runningBalance = 0;
-        const accountEntries = [];
+        const accountEntries: Array<{
+          date: Date;
+          reference: string;
+          description: string;
+          debit: number;
+          credit: number;
+          balance: number;
+        }> = [];
 
         for (const transaction of transactions) {
           const isDebit = transaction.debitAccount === account.accountNumber;

package/ts/skr.classes.transaction.ts

@@ -7,75 +7,93 @@ import type {
   ITransactionData,
 } from './skr.types.js';
 
-const { SmartDataDbDoc, svDb, unI, index, searchable } = plugins.smartdata;
+declare abstract class SmartDataDbDocBase {
+  public save(): Promise<void>;
+  public delete(): Promise<void>;
+  public static getInstance<T>(
+    this: new (...args: any[]) => T,
+    query: Record<string, any>,
+  ): Promise<T | null>;
+  public static getInstances<T>(
+    this: new (...args: any[]) => T,
+    query: Record<string, any>,
+  ): Promise<T[]>;
+}
+
+const SmartDataDbDoc = plugins.smartdata.SmartDataDbDoc as unknown as typeof SmartDataDbDocBase;
+const Collection = plugins.smartdata.Collection as any;
+const svDb = plugins.smartdata.svDb as any;
+const unI = plugins.smartdata.unI as any;
+const index = plugins.smartdata.index as any;
+const searchable = plugins.smartdata.searchable as any;
 
-@plugins.smartdata.Collection(() => getDbSync())
-export class Transaction extends SmartDataDbDoc<Transaction, Transaction> {
+@Collection(() => getDbSync())
+export class Transaction extends SmartDataDbDoc {
   @unI()
-  public id: string;
+  public id!: string;
 
   @svDb()
   @index()
-  public transactionNumber: string;
+  public transactionNumber!: string;
 
   @svDb()
   @index()
-  public date: Date;
+  public date!: Date;
 
   @svDb()
   @index()
-  public debitAccount: string;
+  public debitAccount!: string;
 
   @svDb()
   @index()
-  public creditAccount: string;
+  public creditAccount!: string;
 
   @svDb()
-  public amount: number;
+  public amount!: number;
 
   @svDb()
   @searchable()
-  public description: string;
+  public description!: string;
 
   @svDb()
   @index()
-  public reference: string;
+  public reference!: string;
 
   @svDb()
   @index()
-  public skrType: TSKRType;
+  public skrType!: TSKRType;
 
   @svDb()
-  public vatAmount: number;
+  public vatAmount!: number;
 
   @svDb()
-  public costCenter: string;
+  public costCenter!: string;
 
   @svDb()
   @index()
-  public status: TTransactionStatus;
+  public status!: TTransactionStatus;
 
   @svDb()
-  public reversalOf: string;
+  public reversalOf!: string;
 
   @svDb()
-  public reversedBy: string;
+  public reversedBy!: string;
 
   @svDb()
   @index()
-  public period: string; // Format: YYYY-MM
+  public period!: string; // Format: YYYY-MM
 
   @svDb()
-  public fiscalYear: number;
+  public fiscalYear!: number;
 
   @svDb()
-  public createdAt: Date;
+  public createdAt!: Date;
 
   @svDb()
-  public postedAt: Date;
+  public postedAt!: Date | null;
 
   @svDb()
-  public createdBy: string;
+  public createdBy!: string;
 
   constructor(data?: Partial<ITransactionData>) {
     super();

package/ts/skr.export.pdf.ts

@@ -1,5 +1,6 @@
 import * as plugins from './plugins.js';
 import * as path from 'path';
+import { SmartPdf } from '@push.rocks/smartpdf';
 import type { ITrialBalanceReport, IIncomeStatement, IBalanceSheet } from './skr.types.js';
 
 export interface IPdfReportOptions {
@@ -17,7 +18,7 @@ export interface IPdfReportOptions {
 export class PdfReportGenerator {
   private exportPath: string;
   private options: IPdfReportOptions;
-  private pdfInstance: plugins.smartpdf.SmartPdf | null = null;
+  private pdfInstance: SmartPdf | null = null;
   
   constructor(exportPath: string, options: IPdfReportOptions) {
     this.exportPath = exportPath;
@@ -28,7 +29,7 @@ export class PdfReportGenerator {
    * Initializes the PDF generator
    */
   public async initialize(): Promise<void> {
-    this.pdfInstance = new plugins.smartpdf.SmartPdf();
+    this.pdfInstance = new SmartPdf();
     await this.pdfInstance.start();
   }
 
@@ -598,4 +599,4 @@ export class PdfReportGenerator {
       this.pdfInstance = null;
     }
   }
-}
+}