@fin.cx/einvoice 9.0.0 → 10.0.0

package/ts/formats/validation/en16931.business-rules.validator.ts

@@ -247,34 +247,9 @@ export class EN16931BusinessRulesValidator {
       );
     }
     
-    // BR-CO-16: Amount due for payment = Invoice total with VAT - Paid amount. The envelope's
-    // paid amount (BT-113) is the one the encoders write; the amount due (BT-115) is compared when
-    // a declared one is at hand (`metadata.amountDue`), since the envelope derives it otherwise
-    const paidAmountValue = invoice.paidAmount ?? 0;
-    const declaredDueValue = invoice.metadata?.amountDue;
-    if (declaredDueValue !== undefined) {
-      const paidAmount = useDecimal ? new Decimal(paidAmountValue) : paidAmountValue;
-      const expectedDueAmount = useDecimal
-        ? (expectedGrossTotal as Decimal).subtract(paidAmount)
-        : (expectedGrossTotal as number) - (paidAmount as number);
-      const declaredDueAmount = useDecimal ? new Decimal(declaredDueValue) : declaredDueValue;
-
-      const isDueEqual = useDecimal
-        ? this.decimalCalculator!.areEqual(expectedDueAmount, declaredDueAmount)
-        : this.currencyCalculator
-          ? this.currencyCalculator.areEqual(expectedDueAmount as number, declaredDueAmount as number)
-          : Math.abs((expectedDueAmount as number) - (declaredDueAmount as number)) < 0.01;
-
-      if (!isDueEqual) {
-        this.addError(
-          'BR-CO-16',
-          `Amount due (${useDecimal ? (declaredDueAmount as Decimal).toFixed(2) : (declaredDueAmount as number).toFixed(2)}) does not match calculation (${useDecimal ? (expectedDueAmount as Decimal).toFixed(2) : (expectedDueAmount as number).toFixed(2)})`,
-          'amountDue',
-          useDecimal ? (declaredDueAmount as Decimal).toNumber() : declaredDueAmount as number,
-          useDecimal ? (expectedDueAmount as Decimal).toNumber() : expectedDueAmount as number
-        );
-      }
-    }
+    // BR-CO-16 (amount due for payment = invoice total with VAT - paid amount) is not checked
+    // here: the envelope has no amount due (BT-115); the encoders derive it from the gross total
+    // and the paid amount (BT-113), and the official rules check it on the written XML
   }
   
   /**

package/ts/formats/validation/facturx.validator.ts

@@ -79,7 +79,7 @@ export class FacturXValidator {
         'dueDate',             // BT-9: Payment due date
       ],
       optional: [
-        'metadata.buyerReference', // BT-10: Buyer reference
+        'buyerReference', // BT-10: Buyer reference
         'metadata.purchaseOrderReference', // BT-13: Purchase order reference
         'metadata.salesOrderReference', // BT-14: Sales order reference
         'metadata.contractReference', // BT-12: Contract reference
@@ -108,7 +108,7 @@ export class FacturXValidator {
         // No items required
       ],
       optional: [
-        'metadata.buyerReference',
+        'buyerReference',
         'metadata.purchaseOrderReference',
         'metadata.contractReference',
       ]
@@ -122,7 +122,7 @@ export class FacturXValidator {
         'issueDate',
         'accountingDocType',
         'currency',
-        'metadata.buyerReference',
+        'buyerReference',
         
         // Seller information
         'from.name',
@@ -411,12 +411,12 @@ export class FacturXValidator {
         
       case FacturXProfile.EN16931:
         // EN16931 requires full compliance - additional checks handled by EN16931 validator
-        if (!invoice.metadata?.buyerReference && !invoice.metadata?.extensions?.purchaseOrderReference) {
+        if (!invoice.buyerReference && !invoice.metadata?.extensions?.purchaseOrderReference) {
           results.push({
             ruleId: 'FX-EN-01',
             severity: 'error',
             message: 'EN16931 profile requires either buyer reference or purchase order reference',
-            field: 'metadata.buyerReference',
+            field: 'buyerReference',
             source: 'FACTURX'
           });
         }

package/ts/formats/validation/integrated.validator.ts

@@ -12,6 +12,7 @@ import { CodeListValidator } from './codelist.validator.js';
 import type { ValidationResult, ValidationOptions, ValidationReport } from './validation.types.js';
 import type { EInvoice } from '../../einvoice.js';
 import { UBL_CUSTOMIZATION_IDS } from '../ubl/ubl.types.js';
+import { isPeppolBisBilling3 } from '../utils/peppol.profile.js';
 
 /**
  * Main validator that combines all validation capabilities
@@ -172,8 +173,7 @@ export class MainValidator {
       return 'XRECHNUNG_3.0';
     }
     
-    if (profileId.includes('peppol') || customizationId.includes('peppol') ||
-        profileId.includes('urn:fdc:peppol.eu')) {
+    if (isPeppolBisBilling3(customizationId)) {
       return 'PEPPOL_BIS_3.0';
     }
     
@@ -215,20 +215,7 @@ export class MainValidator {
    * Check if invoice is PEPPOL
    */
   private isPeppolInvoice(invoice: EInvoice): boolean {
-    const profileId = invoice.metadata?.profileId || '';
-    const customizationId = invoice.metadata?.customizationId || '';
-    
-    const peppolProfiles = [
-      'urn:fdc:peppol.eu:2017:poacc:billing:3.0',
-      'urn:fdc:peppol.eu:2017:poacc:billing:01:1.0',
-      'peppol-bis-3',
-      'peppol'
-    ];
-    
-    return peppolProfiles.some(profile => 
-      profileId.toLowerCase().includes(profile.toLowerCase()) ||
-      customizationId.toLowerCase().includes(profile.toLowerCase())
-    );
+    return isPeppolBisBilling3(invoice.metadata?.customizationId);
   }
   
   /**

package/ts/formats/validation/peppol.validator.ts

@@ -5,6 +5,7 @@
 
 import type { ValidationResult } from './validation.types.js';
 import type { EInvoice } from '../../einvoice.js';
+import { isPeppolBisBilling3 } from '../utils/peppol.profile.js';
 
 /**
  * PEPPOL BIS 3.0 Validator
@@ -50,20 +51,8 @@ export class PeppolValidator {
    * Check if invoice is PEPPOL
    */
   private isPeppolInvoice(invoice: EInvoice): boolean {
-    const profileId = invoice.metadata?.profileId || '';
-    const customizationId = invoice.metadata?.customizationId || '';
-    
-    const peppolProfiles = [
-      'urn:fdc:peppol.eu:2017:poacc:billing:3.0',
-      'urn:fdc:peppol.eu:2017:poacc:billing:01:1.0',
-      'peppol-bis-3',
-      'peppol'
-    ];
-    
-    return peppolProfiles.some(profile => 
-      profileId.toLowerCase().includes(profile.toLowerCase()) ||
-      customizationId.toLowerCase().includes(profile.toLowerCase())
-    );
+    // the PEPPOL BIS Billing 3.0 specification identifier (BT-24), not a derivative that names PEPPOL
+    return isPeppolBisBilling3(invoice.metadata?.customizationId);
   }
   
   /**
@@ -393,12 +382,12 @@ export class PeppolValidator {
     
     // PEPPOL-B-01: Invoice must have a buyer reference or purchase order reference
     const purchaseOrderRef = invoice.metadata?.extensions?.purchaseOrderReference;
-    if (!invoice.metadata?.buyerReference && !purchaseOrderRef) {
+    if (!invoice.buyerReference && !purchaseOrderRef) {
       results.push({
         ruleId: 'PEPPOL-B-01',
         severity: 'error',
         message: 'Invoice must have either a buyer reference (BT-10) or purchase order reference (BT-13)',
-        field: 'metadata.buyerReference',
+        field: 'buyerReference',
         source: 'PEPPOL'
       });
     }

package/ts/formats/validation/validation.types.ts

@@ -2,10 +2,16 @@
  * Enhanced validation types for EN16931 compliance
  */
 
+/**
+ * The source of a check of the package's own, one no official rule set states
+ * (such as `EINVOICE-DE-VATID-FORMAT`), so it is not attributed to a standard
+ */
+export const EINVOICE_RULE_SOURCE = 'EINVOICE';
+
 export interface ValidationResult {
   // Core identification
   ruleId: string;                    // e.g., "BR-CO-14"
-  source: string;                     // e.g., "EN16931", "PEPPOL", "XRECHNUNG"
+  source: string;                     // e.g., "EN16931", "PEPPOL", "XRECHNUNG"; EINVOICE_RULE_SOURCE for a check of the package's own
   severity: 'error' | 'warning' | 'info';
   message: string;