@fin.cx/einvoice 5.1.4 → 5.2.1

package/ts/formats/pdf/extractors/associated.extractor.ts

@@ -1,5 +1,5 @@
-import { PDFDocument, PDFDict, PDFName, PDFRawStream, PDFArray, PDFString } from '../../../plugins.js';
 import { BaseXMLExtractor } from './base.extractor.js';
+import { loadPdfLib } from '../../../vendor/pdflib.js';
 
 /**
  * Associated files extractor for PDF/A-3 documents
@@ -14,6 +14,7 @@ export class AssociatedFilesExtractor extends BaseXMLExtractor {
    */
   public async extractXml(pdfBuffer: Uint8Array | Buffer): Promise<string | null> {
     try {
+      const { PDFDocument, PDFDict, PDFName, PDFRawStream, PDFArray, PDFString } = await loadPdfLib();
       const pdfDoc = await PDFDocument.load(pdfBuffer);
 
       // Try to find associated files via the AF entry in the catalog

package/ts/formats/pdf/extractors/base.extractor.ts

@@ -1,4 +1,5 @@
-import { PDFDocument, PDFDict, PDFName, PDFRawStream, PDFArray, PDFString, pako } from '../../../plugins.js';
+import type { PDFRawStream } from 'pdf-lib';
+import { pako } from '../../../plugins.js';
 
 /**
  * Base class for PDF XML extractors with common functionality
@@ -352,4 +353,4 @@ export abstract class BaseXMLExtractor {
            (content.includes('<?xml') || 
             this.knownFormats.some(format => content.includes(format)));
   }
-}
+}

package/ts/formats/pdf/extractors/standard.extractor.ts

@@ -1,5 +1,5 @@
-import { PDFDocument, PDFDict, PDFName, PDFRawStream, PDFArray, PDFString } from '../../../plugins.js';
 import { BaseXMLExtractor } from './base.extractor.js';
+import { loadPdfLib } from '../../../vendor/pdflib.js';
 
 /**
  * Standard PDF XML extractor that extracts XML from embedded files
@@ -13,6 +13,7 @@ export class StandardXMLExtractor extends BaseXMLExtractor {
    */
   public async extractXml(pdfBuffer: Uint8Array | Buffer): Promise<string | null> {
     try {
+      const { PDFDocument, PDFDict, PDFName, PDFRawStream, PDFArray, PDFString } = await loadPdfLib();
       const pdfDoc = await PDFDocument.load(pdfBuffer);
 
       // Get the document's metadata dictionary

package/ts/formats/pdf/pdf.embedder.ts

@@ -1,5 +1,6 @@
-import { PDFDocument, AFRelationship } from '../../plugins.js';
+import type { PDFDocument as TPdfDocument } from 'pdf-lib';
 import type { IPdf } from '../../interfaces/common.js';
+import { loadPdfLib } from '../../vendor/pdflib.js';
 
 /**
  * Error types for PDF embedding operations
@@ -57,8 +58,10 @@ export class PDFEmbedder {
       // Ensure buffer is Uint8Array
       const pdfBufferArray = Buffer.isBuffer(pdfBuffer) ? new Uint8Array(pdfBuffer) : pdfBuffer;
 
+      const { PDFDocument, AFRelationship } = await loadPdfLib();
+
       // Load the PDF
-      let pdfDoc: PDFDocument;
+      let pdfDoc: TPdfDocument;
       try {
         pdfDoc = await PDFDocument.load(pdfBufferArray, {
           ignoreEncryption: true,  // Try to load encrypted PDFs
@@ -239,4 +242,4 @@ export class PDFEmbedder {
       }
     };
   }
-}
+}

package/ts/formats/pdf/pdf.extractor.ts

@@ -1,9 +1,4 @@
-import {
-  BaseXMLExtractor,
-  StandardXMLExtractor,
-  AssociatedFilesExtractor,
-  TextXMLExtractor
-} from './extractors/index.js';
+import type { BaseXMLExtractor } from './extractors/base.extractor.js';
 import { FormatDetector } from '../utils/format.detector.js';
 import { InvoiceFormat } from '../../interfaces/common.js';
 
@@ -36,18 +31,30 @@ export interface PDFExtractResult {
  * Uses multiple specialized extractors in sequence to maximize success rate
  */
 export class PDFExtractor {
-  private extractors: BaseXMLExtractor[] = [];
+  private extractors?: BaseXMLExtractor[];
 
   /**
    * Constructor initializes the chain of extractors
    */
-  constructor() {
-    // Add extractors in order of preference/likelihood of success
-    this.extractors.push(
-      new StandardXMLExtractor(),      // Standard PDF/A-3 embedded files
-      new AssociatedFilesExtractor(),  // Associated files (ZUGFeRD v1, some Factur-X)
-      new TextXMLExtractor()           // Text-based extraction (fallback)
-    );
+  constructor() {}
+
+  private async getExtractors(): Promise<BaseXMLExtractor[]> {
+    if (!this.extractors) {
+      const [standardModule, associatedModule, textModule] = await Promise.all([
+        import('./extractors/standard.extractor.js'),
+        import('./extractors/associated.extractor.js'),
+        import('./extractors/text.extractor.js')
+      ]);
+
+      // Add extractors in order of preference/likelihood of success
+      this.extractors = [
+        new standardModule.StandardXMLExtractor(),      // Standard PDF/A-3 embedded files
+        new associatedModule.AssociatedFilesExtractor(), // Associated files (ZUGFeRD v1, some Factur-X)
+        new textModule.TextXMLExtractor()               // Text-based extraction (fallback)
+      ];
+    }
+
+    return this.extractors;
   }
 
   /**
@@ -69,7 +76,8 @@ export class PDFExtractor {
       const pdfBufferArray = Buffer.isBuffer(pdfBuffer) ? new Uint8Array(pdfBuffer) : pdfBuffer;
 
       // Try each extractor in sequence
-      for (const extractor of this.extractors) {
+      const extractors = await this.getExtractors();
+      for (const extractor of extractors) {
         const extractorName = extractor.constructor.name;
         console.log(`Trying extraction with ${extractorName}...`);
 
@@ -138,4 +146,4 @@ export class PDFExtractor {
       }
     };
   }
-}
+}

package/ts/formats/semantic/semantic.adapter.ts

@@ -169,17 +169,45 @@ export class SemanticModelAdapter {
     }
     
     // Set payment options
-    if (model.paymentInstructions.paymentAccountIdentifier) {
+    if (
+      model.paymentInstructions.paymentAccountIdentifier ||
+      model.paymentInstructions.paymentMeansText ||
+      model.paymentInstructions.paymentServiceProviderIdentifier
+    ) {
       invoice.paymentOptions = {
-        sepa: {
+        description: model.paymentInstructions.paymentMeansText,
+        sepaConnection: {
+          iban: model.paymentInstructions.paymentAccountIdentifier || '',
+          bic: model.paymentInstructions.paymentServiceProviderIdentifier || '',
+          institution: model.paymentInstructions.paymentServiceProviderIdentifier
+        },
+        payPal: { email: '' }
+      };
+
+      invoice.metadata = {
+        ...invoice.metadata,
+        paymentMeansCode: model.paymentInstructions.paymentMeansTypeCode,
+        paymentAccount: {
           iban: model.paymentInstructions.paymentAccountIdentifier,
-          bic: model.paymentInstructions.paymentServiceProviderIdentifier
+          accountName: model.paymentInstructions.paymentAccountName,
+          bankId: model.paymentInstructions.paymentServiceProviderIdentifier
         },
-        bankInfo: {
-          accountHolder: model.paymentInstructions.paymentAccountName || '',
-          institutionName: model.paymentInstructions.paymentServiceProviderIdentifier || ''
+        extensions: {
+          ...invoice.metadata?.extensions,
+          paymentMeans: {
+            paymentMeansCode: model.paymentInstructions.paymentMeansTypeCode,
+            paymentMeansText: model.paymentInstructions.paymentMeansText,
+            remittanceInformation: model.paymentInstructions.remittanceInformation
+          },
+          paymentAccount: {
+            iban: model.paymentInstructions.paymentAccountIdentifier,
+            accountName: model.paymentInstructions.paymentAccountName,
+            bankId: model.paymentInstructions.paymentServiceProviderIdentifier,
+            bic: model.paymentInstructions.paymentServiceProviderIdentifier,
+            institutionName: model.paymentInstructions.paymentServiceProviderIdentifier
+          }
         }
-      } as any;
+      };
     }
     
     // Set extensions
@@ -376,15 +404,21 @@ export class SemanticModelAdapter {
    */
   private mapPaymentInstructions(invoice: EInvoice): PaymentInstructions {
     const paymentMeans = invoice.metadata?.extensions?.paymentMeans;
-    const paymentAccount = invoice.metadata?.extensions?.paymentAccount;
+    const paymentAccount = invoice.metadata?.extensions?.paymentAccount || invoice.metadata?.paymentAccount;
+    const sepaConnection = invoice.paymentOptions?.sepaConnection;
     
     return {
-      paymentMeansTypeCode: paymentMeans?.paymentMeansCode || '30', // Default to credit transfer
-      paymentMeansText: paymentMeans?.paymentMeansText,
+      paymentMeansTypeCode: paymentMeans?.paymentMeansCode || invoice.metadata?.paymentMeansCode || '30',
+      paymentMeansText: paymentMeans?.paymentMeansText || invoice.paymentOptions?.description,
       remittanceInformation: paymentMeans?.remittanceInformation,
-      paymentAccountIdentifier: paymentAccount?.iban,
+      paymentAccountIdentifier: paymentAccount?.iban || sepaConnection?.iban,
       paymentAccountName: paymentAccount?.accountName,
-      paymentServiceProviderIdentifier: paymentAccount?.bic || paymentAccount?.institutionName
+      paymentServiceProviderIdentifier:
+        paymentAccount?.bic ||
+        paymentAccount?.institutionName ||
+        paymentAccount?.bankId ||
+        sepaConnection?.bic ||
+        sepaConnection?.institution
     };
   }
   
@@ -397,10 +431,10 @@ export class SemanticModelAdapter {
       taxExclusiveAmount: invoice.totalNet,
       taxInclusiveAmount: invoice.totalGross,
       allowanceTotalAmount: invoice.metadata?.extensions?.documentAllowances?.reduce(
-        (sum, a) => sum + a.amount, 0
+        (sum: number, a: { amount: number }) => sum + a.amount, 0
       ),
       chargeTotalAmount: invoice.metadata?.extensions?.documentCharges?.reduce(
-        (sum, c) => sum + c.amount, 0
+        (sum: number, c: { amount: number }) => sum + c.amount, 0
       ),
       prepaidAmount: invoice.metadata?.extensions?.prepaidAmount,
       roundingAmount: invoice.metadata?.extensions?.roundingAmount,
@@ -597,4 +631,4 @@ export class SemanticModelAdapter {
     
     return errors;
   }
-}
+}

package/ts/formats/ubl/en16931.ubl.validator.ts

@@ -90,7 +90,8 @@ export class EN16931UBLValidator extends UBLBaseValidator {
     }
 
     // BR-08: An Invoice shall contain the Seller postal address (BG-5).
-    const sellerAddress = this.select('//cac:AccountingSupplierParty//cac:PostalAddress', this.doc)[0];
+    const sellerAddressResult = this.select('//cac:AccountingSupplierParty//cac:PostalAddress', this.doc);
+    const sellerAddress = Array.isArray(sellerAddressResult) ? sellerAddressResult[0] : null;
     if (!sellerAddress || !this.exists('.//cbc:IdentificationCode', sellerAddress)) {
       this.addError('BR-08', 'An Invoice shall contain the Seller postal address', '//cac:AccountingSupplierParty//cac:PostalAddress');
       valid = false;
@@ -103,7 +104,8 @@ export class EN16931UBLValidator extends UBLBaseValidator {
     }
 
     // BR-10: An Invoice shall contain the Buyer postal address (BG-8).
-    const buyerAddress = this.select('//cac:AccountingCustomerParty//cac:PostalAddress', this.doc)[0];
+    const buyerAddressResult = this.select('//cac:AccountingCustomerParty//cac:PostalAddress', this.doc);
+    const buyerAddress = Array.isArray(buyerAddressResult) ? buyerAddressResult[0] : null;
     if (!buyerAddress || !this.exists('.//cbc:IdentificationCode', buyerAddress)) {
       this.addError('BR-10', 'An Invoice shall contain the Buyer postal address', '//cac:AccountingCustomerParty//cac:PostalAddress');
       valid = false;
@@ -213,4 +215,4 @@ export class EN16931UBLValidator extends UBLBaseValidator {
 
     return valid;
   }
-}
+}

package/ts/formats/ubl/generic/ubl.encoder.ts

@@ -263,6 +263,11 @@ export class UBLEncoder extends UBLBaseEncoder {
    * @param invoice Invoice data
    */
   private addPaymentMeans(doc: Document, parentElement: Element, invoice: TInvoice): void {
+    const paymentOptions = invoice.paymentOptions;
+    if (!paymentOptions) {
+      return;
+    }
+
     const paymentMeansNode = doc.createElement('cac:PaymentMeans');
     parentElement.appendChild(paymentMeansNode);
     
@@ -276,26 +281,26 @@ export class UBLEncoder extends UBLBaseEncoder {
     this.appendElement(doc, paymentMeansNode, 'cbc:PaymentDueDate', this.formatDate(dueDate.getTime()));
     
     // Add payment channel code if available
-    if (invoice.paymentOptions.description) {
-      this.appendElement(doc, paymentMeansNode, 'cbc:InstructionNote', invoice.paymentOptions.description);
+    if (paymentOptions.description) {
+      this.appendElement(doc, paymentMeansNode, 'cbc:InstructionNote', paymentOptions.description);
     }
     
     // Add payment ID information if available - use invoice ID as payment reference
     this.appendElement(doc, paymentMeansNode, 'cbc:PaymentID', invoice.id);
     
     // Add bank account information if available
-    if (invoice.paymentOptions.sepaConnection && invoice.paymentOptions.sepaConnection.iban) {
+    if (paymentOptions.sepaConnection && paymentOptions.sepaConnection.iban) {
       const payeeFinancialAccountNode = doc.createElement('cac:PayeeFinancialAccount');
       paymentMeansNode.appendChild(payeeFinancialAccountNode);
       
-      this.appendElement(doc, payeeFinancialAccountNode, 'cbc:ID', invoice.paymentOptions.sepaConnection.iban);
+      this.appendElement(doc, payeeFinancialAccountNode, 'cbc:ID', paymentOptions.sepaConnection.iban);
       
       // Add financial institution information if BIC is available
-      if (invoice.paymentOptions.sepaConnection.bic) {
+      if (paymentOptions.sepaConnection.bic) {
         const financialInstitutionNode = doc.createElement('cac:FinancialInstitutionBranch');
         payeeFinancialAccountNode.appendChild(financialInstitutionNode);
         
-        this.appendElement(doc, financialInstitutionNode, 'cbc:ID', invoice.paymentOptions.sepaConnection.bic);
+        this.appendElement(doc, financialInstitutionNode, 'cbc:ID', paymentOptions.sepaConnection.bic);
       }
     }
   }
@@ -1038,4 +1043,4 @@ export class UBLEncoder extends UBLBaseEncoder {
       }
     }
   }
-}
+}

package/ts/formats/ubl/ubl.decoder.ts

@@ -3,6 +3,13 @@ import type { TInvoice, TCreditNote, TDebitNote } from '../../interfaces/common.
 import { UBLDocumentType, UBL_NAMESPACES } from './ubl.types.js';
 import { DOMParser, xpath } from '../../plugins.js';
 
+const ublParser = new DOMParser();
+const ublNamespaces = {
+  cbc: UBL_NAMESPACES.CBC,
+  cac: UBL_NAMESPACES.CAC,
+};
+const ublSelect = xpath.useNamespaces(ublNamespaces);
+
 /**
  * Base decoder for UBL-based invoice formats
  */
@@ -15,16 +22,17 @@ export abstract class UBLBaseDecoder extends BaseDecoder {
     super(xml, skipValidation);
 
     // Parse XML document
-    this.doc = new DOMParser().parseFromString(xml, 'application/xml');
+      this.doc = ublParser.parseFromString(xml, 'application/xml');
+
+      // Set up namespaces for XPath queries
+      this.namespaces = ublNamespaces;
 
-    // Set up namespaces for XPath queries
-    this.namespaces = {
-      cbc: UBL_NAMESPACES.CBC,
-      cac: UBL_NAMESPACES.CAC
-    };
+      // Create XPath selector with namespaces
+      this.select = ublSelect;
+  }
 
-    // Create XPath selector with namespaces
-    this.select = xpath.useNamespaces(this.namespaces);
+  public override getParsedDocument(): Document {
+    return this.doc;
   }
 
   /**
@@ -75,7 +83,8 @@ export abstract class UBLBaseDecoder extends BaseDecoder {
    * @returns Text value or empty string if not found
    */
   protected getText(xpathExpr: string, context?: Node): string {
-    const node = this.select(xpathExpr, context || this.doc)[0];
+    const result = this.select(xpathExpr, context || this.doc);
+    const node = Array.isArray(result) ? result[0] : null;
     return node ? (node.textContent || '') : '';
   }
 

package/ts/formats/ubl/ubl.validator.ts

@@ -4,29 +4,33 @@ import type { ValidationResult } from '../../interfaces/common.js';
 import { UBLDocumentType } from './ubl.types.js';
 import { DOMParser, xpath } from '../../plugins.js';
 
+const ublValidatorParser = new DOMParser();
+const ublValidatorNamespaces = {
+  cbc: 'urn:oasis:names:specification:ubl:schema:xsd:CommonBasicComponents-2',
+  cac: 'urn:oasis:names:specification:ubl:schema:xsd:CommonAggregateComponents-2',
+};
+const ublValidatorSelect = xpath.useNamespaces(ublValidatorNamespaces);
+
 /**
  * Base validator for UBL-based invoice formats
  */
 export abstract class UBLBaseValidator extends BaseValidator {
-  protected doc: Document;
-  protected namespaces: Record<string, string>;
-  protected select: xpath.XPathSelect;
+  protected doc!: Document;
+  protected namespaces!: Record<string, string>;
+  protected select!: xpath.XPathSelect;
 
-  constructor(xml: string) {
+  constructor(xml: string, doc?: Document) {
     super(xml);
 
     try {
-      // Parse XML document
-      this.doc = new DOMParser().parseFromString(xml, 'application/xml');
+      // Reuse an existing parsed document when available.
+      this.doc = doc ?? ublValidatorParser.parseFromString(xml, 'application/xml');
 
       // Set up namespaces for XPath queries
-      this.namespaces = {
-        cbc: 'urn:oasis:names:specification:ubl:schema:xsd:CommonBasicComponents-2',
-        cac: 'urn:oasis:names:specification:ubl:schema:xsd:CommonAggregateComponents-2'
-      };
+      this.namespaces = ublValidatorNamespaces;
 
       // Create XPath selector with namespaces
-      this.select = xpath.useNamespaces(this.namespaces);
+      this.select = ublValidatorSelect;
     } catch (error) {
       this.addError('UBL-PARSE', `Failed to parse XML: ${error}`, '/');
     }
@@ -101,7 +105,8 @@ export abstract class UBLBaseValidator extends BaseValidator {
    * @returns Text value or empty string if not found
    */
   protected getText(xpathExpr: string, context?: Node): string {
-    const node = this.select(xpathExpr, context || this.doc)[0];
+    const result = this.select(xpathExpr, context || this.doc);
+    const node = Array.isArray(result) ? result[0] : null;
     return node ? (node.textContent || '') : '';
   }
 

package/ts/formats/ubl/xrechnung/xrechnung.decoder.ts

@@ -194,7 +194,36 @@ export class XRechnungDecoder extends UBLBaseDecoder {
       const seller = this.extractParty('//cac:AccountingSupplierParty/cac:Party');
       const buyer = this.extractParty('//cac:AccountingCustomerParty/cac:Party');
 
-      // Create the common invoice data with metadata for business references
+      const businessReferences = {
+        buyerReference,
+        orderReference,
+        contractReference,
+        projectReference
+      };
+
+      const paymentInformation = {
+        paymentMeansCode,
+        paymentID,
+        paymentDueDate,
+        iban,
+        bic,
+        bankName,
+        accountName,
+        paymentTermsNote,
+        discountPercent
+      };
+
+      const dateInformation = {
+        periodStart,
+        periodEnd,
+        deliveryDate
+      };
+
+      const hasBusinessReferences = Object.values(businessReferences).some(value => Boolean(value));
+      const hasPaymentInformation = Object.values(paymentInformation).some(value => Boolean(value));
+      const hasDateInformation = Object.values(dateInformation).some(value => Boolean(value));
+
+      // Create the common invoice data with metadata only when the source XML actually contains it.
       const invoiceData: any = {
         type: 'accounting-doc' as const,
         accountingDocType: 'invoice' as const,
@@ -216,36 +245,20 @@ export class XRechnungDecoder extends UBLBaseDecoder {
         reverseCharge: false,
         currency: currencyCode as finance.TCurrency,
         notes: notes,
-        objectActions: [],
-        metadata: {
+        objectActions: []
+      };
+
+      if (hasBusinessReferences || hasPaymentInformation || hasDateInformation) {
+        invoiceData.metadata = {
           format: 'xrechnung' as any,
           version: '1.0.0',
           extensions: {
-            businessReferences: {
-              buyerReference,
-              orderReference,
-              contractReference,
-              projectReference
-            },
-            paymentInformation: {
-              paymentMeansCode,
-              paymentID,
-              paymentDueDate,
-              iban,
-              bic,
-              bankName,
-              accountName,
-              paymentTermsNote,
-              discountPercent
-            },
-            dateInformation: {
-              periodStart,
-              periodEnd,
-              deliveryDate
-            }
+            ...(hasBusinessReferences ? { businessReferences } : {}),
+            ...(hasPaymentInformation ? { paymentInformation } : {}),
+            ...(hasDateInformation ? { dateInformation } : {}),
           }
-        }
-      };
+        };
+      }
       
       // Validate mandatory EN16931 fields unless validation is skipped
       if (!this.skipValidation) {
@@ -255,7 +268,7 @@ export class XRechnungDecoder extends UBLBaseDecoder {
       return invoiceData;
     } catch (error) {
       // Re-throw validation errors
-      if (error.message && error.message.includes('EN16931 validation failed')) {
+      if (error instanceof Error && error.message.includes('EN16931 validation failed')) {
         throw error;
       }
       

package/ts/formats/utils/format.detector.ts

@@ -70,41 +70,81 @@ export class FormatDetector {
    * @returns Detected format or UNKNOWN if more analysis is needed
    */
   private static quickFormatCheck(xml: string): InvoiceFormat {
-    const lowerXml = xml.toLowerCase();
+    // Only scan a small prefix so large payloads do not create another full-size string copy.
+    const sample = xml.slice(0, 65536);
+
+    // Root-element checks avoid a DOM parse for the common invoice formats.
+    if (/<(?:[A-Za-z_][\w.-]*:)?(?:Invoice|CreditNote)\b/.test(sample)) {
+      const customizationIdMatch = sample.match(
+        /<[^>]*CustomizationID[^>]*>\s*([^<]+?)\s*<\/[^>]*CustomizationID>/i,
+      );
+      const customizationId = customizationIdMatch?.[1] ?? '';
+
+      if (/xrechnung/i.test(customizationId) || /urn:xoev-de:kosit:standard:xrechnung/i.test(customizationId)) {
+        return InvoiceFormat.XRECHNUNG;
+      }
+      return InvoiceFormat.UBL;
+    }
+
+    if (/<(?:[A-Za-z_][\w.-]*:)?CrossIndustryInvoice\b/.test(sample)) {
+      const guidelineIdMatch = sample.match(
+        /<[^>]*GuidelineSpecifiedDocumentContextParameter[^>]*>[\s\S]*?<[^>]*ID[^>]*>\s*([^<]+?)\s*<\/[^>]*ID>/i,
+      );
+      const guidelineId = guidelineIdMatch?.[1] ?? '';
+
+      if (/xrechnung/i.test(guidelineId)) {
+        return InvoiceFormat.XRECHNUNG;
+      }
+      if (/factur-x/i.test(guidelineId) || /urn:cen\.eu:en16931:2017/i.test(guidelineId)) {
+        return InvoiceFormat.FACTURX;
+      }
+      if (/zugferd/i.test(guidelineId) || /urn:ferd:/i.test(guidelineId) || /urn:zugferd/i.test(guidelineId)) {
+        return InvoiceFormat.ZUGFERD;
+      }
+      return InvoiceFormat.CII;
+    }
+
+    if (/<(?:[A-Za-z_][\w.-]*:)?CrossIndustryDocument\b/.test(sample)) {
+      return InvoiceFormat.ZUGFERD;
+    }
+
+    if (/<FatturaElettronica\b/.test(sample)) {
+      return InvoiceFormat.FATTURAPA;
+    }
 
     // Check for obvious Factur-X indicators
     if (
-      lowerXml.includes('factur-x.eu') ||
-      lowerXml.includes('factur-x.xml') ||
-      lowerXml.includes('factur-x:') ||
-      lowerXml.includes('urn:cen.eu:en16931:2017') && lowerXml.includes('factur-x')
+      /factur-x\.eu/i.test(sample) ||
+      /factur-x\.xml/i.test(sample) ||
+      /factur-x:/i.test(sample) ||
+      (/urn:cen\.eu:en16931:2017/i.test(sample) && /factur-x/i.test(sample))
     ) {
       return InvoiceFormat.FACTURX;
     }
 
     // Check for obvious ZUGFeRD indicators
     if (
-      lowerXml.includes('zugferd:') ||
-      lowerXml.includes('zugferd-invoice.xml') ||
-      lowerXml.includes('urn:ferd:') ||
-      lowerXml.includes('urn:zugferd')
+      /zugferd:/i.test(sample) ||
+      /zugferd-invoice\.xml/i.test(sample) ||
+      /urn:ferd:/i.test(sample) ||
+      /urn:zugferd/i.test(sample)
     ) {
       return InvoiceFormat.ZUGFERD;
     }
 
     // Check for obvious XRechnung indicators
     if (
-      lowerXml.includes('xrechnung') ||
-      lowerXml.includes('urn:xoev-de:kosit:standard:xrechnung')
+      /xrechnung/i.test(sample) ||
+      /urn:xoev-de:kosit:standard:xrechnung/i.test(sample)
     ) {
       return InvoiceFormat.XRECHNUNG;
     }
 
     // Check for obvious FatturaPA indicators
     if (
-      lowerXml.includes('fatturapa') ||
-      lowerXml.includes('fattura elettronica') ||
-      lowerXml.includes('fatturaelettronica')
+      /fatturapa/i.test(sample) ||
+      /fattura elettronica/i.test(sample) ||
+      /fatturaelettronica/i.test(sample)
     ) {
       return InvoiceFormat.FATTURAPA;
     }
@@ -198,10 +238,8 @@ export class FormatDetector {
    * @returns True if it's a FatturaPA format
    */
   private static isFatturaPAFormat(root: Element): boolean {
-    return (
-      root.nodeName === 'FatturaElettronica' ||
-      (root.getAttribute('xmlns') && root.getAttribute('xmlns')!.includes('fatturapa.gov.it'))
-    );
+    const xmlns = root.getAttribute('xmlns') || '';
+    return root.nodeName === 'FatturaElettronica' || xmlns.includes('fatturapa.gov.it');
   }
 
   /**
@@ -303,4 +341,4 @@ export class FormatDetector {
     // Generic CII if we can't determine more specifically
     return InvoiceFormat.CII;
   }
-}
+}

package/ts/formats/validation/conformance.harness.ts

@@ -185,7 +185,8 @@ export class ConformanceTestHarness {
           r.source === 'Schematron'
         );
       } catch (error) {
-        console.warn(`Schematron not available for ${sample.format}: ${error.message}`);
+        const errorMessage = error instanceof Error ? error.message : String(error);
+        console.warn(`Schematron not available for ${sample.format}: ${errorMessage}`);
       }
       
       // Aggregate results
@@ -202,12 +203,13 @@ export class ConformanceTestHarness {
       result.passed = result.errors.length === 0 === sample.expectedValid;
       
     } catch (error) {
-      console.error(`Error testing ${sample.name}: ${error.message}`);
+      const errorMessage = error instanceof Error ? error.message : String(error);
+      console.error(`Error testing ${sample.name}: ${errorMessage}`);
       result.errors.push({
         ruleId: 'TEST-ERROR',
         source: 'TestHarness',
         severity: 'error',
-        message: `Test execution failed: ${error.message}`
+        message: `Test execution failed: ${errorMessage}`
       });
     }
     
@@ -588,4 +590,4 @@ export async function runConformanceTests(
     // Generate HTML report
     await harness.generateHTMLReport();
   }
-}
+}