@fiduswriter/editor 0.1.20 → 0.1.21

package/src/state_plugins/inline_reference/{plugin.js → plugin.ts}

@@ -5,6 +5,10 @@ import {
     TextSelection
 } from "prosemirror-state"
 import {Decoration, DecorationSet} from "prosemirror-view"
+import type {Node as ProseMirrorNode} from "prosemirror-model"
+import type {EditorState} from "prosemirror-state"
+import type {EditorView} from "prosemirror-view"
+
 import {COMMENT_ONLY_ROLES, READ_ONLY_ROLES} from "../../index.js"
 import {elementDisabled} from "../../menus/toolbar/model.js"
 import {
@@ -15,10 +19,47 @@ import {
     filterCrossRefs
 } from "./dropup.js"
 
+import type {Editor} from "../../types.js"
+
 const key = new PluginKey("inlineReference")
 
-export const getInlineReferenceState = state => key.getState(state)
-export const setInlineReferenceState = (tr, state) => tr.setMeta(key, state)
+interface BibliographyEntry {
+    id: number
+    entry_key: string
+    author: string
+    title: string
+    year: string
+    source: string
+    entry: Record<string, unknown>
+}
+
+interface CrossRefTarget {
+    id: string
+    text: string
+}
+
+interface InlineReferenceState {
+    active: boolean
+    from: number
+    query: string
+    selectedIndex: number
+    listActive: boolean
+    isEdit: boolean
+    referenceNodePos: number
+    bibList: BibliographyEntry[]
+    widgetId: string | undefined
+    cursorAtStart: boolean | undefined
+    decos: DecorationSet
+}
+
+export const getInlineReferenceState = (state: EditorState) => key.getState(state)
+
+export const setInlineReferenceState = (
+    tr: {
+        setMeta: (key: PluginKey, state: Partial<InlineReferenceState>) => unknown
+    },
+    state: Partial<InlineReferenceState>
+) => tr.setMeta(key, state)
 
 /**
  * Check if citations can be inserted at the given position.
@@ -26,7 +67,7 @@ export const setInlineReferenceState = (tr, state) => tr.setMeta(key, state)
  * (allowed elements per doc part, protected sections) — the same conditions
  * that disable the toolbar citation button.
  */
-function canActivateInlineReference(editor) {
+function canActivateInlineReference(editor: Editor): boolean {
     // Mirror the template-based restriction check used by the toolbar button.
     if (
         editor &&
@@ -38,12 +79,25 @@ function canActivateInlineReference(editor) {
     return true
 }
 
+interface ParsedCitation {
+    references: Array<{
+        id: number
+        prefix?: string
+        locator?: string
+    }>
+    format: string
+}
+
 /**
  * Parse inline citation text into references array.
  * Format: @key[prefix][locator];key2[prefix2][locator2]
  * Returns {references, format} or null if any key cannot be resolved.
  */
-function parseCitationText(text, bibEntries, bibDB) {
+function parseCitationText(
+    text: string,
+    bibEntries: BibliographyEntry[],
+    bibDB: {addReference(entry: Record<string, unknown>, id: number): number}
+): ParsedCitation | null {
     let format = "autocite"
     let body = text
     if (body.startsWith("@@")) {
@@ -57,7 +111,7 @@ function parseCitationText(text, bibEntries, bibDB) {
         return null
     }
 
-    const references = []
+    const references: ParsedCitation["references"] = []
     const parts = body.split(";")
 
     for (const part of parts) {
@@ -82,7 +136,7 @@ function parseCitationText(text, bibEntries, bibDB) {
             // addReference then writes into the document DB, corrupting it.
             id = bibDB.addReference(bibEntry.entry, id)
         }
-        const ref = {id}
+        const ref: ParsedCitation["references"][number] = {id}
         if (match[2]) {
             ref.prefix = match[2]
         }
@@ -102,7 +156,7 @@ function parseCitationText(text, bibEntries, bibDB) {
 /**
  * Extract the active reference index based on cursor offset.
  */
-function getActiveRefIndex(text, cursorOffset) {
+function getActiveRefIndex(text: string, cursorOffset: number): number {
     let pos = 0
     const parts = text.split(";")
     for (let i = 0; i < parts.length; i++) {
@@ -118,7 +172,7 @@ function getActiveRefIndex(text, cursorOffset) {
 /**
  * Get the query (key being typed) for the active reference.
  */
-function getActiveQuery(text, activeIndex) {
+function getActiveQuery(text: string, activeIndex: number): string {
     const parts = text.split(";")
     let part = parts[activeIndex] || ""
     if (part.startsWith("@@")) {
@@ -133,7 +187,11 @@ function getActiveQuery(text, activeIndex) {
 /**
  * Replace the key of the active reference while preserving prefix/locator.
  */
-function replaceActiveKey(text, activeIndex, newKey) {
+function replaceActiveKey(
+    text: string,
+    activeIndex: number,
+    newKey: string
+): string {
     const parts = text.split(";")
     let part = parts[activeIndex] || ""
     let trigger = ""
@@ -153,9 +211,16 @@ function replaceActiveKey(text, activeIndex, newKey) {
 /**
  * Convert a citation node back to its inline text representation.
  */
-function citationToText(node, bibEntries) {
-    const format = node.attrs.format
-    const references = node.attrs.references || []
+function citationToText(
+    node: ProseMirrorNode,
+    bibEntries: BibliographyEntry[]
+): string {
+    const format = node.attrs.format as string
+    const references = (node.attrs.references || []) as Array<{
+        id: number
+        prefix?: string
+        locator?: string
+    }>
     const parts = references.map(ref => {
         const entry = bibEntries.find(e => e.id === ref.id)
         const key = entry ? entry.entry_key : ""
@@ -175,7 +240,7 @@ function citationToText(node, bibEntries) {
     return "@" + body
 }
 
-function getInputCursorPos(el) {
+function getInputCursorPos(el: HTMLElement): number {
     const sel = window.getSelection()
     if (!sel || !sel.rangeCount) {
         return (el.textContent || "").length
@@ -187,13 +252,13 @@ function getInputCursorPos(el) {
     return range.startOffset
 }
 
-function setInputCursorPos(el, pos) {
+function setInputCursorPos(el: HTMLElement, pos: number): void {
     const textNode = el.firstChild
     if (!textNode) {
         return
     }
     const range = document.createRange()
-    const safePos = Math.max(0, Math.min(pos, textNode.length))
+    const safePos = Math.max(0, Math.min(pos, (textNode as Text).length))
     range.setStart(textNode, safePos)
     range.collapse(true)
     const sel = window.getSelection()
@@ -206,7 +271,11 @@ function setInputCursorPos(el, pos) {
 /**
  * Create the inline citation widget DOM element.
  */
-function createInlineReferenceWidget(editor, pluginState, key) {
+function createInlineReferenceWidget(
+    editor: Editor,
+    pluginState: InlineReferenceState,
+    pluginKey: PluginKey
+): HTMLElement {
     const view = editor.currentView || editor.view
     const container = document.createElement("span")
     container.className = "inline-reference-widget"
@@ -223,8 +292,10 @@ function createInlineReferenceWidget(editor, pluginState, key) {
     const dropUpWrapper = document.createElement("span")
     dropUpWrapper.className = "drop-up-outer inline-reference-drop-up"
 
-    function renderDropUp() {
-        const currentState = key.getState(view.state)
+    function renderDropUp(): void {
+        const currentState = pluginKey.getState(view.state) as
+            | InlineReferenceState
+            | undefined
         if (!currentState?.active) {
             return
         }
@@ -232,7 +303,9 @@ function createInlineReferenceWidget(editor, pluginState, key) {
         const citDisabled = elementDisabled(editor, "citation")
         const xrefDisabled = elementDisabled(editor, "cross_reference")
         const isXrefMode = !xrefDisabled && rawText.startsWith("@#")
-        let citationMatches, xrefMatches, activeCitIndex
+        let citationMatches: BibliographyEntry[],
+            xrefMatches: CrossRefTarget[],
+            activeCitIndex: number
         if (isXrefMode) {
             // Cross-reference mode: only show cross-refs, filter by id/text
             citationMatches = []
@@ -279,7 +352,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                     )
                     setInputCursorPos(input, newCursor + entry.entry_key.length)
                     view.dispatch(
-                        view.state.tr.setMeta(key, {
+                        view.state.tr.setMeta(pluginKey, {
                             action: "updateQuery",
                             query: input.textContent
                         })
@@ -294,7 +367,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                     input.textContent = `@#${target.id}`
                     setInputCursorPos(input, input.textContent.length)
                     view.dispatch(
-                        view.state.tr.setMeta(key, {
+                        view.state.tr.setMeta(pluginKey, {
                             action: "updateQuery",
                             query: input.textContent
                         })
@@ -314,12 +387,11 @@ function createInlineReferenceWidget(editor, pluginState, key) {
         }
     }
 
-    input.addEventListener("input", event => {
-        event.stopPropagation()
+    input.addEventListener("input", () => {
         const text = input.textContent || ""
         if (!text) {
             // Everything including `@` was deleted — remove the node.
-            view.dispatch(view.state.tr.setMeta(key, {action: "cancelDelete"}))
+            view.dispatch(view.state.tr.setMeta(pluginKey, {action: "cancelDelete"}))
             view.focus()
             return
         }
@@ -330,7 +402,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
             setInputCursorPos(input, cursorPos + 1)
         }
         view.dispatch(
-            view.state.tr.setMeta(key, {
+            view.state.tr.setMeta(pluginKey, {
                 action: "updateQuery",
                 query: input.textContent
             })
@@ -344,7 +416,9 @@ function createInlineReferenceWidget(editor, pluginState, key) {
 
     input.addEventListener("keydown", event => {
         event.stopPropagation()
-        const currentState = key.getState(view.state)
+        const currentState = pluginKey.getState(view.state) as
+            | InlineReferenceState
+            | undefined
         if (!currentState?.active) {
             return
         }
@@ -354,7 +428,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                 if (getInputCursorPos(input) === 0) {
                     event.preventDefault()
                     view.dispatch(
-                        view.state.tr.setMeta(key, {action: "cancelLeft"})
+                        view.state.tr.setMeta(pluginKey, {action: "cancelLeft"})
                     )
                     view.focus()
                 }
@@ -366,7 +440,9 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                 ) {
                     event.preventDefault()
                     view.dispatch(
-                        view.state.tr.setMeta(key, {action: "commitAndRight"})
+                        view.state.tr.setMeta(pluginKey, {
+                            action: "commitAndRight"
+                        })
                     )
                     view.focus()
                 }
@@ -374,10 +450,12 @@ function createInlineReferenceWidget(editor, pluginState, key) {
             case "ArrowDown":
                 event.preventDefault()
                 {
-                    const currentState = key.getState(view.state)
-                    if (!currentState.listActive) {
+                    const state = pluginKey.getState(view.state) as
+                        | InlineReferenceState
+                        | undefined
+                    if (!state?.listActive) {
                         view.dispatch(
-                            view.state.tr.setMeta(key, {
+                            view.state.tr.setMeta(pluginKey, {
                                 action: "select",
                                 index: 0,
                                 listActive: true
@@ -385,9 +463,9 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                         )
                     } else {
                         view.dispatch(
-                            view.state.tr.setMeta(key, {
+                            view.state.tr.setMeta(pluginKey, {
                                 action: "select",
-                                index: currentState.selectedIndex + 1,
+                                index: state.selectedIndex + 1,
                                 listActive: true
                             })
                         )
@@ -398,21 +476,20 @@ function createInlineReferenceWidget(editor, pluginState, key) {
             case "ArrowUp":
                 event.preventDefault()
                 {
-                    const currentState = key.getState(view.state)
-                    if (
-                        currentState.listActive &&
-                        currentState.selectedIndex > 0
-                    ) {
+                    const state = pluginKey.getState(view.state) as
+                        | InlineReferenceState
+                        | undefined
+                    if (state?.listActive && state.selectedIndex > 0) {
                         view.dispatch(
-                            view.state.tr.setMeta(key, {
+                            view.state.tr.setMeta(pluginKey, {
                                 action: "select",
-                                index: currentState.selectedIndex - 1,
+                                index: state.selectedIndex - 1,
                                 listActive: true
                             })
                         )
                     } else {
                         view.dispatch(
-                            view.state.tr.setMeta(key, {
+                            view.state.tr.setMeta(pluginKey, {
                                 action: "select",
                                 index: -1,
                                 listActive: false
@@ -425,7 +502,9 @@ function createInlineReferenceWidget(editor, pluginState, key) {
             case "Enter":
                 event.preventDefault()
                 {
-                    const currentState = key.getState(view.state)
+                    const state = pluginKey.getState(view.state) as
+                        | InlineReferenceState
+                        | undefined
                     const rawText = input.textContent || ""
                     const citDisabledEnter = elementDisabled(editor, "citation")
                     const xrefDisabledEnter = elementDisabled(
@@ -434,7 +513,9 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                     )
                     const isXrefMode =
                         !xrefDisabledEnter && rawText.startsWith("@#")
-                    let citMatches, xrefMatchesEnter, activeIndexEnter
+                    let citMatches: BibliographyEntry[],
+                        xrefMatchesEnter: CrossRefTarget[],
+                        activeIndexEnter: number
                     if (isXrefMode) {
                         citMatches = []
                         xrefMatchesEnter = filterCrossRefs(
@@ -448,7 +529,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                         const query = getActiveQuery(rawText, activeIndexEnter)
                         citMatches = citDisabledEnter
                             ? []
-                            : filterBibliography(currentState.bibList, query)
+                            : filterBibliography(state?.bibList || [], query)
                         xrefMatchesEnter = xrefDisabledEnter
                             ? []
                             : filterCrossRefs(crossRefList, query)
@@ -457,12 +538,12 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                         citMatches.length + xrefMatchesEnter.length
                     const selectedIndex = Math.max(
                         0,
-                        Math.min(currentState.selectedIndex, totalEnter - 1)
+                        Math.min(state?.selectedIndex ?? -1, totalEnter - 1)
                     )
                     if (
-                        currentState.listActive &&
+                        state?.listActive &&
                         totalEnter > 0 &&
-                        currentState.selectedIndex >= 0
+                        state.selectedIndex >= 0
                     ) {
                         if (selectedIndex < citMatches.length) {
                             // Insert selected citation key into input
@@ -480,7 +561,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                                 ) + entry.entry_key.length
                             setInputCursorPos(input, newCursor)
                             view.dispatch(
-                                view.state.tr.setMeta(key, {
+                                view.state.tr.setMeta(pluginKey, {
                                     action: "updateQuery",
                                     query: input.textContent
                                 })
@@ -495,7 +576,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                             input.textContent = `@#${target.id}`
                             setInputCursorPos(input, input.textContent.length)
                             view.dispatch(
-                                view.state.tr.setMeta(key, {
+                                view.state.tr.setMeta(pluginKey, {
                                     action: "updateQuery",
                                     query: input.textContent
                                 })
@@ -505,7 +586,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                     } else {
                         // Not in list mode or no matches: commit what we have
                         view.dispatch(
-                            view.state.tr.setMeta(key, {action: "commit"})
+                            view.state.tr.setMeta(pluginKey, {action: "commit"})
                         )
                         view.focus()
                     }
@@ -513,7 +594,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                 break
             case "Escape":
                 event.preventDefault()
-                view.dispatch(view.state.tr.setMeta(key, {action: "cancel"}))
+                view.dispatch(view.state.tr.setMeta(pluginKey, {action: "cancel"}))
                 view.focus()
                 break
             case "Home":
@@ -529,7 +610,7 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                 if ((input.textContent || "").length <= 1) {
                     event.preventDefault()
                     view.dispatch(
-                        view.state.tr.setMeta(key, {action: "cancelDelete"})
+                        view.state.tr.setMeta(pluginKey, {action: "cancelDelete"})
                     )
                     view.focus()
                 }
@@ -539,14 +620,14 @@ function createInlineReferenceWidget(editor, pluginState, key) {
                 if ((input.textContent || "").length <= 1) {
                     event.preventDefault()
                     view.dispatch(
-                        view.state.tr.setMeta(key, {action: "cancelDelete"})
+                        view.state.tr.setMeta(pluginKey, {action: "cancelDelete"})
                     )
                     view.focus()
                 }
                 break
             case "Tab":
                 event.preventDefault()
-                view.dispatch(view.state.tr.setMeta(key, {action: "commit"}))
+                view.dispatch(view.state.tr.setMeta(pluginKey, {action: "commit"}))
                 break
             default:
                 break
@@ -555,14 +636,16 @@ function createInlineReferenceWidget(editor, pluginState, key) {
 
     input.addEventListener("focusout", event => {
         const related = event.relatedTarget
-        if (container.contains(related)) {
+        if (container.contains(related as globalThis.Node | null)) {
             return
         }
         const myWidgetId = pluginState.widgetId
         setTimeout(() => {
-            const currentState = key.getState(view.state)
+            const currentState = pluginKey.getState(view.state) as
+                | InlineReferenceState
+                | undefined
             if (currentState?.active && currentState.widgetId === myWidgetId) {
-                view.dispatch(view.state.tr.setMeta(key, {action: "commit"}))
+                view.dispatch(view.state.tr.setMeta(pluginKey, {action: "commit"}))
             }
         }, 1)
     })
@@ -589,14 +672,20 @@ function createInlineReferenceWidget(editor, pluginState, key) {
     return container
 }
 
-export const inlineReferencePlugin = options => {
+export const inlineReferencePlugin = (options: {editor: Editor}): Plugin => {
     const editor = options.editor
-    const bibDB = editor.mod.db.bibDB
+    const bibDB = (editor.mod.db?.bibDB || {}) as {
+        addReference(entry: Record<string, unknown>, id: number): number
+    }
+
+    const appConfig = editor.app as {
+        config?: {user?: {preferences?: {inline_references?: boolean}}}
+    }
 
     const enabled =
-        editor.app.config.user?.preferences?.inline_references === true &&
-        !READ_ONLY_ROLES.includes(editor.docInfo.access_rights) &&
-        !COMMENT_ONLY_ROLES.includes(editor.docInfo.access_rights)
+        appConfig.config?.user?.preferences?.inline_references === true &&
+        !READ_ONLY_ROLES.includes(editor.docInfo.access_rights as string) &&
+        !COMMENT_ONLY_ROLES.includes(editor.docInfo.access_rights as string)
 
     if (!enabled) {
         return new Plugin({
@@ -615,7 +704,7 @@ export const inlineReferencePlugin = options => {
     return new Plugin({
         key,
         state: {
-            init() {
+            init(): InlineReferenceState {
                 return {
                     active: false,
                     from: 0,
@@ -630,22 +719,24 @@ export const inlineReferencePlugin = options => {
                     decos: DecorationSet.empty
                 }
             },
-            apply(tr, prev, _oldState, _state) {
-                let next = {...prev}
+            apply(tr, prev, _oldState, _state): InlineReferenceState {
+                let next = {...prev} as InlineReferenceState
                 const meta = tr.getMeta(key)
 
                 if (meta?.action === "activate") {
                     next = {
                         active: true,
-                        from: meta.from,
-                        query: meta.query || "",
+                        from: meta.from as number,
+                        query: (meta.query as string) || "",
                         selectedIndex: -1,
                         listActive: false,
-                        isEdit: meta.isEdit || false,
-                        referenceNodePos: meta.referenceNodePos || 0,
-                        bibList: meta.bibList || [],
+                        isEdit: (meta.isEdit as boolean) || false,
+                        referenceNodePos: (meta.referenceNodePos as number) || 0,
+                        bibList: (meta.bibList as BibliographyEntry[]) || [],
                         widgetId: Math.random().toString(36).slice(2),
-                        cursorAtStart: meta.cursorAtStart,
+                        cursorAtStart: meta.cursorAtStart as
+                            | boolean
+                            | undefined,
                         decos: DecorationSet.empty
                     }
                 } else if (meta?.action === "deactivate") {
@@ -663,12 +754,12 @@ export const inlineReferencePlugin = options => {
                         decos: DecorationSet.empty
                     }
                 } else if (meta?.action === "select") {
-                    next.selectedIndex = meta.index
+                    next.selectedIndex = meta.index as number
                     if (meta.listActive !== undefined) {
-                        next.listActive = meta.listActive
+                        next.listActive = meta.listActive as boolean
                     }
                 } else if (meta?.action === "updateQuery") {
-                    next.query = meta.query
+                    next.query = meta.query as string
                     next.selectedIndex = -1
                     next.listActive = false
                 }
@@ -716,14 +807,16 @@ export const inlineReferencePlugin = options => {
             }
         },
         appendTransaction: (trs, oldState, newState) => {
-            const oldPluginState = key.getState(oldState)
+            const oldPluginState = key.getState(oldState) as
+                | InlineReferenceState
+                | undefined
             const meta = trs.find(tr => tr.getMeta(key))?.getMeta(key)
 
             if (
                 meta?.action === "commit" ||
                 meta?.action === "commitAndRight"
             ) {
-                if (!oldPluginState.active) {
+                if (!oldPluginState?.active) {
                     return null
                 }
                 const query = oldPluginState.query
@@ -824,6 +917,9 @@ export const inlineReferencePlugin = options => {
             }
 
             if (meta?.action === "cancel") {
+                if (!oldPluginState) {
+                    return null
+                }
                 if (oldPluginState.isEdit) {
                     // Editing: just deactivate, leave reference unchanged
                     const node = newState.doc.nodeAt(
@@ -849,6 +945,9 @@ export const inlineReferencePlugin = options => {
             }
 
             if (meta?.action === "cancelDelete") {
+                if (!oldPluginState) {
+                    return null
+                }
                 if (oldPluginState.isEdit) {
                     // Delete the reference node entirely.
                     const existingNode = newState.doc.nodeAt(
@@ -873,6 +972,9 @@ export const inlineReferencePlugin = options => {
             }
 
             if (meta?.action === "cancelLeft") {
+                if (!oldPluginState) {
+                    return null
+                }
                 if (oldPluginState.isEdit) {
                     const tr = newState.tr.setSelection(
                         TextSelection.create(
@@ -894,7 +996,7 @@ export const inlineReferencePlugin = options => {
             }
 
             if (meta?.action === "openDialog") {
-                if (oldPluginState.active && oldPluginState.isEdit) {
+                if (oldPluginState?.active && oldPluginState.isEdit) {
                     // Deactivate the inline editor and leave a NodeSelection on
                     // the citation so CitationDialog opens with its content.
                     const node = newState.doc.nodeAt(
@@ -915,13 +1017,13 @@ export const inlineReferencePlugin = options => {
             }
 
             if (meta?.action === "insertCrossRef") {
-                if (!oldPluginState.active) {
+                if (!oldPluginState?.active) {
                     return null
                 }
                 const crossRefNode =
                     newState.schema.nodes.cross_reference.create({
-                        id: meta.id,
-                        title: meta.title
+                        id: meta.id as string,
+                        title: meta.title as string | null
                     })
                 if (oldPluginState.isEdit) {
                     // Replace the existing citation node with a cross_reference.
@@ -957,7 +1059,7 @@ export const inlineReferencePlugin = options => {
                 }
             }
 
-            if (oldPluginState.active) {
+            if (oldPluginState?.active) {
                 // If selection moved away from the widget, commit
                 if (
                     trs.some(tr => tr.selectionSet) &&
@@ -1127,11 +1229,20 @@ export const inlineReferencePlugin = options => {
             return null
         },
         props: {
-            decorations(state) {
-                const pluginState = key.getState(state)
+            decorations(state: EditorState) {
+                const pluginState = key.getState(state) as
+                    | InlineReferenceState
+                    | undefined
                 return pluginState?.decos || DecorationSet.empty
             },
-            handleClickOn(_view, _pos, node, nodePos, _event, _direct) {
+            handleClickOn(
+                _view: EditorView,
+                _pos: number,
+                node: ProseMirrorNode,
+                nodePos: number,
+                _event: MouseEvent,
+                _direct: boolean
+            ) {
                 if (node.type.name === "citation") {
                     const bibList = buildBibliographyList(editor)
                     const text = citationToText(node, bibList)
@@ -1173,21 +1284,22 @@ export const inlineReferencePlugin = options => {
                 return false
             },
             handleDOMEvents: {
-                mousedown(view, event) {
+                mousedown(view: EditorView, event: MouseEvent) {
                     if (event.ctrlKey || event.metaKey || event.shiftKey) {
                         return false
                     }
                     if (event.button !== 0) {
                         return false
                     }
-                    const citTarget = event.target.closest(".citation")
+                    const target = event.target as HTMLElement | null
+                    const citTarget = target?.closest(".citation")
                     const xrefTarget =
-                        !citTarget && event.target.closest(".cross-reference")
-                    const target = citTarget || xrefTarget
-                    if (!target) {
+                        !citTarget && target?.closest(".cross-reference")
+                    const closest = citTarget || xrefTarget
+                    if (!closest) {
                         return false
                     }
-                    let pos = view.posAtDOM(target, 0)
+                    let pos = view.posAtDOM(closest, 0)
                     let node = view.state.doc.nodeAt(pos)
                     if (
                         !node ||
@@ -1196,7 +1308,9 @@ export const inlineReferencePlugin = options => {
                     ) {
                         return false
                     }
-                    const pluginState = key.getState(view.state)
+                    const pluginState = key.getState(view.state) as
+                        | InlineReferenceState
+                        | undefined
                     if (pluginState?.active) {
                         // Commit current widget first
                         const commitTr = view.state.tr.setMeta(key, {
@@ -1213,7 +1327,7 @@ export const inlineReferencePlugin = options => {
                             return false
                         }
                     }
-                    let query, bibList
+                    let query: string, bibList: BibliographyEntry[]
                     if (node.type.name === "citation") {
                         bibList = buildBibliographyList(editor)
                         query = citationToText(node, bibList)
@@ -1240,15 +1354,18 @@ export const inlineReferencePlugin = options => {
                     event.preventDefault()
                     return true
                 },
-                click(view, event) {
+                click(view: EditorView, event: MouseEvent) {
                     // Fallback click handler for touch devices and cases where
                     // mousedown/handleClickOn did not fire.
-                    const pluginState = key.getState(view.state)
+                    const pluginState = key.getState(view.state) as
+                        | InlineReferenceState
+                        | undefined
                     if (pluginState?.active) {
-                        const target = event.target.closest(
+                        const target = event.target as HTMLElement | null
+                        const closest = target?.closest(
                             ".inline-reference-widget"
                         )
-                        if (target) {
+                        if (closest) {
                             // Click inside widget: let widget handle it
                             return false
                         }
@@ -1266,11 +1383,12 @@ export const inlineReferencePlugin = options => {
                     if (event.ctrlKey || event.metaKey || event.shiftKey) {
                         return false
                     }
-                    const target = event.target.closest(".citation")
-                    if (!target) {
+                    const target = event.target as HTMLElement | null
+                    const closest = target?.closest(".citation")
+                    if (!closest) {
                         return false
                     }
-                    const pos = view.posAtDOM(target, 0)
+                    const pos = view.posAtDOM(closest, 0)
                     const node = view.state.doc.nodeAt(pos)
                     if (!node || node.type.name !== "citation") {
                         return false
@@ -1295,8 +1413,10 @@ export const inlineReferencePlugin = options => {
                     return true
                 }
             },
-            handleKeyDown(view, event) {
-                const pluginState = key.getState(view.state)
+            handleKeyDown(view: EditorView, event: KeyboardEvent) {
+                const pluginState = key.getState(view.state) as
+                    | InlineReferenceState
+                    | undefined
                 if (!pluginState?.active) {
                     if (event.key === "@") {
                         const $pos = view.state.selection.$head