@fictjs/eslint-plugin 0.0.5 → 0.0.8

package/dist/index.cjs

@@ -28,6 +28,7 @@ __export(index_exports, {
   noNestedComponents: () => no_nested_components_default,
   noStateDestructureWrite: () => no_state_destructure_write_default,
   noStateInLoop: () => no_state_in_loop_default,
+  noStateOutsideComponent: () => no_state_outside_component_default,
   requireComponentReturn: () => require_component_return_default,
   requireListKey: () => require_list_key_default
 });
@@ -347,8 +348,8 @@ var rule5 = {
   },
   create(context) {
     const componentStack = [];
-    const isUpperCaseName = (name) => !!name && /^[A-Z]/.test(name);
-    const getFunctionName = (node) => {
+    const isUpperCaseName2 = (name) => !!name && /^[A-Z]/.test(name);
+    const getFunctionName2 = (node) => {
       if (node.id?.name) {
         return node.id.name;
       }
@@ -358,7 +359,7 @@ var rule5 = {
       }
       return void 0;
     };
-    const hasJSX = (node) => {
+    const hasJSX2 = (node) => {
       let found = false;
       const visit = (n) => {
         if (found) return;
@@ -386,23 +387,23 @@ var rule5 = {
       visit(node);
       return found;
     };
-    const isComponentLike = (node) => {
-      const name = getFunctionName(node);
-      if (isUpperCaseName(name)) return true;
+    const isComponentLike2 = (node) => {
+      const name = getFunctionName2(node);
+      if (isUpperCaseName2(name)) return true;
       if (node.type === "ArrowFunctionExpression" && node.body) {
         const bodyType = node.body.type;
         if (bodyType === "JSXElement" || bodyType === "JSXFragment") return true;
-        if (bodyType === "BlockStatement" && hasJSX(node.body)) return true;
+        if (bodyType === "BlockStatement" && hasJSX2(node.body)) return true;
       }
-      if (node.type !== "ArrowFunctionExpression" && node.body && hasJSX(node.body))
+      if (node.type !== "ArrowFunctionExpression" && node.body && hasJSX2(node.body))
         return true;
       return false;
     };
     const enterFunction = (node) => {
       const parentIsComponent = componentStack[componentStack.length - 1] ?? false;
-      const currentIsComponent = isComponentLike(node);
+      const currentIsComponent = isComponentLike2(node);
       if (parentIsComponent && currentIsComponent) {
-        const name = getFunctionName(node) ?? "this component";
+        const name = getFunctionName2(node) ?? "this component";
         context.report({
           node,
           messageId: "nestedComponent",
@@ -575,8 +576,115 @@ var rule7 = {
 };
 var no_state_destructure_write_default = rule7;
 
-// src/rules/require-component-return.ts
+// src/rules/no-state-outside-component.ts
+var isUpperCaseName = (name) => !!name && /^[A-Z]/.test(name);
+var isHookName = (name) => !!name && /^use[A-Z]/.test(name);
+var getFunctionName = (node) => {
+  if (node.id?.type === "Identifier") {
+    return node.id.name;
+  }
+  const parent = node.parent;
+  if (parent?.type === "VariableDeclarator" && parent.id.type === "Identifier") {
+    return parent.id.name;
+  }
+  return void 0;
+};
+var hasJSX = (node) => {
+  let found = false;
+  const visit = (n) => {
+    if (found) return;
+    const type = n.type;
+    if (type === "JSXElement" || type === "JSXFragment") {
+      found = true;
+      return;
+    }
+    if (type === "FunctionDeclaration" || type === "FunctionExpression" || type === "ArrowFunctionExpression") {
+      return;
+    }
+    for (const key of Object.keys(n)) {
+      if (key === "parent") continue;
+      const value = n[key];
+      if (!value) continue;
+      if (Array.isArray(value)) {
+        for (const child of value) {
+          if (child && typeof child.type === "string") visit(child);
+        }
+      } else if (value && typeof value.type === "string") {
+        visit(value);
+      }
+    }
+  };
+  visit(node);
+  return found;
+};
+var isComponentLike = (node) => {
+  const name = getFunctionName(node);
+  if (isHookName(name)) return true;
+  if (isUpperCaseName(name)) return true;
+  if (node.type === "ArrowFunctionExpression" && node.body.type !== "BlockStatement") {
+    const bodyType = node.body.type;
+    return bodyType === "JSXElement" || bodyType === "JSXFragment";
+  }
+  if (node.body && hasJSX(node.body)) return true;
+  return false;
+};
+var isInConditional = (ancestors) => ancestors.some(
+  (ancestor) => [
+    "IfStatement",
+    "SwitchStatement",
+    "SwitchCase",
+    "ConditionalExpression",
+    "LogicalExpression"
+  ].includes(ancestor.type)
+);
 var rule8 = {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Require $state to be declared at the top level of a component or hook function body",
+      recommended: true
+    },
+    messages: {
+      moduleScope: "$state must be declared inside a component or hook function body (not at module scope).",
+      componentOnly: "$state should only be used inside a component function (PascalCase or JSX-returning) or a hook (useX).",
+      topLevel: "$state must be at the top level of the component or hook body (not inside conditionals or nested functions)."
+    },
+    schema: []
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (node.callee.type !== "Identifier" || node.callee.name !== "$state") return;
+        const ancestors = context.sourceCode.getAncestors(node);
+        const functionAncestors = ancestors.filter(
+          (ancestor) => ["FunctionDeclaration", "FunctionExpression", "ArrowFunctionExpression"].includes(
+            ancestor.type
+          )
+        );
+        if (functionAncestors.length === 0) {
+          context.report({ node, messageId: "moduleScope" });
+          return;
+        }
+        const nearestFunction = functionAncestors[functionAncestors.length - 1];
+        if (functionAncestors.length > 1) {
+          context.report({ node, messageId: "topLevel" });
+          return;
+        }
+        if (!nearestFunction || !isComponentLike(nearestFunction)) {
+          context.report({ node, messageId: "componentOnly" });
+          return;
+        }
+        if (isInConditional(ancestors)) {
+          context.report({ node, messageId: "topLevel" });
+        }
+      }
+    };
+  }
+};
+var no_state_outside_component_default = rule8;
+
+// src/rules/require-component-return.ts
+var rule9 = {
   meta: {
     type: "problem",
     docs: {
@@ -589,8 +697,8 @@ var rule8 = {
     schema: []
   },
   create(context) {
-    const isUpperCaseName = (name) => !!name && /^[A-Z]/.test(name);
-    const getFunctionName = (node) => {
+    const isUpperCaseName2 = (name) => !!name && /^[A-Z]/.test(name);
+    const getFunctionName2 = (node) => {
       if (node.id?.name) {
         return node.id.name;
       }
@@ -643,8 +751,8 @@ var rule8 = {
       return visit(node);
     };
     const enter = (node) => {
-      const name = getFunctionName(node);
-      const isComponent = isUpperCaseName(name);
+      const name = getFunctionName2(node);
+      const isComponent = isUpperCaseName2(name);
       if (!isComponent) return;
       if (node.type === "ArrowFunctionExpression" && node.body.type !== "BlockStatement") {
         return;
@@ -664,10 +772,10 @@ var rule8 = {
     };
   }
 };
-var require_component_return_default = rule8;
+var require_component_return_default = rule9;
 
 // src/rules/require-list-key.ts
-var rule9 = {
+var rule10 = {
   meta: {
     type: "problem",
     docs: {
@@ -758,7 +866,7 @@ var rule9 = {
     };
   }
 };
-var require_list_key_default = rule9;
+var require_list_key_default = rule10;
 
 // src/index.ts
 var plugin = {
@@ -772,6 +880,7 @@ var plugin = {
     "no-empty-effect": no_empty_effect_default,
     "no-inline-functions": no_inline_functions_default,
     "no-state-destructure-write": no_state_destructure_write_default,
+    "no-state-outside-component": no_state_outside_component_default,
     "no-nested-components": no_nested_components_default,
     "require-list-key": require_list_key_default,
     "no-memo-side-effects": no_memo_side_effects_default,
@@ -788,6 +897,7 @@ var plugin = {
         "fict/no-inline-functions": "warn",
         // FICT-X003
         "fict/no-state-destructure-write": "error",
+        "fict/no-state-outside-component": "error",
         "fict/no-nested-components": "error",
         // FICT-C003
         "fict/require-list-key": "error",
@@ -810,6 +920,7 @@ var index_default = plugin;
   noNestedComponents,
   noStateDestructureWrite,
   noStateInLoop,
+  noStateOutsideComponent,
   requireComponentReturn,
   requireListKey
 });

package/dist/index.d.cts

@@ -1,8 +1,8 @@
 import { Rule, ESLint } from 'eslint';
 
-declare const rule$8: Rule.RuleModule;
+declare const rule$9: Rule.RuleModule;
 
-declare const rule$7: Rule.RuleModule;
+declare const rule$8: Rule.RuleModule;
 
 /**
  * ESLint rule to detect inline functions passed to JSX props.
@@ -10,14 +10,14 @@ declare const rule$7: Rule.RuleModule;
  * This integrates with the compiler's validation module (FICT-X003).
  * Inline functions can cause unnecessary re-renders in reactive frameworks.
  */
+declare const rule$7: Rule.RuleModule;
+
 declare const rule$6: Rule.RuleModule;
 
 declare const rule$5: Rule.RuleModule;
 
 declare const rule$4: Rule.RuleModule;
 
-declare const rule$3: Rule.RuleModule;
-
 /**
  * Prevent writes to aliases created by destructuring a $state-backed object.
  * Example:
@@ -25,6 +25,8 @@ declare const rule$3: Rule.RuleModule;
  *   const { count } = state      // allowed (read)
  *   count++                      // banned – must write via state
  */
+declare const rule$3: Rule.RuleModule;
+
 declare const rule$2: Rule.RuleModule;
 
 declare const rule$1: Rule.RuleModule;
@@ -33,4 +35,4 @@ declare const rule: Rule.RuleModule;
 
 declare const plugin: ESLint.Plugin;
 
-export { plugin as default, rule$8 as noDirectMutation, rule$7 as noEmptyEffect, rule$6 as noInlineFunctions, rule$5 as noMemoSideEffects, rule$4 as noNestedComponents, rule$2 as noStateDestructureWrite, rule$3 as noStateInLoop, rule$1 as requireComponentReturn, rule as requireListKey };
+export { plugin as default, rule$9 as noDirectMutation, rule$8 as noEmptyEffect, rule$7 as noInlineFunctions, rule$6 as noMemoSideEffects, rule$5 as noNestedComponents, rule$3 as noStateDestructureWrite, rule$4 as noStateInLoop, rule$2 as noStateOutsideComponent, rule$1 as requireComponentReturn, rule as requireListKey };

package/dist/index.d.ts

@@ -1,8 +1,8 @@
 import { Rule, ESLint } from 'eslint';
 
-declare const rule$8: Rule.RuleModule;
+declare const rule$9: Rule.RuleModule;
 
-declare const rule$7: Rule.RuleModule;
+declare const rule$8: Rule.RuleModule;
 
 /**
  * ESLint rule to detect inline functions passed to JSX props.
@@ -10,14 +10,14 @@ declare const rule$7: Rule.RuleModule;
  * This integrates with the compiler's validation module (FICT-X003).
  * Inline functions can cause unnecessary re-renders in reactive frameworks.
  */
+declare const rule$7: Rule.RuleModule;
+
 declare const rule$6: Rule.RuleModule;
 
 declare const rule$5: Rule.RuleModule;
 
 declare const rule$4: Rule.RuleModule;
 
-declare const rule$3: Rule.RuleModule;
-
 /**
  * Prevent writes to aliases created by destructuring a $state-backed object.
  * Example:
@@ -25,6 +25,8 @@ declare const rule$3: Rule.RuleModule;
  *   const { count } = state      // allowed (read)
  *   count++                      // banned – must write via state
  */
+declare const rule$3: Rule.RuleModule;
+
 declare const rule$2: Rule.RuleModule;
 
 declare const rule$1: Rule.RuleModule;
@@ -33,4 +35,4 @@ declare const rule: Rule.RuleModule;
 
 declare const plugin: ESLint.Plugin;
 
-export { plugin as default, rule$8 as noDirectMutation, rule$7 as noEmptyEffect, rule$6 as noInlineFunctions, rule$5 as noMemoSideEffects, rule$4 as noNestedComponents, rule$2 as noStateDestructureWrite, rule$3 as noStateInLoop, rule$1 as requireComponentReturn, rule as requireListKey };
+export { plugin as default, rule$9 as noDirectMutation, rule$8 as noEmptyEffect, rule$7 as noInlineFunctions, rule$6 as noMemoSideEffects, rule$5 as noNestedComponents, rule$3 as noStateDestructureWrite, rule$4 as noStateInLoop, rule$2 as noStateOutsideComponent, rule$1 as requireComponentReturn, rule as requireListKey };

package/dist/index.js

@@ -312,8 +312,8 @@ var rule5 = {
   },
   create(context) {
     const componentStack = [];
-    const isUpperCaseName = (name) => !!name && /^[A-Z]/.test(name);
-    const getFunctionName = (node) => {
+    const isUpperCaseName2 = (name) => !!name && /^[A-Z]/.test(name);
+    const getFunctionName2 = (node) => {
       if (node.id?.name) {
         return node.id.name;
       }
@@ -323,7 +323,7 @@ var rule5 = {
       }
       return void 0;
     };
-    const hasJSX = (node) => {
+    const hasJSX2 = (node) => {
       let found = false;
       const visit = (n) => {
         if (found) return;
@@ -351,23 +351,23 @@ var rule5 = {
       visit(node);
       return found;
     };
-    const isComponentLike = (node) => {
-      const name = getFunctionName(node);
-      if (isUpperCaseName(name)) return true;
+    const isComponentLike2 = (node) => {
+      const name = getFunctionName2(node);
+      if (isUpperCaseName2(name)) return true;
       if (node.type === "ArrowFunctionExpression" && node.body) {
         const bodyType = node.body.type;
         if (bodyType === "JSXElement" || bodyType === "JSXFragment") return true;
-        if (bodyType === "BlockStatement" && hasJSX(node.body)) return true;
+        if (bodyType === "BlockStatement" && hasJSX2(node.body)) return true;
       }
-      if (node.type !== "ArrowFunctionExpression" && node.body && hasJSX(node.body))
+      if (node.type !== "ArrowFunctionExpression" && node.body && hasJSX2(node.body))
         return true;
       return false;
     };
     const enterFunction = (node) => {
       const parentIsComponent = componentStack[componentStack.length - 1] ?? false;
-      const currentIsComponent = isComponentLike(node);
+      const currentIsComponent = isComponentLike2(node);
       if (parentIsComponent && currentIsComponent) {
-        const name = getFunctionName(node) ?? "this component";
+        const name = getFunctionName2(node) ?? "this component";
         context.report({
           node,
           messageId: "nestedComponent",
@@ -540,8 +540,115 @@ var rule7 = {
 };
 var no_state_destructure_write_default = rule7;
 
-// src/rules/require-component-return.ts
+// src/rules/no-state-outside-component.ts
+var isUpperCaseName = (name) => !!name && /^[A-Z]/.test(name);
+var isHookName = (name) => !!name && /^use[A-Z]/.test(name);
+var getFunctionName = (node) => {
+  if (node.id?.type === "Identifier") {
+    return node.id.name;
+  }
+  const parent = node.parent;
+  if (parent?.type === "VariableDeclarator" && parent.id.type === "Identifier") {
+    return parent.id.name;
+  }
+  return void 0;
+};
+var hasJSX = (node) => {
+  let found = false;
+  const visit = (n) => {
+    if (found) return;
+    const type = n.type;
+    if (type === "JSXElement" || type === "JSXFragment") {
+      found = true;
+      return;
+    }
+    if (type === "FunctionDeclaration" || type === "FunctionExpression" || type === "ArrowFunctionExpression") {
+      return;
+    }
+    for (const key of Object.keys(n)) {
+      if (key === "parent") continue;
+      const value = n[key];
+      if (!value) continue;
+      if (Array.isArray(value)) {
+        for (const child of value) {
+          if (child && typeof child.type === "string") visit(child);
+        }
+      } else if (value && typeof value.type === "string") {
+        visit(value);
+      }
+    }
+  };
+  visit(node);
+  return found;
+};
+var isComponentLike = (node) => {
+  const name = getFunctionName(node);
+  if (isHookName(name)) return true;
+  if (isUpperCaseName(name)) return true;
+  if (node.type === "ArrowFunctionExpression" && node.body.type !== "BlockStatement") {
+    const bodyType = node.body.type;
+    return bodyType === "JSXElement" || bodyType === "JSXFragment";
+  }
+  if (node.body && hasJSX(node.body)) return true;
+  return false;
+};
+var isInConditional = (ancestors) => ancestors.some(
+  (ancestor) => [
+    "IfStatement",
+    "SwitchStatement",
+    "SwitchCase",
+    "ConditionalExpression",
+    "LogicalExpression"
+  ].includes(ancestor.type)
+);
 var rule8 = {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Require $state to be declared at the top level of a component or hook function body",
+      recommended: true
+    },
+    messages: {
+      moduleScope: "$state must be declared inside a component or hook function body (not at module scope).",
+      componentOnly: "$state should only be used inside a component function (PascalCase or JSX-returning) or a hook (useX).",
+      topLevel: "$state must be at the top level of the component or hook body (not inside conditionals or nested functions)."
+    },
+    schema: []
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (node.callee.type !== "Identifier" || node.callee.name !== "$state") return;
+        const ancestors = context.sourceCode.getAncestors(node);
+        const functionAncestors = ancestors.filter(
+          (ancestor) => ["FunctionDeclaration", "FunctionExpression", "ArrowFunctionExpression"].includes(
+            ancestor.type
+          )
+        );
+        if (functionAncestors.length === 0) {
+          context.report({ node, messageId: "moduleScope" });
+          return;
+        }
+        const nearestFunction = functionAncestors[functionAncestors.length - 1];
+        if (functionAncestors.length > 1) {
+          context.report({ node, messageId: "topLevel" });
+          return;
+        }
+        if (!nearestFunction || !isComponentLike(nearestFunction)) {
+          context.report({ node, messageId: "componentOnly" });
+          return;
+        }
+        if (isInConditional(ancestors)) {
+          context.report({ node, messageId: "topLevel" });
+        }
+      }
+    };
+  }
+};
+var no_state_outside_component_default = rule8;
+
+// src/rules/require-component-return.ts
+var rule9 = {
   meta: {
     type: "problem",
     docs: {
@@ -554,8 +661,8 @@ var rule8 = {
     schema: []
   },
   create(context) {
-    const isUpperCaseName = (name) => !!name && /^[A-Z]/.test(name);
-    const getFunctionName = (node) => {
+    const isUpperCaseName2 = (name) => !!name && /^[A-Z]/.test(name);
+    const getFunctionName2 = (node) => {
       if (node.id?.name) {
         return node.id.name;
       }
@@ -608,8 +715,8 @@ var rule8 = {
       return visit(node);
     };
     const enter = (node) => {
-      const name = getFunctionName(node);
-      const isComponent = isUpperCaseName(name);
+      const name = getFunctionName2(node);
+      const isComponent = isUpperCaseName2(name);
       if (!isComponent) return;
       if (node.type === "ArrowFunctionExpression" && node.body.type !== "BlockStatement") {
         return;
@@ -629,10 +736,10 @@ var rule8 = {
     };
   }
 };
-var require_component_return_default = rule8;
+var require_component_return_default = rule9;
 
 // src/rules/require-list-key.ts
-var rule9 = {
+var rule10 = {
   meta: {
     type: "problem",
     docs: {
@@ -723,7 +830,7 @@ var rule9 = {
     };
   }
 };
-var require_list_key_default = rule9;
+var require_list_key_default = rule10;
 
 // src/index.ts
 var plugin = {
@@ -737,6 +844,7 @@ var plugin = {
     "no-empty-effect": no_empty_effect_default,
     "no-inline-functions": no_inline_functions_default,
     "no-state-destructure-write": no_state_destructure_write_default,
+    "no-state-outside-component": no_state_outside_component_default,
     "no-nested-components": no_nested_components_default,
     "require-list-key": require_list_key_default,
     "no-memo-side-effects": no_memo_side_effects_default,
@@ -753,6 +861,7 @@ var plugin = {
         "fict/no-inline-functions": "warn",
         // FICT-X003
         "fict/no-state-destructure-write": "error",
+        "fict/no-state-outside-component": "error",
         "fict/no-nested-components": "error",
         // FICT-C003
         "fict/require-list-key": "error",
@@ -775,6 +884,7 @@ export {
   no_nested_components_default as noNestedComponents,
   no_state_destructure_write_default as noStateDestructureWrite,
   no_state_in_loop_default as noStateInLoop,
+  no_state_outside_component_default as noStateOutsideComponent,
   require_component_return_default as requireComponentReturn,
   require_list_key_default as requireListKey
 };

package/package.json

@@ -1,9 +1,15 @@
 {
   "name": "@fictjs/eslint-plugin",
-  "version": "0.0.5",
+  "version": "0.0.8",
   "description": "ESLint plugin for Fict",
   "publishConfig": {
-    "access": "public"
+    "access": "public",
+    "provenance": true
+  },
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/fictjs/fict.git",
+    "directory": "packages/eslint-plugin"
   },
   "type": "module",
   "main": "dist/index.cjs",