@fiale-plus/pi-rogue-advisor 0.1.5 → 0.1.6

package/README.md

@@ -37,11 +37,11 @@ npm install --workspace packages/advisor
 
 - `mode`: `auto`
 - `review`: `light`
-- `checkins`: `mid-hour`
+- `checkins`: `off` (orchestration turns them on while a goal/autoresearch flow is active)
 - `checkinIntervalMinutes`: `30`
 - `model`: not set (auto-detected)
 
-Check-ins gate on session activity, are bounded, and avoid overlapping calls.
+Check-ins gate on session activity, are bounded, and avoid overlapping calls. They can still be controlled explicitly with `/advisor checkins on|off|<minutes>`.
 
 ## Stability guarantees
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fiale-plus/pi-rogue-advisor",
-  "version": "0.1.5",
+  "version": "0.1.6",
   "description": "Pi-Rogue advisor extension for Pi — multi-model support, SOTA model suggestion, cache-aware session advisory.",
   "type": "module",
   "license": "MIT",

package/skills/advisor/SKILL.md

@@ -43,6 +43,6 @@ The advisor surface is separate from orchestration (`goal`/`loop`/`autoresearch`
 
 - `mode: auto`
 - `review: light`
-- `checkins: mid-hour`
+- `checkins: off` by default; orchestration enables them while a goal/autoresearch flow is active
 - `checkinIntervalMinutes: 30`
 - `model: auto`

package/src/extension.test.ts

@@ -18,11 +18,11 @@ function state(overrides: Record<string, unknown> = {}) {
 }
 
 describe("AdvisorConfig", () => {
-  it("defaults to auto mode, light review, and mid-hour check-ins", () => {
+  it("defaults to auto mode, light review, and goal-scoped check-ins off", () => {
     const cfg = normalizeAdvisorConfig({});
     expect(cfg.mode).toBe("auto");
     expect(cfg.review).toBe("light");
-    expect(cfg.checkins).toBe("mid-hour");
+    expect(cfg.checkins).toBe("off");
     expect(cfg.checkinIntervalMinutes).toBe(30);
     expect(cfg.model).toBeUndefined();
   });
@@ -57,7 +57,7 @@ describe("AdvisorConfig", () => {
     const parsed = normalizeAdvisorConfig(JSON.parse(json) as AdvisorConfig);
     expect(parsed.mode).toBe("auto");
     expect(parsed.review).toBe("light");
-    expect(parsed.checkins).toBe("mid-hour");
+    expect(parsed.checkins).toBe("off");
     expect(parsed.checkinIntervalMinutes).toBe(30);
     expect(parsed.model).toBe("claude-opus-4-6");
   });
@@ -65,21 +65,21 @@ describe("AdvisorConfig", () => {
 
 describe("mid-hour check-ins", () => {
   it("does not run immediately after session start", () => {
-    const cfg = normalizeAdvisorConfig({ checkinIntervalMinutes: 30 });
+    const cfg = normalizeAdvisorConfig({ checkins: "mid-hour", checkinIntervalMinutes: 30 });
     const startedAt = 1_000;
     const now = startedAt + 5 * 60_000;
     expect(shouldRunCheckin(cfg, state(), now, startedAt)).toBeNull();
   });
 
   it("runs after interval when there was new activity", () => {
-    const cfg = normalizeAdvisorConfig({ checkinIntervalMinutes: 30 });
+    const cfg = normalizeAdvisorConfig({ checkins: "mid-hour", checkinIntervalMinutes: 30 });
     const startedAt = 1_000;
     const now = startedAt + 31 * 60_000;
     expect(shouldRunCheckin(cfg, state(), now, startedAt)).toMatch(/mid-hour check-in/);
   });
 
   it("does not run without activity since the last check-in", () => {
-    const cfg = normalizeAdvisorConfig({ checkinIntervalMinutes: 30 });
+    const cfg = normalizeAdvisorConfig({ checkins: "mid-hour", checkinIntervalMinutes: 30 });
     const lastAt = new Date(1_000).toISOString();
     const now = 1_000 + 60 * 60_000;
     expect(shouldRunCheckin(cfg, state({ turns: 5, checkin: { lastAt, lastTurn: 5 } }), now, 1_000)).toBeNull();

package/src/extension.ts

@@ -38,7 +38,7 @@ export interface AdvisorConfig {
 const DEFAULT_CONFIG: AdvisorConfig = {
   mode: "auto",
   review: "light",
-  checkins: "mid-hour",
+  checkins: "off",
   checkinIntervalMinutes: 30,
 };
 
@@ -121,7 +121,7 @@ export function normalizeAdvisorConfig(raw: Partial<AdvisorConfig> = {}): Adviso
   return {
     mode: (raw.mode === "manual" || raw.mode === "off") ? raw.mode : "auto",
     review: (raw.review === "strict" || raw.review === "off") ? raw.review : "light",
-    checkins: raw.checkins === "off" ? "off" : "mid-hour",
+    checkins: raw.checkins === "mid-hour" ? "mid-hour" : DEFAULT_CONFIG.checkins,
     checkinIntervalMinutes: Math.min(MAX_CHECKIN_INTERVAL_MINUTES, Math.max(MIN_CHECKIN_INTERVAL_MINUTES, Number.isFinite(interval) ? Math.round(interval) : DEFAULT_CONFIG.checkinIntervalMinutes)),
     model: raw.model || undefined,
   };