@fiado/type-kit 3.661.0 → 3.662.0

package/_test_/unit/common/InputPatterns.test.ts

@@ -4,6 +4,7 @@ import {
     EMAIL_PATTERN,
     HTTPS_URL_PATTERN,
     IMEI_PATTERN,
+    PHONE_E164_PATTERN,
     PHONE_MX_ACCEPTED_PATTERN,
     PHONE_MX_PATTERN,
     RFC_PATTERN,
@@ -34,6 +35,14 @@ describe('InputPatterns', () => {
         );
     });
 
+    describe('PHONE_E164_PATTERN (celular guardado)', () => {
+        it('acepta +52 con 10 dígitos', () => expect(PHONE_E164_PATTERN.test('+525512345678')).toBe(true));
+        it.each(['5512345678', '525512345678', '+15512345678', '+52551234567', '+5255123456789', '+52 5512345678', ''])(
+            'rechaza %s',
+            (v) => expect(PHONE_E164_PATTERN.test(v)).toBe(false),
+        );
+    });
+
     describe('EMAIL_PATTERN', () => {
         it.each(['ana@somosfiado.com', 'a.b+tag@sub.dominio.mx'])('acepta %s', (v) => expect(EMAIL_PATTERN.test(v)).toBe(true));
         it.each(['ana', 'ana@', '@fiado.com', 'ana@fiado', 'ana @fiado.com', 'ana@@fiado.com', ''])(

package/_test_/unit/common/phoneE164Contract.test.ts

@@ -0,0 +1,29 @@
+import 'reflect-metadata';
+import { plainToInstance, type ClassConstructor } from 'class-transformer';
+import { validateSync } from 'class-validator';
+import { EvaluateSciRequest } from '../../../src/loanScoring/dtos/requests/EvaluateSciRequest';
+import { UpsertCustomerFromKycRequest } from '../../../src/retailCustomer/dtos/requests/UpsertCustomerFromKycRequest';
+import { LinkRetailUserWalletRequest } from '../../../src/retailOrg/dtos/requests/LinkRetailUserWalletRequest';
+import { LookupRetailUserWalletRequest } from '../../../src/retailOrg/dtos/requests/LookupRetailUserWalletRequest';
+import { StartSessionRequest } from '../../../src/retailWizard/dtos/requests/StartSessionRequest';
+
+const failsOn = (cls: ClassConstructor<object>, field: string, value: unknown): boolean =>
+    validateSync(plainToInstance(cls, { [field]: value })).some((error) => error.property === field);
+
+const dtos: Array<[string, ClassConstructor<object>, string]> = [
+    ['StartSessionRequest', StartSessionRequest, 'phone'],
+    ['UpsertCustomerFromKycRequest', UpsertCustomerFromKycRequest, 'phone'],
+    ['EvaluateSciRequest', EvaluateSciRequest, 'cellphone'],
+    ['LinkRetailUserWalletRequest', LinkRetailUserWalletRequest, 'phone'],
+    ['LookupRetailUserWalletRequest', LookupRetailUserWalletRequest, 'phone'],
+];
+
+describe.each(dtos)('%s en la transición a E.164', (_name, cls, field) => {
+    it.each(['5512345678', '+525512345678'])('acepta %s', (value) => {
+        expect(failsOn(cls, field, value)).toBe(false);
+    });
+
+    it.each(['+15512345678', '525512345678', '551234567', '+52551234567'])('rechaza %s', (value) => {
+        expect(failsOn(cls, field, value)).toBe(true);
+    });
+});

package/_test_/unit/loanScoring/evaluateSciRequest.test.ts

@@ -30,8 +30,8 @@ describe('EvaluateSciRequest', () => {
         expect(await errorProperties({ ...BODY, curp: 'XOAC900101HDFRRL05' })).toEqual([]);
     });
 
-    it('rechaza celular con +52 o separadores, y borrowerId que no es ULID (L-177)', async () => {
-        const body = { ...BODY, cellphone: '+525512345678', borrowerId: 'SMOKE-B-LSB' };
+    it('rechaza celular con otra lada o separadores, y borrowerId que no es ULID (L-177)', async () => {
+        const body = { ...BODY, cellphone: '+15512345678', borrowerId: 'SMOKE-B-LSB' };
         expect(await errorProperties(body)).toEqual(['borrowerId', 'cellphone']);
         expect(await errorProperties({ ...BODY, cellphone: '55 1234 5678' })).toEqual(['cellphone']);
     });

package/bin/common/constants/InputPatterns.d.ts

@@ -3,6 +3,9 @@ export declare const PHONE_MX_PATTERN: RegExp;
 /** Teléfono MX en el backend: 10 dígitos, opcionalmente con `+52` para clientes que ya lo mandan. */
 export declare const PHONE_MX_ACCEPTED_PATTERN: RegExp;
 export declare const PHONE_MX_MESSAGE = "El tel\u00E9fono debe tener 10 d\u00EDgitos";
+/** Celular guardado en todo SureKeep: `+52` y 10 dígitos. */
+export declare const PHONE_E164_PATTERN: RegExp;
+export declare const PHONE_E164_MESSAGE = "El tel\u00E9fono debe tener el formato +52 y 10 d\u00EDgitos";
 /** Correo pragmático: algo@dominio.tld, sin espacios. */
 export declare const EMAIL_PATTERN: RegExp;
 export declare const EMAIL_MAX_LENGTH = 254;

package/bin/common/constants/InputPatterns.js

@@ -1,11 +1,14 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.HTTPS_URL_MESSAGE = exports.HTTPS_URL_PATTERN = exports.IMEI_MESSAGE = exports.IMEI_PATTERN = exports.SKU_MESSAGE = exports.SKU_MAX_LENGTH = exports.SKU_PATTERN = exports.ZIP_CODE_MX_MESSAGE = exports.ZIP_CODE_MX_PATTERN = exports.RFC_MESSAGE = exports.RFC_PATTERN = exports.EMAIL_MESSAGE = exports.EMAIL_MAX_LENGTH = exports.EMAIL_PATTERN = exports.PHONE_MX_MESSAGE = exports.PHONE_MX_ACCEPTED_PATTERN = exports.PHONE_MX_PATTERN = void 0;
+exports.HTTPS_URL_MESSAGE = exports.HTTPS_URL_PATTERN = exports.IMEI_MESSAGE = exports.IMEI_PATTERN = exports.SKU_MESSAGE = exports.SKU_MAX_LENGTH = exports.SKU_PATTERN = exports.ZIP_CODE_MX_MESSAGE = exports.ZIP_CODE_MX_PATTERN = exports.RFC_MESSAGE = exports.RFC_PATTERN = exports.EMAIL_MESSAGE = exports.EMAIL_MAX_LENGTH = exports.EMAIL_PATTERN = exports.PHONE_E164_MESSAGE = exports.PHONE_E164_PATTERN = exports.PHONE_MX_MESSAGE = exports.PHONE_MX_ACCEPTED_PATTERN = exports.PHONE_MX_PATTERN = void 0;
 /** Teléfono MX tal como se teclea en la UI: exactamente 10 dígitos. */
 exports.PHONE_MX_PATTERN = /^\d{10}$/;
 /** Teléfono MX en el backend: 10 dígitos, opcionalmente con `+52` para clientes que ya lo mandan. */
 exports.PHONE_MX_ACCEPTED_PATTERN = /^(?:\+52)?\d{10}$/;
 exports.PHONE_MX_MESSAGE = 'El teléfono debe tener 10 dígitos';
+/** Celular guardado en todo SureKeep: `+52` y 10 dígitos. */
+exports.PHONE_E164_PATTERN = /^\+52\d{10}$/;
+exports.PHONE_E164_MESSAGE = 'El teléfono debe tener el formato +52 y 10 dígitos';
 /** Correo pragmático: algo@dominio.tld, sin espacios. */
 exports.EMAIL_PATTERN = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
 exports.EMAIL_MAX_LENGTH = 254;

package/bin/loanScoring/dtos/requests/EvaluateSciRequest.d.ts

@@ -26,7 +26,7 @@ export declare class EvaluateSciRequest {
      * tumbaría la evaluación del wizard. El formato lo revisa loan-scoring antes de consultar (L-177, A).
      */
     curp: string;
-    /** Celular del solicitante: 10 dígitos, sin `+52` (requerido por Modelias). */
+    /** Celular del solicitante: 10 dígitos, con o sin `+52`; loan-scoring lo manda a 10 a Modelias. */
     cellphone: string;
     email?: string;
     /**

package/bin/loanScoring/dtos/requests/EvaluateSciRequest.js

@@ -55,7 +55,7 @@ __decorate([
 __decorate([
     (0, class_validator_1.IsString)(),
     (0, class_validator_1.IsNotEmpty)(),
-    (0, class_validator_1.Matches)(InputPatterns_1.PHONE_MX_PATTERN, { message: 'cellphone debe tener 10 dígitos' }),
+    (0, class_validator_1.Matches)(InputPatterns_1.PHONE_MX_ACCEPTED_PATTERN, { message: 'cellphone debe tener 10 dígitos, con o sin +52' }),
     __metadata("design:type", String)
 ], EvaluateSciRequest.prototype, "cellphone", void 0);
 __decorate([

package/bin/retailCustomer/dtos/requests/UpsertCustomerFromKycRequest.js

@@ -12,6 +12,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.UpsertCustomerFromKycRequest = void 0;
 const class_transformer_1 = require("class-transformer");
 const class_validator_1 = require("class-validator");
+const InputPatterns_1 = require("../../../common/constants/InputPatterns");
 const regex_1 = require("../../../helpers/constans/regex");
 const RetailAddress_1 = require("../RetailAddress");
 const KycMethodEnum_1 = require("../../enums/KycMethodEnum");
@@ -56,7 +57,7 @@ __decorate([
     (0, class_transformer_1.Expose)(),
     (0, class_transformer_1.Transform)(({ value }) => (typeof value === 'string' ? value.replace(/[\s-]/g, '') : value)),
     (0, class_validator_1.IsString)(),
-    (0, class_validator_1.Matches)(regex_1.regexPhoneMx, { message: 'phone debe ser 10 dígitos MX' }),
+    (0, class_validator_1.Matches)(InputPatterns_1.PHONE_MX_ACCEPTED_PATTERN, { message: 'phone debe ser 10 dígitos MX, con o sin +52' }),
     __metadata("design:type", String)
 ], UpsertCustomerFromKycRequest.prototype, "phone", void 0);
 __decorate([

package/bin/retailOrg/dtos/requests/LinkRetailUserWalletRequest.js

@@ -12,6 +12,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.LinkRetailUserWalletRequest = void 0;
 const class_transformer_1 = require("class-transformer");
 const class_validator_1 = require("class-validator");
+const InputPatterns_1 = require("../../../common/constants/InputPatterns");
 const IsSingleWalletKeyConstraint_1 = require("../../validators/IsSingleWalletKeyConstraint");
 /**
  * Body de `PUT /retailers/{retailerId}/users/{retailUserId}/wallet`: vincula la wallet PCF del
@@ -32,6 +33,6 @@ __decorate([
     (0, class_transformer_1.Expose)(),
     (0, class_validator_1.IsOptional)(),
     (0, class_validator_1.IsString)({ message: 'phone debe ser texto' }),
-    (0, class_validator_1.Matches)(/^(\+52)?\d{10}$/, { message: 'phone debe tener 10 dígitos, con o sin +52' }),
+    (0, class_validator_1.Matches)(InputPatterns_1.PHONE_MX_ACCEPTED_PATTERN, { message: 'phone debe tener 10 dígitos, con o sin +52' }),
     __metadata("design:type", String)
 ], LinkRetailUserWalletRequest.prototype, "phone", void 0);

package/bin/retailOrg/dtos/requests/LookupRetailUserWalletRequest.js

@@ -12,6 +12,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.LookupRetailUserWalletRequest = void 0;
 const class_transformer_1 = require("class-transformer");
 const class_validator_1 = require("class-validator");
+const InputPatterns_1 = require("../../../common/constants/InputPatterns");
 const IsSingleWalletKeyConstraint_1 = require("../../validators/IsSingleWalletKeyConstraint");
 /**
  * Body de `POST /retailers/{retailerId}/users/wallet-lookup`: busca una wallet PCF por CLABE o por
@@ -32,6 +33,6 @@ __decorate([
     (0, class_transformer_1.Expose)(),
     (0, class_validator_1.IsOptional)(),
     (0, class_validator_1.IsString)({ message: 'phone debe ser texto' }),
-    (0, class_validator_1.Matches)(/^(\+52)?\d{10}$/, { message: 'phone debe tener 10 dígitos, con o sin +52' }),
+    (0, class_validator_1.Matches)(InputPatterns_1.PHONE_MX_ACCEPTED_PATTERN, { message: 'phone debe tener 10 dígitos, con o sin +52' }),
     __metadata("design:type", String)
 ], LookupRetailUserWalletRequest.prototype, "phone", void 0);

package/bin/retailWizard/dtos/requests/StartSessionRequest.js

@@ -12,7 +12,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.StartSessionRequest = void 0;
 const class_transformer_1 = require("class-transformer");
 const class_validator_1 = require("class-validator");
-const regex_1 = require("../../../helpers/constans/regex");
+const InputPatterns_1 = require("../../../common/constants/InputPatterns");
 /**
  * POST /wizard/sessions — arranca (o reanuda) la saga del wizard para un teléfono.
  * `retailerId`/`storeId`/`sellerRetailUserId` NO viajan en el body: se derivan del JWT del vendedor.
@@ -24,7 +24,7 @@ exports.StartSessionRequest = StartSessionRequest;
 __decorate([
     (0, class_transformer_1.Expose)(),
     (0, class_validator_1.IsString)(),
-    (0, class_validator_1.Matches)(regex_1.regexPhoneMx, { message: 'phone debe ser un teléfono MX de 10 dígitos' }),
+    (0, class_validator_1.Matches)(InputPatterns_1.PHONE_MX_ACCEPTED_PATTERN, { message: 'phone debe ser un teléfono MX de 10 dígitos, con o sin +52' }),
     __metadata("design:type", String)
 ], StartSessionRequest.prototype, "phone", void 0);
 __decorate([

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fiado/type-kit",
-  "version": "3.661.0",
+  "version": "3.662.0",
   "description": "",
   "main": "bin/index.js",
   "types": "bin/index.d.ts",

package/src/common/constants/InputPatterns.ts

@@ -5,6 +5,10 @@ export const PHONE_MX_PATTERN = /^\d{10}$/;
 export const PHONE_MX_ACCEPTED_PATTERN = /^(?:\+52)?\d{10}$/;
 export const PHONE_MX_MESSAGE = 'El teléfono debe tener 10 dígitos';
 
+/** Celular guardado en todo SureKeep: `+52` y 10 dígitos. */
+export const PHONE_E164_PATTERN = /^\+52\d{10}$/;
+export const PHONE_E164_MESSAGE = 'El teléfono debe tener el formato +52 y 10 dígitos';
+
 /** Correo pragmático: algo@dominio.tld, sin espacios. */
 export const EMAIL_PATTERN = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
 export const EMAIL_MAX_LENGTH = 254;

package/src/loanScoring/dtos/requests/EvaluateSciRequest.ts

@@ -1,6 +1,6 @@
 import { Type } from 'class-transformer';
 import { IsBoolean, IsEmail, IsNotEmpty, IsOptional, IsString, Matches, MaxLength, ValidateNested } from 'class-validator';
-import { PHONE_MX_PATTERN } from '../../../common/constants/InputPatterns';
+import { PHONE_MX_ACCEPTED_PATTERN } from '../../../common/constants/InputPatterns';
 import { CREDIT_ID_PATTERN } from '../../../common/constants/CreditIdPattern';
 import { SciInternalHistoryInput } from './SciInternalHistoryInput';
 
@@ -49,10 +49,10 @@ export class EvaluateSciRequest {
     @MaxLength(64)
     curp!: string;
 
-    /** Celular del solicitante: 10 dígitos, sin `+52` (requerido por Modelias). */
+    /** Celular del solicitante: 10 dígitos, con o sin `+52`; loan-scoring lo manda a 10 a Modelias. */
     @IsString()
     @IsNotEmpty()
-    @Matches(PHONE_MX_PATTERN, { message: 'cellphone debe tener 10 dígitos' })
+    @Matches(PHONE_MX_ACCEPTED_PATTERN, { message: 'cellphone debe tener 10 dígitos, con o sin +52' })
     cellphone!: string;
 
     @IsOptional()

package/src/retailCustomer/dtos/requests/UpsertCustomerFromKycRequest.ts

@@ -10,7 +10,8 @@ import {
     Matches,
     ValidateNested,
 } from 'class-validator';
-import { regexCurp, regexIso8601Date, regexPhoneMx } from '../../../helpers/constans/regex';
+import { PHONE_MX_ACCEPTED_PATTERN } from '../../../common/constants/InputPatterns';
+import { regexCurp, regexIso8601Date } from '../../../helpers/constans/regex';
 import { RetailAddress } from '../RetailAddress';
 import { KycMethodEnum } from '../../enums/KycMethodEnum';
 import { KycModalityEnum } from '../../enums/KycModalityEnum';
@@ -53,7 +54,7 @@ export class UpsertCustomerFromKycRequest {
     @Expose()
     @Transform(({ value }) => (typeof value === 'string' ? value.replace(/[\s-]/g, '') : value))
     @IsString()
-    @Matches(regexPhoneMx, { message: 'phone debe ser 10 dígitos MX' })
+    @Matches(PHONE_MX_ACCEPTED_PATTERN, { message: 'phone debe ser 10 dígitos MX, con o sin +52' })
     phone!: string;
 
     // Normalización en el boundary: el CURP se uppercasea para no evadir la unicidad transaccional

package/src/retailOrg/dtos/requests/LinkRetailUserWalletRequest.ts

@@ -1,5 +1,6 @@
 import { Expose } from 'class-transformer';
 import { IsOptional, IsString, Matches, Validate, ValidateIf } from 'class-validator';
+import { PHONE_MX_ACCEPTED_PATTERN } from '../../../common/constants/InputPatterns';
 import { IsSingleWalletKeyConstraint } from '../../validators/IsSingleWalletKeyConstraint';
 
 /**
@@ -19,6 +20,6 @@ export class LinkRetailUserWalletRequest {
     @Expose()
     @IsOptional()
     @IsString({ message: 'phone debe ser texto' })
-    @Matches(/^(\+52)?\d{10}$/, { message: 'phone debe tener 10 dígitos, con o sin +52' })
+    @Matches(PHONE_MX_ACCEPTED_PATTERN, { message: 'phone debe tener 10 dígitos, con o sin +52' })
     phone?: string | null;
 }

package/src/retailOrg/dtos/requests/LookupRetailUserWalletRequest.ts

@@ -1,5 +1,6 @@
 import { Expose } from 'class-transformer';
 import { IsOptional, IsString, Matches, Validate, ValidateIf } from 'class-validator';
+import { PHONE_MX_ACCEPTED_PATTERN } from '../../../common/constants/InputPatterns';
 import { IsSingleWalletKeyConstraint } from '../../validators/IsSingleWalletKeyConstraint';
 
 /**
@@ -19,6 +20,6 @@ export class LookupRetailUserWalletRequest {
     @Expose()
     @IsOptional()
     @IsString({ message: 'phone debe ser texto' })
-    @Matches(/^(\+52)?\d{10}$/, { message: 'phone debe tener 10 dígitos, con o sin +52' })
+    @Matches(PHONE_MX_ACCEPTED_PATTERN, { message: 'phone debe tener 10 dígitos, con o sin +52' })
     phone?: string | null;
 }

package/src/retailWizard/dtos/requests/StartSessionRequest.ts

@@ -1,6 +1,6 @@
 import { Expose } from 'class-transformer';
 import { IsBoolean, IsOptional, IsString, Matches } from 'class-validator';
-import { regexPhoneMx } from '../../../helpers/constans/regex';
+import { PHONE_MX_ACCEPTED_PATTERN } from '../../../common/constants/InputPatterns';
 
 /**
  * POST /wizard/sessions — arranca (o reanuda) la saga del wizard para un teléfono.
@@ -10,7 +10,7 @@ import { regexPhoneMx } from '../../../helpers/constans/regex';
 export class StartSessionRequest {
   @Expose()
   @IsString()
-  @Matches(regexPhoneMx, { message: 'phone debe ser un teléfono MX de 10 dígitos' })
+  @Matches(PHONE_MX_ACCEPTED_PATTERN, { message: 'phone debe ser un teléfono MX de 10 dígitos, con o sin +52' })
   phone!: string;
 
   /** Prospecto a reanudar (opcional): si viene, la sesión se vincula al prospecto. */