@fiado/type-kit 3.626.0 → 3.628.0

package/src/loanOfferings/dtos/requests/ChangeCreditPlanStatusRequest.ts

@@ -1,5 +1,6 @@
 import { Expose } from 'class-transformer';
-import { IsEnum } from 'class-validator';
+import { IsEnum, IsOptional, IsString, MaxLength } from 'class-validator';
+import { OFFERINGS_AUDIT_REASON_MAX_LENGTH } from '../../constants/offeringsInputLimits';
 import { CreditPlanStatusEnum } from '../../enums/CreditPlanStatusEnum';
 
 /**
@@ -10,4 +11,11 @@ export class ChangeCreditPlanStatusRequest {
     @Expose()
     @IsEnum(CreditPlanStatusEnum)
     status!: CreditPlanStatusEnum;
+
+    /** Motivo del cambio; queda en la bitácora del plan. */
+    @Expose()
+    @IsOptional()
+    @IsString()
+    @MaxLength(OFFERINGS_AUDIT_REASON_MAX_LENGTH)
+    reason?: string;
 }

package/src/loanOfferings/dtos/requests/ChangePromotionStatusRequest.ts

@@ -1,5 +1,6 @@
 import { Expose } from 'class-transformer';
-import { IsEnum, IsOptional, IsString } from 'class-validator';
+import { IsEnum, IsOptional, IsString, MaxLength } from 'class-validator';
+import { OFFERINGS_AUDIT_REASON_MAX_LENGTH } from '../../constants/offeringsInputLimits';
 import { PromotionStatusEnum } from '../../enums/PromotionStatusEnum';
 
 /**
@@ -16,5 +17,6 @@ export class ChangePromotionStatusRequest {
     @Expose()
     @IsOptional()
     @IsString()
+    @MaxLength(OFFERINGS_AUDIT_REASON_MAX_LENGTH)
     reason?: string | null;
 }

package/src/loanOfferings/dtos/requests/ComputeAmortizationScheduleRequest.ts

@@ -1,5 +1,6 @@
 import { Expose } from 'class-transformer';
 import { IsInt, IsNumber, Max, Min } from 'class-validator';
+import { AMORTIZATION_TNA_ANNUAL_TECHNICAL_MAX, CREDIT_PLAN_MAX_TERM_WEEKS } from '../../constants/offeringsInputLimits';
 
 /** Body de `POST /private/amortization/schedule` (loan-offerings-business). Tabla francesa semanal sin fechas. */
 export class ComputeAmortizationScheduleRequest {
@@ -9,17 +10,21 @@ export class ComputeAmortizationScheduleRequest {
     @Min(1)
     financedAmountCents!: number;
 
-    /** TNA en decimal (`2.30` = 230%). */
+    /**
+     * TNA en decimal (`2.30` = 230%). El techo es técnico (5 = 500%), no el 2.60 de los planes: la
+     * reestructura sube la TNA del crédito por encima de ese valor (ver `AMORTIZATION_TNA_ANNUAL_TECHNICAL_MAX`).
+     */
     @Expose()
     @IsNumber()
     @Min(0)
+    @Max(AMORTIZATION_TNA_ANNUAL_TECHNICAL_MAX)
     tnaAnnual!: number;
 
     /** Número de cuotas semanales. */
     @Expose()
     @IsInt()
     @Min(1)
-    @Max(104)
+    @Max(CREDIT_PLAN_MAX_TERM_WEEKS)
     termWeeks!: number;
 
     /** IVA sobre interés en decimal (`0.16`). */

package/src/loanOfferings/dtos/requests/ConsumePromotionRequest.ts

@@ -1,12 +1,16 @@
 import { Expose } from 'class-transformer';
-import { IsString } from 'class-validator';
+import { IsNotEmpty, IsString, MaxLength } from 'class-validator';
+import { PROMOTION_CREDIT_ID_MAX_LENGTH } from '../../constants/offeringsInputLimits';
 
 /**
  * Body de POST /private/promotions/:promotionId/consume — el crédito que acaba de activarse bajo
  * esta promoción. `creditId` es la llave de idempotencia: reenviarlo NO vuelve a contar.
  */
 export class ConsumePromotionRequest {
+    /** Llave de idempotencia: vacía colapsaría todos los créditos en una sola fila (L-104). */
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(PROMOTION_CREDIT_ID_MAX_LENGTH)
     creditId!: string;
 }

package/src/loanOfferings/dtos/requests/CreateCreditPlanRequest.ts

@@ -1,17 +1,28 @@
 import { Expose, Type } from 'class-transformer';
 import {
+    ArrayMaxSize,
     ArrayNotEmpty,
     IsArray,
     IsBoolean,
     IsEnum,
     IsInt,
+    IsISO8601,
+    IsNotEmpty,
     IsNumber,
     IsOptional,
     IsString,
     Max,
+    MaxLength,
     Min,
     ValidateNested,
 } from 'class-validator';
+import {
+    CREDIT_PLAN_MAX_TERM_WEEKS,
+    CREDIT_PLAN_TERM_OPTIONS_MAX_ITEMS,
+    OFFERINGS_CODE_MAX_LENGTH,
+    OFFERINGS_DESCRIPTION_MAX_LENGTH,
+    OFFERINGS_NAME_MAX_LENGTH,
+} from '../../constants/offeringsInputLimits';
 import { CreditPlanLevelEnum } from '../../enums/CreditPlanLevelEnum';
 import { ProductTierEnum } from '../../enums/ProductTierEnum';
 import { SaleTypeEnum } from '../../enums/SaleTypeEnum';
@@ -25,14 +36,20 @@ import { PrepaymentMinimum } from '../PrepaymentMinimum';
 export class CreateCreditPlanRequest {
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_CODE_MAX_LENGTH)
     code!: string;
 
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_NAME_MAX_LENGTH)
     name!: string;
 
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_DESCRIPTION_MAX_LENGTH)
     description!: string;
 
     @Expose()
@@ -64,11 +81,14 @@ export class CreateCreditPlanRequest {
     @Max(1)
     maxDownPaymentPct?: number | null;
 
+    /** Plazos ofrecidos, en semanas: de 1 a 104 cada uno. */
     @Expose()
     @IsArray()
     @ArrayNotEmpty()
+    @ArrayMaxSize(CREDIT_PLAN_TERM_OPTIONS_MAX_ITEMS)
     @IsInt({ each: true })
     @Min(1, { each: true })
+    @Max(CREDIT_PLAN_MAX_TERM_WEEKS, { each: true })
     termWeeksOptions!: number[];
 
     @Expose()
@@ -108,14 +128,16 @@ export class CreateCreditPlanRequest {
     @Max(100)
     maxSciScore?: number | null;
 
+    /** Inicio de vigencia en ISO-8601; ausente o `null` = sin inicio. */
     @Expose()
     @IsOptional()
-    @IsString()
+    @IsISO8601()
     validFrom?: string | null;
 
+    /** Fin de vigencia en ISO-8601; ausente o `null` = sin fin. */
     @Expose()
     @IsOptional()
-    @IsString()
+    @IsISO8601()
     validUntil?: string | null;
 
     /** Mínimo del abono a capital; ausente = sin cambios (en el alta: `ANY`). */

package/src/loanOfferings/dtos/requests/CreateFinancierRequest.ts

@@ -3,11 +3,22 @@ import {
     IsArray,
     IsEnum,
     IsInt,
+    IsNotEmpty,
     IsObject,
     IsOptional,
     IsString,
+    IsUrl,
+    MaxLength,
     Min,
 } from 'class-validator';
+import {
+    FINANCIER_CONFIG_MAX_BYTES,
+    FINANCIER_REDIRECT_URL_MAX_LENGTH,
+    OFFERINGS_CODE_MAX_LENGTH,
+    OFFERINGS_LABEL_MAX_LENGTH,
+    OFFERINGS_NAME_MAX_LENGTH,
+} from '../../constants/offeringsInputLimits';
+import { MaxJsonBytes } from '../../validators/MaxJsonBytes';
 import { FinancierTypeEnum } from '../../enums/FinancierTypeEnum';
 import { ProductTierEnum } from '../../enums/ProductTierEnum';
 
@@ -19,10 +30,14 @@ import { ProductTierEnum } from '../../enums/ProductTierEnum';
 export class CreateFinancierRequest {
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_CODE_MAX_LENGTH)
     code!: string;
 
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_NAME_MAX_LENGTH)
     name!: string;
 
     @Expose()
@@ -37,11 +52,16 @@ export class CreateFinancierRequest {
 
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_LABEL_MAX_LENGTH)
     label!: string;
 
+    /** URL https a la que se redirige al cliente; `null` = sin redirección. */
     @Expose()
     @IsOptional()
     @IsString()
+    @MaxLength(FINANCIER_REDIRECT_URL_MAX_LENGTH)
+    @IsUrl({ protocols: ['https'], require_protocol: true })
     externalRedirectUrl?: string | null;
 
     @Expose()
@@ -50,8 +70,13 @@ export class CreateFinancierRequest {
     @IsEnum(ProductTierEnum, { each: true })
     eligibleTiers?: ProductTierEnum[] | null;
 
+    /**
+     * @deprecated Ningún consumidor lo lee (TD-019 de loan-offerings) y se va a eliminar (decisión
+     * D-9). Mientras tanto, a lo más 4 KB serializado.
+     */
     @Expose()
     @IsOptional()
     @IsObject()
+    @MaxJsonBytes(FINANCIER_CONFIG_MAX_BYTES)
     config?: Record<string, unknown> | null;
 }

package/src/loanOfferings/dtos/requests/CreatePromotionRequest.ts

@@ -9,8 +9,15 @@ import {
     IsNotEmpty,
     IsOptional,
     IsString,
+    MaxLength,
     ValidateNested,
 } from 'class-validator';
+import {
+    OFFERINGS_DESCRIPTION_MAX_LENGTH,
+    OFFERINGS_NAME_MAX_LENGTH,
+    PROMOTION_PRODUCT_SKUS_MAX_ITEMS,
+    SCOPE_STORE_IDS_MAX_ITEMS,
+} from '../../constants/offeringsInputLimits';
 import { PROMOTION_RETAILER_IDS_MAX_ITEMS } from '../../constants/promotionRetailerScope';
 import { CreditPlanLevelEnum } from '../../enums/CreditPlanLevelEnum';
 import { ProductCategoryEnum } from '../../../retailCatalog/enums/ProductCategoryEnum';
@@ -25,10 +32,14 @@ import { PromotionEffectInput } from './PromotionEffectInput';
 export class CreatePromotionRequest {
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_NAME_MAX_LENGTH)
     name!: string;
 
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_DESCRIPTION_MAX_LENGTH)
     description!: string;
 
     @Expose()
@@ -47,11 +58,13 @@ export class CreatePromotionRequest {
     @IsEnum(CreditPlanLevelEnum, { each: true })
     targetLevels!: CreditPlanLevelEnum[];
 
-    /** SKUs alcanzados; ausente o `null` = todos los productos. */
+    /** SKUs alcanzados; ausente o `null` = todos los productos. Hasta 2 000. */
     @Expose()
     @IsOptional()
     @IsArray()
+    @ArrayMaxSize(PROMOTION_PRODUCT_SKUS_MAX_ITEMS)
     @IsString({ each: true })
+    @IsNotEmpty({ each: true })
     productSkus?: string[] | null;
 
     /** Tipos de producto alcanzados; ausente o `null` = todos los tipos. */
@@ -77,11 +90,13 @@ export class CreatePromotionRequest {
     @IsNotEmpty({ each: true })
     retailerIds?: string[] | null;
 
-    /** Tiendas alcanzadas. `null` o ausente = todas. */
+    /** Tiendas alcanzadas. `null` o ausente = todas. Hasta 1 000. */
     @Expose()
     @IsOptional()
     @IsArray()
+    @ArrayMaxSize(SCOPE_STORE_IDS_MAX_ITEMS)
     @IsString({ each: true })
+    @IsNotEmpty({ each: true })
     storeIds?: string[] | null;
 
     @Expose()

package/src/loanOfferings/dtos/requests/CreateSegmentRequest.ts

@@ -1,5 +1,6 @@
 import { Expose } from 'class-transformer';
 import { ArrayMaxSize, IsArray, IsEnum, IsNotEmpty, IsOptional, IsString, MaxLength } from 'class-validator';
+import { SEGMENT_MEMBER_IDS_MAX_ITEMS } from '../../constants/offeringsInputLimits';
 import { SegmentColorSlotEnum } from '../../enums/SegmentColorSlotEnum';
 
 /**
@@ -47,11 +48,13 @@ export class CreateSegmentRequest {
 
     /**
      * Clientes agregados a mano por `retailCustomerId`. Ganan siempre, cumplan o no un cohort.
-     * Un segmento puede nacer SOLO con esta lista, sin ningún cohort.
+     * Un segmento puede nacer SOLO con esta lista, sin ningún cohort. Hasta 5 000, sin ids vacíos.
      */
     @Expose()
     @IsOptional()
     @IsArray()
+    @ArrayMaxSize(SEGMENT_MEMBER_IDS_MAX_ITEMS)
     @IsString({ each: true })
+    @IsNotEmpty({ each: true })
     memberIds?: string[];
 }

package/src/loanOfferings/dtos/requests/CreateStorePolicyRequest.ts

@@ -1,11 +1,13 @@
 import { Expose, Type } from 'class-transformer';
 import {
+    ArrayMaxSize,
     ArrayNotEmpty,
     IsArray,
     IsBoolean,
     IsEnum,
     IsInt,
     IsISO8601,
+    IsNotEmpty,
     IsNumber,
     IsOptional,
     IsString,
@@ -14,6 +16,7 @@ import {
     Min,
     ValidateNested,
 } from 'class-validator';
+import { SCOPE_STORE_IDS_MAX_ITEMS } from '../../constants/offeringsInputLimits';
 import { CreditPlanLevelEnum } from '../../enums/CreditPlanLevelEnum';
 
 /** Grupo de palancas que ENDURECEN las condiciones del plan. */
@@ -114,12 +117,14 @@ export class CreateStorePolicyRequest {
     @IsString({ each: true })
     allowedSkus?: string[];
 
-    /** Alcance: tiendas alcanzadas. Ausente = toda la red. */
+    /** Alcance: tiendas alcanzadas. Ausente = toda la red. Hasta 1 000. */
     @Expose()
     @IsOptional()
     @IsArray()
     @ArrayNotEmpty()
+    @ArrayMaxSize(SCOPE_STORE_IDS_MAX_ITEMS)
     @IsString({ each: true })
+    @IsNotEmpty({ each: true })
     storeIds?: string[];
 
     /** Alcance: niveles alcanzados. Ausente = todos los niveles. */

package/src/loanOfferings/dtos/requests/ReleasePromotionRequest.ts

@@ -0,0 +1,16 @@
+import { Expose } from 'class-transformer';
+import { IsNotEmpty, IsString, MaxLength } from 'class-validator';
+import { PROMOTION_CREDIT_ID_MAX_LENGTH } from '../../constants/offeringsInputLimits';
+
+/**
+ * Body de POST /private/promotions/:promotionId/release — el crédito con promoción que se canceló.
+ * Baja `creditsGenerated` una sola vez por crédito: `creditId` es la llave de idempotencia, así que
+ * reenviarlo no vuelve a restar. El bono PCF no vuelve al presupuesto: es irreversible (L-052, D-2).
+ */
+export class ReleasePromotionRequest {
+    @Expose()
+    @IsString()
+    @IsNotEmpty()
+    @MaxLength(PROMOTION_CREDIT_ID_MAX_LENGTH)
+    creditId!: string;
+}

package/src/loanOfferings/dtos/requests/ReservePromotionBonusRequest.ts

@@ -1,12 +1,16 @@
 import { Expose } from 'class-transformer';
-import { IsString } from 'class-validator';
+import { IsNotEmpty, IsString, MaxLength } from 'class-validator';
+import { PROMOTION_CREDIT_ID_MAX_LENGTH } from '../../constants/offeringsInputLimits';
 
 /**
  * Body de POST /private/promotions/:promotionId/bonus-payment — el crédito recién activado que va a
  * cobrar el bono. `creditId` es el candado: reenviarlo devuelve `reserved: false`, no un segundo pago.
  */
 export class ReservePromotionBonusRequest {
+    /** Llave de idempotencia: vacía colapsaría todos los créditos en una sola fila (L-104). */
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(PROMOTION_CREDIT_ID_MAX_LENGTH)
     creditId!: string;
 }

package/src/loanOfferings/dtos/requests/SettlePromotionBonusRequest.ts

@@ -1,5 +1,6 @@
 import { Expose } from 'class-transformer';
-import { IsEnum, IsOptional, IsString } from 'class-validator';
+import { IsEnum, IsNotEmpty, IsOptional, IsString, MaxLength } from 'class-validator';
+import { PROMOTION_CREDIT_ID_MAX_LENGTH } from '../../constants/offeringsInputLimits';
 import { PromotionBonusStatusEnum } from '../../enums/PromotionBonusStatusEnum';
 
 /**
@@ -7,8 +8,11 @@ import { PromotionBonusStatusEnum } from '../../enums/PromotionBonusStatusEnum';
  * contestó el processor. `RESERVED` no se acepta: es el estado del que se sale, no al que se llega.
  */
 export class SettlePromotionBonusRequest {
+    /** Llave de idempotencia: vacía colapsaría todos los créditos en una sola fila (L-104). */
     @Expose()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(PROMOTION_CREDIT_ID_MAX_LENGTH)
     bonusId!: string;
 
     @Expose()

package/src/loanOfferings/dtos/requests/SimulateCreditPlanRequest.ts

@@ -1,5 +1,6 @@
 import { Expose } from 'class-transformer';
-import { IsArray, IsEnum, IsInt, IsNotEmpty, IsNumber, IsOptional, IsString, Max, Min } from 'class-validator';
+import { ArrayMaxSize, IsArray, IsEnum, IsInt, IsNotEmpty, IsNumber, IsOptional, IsString, Max, Min } from 'class-validator';
+import { CUSTOMER_SEGMENT_IDS_MAX_ITEMS } from '../../constants/offeringsInputLimits';
 import { ProductCategoryEnum } from '../../../retailCatalog/enums/ProductCategoryEnum';
 import { ProductTierEnum } from '../../../retailCatalog/enums/ProductTierEnum';
 
@@ -71,10 +72,13 @@ export class SimulateCreditPlanRequest {
     /**
      * Segmentos del cliente, los que devolvió `POST /private/segments/resolve`. Un arreglo vacío
      * declara que el cliente no está en ninguno; ausente declara que el caller no lo consultó.
+     * Hasta 50, sin ids vacíos.
      */
     @Expose()
     @IsOptional()
     @IsArray()
+    @ArrayMaxSize(CUSTOMER_SEGMENT_IDS_MAX_ITEMS)
     @IsString({ each: true })
+    @IsNotEmpty({ each: true })
     customerSegmentIds?: string[];
 }

package/src/loanOfferings/dtos/requests/UpdateCohortRequest.ts

@@ -1,14 +1,17 @@
 import { Expose, Type } from 'class-transformer';
 import { ArrayMaxSize, ArrayMinSize, IsArray, IsOptional, IsString, MaxLength, ValidateNested } from 'class-validator';
+import { IsOptionalNonNull } from '../../validators/IsOptionalNonNull';
 import { CohortCondition } from './CohortCondition';
 
 /**
  * Body de PUT /cohorts/:cohortId — edición parcial; ausente deja el campo como está. Sube
  * `version`. El cambio de estado va por su endpoint dedicado.
+ *
+ * `null` solo se acepta en `description`, donde la borra; en `name` y `conditions` da 400.
  */
 export class UpdateCohortRequest {
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsString()
     @MaxLength(120)
     name?: string;
@@ -17,11 +20,11 @@ export class UpdateCohortRequest {
     @IsOptional()
     @IsString()
     @MaxLength(500)
-    description?: string;
+    description?: string | null;
 
     /** Reemplaza todas las condiciones. */
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsArray()
     @ArrayMinSize(1)
     @ArrayMaxSize(10)

package/src/loanOfferings/dtos/requests/UpdateCreditPlanRequest.ts

@@ -1,19 +1,31 @@
 import { Expose, Type } from 'class-transformer';
 import {
+    ArrayMaxSize,
     ArrayNotEmpty,
     IsArray,
     IsBoolean,
     IsEnum,
     IsInt,
+    IsISO8601,
+    IsNotEmpty,
     IsNumber,
     IsOptional,
     IsString,
     Max,
+    MaxLength,
     Min,
     ValidateNested,
 } from 'class-validator';
+import {
+    CREDIT_PLAN_MAX_TERM_WEEKS,
+    CREDIT_PLAN_TERM_OPTIONS_MAX_ITEMS,
+    OFFERINGS_AUDIT_REASON_MAX_LENGTH,
+    OFFERINGS_DESCRIPTION_MAX_LENGTH,
+    OFFERINGS_NAME_MAX_LENGTH,
+} from '../../constants/offeringsInputLimits';
 import { ProductTierEnum } from '../../enums/ProductTierEnum';
 import { SaleTypeEnum } from '../../enums/SaleTypeEnum';
+import { IsOptionalNonNull } from '../../validators/IsOptionalNonNull';
 import { PrepaymentMinimum } from '../PrepaymentMinimum';
 
 /**
@@ -21,20 +33,27 @@ import { PrepaymentMinimum } from '../PrepaymentMinimum';
  * En F1 el PUT puede editar `min/maxSciScore` por-plan (DEC-004); el guard atómico anti-huecos
  * entre planes (21-100) es F2/F3. El cambio de `status` va por su endpoint dedicado.
  * `code` y `level` no se editan aquí (identidad/segmentación del plan).
+ *
+ * Ausente deja el campo como está. `null` solo se acepta en los campos que lo declaran
+ * (`eligibleTiers`, `maxDownPaymentPct`, `min/maxSciScore`, `validFrom/Until`); en el resto da 400.
  */
 export class UpdateCreditPlanRequest {
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_NAME_MAX_LENGTH)
     name?: string;
 
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_DESCRIPTION_MAX_LENGTH)
     description?: string;
 
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsArray()
     @ArrayNotEmpty()
     @IsEnum(SaleTypeEnum, { each: true })
@@ -47,7 +66,7 @@ export class UpdateCreditPlanRequest {
     eligibleTiers?: ProductTierEnum[] | null;
 
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsNumber()
     @Min(0)
     @Max(1)
@@ -60,36 +79,39 @@ export class UpdateCreditPlanRequest {
     @Max(1)
     maxDownPaymentPct?: number | null;
 
+    /** Plazos ofrecidos, en semanas: de 1 a 104 cada uno. */
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsArray()
     @ArrayNotEmpty()
+    @ArrayMaxSize(CREDIT_PLAN_TERM_OPTIONS_MAX_ITEMS)
     @IsInt({ each: true })
     @Min(1, { each: true })
+    @Max(CREDIT_PLAN_MAX_TERM_WEEKS, { each: true })
     termWeeksOptions?: number[];
 
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsInt()
     @Min(0)
     maxFinancedAmountCents?: number;
 
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsNumber()
     @Min(2.0)
     @Max(2.6)
     tnaAnnual?: number;
 
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsNumber()
     @Min(0)
     @Max(1)
     openingCommissionPct?: number;
 
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsBoolean()
     paymentShift?: boolean;
 
@@ -107,20 +129,29 @@ export class UpdateCreditPlanRequest {
     @Max(100)
     maxSciScore?: number | null;
 
+    /** Inicio de vigencia en ISO-8601; `null` la quita. */
     @Expose()
     @IsOptional()
-    @IsString()
+    @IsISO8601()
     validFrom?: string | null;
 
+    /** Fin de vigencia en ISO-8601; `null` la quita. */
     @Expose()
     @IsOptional()
-    @IsString()
+    @IsISO8601()
     validUntil?: string | null;
 
     /** Mínimo del abono a capital; ausente = sin cambios (en el alta: `ANY`). */
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @ValidateNested()
     @Type(() => PrepaymentMinimum)
     prepaymentMinimum?: PrepaymentMinimum;
+
+    /** Motivo del cambio; queda en la bitácora del plan. */
+    @Expose()
+    @IsOptional()
+    @IsString()
+    @MaxLength(OFFERINGS_AUDIT_REASON_MAX_LENGTH)
+    reason?: string;
 }

package/src/loanOfferings/dtos/requests/UpdateFinancierRequest.ts

@@ -2,30 +2,49 @@ import { Expose } from 'class-transformer';
 import {
     IsArray,
     IsEnum,
+    IsNotEmpty,
     IsObject,
     IsOptional,
     IsString,
+    IsUrl,
+    MaxLength,
 } from 'class-validator';
+import {
+    FINANCIER_CONFIG_MAX_BYTES,
+    FINANCIER_REDIRECT_URL_MAX_LENGTH,
+    OFFERINGS_LABEL_MAX_LENGTH,
+    OFFERINGS_NAME_MAX_LENGTH,
+} from '../../constants/offeringsInputLimits';
 import { ProductTierEnum } from '../../enums/ProductTierEnum';
+import { IsOptionalNonNull } from '../../validators/IsOptionalNonNull';
+import { MaxJsonBytes } from '../../validators/MaxJsonBytes';
 
 /**
  * Body de PUT /financiers/:financierId — edición parcial (todos opcionales).
  * `code`, `type` y `displayOrder` no se editan aquí (identidad / orden por endpoint dedicado).
+ * `null` se acepta en `externalRedirectUrl`, `eligibleTiers` y `config`; en `name` y `label` da 400.
  */
 export class UpdateFinancierRequest {
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_NAME_MAX_LENGTH)
     name?: string;
 
     @Expose()
-    @IsOptional()
+    @IsOptionalNonNull()
     @IsString()
+    @IsNotEmpty()
+    @MaxLength(OFFERINGS_LABEL_MAX_LENGTH)
     label?: string;
 
+    /** URL https a la que se redirige al cliente; `null` = sin redirección. */
     @Expose()
     @IsOptional()
     @IsString()
+    @MaxLength(FINANCIER_REDIRECT_URL_MAX_LENGTH)
+    @IsUrl({ protocols: ['https'], require_protocol: true })
     externalRedirectUrl?: string | null;
 
     @Expose()
@@ -34,8 +53,13 @@ export class UpdateFinancierRequest {
     @IsEnum(ProductTierEnum, { each: true })
     eligibleTiers?: ProductTierEnum[] | null;
 
+    /**
+     * @deprecated Ningún consumidor lo lee (TD-019 de loan-offerings) y se va a eliminar (decisión
+     * D-9). Mientras tanto, a lo más 4 KB serializado.
+     */
     @Expose()
     @IsOptional()
     @IsObject()
+    @MaxJsonBytes(FINANCIER_CONFIG_MAX_BYTES)
     config?: Record<string, unknown> | null;
 }