@fiado/type-kit 3.553.0 → 3.555.0

package/_test_/unit/loanRetailAudit/loanRetailAuditContracts.test.ts

@@ -132,6 +132,15 @@ describe('catálogos', () => {
         expect(RetailAuditEntityTypeEnum.RETAIL_CUSTOMER).toBe('RETAIL_CUSTOMER');
     });
 
+    it('incluye el saldo del libro y el depósito de comisiones y los acepta en el evento', () => {
+        for (const entityType of ['COMMISSION_LEDGER', 'COMMISSION_PAYMENT']) {
+            expect(AUDIT_TRAIL_ENTITY_TYPES).toContain(entityType);
+            expect(errorsOf(AuditTrailRecordedV1, { ...validEvent, entityType })).toEqual([]);
+        }
+        expect(RetailAuditEntityTypeEnum.COMMISSION_LEDGER).toBe('COMMISSION_LEDGER');
+        expect(RetailAuditEntityTypeEnum.COMMISSION_PAYMENT).toBe('COMMISSION_PAYMENT');
+    });
+
     it('AUDIT_TRAIL_ENTITY_TYPES une Loan y Retail sin repetidos', () => {
         const all = [...Object.values(LoanAuditEntityTypeEnum), ...Object.values(RetailAuditEntityTypeEnum)];
         expect([...AUDIT_TRAIL_ENTITY_TYPES].sort()).toEqual([...all].sort());

package/_test_/unit/retailWizard/accessorySaleRequests.test.ts

@@ -14,7 +14,6 @@ function errorsOf<T extends object>(cls: new () => T, payload: Record<string, un
 }
 
 const validSale = {
-  otpChallengeId: 'chl-1',
   lines: [{ sku: 'ACC-1', qty: 2 }],
   paymentMethod: SalePaymentMethodEnum.CASH,
   amountCents: 39800,
@@ -91,8 +90,10 @@ describe('CreateAccessorySaleRequest', () => {
     expect(errorsOf(CreateAccessorySaleRequest, { ...validSale, paymentMethod: SalePaymentMethodEnum.WIRE })).toEqual([]);
   });
 
-  it('exige el reto OTP', () => {
-    expect(errorsOf(CreateAccessorySaleRequest, { ...validSale, otpChallengeId: '' })).toContain('otpChallengeId');
+  it('ya no lleva reto OTP: otpChallengeId se descarta', () => {
+    const dto = plainToInstance(CreateAccessorySaleRequest, { ...validSale, otpChallengeId: 'chl-1' }, { excludeExtraneousValues: true });
+    expect(dto).not.toHaveProperty('otpChallengeId');
+    expect(validateSync(dto)).toEqual([]);
   });
 });
 

package/_test_/unit/retailWizard/fixtures/saleWithoutCustomer.strict.ts

@@ -0,0 +1,3 @@
+import type { Sale } from '../../../../src/retailWizard/dtos/Sale';
+
+export const counterSaleCustomerId: Sale['retailCustomerId'] = null;

package/_test_/unit/retailWizard/saleWithoutCustomer.test.ts

@@ -0,0 +1,32 @@
+import 'reflect-metadata';
+import * as path from 'path';
+import * as ts from 'typescript';
+import { counterSaleCustomerId } from './fixtures/saleWithoutCustomer.strict';
+
+const FIXTURE = path.join(__dirname, 'fixtures', 'saleWithoutCustomer.strict.ts');
+
+// Sin strictNullChecks null cabe en string y la prueba no detecta nada.
+function strictDiagnostics(): string[] {
+  const program = ts.createProgram([FIXTURE], {
+    strict: true,
+    noEmit: true,
+    skipLibCheck: true,
+    target: ts.ScriptTarget.ES2020,
+    module: ts.ModuleKind.CommonJS,
+    moduleResolution: ts.ModuleResolutionKind.Node10,
+  });
+  return ts
+    .getPreEmitDiagnostics(program)
+    .filter((d) => d.file?.fileName === FIXTURE)
+    .map((d) => ts.flattenDiagnosticMessageText(d.messageText, '\n'));
+}
+
+describe('venta de mostrador sin cliente — retailCustomerId nullable', () => {
+  it('Sale acepta retailCustomerId null en strict', () => {
+    expect(strictDiagnostics()).toEqual([]);
+  });
+
+  it('el valor viaja como null', () => {
+    expect(counterSaleCustomerId).toBeNull();
+  });
+});

package/bin/loanRetailAudit/enums/RetailAuditEntityTypeEnum.d.ts

@@ -14,6 +14,10 @@ export declare enum RetailAuditEntityTypeEnum {
     COMMISSION_ADJUSTMENT = "COMMISSION_ADJUSTMENT",
     COMMISSION_RULE = "COMMISSION_RULE",
     COMMISSION_POLICY = "COMMISSION_POLICY",
+    /** El saldo de un vendedor en el libro de pagos de comisiones; `entityId` = `<retailerId>#<sellerId>`. */
+    COMMISSION_LEDGER = "COMMISSION_LEDGER",
+    /** Un depósito de comisiones a la wallet; `entityId` = `<retailerId>#<sellerId>#<paymentId>`. */
+    COMMISSION_PAYMENT = "COMMISSION_PAYMENT",
     PROSPECT = "PROSPECT",
     RETAIL_CUSTOMER = "RETAIL_CUSTOMER"
 }

package/bin/loanRetailAudit/enums/RetailAuditEntityTypeEnum.js

@@ -18,6 +18,10 @@ var RetailAuditEntityTypeEnum;
     RetailAuditEntityTypeEnum["COMMISSION_ADJUSTMENT"] = "COMMISSION_ADJUSTMENT";
     RetailAuditEntityTypeEnum["COMMISSION_RULE"] = "COMMISSION_RULE";
     RetailAuditEntityTypeEnum["COMMISSION_POLICY"] = "COMMISSION_POLICY";
+    /** El saldo de un vendedor en el libro de pagos de comisiones; `entityId` = `<retailerId>#<sellerId>`. */
+    RetailAuditEntityTypeEnum["COMMISSION_LEDGER"] = "COMMISSION_LEDGER";
+    /** Un depósito de comisiones a la wallet; `entityId` = `<retailerId>#<sellerId>#<paymentId>`. */
+    RetailAuditEntityTypeEnum["COMMISSION_PAYMENT"] = "COMMISSION_PAYMENT";
     RetailAuditEntityTypeEnum["PROSPECT"] = "PROSPECT";
     RetailAuditEntityTypeEnum["RETAIL_CUSTOMER"] = "RETAIL_CUSTOMER";
 })(RetailAuditEntityTypeEnum || (exports.RetailAuditEntityTypeEnum = RetailAuditEntityTypeEnum = {}));

package/bin/retailWizard/dtos/Sale.d.ts

@@ -18,7 +18,8 @@ export interface Sale {
     retailerId: string;
     storeId: string;
     sellerRetailUserId: string;
-    retailCustomerId: string;
+    /** `null` en la venta de mostrador sin cliente. */
+    retailCustomerId: string | null;
     /** Sesión del wizard que cerró la venta; ausente en la venta de mostrador. */
     wizardSessionId?: string;
     /** Canal de la venta; ausente = `WIZARD` (ventas anteriores al campo). */

package/bin/retailWizard/dtos/requests/CreateAccessorySaleRequest.d.ts

@@ -2,11 +2,10 @@ import { SalePaymentMethodEnum } from '../../enums/SalePaymentMethodEnum';
 import { SalePaymentDetail } from '../SalePaymentDetail';
 import { AccessorySaleLine } from '../AccessorySaleLine';
 /**
- * POST /wizard/accessory-sales — cierra la venta de mostrador con el celular ya verificado.
+ * POST /wizard/accessory-sales — cierra la venta de mostrador, sin cliente.
  * `amountCents` es lo cobrado en caja y debe igualar la suma del catálogo.
  */
 export declare class CreateAccessorySaleRequest {
-    otpChallengeId: string;
     lines: AccessorySaleLine[];
     paymentMethod: SalePaymentMethodEnum;
     amountCents: number;

package/bin/retailWizard/dtos/requests/CreateAccessorySaleRequest.js

@@ -16,18 +16,12 @@ const SalePaymentMethodEnum_1 = require("../../enums/SalePaymentMethodEnum");
 const SalePaymentDetail_1 = require("../SalePaymentDetail");
 const AccessorySaleLine_1 = require("../AccessorySaleLine");
 /**
- * POST /wizard/accessory-sales — cierra la venta de mostrador con el celular ya verificado.
+ * POST /wizard/accessory-sales — cierra la venta de mostrador, sin cliente.
  * `amountCents` es lo cobrado en caja y debe igualar la suma del catálogo.
  */
 class CreateAccessorySaleRequest {
 }
 exports.CreateAccessorySaleRequest = CreateAccessorySaleRequest;
-__decorate([
-    (0, class_transformer_1.Expose)(),
-    (0, class_validator_1.IsString)(),
-    (0, class_validator_1.MinLength)(1),
-    __metadata("design:type", String)
-], CreateAccessorySaleRequest.prototype, "otpChallengeId", void 0);
 __decorate([
     (0, class_transformer_1.Expose)(),
     (0, class_validator_1.IsArray)(),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fiado/type-kit",
-  "version": "3.553.0",
+  "version": "3.555.0",
   "description": "",
   "main": "bin/index.js",
   "types": "bin/index.d.ts",

package/src/loanRetailAudit/enums/RetailAuditEntityTypeEnum.ts

@@ -14,6 +14,10 @@ export enum RetailAuditEntityTypeEnum {
     COMMISSION_ADJUSTMENT = 'COMMISSION_ADJUSTMENT',
     COMMISSION_RULE = 'COMMISSION_RULE',
     COMMISSION_POLICY = 'COMMISSION_POLICY',
+    /** El saldo de un vendedor en el libro de pagos de comisiones; `entityId` = `<retailerId>#<sellerId>`. */
+    COMMISSION_LEDGER = 'COMMISSION_LEDGER',
+    /** Un depósito de comisiones a la wallet; `entityId` = `<retailerId>#<sellerId>#<paymentId>`. */
+    COMMISSION_PAYMENT = 'COMMISSION_PAYMENT',
     PROSPECT = 'PROSPECT',
     RETAIL_CUSTOMER = 'RETAIL_CUSTOMER',
 }

package/src/retailWizard/dtos/Sale.ts

@@ -19,7 +19,8 @@ export interface Sale {
   retailerId: string;
   storeId: string;
   sellerRetailUserId: string;
-  retailCustomerId: string;
+  /** `null` en la venta de mostrador sin cliente. */
+  retailCustomerId: string | null;
   /** Sesión del wizard que cerró la venta; ausente en la venta de mostrador. */
   wizardSessionId?: string;
   /** Canal de la venta; ausente = `WIZARD` (ventas anteriores al campo). */

package/src/retailWizard/dtos/requests/CreateAccessorySaleRequest.ts

@@ -18,15 +18,10 @@ import { SalePaymentDetail } from '../SalePaymentDetail';
 import { AccessorySaleLine } from '../AccessorySaleLine';
 
 /**
- * POST /wizard/accessory-sales — cierra la venta de mostrador con el celular ya verificado.
+ * POST /wizard/accessory-sales — cierra la venta de mostrador, sin cliente.
  * `amountCents` es lo cobrado en caja y debe igualar la suma del catálogo.
  */
 export class CreateAccessorySaleRequest {
-  @Expose()
-  @IsString()
-  @MinLength(1)
-  otpChallengeId!: string;
-
   @Expose()
   @IsArray()
   @ArrayMinSize(1)