@fiado/type-kit 3.483.0 → 3.485.0

package/_test_/unit/retailPromotions/salePromotionDiscountLevers.test.ts

@@ -0,0 +1,49 @@
+import 'reflect-metadata';
+import { plainToInstance } from 'class-transformer';
+import { validate } from 'class-validator';
+import { SalePromotionLeversInput } from '../../../src/retailPromotions/index';
+
+/** Rutas de propiedad con error dentro de las palancas (`deviceDiscount.maxAmountCents`). */
+const errorPaths = async (levers: Record<string, unknown>): Promise<string[]> => {
+  const errors = await validate(plainToInstance(SalePromotionLeversInput, levers) as object);
+  const walk = (list: typeof errors, prefix: string): string[] =>
+    list.flatMap((e) => {
+      const path = prefix ? `${prefix}.${e.property}` : e.property;
+      return e.children && e.children.length > 0 ? walk(e.children, path) : [path];
+    });
+  return walk(errors, '');
+};
+
+describe('deviceDiscount', () => {
+  it('acepta % o $ con tope opcional', async () => {
+    expect(await errorPaths({ deviceDiscount: { type: 'PERCENTAGE', percentBps: 1500, maxAmountCents: 200000 } })).toHaveLength(0);
+    expect(await errorPaths({ deviceDiscount: { type: 'AMOUNT', amountCents: 50000 } })).toHaveLength(0);
+    expect(await errorPaths({ deviceDiscount: { type: 'AMOUNT', amountCents: 50000, maxAmountCents: null } })).toHaveLength(0);
+  });
+
+  it('rechaza porcentaje fuera de 1..10000, monto no positivo y tope no positivo', async () => {
+    expect(await errorPaths({ deviceDiscount: { type: 'PERCENTAGE', percentBps: 0 } })).toContain('deviceDiscount.percentBps');
+    expect(await errorPaths({ deviceDiscount: { type: 'PERCENTAGE', percentBps: 10001 } })).toContain('deviceDiscount.percentBps');
+    expect(await errorPaths({ deviceDiscount: { type: 'AMOUNT', amountCents: 0 } })).toContain('deviceDiscount.amountCents');
+    expect(await errorPaths({ deviceDiscount: { type: 'AMOUNT', amountCents: 100, maxAmountCents: 0 } })).toContain('deviceDiscount.maxAmountCents');
+  });
+});
+
+describe('accessoryDiscount', () => {
+  it('sin type se asume porcentaje, como las promos existentes', async () => {
+    expect(await errorPaths({ accessoryDiscount: { percentBps: 2000, maxAmountCents: 30000 } })).toHaveLength(0);
+    expect(await errorPaths({ accessoryDiscount: { maxAmountCents: 30000 } })).toContain('accessoryDiscount.percentBps');
+  });
+
+  it('acepta monto fijo con type AMOUNT y no exige percentBps', async () => {
+    expect(await errorPaths({ accessoryDiscount: { type: 'AMOUNT', amountCents: 10000 } })).toHaveLength(0);
+    expect(await errorPaths({ accessoryDiscount: { type: 'AMOUNT', percentBps: 1000 } })).toContain('accessoryDiscount.amountCents');
+  });
+
+  it('rechaza tipo desconocido, porcentaje fuera de rango, monto y tope no positivos', async () => {
+    expect(await errorPaths({ accessoryDiscount: { type: 'FREE', percentBps: 1000 } })).toContain('accessoryDiscount.type');
+    expect(await errorPaths({ accessoryDiscount: { type: 'PERCENTAGE', percentBps: 10001 } })).toContain('accessoryDiscount.percentBps');
+    expect(await errorPaths({ accessoryDiscount: { type: 'AMOUNT', amountCents: -5 } })).toContain('accessoryDiscount.amountCents');
+    expect(await errorPaths({ accessoryDiscount: { percentBps: 1000, maxAmountCents: 0 } })).toContain('accessoryDiscount.maxAmountCents');
+  });
+});

package/bin/fileStorage/dtos/UserDocumentItem.d.ts

@@ -0,0 +1,6 @@
+export declare class UserDocumentItem {
+    key: string;
+    lastModified: string;
+    sizeKb: string;
+    url: string;
+}

package/bin/fileStorage/dtos/UserDocumentItem.js

@@ -0,0 +1,8 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.UserDocumentItem = void 0;
+// Item que devuelve fiado-s3-lambda en `listDirectoryDocumentsV2` (documentos de un directorio en S3).
+// Response DTO: sin class-validator. `sizeKb` viaja como string porque así lo emite el lambda.
+class UserDocumentItem {
+}
+exports.UserDocumentItem = UserDocumentItem;

package/bin/fileStorage/index.d.ts

@@ -0,0 +1 @@
+export * from './dtos/UserDocumentItem';

package/bin/fileStorage/index.js

@@ -0,0 +1,18 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __exportStar = (this && this.__exportStar) || function(m, exports) {
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+//dtos
+__exportStar(require("./dtos/UserDocumentItem"), exports);

package/bin/index.d.ts

@@ -118,3 +118,4 @@ export * as WebhookBusiness from './webhookBusiness';
 export * as Membership from './membership';
 export * as RetailLoan from './retailLoan';
 export * as MoneyTransfer from './moneyTransfer';
+export * as FileStorage from './fileStorage';

package/bin/index.js

@@ -38,7 +38,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.IssuanceBusiness = exports.Blacklist = exports.CentralPayments = exports.Helpdesk = exports.FiadoApiResponse = exports.Auth = exports.LegalDocumentsBusiness = exports.Role = exports.STPAccount = exports.RiskProfile = exports.FraudPreventionEngine = exports.BBVARst = exports.Stp = exports.BenefitCenter = exports.BankAccount = exports.P2pContact = exports.CreditContract = exports.Contract = exports.ProductCatalog = exports.ContactInfo = exports.TransactionAnalytics = exports.Transaction = exports.TransactionProcessor = exports.GenericMessage = exports.EventBridgeMessage = exports.SessionActivity = exports.NotificationMessages = exports.ServicePayment = exports.Header = exports.Identity = exports.UserTags = exports.Group = exports.File = exports.ExchangeRate = exports.Directory = exports.Currency = exports.Country = exports.Card = exports.Authentication = exports.AppContent = exports.App = exports.Offices = exports.Places = exports.Address = exports.Beneficiary = exports.Activity = exports.Biometrics = exports.MetamapConnector = exports.Account = exports.Crypto = void 0;
 exports.RetailPromotions = exports.RetailWizard = exports.RetailCustomer = exports.RetailCards = exports.RetailCatalog = exports.RetailCommission = exports.RetailOrg = exports.EmailVerification = exports.NetworkConnector = exports.Modelias = exports.TotpSecurity = exports.Passport = exports.WalletFunding = exports.Remittance = exports.PlatformRbac = exports.CognitoBackofficeConnector = exports.WhatsappConnector = exports.TwilioConnector = exports.MessagesConnector = exports.Mdm = exports.MilestoneBusiness = exports.CirculoCredito = exports.CreditStatements = exports.Sentry = exports.AiEngine = exports.Funnel = exports.TeamsConnector = exports.PlatformErrorEvents = exports.CustomerFile = exports.CreditBackoffice = exports.CreditDashboard = exports.CreditEngine = exports.Credit = exports.ComissionBusiness = exports.ReferralBusiness = exports.ZendeskMessaging = exports.NotificationWS = exports.Event = exports.PayrollBusiness = exports.Cnbv = exports.DirectorySetting = exports.InvoiceCollector = exports.Collector = exports.Pricelist = exports.Company = exports.Services = exports.AccountIssuanceBusiness = exports.AppSelectionData = exports.Device = exports.Observations = void 0;
-exports.MoneyTransfer = exports.RetailLoan = exports.Membership = exports.WebhookBusiness = exports.PeopleBusiness = exports.UserConfirmations = exports.Collection = exports.Shipping = exports.PhoneSales = exports.Onboarding = exports.Kyc = exports.LoanScoring = exports.LoanCredit = exports.LoanCollectorAssignment = exports.LoanOfferings = exports.Shortlink = exports.LoanConfig = exports.DatalakeQuery = void 0;
+exports.FileStorage = exports.MoneyTransfer = exports.RetailLoan = exports.Membership = exports.WebhookBusiness = exports.PeopleBusiness = exports.UserConfirmations = exports.Collection = exports.Shipping = exports.PhoneSales = exports.Onboarding = exports.Kyc = exports.LoanScoring = exports.LoanCredit = exports.LoanCollectorAssignment = exports.LoanOfferings = exports.Shortlink = exports.LoanConfig = exports.DatalakeQuery = void 0;
 exports.Crypto = __importStar(require("./crypto"));
 exports.Account = __importStar(require("./account"));
 exports.MetamapConnector = __importStar(require("./metamapConnector"));
@@ -229,3 +229,5 @@ exports.RetailLoan = __importStar(require("./retailLoan"));
 // servicios/productos con riel SPEI/ACH y liquidación inmediata o en lote, liquidaciones
 // (settlements) y estado de órdenes SPEI. Reusa AmountTypeEnum/ReferenceTypeEnum de servicePayment.
 exports.MoneyTransfer = __importStar(require("./moneyTransfer"));
+// FileStorage: contrato de fiado-s3-lambda (documentos de usuario en S3). Consumido por api-invoker (IFileStorageApi).
+exports.FileStorage = __importStar(require("./fileStorage"));

package/bin/retailPromotions/dtos/SalePromotionLevers.d.ts

@@ -2,11 +2,18 @@ import { AccessorySubcategoryEnum } from '../../retailCatalog/enums/AccessorySub
 import { ProductCategoryEnum } from '../../retailCatalog/enums/ProductCategoryEnum';
 import { ProductTierEnum } from '../../retailCatalog/enums/ProductTierEnum';
 import { CouponScopeEnum } from '../enums/CouponScopeEnum';
+import { DiscountTypeEnum } from '../enums/DiscountTypeEnum';
 import { GiftModeEnum } from '../enums/GiftModeEnum';
 import { DiscountValue } from './DiscountValue';
-/** Descuento en accesorios: % sobre los accesorios de la venta, con tope opcional en centavos. */
+/** Descuento del equipo en % o $, con tope opcional en centavos. */
+export interface DeviceDiscountLever extends DiscountValue {
+    maxAmountCents?: number | null;
+}
+/** Descuento en accesorios en % o $, con tope opcional en centavos; sin `type` es `PERCENTAGE`. */
 export interface AccessoryDiscountLever {
-    percentBps: number;
+    type?: DiscountTypeEnum | null;
+    amountCents?: number | null;
+    percentBps: number | null;
     maxAmountCents: number | null;
 }
 /** Regalo por lista (`skus`) o por gama (`accessorySubcategory` + `maxPriceCents`); el cliente elige `chooseCount`. */
@@ -37,7 +44,7 @@ export interface WalletBonusLever {
 }
 /** Las 7 palancas; una palanca ausente o `null` no se usa. */
 export interface SalePromotionLevers {
-    deviceDiscount: DiscountValue | null;
+    deviceDiscount: DeviceDiscountLever | null;
     accessoryDiscount: AccessoryDiscountLever | null;
     gift: GiftLever | null;
     coupon: CouponLever | null;

package/bin/retailPromotions/dtos/requests/SalePromotionLeversInput.d.ts

@@ -1,9 +1,20 @@
 import { AccessorySubcategoryEnum } from '../../../retailCatalog/enums/AccessorySubcategoryEnum';
 import { CouponScopeEnum } from '../../enums/CouponScopeEnum';
+import { DiscountTypeEnum } from '../../enums/DiscountTypeEnum';
 import { GiftModeEnum } from '../../enums/GiftModeEnum';
 import { DiscountValueInput } from './DiscountValueInput';
+/** Descuento del equipo: % (`percentBps` 1..10000) o $ (`amountCents` > 0), con tope opcional en centavos. */
+export declare class DeviceDiscountLeverInput {
+    type: DiscountTypeEnum;
+    amountCents?: number | null;
+    percentBps?: number | null;
+    maxAmountCents?: number | null;
+}
+/** Descuento en accesorios: igual que el del equipo, pero sin `type` se asume `PERCENTAGE`. */
 export declare class AccessoryDiscountLeverInput {
-    percentBps: number;
+    type?: DiscountTypeEnum | null;
+    amountCents?: number | null;
+    percentBps?: number | null;
     maxAmountCents?: number | null;
 }
 /** Regalo por lista exige `skus`; por gama exige `accessorySubcategory` y `maxPriceCents`. */
@@ -31,7 +42,7 @@ export declare class WalletBonusLeverInput {
 }
 /** Las 7 palancas en el body; que venga al menos una lo valida el lambda (422). */
 export declare class SalePromotionLeversInput {
-    deviceDiscount?: DiscountValueInput | null;
+    deviceDiscount?: DeviceDiscountLeverInput | null;
     accessoryDiscount?: AccessoryDiscountLeverInput | null;
     gift?: GiftLeverInput | null;
     coupon?: CouponLeverInput | null;

package/bin/retailPromotions/dtos/requests/SalePromotionLeversInput.js

@@ -9,25 +9,75 @@ var __metadata = (this && this.__metadata) || function (k, v) {
     if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.SalePromotionLeversInput = exports.WalletBonusLeverInput = exports.ExtendedWarrantyLeverInput = exports.AirtimeLeverInput = exports.CouponLeverInput = exports.GiftLeverInput = exports.AccessoryDiscountLeverInput = void 0;
+exports.SalePromotionLeversInput = exports.WalletBonusLeverInput = exports.ExtendedWarrantyLeverInput = exports.AirtimeLeverInput = exports.CouponLeverInput = exports.GiftLeverInput = exports.AccessoryDiscountLeverInput = exports.DeviceDiscountLeverInput = void 0;
 const class_transformer_1 = require("class-transformer");
 const class_validator_1 = require("class-validator");
 const AccessorySubcategoryEnum_1 = require("../../../retailCatalog/enums/AccessorySubcategoryEnum");
 const CouponScopeEnum_1 = require("../../enums/CouponScopeEnum");
+const DiscountTypeEnum_1 = require("../../enums/DiscountTypeEnum");
 const GiftModeEnum_1 = require("../../enums/GiftModeEnum");
 const DiscountValueInput_1 = require("./DiscountValueInput");
+/** Descuento del equipo: % (`percentBps` 1..10000) o $ (`amountCents` > 0), con tope opcional en centavos. */
+class DeviceDiscountLeverInput {
+}
+exports.DeviceDiscountLeverInput = DeviceDiscountLeverInput;
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.IsEnum)(DiscountTypeEnum_1.DiscountTypeEnum),
+    __metadata("design:type", String)
+], DeviceDiscountLeverInput.prototype, "type", void 0);
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.ValidateIf)((o) => o.type === DiscountTypeEnum_1.DiscountTypeEnum.AMOUNT),
+    (0, class_validator_1.IsInt)(),
+    (0, class_validator_1.Min)(1),
+    __metadata("design:type", Number)
+], DeviceDiscountLeverInput.prototype, "amountCents", void 0);
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.ValidateIf)((o) => o.type === DiscountTypeEnum_1.DiscountTypeEnum.PERCENTAGE),
+    (0, class_validator_1.IsInt)(),
+    (0, class_validator_1.Min)(1),
+    (0, class_validator_1.Max)(10000),
+    __metadata("design:type", Number)
+], DeviceDiscountLeverInput.prototype, "percentBps", void 0);
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.IsOptional)(),
+    (0, class_validator_1.IsInt)(),
+    (0, class_validator_1.Min)(1),
+    __metadata("design:type", Number)
+], DeviceDiscountLeverInput.prototype, "maxAmountCents", void 0);
+/** Descuento en accesorios: igual que el del equipo, pero sin `type` se asume `PERCENTAGE`. */
 class AccessoryDiscountLeverInput {
 }
 exports.AccessoryDiscountLeverInput = AccessoryDiscountLeverInput;
 __decorate([
     (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.IsOptional)(),
+    (0, class_validator_1.IsEnum)(DiscountTypeEnum_1.DiscountTypeEnum),
+    __metadata("design:type", String)
+], AccessoryDiscountLeverInput.prototype, "type", void 0);
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.ValidateIf)((o) => o.type === DiscountTypeEnum_1.DiscountTypeEnum.AMOUNT),
+    (0, class_validator_1.IsInt)(),
+    (0, class_validator_1.Min)(1),
+    __metadata("design:type", Number)
+], AccessoryDiscountLeverInput.prototype, "amountCents", void 0);
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.ValidateIf)((o) => o.type !== DiscountTypeEnum_1.DiscountTypeEnum.AMOUNT),
     (0, class_validator_1.IsInt)(),
+    (0, class_validator_1.Min)(1),
+    (0, class_validator_1.Max)(10000),
     __metadata("design:type", Number)
 ], AccessoryDiscountLeverInput.prototype, "percentBps", void 0);
 __decorate([
     (0, class_transformer_1.Expose)(),
     (0, class_validator_1.IsOptional)(),
     (0, class_validator_1.IsInt)(),
+    (0, class_validator_1.Min)(1),
     __metadata("design:type", Number)
 ], AccessoryDiscountLeverInput.prototype, "maxAmountCents", void 0);
 /** Regalo por lista exige `skus`; por gama exige `accessorySubcategory` y `maxPriceCents`. */
@@ -119,8 +169,8 @@ __decorate([
     (0, class_transformer_1.Expose)(),
     (0, class_validator_1.IsOptional)(),
     (0, class_validator_1.ValidateNested)(),
-    (0, class_transformer_1.Type)(() => DiscountValueInput_1.DiscountValueInput),
-    __metadata("design:type", DiscountValueInput_1.DiscountValueInput)
+    (0, class_transformer_1.Type)(() => DeviceDiscountLeverInput),
+    __metadata("design:type", DeviceDiscountLeverInput)
 ], SalePromotionLeversInput.prototype, "deviceDiscount", void 0);
 __decorate([
     (0, class_transformer_1.Expose)(),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fiado/type-kit",
-  "version": "3.483.0",
+  "version": "3.485.0",
   "description": "",
   "main": "bin/index.js",
   "types": "bin/index.d.ts",

package/src/fileStorage/dtos/UserDocumentItem.ts

@@ -0,0 +1,8 @@
+// Item que devuelve fiado-s3-lambda en `listDirectoryDocumentsV2` (documentos de un directorio en S3).
+// Response DTO: sin class-validator. `sizeKb` viaja como string porque así lo emite el lambda.
+export class UserDocumentItem {
+    key: string;
+    lastModified: string;
+    sizeKb: string;
+    url: string;
+}

package/src/fileStorage/index.ts

@@ -0,0 +1,2 @@
+//dtos
+export * from './dtos/UserDocumentItem';

package/src/index.ts

@@ -189,3 +189,5 @@ export * as RetailLoan from './retailLoan';
 // servicios/productos con riel SPEI/ACH y liquidación inmediata o en lote, liquidaciones
 // (settlements) y estado de órdenes SPEI. Reusa AmountTypeEnum/ReferenceTypeEnum de servicePayment.
 export * as MoneyTransfer from './moneyTransfer';
+// FileStorage: contrato de fiado-s3-lambda (documentos de usuario en S3). Consumido por api-invoker (IFileStorageApi).
+export * as FileStorage from './fileStorage';

package/src/retailPromotions/dtos/SalePromotionLevers.ts

@@ -2,12 +2,20 @@ import { AccessorySubcategoryEnum } from '../../retailCatalog/enums/AccessorySub
 import { ProductCategoryEnum } from '../../retailCatalog/enums/ProductCategoryEnum';
 import { ProductTierEnum } from '../../retailCatalog/enums/ProductTierEnum';
 import { CouponScopeEnum } from '../enums/CouponScopeEnum';
+import { DiscountTypeEnum } from '../enums/DiscountTypeEnum';
 import { GiftModeEnum } from '../enums/GiftModeEnum';
 import { DiscountValue } from './DiscountValue';
 
-/** Descuento en accesorios: % sobre los accesorios de la venta, con tope opcional en centavos. */
+/** Descuento del equipo en % o $, con tope opcional en centavos. */
+export interface DeviceDiscountLever extends DiscountValue {
+    maxAmountCents?: number | null;
+}
+
+/** Descuento en accesorios en % o $, con tope opcional en centavos; sin `type` es `PERCENTAGE`. */
 export interface AccessoryDiscountLever {
-    percentBps: number;
+    type?: DiscountTypeEnum | null;
+    amountCents?: number | null;
+    percentBps: number | null;
     maxAmountCents: number | null;
 }
 
@@ -44,7 +52,7 @@ export interface WalletBonusLever {
 
 /** Las 7 palancas; una palanca ausente o `null` no se usa. */
 export interface SalePromotionLevers {
-    deviceDiscount: DiscountValue | null;
+    deviceDiscount: DeviceDiscountLever | null;
     accessoryDiscount: AccessoryDiscountLever | null;
     gift: GiftLever | null;
     coupon: CouponLever | null;

package/src/retailPromotions/dtos/requests/SalePromotionLeversInput.ts

@@ -5,23 +5,68 @@ import {
     IsEnum,
     IsInt,
     IsOptional,
+    Max,
+    Min,
     IsString,
     ValidateIf,
     ValidateNested,
 } from 'class-validator';
 import { AccessorySubcategoryEnum } from '../../../retailCatalog/enums/AccessorySubcategoryEnum';
 import { CouponScopeEnum } from '../../enums/CouponScopeEnum';
+import { DiscountTypeEnum } from '../../enums/DiscountTypeEnum';
 import { GiftModeEnum } from '../../enums/GiftModeEnum';
 import { DiscountValueInput } from './DiscountValueInput';
 
+/** Descuento del equipo: % (`percentBps` 1..10000) o $ (`amountCents` > 0), con tope opcional en centavos. */
+export class DeviceDiscountLeverInput {
+    @Expose()
+    @IsEnum(DiscountTypeEnum)
+    type!: DiscountTypeEnum;
+
+    @Expose()
+    @ValidateIf((o: DeviceDiscountLeverInput) => o.type === DiscountTypeEnum.AMOUNT)
+    @IsInt()
+    @Min(1)
+    amountCents?: number | null;
+
+    @Expose()
+    @ValidateIf((o: DeviceDiscountLeverInput) => o.type === DiscountTypeEnum.PERCENTAGE)
+    @IsInt()
+    @Min(1)
+    @Max(10000)
+    percentBps?: number | null;
+
+    @Expose()
+    @IsOptional()
+    @IsInt()
+    @Min(1)
+    maxAmountCents?: number | null;
+}
+
+/** Descuento en accesorios: igual que el del equipo, pero sin `type` se asume `PERCENTAGE`. */
 export class AccessoryDiscountLeverInput {
     @Expose()
+    @IsOptional()
+    @IsEnum(DiscountTypeEnum)
+    type?: DiscountTypeEnum | null;
+
+    @Expose()
+    @ValidateIf((o: AccessoryDiscountLeverInput) => o.type === DiscountTypeEnum.AMOUNT)
+    @IsInt()
+    @Min(1)
+    amountCents?: number | null;
+
+    @Expose()
+    @ValidateIf((o: AccessoryDiscountLeverInput) => o.type !== DiscountTypeEnum.AMOUNT)
     @IsInt()
-    percentBps!: number;
+    @Min(1)
+    @Max(10000)
+    percentBps?: number | null;
 
     @Expose()
     @IsOptional()
     @IsInt()
+    @Min(1)
     maxAmountCents?: number | null;
 }
 
@@ -94,8 +139,8 @@ export class SalePromotionLeversInput {
     @Expose()
     @IsOptional()
     @ValidateNested()
-    @Type(() => DiscountValueInput)
-    deviceDiscount?: DiscountValueInput | null;
+    @Type(() => DeviceDiscountLeverInput)
+    deviceDiscount?: DeviceDiscountLeverInput | null;
 
     @Expose()
     @IsOptional()