@fiado/type-kit 3.477.0 → 3.479.0

package/_test_/unit/retailPromotions/constants.test.ts

@@ -43,7 +43,7 @@ describe('catálogo de errores', () => {
     expect(RETAIL_PROMOTIONS_ERROR_HTTP_STATUS.CODE_NOT_FOUND).toBe(404);
     expect(RETAIL_PROMOTIONS_ERROR_HTTP_STATUS.DISCOUNT_AFTER_QUOTE).toBe(409);
     expect(RETAIL_PROMOTIONS_ERROR_HTTP_STATUS.CODE_NOT_OWNED).toBe(422);
-    expect(Object.keys(RetailPromotionsErrorCodeEnum)).toHaveLength(28);
+    expect(Object.keys(RetailPromotionsErrorCodeEnum)).toHaveLength(29);
   });
 
   it('promo de regalo y de venta mandadas en el campo equivocado son 422', () => {

package/_test_/unit/retailPromotions/skuSalePromotions.test.ts

@@ -0,0 +1,49 @@
+import 'reflect-metadata';
+import { plainToInstance } from 'class-transformer';
+import { validate } from 'class-validator';
+import {
+  RETAIL_PROMOTIONS_ERROR_HTTP_STATUS,
+  RetailPromotionsErrorCodeEnum,
+  SkuSalePromotionsQuery,
+  SkuSalePromotionsResponse,
+} from '../../../src/retailPromotions/index';
+
+const invalidProps = async (raw: Record<string, unknown>): Promise<string[]> => {
+  const errors = await validate(plainToInstance(SkuSalePromotionsQuery, raw) as object);
+  return errors.map((e) => e.property).sort();
+};
+
+describe('SkuSalePromotionsQuery', () => {
+  it('acepta sessionId y sku', async () => {
+    expect(await invalidProps({ sessionId: 'ses-1', sku: 'SKU-1' })).toEqual([]);
+  });
+
+  it('exige ambos campos', async () => {
+    expect(await invalidProps({})).toEqual(['sessionId', 'sku']);
+  });
+
+  it.each([
+    ['sessionId', { sessionId: '', sku: 'SKU-1' }],
+    ['sku', { sessionId: 'ses-1', sku: '' }],
+  ])('rechaza %s vacío', async (prop, raw) => {
+    expect(await invalidProps(raw)).toEqual([prop]);
+  });
+
+  it('rechaza valores que no son texto', async () => {
+    expect(await invalidProps({ sessionId: 1, sku: ['SKU-1'] })).toEqual(['sessionId', 'sku']);
+  });
+});
+
+describe('SkuSalePromotionsResponse', () => {
+  it('lleva el sku y sus promos evaluadas', () => {
+    const response: SkuSalePromotionsResponse = { sku: 'SKU-1', promotions: [] };
+    expect(response.promotions).toEqual([]);
+  });
+});
+
+describe('CATALOG_SKU_NOT_FOUND', () => {
+  it('es 404', () => {
+    expect(RetailPromotionsErrorCodeEnum.CATALOG_SKU_NOT_FOUND).toBe('CATALOG_SKU_NOT_FOUND');
+    expect(RETAIL_PROMOTIONS_ERROR_HTTP_STATUS.CATALOG_SKU_NOT_FOUND).toBe(404);
+  });
+});

package/_test_/unit/retailWizard/promotionM2mRequests.test.ts

@@ -83,6 +83,43 @@ describe('SetAnchorGiftsRequest', () => {
     expect(errorsOf(SetAnchorGiftsRequest, { ...ok, items: [{ sku: '' }] })).toContain('items.0.sku'));
   it('exige items como arreglo', () =>
     expect(errorsOf(SetAnchorGiftsRequest, { promotionId: null, promotionVersion: null })).toContain('items'));
+
+  describe('promo por item', () => {
+    const own = { sku: 'CASE-1', promotionId: 'promo-2', promotionVersion: 3 };
+
+    it('acepta un item sin promo propia (usa la de la raíz)', () => {
+      const req = plainToInstance(SetAnchorGiftsRequest, ok);
+      expect(validateSync(req)).toEqual([]);
+      expect(req.items[0].promotionId).toBeUndefined();
+      expect(req.items[0].promotionVersion).toBeUndefined();
+    });
+    it('acepta un item con promotionId y promotionVersion', () =>
+      expect(errorsOf(SetAnchorGiftsRequest, { ...ok, items: [own] })).toEqual([]));
+    it('exige promotionVersion si el item trae solo promotionId', () =>
+      expect(errorsOf(SetAnchorGiftsRequest, { ...ok, items: [{ sku: 'CASE-1', promotionId: 'promo-2' }] })).toContain(
+        'items.0.promotionVersion',
+      ));
+    it('exige promotionId si el item trae solo promotionVersion', () =>
+      expect(errorsOf(SetAnchorGiftsRequest, { ...ok, items: [{ sku: 'CASE-1', promotionVersion: 3 }] })).toContain(
+        'items.0.promotionId',
+      ));
+    it('rechaza la versión 0 en el item', () =>
+      expect(errorsOf(SetAnchorGiftsRequest, { ...ok, items: [{ ...own, promotionVersion: 0 }] })).toContain(
+        'items.0.promotionVersion',
+      ));
+    it('rechaza promotionId vacío en el item', () =>
+      expect(errorsOf(SetAnchorGiftsRequest, { ...ok, items: [{ ...own, promotionId: '' }] })).toContain(
+        'items.0.promotionId',
+      ));
+    it('acepta dos items de la misma ancla con promos distintas', () => {
+      const req = plainToInstance(SetAnchorGiftsRequest, {
+        ...ok,
+        items: [own, { sku: 'MICA-1', promotionId: 'promo-9', promotionVersion: 1 }],
+      });
+      expect(validateSync(req)).toEqual([]);
+      expect(req.items.map((i) => i.promotionId)).toEqual(['promo-2', 'promo-9']);
+    });
+  });
 });
 
 describe('ApplySalePromotionRequest', () => {

package/bin/retailPromotions/constants/retailPromotionsErrorHttpStatus.js

@@ -32,4 +32,5 @@ exports.RETAIL_PROMOTIONS_ERROR_HTTP_STATUS = {
     [RetailPromotionsErrorCodeEnum_1.RetailPromotionsErrorCodeEnum.PROMOTION_NOT_REVALIDATED]: 409,
     [RetailPromotionsErrorCodeEnum_1.RetailPromotionsErrorCodeEnum.SALE_PROMOTION_HOLD_CONFLICT]: 409,
     [RetailPromotionsErrorCodeEnum_1.RetailPromotionsErrorCodeEnum.INVALID_NEXT_TOKEN]: 400,
+    [RetailPromotionsErrorCodeEnum_1.RetailPromotionsErrorCodeEnum.CATALOG_SKU_NOT_FOUND]: 404,
 };

package/bin/retailPromotions/dtos/requests/SkuSalePromotionsQuery.d.ts

@@ -0,0 +1,5 @@
+/** Query de publicListSkuSalePromotions; precio, tienda y cliente salen de la sesión y del catálogo. */
+export declare class SkuSalePromotionsQuery {
+    sessionId: string;
+    sku: string;
+}

package/bin/retailPromotions/dtos/requests/SkuSalePromotionsQuery.js

@@ -0,0 +1,30 @@
+"use strict";
+var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
+    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
+    if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
+    else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
+    return c > 3 && r && Object.defineProperty(target, key, r), r;
+};
+var __metadata = (this && this.__metadata) || function (k, v) {
+    if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.SkuSalePromotionsQuery = void 0;
+const class_transformer_1 = require("class-transformer");
+const class_validator_1 = require("class-validator");
+/** Query de publicListSkuSalePromotions; precio, tienda y cliente salen de la sesión y del catálogo. */
+class SkuSalePromotionsQuery {
+}
+exports.SkuSalePromotionsQuery = SkuSalePromotionsQuery;
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.IsString)(),
+    (0, class_validator_1.IsNotEmpty)(),
+    __metadata("design:type", String)
+], SkuSalePromotionsQuery.prototype, "sessionId", void 0);
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.IsString)(),
+    (0, class_validator_1.IsNotEmpty)(),
+    __metadata("design:type", String)
+], SkuSalePromotionsQuery.prototype, "sku", void 0);

package/bin/retailPromotions/dtos/responses/SkuSalePromotionsResponse.d.ts

@@ -0,0 +1,6 @@
+import { EvaluatedSalePromotion } from './WizardSalePromotionResponses';
+/** Promos que aplicarían si el SKU fuera la ancla de la sesión, con sus opciones de regalo. */
+export interface SkuSalePromotionsResponse {
+    sku: string;
+    promotions: EvaluatedSalePromotion[];
+}

package/bin/retailPromotions/dtos/responses/SkuSalePromotionsResponse.js

@@ -0,0 +1,2 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });

package/bin/retailPromotions/enums/RetailPromotionsErrorCodeEnum.d.ts

@@ -40,5 +40,7 @@ export declare enum RetailPromotionsErrorCodeEnum {
     /** Otra venta ya retiene la promo. */
     SALE_PROMOTION_HOLD_CONFLICT = "SALE_PROMOTION_HOLD_CONFLICT",
     /** El token de paginación no es válido. */
-    INVALID_NEXT_TOKEN = "INVALID_NEXT_TOKEN"
+    INVALID_NEXT_TOKEN = "INVALID_NEXT_TOKEN",
+    /** El SKU no existe en el catálogo. */
+    CATALOG_SKU_NOT_FOUND = "CATALOG_SKU_NOT_FOUND"
 }

package/bin/retailPromotions/enums/RetailPromotionsErrorCodeEnum.js

@@ -45,4 +45,6 @@ var RetailPromotionsErrorCodeEnum;
     RetailPromotionsErrorCodeEnum["SALE_PROMOTION_HOLD_CONFLICT"] = "SALE_PROMOTION_HOLD_CONFLICT";
     /** El token de paginación no es válido. */
     RetailPromotionsErrorCodeEnum["INVALID_NEXT_TOKEN"] = "INVALID_NEXT_TOKEN";
+    /** El SKU no existe en el catálogo. */
+    RetailPromotionsErrorCodeEnum["CATALOG_SKU_NOT_FOUND"] = "CATALOG_SKU_NOT_FOUND";
 })(RetailPromotionsErrorCodeEnum || (exports.RetailPromotionsErrorCodeEnum = RetailPromotionsErrorCodeEnum = {}));

package/bin/retailPromotions/index.d.ts

@@ -45,6 +45,8 @@ export * from './dtos/requests/EvaluateSalePromotionsRequest';
 export * from './dtos/requests/HoldGiftPromotionInput';
 export * from './dtos/requests/HoldSalePromotionRequest';
 export * from './dtos/requests/GetSaleCouponQuery';
+export * from './dtos/requests/SkuSalePromotionsQuery';
 export * from './dtos/responses/SalePromotionCrudResponses';
 export * from './dtos/responses/DiscountCodeResponses';
 export * from './dtos/responses/WizardSalePromotionResponses';
+export * from './dtos/responses/SkuSalePromotionsResponse';

package/bin/retailPromotions/index.js

@@ -65,7 +65,9 @@ __exportStar(require("./dtos/requests/EvaluateSalePromotionsRequest"), exports);
 __exportStar(require("./dtos/requests/HoldGiftPromotionInput"), exports);
 __exportStar(require("./dtos/requests/HoldSalePromotionRequest"), exports);
 __exportStar(require("./dtos/requests/GetSaleCouponQuery"), exports);
+__exportStar(require("./dtos/requests/SkuSalePromotionsQuery"), exports);
 // Response DTOs
 __exportStar(require("./dtos/responses/SalePromotionCrudResponses"), exports);
 __exportStar(require("./dtos/responses/DiscountCodeResponses"), exports);
 __exportStar(require("./dtos/responses/WizardSalePromotionResponses"), exports);
+__exportStar(require("./dtos/responses/SkuSalePromotionsResponse"), exports);

package/bin/retailWizard/dtos/requests/SetAnchorGiftsRequest.d.ts

@@ -1,6 +1,9 @@
 /** Un regalo del conjunto que queda ligado al ancla. */
 export declare class AnchorGiftItem {
     sku: string;
+    /** Promo propia de esta línea GIFT; va junto con `promotionVersion` y, si falta, se usa la de la raíz. */
+    promotionId?: string;
+    promotionVersion?: number;
 }
 /**
  * PUT /private/wizard/sessions/{id}/lines/{anchorLineId}/gifts (M2M de Promociones).

package/bin/retailWizard/dtos/requests/SetAnchorGiftsRequest.js

@@ -12,6 +12,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.SetAnchorGiftsRequest = exports.AnchorGiftItem = void 0;
 const class_transformer_1 = require("class-transformer");
 const class_validator_1 = require("class-validator");
+/** Hay que validar la promo del item si vino cualquiera de sus dos campos. */
+function hasOwnPromotion(o) {
+    return o.promotionId !== undefined || o.promotionVersion !== undefined;
+}
 /** Un regalo del conjunto que queda ligado al ancla. */
 class AnchorGiftItem {
 }
@@ -22,6 +26,20 @@ __decorate([
     (0, class_validator_1.IsNotEmpty)(),
     __metadata("design:type", String)
 ], AnchorGiftItem.prototype, "sku", void 0);
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.ValidateIf)(hasOwnPromotion),
+    (0, class_validator_1.IsString)(),
+    (0, class_validator_1.IsNotEmpty)(),
+    __metadata("design:type", String)
+], AnchorGiftItem.prototype, "promotionId", void 0);
+__decorate([
+    (0, class_transformer_1.Expose)(),
+    (0, class_validator_1.ValidateIf)(hasOwnPromotion),
+    (0, class_validator_1.IsInt)(),
+    (0, class_validator_1.Min)(1),
+    __metadata("design:type", Number)
+], AnchorGiftItem.prototype, "promotionVersion", void 0);
 /** Hay que validar el campo si hay regalos o si vino con valor. */
 function mustValidate(o, value) {
     return (Array.isArray(o.items) && o.items.length > 0) || (value !== null && value !== undefined);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fiado/type-kit",
-  "version": "3.477.0",
+  "version": "3.479.0",
   "description": "",
   "main": "bin/index.js",
   "types": "bin/index.d.ts",

package/src/retailPromotions/constants/retailPromotionsErrorHttpStatus.ts

@@ -30,4 +30,5 @@ export const RETAIL_PROMOTIONS_ERROR_HTTP_STATUS: Readonly<Record<C, 400 | 403 |
     [C.PROMOTION_NOT_REVALIDATED]: 409,
     [C.SALE_PROMOTION_HOLD_CONFLICT]: 409,
     [C.INVALID_NEXT_TOKEN]: 400,
+    [C.CATALOG_SKU_NOT_FOUND]: 404,
 };

package/src/retailPromotions/dtos/requests/SkuSalePromotionsQuery.ts

@@ -0,0 +1,15 @@
+import { Expose } from 'class-transformer';
+import { IsNotEmpty, IsString } from 'class-validator';
+
+/** Query de publicListSkuSalePromotions; precio, tienda y cliente salen de la sesión y del catálogo. */
+export class SkuSalePromotionsQuery {
+    @Expose()
+    @IsString()
+    @IsNotEmpty()
+    sessionId!: string;
+
+    @Expose()
+    @IsString()
+    @IsNotEmpty()
+    sku!: string;
+}

package/src/retailPromotions/dtos/responses/SkuSalePromotionsResponse.ts

@@ -0,0 +1,7 @@
+import { EvaluatedSalePromotion } from './WizardSalePromotionResponses';
+
+/** Promos que aplicarían si el SKU fuera la ancla de la sesión, con sus opciones de regalo. */
+export interface SkuSalePromotionsResponse {
+    sku: string;
+    promotions: EvaluatedSalePromotion[];
+}

package/src/retailPromotions/enums/RetailPromotionsErrorCodeEnum.ts

@@ -41,4 +41,6 @@ export enum RetailPromotionsErrorCodeEnum {
     SALE_PROMOTION_HOLD_CONFLICT = 'SALE_PROMOTION_HOLD_CONFLICT',
     /** El token de paginación no es válido. */
     INVALID_NEXT_TOKEN = 'INVALID_NEXT_TOKEN',
+    /** El SKU no existe en el catálogo. */
+    CATALOG_SKU_NOT_FOUND = 'CATALOG_SKU_NOT_FOUND',
 }

package/src/retailPromotions/index.ts

@@ -52,8 +52,10 @@ export * from './dtos/requests/EvaluateSalePromotionsRequest';
 export * from './dtos/requests/HoldGiftPromotionInput';
 export * from './dtos/requests/HoldSalePromotionRequest';
 export * from './dtos/requests/GetSaleCouponQuery';
+export * from './dtos/requests/SkuSalePromotionsQuery';
 
 // Response DTOs
 export * from './dtos/responses/SalePromotionCrudResponses';
 export * from './dtos/responses/DiscountCodeResponses';
 export * from './dtos/responses/WizardSalePromotionResponses';
+export * from './dtos/responses/SkuSalePromotionsResponse';

package/src/retailWizard/dtos/requests/SetAnchorGiftsRequest.ts

@@ -1,12 +1,30 @@
 import { Expose, Type } from 'class-transformer';
 import { IsArray, IsInt, IsNotEmpty, IsString, Min, ValidateIf, ValidateNested } from 'class-validator';
 
+/** Hay que validar la promo del item si vino cualquiera de sus dos campos. */
+function hasOwnPromotion(o: AnchorGiftItem): boolean {
+  return o.promotionId !== undefined || o.promotionVersion !== undefined;
+}
+
 /** Un regalo del conjunto que queda ligado al ancla. */
 export class AnchorGiftItem {
   @Expose()
   @IsString()
   @IsNotEmpty()
   sku!: string;
+
+  /** Promo propia de esta línea GIFT; va junto con `promotionVersion` y, si falta, se usa la de la raíz. */
+  @Expose()
+  @ValidateIf(hasOwnPromotion)
+  @IsString()
+  @IsNotEmpty()
+  promotionId?: string;
+
+  @Expose()
+  @ValidateIf(hasOwnPromotion)
+  @IsInt()
+  @Min(1)
+  promotionVersion?: number;
 }
 
 /** Hay que validar el campo si hay regalos o si vino con valor. */