@fiado/type-kit 3.437.0 → 3.438.0

package/_test_/unit/loanCredit/creditLifecycleEnums.test.ts

@@ -41,7 +41,14 @@ describe.each([
     [
         'PaymentReviewReasonEnum',
         PaymentReviewReasonEnum,
-        ['OVERPAYMENT', 'INSTALLMENT_CLOSED', 'CREDIT_NOT_COLLECTIBLE', 'LEGACY_INSTALLMENT_WITH_PAYMENT', 'UNCAPTURED_HOLD'],
+        [
+            'OVERPAYMENT',
+            'INSTALLMENT_CLOSED',
+            'CREDIT_NOT_COLLECTIBLE',
+            'LEGACY_INSTALLMENT_WITH_PAYMENT',
+            'UNCAPTURED_HOLD',
+            'AD_HOC_CHARGE_INCOMPLETE',
+        ],
     ],
     ['PaymentReviewActionEnum', PaymentReviewActionEnum, ['APPLY', 'REFUND', 'RECONCILE']],
     ['RefundDestinationEnum', RefundDestinationEnum, ['CUSTOMER_ACCOUNT', 'PCF_CLABE']],

package/_test_/unit/loanCredit/dtos/creditLifecycleRequests.test.ts

@@ -60,8 +60,12 @@ describe('BackofficeWriteOffCreditRequest', () => {
         expect(await errorPaths(BackofficeWriteOffCreditRequest, body)).toEqual([]);
     });
 
-    it('rechaza un motivo vacío y una confirmación que no es booleana', async () => {
-        const body = { reason: '', confirmations: { recoveryResourcesExhausted: 'yes' } };
+    it('deja pasar el motivo vacío para que el lambda responda WRITE_OFF_REASON_REQUIRED', async () => {
+        expect(await errorPaths(BackofficeWriteOffCreditRequest, { reason: '' })).toEqual([]);
+    });
+
+    it('rechaza un motivo que no es texto y una confirmación que no es booleana', async () => {
+        const body = { reason: 42, confirmations: { recoveryResourcesExhausted: 'yes' } };
 
         expect(await errorPaths(BackofficeWriteOffCreditRequest, body)).toEqual(
             expect.arrayContaining(['reason', 'confirmations.recoveryResourcesExhausted']),

package/bin/loanCredit/dtos/requests/BackofficeWriteOffCreditRequest.js

@@ -21,7 +21,6 @@ __decorate([
     (0, class_transformer_1.Expose)(),
     (0, class_validator_1.IsOptional)(),
     (0, class_validator_1.IsString)(),
-    (0, class_validator_1.MinLength)(1),
     __metadata("design:type", String)
 ], BackofficeWriteOffCreditRequest.prototype, "reason", void 0);
 __decorate([

package/bin/loanCredit/enums/PaymentReviewReasonEnum.d.ts

@@ -12,5 +12,7 @@ export declare enum PaymentReviewReasonEnum {
     /** Cuota con abonos previos sin desglose. */
     LEGACY_INSTALLMENT_WITH_PAYMENT = "LEGACY_INSTALLMENT_WITH_PAYMENT",
     /** Lo retenido sin capturar. */
-    UNCAPTURED_HOLD = "UNCAPTURED_HOLD"
+    UNCAPTURED_HOLD = "UNCAPTURED_HOLD",
+    /** Cobro ad hoc PREPAYMENT, ADVANCE o RECOVERY que no fue completo. */
+    AD_HOC_CHARGE_INCOMPLETE = "AD_HOC_CHARGE_INCOMPLETE"
 }

package/bin/loanCredit/enums/PaymentReviewReasonEnum.js

@@ -17,4 +17,6 @@ var PaymentReviewReasonEnum;
     PaymentReviewReasonEnum["LEGACY_INSTALLMENT_WITH_PAYMENT"] = "LEGACY_INSTALLMENT_WITH_PAYMENT";
     /** Lo retenido sin capturar. */
     PaymentReviewReasonEnum["UNCAPTURED_HOLD"] = "UNCAPTURED_HOLD";
+    /** Cobro ad hoc PREPAYMENT, ADVANCE o RECOVERY que no fue completo. */
+    PaymentReviewReasonEnum["AD_HOC_CHARGE_INCOMPLETE"] = "AD_HOC_CHARGE_INCOMPLETE";
 })(PaymentReviewReasonEnum || (exports.PaymentReviewReasonEnum = PaymentReviewReasonEnum = {}));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fiado/type-kit",
-  "version": "3.437.0",
+  "version": "3.438.0",
   "description": "",
   "main": "bin/index.js",
   "types": "bin/index.d.ts",

package/src/loanCredit/dtos/requests/BackofficeWriteOffCreditRequest.ts

@@ -1,5 +1,5 @@
 import { Expose, Type } from 'class-transformer';
-import { IsOptional, IsString, MinLength, ValidateNested } from 'class-validator';
+import { IsOptional, IsString, ValidateNested } from 'class-validator';
 import { WriteOffConfirmations } from '../WriteOffConfirmations';
 
 /** Body de `POST /backoffice/credits/:creditId/write-off`. Los faltantes los responde el lambda con su code. */
@@ -8,7 +8,6 @@ export class BackofficeWriteOffCreditRequest {
     @Expose()
     @IsOptional()
     @IsString()
-    @MinLength(1)
     reason?: string;
 
     @Expose()

package/src/loanCredit/enums/PaymentReviewReasonEnum.ts

@@ -13,4 +13,6 @@ export enum PaymentReviewReasonEnum {
     LEGACY_INSTALLMENT_WITH_PAYMENT = 'LEGACY_INSTALLMENT_WITH_PAYMENT',
     /** Lo retenido sin capturar. */
     UNCAPTURED_HOLD = 'UNCAPTURED_HOLD',
+    /** Cobro ad hoc PREPAYMENT, ADVANCE o RECOVERY que no fue completo. */
+    AD_HOC_CHARGE_INCOMPLETE = 'AD_HOC_CHARGE_INCOMPLETE',
 }