@fiado/api-invoker 1.3.21 → 1.3.23

package/bin/bankAccount/BankAccountApi.d.ts

@@ -1,10 +1,13 @@
-import { IBankAccountApi } from "./interfaces/IBankAccountApi";
 import { IHttpRequest } from "@fiado/http-client";
+import { IBankAccountApi } from "./interfaces/IBankAccountApi";
+import GetExternalBankAccountResponse from "@fiado/type-kit/bin/bankAccount/dtos/GetExternalBankAccountResponse";
+import FiadoApiResponse from "@fiado/type-kit/bin/apiResponse/dtos/FiadoApiResponse";
+import { GetExternalBankResponse } from "@fiado/type-kit/bin/bankAccount";
 export default class BankAccountApi implements IBankAccountApi {
     private httpRequest;
     private readonly baseUrl;
     constructor(httpRequest: IHttpRequest);
-    getBankAccountById(bankAccountId: string): Promise<any>;
-    getBankById(bankId: string): Promise<any>;
-    getBankByCode(bankCode?: string, shortBankCode?: string): Promise<any>;
+    getBankAccountById(bankAccountId: string): Promise<FiadoApiResponse<GetExternalBankAccountResponse>>;
+    getBankById(bankId: string): Promise<FiadoApiResponse<GetExternalBankResponse>>;
+    getBankByCode(bankCode?: string, shortBankCode?: string): Promise<FiadoApiResponse<GetExternalBankResponse[]>>;
 }

package/bin/bankAccount/BankAccountApi.js

@@ -19,35 +19,20 @@ let BankAccountApi = class BankAccountApi {
         this.baseUrl = process.env.BANK_ACCOUNT_LAMBDA_UR || "";
     }
     async getBankAccountById(bankAccountId) {
-        const url = `${this.baseUrl}`;
-        const body = {
-            accountId: bankAccountId
-        };
-        const headers = {
-            'Content-Type': 'application/json',
-            operationName: "postBankAccountId"
-        };
-        return await this.httpRequest.post(url, body, headers);
+        const url = `${this.baseUrl}/accounts/${bankAccountId}`;
+        return await this.httpRequest.get(url);
     }
     async getBankById(bankId) {
-        const url = `${this.baseUrl}`;
-        const body = {
-            bankId: bankId
-        };
-        const headers = {
-            'Content-Type': 'application/json',
-            operationName: "getBanksBankId"
-        };
-        return await this.httpRequest.post(url, body, headers);
+        const url = `${this.baseUrl}/banks/${bankId}`;
+        return await this.httpRequest.get(url);
     }
     async getBankByCode(bankCode, shortBankCode) {
-        const url = `${this.baseUrl}`;
-        const params = bankCode ? `bankCode=${bankCode}` : `shortBankCode=${shortBankCode}`;
-        const headers = {
-            'Content-Type': 'application/json',
-            operationName: "getBanks"
+        const url = `${this.baseUrl}/banks`;
+        const params = {
+            ...bankCode && { bankCode: bankCode },
+            ...shortBankCode && { shortBankCode: shortBankCode },
         };
-        return await this.httpRequest.post(`${url}?${params}`, null, headers);
+        return await this.httpRequest.get(url, { params });
     }
 };
 BankAccountApi = __decorate([

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fiado/api-invoker",
-  "version": "1.3.21",
+  "version": "1.3.23",
   "description": "Sirve como un puente entre diferentes funciones lambda, facilitando la comunicación entre ellas a través de invocaciones http",
   "main": "bin/index.js",
   "types": "bin/index.d.ts",

package/src/bankAccount/BankAccountApi.ts

@@ -1,7 +1,11 @@
-import {inject, injectable} from "inversify";
-import {IBankAccountApi} from "./interfaces/IBankAccountApi";
-import {IHttpRequest} from "@fiado/http-client";
-import GetExternalBankAccountRequest from "@fiado/type-kit/bin/bankAccount/dtos/GetExternalBankAccountRequest";
+import { ApiResponse } from "@fiado/gateway-adapter";
+import { IHttpRequest } from "@fiado/http-client";
+import { inject, injectable } from "inversify";
+import { IBankAccountApi } from "./interfaces/IBankAccountApi";
+import GetExternalBankAccountResponse from "@fiado/type-kit/bin/bankAccount/dtos/GetExternalBankAccountResponse";
+import FiadoApiResponse from "@fiado/type-kit/bin/apiResponse/dtos/FiadoApiResponse";
+import { GetExternalBankResponse } from "@fiado/type-kit/bin/bankAccount";
+
 
 @injectable()
 export default class BankAccountApi implements IBankAccountApi {
@@ -10,40 +14,22 @@ export default class BankAccountApi implements IBankAccountApi {
     constructor(@inject("IHttpRequest") private httpRequest: IHttpRequest) {
     }
 
-    async getBankAccountById(bankAccountId: string): Promise<any> {
-        const url = `${this.baseUrl}`;
-        const body: GetExternalBankAccountRequest = {
-            accountId: bankAccountId
-        } as GetExternalBankAccountRequest;
-        const headers = {
-            'Content-Type': 'application/json',
-            operationName: "postBankAccountId"
-        };
-
-        return await this.httpRequest.post(url, body, headers);
+    async getBankAccountById(bankAccountId: string): Promise<FiadoApiResponse<GetExternalBankAccountResponse>> {
+        const url = `${this.baseUrl}/accounts/${bankAccountId}`;
+        return await this.httpRequest.get(url);
     }
 
-    async getBankById(bankId: string): Promise<any> {
-        const url = `${this.baseUrl}`;
-        const body: GetExternalBankAccountRequest = {
-            bankId: bankId
-        } as GetExternalBankAccountRequest;
-        const headers = {
-            'Content-Type': 'application/json',
-            operationName: "getBanksBankId"
-        };
-
-        return await this.httpRequest.post(url, body, headers);
+    async getBankById(bankId: string): Promise<FiadoApiResponse<GetExternalBankResponse>> {
+        const url = `${this.baseUrl}/banks/${bankId}`;
+        return await this.httpRequest.get(url);
     }
 
-    async getBankByCode(bankCode?: string, shortBankCode?: string): Promise<any> {
-        const url = `${this.baseUrl}`;
-        const params = bankCode ? `bankCode=${bankCode}` : `shortBankCode=${shortBankCode}`;
-        const headers = {
-            'Content-Type': 'application/json',
-            operationName: "getBanks"
+    async getBankByCode(bankCode?: string, shortBankCode?: string): Promise<FiadoApiResponse<GetExternalBankResponse[]>> {
+        const url = `${this.baseUrl}/banks`;
+        const params = {
+            ...bankCode && { bankCode: bankCode },
+            ...shortBankCode && { shortBankCode: shortBankCode },
         };
-
-        return await this.httpRequest.post(`${url}?${params}`, null, headers);
+        return await this.httpRequest.get(url, { params });
     }
 }