@fgv/ts-web-extras 5.0.2 → 5.1.0-1

package/src/test/unit/fileApiTreeAccessors.test.ts

@@ -22,6 +22,7 @@
 
 import '@fgv/ts-utils-jest';
 import { FileApiTreeAccessors } from '../../packlets/file-tree';
+import { FileTree } from '@fgv/ts-json-base';
 import { FileTreeHelpers } from '../../packlets/helpers';
 import {
   createMockFile,
@@ -30,6 +31,39 @@ import {
   verifyFileAPI
 } from '../utils/testHelpers';
 
+// ---- Minimal mock fetch helpers for createFromHttp tests ----
+
+interface IHttpMockResponse {
+  ok: boolean;
+  status?: number;
+  jsonValue?: unknown;
+  textValue?: string;
+  throwOnJson?: boolean;
+}
+
+function makeMockHttpResponse(options: IHttpMockResponse): Response {
+  const { ok, status = ok ? 200 : 400, jsonValue, textValue, throwOnJson } = options;
+  return {
+    ok,
+    status,
+    json: throwOnJson
+      ? () => Promise.reject(new Error('JSON parse error'))
+      : () => Promise.resolve(jsonValue),
+    text: () => Promise.resolve(textValue ?? `HTTP ${status}`)
+  } as unknown as Response;
+}
+
+function makeMockHttpFetch(responses: IHttpMockResponse[]): typeof fetch {
+  let callIndex = 0;
+  return (url: string | URL | Request, _init?: RequestInit): Promise<Response> => {
+    const response = responses[callIndex++];
+    if (response === undefined) {
+      return Promise.reject(new Error(`Unexpected fetch call to ${url.toString()}`));
+    }
+    return Promise.resolve(makeMockHttpResponse(response));
+  };
+}
+
 describe('FileApiTreeAccessors', () => {
   describe('Static factory methods', () => {
     describe('create', () => {
@@ -1315,4 +1349,39 @@ describe('FileApiTreeAccessors', () => {
       });
     });
   });
+
+  describe('createFromHttp', () => {
+    test('succeeds and returns a FileTree when HTTP backend loads successfully', async () => {
+      const fetchImpl = makeMockHttpFetch([
+        {
+          ok: true,
+          jsonValue: { path: '/', children: [{ path: '/data.json', name: 'data.json', type: 'file' }] }
+        },
+        { ok: true, jsonValue: { path: '/data.json', contents: '{"items":{}}' } }
+      ]);
+
+      const result = await FileApiTreeAccessors.createFromHttp({
+        baseUrl: 'http://localhost:3000',
+        fetchImpl,
+        mutable: true
+      });
+
+      expect(result).toSucceedAndSatisfy((tree) => {
+        expect(tree).toBeInstanceOf(FileTree.FileTree);
+        expect(tree.getFile('/data.json')).toSucceed();
+        expect(FileTree.isPersistentAccessors(tree.hal)).toBe(true);
+      });
+    });
+
+    test('fails when the HTTP backend returns an error during initial load', async () => {
+      const fetchImpl = makeMockHttpFetch([{ ok: false, status: 503, textValue: 'Service Unavailable' }]);
+
+      const result = await FileApiTreeAccessors.createFromHttp({
+        baseUrl: 'http://localhost:3000',
+        fetchImpl
+      });
+
+      expect(result).toFailWith(/service unavailable/i);
+    });
+  });
 });

package/src/test/unit/fileApiTypes.test.ts

@@ -279,6 +279,18 @@ describe('File API Types', () => {
 
       await expect(safeShowOpenFilePicker(mockWindow)).rejects.toThrow('User cancelled file picker');
     });
+
+    test('returns null when user cancels (AbortError)', async () => {
+      const abortError = new DOMException('The user aborted a request.', 'AbortError');
+      const mockWindow = {
+        showOpenFilePicker: jest.fn().mockRejectedValue(abortError),
+        showSaveFilePicker: jest.fn(),
+        showDirectoryPicker: jest.fn()
+      } as unknown as WindowWithFsAccess;
+
+      const result = await safeShowOpenFilePicker(mockWindow);
+      expect(result).toBeNull();
+    });
   });
 
   describe('safeShowSaveFilePicker', () => {
@@ -357,6 +369,18 @@ describe('File API Types', () => {
 
       await expect(safeShowSaveFilePicker(mockWindow)).rejects.toThrow('Save operation failed');
     });
+
+    test('returns null when user cancels (AbortError)', async () => {
+      const abortError = new DOMException('The user aborted a request.', 'AbortError');
+      const mockWindow = {
+        showOpenFilePicker: jest.fn(),
+        showSaveFilePicker: jest.fn().mockRejectedValue(abortError),
+        showDirectoryPicker: jest.fn()
+      } as unknown as WindowWithFsAccess;
+
+      const result = await safeShowSaveFilePicker(mockWindow);
+      expect(result).toBeNull();
+    });
   });
 
   describe('safeShowDirectoryPicker', () => {
@@ -441,6 +465,18 @@ describe('File API Types', () => {
 
       await expect(safeShowDirectoryPicker(mockWindow)).rejects.toThrow('Directory access denied');
     });
+
+    test('returns null when user cancels (AbortError)', async () => {
+      const abortError = new DOMException('The user aborted a request.', 'AbortError');
+      const mockWindow = {
+        showOpenFilePicker: jest.fn(),
+        showSaveFilePicker: jest.fn(),
+        showDirectoryPicker: jest.fn().mockRejectedValue(abortError)
+      } as unknown as WindowWithFsAccess;
+
+      const result = await safeShowDirectoryPicker(mockWindow);
+      expect(result).toBeNull();
+    });
   });
 
   describe('integration tests', () => {