@fgv/ts-res 5.0.1-0 → 5.0.1-2

package/dist/ts-res.d.ts

@@ -10,6 +10,7 @@ import { IReadOnlyResultMap } from '@fgv/ts-utils';
 import { JsonCompatible } from '@fgv/ts-json-base';
 import { JsonObject } from '@fgv/ts-json-base';
 import { JsonValue } from '@fgv/ts-json-base';
+import { Logging } from '@fgv/ts-utils';
 import { ObjectConverter } from '@fgv/ts-utils';
 import { Result } from '@fgv/ts-utils';
 import { ResultMap } from '@fgv/ts-utils';
@@ -995,6 +996,10 @@ declare class CompiledResourceCollection implements IResourceManager<IResource>
      * contains the {@link Qualifiers.Qualifier | qualifiers} used in this collection.
      */
     get qualifiers(): IReadOnlyQualifierCollector;
+    /**
+     * The resource IDs contained in this compiled resource collection.
+     */
+    get resourceIds(): ReadonlyArray<ResourceId>;
     /**
      * A {@link ResourceTypes.ResourceTypeCollector | ResourceTypeCollector} which
      * contains the {@link ResourceTypes.ResourceType | resource types} used in this collection.
@@ -2552,6 +2557,150 @@ declare const DefaultResourceTypes: ReadonlyArray<ResourceTypes.Config.IResource
  */
 declare const DefaultSystemConfiguration: ISystemConfiguration;
 
+/**
+ * Class for generating resource deltas between baseline and delta resolvers.
+ * Creates partial/augment candidates for updated resources and full/replace candidates for new resources.
+ * Uses Diff.jsonThreeWayDiff for efficient delta computation.
+ * @public
+ */
+declare class DeltaGenerator {
+    /**
+     * The baseline resource resolver to compare against.
+     * @internal
+     */
+    private readonly _baselineResolver;
+    /**
+     * The delta resource resolver containing changes.
+     * @internal
+     */
+    private readonly _deltaResolver;
+    /**
+     * The resource manager to clone and update.
+     * @internal
+     */
+    private readonly _resourceManager;
+    /**
+     * Logger for status and error reporting.
+     * @internal
+     */
+    private readonly _logger;
+    /**
+     * Constructor for a {@link Resources.DeltaGenerator | DeltaGenerator} object.
+     * @param params - Parameters to create a new {@link Resources.DeltaGenerator | DeltaGenerator}.
+     * @internal
+     */
+    protected constructor(params: IDeltaGeneratorParams);
+    /**
+     * Creates a new {@link Resources.DeltaGenerator | DeltaGenerator} object.
+     * @param params - Parameters to create a new {@link Resources.DeltaGenerator | DeltaGenerator}.
+     * @returns `Success` with the new {@link Resources.DeltaGenerator | DeltaGenerator} object if successful,
+     * or `Failure` with an error message if not.
+     * @public
+     */
+    static create(params: IDeltaGeneratorParams): Result<DeltaGenerator>;
+    /**
+     * Generates deltas between baseline and delta resolvers.
+     * Creates a cloned resource manager with partial/augment candidates for updates
+     * and full/replace candidates for new resources.
+     *
+     * @param options - Options controlling delta generation behavior.
+     * @returns `Success` with the updated resource manager if successful,
+     * or `Failure` with an error message if not.
+     * @public
+     */
+    generate(options?: IDeltaGeneratorOptions): Result<ResourceManagerBuilder>;
+    /**
+     * Validates the provided context declaration.
+     * @param context - The context declaration to validate.
+     * @returns `Success` with the validated context if successful, `Failure` otherwise.
+     * @internal
+     */
+    private _validateContext;
+    /**
+     * Enumerates target resource IDs for delta generation.
+     * If specific resource IDs are provided, uses those. Otherwise, discovers all resources
+     * from both the baseline resource manager and the delta resolver to ensure comprehensive
+     * coverage of all potential resources.
+     *
+     * @param requestedIds - Optional array of specific resource IDs to target.
+     * @param context - The validated context to use for resource discovery.
+     * @returns `Success` with array of resource IDs if successful, `Failure` otherwise.
+     * @internal
+     */
+    private _enumerateTargetResources;
+    /**
+     * Discovers all unique resource IDs from both baseline and delta resolvers.
+     * Creates a union of resource IDs from the baseline resource manager and delta resolver
+     * to ensure comprehensive coverage of all resources.
+     *
+     * @returns `Success` with array of unique resource IDs if successful, `Failure` otherwise.
+     * @internal
+     */
+    private _discoverAllResourceIds;
+    /**
+     * Creates a clone of the resource manager for delta operations.
+     * @returns `Success` with the cloned resource manager if successful, `Failure` otherwise.
+     * @internal
+     */
+    private _cloneResourceManager;
+    /**
+     * Generates deltas for the specified resources and adds them to the cloned manager.
+     *
+     * @param clonedManager - The cloned resource manager to update.
+     * @param resourceIds - Array of resource IDs to process.
+     * @param context - The context to use for resource resolution.
+     * @param skipUnchanged - Whether to skip resources that haven't changed.
+     * @returns `Success` with the updated manager if successful, `Failure` otherwise.
+     * @internal
+     */
+    private _generateDeltas;
+    /**
+     * Generates a delta for a single resource and adds appropriate candidates to the manager.
+     *
+     * @param manager - The resource manager to update.
+     * @param resourceId - The resource ID to process.
+     * @param context - The context to use for resource resolution.
+     * @param skipUnchanged - Whether to skip resources that haven't changed.
+     * @returns `Success` with the resource delta result if successful, `Failure` otherwise.
+     * @internal
+     */
+    private _generateResourceDelta;
+    /**
+     * Checks if two JSON values are identical.
+     * @param value1 - First value to compare.
+     * @param value2 - Second value to compare.
+     * @returns True if values are identical, false otherwise.
+     * @internal
+     */
+    private _areValuesIdentical;
+    /**
+     * Creates a new resource candidate for a newly discovered resource.
+     * Uses full/replace merge method since this is a completely new resource.
+     *
+     * @param manager - The resource manager to update.
+     * @param resourceId - The resource ID for the new resource.
+     * @param value - The resolved value for the new resource.
+     * @param context - The context used for resolution.
+     * @returns `Success` if the candidate was added successfully, `Failure` otherwise.
+     * @internal
+     */
+    private _createNewResourceCandidate;
+    /**
+     * Creates a delta candidate for an updated resource.
+     * Computes the difference between baseline and delta values and creates
+     * a partial/augment candidate with only the changed properties.
+     *
+     * @param manager - The resource manager to update.
+     * @param resourceId - The resource ID for the updated resource.
+     * @param baselineValue - The baseline resolved value.
+     * @param deltaValue - The delta resolved value.
+     * @param context - The context used for resolution.
+     * @returns `Success` if the candidate was added successfully, `Failure` otherwise.
+     * @internal
+     */
+    private _createDeltaCandidate;
+}
+
 /**
  * Type for handling empty branch nodes during tree composition.
  * The handler receives the branch node, names of failed children, and the resolver for recovery attempts.
@@ -2727,7 +2876,7 @@ declare function getDirectoryName(path: string): string;
 /**
  * Gets the name for a resource ID.
  * @param id - The resource ID to get the name for.
- * @returns The resource name if found, or undefined if not.
+ * @returns `Success` with the resource name if found, or `Failure` with an error message if not.
  * @public
  */
 declare function getNameForResourceId(id: string | undefined): Result<ResourceName>;
@@ -3813,6 +3962,49 @@ declare interface IDeclarationOptions {
     normalized?: boolean;
 }
 
+/**
+ * Interface for options controlling delta generation behavior.
+ * @public
+ */
+declare interface IDeltaGeneratorOptions {
+    /**
+     * Context to use when resolving resources. If not provided, uses empty context.
+     */
+    context?: Context.IContextDecl;
+    /**
+     * Array of specific resource IDs to include in delta generation.
+     * If not provided, generates deltas for all resources in the delta resolver.
+     */
+    resourceIds?: ReadonlyArray<string>;
+    /**
+     * Whether to skip resources that haven't changed. Default: true.
+     */
+    skipUnchanged?: boolean;
+}
+
+/**
+ * Interface for parameters to create a {@link Resources.DeltaGenerator | DeltaGenerator}.
+ * @public
+ */
+declare interface IDeltaGeneratorParams {
+    /**
+     * The baseline resource resolver to compare against.
+     */
+    baselineResolver: IResourceResolver;
+    /**
+     * The delta resource resolver containing changes.
+     */
+    deltaResolver: IResourceResolver;
+    /**
+     * The resource manager to clone and update.
+     */
+    resourceManager: ResourceManagerBuilder;
+    /**
+     * Optional logger for status and error reporting.
+     */
+    logger?: Logging.ILogger;
+}
+
 /**
  * @internal
  */
@@ -5266,6 +5458,10 @@ export declare interface IResourceManager<TR extends IResource = IResource> {
      * The number of resources in this resource manager.
      */
     readonly numResources: number;
+    /**
+     * The resource IDs that this resource manager can resolve.
+     */
+    readonly resourceIds: ReadonlyArray<ResourceId>;
     /**
      * The number of candidates in this resource manager.
      */
@@ -5317,6 +5513,10 @@ declare interface IResourceManagerCloneOptions extends IResourceDeclarationOptio
  * @public
  */
 export declare interface IResourceResolver {
+    /**
+     * The resource IDs that this resolver can resolve.
+     */
+    readonly resourceIds: ReadonlyArray<ResourceId>;
     /**
      * Resolves a resource to a composed value by merging matching candidates according to their merge methods.
      * Starting from the highest priority candidates, finds the first "full" candidate and merges all higher
@@ -8457,6 +8657,10 @@ export declare class ResourceManagerBuilder implements IResourceManager<Resource
      * the {@link Resources.ResourceCandidate | resource candidates} in this manager.
      */
     get conditions(): ReadOnlyConditionCollector;
+    /**
+     * The resource IDs that this resource manager can resolve.
+     */
+    get resourceIds(): ReadonlyArray<ResourceId>;
     /**
      * A {@link Conditions.ConditionSetCollector | ConditionSetCollector} which
      * contains the {@link Conditions.ConditionSet | condition sets} used so far by
@@ -8805,6 +9009,10 @@ export declare class ResourceResolver implements IResourceResolver {
      * The readonly qualifier collector that provides qualifier implementations.
      */
     get qualifiers(): IReadOnlyQualifierCollector;
+    /**
+     * The resource IDs that this resolver can resolve.
+     */
+    get resourceIds(): ReadonlyArray<ResourceId>;
     /**
      * The cache array for resolved conditions, indexed by condition index for O(1) lookup.
      * Each entry stores the resolved {@link Runtime.IConditionMatchResult | condition match result} for
@@ -9032,6 +9240,9 @@ declare namespace Resources {
         CandidateValue,
         ICandidateValueCollectorCreateParams,
         CandidateValueCollector,
+        IDeltaGeneratorParams,
+        IDeltaGeneratorOptions,
+        DeltaGenerator,
         IResourceCandidateCreateParams,
         ICandidateDeclOptions,
         ResourceCandidate,

package/lib/packlets/common/helpers/resources.d.ts

@@ -34,7 +34,7 @@ export declare function joinOptionalResourceIds(...ids: (string | undefined)[]):
 /**
  * Gets the name for a resource ID.
  * @param id - The resource ID to get the name for.
- * @returns The resource name if found, or undefined if not.
+ * @returns `Success` with the resource name if found, or `Failure` with an error message if not.
  * @public
  */
 export declare function getNameForResourceId(id: string | undefined): Result<ResourceName>;

package/lib/packlets/common/helpers/resources.js

@@ -87,12 +87,13 @@ function joinOptionalResourceIds(...ids) {
 /**
  * Gets the name for a resource ID.
  * @param id - The resource ID to get the name for.
- * @returns The resource name if found, or undefined if not.
+ * @returns `Success` with the resource name if found, or `Failure` with an error message if not.
  * @public
  */
 function getNameForResourceId(id) {
     return splitResourceId(id).onSuccess((parts) => {
-        return parts.length > 0 ? (0, ts_utils_1.succeed)(parts[parts.length - 1]) : fail('Empty id has no name');
+        /* c8 ignore next 1 - tested but coverage having issues */
+        return parts.length > 0 ? (0, ts_utils_1.succeed)(parts[parts.length - 1]) : fail(`${id}: invalid resource id`);
     });
 }
 //# sourceMappingURL=resources.js.map

package/lib/packlets/common/resources.d.ts

@@ -66,6 +66,10 @@ export type CandidateValueKey = Brand<string, 'CandidateValueKey'>;
  * @public
  */
 export interface IResourceResolver {
+    /**
+     * The resource IDs that this resolver can resolve.
+     */
+    readonly resourceIds: ReadonlyArray<ResourceId>;
     /**
      * Resolves a resource to a composed value by merging matching candidates according to their merge methods.
      * Starting from the highest priority candidates, finds the first "full" candidate and merges all higher

package/lib/packlets/common/validate/conditions.js

@@ -316,7 +316,7 @@ function toQualifierTypeIndex(index) {
 function toQualifierMatchScore(value) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidQualifierMatchScore(value)) {
-        return (0, ts_utils_1.fail)(`${value}: not a valid match score`);
+        return (0, ts_utils_1.fail)(`${value}: invalid match score`);
     }
     return (0, ts_utils_1.succeed)(value);
 }
@@ -330,7 +330,7 @@ function toQualifierMatchScore(value) {
 function toConditionPriority(priority) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidConditionPriority(priority)) {
-        return (0, ts_utils_1.fail)(`${priority}: not a valid priority`);
+        return (0, ts_utils_1.fail)(`${priority}: invalid priority`);
     }
     return (0, ts_utils_1.succeed)(priority);
 }
@@ -344,7 +344,7 @@ function toConditionPriority(priority) {
 function toConditionIndex(index) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidConditionIndex(index)) {
-        return (0, ts_utils_1.fail)(`${index}: not a valid condition index`);
+        return (0, ts_utils_1.fail)(`${index}: invalid condition index`);
     }
     return (0, ts_utils_1.succeed)(index);
 }
@@ -357,7 +357,7 @@ function toConditionIndex(index) {
  */
 function toConditionOperator(operator) {
     if (!isValidConditionOperator(operator)) {
-        return (0, ts_utils_1.fail)(`${operator}: not a valid condition operator`);
+        return (0, ts_utils_1.fail)(`${operator}: invalid condition operator`);
     }
     return (0, ts_utils_1.succeed)(operator);
 }
@@ -371,7 +371,7 @@ function toConditionOperator(operator) {
 function toConditionKey(key) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidConditionKey(key)) {
-        return (0, ts_utils_1.fail)(`${key}: not a valid condition key`);
+        return (0, ts_utils_1.fail)(`${key}: invalid condition key`);
     }
     return (0, ts_utils_1.succeed)(key);
 }
@@ -385,7 +385,7 @@ function toConditionKey(key) {
 function toConditionToken(token) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidConditionToken(token)) {
-        return (0, ts_utils_1.fail)(`${token}: not a valid condition token`);
+        return (0, ts_utils_1.fail)(`${token}: invalid condition token`);
     }
     return (0, ts_utils_1.succeed)(token);
 }
@@ -399,7 +399,7 @@ function toConditionToken(token) {
 function toConditionSetIndex(index) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidConditionSetIndex(index)) {
-        return (0, ts_utils_1.fail)(`${index}: not a valid condition set index`);
+        return (0, ts_utils_1.fail)(`${index}: invalid condition set index`);
     }
     return (0, ts_utils_1.succeed)(index);
 }
@@ -413,7 +413,7 @@ function toConditionSetIndex(index) {
 function toConditionSetKey(key) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidConditionSetKey(key)) {
-        return (0, ts_utils_1.fail)(`${key}: not a valid condition set key`);
+        return (0, ts_utils_1.fail)(`${key}: invalid condition set key`);
     }
     return (0, ts_utils_1.succeed)(key);
 }
@@ -427,7 +427,7 @@ function toConditionSetKey(key) {
 function toConditionSetToken(token) {
     /* c8 ignore next 3 - functional code path tested but coverage intermittently missed */
     if (!isValidConditionSetToken(token)) {
-        return (0, ts_utils_1.fail)(`${token}: not a valid condition set token`);
+        return (0, ts_utils_1.fail)(`${token}: invalid condition set token`);
     }
     return (0, ts_utils_1.succeed)(token);
 }
@@ -440,7 +440,7 @@ function toConditionSetToken(token) {
  */
 function toConditionSetHash(hash) {
     if (!isValidConditionSetHash(hash)) {
-        return (0, ts_utils_1.fail)(`${hash}: not a valid condition set hash`);
+        return (0, ts_utils_1.fail)(`${hash}: invalid condition set hash`);
     }
     return (0, ts_utils_1.succeed)(hash);
 }
@@ -454,7 +454,7 @@ function toConditionSetHash(hash) {
 function toDecisionKey(key) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidDecisionKey(key)) {
-        return (0, ts_utils_1.fail)(`${key}: not a valid decision key`);
+        return (0, ts_utils_1.fail)(`${key}: invalid decision key`);
     }
     return (0, ts_utils_1.succeed)(key);
 }
@@ -468,7 +468,7 @@ function toDecisionKey(key) {
 function toDecisionIndex(index) {
     /* c8 ignore next 3 - coverage is having a bad day */
     if (!isValidDecisionIndex(index)) {
-        return (0, ts_utils_1.fail)(`${index}: not a valid decision index`);
+        return (0, ts_utils_1.fail)(`${index}: invalid decision index`);
     }
     return (0, ts_utils_1.succeed)(index);
 }
@@ -513,7 +513,7 @@ function isValidContextToken(token) {
 function toContextQualifierToken(token) {
     /* c8 ignore next 3 - functional code path tested but coverage intermittently missed */
     if (!isValidContextQualifierToken(token)) {
-        return (0, ts_utils_1.fail)(`${token}: not a valid context qualifier token`);
+        return (0, ts_utils_1.fail)(`${token}: invalid context qualifier token`);
     }
     return (0, ts_utils_1.succeed)(token);
 }
@@ -527,7 +527,7 @@ function toContextQualifierToken(token) {
 function toContextToken(token) {
     /* c8 ignore next 3 - functional code path tested but coverage intermittently missed */
     if (!isValidContextToken(token)) {
-        return (0, ts_utils_1.fail)(`${token}: not a valid context token`);
+        return (0, ts_utils_1.fail)(`${token}: invalid context token`);
     }
     return (0, ts_utils_1.succeed)(token);
 }

package/lib/packlets/common/validate/resources.js

@@ -119,7 +119,7 @@ function isValidCandidateValueKey(key) {
 function toResourceName(name) {
     /* c8 ignore next 3 - coverage having issues */
     if (!isValidResourceName(name)) {
-        return (0, ts_utils_1.fail)(`${name}: not a valid resource name.`);
+        return (0, ts_utils_1.fail)(`${name}: invalid resource name.`);
     }
     return (0, ts_utils_1.succeed)(name);
 }
@@ -134,7 +134,7 @@ function toResourceName(name) {
 function toResourceId(id) {
     /* c8 ignore next 3 - defensive coding: resource ID validation should prevent invalid IDs */
     if (!isValidResourceId(id)) {
-        return (0, ts_utils_1.fail)(`${id}: not a valid resource ID.`);
+        return (0, ts_utils_1.fail)(`${id}: invalid resource ID.`);
     }
     return (0, ts_utils_1.succeed)(id);
 }
@@ -159,7 +159,7 @@ function toOptionalResourceId(id) {
  */
 function toResourceIndex(index) {
     if (!isValidResourceIndex(index)) {
-        return (0, ts_utils_1.fail)(`${index}: not a valid resource index.`);
+        return (0, ts_utils_1.fail)(`${index}: invalid resource index.`);
     }
     return (0, ts_utils_1.succeed)(index);
 }
@@ -174,7 +174,7 @@ function toResourceIndex(index) {
 function toResourceTypeName(name) {
     /* c8 ignore next 3 - coverage having issues */
     if (!isValidResourceTypeName(name)) {
-        return (0, ts_utils_1.fail)(`${name}: not a valid resource type name.`);
+        return (0, ts_utils_1.fail)(`${name}: invalid resource type name.`);
     }
     return (0, ts_utils_1.succeed)(name);
 }
@@ -189,7 +189,7 @@ function toResourceTypeName(name) {
 function toResourceTypeIndex(index) {
     /* c8 ignore next 3 - coverage having issues */
     if (!isValidResourceTypeIndex(index)) {
-        return (0, ts_utils_1.fail)(`${index}: not a valid resource type index.`);
+        return (0, ts_utils_1.fail)(`${index}: invalid resource type index.`);
     }
     return (0, ts_utils_1.succeed)(index);
 }
@@ -204,7 +204,7 @@ function toResourceTypeIndex(index) {
 function toCandidateValueKey(key) {
     /* c8 ignore next 3 - coverage having issues */
     if (!isValidCandidateValueKey(key)) {
-        return (0, ts_utils_1.fail)(`${key}: not a valid candidate value key.`);
+        return (0, ts_utils_1.fail)(`${key}: invalid candidate value key.`);
     }
     return (0, ts_utils_1.succeed)(key);
 }
@@ -219,7 +219,7 @@ function toCandidateValueKey(key) {
 function toCandidateValueIndex(index) {
     /* c8 ignore next 3 - coverage having issues */
     if (!isValidCandidateValueIndex(index)) {
-        return (0, ts_utils_1.fail)(`${index}: not a valid candidate value index.`);
+        return (0, ts_utils_1.fail)(`${index}: invalid candidate value index.`);
     }
     return (0, ts_utils_1.succeed)(index);
 }

package/lib/packlets/conditions/conditionSet.js

@@ -185,9 +185,9 @@ class ConditionSet {
             const conditions = Object.entries(conditionSet).map(([qualifierName, value]) => {
                 if (typeof value === 'string') {
                     return { qualifierName, value };
+                    /* c8 ignore next 3 - edge case */
                 }
                 else {
-                    /* c8 ignore next 1 - edge case: object spread pattern rarely used */
                     return Object.assign({ qualifierName }, value);
                 }
             });

package/lib/packlets/config/common.js

@@ -76,6 +76,7 @@ function getPredefinedDeclaration(name, initParams) {
         }
         return baseConfig;
     }
+    /* c8 ignore next 3 - defense in depth */
     return (0, ts_utils_1.fail)(`Unknown predefined system configuration: ${name}`);
 }
 /**

package/lib/packlets/config/configInitFactory.js

@@ -123,6 +123,7 @@ class BuiltInQualifierTypeFactory {
         if (QualifierTypes.Config.isSystemQualifierTypeConfig(config)) {
             return QualifierTypes.createQualifierTypeFromSystemConfig(config);
         }
+        /* c8 ignore next 2 - functional code tested but coverage intermittently missed */
         return (0, ts_utils_1.fail)(`${config.name}: unknown built-in qualifier type (${config.systemType})`);
     }
 }

package/lib/packlets/config/systemConfiguration.js

@@ -122,6 +122,7 @@ class SystemConfiguration {
      */
     static create(config, initParams) {
         if (initParams === null || initParams === void 0 ? void 0 : initParams.qualifierDefaultValues) {
+            /* c8 ignore next 9 - functional code tested but coverage intermittently missed */
             return updateSystemConfigurationQualifierDefaultValues(config, initParams.qualifierDefaultValues).onSuccess((updatedConfig) => (0, ts_utils_1.captureResult)(() => new SystemConfiguration(updatedConfig, (0, ts_utils_1.omit)(initParams, ['qualifierDefaultValues']))));
         }
         return (0, ts_utils_1.captureResult)(() => new SystemConfiguration(config, initParams));

package/lib/packlets/context/convert/decls.js

@@ -67,8 +67,8 @@ exports.validatedContextQualifierValueDecl = ts_utils_1.Converters.generic((from
  * @public
  */
 exports.validatedContextDecl = ts_utils_1.Converters.generic((from, __self, context) => {
+    /* c8 ignore next 3 - functional code path tested but coverage intermittently missed */
     if (!context) {
-        /* c8 ignore next 2 - functional code path tested but coverage intermittently missed */
         return ts_utils_1.Failure.with('validatedContextDecl converter requires a context');
     }
     return exports.contextDecl.convert(from).onSuccess((decl) => {

package/lib/packlets/import/importers/collectionImporter.js

@@ -91,7 +91,7 @@ class CollectionImporter {
         if (!(0, importable_1.isImportable)(item) || (item.type !== 'resourceCollection' && item.type !== 'resourceTree')) {
             /* c8 ignore next 1 - defense in depth */
             const name = (_b = (_a = item.context) === null || _a === void 0 ? void 0 : _a.baseId) !== null && _b !== void 0 ? _b : 'unknown';
-            return (0, ts_utils_1.failWithDetail)(`${name}: not a valid resource collection importable (${item.type})`, 'skipped');
+            return (0, ts_utils_1.failWithDetail)(`${name}: invalid resource collection importable (${item.type})`, 'skipped');
         }
         const container = item.type === 'resourceCollection' ? item.collection : item.tree;
         return importContext_1.ImportContext.forContainerImport(container.context, item.context)

package/lib/packlets/import/importers/jsonImporter.js

@@ -89,7 +89,7 @@ class JsonImporter {
         if (!(0, importable_1.isImportable)(item) || item.type !== 'json') {
             /* c8 ignore next 3 - functional code path tested but coverage intermittently missed */
             const name = (_b = (_a = item.context) === null || _a === void 0 ? void 0 : _a.baseId) !== null && _b !== void 0 ? _b : 'unknown';
-            return (0, ts_utils_1.failWithDetail)(`${name}: not a valid JSON importable (${item.type})`, 'skipped');
+            return (0, ts_utils_1.failWithDetail)(`${name}: invalid JSON importable (${item.type})`, 'skipped');
         }
         return (this._tryImportResourceCollection(item)
             .onFailure(() => this._tryImportResourceTree(item))

package/lib/packlets/qualifier-types/helpers.js

@@ -88,9 +88,9 @@ function createQualifierTypeFromConfig(typeConfig) {
             return Config.Convert.literalQualifierTypeConfig
                 .convert(childConfig)
                 .onSuccess((configuration) => literalQualifierType_1.LiteralQualifierType.createFromConfig(Object.assign(Object.assign({}, typeConfig), { configuration })));
-        default:
-            return (0, ts_utils_1.fail)(`Unknown qualifier type: ${typeConfig.systemType}`);
     }
+    /* c8 ignore next 1 - defense in depth */
+    return (0, ts_utils_1.fail)(`Unknown qualifier type: ${typeConfig.systemType}`);
 }
 /**
  * Creates a {@link QualifierTypes.SystemQualifierType | SystemQualifierType} from a system configuration object.
@@ -111,8 +111,9 @@ function createQualifierTypeFromSystemConfig(typeConfig) {
             return territoryQualifierType_1.TerritoryQualifierType.createFromConfig(typeConfig);
         case 'literal':
             return literalQualifierType_1.LiteralQualifierType.createFromConfig(typeConfig);
-        default:
-            return (0, ts_utils_1.fail)(`${systemType}: Unknown system qualifier type.`);
     }
+    /* c8 ignore next 3 - should not happen */
+    // @ts-expect-error
+    return (0, ts_utils_1.fail)(`${systemType}: Unknown system qualifier type.`);
 }
 //# sourceMappingURL=helpers.js.map

package/lib/packlets/qualifier-types/literalQualifierType.js

@@ -230,7 +230,7 @@ class LiteralQualifierType extends qualifierType_1.QualifierType {
     static toLiteralConditionValue(from) {
         return LiteralQualifierType.isValidLiteralConditionValue(from)
             ? (0, ts_utils_1.succeed)(from)
-            : (0, ts_utils_1.fail)(`${from}: not a valid literal condition value.`);
+            : (0, ts_utils_1.fail)(`${from}: invalid literal condition value.`);
     }
 }
 exports.LiteralQualifierType = LiteralQualifierType;

package/lib/packlets/qualifier-types/literalValueHierarchy.js

@@ -102,7 +102,7 @@ class LiteralValueHierarchy {
         if (ancestors.isSuccess()) {
             return ancestors.value.includes(possibleAncestor);
         }
-        /* c8 ignore next 1 - edge case: ancestor validation fallback */
+        /* c8 ignore next 2 - edge case: ancestor validation fallback */
         return false;
     }
     /**
@@ -133,11 +133,11 @@ class LiteralValueHierarchy {
         // For open hierarchies, skip validation and allow any values
         if (!this.isOpenValues) {
             // Validate that both condition and context exist in the hierarchy
-            /* c8 ignore next 2 - functional error case tested but coverage intermittently missed */
+            /* c8 ignore next 3 - functional error case tested but coverage intermittently missed */
             if (!this.values.has(condition)) {
                 return common_1.NoMatch;
             }
-            /* c8 ignore next 2 - functional error case tested but coverage intermittently missed */
+            /* c8 ignore next 3 - functional error case tested but coverage intermittently missed */
             if (!this.values.has(context)) {
                 return common_1.NoMatch;
             }
@@ -168,6 +168,7 @@ class LiteralValueHierarchy {
         var _a;
         const errors = new ts_utils_1.MessageAggregator();
         const values = params.values;
+        /* c8 ignore next 1 - defense in depth */
         const hierarchy = (_a = params.hierarchy) !== null && _a !== void 0 ? _a : {};
         // If no values are provided, collect all values from the hierarchy
         let allValues;
@@ -191,7 +192,7 @@ class LiteralValueHierarchy {
                 }
                 const parent = valueMap.get(parentName);
                 if (!parent) {
-                    errors.addMessage(`${valueName}: parent ${parentName} is not a valid literal value.`);
+                    errors.addMessage(`${valueName}: parent ${parentName} is invalid literal value.`);
                     continue;
                 }
                 let ancestor = parent.parent;
@@ -202,14 +203,14 @@ class LiteralValueHierarchy {
                     ancestors.push(ancestor.name);
                     /* c8 ignore next 1 - defensive coding: ancestor.parent === value is very difficult to reach */
                     if (ancestor.parent === parent || ancestor.parent === value) {
-                        /* c8 ignore next 3 - defensive coding: circular reference error reporting intermittently missed */
+                        /* c8 ignore next 4 - defensive coding: circular reference error reporting intermittently missed */
                         errors.addMessage(`${valueName}: Circular reference detected: ${ancestors.join('->')}`);
                         circular = true;
                         break;
                     }
                     ancestor = ancestor.parent;
                 }
-                /* c8 ignore next 2 - defensive coding: circular reference handling intermittently missed */
+                /* c8 ignore next 3 - defensive coding: circular reference handling intermittently missed */
                 if (circular) {
                     continue;
                 }