@fgv/ts-agent-memory 5.1.0-39 → 5.1.0-41

package/lib/test/unit/ingest/orchestrator.test.js

@@ -91,10 +91,32 @@ function candidate(kind, entityId, body, opts = {}) {
         body
     };
 }
+/**
+ * A scope-qualified target, authored as `scope#id` or a bare id defaulting to the
+ * knowledge scope (where the note/num fixtures live). `kt` is the assertion-side
+ * spelling of the same helper.
+ */
+function scopedTarget(spec) {
+    const hash = spec.indexOf('#');
+    const scope = hash >= 0 ? spec.slice(0, hash) : 'knowledge';
+    const id = hash >= 0 ? spec.slice(hash + 1) : spec;
+    return { scope: scope, id: id };
+}
+function kt(id, scope = 'knowledge') {
+    return { scope: scope, id: id };
+}
+/** The scope-qualified reference of a candidate about to be written, by its entityId. */
+function srcOf(ctx, entityId) {
+    const found = ctx.candidates.find((rc) => rc.candidate.envelope.entityId === entityId);
+    if (found === undefined) {
+        throw new Error(`test relater: no candidate with entityId '${entityId}'`);
+    }
+    return found.id;
+}
 function candEdge(source, type, target, confidence) {
     return {
-        source: source,
-        edge: Object.assign({ type: type, target: target }, (confidence !== undefined ? { confidence } : {}))
+        source: scopedTarget(source),
+        edge: Object.assign({ type: type, target: scopedTarget(target) }, (confidence !== undefined ? { confidence } : {}))
     };
 }
 function buildStore(params = {}) {
@@ -165,7 +187,10 @@ describe('MemoryIngestOrchestrator', () => {
         test('classifies, extracts, and writes one record end-to-end with host-ingest provenance + derivedFrom', async () => {
             const store = buildStore();
             const orch = buildOrchestrator({ store });
-            const sourceId = 'turn-3';
+            const sourceId = {
+                scope: 'conversations/c1',
+                id: 'turn-3'
+            };
             const result = await orch.ingestItem({ id: 'doc-1', content: 'the sky is blue', sourceId });
             expect(result).toSucceedAndSatisfy((r) => {
                 var _a, _b, _c;
@@ -176,7 +201,7 @@ describe('MemoryIngestOrchestrator', () => {
                 expect(rec.resolution.verdict).toBe('new');
                 expect(rec.id).toBe('doc-1');
                 expect((_a = rec.record) === null || _a === void 0 ? void 0 : _a.envelope.provenance.source).toBe(index_1.HOST_INGEST_PROVENANCE_SOURCE);
-                expect((_b = rec.record) === null || _b === void 0 ? void 0 : _b.envelope.provenance.derivedFrom).toBe('turn-3');
+                expect((_b = rec.record) === null || _b === void 0 ? void 0 : _b.envelope.provenance.derivedFrom).toEqual(sourceId);
                 expect((_c = rec.record) === null || _c === void 0 ? void 0 : _c.body).toBe('the sky is blue');
                 expect(rec.interlock).toBeUndefined();
             });
@@ -251,6 +276,25 @@ describe('MemoryIngestOrchestrator', () => {
             });
             expect(await orch.ingestItem({ id: 'o-1', content: 'x' })).toFailWith(/no identity codec/);
         });
+        test('fails loudly when a pre-existing snapshot record cannot be scoped (no codec for its kind)', async () => {
+            // The store can persist a note (it has the note codec), but the orchestrator
+            // below is wired WITHOUT a note codec — so when it snapshots the store to run
+            // the edge path, it cannot resolve the seeded note's scope and fails loudly
+            // (never silently drops it from the cycle graph). This is the branch the
+            // scope-qualified edge change added.
+            const store = buildStore();
+            await putNote(store, 'legacy', 'anchor');
+            const orch = index_1.MemoryIngestOrchestrator.create({
+                store,
+                registry: registry(),
+                // Deliberately omit the note codec (and any default) that the seeded record needs.
+                codecs: new Map([[numKind, new index_1.KnowledgeIdentityCodec()]]),
+                classifier: classifier(() => (0, ts_utils_1.succeed)({ kind: numKind })),
+                extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(numKind, 'n-1', 7)])),
+                relationExtractor: noEdges
+            }).orThrow();
+            expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/cannot resolve scope for stored record 'legacy'.*no identity codec registered for kind 'note'/i);
+        });
     });
     describe('stage 4 — exact dedup (layer 1)', () => {
         test('an exact {kind,body} match in scope is duplicate-of (no resolver)', async () => {
@@ -261,7 +305,7 @@ describe('MemoryIngestOrchestrator', () => {
             });
             expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
                 expect(r.records[0].disposition).toBe('deduped');
-                expect(r.records[0].resolution).toEqual({ verdict: 'duplicate-of', target: 'doc-a' });
+                expect(r.records[0].resolution).toEqual({ verdict: 'duplicate-of', target: kt('doc-a') });
                 expect(r.records[0].id).toBe('doc-a');
             });
             // doc-b was never written.
@@ -318,13 +362,17 @@ async function putNote(store, id, body) {
     (await store.put(rec)).orThrow();
 }
 function mockStore(overrides) {
-    var _a, _b, _c, _d, _e;
+    var _a, _b, _c, _d, _e, _f, _g;
     return {
         get: (_a = overrides.get) !== null && _a !== void 0 ? _a : (() => Promise.resolve((0, ts_utils_1.succeed)(undefined))),
         getById: (_b = overrides.getById) !== null && _b !== void 0 ? _b : (() => Promise.resolve((0, ts_utils_1.succeed)(undefined))),
         list: (_c = overrides.list) !== null && _c !== void 0 ? _c : (() => Promise.resolve((0, ts_utils_1.succeed)([]))),
-        put: (_d = overrides.put) !== null && _d !== void 0 ? _d : ((r) => Promise.resolve((0, ts_utils_1.succeed)(r))),
-        delete: (_e = overrides.delete) !== null && _e !== void 0 ? _e : (() => Promise.resolve((0, ts_utils_1.fail)('n/a')))
+        listScoped: (_d = overrides.listScoped) !== null && _d !== void 0 ? _d : (() => Promise.resolve((0, ts_utils_1.succeed)([]))),
+        asRecordSource: (_e = overrides.asRecordSource) !== null && _e !== void 0 ? _e : (() => ({
+            list: () => Promise.resolve((0, ts_utils_1.succeed)([]))
+        })),
+        put: (_f = overrides.put) !== null && _f !== void 0 ? _f : ((r) => Promise.resolve((0, ts_utils_1.succeed)(r))),
+        delete: (_g = overrides.delete) !== null && _g !== void 0 ? _g : (() => Promise.resolve((0, ts_utils_1.fail)('n/a')))
     };
 }
 describe('MemoryIngestOrchestrator — stage 4 similarity (layer 2)', () => {
@@ -352,7 +400,7 @@ describe('MemoryIngestOrchestrator — stage 4 similarity (layer 2)', () => {
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'duplicate-of', target: similar[0].id })),
+            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'duplicate-of', target: similar[0].target })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'apple tart')]))
         });
         expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
@@ -369,12 +417,12 @@ describe('MemoryIngestOrchestrator — stage 4 similarity (layer 2)', () => {
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'supersede', target: similar[0].id })),
+            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'supersede', target: similar[0].target })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'apple tart')]))
         });
         expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
             expect(r.records[0].disposition).toBe('written');
-            expect(r.records[0].resolution).toEqual({ verdict: 'supersede', target: 'doc-a' });
+            expect(r.records[0].resolution).toEqual({ verdict: 'supersede', target: kt('doc-a') });
             expect(r.records[0].id).toBe('doc-b');
         });
         expect(await store.get(noteKind, 'doc-b')).toSucceedAndSatisfy((rec) => expect(rec === null || rec === void 0 ? void 0 : rec.body).toBe('apple tart'));
@@ -387,7 +435,7 @@ describe('MemoryIngestOrchestrator — stage 4 similarity (layer 2)', () => {
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: similar[0].id })),
+            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: similar[0].target })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'apple tart')]))
         });
         expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
@@ -406,10 +454,10 @@ describe('MemoryIngestOrchestrator — stage 4 similarity (layer 2)', () => {
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver(() => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: 'ghost' })),
+            entityResolver: resolver(() => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: kt('ghost') })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'apple tart')]))
         });
-        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/merge-into target 'ghost' does not exist/);
+        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/merge-into target 'knowledge\/ghost' does not exist/);
     });
     test('a below-threshold neighbor is not surfaced (resolver not called)', async () => {
         const vectorIndex = index_1.InMemoryCosineIndex.create().orThrow();
@@ -446,9 +494,9 @@ describe('MemoryIngestOrchestrator — stage 4 similarity (layer 2)', () => {
     });
     test('a surfaced hit with no backing record is skipped', async () => {
         const ghostIndex = {
-            add: (id) => Promise.resolve((0, ts_utils_1.succeed)(id)),
-            remove: (id) => Promise.resolve((0, ts_utils_1.succeed)(id)),
-            query: () => Promise.resolve((0, ts_utils_1.succeed)([{ id: 'ghost', score: 0.99 }]))
+            add: (t) => Promise.resolve((0, ts_utils_1.succeed)(t.id)),
+            remove: (t) => Promise.resolve((0, ts_utils_1.succeed)(t)),
+            query: () => Promise.resolve((0, ts_utils_1.succeed)([{ target: kt('ghost'), score: 0.99 }]))
         };
         const orch = buildOrchestrator({
             store: buildStore(),
@@ -474,8 +522,8 @@ describe('MemoryIngestOrchestrator — stage 4 similarity (layer 2)', () => {
     });
     test('a similarity-query failure surfaces loudly', async () => {
         const failingIndex = {
-            add: (id) => Promise.resolve((0, ts_utils_1.succeed)(id)),
-            remove: (id) => Promise.resolve((0, ts_utils_1.succeed)(id)),
+            add: (t) => Promise.resolve((0, ts_utils_1.succeed)(t.id)),
+            remove: (t) => Promise.resolve((0, ts_utils_1.succeed)(t)),
             query: () => Promise.resolve((0, ts_utils_1.fail)('query kaput'))
         };
         const orch = buildOrchestrator({
@@ -547,7 +595,7 @@ describe('MemoryIngestOrchestrator — stage 5 relate + cycle guard', () => {
             var _a;
             expect(r.records[0].edges).toHaveLength(1);
             expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([
-                { type: 'mentions', target: 'doc-a', confidence: 0.7 }
+                { type: 'mentions', target: kt('doc-a'), confidence: 0.7 }
             ]);
         });
     });
@@ -560,7 +608,7 @@ describe('MemoryIngestOrchestrator — stage 5 relate + cycle guard', () => {
         expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
             var _a;
             expect(r.records).toHaveLength(2);
-            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: 'rel', target: 'doc-c' }]);
+            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: 'rel', target: kt('doc-c') }]);
             expect(r.records[1].edges).toEqual([]);
         });
     });
@@ -570,7 +618,7 @@ describe('MemoryIngestOrchestrator — stage 5 relate + cycle guard', () => {
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'x')])),
             relationExtractor: relater(() => (0, ts_utils_1.succeed)([candEdge('ghost', 'rel', 'doc-b')]))
         });
-        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/edge source 'ghost' is not a candidate being written/);
+        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/edge source 'knowledge\/ghost' is not a candidate being written/);
     });
     test('rejects an edge whose target resolves to nothing', async () => {
         const orch = buildOrchestrator({
@@ -578,7 +626,7 @@ describe('MemoryIngestOrchestrator — stage 5 relate + cycle guard', () => {
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'x')])),
             relationExtractor: relater(() => (0, ts_utils_1.succeed)([candEdge('doc-b', 'rel', 'ghost')]))
         });
-        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/edge target 'ghost' resolves to neither/);
+        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/edge target 'knowledge\/ghost' resolves to neither/);
     });
     test('rejects a cycle-inducing edge (default guard)', async () => {
         const orch = buildOrchestrator({
@@ -597,8 +645,8 @@ describe('MemoryIngestOrchestrator — stage 5 relate + cycle guard', () => {
         });
         expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
             var _a, _b;
-            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: 'rel', target: 'doc-c' }]);
-            expect((_b = r.records[1].record) === null || _b === void 0 ? void 0 : _b.envelope.links).toEqual([{ type: 'rel', target: 'doc-b' }]);
+            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: 'rel', target: kt('doc-c') }]);
+            expect((_b = r.records[1].record) === null || _b === void 0 ? void 0 : _b.envelope.links).toEqual([{ type: 'rel', target: kt('doc-b') }]);
         });
     });
     test('a contradicts edge on a NON-temporal kind persists as a plain link (no interlock)', async () => {
@@ -612,7 +660,89 @@ describe('MemoryIngestOrchestrator — stage 5 relate + cycle guard', () => {
         expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
             var _a;
             expect(r.records[0].interlock).toBeUndefined();
-            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: 'contradicts', target: 'doc-a' }]);
+            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: 'contradicts', target: kt('doc-a') }]);
+        });
+    });
+    describe('_validateEdges cross-scope target disambiguation', () => {
+        // Two EXISTING records share the idStem 'turn-3' across two conversations
+        // (the MTM codec mints per-scope stems). A stage-5 edge target must resolve
+        // to the CORRECT (scope, id) — with bare-id keying both would alias and a
+        // wrong-scope target would silently validate. Guards the ingest-validation seam.
+        const mtmKind = 'mtm';
+        function mtmRegistry() {
+            const reg = registry();
+            reg.register(mtmKind, ts_utils_1.Converters.string);
+            return reg;
+        }
+        const mtmCodecs = new Map([
+            [mtmKind, new index_1.MtmIdentityCodec()]
+        ]);
+        async function seedTurn(store, entityId, body) {
+            const addr = new index_1.MtmIdentityCodec().encode(entityId).orThrow();
+            const rec = {
+                envelope: {
+                    id: addr.idStem,
+                    entityId: entityId,
+                    kind: mtmKind,
+                    tags: [],
+                    links: [],
+                    created: 0,
+                    updated: 0,
+                    seq: 0,
+                    contentHash: '',
+                    provenance: { source: 'agent' }
+                },
+                body
+            };
+            (await store.put(rec)).orThrow();
+        }
+        function buildMtmOrchestrator(store, relationExtractor) {
+            return index_1.MemoryIngestOrchestrator.create({
+                store,
+                registry: mtmRegistry(),
+                codecs: mtmCodecs,
+                classifier: classifier(() => (0, ts_utils_1.succeed)({ kind: mtmKind })),
+                // The candidate is a fresh turn-5 under conv-a (distinct stem from the seeds).
+                extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(mtmKind, 'conv-a:5', 'a new turn')])),
+                relationExtractor
+            }).orThrow();
+        }
+        async function seededStore() {
+            const store = index_1.FileTreeMemoryStore.create({
+                root: mutableRoot(),
+                registry: mtmRegistry(),
+                codecs: mtmCodecs,
+                clock
+            }).orThrow();
+            await seedTurn(store, 'conv-a:3', 'anchor in conversation a');
+            await seedTurn(store, 'conv-b:3', 'anchor in conversation b');
+            return store;
+        }
+        test('accepts a same-stem edge target that resolves to the correct scope', async () => {
+            const store = await seededStore();
+            const orch = buildMtmOrchestrator(store, relater((ctx) => (0, ts_utils_1.succeed)([
+                {
+                    source: srcOf(ctx, 'conv-a:5'),
+                    edge: { type: 'rel', target: kt('turn-3', 'conversations/conv-a') }
+                }
+            ])));
+            expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
+                var _a;
+                expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([
+                    { type: 'rel', target: kt('turn-3', 'conversations/conv-a') }
+                ]);
+            });
+        });
+        test('rejects a same-stem edge target whose scope has no matching record', async () => {
+            const store = await seededStore();
+            const orch = buildMtmOrchestrator(store, relater((ctx) => (0, ts_utils_1.succeed)([
+                {
+                    source: srcOf(ctx, 'conv-a:5'),
+                    // turn-3 exists under conv-a and conv-b, but NOT conv-z.
+                    edge: { type: 'rel', target: kt('turn-3', 'conversations/conv-z') }
+                }
+            ])));
+            expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/edge target 'conversations\/conv-z\/turn-3' resolves to neither a sibling candidate nor an existing record/);
         });
     });
 });
@@ -633,13 +763,20 @@ describe('MemoryIngestOrchestrator — contradicts→temporal interlock', () =>
             store,
             classifier: classifyFact,
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(factKind, 'fact-1', 'the sky is grey')])),
-            relationExtractor: relater(() => (0, ts_utils_1.succeed)([candEdge('fact-1', 'contradicts', v1Id)]))
+            relationExtractor: relater((ctx) => (0, ts_utils_1.succeed)([
+                {
+                    source: srcOf(ctx, 'fact-1'),
+                    edge: { type: index_1.CONTRADICTS_LINK_TYPE, target: kt(v1Id, 'facts/entities/fact-1') }
+                }
+            ]))
         });
         expect(await secondOrch.ingestItem({ id: 'fact-1', content: 'the sky is grey' })).toSucceedAndSatisfy((r) => {
             var _a;
             expect(r.records[0].interlock).toBe('temporal-versioned');
             expect(r.records[0].disposition).toBe('written');
-            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: index_1.CONTRADICTS_LINK_TYPE, target: v1Id }]);
+            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([
+                { type: index_1.CONTRADICTS_LINK_TYPE, target: kt(v1Id, 'facts/entities/fact-1') }
+            ]);
         });
         // The current version is the new (contradicting) one.
         expect(await store.get(factKind, 'fact-1')).toSucceedAndSatisfy((rec) => expect(rec === null || rec === void 0 ? void 0 : rec.body).toBe('the sky is grey'));
@@ -661,7 +798,12 @@ describe('MemoryIngestOrchestrator — contradicts→temporal interlock', () =>
             store,
             classifier: classifyFact,
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(factKind, 'fact-1', 'grey')])),
-            relationExtractor: relater(() => (0, ts_utils_1.succeed)([candEdge('fact-1', 'contradicts', v1Id)]))
+            relationExtractor: relater((ctx) => (0, ts_utils_1.succeed)([
+                {
+                    source: srcOf(ctx, 'fact-1'),
+                    edge: { type: index_1.CONTRADICTS_LINK_TYPE, target: kt(v1Id, 'facts/entities/fact-1') }
+                }
+            ]))
         });
         (await o2.ingestItem({ id: 'fact-1', content: 'grey' })).orThrow();
         // Re-introduce the ORIGINAL body: the invalidated v1 must be skipped by exact
@@ -792,7 +934,7 @@ describe('MemoryIngestOrchestrator — review-punch-list fixes', () => {
         });
         expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceedAndSatisfy((r) => {
             var _a;
-            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: 'rel', target: 'doc-a' }]);
+            expect((_a = r.records[0].record) === null || _a === void 0 ? void 0 : _a.envelope.links).toEqual([{ type: 'rel', target: kt('doc-a') }]);
         });
     });
     test('two candidates merging into the same target do not duplicate a shared edge', async () => {
@@ -804,13 +946,13 @@ describe('MemoryIngestOrchestrator — review-punch-list fixes', () => {
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: similar[0].id })),
+            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: similar[0].target })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'apple tart'), candidate(noteKind, 'doc-c', 'apple tart')])),
             relationExtractor: relater(() => (0, ts_utils_1.succeed)([candEdge('doc-a', 'rel', 'doc-x')]))
         });
         expect(await orch.ingestItem({ id: 'i', content: 'x' })).toSucceed();
         expect(await store.get(noteKind, 'doc-a')).toSucceedAndSatisfy((rec) => {
-            expect(rec === null || rec === void 0 ? void 0 : rec.envelope.links).toEqual([{ type: 'rel', target: 'doc-x' }]);
+            expect(rec === null || rec === void 0 ? void 0 : rec.envelope.links).toEqual([{ type: 'rel', target: kt('doc-x') }]);
         });
     });
 });
@@ -840,18 +982,18 @@ describe('MemoryIngestOrchestrator — merge-into safety (second review)', () =>
         const store = buildStore({ vectorIndex, embed });
         await putFull(store, noteKind, 'doc-a', 'apple pie', {
             tags: ['old-tag'],
-            links: [{ type: 'existing', target: 'doc-z' }]
+            links: [{ type: 'existing', target: kt('doc-z') }]
         });
         await putFull(store, noteKind, 'doc-x', 'target of stage-5');
         const orch = buildOrchestrator({
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: similar[0].id })),
+            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: similar[0].target })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([
                 candidate(noteKind, 'doc-b', 'apple tart', {
                     tags: ['new-tag'],
-                    links: [{ type: 'candlink', target: 'doc-z' }]
+                    links: [{ type: 'candlink', target: kt('doc-z') }]
                 })
             ])),
             relationExtractor: relater(() => (0, ts_utils_1.succeed)([candEdge('doc-a', 'stage5', 'doc-x')]))
@@ -865,9 +1007,9 @@ describe('MemoryIngestOrchestrator — merge-into safety (second review)', () =>
             expect([...((_a = rec === null || rec === void 0 ? void 0 : rec.envelope.tags) !== null && _a !== void 0 ? _a : [])].sort()).toEqual(['new-tag', 'old-tag']);
             // Original link + candidate link + stage-5 edge, each exactly once.
             expect(rec === null || rec === void 0 ? void 0 : rec.envelope.links).toEqual([
-                { type: 'existing', target: 'doc-z' },
-                { type: 'candlink', target: 'doc-z' },
-                { type: 'stage5', target: 'doc-x' }
+                { type: 'existing', target: kt('doc-z') },
+                { type: 'candlink', target: kt('doc-z') },
+                { type: 'stage5', target: kt('doc-x') }
             ]);
         });
     });
@@ -880,10 +1022,10 @@ describe('MemoryIngestOrchestrator — merge-into safety (second review)', () =>
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: similar[0].id })),
+            entityResolver: resolver((__c, similar) => (0, ts_utils_1.succeed)({ verdict: 'merge-into', target: similar[0].target })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'apple tart')]))
         });
-        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/merge-into target 'conv-1' is kind 'ltm' but the candidate is kind 'note'/);
+        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/merge-into target 'conversations\/conv-1' is kind 'ltm' but the candidate is kind 'note'/);
     });
     test('supersede with a non-existent target fails loudly', async () => {
         const vectorIndex = index_1.InMemoryCosineIndex.create().orThrow();
@@ -893,10 +1035,10 @@ describe('MemoryIngestOrchestrator — merge-into safety (second review)', () =>
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver(() => (0, ts_utils_1.succeed)({ verdict: 'supersede', target: 'ghost' })),
+            entityResolver: resolver(() => (0, ts_utils_1.succeed)({ verdict: 'supersede', target: kt('ghost') })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'apple tart')]))
         });
-        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/supersede target 'ghost' does not exist/);
+        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/supersede target 'knowledge\/ghost' does not exist/);
     });
     test('duplicate-of with a non-existent target fails loudly', async () => {
         const vectorIndex = index_1.InMemoryCosineIndex.create().orThrow();
@@ -906,10 +1048,10 @@ describe('MemoryIngestOrchestrator — merge-into safety (second review)', () =>
             store,
             vectorIndex,
             embed,
-            entityResolver: resolver(() => (0, ts_utils_1.succeed)({ verdict: 'duplicate-of', target: 'ghost' })),
+            entityResolver: resolver(() => (0, ts_utils_1.succeed)({ verdict: 'duplicate-of', target: kt('ghost') })),
             extractor: extractor(() => (0, ts_utils_1.succeed)([candidate(noteKind, 'doc-b', 'apple tart')]))
         });
-        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/duplicate-of target 'ghost' does not exist/);
+        expect(await orch.ingestItem({ id: 'i', content: 'x' })).toFailWith(/duplicate-of target 'knowledge\/ghost' does not exist/);
     });
 });
 //# sourceMappingURL=orchestrator.test.js.map