@fffangchenghao/dsh-latex-look 0.3.4 → 0.3.5

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 0.3.5
+
+- **The tool reports facts, not advice.** When the point lookup finds a rule it now
+  says what it measured and stops: `ink at this point: horizontal rule at y=47pt,
+  76% of page width`, then either `drawn by line 15: \rule{...}` or `nearest source
+  line 40 contains no rule command ... the document body does not draw this rule`.
+  The previous wording told the reader to go and look at `\pagestyle` /
+  `\headrulewidth`; that is knowledge about typography, not an observation, and the
+  tool is the wrong place for it — it lives in `SKILL.md`, where the agent reads it
+  and decides.
+- The ink probe searches a ±4 pt band instead of one pixel row. Clicking a line is
+  routinely a point or two off, and a miss left the caller trusting the locate answer
+  this check exists to challenge. The finding reports the rule's own y, so a query
+  two points away still lands on the truth.
+
 ## 0.3.4
 
 - Fix the bundle patch for a scoped package name: `name: @scope/pkg` is not valid

package/SKILL.md

@@ -170,7 +170,7 @@ document is broken, suspect one of these:
 | Jumped to another page | `[htbp]` + `\FloatBarrier`; or `\usepackage{float}` + `[H]` |
 | Adding a caption pushed a near-full-page figure off the page, leaving half a page blank | the figure was already as tall as the text block, so a few millimetres of caption cannot fit above it. Wrapping it in `minipage` makes it unbreakable. Make that figure a float (`\begin{figure}[!tbp]`) so the text after it fills the page and the figure starts the next one |
 | Caption orphaned on the next page | wrap figure+caption in one `minipage` — a caption is not tied to its graphic by default |
-| "Delete the line at the top of the page" and `--point` returns `\end{document}` | the rule is page furniture, and `latex_look` now says so: `^ that is a rule ... NO line of the document draws it`. Look at `\pagestyle`, `\fancyhf`, `\headrulewidth` — never at line 40. When the rule *is* typed, the same line names it: `drawn by line 15: \rule{\linewidth}{0.4pt}` |
+| "Delete the line at the top of the page", and the point lookup reports `the document body does not draw this rule` | the rule comes from the page style. It is `\pagestyle{fancy}` / `\pagestyle{headings}` with the head rule still on, or a `\rule`/`\hrule` in a `\markboth`-style macro. Fix it with `\fancyhf{}` plus `\renewcommand{\headrulewidth}{0pt}`, or switch to `\pagestyle{plain}`. Do **not** edit the line the lookup named (`\end{document}`); it is only the nearest box. When the rule *is* typed in the body, the lookup names it instead: `drawn by line 15: \rule{\linewidth}{0.4pt}`, and that is the line to change |
 | A figure sits above the chapter title on a chapter's first page | a top float won the opening page. `\let\origchapter\chapter\renewcommand{\chapter}{\suppressfloats[t]\origchapter}` (no `@` in the name, or wrap it in `\makeatletter`) forbids top floats on every chapter opening, now and for chapters added later |
 | Numbers run backwards: 图 3-4 on one page, 图 3-3 on the next | you floated one object but left its numbered neighbours inline. A float is placed later than an inline object that follows it in the source, and the reader turns the page to see 3-4 before 3-3. Floats of the same class keep their relative order, so float the **whole run** — never a float mixed into inline siblings. Check with `latex_look --sequence 图` after any change to how objects are placed |
 | Too much space around it | `\setlength{\intextsep}{6pt}`, `\setlength{\textfloatsep}{10pt}` |

package/bin/latex-look.mjs

@@ -83,11 +83,16 @@ function summary(r) {
       const at = typeof h.x === 'number' && typeof h.y === 'number' ? ` x=${h.x.toFixed(1)} y=${h.y.toFixed(1)}` : ''
       L.push(`  ${h.file}:${h.line}  → p${h.page}${at}${fixed}`)
       if (h.ink && h.ink.kind === 'rule' && h.ink.origin === 'command' && h.ink.sourceLine) {
-        L.push(`      ^ that is a rule, not text: it is drawn by line ${h.ink.sourceLine.line}: ${h.ink.sourceLine.text}`)
+        L.push(`      ^ ink at this point: horizontal rule at y=${h.ink.y}pt, ${Math.round(h.ink.span * 100)}% of page width`)
+        L.push(`        drawn by line ${h.ink.sourceLine.line}: ${h.ink.sourceLine.text}`)
       } else if (h.ink && h.ink.kind === 'rule') {
-        L.push(`      ^ that is a rule spanning ${Math.round(h.ink.span * 100)}% of the page, and NO line of the document draws it.`)
-        L.push('        It is page furniture: \\pagestyle / \\fancyhf / \\headrulewidth, or a table/list rule')
-        L.push('        from a package. The line above is only the nearest box, not the cause.')
+        // Facts only. What to do about it is the reader's knowledge, not this tool's,
+        // and a hint here would be wrong on any document that does not match the guess.
+        L.push(`      ^ ink at this point: horizontal rule at y=${h.ink.y}pt, ${Math.round(h.ink.span * 100)}% of page width`)
+        L.push(`        nearest source line ${h.line} contains no rule command, and neither does any line within 4 of it`)
+        L.push('        the document body does not draw this rule')
+      } else if (h.ink && h.ink.kind === 'blank') {
+        L.push('      ^ ink at this point: none (blank paper; the nearest box belongs to a different spot)')
       }
     }
   }

package/index.js

@@ -128,11 +128,16 @@ function format(r) {
           : ''
       L.push(`  ${h.file}:${h.line} → page ${h.page}${y}${fixed}`)
       if (h.ink && h.ink.kind === 'rule' && h.ink.origin === 'command' && h.ink.sourceLine) {
-        L.push(`      ^ that is a rule, not text: it is drawn by line ${h.ink.sourceLine.line}: ${h.ink.sourceLine.text}`)
+        L.push(`      ^ ink at this point: horizontal rule at y=${h.ink.y}pt, ${Math.round(h.ink.span * 100)}% of page width`)
+        L.push(`        drawn by line ${h.ink.sourceLine.line}: ${h.ink.sourceLine.text}`)
       } else if (h.ink && h.ink.kind === 'rule') {
-        L.push(`      ^ that is a rule spanning ${Math.round(h.ink.span * 100)}% of the page, and NO line of the document draws it.`)
-        L.push('        It is page furniture: \\pagestyle / \\fancyhf / \\headrulewidth, or a table/list rule from a package.')
-        L.push('        The line above is only the nearest box, not the cause.')
+        // Facts only: what to do about a rule is the reader's knowledge, not the
+        // tool's. A hint here would be wrong on any document that does not match it.
+        L.push(`      ^ ink at this point: horizontal rule at y=${h.ink.y}pt, ${Math.round(h.ink.span * 100)}% of page width`)
+        L.push(`        nearest source line ${h.line} contains no rule command, and neither does any line within 4 of it`)
+        L.push('        the document body does not draw this rule')
+      } else if (h.ink && h.ink.kind === 'blank') {
+        L.push('      ^ ink at this point: none (blank paper; the nearest box belongs to a different spot)')
       }
     }
   }

package/lib/core.mjs

@@ -824,27 +824,34 @@ export function classifyInk(raster, { x, y, dpi = 72 } = {}) {
     const o = (yy * raster.width + xx) * 3
     return raster.data[o] < 200 && raster.data[o + 1] < 200 && raster.data[o + 2] < 200
   }
-  let bestSpan = 0
-  let bestRow = py
-  for (let yy = Math.max(0, py - 1); yy <= Math.min(raster.height - 1, py + 1); yy++) {
+  const rowInk = (yy) => {
     let count = 0
     for (let xx = 0; xx < raster.width; xx++) if (at(xx, yy)) count++
-    if (count > bestSpan) { bestSpan = count; bestRow = yy }
+    return count / raster.width
+  }
+  // Look for a rule in a band around the point, not on one exact row: a reader who
+  // clicks a line is routinely a point or two away, and a miss here would leave the
+  // caller trusting a locate answer this check exists to challenge.
+  const bandPt = 4
+  const band = Math.max(1, Math.round((bandPt / 72) * dpi))
+  let best = { span: 0, row: py }
+  for (let yy = Math.max(0, py - band); yy <= Math.min(raster.height - 1, py + band); yy++) {
+    const span = rowInk(yy)
+    if (span > best.span) best = { span, row: yy }
+  }
+  let thin = true
+  for (const yy of [best.row - 3, best.row + 3]) {
+    if (yy < 0 || yy >= raster.height) continue
+    if (rowInk(yy) > 0.3) { thin = false; break }
+  }
+  if (best.span > 0.35 && thin) {
+    return { kind: 'rule', span: Number(best.span.toFixed(2)), y: Number(((best.row / dpi) * 72).toFixed(1)) }
   }
-  const span = bestSpan / raster.width
   let near = 0
   for (let yy = Math.max(0, py - 4); yy <= Math.min(raster.height - 1, py + 4); yy++) {
     for (let xx = Math.max(0, px - 4); xx <= Math.min(raster.width - 1, px + 4); xx++) if (at(xx, yy)) near++
   }
-  let thin = true
-  for (const yy of [bestRow - 3, bestRow + 3]) {
-    if (yy < 0 || yy >= raster.height) continue
-    let count = 0
-    for (let xx = 0; xx < raster.width; xx++) if (at(xx, yy)) count++
-    if (count / raster.width > 0.3) { thin = false; break }
-  }
-  const kind = span > 0.35 && thin ? 'rule' : near > 0 ? 'text' : 'blank'
-  return { kind, span: Number(span.toFixed(2)) }
+  return { kind: near > 0 ? 'text' : 'blank' }
 }
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fffangchenghao/dsh-latex-look",
-  "version": "0.3.4",
+  "version": "0.3.5",
   "description": "DSH plugin: let an AI agent see a LaTeX document — compile it, render the page, locate the source line, and diff what an edit changed.",
   "type": "module",
   "license": "MIT",