@ferris1225/pi-subagents 4.3.14 → 4.3.15

package/CHANGELOG.md

@@ -3,6 +3,15 @@
 Release notes for `@ferris1225/pi-subagents`. Only the most recent releases
 are kept here; every published version is preserved as a GitHub Release.
 
+## 4.3.15
+
+- Fix the cost footer's stale-context crash after reload, new session, resume,
+  or fork. Remove the module-global event context cache and render against
+  the installed footer's own live session context. Existing shutdown cleanup
+  removes the footer and its subscriptions before that context is invalidated.
+- Cover replacement-session rendering with Pi's real context invalidation,
+  subscription cleanup, and live model/thinking/context/session-name updates.
+
 ## 4.3.13
 
 - Remove the `subagents N running · …` activity-count line from the footer.

package/README.md

@@ -12,6 +12,10 @@ once and your main agent delegates on its own.
 
 ## What's new
 
+**4.3.15** — fix the cost footer crash after `/reload`, `/new`, `/resume`, or
+`/fork`: each footer now reads only its own session's live context, never an
+event context retained from the previous session.
+
 **4.3.13** — the footer is reserved for the per-model cost tally: the
 `subagents N running` activity-count line is gone, leaving the widget,
 completion notifications, and `subagent_status` for live progress.
@@ -389,7 +393,9 @@ under width pressure a settled row drops its token flow before truncating, so
 children report their own usage per run when they settle, and pi would
 otherwise attribute it to one session total — exactly the cross-model merge
 this footer exists to avoid. The ledger reseeds from the session file on
-reload, so the tally survives restarts.
+reload or session replacement. The footer is removed at session shutdown and
+reinstalled with the new session's live context, so switching or reloading
+never reuses a stale context from the previous session.
 
 Completions resume the main agent on their own, with a compact block of at most 40
 lines by default; longer output lands unchanged in a Markdown artifact whose path

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ferris1225/pi-subagents",
-  "version": "4.3.14",
+  "version": "4.3.15",
   "description": "A managed sub-agent team for pi: scout, artisan, steward, and sentinel roles, one-shot runs, read-only status, and Git worktree isolation.",
   "type": "module",
   "license": "MIT",

package/src/presentation/cost-footer.ts

@@ -14,7 +14,7 @@ import type { ExtensionContext, Theme } from "@earendil-works/pi-coding-agent";
 import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { isAbsolute, relative, resolve, sep } from "node:path";
 import { stripVTControlCharacters } from "node:util";
-import { costLedger, latestTrackedContext, type ModelSpendRow } from "./cost-ledger.ts";
+import { costLedger, type ModelSpendRow } from "./cost-ledger.ts";
 import { formatTokens, formatUsageTokens } from "./monitor.ts";
 import type { UsageStats } from "../execution/rpc-control.ts";
 
@@ -26,8 +26,7 @@ interface FooterData {
 	onBranchChange(callback: () => void): () => void;
 }
 
-/** Context pieces the footer renders against; falls back to the latest event
- * context so a fresh install still sees live session state. */
+/** Live context owned by the installed footer's session. */
 type RenderContext = Partial<Pick<ExtensionContext, "sessionManager" | "getContextUsage" | "model" | "thinkingLevel">>;
 
 /** Minimum gap between the stats left side and the right-aligned model. */
@@ -135,8 +134,7 @@ export function renderCostFooter(
 	footerData: FooterData | undefined,
 	ctx: RenderContext,
 ): string[] {
-	const live = latestTrackedContext() ?? ctx;
-	const sessionManager = live.sessionManager ?? ctx.sessionManager;
+	const sessionManager = ctx.sessionManager;
 	const lines: string[] = [];
 
 	let project = formatProjectPath(sessionManager?.getCwd() ?? "", process.env.HOME || process.env.USERPROFILE);
@@ -149,7 +147,7 @@ export function renderCostFooter(
 	const rows = costLedger.snapshot();
 	if (rows.length > 0) {
 		const current = rows.find((row) => row.current);
-		if (current) lines.push(currentModelLine(current, theme, width, live));
+		if (current) lines.push(currentModelLine(current, theme, width, ctx));
 		const settled = rows
 			.filter((row) => !row.current)
 			.sort((left, right) => right.spend.cost - left.spend.cost);
@@ -176,7 +174,8 @@ export function renderCostFooter(
 /**
  * Replace pi's built-in footer with the per-model cost footer. The factory
  * re-renders on ledger updates and git branch changes; context, model, and
- * thinking state come from the freshest event context available.
+ * thinking state use Pi's live getters for this session. Shutdown clears the
+ * footer before Pi invalidates its context.
  */
 export function installCostFooter(ctx: Pick<ExtensionContext, "mode" | "ui"> & RenderContext): void {
 	if (ctx.mode !== "tui") return;

package/src/presentation/cost-ledger.ts

@@ -9,7 +9,7 @@
  * each model keeps its own tally — plus its live token throughput.
  */
 
-import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { modelRef } from "../configuration/models.ts";
 
 export interface ModelSpend {
@@ -198,28 +198,18 @@ export class CostLedger {
 
 export const costLedger = new CostLedger();
 
-/** Latest event context, so the footer renders against live session state
- * (context usage, cwd, session name) without holding a stale install-time ctx. */
-let latestContext: ExtensionContext | undefined;
-
 /** Wire the main window's own generation into the ledger: assistant messages
  * carry the serving model and exact usage, model switches re-key the current
  * row, and compaction calls land on the model that made them. */
 export function registerMainCostTracking(pi: ExtensionAPI): void {
-	const remember = (ctx: ExtensionContext): void => {
-		latestContext = ctx;
-	};
-
-	pi.on("message_start", async (event, ctx) => {
-		remember(ctx);
+	pi.on("message_start", async (event) => {
 		const message = (event as { message?: { role?: string } }).message;
 		if (message?.role !== "assistant") return;
 		const ref = messageModelRef(message as { provider?: string; model?: string });
 		if (ref) costLedger.noteStreamStart(ref);
 	});
 
-	pi.on("message_update", async (event, ctx) => {
-		remember(ctx);
+	pi.on("message_update", async (event) => {
 		const delta = (event as { assistantMessageEvent?: { type?: string; delta?: string } }).assistantMessageEvent;
 		if (delta?.type !== "text_delta" && delta?.type !== "thinking_delta") return;
 		// `message_start` does not always carry the model yet; the first delta
@@ -234,8 +224,7 @@ export function registerMainCostTracking(pi: ExtensionAPI): void {
 		costLedger.noteStreamDelta(delta.delta?.length ?? 0);
 	});
 
-	pi.on("message_end", async (event, ctx) => {
-		remember(ctx);
+	pi.on("message_end", async (event) => {
 		const message = (event as { message?: { role?: string; provider?: string; model?: string; usage?: UsageLike } }).message;
 		if (message?.role !== "assistant") return;
 		const ref = messageModelRef(message) ?? costLedger.getCurrentModel();
@@ -245,15 +234,13 @@ export function registerMainCostTracking(pi: ExtensionAPI): void {
 		costLedger.record(ref, usage);
 	});
 
-	pi.on("model_select", async (event, ctx) => {
-		remember(ctx);
+	pi.on("model_select", async (event) => {
 		costLedger.markCurrentModel(modelRef(event.model));
 	});
 
 	pi.on("session_compact", async (event, ctx) => {
-		remember(ctx);
 		const usage = (event as { compactionEntry?: { usage?: UsageLike } }).compactionEntry?.usage;
-		const ref = costLedger.getCurrentModel() ?? (latestContext?.model ? modelRef(latestContext.model) : undefined);
+		const ref = costLedger.getCurrentModel() ?? (ctx.model ? modelRef(ctx.model) : undefined);
 		if (usage && ref) costLedger.record(ref, finiteUsage(usage));
 	});
 }
@@ -280,7 +267,3 @@ export function seedCostLedgerFromSession(ctx: {
 		}
 	}
 }
-
-export function latestTrackedContext(): ExtensionContext | undefined {
-	return latestContext;
-}