@ferris1225/pi-subagents 4.2.4 → 4.2.7

package/src/monitor.ts

@@ -242,7 +242,7 @@ export const RUN_LABEL_MAX = 32;
  * distinguishing fragment so concurrent same-agent runs are told apart by WHAT
  * they do, not just their run id. A file/directory path outranks other
  * fragment kinds (a kebab-case word like "edge-case" never beats
- * "tests/config.test.ts"); a long path keeps its tail (the filename is the
+ * "src/config.ts"); a long path keeps its tail (the filename is the
  * recognisable part); a task with no recognizable fragment falls back to a
  * head slice of its prose. Grapheme-safe.
  */

package/src/prompt.ts

@@ -1,69 +1,69 @@
-/**
- * Builds the delegation directive injected into the parent model's
- * system prompt via `before_agent_start`. It is paid on every turn, so it
- * stays a lean routing contract — when a child context pays for itself,
- * how wide to fan out, and how results come back. Tool metadata stays
- * intentionally minimal so role/process guidance is not paid for twice.
- */
-
-import type { AgentConfig } from "./agents.ts";
-import { formatCatalogEntry } from "./agents.ts";
-
-function bullets(lines: readonly string[]): string {
-	return lines.map((line) => `- ${line}`).join("\n");
-}
-
-export function buildDelegationDirective(
-	agents: AgentConfig[],
-): string {
-	if (agents.length === 0) return "";
-
-	const catalog = agents.map(formatCatalogEntry).join("\n");
-	const hasExplorer = agents.some((agent) => agent.name === "explorer");
-	const hasExecutor = agents.some((agent) => agent.name === "executor");
-
-	const dispatchRules = [
-		`Delegate aggressively: child contexts are cheap, yours is scarce. Inline only trivial work — a lookup, a single focused edit, an answer already in context${hasExecutor ? "; default every non-trivial delegated task (implementation, fix, refactor, test, cleanup, docs sync, result merging) to `executor`" : ""}.`,
-		"A single artifact you must fully absorb yourself (one issue, one spec) is inline work — delegation saves search, not that read.",
-		...(hasExplorer
-			? [
-				"`explorer`: split a broad question into parallel explorers with disjoint scopes. Its findings are leads, never proof — re-read the cited line ranges before acting on them (a child you brief re-verifies).",
-			]
-			: []),
-		...(hasExecutor
-			? [
-				"`executor`: brief it as the edit authorization. For cleanup, name the scope (uncommitted diff, Git range, directory) — every safe proven cut applies without per-item approval; finding no safe cut is a valid result. After a wide fan-out, pass the result-artifact paths to one executor and read its merged brief instead of every result yourself.",
-			]
-			: []),
-		"Parallelize by default: map the todo list onto ONE `tasks` dispatch. One child owns one deliverable and its files; only genuinely dependent work waits for its prerequisite.",
-		"Brief each child completely — goal, exact paths, constraints, expected output; it has no conversation memory and cannot delegate. Resume parked threads with `subagent_control resume`.",
-	];
-
-	const handoffRules = [
-		"Dispatch never blocks or ends your turn — keep working; each completion resumes you automatically. Never sleep or poll for it.",
-		"Results are already shown; add only your conclusion or next action, never a restatement.",
-		"Never declare the overall task done while a dispatched run is still active.",
-	];
-
-	const verificationRules = [
-		"Never report an unrun check as passed; surface unavailable checks and pre-existing failures, and inspect the actual diff before reporting completion.",
-		"Commit or push only when explicitly requested and applicable checks pass.",
-	];
-
-	return `
-## Sub-agent delegation (pi-subagents)
-
-\`subagent\` runs isolated leaf Pi child processes in the background.
-
-Agents:
-${catalog}
-
-Dispatch:
-${bullets(dispatchRules)}
-
-Result handoff:
-${bullets(handoffRules)}
-
-Verification:
-${bullets(verificationRules)}`;
-}
+/**
+ * Builds the delegation directive injected into the parent model's
+ * system prompt via `before_agent_start`. It is paid on every turn, so it
+ * stays a lean routing contract — when a child context pays for itself,
+ * how wide to fan out, and how results come back. Tool metadata stays
+ * intentionally minimal so role/process guidance is not paid for twice.
+ */
+
+import type { AgentConfig } from "./agents.ts";
+import { formatCatalogEntry } from "./agents.ts";
+
+function bullets(lines: readonly string[]): string {
+	return lines.map((line) => `- ${line}`).join("\n");
+}
+
+export function buildDelegationDirective(
+	agents: AgentConfig[],
+): string {
+	if (agents.length === 0) return "";
+
+	const catalog = agents.map(formatCatalogEntry).join("\n");
+	const hasExplorer = agents.some((agent) => agent.name === "explorer");
+	const hasExecutor = agents.some((agent) => agent.name === "executor");
+
+	const dispatchRules = [
+		`Delegate aggressively: child contexts are cheap, yours is scarce. A unit is delegable when it can proceed independently and return a compact result${hasExecutor ? "; when both hold, default it to `executor`" : ""}.`,
+		"Keep inline what fails either test — a lookup, a single focused edit, an answer already in context, or a single artifact you must absorb yourself (one issue, one spec), where delegation saves search, not that read. Cluster related questions into one brief instead of firing many small dispatches; a child loses context between runs.",
+		...(hasExplorer
+			? [
+				"`explorer`: split a broad question into parallel explorers with disjoint scopes. Its findings are leads, never proof — re-read the cited line ranges before acting on them (a child you brief re-verifies).",
+			]
+			: []),
+		...(hasExecutor
+			? [
+				"`executor`: brief it as the edit authorization. For cleanup, name the scope (uncommitted diff, Git range, directory) — every safe proven cut applies without per-item approval; finding no safe cut is a valid result. After a wide fan-out, pass the result-artifact paths to one executor and read its merged brief instead of every result yourself.",
+			]
+			: []),
+		"Parallelize by default: map the todo list onto ONE `tasks` dispatch. One child owns one deliverable and its files; only genuinely dependent work waits for its prerequisite.",
+		"Brief each child completely — goal, exact paths, constraints, expected output; it has no conversation memory and cannot delegate. Resume parked threads with `subagent_control resume`.",
+	];
+
+	const handoffRules = [
+		"Dispatch never blocks or ends your turn — keep working; each completion resumes you automatically. Never sleep or poll for it.",
+		"Results are already shown; add only your conclusion or next action, never a restatement.",
+		"Never declare the overall task done while a dispatched run is still active.",
+	];
+
+	const verificationRules = [
+		"Never report an unrun check as passed; surface unavailable checks and pre-existing failures, and inspect the actual diff before reporting completion.",
+		"Commit or push only when explicitly requested and applicable checks pass.",
+	];
+
+	return `
+## Sub-agent delegation (pi-subagents)
+
+\`subagent\` runs isolated leaf Pi child processes in the background.
+
+Agents:
+${catalog}
+
+Dispatch:
+${bullets(dispatchRules)}
+
+Result handoff:
+${bullets(handoffRules)}
+
+Verification:
+${bullets(verificationRules)}`;
+}

package/src/rpc-run.ts

@@ -8,7 +8,7 @@
  */
 
 import { spawn, type ChildProcess } from "node:child_process";
-import { existsSync, readdirSync, unlinkSync, rmdirSync } from "node:fs";
+import { existsSync, readdirSync } from "node:fs";
 import { mkdir, mkdtemp, rm, writeFile } from "node:fs/promises";
 import { basename, join } from "node:path";
 import { StringDecoder } from "node:string_decoder";
@@ -364,6 +364,11 @@ export async function writeChildRetryPolicyExtension(
 	}
 }
 
+/** Hand the agent body to the child as a file rather than inline argv text.
+ * `--append-system-prompt` takes either, but a system prompt is unbounded — a
+ * custom agent can carry a whole spec — while Windows caps a command line at
+ * 32767 characters, so inlining turns a long agent into an opaque spawn failure.
+ * The file lives in the run's scratch dir and is removed when the attempt ends. */
 async function writePromptToTempFile(
 	scratchRoot: string,
 	agentName: string,
@@ -974,20 +979,9 @@ export async function runRpcAgentAttempt(options: RunRpcAttemptOptions): Promise
 		return result;
 	} finally {
 		if (attemptToken !== undefined) control?.detach(attemptToken);
-		if (tmpPromptPath) {
-			try {
-				unlinkSync(tmpPromptPath);
-			} catch {
-				/* ignore */
-			}
-		}
-		if (tmpPromptDir) {
-			try {
-				rmdirSync(tmpPromptDir);
-			} catch {
-				/* ignore */
-			}
-		}
+		// Recursive removal: the directory also holds the temp-hygiene owner marker,
+		// so an empty-directory removal always fails and leaks one dir per dispatch.
+		if (tmpPromptDir) await rm(tmpPromptDir, { recursive: true, force: true }).catch(() => undefined);
 		await rm(retryPolicy.dir, { recursive: true, force: true }).catch(() => undefined);
 	}
 }