@ferris1225/pi-subagents 4.2.0 → 4.2.1

package/README.md

@@ -262,7 +262,11 @@ strength per agent. Everything else is config-file only, stored at
 The delegation directive is always injected; there is no toggle. Invalid values
 fall back safely, and stale keys — including the former `proactiveInjection`,
 `maxConcurrency`, `maxFixRounds`, and `notifyOnReviewPass` knobs — are dropped
-automatically. At session
+automatically. Built-in roles a newer package no longer ships (such as the
+retired `worker`/`cleaner`/`documenter`/`synthesizer`/`reviewer` set) are pruned
+from `enabledAgents`, `knownAgents`, and the model/thinking tables at first
+load, so the setup wizard never mixes old and new roles; custom agents are
+untouched. At session
 start, model overrides pi no longer reports are removed with a one-time notice. If
 pi's own session compaction fails mid-thread, a notice surfaces the error and the
 automatic retry instead of failing quietly.

package/package.json

@@ -1,55 +1,55 @@
-{
-  "name": "@ferris1225/pi-subagents",
-  "version": "4.2.0",
-  "description": "A managed sub-agent team for pi: specialized roles, pre-commit documentation sync, retained threads, auto-fix chains, model fallback, and Git worktree isolation.",
-  "type": "module",
-  "license": "MIT",
-  "publishConfig": {
-    "access": "public"
-  },
-  "keywords": [
-    "pi-package",
-    "pi-extension",
-    "subagent",
-    "sub-agent",
-    "delegation",
-    "code-cleanup",
-    "dead-code"
-  ],
-  "files": [
-    "src",
-    "agents",
-    "README.md",
-    "LICENSE"
-  ],
-  "pi": {
-    "extensions": [
-      "./src/index.ts"
-    ]
-  },
-  "scripts": {
-    "check": "tsc --noEmit",
-    "test": "vitest run tests",
-    "prepack": "npm run check && npm test"
-  },
-  "peerDependencies": {
-    "@earendil-works/pi-agent-core": ">=0.84.4",
-    "@earendil-works/pi-ai": ">=0.84.4",
-    "@earendil-works/pi-coding-agent": ">=0.84.4",
-    "@earendil-works/pi-tui": ">=0.84.4",
-    "typebox": "*"
-  },
-  "devDependencies": {
-    "@earendil-works/pi-agent-core": "^0.84.4",
-    "@earendil-works/pi-ai": "^0.84.4",
-    "@earendil-works/pi-coding-agent": "^0.84.4",
-    "@earendil-works/pi-tui": "^0.84.4",
-    "@types/node": "^22.10.0",
-    "typebox": "^1.3.9",
-    "typescript": "^5.9.0",
-    "vitest": "^4.1.0"
-  },
-  "engines": {
-    "node": ">=22.19.0"
-  }
-}
+{
+  "name": "@ferris1225/pi-subagents",
+  "version": "4.2.1",
+  "description": "A managed sub-agent team for pi: specialized roles, pre-commit documentation sync, retained threads, auto-fix chains, model fallback, and Git worktree isolation.",
+  "type": "module",
+  "license": "MIT",
+  "publishConfig": {
+    "access": "public"
+  },
+  "keywords": [
+    "pi-package",
+    "pi-extension",
+    "subagent",
+    "sub-agent",
+    "delegation",
+    "code-cleanup",
+    "dead-code"
+  ],
+  "files": [
+    "src",
+    "agents",
+    "README.md",
+    "LICENSE"
+  ],
+  "pi": {
+    "extensions": [
+      "./src/index.ts"
+    ]
+  },
+  "scripts": {
+    "check": "tsc --noEmit",
+    "test": "vitest run tests",
+    "prepack": "npm run check && npm test"
+  },
+  "peerDependencies": {
+    "@earendil-works/pi-agent-core": ">=0.84.4",
+    "@earendil-works/pi-ai": ">=0.84.4",
+    "@earendil-works/pi-coding-agent": ">=0.84.4",
+    "@earendil-works/pi-tui": ">=0.84.4",
+    "typebox": "*"
+  },
+  "devDependencies": {
+    "@earendil-works/pi-agent-core": "^0.84.4",
+    "@earendil-works/pi-ai": "^0.84.4",
+    "@earendil-works/pi-coding-agent": "^0.84.4",
+    "@earendil-works/pi-tui": "^0.84.4",
+    "@types/node": "^22.10.0",
+    "typebox": "^1.3.9",
+    "typescript": "^5.9.0",
+    "vitest": "^4.1.0"
+  },
+  "engines": {
+    "node": ">=22.19.0"
+  }
+}

package/src/config.ts

@@ -15,6 +15,13 @@ import { getAgentDir, withFileMutationQueue } from "@earendil-works/pi-coding-ag
 /** Full catalog of agents shipped with the package (selectable in /subagents-setup). */
 export const BUILTIN_AGENT_NAMES = ["explorer", "executor"] as const;
 
+/** Built-in agent names this package no longer ships. Loading an older config
+ * prunes them from every record so the setup wizard, dispatch catalog, and
+ * model-routing table never surface dead roles. Custom names stay untouched —
+ * except one that reuses a removed built-in name, which this cleanup cannot
+ * distinguish and deliberately treats as retired. */
+export const REMOVED_BUILTIN_AGENT_NAMES = ["worker", "cleaner", "documenter", "synthesizer", "reviewer"] as const;
+
 /** Agents enabled out of the box on a fresh install. */
 export const DEFAULT_ENABLED_AGENTS: readonly string[] = [...BUILTIN_AGENT_NAMES];
 
@@ -183,6 +190,29 @@ function defaultConfig(): SubagentsConfig {
 	};
 }
 
+/**
+ * Drop every removed built-in role from an already-normalized config: enabled
+ * and known lists, plus per-agent model and thinking routes. The schema-upgrade
+ * persistence in loadConfig writes the pruned shape back to disk.
+ */
+function pruneRemovedBuiltins(config: SubagentsConfig): SubagentsConfig {
+	const removed = new Set<string>(REMOVED_BUILTIN_AGENT_NAMES);
+	const filter = (names: readonly string[]): string[] => names.filter((name) => !removed.has(name));
+	const agentModels = { ...config.agentModels };
+	const agentThinkingLevels = { ...config.agentThinkingLevels };
+	for (const name of REMOVED_BUILTIN_AGENT_NAMES) {
+		delete agentModels[name];
+		delete agentThinkingLevels[name];
+	}
+	return {
+		...config,
+		enabledAgents: filter(config.enabledAgents),
+		knownAgents: filter(config.knownAgents),
+		agentModels,
+		agentThinkingLevels,
+	};
+}
+
 /**
  * A shipped agent the config has never recorded is new in this release; the
  * stale allow-list must not keep it dark. Enable it and adopt explorer's
@@ -216,6 +246,7 @@ function adoptNewBuiltins(config: SubagentsConfig): SubagentsConfig {
  * A file from an older version (missing newer keys or holding extra keys) is
  * normalized and persisted back, so the on-disk config stays current. Built-in
  * agents the file has never seen are adopted: enabled with explorer's route.
+ * Built-in roles this package retired are pruned from every record.
  */
 export async function loadConfig(configPath: string = getConfigPath()): Promise<SubagentsConfig> {
 	let text: string;
@@ -233,7 +264,10 @@ export async function loadConfig(configPath: string = getConfigPath()): Promise<
 		return defaultConfig();
 	}
 
-	const config = adoptNewBuiltins(normalizeConfig(parsed));
+	// Adopt newly shipped roles first so the prune below works on the final
+	// catalog, then drop roles this package stopped shipping and persist the
+	// cleaned shape back to disk.
+	const config = pruneRemovedBuiltins(adoptNewBuiltins(normalizeConfig(parsed)));
 
 	// Schema upgrade: persist the normalized shape when the file gained fields
 	// (new version) or dropped invalid ones.