@fern-api/fern-api-dev 4.63.3 → 4.63.4

package/cli.cjs

@@ -551564,6 +551564,7 @@ var NoConflictingEndpointPathsRule = {
 
 // ../fern-definition/validator/lib/rules/no-conflicting-request-wrapper-properties/no-conflicting-request-wrapper-properties.js
 init_lib4();
+init_lodash();
 var NoConflictingRequestWrapperPropertiesRule = {
   name: "no-conflicting-request-wrapper-properties",
   create: ({ workspace }) => {
@@ -551588,6 +551589,8 @@ var NoConflictingRequestWrapperPropertiesRule = {
 ` + propertiesWithName.map((property23) => `  - ${convertRequestWrapperPropertyToString(property23)}`).join("\n")
             });
           }
+          const camelCaseViolations = getCamelCaseNormalizedCollisions(nameToProperties);
+          violations.push(...camelCaseViolations);
           return violations;
         }
       }
@@ -551688,6 +551691,32 @@ function convertRequestWrapperPropertyToString(property23) {
       assertNever(property23);
   }
 }
+function getCamelCaseNormalizedCollisions(nameToProperties) {
+  const camelCaseToEntries = {};
+  for (const [rawName, properties7] of Object.entries(nameToProperties)) {
+    for (const property23 of properties7) {
+      const normalizedName = camelCase_default(rawName);
+      const entries22 = camelCaseToEntries[normalizedName] ??= [];
+      entries22.push({ rawName, property: property23 });
+    }
+  }
+  const violations = [];
+  for (const [normalizedName, entries22] of Object.entries(camelCaseToEntries)) {
+    if (entries22.length <= 1) {
+      continue;
+    }
+    const distinctRawNames = new Set(entries22.map((e6) => e6.rawName));
+    if (distinctRawNames.size <= 1) {
+      continue;
+    }
+    violations.push({
+      severity: "fatal",
+      message: `Multiple request properties resolve to the same generated name ${source_default.bold(normalizedName)} after camelCase normalization. This causes broken generated code. Use the "name" property to disambiguate.
+` + entries22.map((entry) => `  - ${convertRequestWrapperPropertyToString(entry.property)} (name: "${entry.rawName}")`).join("\n")
+    });
+  }
+  return violations;
+}
 
 // ../fern-definition/validator/lib/rules/no-duplicate-declarations/no-duplicate-declarations.js
 var import_path22 = __toESM(require("path"), 1);
@@ -594441,6 +594470,130 @@ var NoComponentSchemaCollisionsRule = {
   }
 };
 
+// ../workspace/oss-validator/lib/rules/no-conflicting-parameter-names/no-conflicting-parameter-names.js
+init_lib6();
+var NoConflictingParameterNamesRule = {
+  name: "no-conflicting-parameter-names",
+  run: async ({ workspace, specs, loadedDocuments }) => {
+    const violations = [];
+    for (const spec of specs) {
+      if (spec.type !== "openapi") {
+        continue;
+      }
+      const openAPI = loadedDocuments.get(spec.absoluteFilepath);
+      if (openAPI == null) {
+        continue;
+      }
+      const apiToValidate = isOpenAPIV2(openAPI) ? await convertOpenAPIV2ToV3(openAPI) : openAPI;
+      const relativeFilepath = relative3(workspace.absoluteFilePath, spec.source.file);
+      for (const [path97, pathItem] of Object.entries(apiToValidate.paths ?? {})) {
+        if (pathItem == null || typeof pathItem !== "object") {
+          continue;
+        }
+        const pathItemObj = pathItem;
+        const pathLevelParams = resolveAllParams(pathItemObj.parameters, apiToValidate);
+        for (const method8 of ["get", "put", "post", "delete", "options", "head", "patch", "trace"]) {
+          const operation = pathItemObj[method8];
+          if (operation == null) {
+            continue;
+          }
+          const operationParams = resolveAllParams(operation.parameters, apiToValidate);
+          const mergedParams = mergeParameters(pathLevelParams, operationParams);
+          const nameToParams = {};
+          for (const param of mergedParams) {
+            const normalizedName = toCamelCase3(param.name);
+            if (normalizedName === "") {
+              continue;
+            }
+            const existing = nameToParams[normalizedName] ??= [];
+            existing.push(param);
+          }
+          for (const [normalizedName, params2] of Object.entries(nameToParams)) {
+            if (params2.length <= 1) {
+              continue;
+            }
+            const distinctTypes = new Set(params2.map((p10) => p10.in));
+            if (distinctTypes.size <= 1) {
+              continue;
+            }
+            const paramDescriptions = params2.map((p10) => `${p10.in} parameter '${p10.name}'`).join(", ");
+            violations.push({
+              name: "no-conflicting-parameter-names",
+              severity: "error",
+              relativeFilepath,
+              nodePath: ["paths", path97, method8],
+              message: `Parameters ${paramDescriptions} all normalize to '${normalizedName}' in generated SDKs. This causes broken code (duplicate keyword arguments in Python, duplicate properties in TypeScript). Rename one of the parameters to avoid the collision.`
+            });
+          }
+        }
+      }
+    }
+    return violations;
+  }
+};
+function resolveAllParams(params2, api) {
+  if (!Array.isArray(params2)) {
+    return [];
+  }
+  const result = [];
+  for (const param of params2) {
+    const resolved = resolveParam(param, api);
+    if (resolved != null) {
+      result.push(resolved);
+    }
+  }
+  return result;
+}
+function resolveParam(param, api, visited = /* @__PURE__ */ new Set()) {
+  if (typeof param !== "object" || param == null) {
+    return void 0;
+  }
+  const paramObj = param;
+  if (typeof paramObj.$ref === "string") {
+    const refPath = paramObj.$ref;
+    if (visited.has(refPath)) {
+      return void 0;
+    }
+    if (refPath.startsWith("#/components/parameters/")) {
+      const paramName = refPath.substring("#/components/parameters/".length);
+      const components = api.components;
+      const resolved = components?.parameters?.[paramName];
+      if (resolved != null) {
+        visited.add(refPath);
+        return resolveParam(resolved, api, visited);
+      }
+    }
+    if (refPath.startsWith("#/parameters/")) {
+      const paramName = refPath.substring("#/parameters/".length);
+      const parameters2 = api.parameters;
+      const resolved = parameters2?.[paramName];
+      if (resolved != null) {
+        visited.add(refPath);
+        return resolveParam(resolved, api, visited);
+      }
+    }
+    return void 0;
+  }
+  if (typeof paramObj.in === "string" && typeof paramObj.name === "string") {
+    return { in: paramObj.in, name: paramObj.name };
+  }
+  return void 0;
+}
+function mergeParameters(pathParams, operationParams) {
+  const operationParamKeys = new Set(operationParams.map((p10) => `${p10.in}:${p10.name}`));
+  const merged = [...operationParams];
+  for (const pathParam of pathParams) {
+    const key2 = `${pathParam.in}:${pathParam.name}`;
+    if (!operationParamKeys.has(key2)) {
+      merged.push(pathParam);
+    }
+  }
+  return merged;
+}
+function toCamelCase3(input3) {
+  return input3.replace(/[-_]+(.)?/g, (_16, char) => char != null ? char.toUpperCase() : "").replace(/^[A-Z]/, (char) => char.toLowerCase());
+}
+
 // ../workspace/oss-validator/lib/rules/no-duplicate-auth-header-parameters/no-duplicate-auth-header-parameters.js
 init_lib6();
 var NoDuplicateAuthHeaderParametersRule = {
@@ -594469,7 +594622,7 @@ var NoDuplicateAuthHeaderParametersRule = {
         const pathLevelParams = pathItemObj.parameters;
         if (Array.isArray(pathLevelParams)) {
           for (const param of pathLevelParams) {
-            const resolved = resolveParam(param, apiToValidate);
+            const resolved = resolveParam2(param, apiToValidate);
             if (resolved != null && isDuplicateAuthHeader(resolved, authHeaderNames)) {
               violations.push({
                 name: "no-duplicate-auth-header-parameters",
@@ -594487,7 +594640,7 @@ var NoDuplicateAuthHeaderParametersRule = {
             continue;
           }
           for (const param of operation.parameters) {
-            const resolved = resolveParam(param, apiToValidate);
+            const resolved = resolveParam2(param, apiToValidate);
             if (resolved != null && isDuplicateAuthHeader(resolved, authHeaderNames)) {
               violations.push({
                 name: "no-duplicate-auth-header-parameters",
@@ -594531,7 +594684,7 @@ function getAuthHeaderNames(api) {
   }
   return headerNames;
 }
-function resolveParam(param, api, visited = /* @__PURE__ */ new Set()) {
+function resolveParam2(param, api, visited = /* @__PURE__ */ new Set()) {
   if (typeof param !== "object" || param == null) {
     return void 0;
   }
@@ -594547,7 +594700,7 @@ function resolveParam(param, api, visited = /* @__PURE__ */ new Set()) {
       const resolved = components?.parameters?.[paramName];
       if (resolved != null) {
         visited.add(refPath);
-        return resolveParam(resolved, api, visited);
+        return resolveParam2(resolved, api, visited);
       }
     }
     return void 0;
@@ -594753,7 +594906,8 @@ function getAllRules2() {
     NoDuplicateOverridesRule,
     NoSchemaTitleCollisionsRule,
     NoComponentSchemaCollisionsRule,
-    NoInvalidTagNamesOrFrontmatterRule
+    NoInvalidTagNamesOrFrontmatterRule,
+    NoConflictingParameterNamesRule
   ];
 }
 
@@ -603124,7 +603278,7 @@ var AccessTokenPosthogManager = class {
         properties: {
           ...event,
           ...event.properties,
-          version: "4.63.3",
+          version: "4.63.4",
           usingAccessToken: true
         }
       });
@@ -603175,7 +603329,7 @@ var UserPosthogManager = class {
       distinctId: this.userId ?? await this.getPersistedDistinctId(),
       event: "CLI",
       properties: {
-        version: "4.63.3",
+        version: "4.63.4",
         ...event,
         ...event.properties,
         usingAccessToken: false,
@@ -839769,7 +839923,7 @@ var LOCAL_STORAGE_FOLDER4 = ".fern-dev";
 var LOGS_FOLDER_NAME = "logs";
 var MAX_LOGS_DIR_SIZE_BYTES = 100 * 1024 * 1024;
 function getCliSource() {
-  const version7 = "4.63.3";
+  const version7 = "4.63.4";
   return `cli@${version7}`;
 }
 var DebugLogger = class {
@@ -850967,7 +851121,7 @@ var LegacyDocsPublisher = class {
         previewId,
         disableTemplates: void 0,
         skipUpload,
-        cliVersion: "4.63.3"
+        cliVersion: "4.63.4"
       });
       if (taskContext.getResult() === TaskResult.Failure) {
         return { success: false };
@@ -874356,11 +874510,11 @@ function getMajorVersionSuffix({ config: config5 }) {
 }
 function parseMajorVersion({ config: config5 }) {
   const version7 = getVersion(config5);
-  if (version7 == null) {
+  if (version7 == null || version7 === "") {
     return void 0;
   }
   const split2 = version7.split(".");
-  if (split2[0] == null) {
+  if (split2[0] == null || split2[0] === "" || split2[0] === "v") {
     return void 0;
   }
   const majorVersion2 = split2[0];
@@ -924345,7 +924499,7 @@ var CliContext = class {
     if (false) {
       this.logger.error("CLI_VERSION is not defined");
     }
-    return "4.63.3";
+    return "4.63.4";
   }
   getCliName() {
     if (false) {

package/package.json

@@ -1,5 +1,5 @@
 {
-  "version": "4.63.3",
+  "version": "4.63.4",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/fern-api/fern.git",