@fenglimg/fabric-cli 2.0.0-rc.36 → 2.0.0-rc.38

package/templates/skills/fabric-review/ref/i18n-policy.md

@@ -1,5 +1,11 @@
 # UX i18n Policy — fabric-review full reference
 
+> **Shared core (rc.37 NEW-13):** the cross-skill invariants — protected-token
+> NEVER-translate list, AskUserQuestion routing-key rule, layer heuristic, and
+> events-emit convention — live once in `../../lib/shared-policy.md`. This file
+> keeps only the fabric-review-specific 5-class examples. Read the shared lib
+> for the common rules; do not fork them here.
+
 > **Loaded on demand.** Only consult when you need to disambiguate which of the 5 classes a given string belongs to. SKILL.md gives the operative rule.
 
 ## UX i18n Policy (5-class bilingualization)

package/templates/skills/fabric-review/ref/modify-flow.md

@@ -2,7 +2,15 @@
 
 ## Modify Sub-Flow
 
-`modify` is the only action that mutates frontmatter or stable_id. It accepts `changes` of shape `{title?, summary?, layer?, maturity?, tags?}`. Server semantics:
+The modify family is the only action group that mutates frontmatter or stable_id. It accepts `changes` of shape `{title?, summary?, layer?, maturity?, tags?, relevance_scope?, relevance_paths?}`.
+
+**v2.0.0-rc.37 NEW-12 — explicit split.** Prefer the dedicated action over the legacy combined `modify`:
+
+- `action="modify-content"` — scalar edits (title/summary/tags/maturity/relevance_*); stable_id PRESERVED; the server STRIPS any `changes.layer` so this path can never flip layer. Emits `knowledge_slug_renamed` only when slug derives from title.
+- `action="modify-layer"` — the dedicated layer-flip path; `changes.layer` is REQUIRED. The ONLY legal stable_id mutation in the system (see Layer-Flip Rules below).
+- `action="modify"` (legacy alias) — still accepted; routes to content-edit OR layer-flip by whether `changes.layer` is present. New call sites should use the explicit pair.
+
+Server semantics (identical regardless of which action selected the path):
 
 - **title / summary / tags / maturity changes** → in-place rewrite; stable_id PRESERVED; emits `knowledge_slug_renamed` only when slug derives from title.
 - **layer change** → the ONLY legal stable_id mutation in the system.

package/templates/skills/fabric-review/ref/per-mode-flows.md

@@ -152,4 +152,4 @@ Full bilingual rendering blocks + step-by-step procedures for the four modes ref
 
 ### Anti-Pattern (Hard Rule restatement)
 
-NEVER emit an `AskUserQuestion` whose options include {pending, topic, health, revisit}. The user does not pick the mode. If inference is genuinely ambiguous after all 3 steps, default to `pending` and proceed; the user can always cancel and redirect.
+NEVER emit an `AskUserQuestion` whose options include {pending, maintain} (or the legacy {topic, health, revisit} aliases). The user does not pick the mode. If inference is genuinely ambiguous after both steps, default to `pending` and proceed; the user can always cancel and redirect. (rc.37 NEW-12 collapsed the 4 legacy modes to 2: `pending` + `maintain`.)

package/templates/skills/lib/shared-policy.md

@@ -0,0 +1,69 @@
+# Shared skill policy — cross-skill canonical core (rc.37 NEW-13)
+
+> **Single source of truth** for the policy invariants that fabric-archive,
+> fabric-review, and fabric-import all depend on. Each skill's `ref/` keeps
+> only its skill-specific examples and points here (`../../lib/shared-policy.md`)
+> for the common rules. Edit invariants HERE — never fork them per skill.
+
+## 1. Protected tokens — NEVER translated
+
+When rendering bilingual (zh-CN ↔ en) output, prose is translated but the
+following classes of token appear **verbatim in both variants**:
+
+- **MCP tool + field names**: `fab_extract_knowledge`, `fab_review`,
+  `fab_recall`, `fab_plan_context`, `fab_get_knowledge_sections`,
+  `relevance_scope`, `relevance_paths`, `source_sessions`, `proposed_reason`,
+  `session_context`, `intent_clues`, `tech_stack`, `impact`, `must_read_if`,
+  `evidence_paths`, `tags`, `pending_path`, `layer`.
+- **Enum / routing values**: `narrow`, `broad`, `team`, `personal`, `draft`,
+  `verified`, `proven`, `knowledge_scope_degraded`.
+- **Imperatives + paths**: `MUST`, `NEVER`, `.fabric/knowledge/`, file paths.
+
+The authoritative machine-checked list is `PROTECTED_TOKENS` in
+`@fenglimg/fabric-shared` (enforced by `scripts/lint-protected-tokens.ts`).
+Bilingualization scope is **prose ONLY**.
+
+## 2. AskUserQuestion routing-key invariant
+
+When any skill issues an `AskUserQuestion`:
+
+- `header` + `question` → user-facing prose → **translated** per
+  `.fabric/fabric-config.json` → `fabric_language`.
+- `options[]` entries → **routing keys** consumed by the skill's `switch`
+  over the returned choice → stay **English** in BOTH variants.
+
+Canonical option arrays (English in every locale):
+
+- Per-item review action: `["approve", "reject", "modify", "defer", "skip"]`
+- Stale-item action (review health mode): `["defer", "demote", "skip"]`
+- Layer-flip target: `["team", "personal"]`
+
+A skill that translates `options[]` MUST then dual-string-match
+(`choice === "approve" || choice === "通过"`); avoid this — keep options
+English so the state machine stays single-string.
+
+## 3. Layer heuristic (team vs personal)
+
+Default classification when archiving / proposing knowledge:
+
+- **强 team** — cross-cutting decisions, architecture, shared pitfalls,
+  conventions the whole repo depends on.
+- **强 personal** — individual workflow preferences, local environment quirks,
+  notes scoped to one contributor (`KP-*` ids, in-repo `~/.fabric` root).
+- **默认 team** — when ambiguous, default to `team` (shared visibility is the
+  safer default; a mis-scoped personal entry hides knowledge from the team).
+
+This block is itself a protected token sequence — render `强 team` /
+`强 personal` / `默认 team` verbatim.
+
+## 4. Events emit convention
+
+Skills persist lifecycle via MCP tools (which emit the canonical events) —
+they do NOT hand-write `.fabric/events.jsonl`:
+
+- `fab_extract_knowledge` → `knowledge_proposed` (+ archive-attempt events).
+- `fab_review` approve → `knowledge_promote_started` → `knowledge_promoted`.
+- `fab_review` modify-layer → `knowledge_layer_changed` (+ id-redirect).
+
+Never instruct the user to delete or hand-edit the event ledger; it is the
+append-only audit trail. Counter rollups live in `.fabric/metrics.jsonl`.

package/dist/serve-43JTEM3U.js

@@ -1,142 +0,0 @@
-#!/usr/bin/env node
-import {
-  hasActionHint,
-  paint,
-  renderFabricError,
-  symbol
-} from "./chunk-G2CIOLD4.js";
-import {
-  t
-} from "./chunk-PWLW3B57.js";
-import {
-  createDebugLogger,
-  resolveDevMode
-} from "./chunk-COI5VDFU.js";
-
-// src/commands/serve.ts
-import { defineCommand } from "citty";
-import { acquireLock, releaseLock, startHttpServer } from "@fenglimg/fabric-server";
-var DEFAULT_PORT = 7373;
-var serveCommand = defineCommand({
-  meta: {
-    name: "serve",
-    description: t("cli.serve.description")
-  },
-  args: {
-    port: {
-      type: "string",
-      description: t("cli.serve.args.port.description"),
-      default: String(DEFAULT_PORT)
-    },
-    host: {
-      type: "string",
-      description: t("cli.serve.args.host.description"),
-      default: "127.0.0.1"
-    },
-    target: {
-      type: "string",
-      description: t("cli.serve.args.target.description")
-    },
-    debug: {
-      type: "boolean",
-      description: t("cli.serve.args.debug.description"),
-      default: false
-    },
-    // v2.0.0-rc.29 TASK-002 (BUG-K1): default-deny strict-auth.
-    "allow-loopback-no-auth": {
-      type: "boolean",
-      description: t("cli.serve.args.allow-loopback-no-auth.description"),
-      default: false
-    }
-  },
-  async run({ args }) {
-    const workspaceRoot = process.cwd();
-    const logger = createDebugLogger(args.debug);
-    const resolution = resolveDevMode(args.target, workspaceRoot);
-    const port = parsePort(args.port);
-    const requestedHost = parseHost(args.host);
-    const authToken = readAuthTokenFromEnv();
-    const allowLoopbackNoAuth = args["allow-loopback-no-auth"] === true;
-    const host = validateHost(requestedHost, authToken, allowLoopbackNoAuth);
-    const projectRoot = resolution.target;
-    try {
-      acquireLock(projectRoot);
-    } catch (err) {
-      if (hasActionHint(err)) {
-        renderFabricError(err);
-        process.exit(1);
-      }
-      throw err;
-    }
-    process.on("exit", () => {
-      releaseLock(projectRoot);
-    });
-    logger(`serve target source: ${resolution.source}`);
-    for (const step of resolution.chain) {
-      logger(step);
-    }
-    try {
-      await startHttpServer({
-        port,
-        projectRoot,
-        host,
-        authToken,
-        allowLoopbackNoAuth
-      });
-    } catch (error) {
-      if (isNodeError(error) && error.code === "EADDRINUSE") {
-        releaseLock(projectRoot);
-        throw new Error(t("cli.serve.error.port-in-use", { port: String(port), nextPort: String(port + 1) }));
-      }
-      releaseLock(projectRoot);
-      throw error;
-    }
-    console.log(`${symbol.ok} ${paint.ai(t("cli.serve.ready.title"))} ${paint.human(`http://${host}:${port}`)}`);
-  }
-});
-var serve_default = serveCommand;
-function parsePort(value) {
-  const port = Number.parseInt(value ?? String(DEFAULT_PORT), 10);
-  if (!Number.isInteger(port) || port < 1 || port > 65535) {
-    throw new Error(t("cli.shared.invalid-port", { value: value ?? "<unset>" }));
-  }
-  return port;
-}
-function parseHost(value) {
-  const host = value?.trim() ?? "127.0.0.1";
-  if (host.length === 0) {
-    throw new Error(t("cli.shared.invalid-host-empty"));
-  }
-  return host;
-}
-function readAuthTokenFromEnv() {
-  const token = process.env.FABRIC_AUTH_TOKEN;
-  return token === void 0 || token.length === 0 ? void 0 : token;
-}
-function validateHost(host, authToken, allowLoopbackNoAuth) {
-  if (authToken !== void 0) {
-    return host;
-  }
-  if (!isLoopbackHost(host)) {
-    console.error(
-      `${symbol.warn} ${paint.warn(t("cli.serve.warning.host-fallback", { host }))}`
-    );
-    return "127.0.0.1";
-  }
-  if (!allowLoopbackNoAuth) {
-    console.error(
-      `${symbol.warn} ${paint.warn(t("cli.serve.warning.loopback-deny-default"))}`
-    );
-  }
-  return host;
-}
-function isLoopbackHost(host) {
-  return host === "127.0.0.1" || host === "localhost" || host === "::1";
-}
-function isNodeError(error) {
-  return error instanceof Error;
-}
-export {
-  serve_default as default,
-  serveCommand
-};