@feng0531/dsh-code-review 0.38.0 → 0.40.0

package/src/dependency-chain.mjs

@@ -0,0 +1,44 @@
+import {contextCandidates} from './context-candidates.mjs';
+import {gitContextIndex} from './tracked-context.mjs';
+import {readLocal} from './content.mjs';
+// Fixed-depth literal navigation, not symbol binding. Never enumerate the repository.
+export async function captureDependencyChain(root,files,options={}){
+ const signal=AbortSignal.any([AbortSignal.timeout(30000),...(options.signal?[options.signal]:[])]);
+ const scoped={...options,maxFileBytes:Math.min(options.maxFileBytes??256*1024,256*1024),signal},probes=new Set(),visited=new Set(files.map(f=>f.path)),context=[],candidates=[];
+ const reserved=new Set([...(options.contextPaths??[]),...(options.rulePaths??[])]),limit=Math.min(options.maxContextFiles??20,20);
+ let frontier=[...files],index,bytes=0,truncated=false,depth=0;
+ const explicitSeeds=[];
+ if(new Set(options.contextPaths??[]).size>limit)throw new Error('Context file limit exceeded');
+ for(const name of [...new Set(options.contextPaths??[])].sort()){
+  const changed=files.find(f=>f.path===name);
+  if(changed){if(changed.eligibility!=='reviewable'||changed.rightExists===false)throw new Error('Context path is an excluded blocked or deleted change');continue;}
+  const item={path:name,...await readLocal(root,name,scoped)};
+  bytes+=item.bytes;if(bytes>1024*1024)throw new Error('Dependency source byte limit exceeded');
+  explicitSeeds.push(item);visited.add(name);frontier.push({path:name,eligibility:'reviewable',right:item});
+ }
+ // Seeds are already explicitly selected, but descendants must still pass exact tracked probes.
+
+ const onProbe=paths=>{for(const p of paths)probes.add(p);if(probes.size>512)throw new Error('Git context lookup limit exceeded');};
+ for(depth=1;depth<=3&&frontier.length;depth++){
+  signal.throwIfAborted();for(let i=0;i<frontier.length;i+=200)contextCandidates(frontier.slice(i,i+200),[],{onProbe});
+  index=await gitContextIndex(root,{...scoped,probePaths:[...probes]});
+  const plans=[];for(let i=0;i<frontier.length;i+=200)plans.push(contextCandidates(frontier.slice(i,i+200),index.paths));const plan={candidates:plans.flatMap(p=>p.candidates),truncated:plans.some(p=>p.truncated)};truncated ||= plan.truncated;
+  const next=[];
+  for(const entry of plan.candidates){
+   if(visited.has(entry.path)||reserved.has(entry.path))continue;
+   visited.add(entry.path);const candidate={...entry,depth};candidates.push(candidate);
+   if(candidates.length>20)throw new Error('Dependency candidate limit exceeded');
+   if(context.length+new Set(options.contextPaths??[]).size>=limit){candidate.status='blocked';candidate.reason='Context file limit exceeded';continue;}
+   try{
+    const item={path:entry.path,...await readLocal(root,entry.path,scoped)};
+    bytes+=item.bytes;if(bytes>1024*1024)throw new Error('Dependency source byte limit exceeded');
+    context.push(item);candidate.status='captured';
+    next.push({path:item.path,eligibility:'reviewable',right:item});
+   }catch(error){signal.throwIfAborted();if(error.message==='Dependency source byte limit exceeded')throw error;candidate.status='blocked';candidate.reason=error.message;}
+  }
+  frontier=next;
+ }
+ if(frontier.length)truncated=true;
+ const indexOptions={...scoped,probePaths:[...probes]};
+ return {context,index,indexOptions,explicitSeeds,autoContext:{candidates,capturedPaths:context.map(c=>c.path),truncated,maxDepth:3,probeCount:probes.size,sourceBytes:bytes,notice:'Bounded current-side literal dependency navigation from changed and explicit context sources, depth <=3, 512 shared exact probes, 20 candidates/context slots, 1MiB source bytes and 30s through verification. Not symbol binding, caller coverage or complete definitions.'}};
+}

package/src/snapshot.mjs

@@ -1,3 +1,4 @@
+import {captureDependencyChain} from './dependency-chain.mjs';
 import {captureSvnCallers} from './svn-caller-capture.mjs';
 import { captureCallers } from './caller-capture.mjs';
 import { validateCallerScopes } from './caller-index.mjs';
@@ -48,8 +49,11 @@ export async function captureSnapshot(cwd, options = {}) {
   if (!Array.isArray(rulePaths) || rulePaths.some(name => contextPaths.includes(name))) throw new Error('Rule paths must be separate from context paths');
   const rules = await captureProjectRules(snapshot.root, rulePaths, { signal: options.signal, files: snapshot.files });
   const context = [];
-  let autoContext, index, indexOptions = options;
-  if (options.autoContext === true) {
+  let autoContext, index, explicitSeeds = [], indexOptions = options;
+  if (options.autoContext === true && type==='git') {
+    const chain=await captureDependencyChain(snapshot.root,snapshot.files,options);
+    explicitSeeds=chain.explicitSeeds;context.push(...chain.context);autoContext=chain.autoContext;index=chain.index;indexOptions=chain.indexOptions;
+  } else if (options.autoContext === true) {
     if(type==='git'){const probes=new Set();contextCandidates(snapshot.files,[],{onProbe:paths=>{for(const p of paths)probes.add(p);if(probes.size>512)throw new Error('Git context lookup limit exceeded');}});indexOptions={...options,probePaths:[...probes]};}
     index = await (type === 'git' ? gitContextIndex : svnContextIndex)(snapshot.root, indexOptions);
     const plan = contextCandidates(snapshot.files, index.paths);
@@ -68,7 +72,12 @@ export async function captureSnapshot(cwd, options = {}) {
       if (changed.eligibility !== 'reviewable') throw new Error('Context path is an excluded or blocked change');
       if (changed.rightExists === false) throw new Error('Deleted path cannot be working context');
       context.push({ path: name, ...changed.right });
-    } else context.push({ path: name, ...await readLocal(snapshot.root, name, options) });
+    } else {
+      const item={path:name,...await readLocal(snapshot.root,name,indexOptions)};
+      const seed=explicitSeeds.find(c=>c.path===name);
+      if(seed&&seed.hash!==item.hash)throw new Error('Explicit dependency seed changed during capture');
+      context.push(item);
+    }
   }
   let callerDiscovery, verifyCallers;
   if (options.callerScopePaths !== undefined) {
@@ -89,8 +98,8 @@ export async function captureSnapshot(cwd, options = {}) {
     }
   }
   // Re-capture verifies both selected sides while collecting explicit context.
-  if ((await capture(cwd, options)).id !== snapshot.id) throw new Error('Snapshot changed while collecting context');
-  for (const item of context) if ((await readLocal(snapshot.root, item.path, options)).hash !== item.hash) throw new Error('Context changed during capture');
+  if ((await capture(cwd, indexOptions)).id !== snapshot.id) throw new Error('Snapshot changed while collecting context');
+  for (const item of context) if ((await readLocal(snapshot.root, item.path, indexOptions)).hash !== item.hash) throw new Error('Context changed during capture');
   if (index && (await (type === 'git' ? gitContextIndex : svnContextIndex)(snapshot.root, indexOptions)).fingerprint !== index.fingerprint) throw new Error('Tracked context index changed during capture');
   const verifiedRules = await captureProjectRules(snapshot.root, rulePaths, { signal: options.signal, files: snapshot.files });
   if (JSON.stringify(verifiedRules) !== JSON.stringify(rules)) throw new Error('Rules changed during capture');