@feigi/fleet-ctl 3.82.20 → 3.82.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@feigi/fleet-ctl",
-  "version": "3.82.20",
+  "version": "3.82.21",
   "description": "Agent fleet: run-team controller, merge bot, PR reviewer, and the ticket pipeline they share",
   "license": "Apache-2.0",
   "repository": {

package/scripts/tier-outcomes.mjs

@@ -20,7 +20,12 @@
 //     lack a member row (nothing from that run was checked). `--live`
 //     (a run in progress; CI never passes it) adds a WARNING, never a
 //     failure, per PR whose run-ledger row carries `reviewed=` but which has
-//     no row here. `--ledger <path>` names another ledger than the run's own.
+//     no row here, except a PR that closes no issue: `append` keys a row on
+//     exactly one ticket and refuses it, so it is named in a `note` line and
+//     never warned about. A read of that PR that does not answer keeps the
+//     warning, after a line naming why the read failed. Both reads of a PR's
+//     closing references ignore an ambient GH_REPO and give `gh` 60s.
+//     `--ledger <path>` names another ledger than the run's own.
 //
 // `tier` resolution, in order (never tie-broken by `run_date`: the two files'
 // `run_date`s mean different things — this file's header measures 92 of 267
@@ -445,20 +450,37 @@ function readLedger(ledgerFile, requireFile) {
   }
 }
 
-function closingTicket(pr) {
+// A PR's closingIssuesReferences array, or an Error naming why it could not be
+// read. GH_REPO is blanked so an ambient one naming another repository never
+// decides which PR is read; the timeout keeps a hung `gh` from stalling
+// `append` or a close-out's `check --live`.
+const GH_TIMEOUT_MS = 60_000;
+function closingRefs(pr) {
   let raw;
   try {
-    raw = execFileSync("gh", ["pr", "view", pr, "--json", "closingIssuesReferences"], { encoding: "utf8", stdio: ["ignore", "pipe", "pipe"] });
+    raw = execFileSync("gh", ["pr", "view", String(pr), "--json", "closingIssuesReferences"], {
+      encoding: "utf8", stdio: ["ignore", "pipe", "pipe"], env: { ...process.env, GH_REPO: "" }, timeout: GH_TIMEOUT_MS,
+    });
   } catch (e) {
-    die(`gh pr view ${pr} failed: ${e.stderr?.trim() || e.message}`);
+    throw new Error(`gh pr view ${pr} failed: ${e.stderr?.trim() || e.message}`);
   }
   let refs;
   try {
     refs = JSON.parse(raw).closingIssuesReferences;
   } catch (e) {
-    die(`gh pr view ${pr} returned unreadable JSON: ${e.message}`);
+    throw new Error(`gh pr view ${pr} returned unreadable JSON: ${e.message}`);
+  }
+  if (!Array.isArray(refs)) throw new Error(`gh pr view ${pr} returned no closingIssuesReferences array`);
+  return refs;
+}
+
+function closingTicket(pr) {
+  let refs;
+  try {
+    refs = closingRefs(pr);
+  } catch (e) {
+    die(e.message);
   }
-  if (!Array.isArray(refs)) die(`gh pr view ${pr} returned no closingIssuesReferences array`);
   const numbers = [...new Set(refs.map((r) => r?.number))];
   if (numbers.length !== 1 || !Number.isInteger(numbers[0])) {
     die(`PR #${pr} closes ${numbers.length === 0 ? "no issue" : `${numbers.length} issues (${numbers.map((n) => `#${n}`).join(", ")})`} per GitHub's closingIssuesReferences — a tier-outcomes row keys on exactly one ticket`);
@@ -534,6 +556,20 @@ function append(pr, paths) {
   console.log(line);
 }
 
+// True only when `gh` answered and the PR's closingIssuesReferences is an empty
+// array. Any other outcome (gh failing, unreadable JSON, a non-array) is false
+// after a line naming why: a PR whose closing references cannot be read keeps
+// its warning. That line never reads `WARNING PR #`, which closeout.mjs turns
+// into a NEED.
+function closesNoIssue(pr) {
+  try {
+    return closingRefs(pr).length === 0;
+  } catch (e) {
+    console.error(`${NAME}: could not read the closing references of PR #${pr}: ${e.message}`);
+    return false;
+  }
+}
+
 function check(paths) {
   for (const flag of Object.keys(APPEND_FLAGS)) {
     if (arg(flag) !== null) die(`--${flag} is an append flag`);
@@ -546,6 +582,10 @@ function check(paths) {
   if (has("live")) {
     const ledger = readLedger(paths.ledger, true);
     for (const pr of unrecordedReviewedPrs(ledger, rows)) {
+      if (closesNoIssue(pr)) {
+        console.error(`${NAME}: note PR #${pr} carries reviewed= on the ledger and closes no issue, so it takes no row in ${paths.file}`);
+        continue;
+      }
       console.error(`${NAME}: WARNING PR #${pr} carries reviewed= on the ledger but has no row in ${paths.file} — run \`tier-outcomes.mjs append ${pr}\` if it is an implementer PR`);
     }
   }

package/skills/run-team/SKILL.md

@@ -211,6 +211,7 @@ owes beyond its call:
      a recorded stop as the end of the run. A `NEED tier-outcomes append
      <pr>` is a PR the ledger marks reviewed with no verdict row: append it with
      the verdict you rule (**Guard: accumulate per PR**) and run `finish` again.
+     A reviewed PR that closes no issue takes no row and is never a NEED.
      A step it fails is explained in references/close-out.md. Exit 0 is the run
      closed.
   Drain only when a documented trigger fired, and name the trigger in `--reason`.

package/skills/run-team/references/close-out.md

@@ -24,8 +24,10 @@
      `fleet-heartbeat.mjs --stop` last, because every reader takes a recorded
      stop as the end of the run. A `NEED tier-outcomes append <pr>` is a PR
      the ledger marks reviewed with no verdict row: append it with the verdict
-     you rule (**Guard: accumulate per PR**) and run `finish` again. A step it
-     fails is explained in references/close-out.md. Exit 0 is the run closed.
+     you rule (**Guard: accumulate per PR**) and run `finish` again. A reviewed
+     PR that closes no issue, a `Refs`-only step for instance, takes no row: the
+     check names it in a `note` line and never asks for one. A step it fails is
+     explained in references/close-out.md. Exit 0 is the run closed.
   Drain only when a documented trigger fired, and name the trigger in `--reason`.
   **Undrain** only when the maintainer asks, never a drain that budget or
   context exhaustion caused (references/close-out.md).
@@ -83,7 +85,10 @@ and none could be compared, so nothing from that run was checked: append the
 run's member rows if they are missing, or blank each named row's `tier` and say
 why in `note`.
 Each WARNING names a PR this run's ledger marks `reviewed=` that has no row yet
-— append it before committing if it is an implementer PR.
+— append it before committing if it is an implementer PR. A reviewed PR that
+closes no issue is named in a `note` line instead: it takes no row. A line
+saying the PR's closing references could not be read comes before that PR's
+WARNING and says why.
 
 ## Drain the pending ticket-features rows and refresh the cost guard