@feigi/fleet-ctl 3.82.12 → 3.82.14

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: fleet-implementer-slow-high
3
- description: A `/skill:run-team` implementer at cell slow-high. Dispatched by the controller in phase 2, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
3
+ description: A `/skill:run-team` implementer at cell slow-high. Dispatched by the controller at the Pull's dispatch, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
4
4
  model: "@slow:high"
5
5
  ---
6
6
 
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: fleet-implementer-slow-medium
3
- description: A `/skill:run-team` implementer at cell slow-medium. Dispatched by the controller in phase 2, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
3
+ description: A `/skill:run-team` implementer at cell slow-medium. Dispatched by the controller at the Pull's dispatch, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
4
4
  model: "@slow:medium"
5
5
  ---
6
6
 
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: fleet-implementer-smol-high
3
- description: A `/skill:run-team` implementer at cell smol-high. Dispatched by the controller in phase 2, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
3
+ description: A `/skill:run-team` implementer at cell smol-high. Dispatched by the controller at the Pull's dispatch, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
4
4
  model: "@smol:high"
5
5
  ---
6
6
 
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: fleet-implementer-task-high
3
- description: A `/skill:run-team` implementer at cell task-high. Dispatched by the controller in phase 2, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
3
+ description: A `/skill:run-team` implementer at cell task-high. Dispatched by the controller at the Pull's dispatch, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
4
4
  model: "@task:high"
5
5
  ---
6
6
 
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: fleet-implementer-task-max
3
- description: A `/skill:run-team` implementer at cell task-max. Dispatched by the controller in phase 2, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
3
+ description: A `/skill:run-team` implementer at cell task-max. Dispatched by the controller at the Pull's dispatch, never invoked directly; the body is byte-identical across every fleet-implementer-* definition.
4
4
  model: "@task:max"
5
5
  ---
6
6
 
@@ -13,6 +13,7 @@ argument-hint: [pr-number]
13
13
  2. Plan the actions. Split explicitly into **apply now** / **defer**. A finding is deferred, never dropped. **Every `suggestion` — the review's `severity`, the plugin's *Suggestions* bucket — arrives unchecked: the review budgets that band 0 refuters, so nothing has looked at it yet.** Checking it is now your job, not nobody's. So split it by SCOPE first, and check it in either scope. Out of the PR's ticket scope → defer and file, but **the claim bar runs first:** a suggestion whose claim is about shape — step 5's worth-a-claim bar, recorded `claimKind: shape` — gets no refuter and goes to the closed `PR #<pr> review: the suggestion band, checked` record, and every other out-of-scope suggestion gets the same refuter an in-scope one does, dispatched the same way, before it is filed. In scope → dispatch one refuter against it, biased to refuse, and hand it this instruction verbatim with one substitution: resolve `<scratch>/pr<N>/<finding>/` in it to an absolute path under your own run root — `mktemp -d` once per round for `<scratch>/pr<N>/fix-XXXXXXXX/`, never bare `pr<N>`, since finding ids restart at 1 each round too — and write that absolute path into the refuter's prompt in its place; a refuter never derives its own path, and tell it your step-3 `testCmd`, which its rules call `<testCmd>`: *Try to REFUTE this finding. Default to refuted=true if uncertain. Verify by RUNNING something — compile it, run the test, apply the mutation. Do not reason your way to agreement. Observe that run synchronously — run the command, wait for it, read its exit code. Never poll a log file for a completion marker: prefer ONE blocking run to a poll loop, and treat its return as permission to look, never as the answer. Reading a log the run has already finished writing is fine; waiting on one is not. If you match a test reporter's own output, accepting both `ℹ` and `#` is necessary but NOT sufficient — strip SGR escapes first as well. node's prefix moves with the node version and with whether stdout is a TTY, and color wraps the whole line so it begins with ESC and no prefix anchor matches at all, which returns empty at exit 0 — indistinguishable from a hung run and from a run of zero tests. For an uncolored baseline use `env -u FORCE_COLOR`; `FORCE_COLOR=` empty still enables color, so it is not a control. State your search scope AND what your pattern would have missed. A grep over one ref does not support a claim about history; a pattern built from the token a diff removed does not support a claim that the category is empty. When your check scores a mutant killed or a test red, run only in your own copy of the tree, and these rules decide it and nothing else: Valid red: a run that completed — the command returned on its own, with no signal and no timeout, deadline or kill having fired — in which the test the claim names is reported failing. An exit ≠ 0 with no failing test is not red, and a different test failing is not red for this claim. A red in the full suite only triggers a narrowed run; it is never evidence on its own. Narrowed run: the Test entrypoint with arguments appended, `<testCmd> <args>`. That appended arguments reach the Test entrypoint is all that is promised about them, so a narrowed run counts only if it reports `tests` > 0 and its output names the claimed test. If no narrowing can be proven, run the full `<testCmd>` and read the named test's own result from its output. Kill: the mutant produced a valid red in a narrowed run, and the same narrowed command, in the same tree with the mutant reverted, ran a valid green with the named test passing — completed, exit 0, `tests` > 0, `cancelled` 0. A completed exit ≠ 0 with the named test not failing is not a kill, and no kill stands without that green run on the unmutated tree. The result is inconclusive, never a kill, when the red does not reproduce in the narrowed run, when the unmutated tree is red too, or when no usable run exists. Evidence line: every kill and every valid red you claim carries one line in the claim's own free-text field: `red: <cmd> → exit N, fail K incl <test>; baseline: <cmd> → exit 0, <test> pass`. A failing-test finding filed off the review's shared run carries the `red:` half alone. This refuter has no abstain: a run that could not decide — neither a valid red nor a valid green — is no kill and no refutation, so name the runs in `reason`, each with its evidence line, and leave `refuted` true, so the suggestion defers on the record instead of applying on a check that decided nothing. A failure injection with no positive control has produced NO result, never a negative one. Before you read an injected fault — an env var, an argv word, a mutant — as having had no effect, prove the injection reached the child: one run whose output differs with it present versus absent, or the child echoing the injected value back. Uncontrolled, the cell is unrun — say so in your verdict instead of reporting a no-effect result. Build such an invocation as an array expanded braced and quoted — `cfg=(SETB=1 BADJ=1); env "${cfg[@]}" sh ./probe.sh` — or inline the assignments literally — `env SETB=1 BADJ=1 sh ./probe.sh`; NEVER from an unquoted scalar — `cfg="SETB=1 BADJ=1"; env $cfg sh ./probe.sh` — which under zsh passes ONE argument, sets a variable literally named `SETB` to `1 BADJ=1`, never sets `BADJ` at all, and still exits 0. `env $cfg[@]` is not the portable spelling either: measured, bash word-splits it into `SETB=1` and `BADJ=1[@]`, so the injection variable is set to a corrupted value, while zsh behaves exactly as with the bare `$cfg` — `BADJ` never set, exit 0. Everything you write — mutants, fixtures, scratch repos — goes under `<scratch>/pr<N>/<finding>/` and nowhere else; the checkout and any worktree are never write targets, though `git show`/`git archive` at a pinned ref read fine anywhere. Chain the directory change into the command, `cd "$D" && git …`, never `cd "$D"; git …`, so a failed `cd` cannot leave a `git` command running in the checkout — and bracket a fixture's own git with `git rev-parse --show-toplevel`: before `git init` it must NOT resolve to the host repository, and `fatal: not a git repository` (exit 128) is the usual pass, not a failure — an outer repository whose ignore rules cover your scratch dir is a pass too; before any `git commit` it must resolve to your scratch path, which catches a forgotten `git init` under any enclosing repository — compare resolved forms (`realpath`), since `--show-toplevel` can report a symlinked parent such as `/tmp` or a symlinked `$HOME` under its resolved name.* That last clause is the whole mechanism — a refuter left to reason its way to agreement rubber-stamps, and "apply only what survives" silently degrades into "apply everything in scope". Apply only what survives; a refuted one defers with the refutation in its body. **Out of scope the refuter decides only where the suggestion is filed — it defers either way, never applied.** Refuted → the closed `PR #<pr> review: the suggestion band, checked` record, never an open issue. Survived, or its refuter crashed or abstained → its own open issue labelled `needs-triage`, citing the verdict, or the run that crashed, in the body. There is no cap on these refuters; your final verdict (step 4) says how many you dispatched against out-of-scope suggestions. "In scope" means the ticket's scope, not merely the same files — and applying one still never licenses editing a file the ticket has no business in. **A finding in `unverified` whose refuters ran and crashed or abstained always defers, whatever its severity** — and which it is, you read off the finding's **`refutersDispatched`** and **`refutersInconclusive`**, never off severity and never off an empty vote list: `refutersDispatched` above zero with nothing decided means every refuter dispatched against it died or abstained, and `refutersInconclusive` counts the ones that abstained. Only a `survived` finding has been checked; severity says how much a finding would matter if true, never whether anything looked. **Deferring a crash is your move, and re-running it is not** — the review already re-dispatched every crashed refuter pair once, in-run, so a crash that reaches you crashed twice, and the result's `resume` field names the one move left, which is not yours: nothing replays a review that ran in a runner's kernel — it is reported, not acted on. So say *in the deferral* that its refuters crashed rather than that it went unchecked, and re-run nothing for it. **An abstention is not a crash** — a refuter that abstained ran and could not decide: defer and file the finding, citing the inconclusive runs each abstaining refuter named in its `reason`, and never describe its refuters as crashed. **A `suggestion` is also in `unverified`, for a different reason — `refutersDispatched` of zero, the 0-refuter budget the workflow gives that band by policy, so nothing looked *there* — and the scope split above, not this rule, covers it.**
14
14
  **Write every ruling to `<scratch>/dispositions-<your name>.json`, `<your name>` the `fix-pr-<pr>[-x]` you were dispatched as (standalone, `fix-pr-<pr>`) — the disposition record `dispositions-check.mjs` judges against the review result file before any finisher is dispatched.** It is `{"head": "<the review file's head>", "run": "<the run root's name in the review path>", "entries": [ … ]}` — `run` the `<run>` of the review path your prompt names, which the check holds against the one the PR's latest `reviewed=` names, so a record written against an earlier review of the same PR, a same-head one included, is a mismatch (standalone, with no ledger naming a run, leave it out): one entry per `survived` finding and per `unverified` finding, plus one per `refuted` finding you reverse. Each entry carries `bucket` (`survived|unverified|refuted`), `index` (its position in that bucket of the review file — stable, since a round's file never changes), `scope` (`in|out`), `claimKind` (`behavior|shape`) and `disposition` (`apply|defer`), and where they apply `reason`, `issue` (the number you filed it to or commented on), `verdictPath` (a suggestion's refuter verdict file, in scope and, above the claim bar, out of scope) and `remedyFiles` (the files its remedy names). A `refuted` entry carries `scope`, `claimKind` and `disposition` like every other entry, and a non-empty `reason` holding the evidence that reverses it; a missing or blank `reason` is a mismatch. The check reads scope off the diff before it reads your entry: a finding with no `line`, or on a line `git diff` touches from the PR's merge-base with `origin/main` to the review's `head`, is in scope whatever `scope` says, and only otherwise does the declared one stand. An in-scope `survived` finding deferred passes only with `reason` `false-rationale`, `mutual-exclusion`, `remedy-worse` or `remedy-outside-diff`. `remedy-outside-diff` — the remedy would edit a file the PR's diff does not touch — also needs `remedyFiles` to name at least one file absent from `git diff` from that merge-base to the review's `head`: none named, or every one in that diff, is a mismatch. A `critical` or `important` finding deferred for it goes to a human instead of passing: the script exits 1 with verdict `escalate`, `ledger.mjs dispatch` refuses the PR's finisher, and nothing retries it; a `suggestion` deferred for it passes. Any other reason, none, or a `survived` or `unverified` finding with no entry is a mismatch: the script exits 1 naming each violating entry's bucket, index and rule, and `ledger.mjs dispatch` refuses the PR's finisher. `disposition` has no `dismiss`: an in-scope `survived` finding verified correct, needing no change, is deferred with `reason` `false-rationale` and filed on the closed suggestion-band record — step 5's `PR #<pr> review: the suggestion band, checked`.
15
15
  3. **Run `checkCmd` and `testCmd` before you commit**, from the worktree, each copied verbatim — not a runner you picked. `checkCmd` is the Recipe's Check step and `testCmd` is the command your dispatcher handed you; **standalone, with no dispatcher to hand you them, they are the repo's own Check step and Test entrypoint**, read off the repo's Recipe cache (`derive-testcmd.sh <repo> check` prints the first, `derive-testcmd.sh <repo> test` the second). Read them off the repo, never invent one: "not a runner you picked" is what this step forbids, and on the standalone path nothing else defines the referent. With no usable Recipe cache (`derive-testcmd.sh` refuses), run the Recipe derivation step first — dispatch a `task` member, agent `fleet-recipe-deriver`, its prompt naming the main checkout's absolute path as `<repo>` and a scratch directory of its own; it proves all three commands in a throwaway worktree and writes the cache only on proof, and its `RECIPE NOT PROVEN` is a stop, reported with its reason. Never fall back to a runner of your own choosing. `tests 0` is a FAILED run, not a pass: a glob matching nothing still exits 0. **Zero is not the only no-work count.** A run reporting **0 passes with no failures** skipped everything it collected, and a count **materially below the whole suite** means you ran a partial tree — this suite reported `tests 937` when this line was written, so compare what you get against a full run rather than against zero. The number drifts; that is the safe direction, because a stale one produces a loud false red while its absence produces a silent false green. Red, zero-test, or either no-work count → fix it or move the finding to defer; never commit over it. Then commit and push — `~/.fleet/bin/fleet-run push-sync.mjs --branch <branch>`, which pushes the explicit refspec `HEAD:refs/heads/<branch>` and then moves the worktree holding `<branch>` to the pushed SHA, or names why it did not and exits 3 with the push landed: this step also runs from a `--detach` worktree (`run-team/SKILL.md`'s worktree-recreation form), where a bare `git push` exits 128 (`fatal: You are not currently on a branch`), any push whose destination is `HEAD` rather than a full or branch refname (`-u` or not, forced or not) exits 1 (`error: The destination you provided is not a full refname`), and a refspec push alone leaves the claim worktree's `refs/heads/<branch>` at its old tip — and report the test result alongside the SHA. **Then reconcile the PR body with what you actually did.** It merges into the permanent record and nothing downstream re-derives it: your commit messages are yours to fix and usually get fixed, the body is neither. Removing a change, or reversing one, leaves the body asserting work the diff no longer contains. Measured twice in one run — one body kept asserting a calibration its own fix had just deleted as false, another kept claiming a hunk the fix had removed as "this diff owns it" — both caught by a finisher's reading rather than by any rule, and both would otherwise have merged intact. `gh pr edit <pr> --body-file <path>`, and re-read the body against the final diff rather than against your memory of it. **Never `--no-verify` on a commit you push, or on the push itself.** The fleet runs in repos it knows nothing about: it must not assume a pre-commit hook exists, and must never bypass one that does on what reaches the branch — a hook that fails is a finding to report, not an obstacle. Nothing re-reviews what you commit here, so this run is the only gate between your edit and a merge.
16
+ **Under the fleet, run the two through `recipe-check.mjs`, not one by one:** from the worktree, after `git add` and before the commit, `~/.fleet/bin/fleet-run recipe-check.mjs --member <your name> --testCmd "<testCmd>" --reports <scratch>/reports` — `<your name>` the `fix-pr-<pr>[-x]` you were dispatched as, and `<testCmd>` the whole command you were handed, one quoted argument. It runs the Recipe's Check step, which is `checkCmd`, then `<testCmd>` exactly as handed, against the staged tree, and records both results beside your report. The record is keyed to the tree, so run it again after any content change or rebase — a message-only amend keeps it valid — and the controller refuses an `applied` report whose head's tree has no green record. A non-zero exit is red; exit 75 is no test result — no slot was free and nothing ran — so run it again. **Standalone, with no report to settle against,** run `checkCmd` and `testCmd` yourself, each copied verbatim.
16
17
  4. **Under the fleet, do not hold this wait.** The controller owns a persistent CI Monitor and dispatches a finisher once your report has arrived and CI is green — so push, then report to the controller a **final verdict** (every specialist you dispatched + its outcome + your apply/defer adjudication + how many refuters you dispatched against out-of-scope suggestions + the pushed SHA) and stop. A specialist that has not reported to you is not a verdict line — `hub send` it by name for its report, then ask the controller, before ruling; see **Specialists**. The controller keys "review complete" on that verdict, **never on you merely going idle** — a slow specialist can still be running when your turn ends, and finishing off idle-alone ships a premature label (observed: a PR labelled while its contract-test specialist was still running and about to surface a vacuous pin). A turn-based reviewer re-reading `gh pr checks` each idle cycle rebuilds its whole context for nothing the Monitor lacks. **Standalone (no controller): watch** the run until the diff-validating jobs are green (bind via `ci-state.mjs` below); fix a **genuine** failure and repeat from 3. **Staleness is not a failure:** a `rebase-check` red or heavy jobs `skipped` **solely from a non-zero behind-count** never clears by waiting and must not be rebased away here — see **`skipped` is not `passed`** and **Do NOT rebase to label** below for what it looks like and why. Stop watching and go to 6. A turn-based reviewer that "waits for green" on a behind PR stalls forever and ends its turn without labelling. **`ci-state.mjs` returns `verdict: "no-ci"`** → there is no run to watch, so don't: go straight to 6 and let that step's `--declare-no-ci` branch decide.
17
18
  5. File each deferred finding: `gh issue create --label needs-triage` with the finding, `file:line`, why deferred, `Deferred from PR #<pr> review`, and **the finding's `dimension` in the issue body** — the review returns it on every finding, and a backlog that does not carry it cannot be attributed to the specialist that generated it. **The body also carries the evidence triage needs: the refuter's verdict — the `verdictPath` reason, or the review's votes — and the candidate remedy.** **Every issue you create is labelled `needs-triage`; only triage sets `ready-for-agent`** — and the label is never omitted; an unlabelled issue is invisible to both `candidates.mjs --require-label` and the cockpit's pool query, reachable only by a human. **A confirmed defect does not settle its remedy**, so confirming one earns it no other label: a confirmed defect with the remedy still open files `needs-triage`, and so does a finding you are unsure is broken at all. **A finding a refuter CHECKED and did not survive is neither** — it is not a confirmed defect, and you are not unsure whether anything is broken: you measured that nothing is. Refutations go as **one issue per review, titled `PR #<pr> review: the suggestion band, checked`, labelled `wontfix`, and CLOSED** — a run that files them open instead has to be corrected afterwards, as one was on 2026-08-27. Left open they read as queued agent work and rot into filing artifacts; a measured triage pass found a quarter of its `needs-triage` backlog was refuted records, bulk-closable by title shape. Closed is still a durable home — `check` reads the tracker at `--state all`, so a future run re-deriving the finding lands on the evidence rather than re-litigating it. Split the band only where an entry is **not** a refutation: a residual the refuter surfaced, or an out-of-scope finding its refuter let survive or never decided, is real deferred work — and real deferred work earns its own open issue only past a second bar. **Worth a claim: a finding whose own claim is that correct code could be shaped better — style, naming, layout, redundancy, a micro-simplification — never gets its own open issue.** **Neither does a gap in a prose guard — a test holding prose to its wording — unless something acts on the guarded text: an agent follows it as an instruction (a skill, a command, an agent definition, a script's header or usage text, `AGENTS.md`), or a program other than its own guard reads it.** Whether anything does is your judgement, as `claimKind` is, and a gap below this bar is recorded `claimKind: shape`. A gap in a guard's own code — a slow pattern, a dead branch, an unchecked spawn result — takes the stakes of the prose it guards, and a helper several guards share takes the highest of theirs. A missed wording already in the tree is no guard gap — that prose is wrong — and neither is an input already in the tree that trips a guard's code; each files on its own merits. Once the prose is corrected, the observed wording may join the guard's literal ban, never a reader built to catch wordings nobody has written. A below-bar finding's only open question is "is this worth doing?", which answers itself under the repriced triage bar: measured 2026-08-15→31, 133 issues were triage-closed `wontfix` in sixteen days, 121 of them review deferrals, mostly this shape. Append it to the same closed record issue under a `Below the claim bar` heading — `file:line`, dimension, the claim, and a re-open trigger per entry. Closed is a durable home for these too: `check` reads `--state all`, so a run re-deriving the finding lands on the record instead of re-filing — and a later review returning the same finding as `survived`, or a maintainer hitting it, is the promotion signal: file it open then, citing the record. **An in-scope rediscovery step 2 applied is that same promotion signal, and it files nothing** — so the record carries no mark unless you write one: run `check` over each finding step 2 applied as well, and where its tracker rows put one on a `Below the claim bar` entry, comment on that record issue, opening `Promoted — applied, not filed`, and name the entry, that its refuter let it through, and the commit carrying the fix. That comment is the promotion mark this path leaves, and it is **not** a cross-reference — measured on this tracker, a comment mints `cross-referenced` on the issue its own text *names*, never on the issue it sits under (a comment citing a second issue landed on that issue's timeline and nowhere else), so the fixed opening is what carries the signal instead. **The bar reads the finding's claim, never its review band** — a finding that alleges wrong behavior, whatever band it sat in, `unverified`-with-crashed-refuters included, is above this bar and files open, `needs-triage`, which is why a band cannot carry this decision. Do **not** reach for phase 0's **decided?** test here. That is a *consumption* gate, and whether a filed issue is decided enough to reach it is triage's call, never the filer's. **The cost of this rule is watched:** open `needs-triage` issues citing `Deferred from PR` above 40 on 3 consecutive run dates send the filing rule back to the maintainer — batch triage, a fleet triage role, or a different bar. **Dedupe through `~/.fleet/bin/fleet-run ledger.mjs check "<subject>"`, never a bare `gh issue list --search`** — the duplicate class that guard exists to catch was filed from *here*: the ledger row for the finding rediscovered five times in one measured run carries a reviewer's own source tag, `(review-pr-108)`. `check` reads this run's filed list *and* the tracker at `--state all`, so a closed duplicate still counts. Exit **1** is already filed in this run; exit **3** is a clean ledger with matching tracker rows that score against the subject — read the ones it prints and comment on the existing follow-up rather than filing a second issue. **Exit 0 is not automatically "safe to file"**: it covers `clean`, `soft-hit` and `unverified` alike, and an unreachable `gh` degrades to a ledger-only answer that says `TRACKER NOT CHECKED`, so read the stdout `verdict` to tell a tracker that was searched and clean from one nobody read — under `unverified`, search it yourself before filing — or, for the applied-promotion comment above, before treating a tracker nobody could read as a reason to skip it. **`soft-hit` is the answer that costs most to misread**: it means related rows were found and none of them was established as a duplicate — a near-miss above the floor, or tracker rows the scorer rates 0.00 — so read the rows it printed and decide, and never treat that exit 0 as permission. Exit **2** is a usage error, meaning nothing was checked at all: fix the invocation and re-run, never read it as a duplicate. Full exit-code and `verdict` semantics live in `$(~/.fleet/bin/fleet-run --root)/skills/run-team/references/ledger.md`, which `SKILL.md`'s **Run ledger** section points at — read them there rather than restating them here. **The guard dedupes, it never drops:** a duplicate becomes a comment on the issue that already covers it, never a dropped finding. **Record every issue you create, at once:** immediately after each `gh issue create`, run `~/.fleet/bin/fleet-run ledger.mjs filed <N> "<subject>"` — `<N>` the number `gh issue create` printed, and **the same subject string you passed to `check`**, so the next `check` for that finding meets it in the filed list instead of scoring a rewording. Without it the guard's ledger half never holds a row, and its exit **1** can never fire. If `filed` fails, retry it once; if it fails again, leave the issue alone — it exists and is correct — and report it as `unrecorded: #N <subject>`, so the controller runs `filed` for it. Report `filed: #N <subject>` for every issue you created — under the fleet, in your report to the controller. **The one window the guard cannot see:** `check` → `gh issue create` → `filed` is three commands, and the ledger's lock covers each alone, so two filers can both read `clean` in the seconds before either records. That gap is accepted, never a reason to skip `filed`. Post the numbers as one PR comment.
18
19
  **A duplicate that should hold an open deferral is a comment, never a relabel.** Where the guard lands a finding whose home is an open issue on an existing one that is open, cite the refuters' verdict — or the review's votes — in the comment you leave there, and change no label. Never relabel `ready-for-agent` down to `needs-triage`: a `ready-for-agent` issue already holds a `needs-triage` finding, because triage already promoted it, and a later run's crashed refuters are no reason to send it back. A closed one cannot hold it: file a new open issue citing it, as the promotion rule above does for the closed record.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@feigi/fleet-ctl",
3
- "version": "3.82.12",
3
+ "version": "3.82.14",
4
4
  "description": "Agent fleet: run-team controller, merge bot, PR reviewer, and the ticket pipeline they share",
5
5
  "license": "Apache-2.0",
6
6
  "repository": {
@@ -118,7 +118,10 @@
118
118
  // row: `pull.mjs next` skips it, `next --head` would start the
119
119
  // ticket over, so the next head fills the slot. Nor is it counted
120
120
  // in `unclaimed=` or toward the short-queue refresh, so a
121
- // shortlist of ended heads refreshes. A record from another
121
+ // shortlist of ended heads refreshes. A Pull that left on an
122
+ // exclusion (its reason starts `excluded ·`) is no such end: its
123
+ // head is counted and Pulled again once the exclusion lifts. A
124
+ // record from another
122
125
  // phase-0 session, or one unreadable or absent, is the fresh row:
123
126
  // `pull.mjs next` starts or resumes it.
124
127
  // session The listing of the session directory omp writes one
@@ -139,7 +142,7 @@
139
142
  // the ledger; main() does the I/O. Split so the guard table and the reading are
140
143
  // both unit-testable without a network.
141
144
 
142
- import { parseMember, parseToken, premisesOf, rowNums, nextRetry, readRetired, REVIEW, REVIEWED } from "./ledger-grammar.mjs";
145
+ import { parseMember, parseToken, premisesOf, rowNums, nextRetry, readRetired, pullEnded, REVIEW, REVIEWED } from "./ledger-grammar.mjs";
143
146
 
144
147
  // The implementer and reviewer rows' TARGET is the In-flight bound; the merge
145
148
  // bot's is 1. Availability of work belongs in the ACTION, not the target: a
@@ -273,8 +276,10 @@ const QUESTION_NUMBERS = { staleness: "Q1", close: "Q1b", decided: "Q2", collisi
273
276
  * PULL row: `{kind: "pending", qid, stale}`, `{kind: "dispatched", text}` with
274
277
  * the text the Pull's own `ledger.mjs row` wrote (null when it recorded none),
275
278
  * `{kind: "ended"}` for a Pull that left or was released, or null for the
276
- * fresh row. `since` is the file's mtime and `session` this run's phase-0
277
- * session, null when the receipt names none.
279
+ * fresh row. A Pull that left on an Exclusion (its reason starts `excluded ·`)
280
+ * is the fresh row too: it is no end, since the head claims a PULL row again
281
+ * once the tick's own lift logic admits it. `since` is the file's mtime and
282
+ * `session` this run's phase-0 session, null when the receipt names none.
278
283
  */
279
284
  export function pullOf(record, { session, since, now, staleMinutes }) {
280
285
  if (record === null || typeof record !== "object" || Array.isArray(record)) return null;
@@ -283,7 +288,14 @@ export function pullOf(record, { session, since, now, staleMinutes }) {
283
288
  if (session !== null && record.session !== session) return null;
284
289
  // pull.mjs's `next` skips a Pull that ended in this run, and `next --head`
285
290
  // would start the ticket over: the head is no one for a PULL row to name.
286
- if (record.status === "left" || record.status === "released") return { kind: "ended" };
291
+ // `pullEnded` is the one test both read. A Pull that left on an Exclusion is
292
+ // no such end, so it falls through to the fresh row. While a `behind-pr:#M`
293
+ // premise stands, the ledger claims the head and it never reaches here; a
294
+ // `behind-issue` or branch-named premise only the refreshed shortlist keeps
295
+ // out, by dropping its ticket (unclaimed), so after a failed refresh the
296
+ // head can get a PULL row that `pull.mjs` leaves again. Once the premise
297
+ // lifts, `next` takes it again.
298
+ if (pullEnded(record)) return { kind: "ended" };
287
299
  if (record.status === "running" && typeof record.pending?.qid === "string") {
288
300
  return { kind: "pending", qid: record.pending.qid, stale: now - since > staleMinutes * 60_000 };
289
301
  }
@@ -308,7 +320,8 @@ function pullAction(n, p) {
308
320
  }
309
321
 
310
322
  // The heads a PULL row could name: a head whose Pull ended in this run takes
311
- // no slot, and the next head takes it. Order kept, so the slots fill oldest first.
323
+ // no slot, and the next head takes it. A Pull that left on an Exclusion is no
324
+ // such end (pullOf). Order kept, so the slots fill oldest first.
312
325
  function pullable(heads, pulls) {
313
326
  return heads.filter((n) => pulls?.get(n)?.kind !== "ended");
314
327
  }
@@ -366,7 +379,8 @@ function implementers(s) {
366
379
  if (heads.length) return heads.slice(0, s.bound - s.inFlight).map((n) => one(pullAction(n, s.pulls?.get(n)), { acts: true }));
367
380
 
368
381
  // Nothing to Pull even after a refresh: no unclaimed head, or only heads
369
- // whose Pull ended in this run, which `pull.mjs next` skips. `SUGGEST /triage` asks a
382
+ // whose Pull ended in this run, which `pull.mjs next` skips — a Pull that
383
+ // left on an Exclusion is no such end (pullOf). `SUGGEST /triage` asks a
370
384
  // MAINTAINER to tick tickets, and on the unattended night the heartbeat
371
385
  // exists for there is nobody to ask — so it prints (the fold shows it once)
372
386
  // but is not actionable, or it would pin the interval at the base all night.
@@ -1195,10 +1209,12 @@ export function deriveRun({ rows, dispatched, drain, retired = [] }, prs, closed
1195
1209
  // `behind-issue` or branch-named premise) is different: its row is rewritten
1196
1210
  // only when a Pull dispatches the ticket (shortlist.mjs's own header, §3),
1197
1211
  // never on its own, so once shortlist.mjs's live probe has re-admitted the
1198
- // ticket to these entries, that stale row no longer blocks it.
1212
+ // ticket to these entries, that stale row no longer blocks it. A row naming no
1213
+ // premise has nothing to lift: it claims its ticket for good, as `pull.mjs
1214
+ // next` and shortlist.mjs read it.
1199
1215
  export function unclaimed(entries, run) {
1200
1216
  const unverifiable = new Set(run.excluded
1201
- .filter((e) => e.premises.every(({ kind, target }) => kind !== "pr" || !isDigits(target)))
1217
+ .filter((e) => e.premises.length > 0 && e.premises.every(({ kind, target }) => kind !== "pr" || !isDigits(target)))
1202
1218
  .map((e) => e.n));
1203
1219
  return entries.map((e) => e.n).filter((n) => !run.claimed.has(n) || unverifiable.has(n));
1204
1220
  }
@@ -1226,8 +1242,9 @@ export function parseShortlist(text) {
1226
1242
 
1227
1243
  // Why this tick refreshes the shortlist, or null. `unclaimed` counts the
1228
1244
  // heads a PULL row could name, so a head whose Pull ended in this run is not
1229
- // in it. The premise-lifted
1230
- // trigger costs gh calls, so main() asks it only when these answer null.
1245
+ // in it — a Pull that left on an Exclusion is no such end (pullOf). The
1246
+ // premise-lifted trigger costs gh calls, so main() asks it only when these
1247
+ // answer null.
1231
1248
  // Nothing refreshes while the bound holds (`held`, n ≥ B, whichever HOLD row
1232
1249
  // prints): a refresh then cannot feed a Pull, and the first tick back under
1233
1250
  // the bound refreshes and Pulls in the same tick, so nothing is lost.
@@ -2168,8 +2185,8 @@ function main() {
2168
2185
  if (scratch === null) console.error(`${NAME}: report files and Pull records not checked — no scratch in the phase-0 receipt and no --scratch`);
2169
2186
  // Each head's Pull record read, not only the heads a free slot names: a head
2170
2187
  // whose Pull ended gives its slot to the next, so the heads past the slots
2171
- // can fill one. The session it is judged against is the receipt's, as
2172
- // pull.mjs judges it.
2188
+ // can fill one. A Pull that left on an Exclusion is no such end (pullOf). The
2189
+ // session it is judged against is the receipt's, as pull.mjs judges it.
2173
2190
  const runSession = receipt.read.state === "ok" && receipt.read.receipt.session !== "" ? receipt.read.receipt.session : null;
2174
2191
  const pullsOf = (hs) => scratch === null ? new Map()
2175
2192
  : readPulls(scratch.root, hs, { session: runSession, now: Date.now(), staleMinutes: pullStaleMinutes });
@@ -2186,7 +2203,8 @@ function main() {
2186
2203
  let fresh = null;
2187
2204
  // Short means fewer heads than B that a PULL row could name: `pull.mjs next`
2188
2205
  // skips a head whose Pull ended in this run, so counting it would hold back
2189
- // the refresh that finds the head to take its slot.
2206
+ // the refresh that finds the head to take its slot. A Pull that left on an
2207
+ // Exclusion is no such end (pullOf).
2190
2208
  const counted = pullable(heads, pulls).length;
2191
2209
  // While the bound holds a refresh cannot feed a Pull, so none of its
2192
2210
  // triggers runs: the first tick back under the bound refreshes and Pulls in
@@ -609,6 +609,20 @@ export function premisesOf(row) {
609
609
  return [...m[1].matchAll(PREMISE)].map(([, kind, target]) => ({ kind, target }));
610
610
  }
611
611
 
612
+ /** The prefix of the `outcome.reason` of a Pull that ended on an Exclusion. pull.mjs writes it on every path that
613
+ * ends a Pull on an Exclusion naming a premise; a row naming no premise leaves the row's own text as the reason,
614
+ * which carries the prefix only when the row does — that Exclusion never lifts, so neither reader takes its head
615
+ * again whatever the reason says. The fleet tick and `pull.mjs next` read it to tell such a Pull from one that ended
616
+ * for good: taken, relabelled, closed or released. */
617
+ export const EXCLUDED_REASON = "excluded ·";
618
+
619
+ /** Whether a Pull's `outcome.reason` says it ended on an Exclusion. */
620
+ const exclusionEnded = (reason) => typeof reason === "string" && reason.startsWith(EXCLUDED_REASON);
621
+
622
+ /** Whether a Pull record ended for good: released, or left for any reason but an Exclusion. The fleet tick's
623
+ * pullOf and `pull.mjs next` both read a Pull's end through it, so the two cannot disagree. */
624
+ export const pullEnded = (record) => record.status === "released" || (record.status === "left" && !exclusionEnded(record.outcome?.reason));
625
+
612
626
  export const ROWS = "## Rows";
613
627
  export const DISPATCHED = "## Dispatched";
614
628
  export const FILED = "## Filed";
@@ -56,7 +56,7 @@ import { deriveRun, LedgerError, labelOffMember, HELD, CONFLICT_HOLD } from "./f
56
56
  import { stateFileIn, readState, writeState, assessBeat, stallsAt } from "./fleet-state.mjs";
57
57
  import { processSource, ancestry, controllerOf, judgeController, ProcUnreadable } from "./proc.mjs";
58
58
  import { attemptLock, releaseLockFile, reapPathOf } from "./pid-lock.mjs";
59
- import { readReportIn, reportsDir, reportFamily, defaultScratch } from "./report-files.mjs";
59
+ import { readCheckRecordIn, readReportIn, reportsDir, reportFamily, defaultScratch } from "./report-files.mjs";
60
60
 
61
61
  const NAME = "ledger";
62
62
  // The plugin's own agent definitions — the directory tier-check.mjs reads
@@ -2250,9 +2250,12 @@ function recordFiled(id, subject) {
2250
2250
  // checked before anything is written:
2251
2251
  //
2252
2252
  // impl-N=PR#M verify-sha.sh <branch> <head> exits 0; PR M
2253
- // reads OPEN and its closingIssuesReferences name N
2253
+ // reads OPEN and its closingIssuesReferences name N;
2254
+ // the Check-step record (below) holds for <head>
2254
2255
  // impl-N=bailed bailCause is not null; the receipt names it
2255
- // fix-pr-M=applied:<head> origin's refs/heads/<branch> is <head>
2256
+ // fix-pr-M=applied:<head> origin's refs/heads/<branch> is <head>, fetched
2257
+ // by verify-sha.sh; the Check-step record (below)
2258
+ // holds for <head>
2256
2259
  // fix-pr-M=no-op origin's refs/heads/<branch> is the head PR M's
2257
2260
  // latest reviewed= names, as the tick folds it
2258
2261
  // finisher-pr-M=labelled PR M's labels carry ready-to-merge, and so does
@@ -2261,6 +2264,16 @@ function recordFiled(id, subject) {
2261
2264
  // evidence is not empty
2262
2265
  // merge-bot-n=done every merged[].pr reads MERGED
2263
2266
  //
2267
+ // THE CHECK-STEP RECORD, for `impl-N=PR#M` and `fix-pr-M=applied:<head>`:
2268
+ // recipe-check.mjs writes `<reports>/<member>.check.json` on the member's
2269
+ // staged tree, and settle requires that it exists and parses, that the Check
2270
+ // step and the Test entrypoint both exited 0 in it, and that its `tree` is
2271
+ // `<head>^{tree}`, so a message-only amend keeps it valid while any content
2272
+ // change or rebase does not. Settle runs neither command: the record is the
2273
+ // member's word, at the trust level of its report. A repository whose Recipe
2274
+ // cache derive-testcmd.sh refuses has no gate. A `<head>^{tree}` git cannot
2275
+ // read is "could not look", never a tree mismatch.
2276
+ //
2264
2277
  // A `failed` report claims no state, so it settles `=failed` unchecked. A
2265
2278
  // fix-applier's `refuted` deferral claims one more thing: that its disposition
2266
2279
  // record gives the reversal a reason, which is the text `## Ruled` gets.
@@ -2298,6 +2311,7 @@ function mismatch(msg) {
2298
2311
  async function runSettleFromReport() {
2299
2312
  const usage = "usage: ledger.mjs settle <member> --from-report [--reports <dir>]";
2300
2313
  const verifySha = join(dirname(fileURLToPath(import.meta.url)), "verify-sha.sh");
2314
+ const deriveTestcmd = join(dirname(fileURLToPath(import.meta.url)), "derive-testcmd.sh");
2301
2315
  const ready = "ready-to-merge";
2302
2316
  // The bound on each child a check runs: generous, because verify-sha.sh
2303
2317
  // fetches, and still a bound, because the child may never answer at all.
@@ -2370,6 +2384,7 @@ async function runSettleFromReport() {
2370
2384
  }
2371
2385
  return r;
2372
2386
  };
2387
+ const verifyShaOf = (branch, sha) => look(`verify-sha.sh ${branch} ${sha}`, "sh", [verifySha, branch, sha], [0, 1]);
2373
2388
  // A `gh pr view --json <fields>` answer: an object whose every requested
2374
2389
  // field has the type that field has. Anything else was not what was asked
2375
2390
  // for, so it could not look.
@@ -2405,6 +2420,32 @@ async function runSettleFromReport() {
2405
2420
  checks.push({ name, ok });
2406
2421
  return ok;
2407
2422
  };
2423
+ // The Recipe gate, for the two reports that name a pushed head: the member's
2424
+ // Check-step record must show the Recipe's Check step and the Test
2425
+ // entrypoint both exited 0 against the very tree `head` holds. Nothing here
2426
+ // runs either command — the record is the member's word, at the trust level
2427
+ // of its report. A repository whose Recipe cache derive-testcmd.sh refuses
2428
+ // (exit 1: absent, unproven, invalid) has no Check step to have run, so no
2429
+ // gate applies; any other answer from it could not look. `head`'s commit
2430
+ // object must be local when the tree is read: `fetchHead`, when given, puts
2431
+ // it there, and runs only once a gate applies.
2432
+ const recipeGate = (head, fetchHead) => {
2433
+ for (const field of ["check", "test"]) {
2434
+ if (look(`derive-testcmd.sh . ${field}`, "sh", [deriveTestcmd, repoDir(), field], [0, 1]).status === 1) return;
2435
+ }
2436
+ const rec = readCheckRecordIn(reports, member);
2437
+ const label = rec.state === "absent" ? `a Check-step record exists at ${rec.path}`
2438
+ : rec.state === "ok" ? `Check-step record ${rec.path} exists and parses`
2439
+ : `Check-step record ${rec.path} parses: ${rec.violation}`;
2440
+ if (!check(label, rec.state === "ok")) return;
2441
+ const { check: step, test, tree } = rec.record;
2442
+ const exited = (c) => (c.exitCode === null ? "not run" : `exit ${c.exitCode}`);
2443
+ check(`the recorded Check step exited 0 (recorded: ${exited(step)})`, step.exitCode === 0);
2444
+ check(`the recorded Test entrypoint exited 0 (recorded: ${exited(test)})`, test.exitCode === 0);
2445
+ fetchHead?.();
2446
+ const headTree = look(`git rev-parse --verify ${head}^{tree}`, "git", ["rev-parse", "--verify", `${head}^{tree}`]).stdout.trim();
2447
+ check(`the recorded tree ${tree} is ${head}'s tree ${headTree}`, tree === headTree);
2448
+ };
2408
2449
  const ruledLines = [];
2409
2450
  let outcome;
2410
2451
  if (live.family === "impl") {
@@ -2412,8 +2453,9 @@ async function runSettleFromReport() {
2412
2453
  if (report.pr === null) invalid('$.pr: null is not a PR number, with outcome "pr"');
2413
2454
  if (report.head === null) invalid('$.head: null, with outcome "pr"');
2414
2455
  outcome = `PR#${report.pr}`;
2415
- const sha = look(`verify-sha.sh ${report.branch} ${report.head}`, "sh", [verifySha, report.branch, report.head], [0, 1]);
2456
+ const sha = verifyShaOf(report.branch, report.head);
2416
2457
  check(`verify-sha.sh ${report.branch} ${report.head} exits 0`, sha.status === 0);
2458
+ recipeGate(report.head);
2417
2459
  const pr = prView(report.pr, "state,closingIssuesReferences");
2418
2460
  check(`PR #${report.pr} reads OPEN`, pr.state === "OPEN");
2419
2461
  check(`PR #${report.pr} closes #${live.number}`, pr.closingIssuesReferences.some((c) => c?.number === live.number));
@@ -2426,6 +2468,12 @@ async function runSettleFromReport() {
2426
2468
  outcome = `applied:${report.head}`;
2427
2469
  const head = remoteHead(report.branch);
2428
2470
  check(`origin refs/heads/${report.branch} is ${report.head}`, head === report.head);
2471
+ if (head === report.head) {
2472
+ // verify-sha.sh is the fetch that puts the head's commit object here,
2473
+ // which the tree read needs; its exit 2 is a fetch that failed or an
2474
+ // object that is not there, so it could not look.
2475
+ recipeGate(report.head, () => verifyShaOf(report.branch, report.head));
2476
+ }
2429
2477
  } else if (report.outcome === "no-op") {
2430
2478
  outcome = "no-op";
2431
2479
  let fold;
package/scripts/pull.mjs CHANGED
@@ -8,7 +8,9 @@
8
8
  // Reached through the Resolver and run from the MAIN checkout (a linked
9
9
  // worktree refuses). `next` starts a Pull on the shortlist head — `--head`, else
10
10
  // the first `.fleet/shortlist.json` entry with no `impl-` row, no live
11
- // `excluded` row and no Pull of its own already ended in this phase-0 session — or resumes the
11
+ // `excluded` row and no Pull of its own already ended in this phase-0 session
12
+ // (a Pull that ended on an exclusion whose premise has since lifted is not
13
+ // ended in this sense, and its head is taken again) — or resumes the
12
14
  // one in progress for `--head`; `answer` records one answer and resumes. Both
13
15
  // run until the next question or the end of the Pull, and both are safe to
14
16
  // run again: the state is on disk after every step.
@@ -132,7 +134,7 @@ import { isDigits, makeDie } from "./arg.mjs";
132
134
  import { FleetDirUnresolvable, fleetFile } from "./fleet-dir.mjs";
133
135
  import { gitEnv } from "./git-env.mjs";
134
136
  import { isCLI } from "./is-cli.mjs";
135
- import { memberTokens, premisesOf, tierValues } from "./ledger-grammar.mjs";
137
+ import { EXCLUDED_REASON, memberTokens, premisesOf, pullEnded, tierValues } from "./ledger-grammar.mjs";
136
138
  import { sessionFromReceipt } from "./phase0-receipt.mjs";
137
139
  import { briefPaths, briefText, outOfScope, strandedRuling } from "./ticket-router.mjs";
138
140
 
@@ -1133,7 +1135,7 @@ class Pull {
1133
1135
  }
1134
1136
  const r = this.script("exclude", "ledger.mjs", ["row", String(st.ticket), `excluded · ${token}`]);
1135
1137
  if (r.status !== 0) return this.stop(withText(`ledger.mjs row failed (${r.how})`, r));
1136
- return this.leave(`excluded · ${token}`);
1138
+ return this.leave(`${EXCLUDED_REASON} ${token}`);
1137
1139
  }
1138
1140
  }
1139
1141
 
@@ -1196,7 +1198,7 @@ function heldOut(p, n) {
1196
1198
  throw new Refusal(`#${n}: the premise of its exclusion could not be read, so the exclusion stands: ${standing.unread} — run again once gh answers`);
1197
1199
  }
1198
1200
  if (standing.token === null) return row.slice(rowKey(row).length).trim();
1199
- return `excluded · ${standing.token}${standing.state === null ? "" : ` ${standing.state}`}`;
1201
+ return `${EXCLUDED_REASON} ${standing.token}${standing.state === null ? "" : ` ${standing.state}`}`;
1200
1202
  }
1201
1203
 
1202
1204
  // The phase-0 session names the run a Pull belongs to: the persistent scratch
@@ -1235,7 +1237,8 @@ function shortlistHead(p, run) {
1235
1237
  continue;
1236
1238
  }
1237
1239
  const ended = readPull(p.statePath(n));
1238
- if (ended !== null && (ended.status === "left" || ended.status === "released") && (run === null || ended.session === run)) continue;
1240
+ // A Pull that left on an exclusion whose premise has lifted — checked above — is not an end: the head is taken again.
1241
+ if (ended !== null && pullEnded(ended) && (run === null || ended.session === run)) continue;
1239
1242
  return n;
1240
1243
  }
1241
1244
  if (unreadable.length > 0) {