@feigi/fleet-ctl 3.24.39 → 3.24.40
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/scripts/fleet-tick.mjs +12 -11
- package/skills/run-team/SKILL.md +12 -7
package/package.json
CHANGED
package/scripts/fleet-tick.mjs
CHANGED
|
@@ -571,7 +571,7 @@ export function deriveRun({ rows, dispatched, drain }, prs, closed = new Set(),
|
|
|
571
571
|
// `reviewed=` — one read while no hold stood unresolved. The one read
|
|
572
572
|
// while a hold did is the conflict fix-applier `ledger.mjs dispatch` named
|
|
573
573
|
// a `fleet-implementer-<cell>`: it rebases and never sees the review file,
|
|
574
|
-
// so it clears the hold and answers no
|
|
574
|
+
// so it clears the hold and answers no finding. Each fix-applier
|
|
575
575
|
// does one of those jobs once, so its landing folds once per PR
|
|
576
576
|
// (`fixLanded`), however many copies of its token the rows carry.
|
|
577
577
|
// `fixMembers`: every fix-applier on this PR, wherever its token sits —
|
|
@@ -601,7 +601,7 @@ export function deriveRun({ rows, dispatched, drain }, prs, closed = new Set(),
|
|
|
601
601
|
const t = parseToken(tok);
|
|
602
602
|
if (t) {
|
|
603
603
|
note(t, where, pr);
|
|
604
|
-
// A settled `failed`/`killed` fix-applier leaves
|
|
604
|
+
// A settled `failed`/`killed` fix-applier leaves review findings or a
|
|
605
605
|
// conflict unfixed and no successor dispatched — the PR stays fix-due
|
|
606
606
|
// for a `-b` replacement. Only a live attempt, or one that actually
|
|
607
607
|
// landed (`applied:`/`no-op`), holds it off. Read the outcome off the
|
|
@@ -613,7 +613,7 @@ export function deriveRun({ rows, dispatched, drain }, prs, closed = new Set(),
|
|
|
613
613
|
// must not un-settle what actually landed. Which job a landed one did
|
|
614
614
|
// is read off where its token sits:
|
|
615
615
|
// after an unresolved hold it was the conflict fix-applier and clears
|
|
616
|
-
// that hold; otherwise it answered the latest review's
|
|
616
|
+
// that hold; otherwise it answered the latest review's findings. A
|
|
617
617
|
// hold reopens `conflictOpen` below and a `reviewed=` resets
|
|
618
618
|
// `reviewFixed`, so only a fix-applier after the latest of each ever
|
|
619
619
|
// counts. Only ONE copy says where: the first in-place settled one,
|
|
@@ -621,7 +621,7 @@ export function deriveRun({ rows, dispatched, drain }, prs, closed = new Set(),
|
|
|
621
621
|
// folding again would land the one member twice: a stale bare copy
|
|
622
622
|
// after the hold its member's in-place copy preceded clearing that
|
|
623
623
|
// hold, or a second copy after the first cleared the hold answering
|
|
624
|
-
//
|
|
624
|
+
// findings the conflict fix-applier never read. Liveness is not read
|
|
625
625
|
// here at all: a bare copy read before a later row settles its member
|
|
626
626
|
// reads unsettled at that point, so `fixMembers` is judged once every
|
|
627
627
|
// row has been read. A copy reaching this branch has just been
|
|
@@ -772,15 +772,16 @@ export function deriveRun({ rows, dispatched, drain }, prs, closed = new Set(),
|
|
|
772
772
|
// The in-flight reviews of PRs the open list does not carry: the ones
|
|
773
773
|
// `finished` could retire, so the caller asks gh about these and no others.
|
|
774
774
|
reviewsOffList: reviewing.filter(([n]) => !open.has(n)).map(([n]) => n).sort(asc),
|
|
775
|
-
// A returned review whose
|
|
776
|
-
//
|
|
777
|
-
//
|
|
778
|
-
//
|
|
779
|
-
//
|
|
780
|
-
//
|
|
775
|
+
// A returned review whose survived or unverified findings no review
|
|
776
|
+
// fix-applier has answered — `ledger.mjs dispatch` refuses a finisher
|
|
777
|
+
// on either until one has — a conflict hold no fix-applier has cleared,
|
|
778
|
+
// or a dispositions mismatch no retry has answered — on a PR still open,
|
|
779
|
+
// with no fix-applier working it and no newer review running. The first
|
|
780
|
+
// two are answered apart here: a landed conflict fix-applier lifts the
|
|
781
|
+
// hold and leaves findings it never read due for a review one.
|
|
781
782
|
fixDue: [...byPr.entries()]
|
|
782
783
|
.filter(([n, st]) => open.has(n)
|
|
783
|
-
&& ((st.survived > 0 && !st.reviewFixed) || conflictHeld(st) || mismatchDue(st))
|
|
784
|
+
&& (((st.survived > 0 || st.unverified > 0) && !st.reviewFixed) || conflictHeld(st) || mismatchDue(st))
|
|
784
785
|
&& !fixRunning(st) && !st.inFlight)
|
|
785
786
|
.map(([n]) => n).sort(asc),
|
|
786
787
|
// Open, not signed off, closing an issue (GitHub's own linked set — a
|
package/skills/run-team/SKILL.md
CHANGED
|
@@ -1521,8 +1521,8 @@ owes beyond its row:
|
|
|
1521
1521
|
whichever point the ticket fails them.
|
|
1522
1522
|
- **A review result lands** → see the result file written (by you or by the
|
|
1523
1523
|
runner — **Reviewers** says which, per harness) and record `reviewed=` off its
|
|
1524
|
-
digest, then run the tick: a PR with
|
|
1525
|
-
`DISPATCH fix-pr PR#<M>`.
|
|
1524
|
+
digest, then run the tick: a PR with survived or unverified findings prints as
|
|
1525
|
+
`DISPATCH fix-pr PR#<M>`. No survived or unverified finding and nothing to file → skip the
|
|
1526
1526
|
fix-applier and dispatch the **finisher** directly: no member will touch that
|
|
1527
1527
|
PR, so no push is coming and nothing will wake you. A review that failed is
|
|
1528
1528
|
not a result — **Reviewers** says who retries it and what takes over.
|
|
@@ -1643,7 +1643,7 @@ depth** guard table applied in code. Act on each line as it reads:
|
|
|
1643
1643
|
blind until it can.
|
|
1644
1644
|
- `SUGGEST /triage, hold idle` — nothing is admissible after the refresh.
|
|
1645
1645
|
Suggest, never run (**Queue depth**).
|
|
1646
|
-
- `DISPATCH fix-pr PR#<M> …` — a fix-applier per PR, for a review's
|
|
1646
|
+
- `DISPATCH fix-pr PR#<M> …` — a fix-applier per PR, for a review's survived or unverified findings,
|
|
1647
1647
|
a dispositions mismatch no retry has answered, or a merge bot's `conflict-hold:#<M>` (**Reviewers**). Printed
|
|
1648
1648
|
ahead of reviews on purpose: finishing what is started beats starting more.
|
|
1649
1649
|
- `DISPATCH review PR#<M> …` — a review per PR, oldest first, off your turn
|
|
@@ -2125,7 +2125,8 @@ cap. A runner member that is killed rather than failed follows **Failure
|
|
|
2125
2125
|
handling** (fresh name, inherited state stated).
|
|
2126
2126
|
|
|
2127
2127
|
**Then dispatch a fix-applier** — on `DISPATCH fix-pr PR#<M>`, which the tick
|
|
2128
|
-
prints for a PR whose `reviewed=` counts
|
|
2128
|
+
prints for a PR whose `reviewed=` counts survived or unverified findings that
|
|
2129
|
+
no review fix-applier
|
|
2129
2130
|
has landed `applied:`/`no-op` on since, with no fix-applier live on it — one
|
|
2130
2131
|
named member per PR, `fix-pr-<pr#>` (the next suffix when that name is already
|
|
2131
2132
|
on record), never the PR's
|
|
@@ -2156,7 +2157,7 @@ bring `<branch>` current with `origin/main`, resolving every conflict by
|
|
|
2156
2157
|
head. Settle it `applied:<head>` — `no-op` if no conflict was left — which is
|
|
2157
2158
|
what lifts the tick's merge hold; a dispatched-but-live one does not, and
|
|
2158
2159
|
`failed`/`killed` leave the PR fix-due for a replacement. It answers the
|
|
2159
|
-
hold and nothing else:
|
|
2160
|
+
hold and nothing else: survived or unverified findings of a returned review the row also carries
|
|
2160
2161
|
stay unanswered through its settle, so the tick prints `DISPATCH fix-pr
|
|
2161
2162
|
PR#<M>` again once it lands, and that one — `dispatch` now prints `null` —
|
|
2162
2163
|
is a review fix-applier, dispatched as above. The push moves the
|
|
@@ -2526,7 +2527,10 @@ latest `reviewed=` counts a survived or unverified finding, unless the
|
|
|
2526
2527
|
dispositions verdict answering that review's head is `ok`**: among the
|
|
2527
2528
|
`dispositions-*=fix-pr-<M>[-x]:<head>` tokens whose head matches it, the one
|
|
2528
2529
|
from the highest-suffixed fix-applier. A PR whose latest review counts
|
|
2529
|
-
`0/<n>/0` is not gated.
|
|
2530
|
+
`0/<n>/0` is not gated. One counting `0/<n>/<u>` with `<u>` above zero is
|
|
2531
|
+
gated like survivors, and the tick prints `DISPATCH fix-pr PR#<M>` for it: that
|
|
2532
|
+
fix-applier's `no-op` and its `ok` verdict are what open the finisher. The
|
|
2533
|
+
refusal names its cause. `dispositions
|
|
2530
2534
|
unchecked` — no verdict answers that head: run `dispositions-check.mjs` for
|
|
2531
2535
|
the fix-applier that answered the review, as the Fix-applier report edge
|
|
2532
2536
|
states, then dispatch again. `dispositions mismatch` — no finisher: the tick
|
|
@@ -2975,7 +2979,8 @@ touch, and to read each corrected sentence literally, clause by clause. It then
|
|
|
2975
2979
|
does the fix-applier's job too:
|
|
2976
2980
|
apply, defer, file, push, report, exit. On its report, record
|
|
2977
2981
|
`reviewed=<head>:0/<refuted>/<deferred>` against the head it pushed — it applied
|
|
2978
|
-
its own survivors, so the zero is what tells the tick no fix-applier is owed
|
|
2982
|
+
its own survivors, so the zero is what tells the tick no fix-applier is owed for
|
|
2983
|
+
them; a nonzero `<deferred>` is still fix-due, as any review's unverified band is —
|
|
2979
2984
|
and it reaches a finisher through the same gate as any other PR.
|
|
2980
2985
|
|
|
2981
2986
|
**Authorize the fan-out explicitly.** State that the full specialist set IS the
|