@feigi/fleet-ctl 3.24.2 → 3.24.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/scripts/board.html +22 -22
- package/scripts/board.mjs +143 -145
- package/scripts/compute-board.mjs +39 -38
package/package.json
CHANGED
package/scripts/board.html
CHANGED
|
@@ -8,7 +8,7 @@
|
|
|
8
8
|
:root { color-scheme: dark; --bg:#0d1117; --panel:#161b22; --line:#30363d;
|
|
9
9
|
--fg:#e6edf3; --dim:#8b949e; --red:#f85149; --amber:#d29922; --green:#3fb950; --blue:#58a6ff; }
|
|
10
10
|
* { box-sizing: border-box; }
|
|
11
|
-
/* The page is the window's height
|
|
11
|
+
/* The page is the window's height: header, banner, attention strip,
|
|
12
12
|
spend panel and footer keep their natural height and never shrink; #board
|
|
13
13
|
takes the rest, and each column scrolls on its own past that. The board's
|
|
14
14
|
min-height is the floor for a window too short for the fixed parts — they
|
|
@@ -91,7 +91,7 @@ const COLUMNS = ["POOL", "IMPLEMENTING", "REVIEW", "READY", "MERGED"];
|
|
|
91
91
|
let interval = 15;
|
|
92
92
|
let repoUrl = null; // full repo URL from the model (carries the host) — PR links, GHE-safe
|
|
93
93
|
|
|
94
|
-
// The instance's name, for the tab strip and the header
|
|
94
|
+
// The instance's name, for the tab strip and the header. Two cockpits
|
|
95
95
|
// are two WORKSPACES, and until this the pair rendered one constant twice —
|
|
96
96
|
// the operator's only way to tell two open windows apart was to read the
|
|
97
97
|
// tickets on them. `repo` has ridden the payload since the board existed and
|
|
@@ -99,7 +99,7 @@ let repoUrl = null; // full repo URL from the model (carries the host) — PR li
|
|
|
99
99
|
//
|
|
100
100
|
// Truthiness, not a null check: `gh repo view` failing leaves gather()'s
|
|
101
101
|
// `repo` null, a malformed answer can leave it "", and the identity stub
|
|
102
|
-
// served before the first tick
|
|
102
|
+
// served before the first tick carries no `repo` key at all. All
|
|
103
103
|
// three mean "this board cannot name its repo", and all three must render
|
|
104
104
|
// today's constant rather than `fleet cockpit — undefined`.
|
|
105
105
|
//
|
|
@@ -136,15 +136,15 @@ function spendRows(host, items, { label, value, pct, highlight }) {
|
|
|
136
136
|
// branching lives here rather than in renderSpend below because this page has no
|
|
137
137
|
// other test seam: it is served as one self-contained file, so a test reaches
|
|
138
138
|
// this decision only by lifting it out of the source and calling it directly,
|
|
139
|
-
// which
|
|
139
|
+
// which a test does. That gap is not academic — the falsy-cacheWrite
|
|
140
140
|
// case below shipped broken and its fix shipped untested, because until this
|
|
141
|
-
// split there was nothing a test could call
|
|
141
|
+
// split there was nothing a test could call.
|
|
142
142
|
//
|
|
143
143
|
// `kind` is the tag the renderer switches on; "hidden" appends nothing at all.
|
|
144
144
|
// Both text-only outcomes carry the same `text` field because both render as one
|
|
145
145
|
// `spend-wrap` div, differing only in wording.
|
|
146
146
|
function spendView(sp) {
|
|
147
|
-
//
|
|
147
|
+
// The damaged-lines phrase, shared by both the early note-only branch and the funded
|
|
148
148
|
// panel's note below, so a rewording can't update one copy and silently
|
|
149
149
|
// miss the other. It names the LINES, not the files: one transcript can
|
|
150
150
|
// hold several damaged lines, and "1 transcript damaged" would read as a
|
|
@@ -156,7 +156,7 @@ function spendView(sp) {
|
|
|
156
156
|
// launched backgrounded and the operator is watching this page, not a log.
|
|
157
157
|
//
|
|
158
158
|
// Switch on `ok`, gatherSpend's explicit tag, and never on `error`. Reading
|
|
159
|
-
// the error case off `error`'s truthiness was
|
|
159
|
+
// the error case off `error`'s truthiness was a bug: `{ error: "" }` and
|
|
160
160
|
// `{ error: undefined }` — both of which the producer's outer catch can emit,
|
|
161
161
|
// from a message-less throw and a thrown non-Error — matched neither this
|
|
162
162
|
// branch nor a success shape, so they fell through, found no totals, and HID
|
|
@@ -179,7 +179,7 @@ function spendView(sp) {
|
|
|
179
179
|
// rendered identically to "nothing yet". stderr does not cover it (see
|
|
180
180
|
// above), so the note goes out on its own, without the zeroed two-column body.
|
|
181
181
|
if (!sp.totals || !sp.totals.cacheWrite) {
|
|
182
|
-
//
|
|
182
|
+
// The damaged-lines worst case: when a damaged line WAS the run's only cache-creation
|
|
183
183
|
// turn there is nothing left to sum, so cache-write is 0 with `skipped`
|
|
184
184
|
// also 0 — a freshly-dispatched agent with no cache-creation turn flushed
|
|
185
185
|
// yet can land here too, which is why `damaged` alone, without `skipped`,
|
|
@@ -198,7 +198,7 @@ function spendView(sp) {
|
|
|
198
198
|
lede: `${k(sp.totals.cacheWrite)} cache-write · ${k(sp.totals.cacheRead)} cache-read · ${k(sp.totals.output)} output · ${sp.totals.agents} agents · review ${sp.reviewPct.toFixed(0)}%`,
|
|
199
199
|
// `skipped` means "contributed nothing"; `damaged` means "contributed, but
|
|
200
200
|
// may be missing the torn line's tool_use blocks and output_tokens
|
|
201
|
-
// snapshot"
|
|
201
|
+
// snapshot" — cache_creation/cache_read repeat on every line
|
|
202
202
|
// of a turn and survive a mid-turn tear, so the panel's totals are not
|
|
203
203
|
// necessarily short. Two different
|
|
204
204
|
// lies, so two different phrases, both routed through the one channel that
|
|
@@ -282,27 +282,27 @@ function render(m) {
|
|
|
282
282
|
span.append(el("span", "flag", (t.flags || []).join(" ")));
|
|
283
283
|
att.append(span);
|
|
284
284
|
}
|
|
285
|
-
// columns — each built once and kept, its contents rewritten every tick
|
|
286
|
-
//
|
|
285
|
+
// columns — each built once and kept, its contents rewritten every tick.
|
|
286
|
+
// A column scrolls on its own and a scroll offset lives on
|
|
287
287
|
// the element, so a tick that threw the columns away and built new ones
|
|
288
288
|
// jumped every column back to the top within one poll. Keeping the node
|
|
289
289
|
// keeps its scroll — and a scroll still in flight — with nothing to save
|
|
290
290
|
// or restore. #board's own children ARE the column cache: nothing else
|
|
291
291
|
// ever appends to or clears #board, so board.children[i] is always
|
|
292
|
-
// COLUMNS[i]'s node and no separate Map is needed to remember it
|
|
293
|
-
//
|
|
294
|
-
// silently stale against it, never disagree usefully
|
|
292
|
+
// COLUMNS[i]'s node and no separate Map is needed to remember it: a
|
|
293
|
+
// Map here could only ever agree with board.children or go
|
|
294
|
+
// silently stale against it, never disagree usefully. Every column's
|
|
295
295
|
// contents are built before any of them reach the DOM, so a ticket that
|
|
296
296
|
// makes card() throw partway through leaves EVERY column on the previous
|
|
297
297
|
// tick together — never some columns on the new tick and others frozen on
|
|
298
298
|
// the old one, a mixed-tick board that could look like a normal render
|
|
299
|
-
// (
|
|
299
|
+
// (poll()'s own catch below still banners the failure).
|
|
300
300
|
const board = document.getElementById("board");
|
|
301
301
|
const q = m.queue || {};
|
|
302
302
|
const next = COLUMNS.map((name) => {
|
|
303
303
|
const inCol = (m.tickets || []).filter((t) => t.column === name);
|
|
304
304
|
const h = el("h2", null, name + " ");
|
|
305
|
-
//
|
|
305
|
+
// POOL's own count is `q.pool` — the same number, except that a
|
|
306
306
|
// capped pool read makes it `"100+"`, and a header reading a bare 100
|
|
307
307
|
// beside a footer reading 100+ would be the exact claim the `+` retracts.
|
|
308
308
|
h.append(el("span", null, String(name === "POOL" ? q.pool ?? inCol.length : inCol.length)));
|
|
@@ -314,7 +314,7 @@ function render(m) {
|
|
|
314
314
|
col.replaceChildren(...next[i]);
|
|
315
315
|
});
|
|
316
316
|
renderSpend(m.spend);
|
|
317
|
-
//
|
|
317
|
+
// Computed here, ahead of the footer, not only inside the banner
|
|
318
318
|
// arm below. The banner is a single slot behind a stale/stall/ledger
|
|
319
319
|
// priority chain (next section): whenever any of those also fires on the
|
|
320
320
|
// same tick, that chain's capMsg arm never runs, and an open-PR cap has no
|
|
@@ -334,8 +334,8 @@ function render(m) {
|
|
|
334
334
|
(m.filed || []).map((f) => "#" + f.issue).join(" "));
|
|
335
335
|
foot.append(filed);
|
|
336
336
|
// freshness
|
|
337
|
-
//
|
|
338
|
-
//
|
|
337
|
+
// Exactly one payload reaches this page without a `generatedAt` —
|
|
338
|
+
// the identity stub, written at bind time so a racing launch's probe has
|
|
339
339
|
// something to read. The page can now SEE it, because the cockpit answers
|
|
340
340
|
// HTTP while its first tick is still computing where it used to answer
|
|
341
341
|
// nothing at all until the tick was done. Only computeBoard() sets the
|
|
@@ -346,7 +346,7 @@ function render(m) {
|
|
|
346
346
|
const banner = document.getElementById("stale-banner");
|
|
347
347
|
const ledgerMsg = ledgerBanner(m.ledgerState);
|
|
348
348
|
const stallMsg = livenessBanner(m.liveness);
|
|
349
|
-
//
|
|
349
|
+
// Best-effort placement in the single banner slot when nothing
|
|
350
350
|
// higher-priority holds it — ranked last, since stale/a stall/an unread
|
|
351
351
|
// ledger each say the board is wrong wholesale, versus this notice, which
|
|
352
352
|
// only says it may be short at one edge. The footer append above is what
|
|
@@ -375,7 +375,7 @@ function render(m) {
|
|
|
375
375
|
} else { banner.style.display = "none"; banner.className = ""; }
|
|
376
376
|
}
|
|
377
377
|
|
|
378
|
-
// The heartbeat's mark, rendered
|
|
378
|
+
// The heartbeat's mark, rendered. A dead run's tickets keep the label
|
|
379
379
|
// that marks them in flight, and the candidate scan EXCLUDES that label, so a
|
|
380
380
|
// run that stopped silently costs the night AND strands its tickets out of
|
|
381
381
|
// sight of the next run's scans. This is the surface that says so while the
|
|
@@ -402,7 +402,7 @@ function livenessBanner(l) {
|
|
|
402
402
|
return l && l.text ? "⚠ " + l.text : null;
|
|
403
403
|
}
|
|
404
404
|
|
|
405
|
-
// Three ledger states, three renderings
|
|
405
|
+
// Three ledger states, three renderings. `read` refuses an absent ledger
|
|
406
406
|
// under --require-file now, so gather() can tell "there was no ledger to read"
|
|
407
407
|
// from "read it, nothing filed yet" from "read it, the answer would not parse".
|
|
408
408
|
// All three used to arrive here as the same empty lists and drew the same empty
|