@feigi/fleet-ctl 3.23.35 → 3.23.37
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/scripts/main-checkout.mjs +1 -1
- package/scripts/member-write-guard.mjs +1 -1
- package/scripts/repo-root.mjs +1 -1
- package/skills/run-team/references/reaping.md +1 -1
- package/scripts/agent-test-dir-prose.test.mjs +0 -59
- package/scripts/agent-test.test.mjs +0 -1640
- package/scripts/ambient-git-vars-mjs-prose.test.mjs +0 -397
- package/scripts/ambient-git-vars-prose.test.mjs +0 -192
- package/scripts/ancestry-check-position-prose.test.mjs +0 -175
- package/scripts/apply-ruleset.test.mjs +0 -421
- package/scripts/arg-header-probes-prose.test.mjs +0 -394
- package/scripts/arg.test.mjs +0 -1354
- package/scripts/board-cli.test.mjs +0 -710
- package/scripts/board-identity.test.mjs +0 -429
- package/scripts/board-liveness-banner.test.mjs +0 -119
- package/scripts/board-prev-shape.test.mjs +0 -228
- package/scripts/board-tryparse-null.test.mjs +0 -119
- package/scripts/board.test.mjs +0 -3121
- package/scripts/brief-after-cut-prose.test.mjs +0 -53
- package/scripts/candidates-exit3-prose.test.mjs +0 -302
- package/scripts/candidates.test.mjs +0 -2312
- package/scripts/caveat-unification-prose.test.mjs +0 -98
- package/scripts/cell-readout.test.mjs +0 -615
- package/scripts/ci-comment-rot-prose.test.mjs +0 -2025
- package/scripts/ci-completes-premise-prose.test.mjs +0 -257
- package/scripts/ci-state-prose.test.mjs +0 -113
- package/scripts/ci-state.test.mjs +0 -1933
- package/scripts/ci-vacuous-green.test.mjs +0 -368
- package/scripts/citation-sweep-prose.test.mjs +0 -1712
- package/scripts/claim-lifecycle.test.mjs +0 -187
- package/scripts/claim-ticket.test.mjs +0 -1122
- package/scripts/closing-keyword-prose.test.mjs +0 -193
- package/scripts/cockpit-launch-idempotent-prose.test.mjs +0 -165
- package/scripts/cockpit-tick-nonblocking.test.mjs +0 -210
- package/scripts/compute-board.test.mjs +0 -1214
- package/scripts/compute-spend.test.mjs +0 -517
- package/scripts/consumer-technology-prose.test.mjs +0 -126
- package/scripts/cross-repo-citation-prose.test.mjs +0 -155
- package/scripts/cwd-isolation-pins.mjs +0 -83
- package/scripts/dedupe-guard-prose.test.mjs +0 -243
- package/scripts/delete-merged-branch.test.mjs +0 -576
- package/scripts/derive-testcmd.test.mjs +0 -595
- package/scripts/diff-stats.test.mjs +0 -404
- package/scripts/dispatch-block-golden-prose.test.mjs +0 -1130
- package/scripts/dispatch-block-pins-prose.test.mjs +0 -615
- package/scripts/dispositions-check.test.mjs +0 -936
- package/scripts/dispositions-gate-prose.test.mjs +0 -129
- package/scripts/drop-merged-label.test.mjs +0 -479
- package/scripts/exec-stub.mjs +0 -93
- package/scripts/exec-stub.test.mjs +0 -69
- package/scripts/expected-jobs-prose.test.mjs +0 -80
- package/scripts/fan-out-authorization-prose.test.mjs +0 -80
- package/scripts/filing-bar-seat-prose.test.mjs +0 -242
- package/scripts/filing-claim-bar-prose.test.mjs +0 -166
- package/scripts/finisher-died-prose.test.mjs +0 -31
- package/scripts/finisher-dispatch-premise-prose.test.mjs +0 -312
- package/scripts/finisher-halt-prose.test.mjs +0 -106
- package/scripts/finisher-name-prose.test.mjs +0 -134
- package/scripts/finisher-own-tree-prose.test.mjs +0 -299
- package/scripts/finisher-pin-race-prose.test.mjs +0 -339
- package/scripts/finisher-test-verdict-prose.test.mjs +0 -102
- package/scripts/fix-applier-correction-rules-prose.test.mjs +0 -202
- package/scripts/fix-applier-result-file-prose.test.mjs +0 -149
- package/scripts/fleet-bootstrap.test.mjs +0 -75
- package/scripts/fleet-heartbeat.test.mjs +0 -450
- package/scripts/fleet-provenance.test.mjs +0 -138
- package/scripts/fleet-run.test.mjs +0 -90
- package/scripts/fleet-state.test.mjs +0 -460
- package/scripts/fleet-tick-prose.test.mjs +0 -300
- package/scripts/fleet-tick.test.mjs +0 -2444
- package/scripts/force-with-lease-reason-prose.test.mjs +0 -184
- package/scripts/frontmatter-check.test.mjs +0 -436
- package/scripts/git-env.test.mjs +0 -149
- package/scripts/git-status-untracked-mode-sweep.test.mjs +0 -216
- package/scripts/gone-walk.test.mjs +0 -213
- package/scripts/gp-sep-invariant-prose.test.mjs +0 -188
- package/scripts/head-moved-after-label-prose.test.mjs +0 -233
- package/scripts/immutable-body-claim-prose.test.mjs +0 -204
- package/scripts/implementer-model-tier.test.mjs +0 -235
- package/scripts/inflight-citation-prose.test.mjs +0 -144
- package/scripts/inflight-exit2-prose.test.mjs +0 -81
- package/scripts/inflight-probe-guard-prose.test.mjs +0 -109
- package/scripts/inflight-scan-scope-prose.test.mjs +0 -57
- package/scripts/inflight.test.mjs +0 -2882
- package/scripts/injection-control-prose.test.mjs +0 -404
- package/scripts/install-root-audit.test.mjs +0 -464
- package/scripts/instrument-check-prose.test.mjs +0 -235
- package/scripts/instruments.test.mjs +0 -787
- package/scripts/is-cli.test.mjs +0 -99
- package/scripts/issue-tracker-prose.test.mjs +0 -71
- package/scripts/json.test.mjs +0 -364
- package/scripts/ledger-dispatch.test.mjs +0 -927
- package/scripts/ledger-grammar.test.mjs +0 -227
- package/scripts/ledger-read-require-file.test.mjs +0 -197
- package/scripts/ledger-rotate.test.mjs +0 -142
- package/scripts/ledger.test.mjs +0 -3436
- package/scripts/line-distance-prose.test.mjs +0 -245
- package/scripts/liveness-rationale-prose.test.mjs +0 -83
- package/scripts/locale-pin-prose.test.mjs +0 -189
- package/scripts/main-checkout.test.mjs +0 -332
- package/scripts/member-outcome-prose.test.mjs +0 -167
- package/scripts/member-outcomes-header.test.mjs +0 -129
- package/scripts/member-outcomes-prose.test.mjs +0 -63
- package/scripts/member-outcomes.test.mjs +0 -638
- package/scripts/member-prompt-prose.test.mjs +0 -165
- package/scripts/member-record.test.mjs +0 -541
- package/scripts/member-write-guard.test.mjs +0 -214
- package/scripts/merge-commit-probe-prose.test.mjs +0 -122
- package/scripts/merge-gate.test.mjs +0 -613
- package/scripts/muted-git-guard-sweep.test.mjs +0 -493
- package/scripts/net-ssh-precedence-prose.test.mjs +0 -91
- package/scripts/net-watchdog-prose.test.mjs +0 -79
- package/scripts/net.test.mjs +0 -211
- package/scripts/no-ci-gate-prose.test.mjs +0 -108
- package/scripts/no-undo-audit.test.mjs +0 -3961
- package/scripts/no-wave.test.mjs +0 -138
- package/scripts/node-floor-sweep.test.mjs +0 -611
- package/scripts/pointer-target-prose.test.mjs +0 -186
- package/scripts/pr-cost.test.mjs +0 -521
- package/scripts/pr-overlap.test.mjs +0 -692
- package/scripts/printf-die-sweep.test.mjs +0 -384
- package/scripts/prompt-renderer.mjs +0 -40
- package/scripts/prompt-renderer.test.mjs +0 -68
- package/scripts/prose-pin.mjs +0 -807
- package/scripts/prose-pin.test.mjs +0 -1034
- package/scripts/prove-merge.test.mjs +0 -995
- package/scripts/pull-table-relabel-prose.test.mjs +0 -60
- package/scripts/quiet-payload-prose.test.mjs +0 -222
- package/scripts/reap-cherry-check-prose.test.mjs +0 -80
- package/scripts/reap.test.mjs +0 -4432
- package/scripts/reaping-prose.test.mjs +0 -239
- package/scripts/reaping-reap-authorizers-prose.test.mjs +0 -112
- package/scripts/reaping-release-authorizers-prose.test.mjs +0 -85
- package/scripts/recipe-derivation-prose.test.mjs +0 -112
- package/scripts/recipe-prove.test.mjs +0 -1042
- package/scripts/refuter-scratch-prose.test.mjs +0 -135
- package/scripts/release-label-required-prose.test.mjs +0 -71
- package/scripts/release-label-split-prose.test.mjs +0 -184
- package/scripts/release-ticket-reap-pairing-prose.test.mjs +0 -63
- package/scripts/release-ticket.test.mjs +0 -5099
- package/scripts/renovate-release-contract.test.mjs +0 -379
- package/scripts/repo-root.test.mjs +0 -873
- package/scripts/reporter-output-rule-prose.test.mjs +0 -208
- package/scripts/review-agent-report-only.test.mjs +0 -49
- package/scripts/review-core-booking.test.mjs +0 -35
- package/scripts/review-core-cwd-isolation.test.mjs +0 -374
- package/scripts/review-core-reads.test.mjs +0 -478
- package/scripts/review-core-refuter-scratch.test.mjs +0 -148
- package/scripts/review-core-scratch-refusal.test.mjs +0 -64
- package/scripts/review-core-shared-test-run.test.mjs +0 -275
- package/scripts/review-core-snapshot-path.test.mjs +0 -830
- package/scripts/review-core-specialist-scratch.test.mjs +0 -191
- package/scripts/review-core-testcmd.test.mjs +0 -335
- package/scripts/review-core-unrun.test.mjs +0 -566
- package/scripts/review-core-unverified-discriminant.test.mjs +0 -208
- package/scripts/review-eval-resolver-path.test.mjs +0 -55
- package/scripts/review-host-fixture.mjs +0 -89
- package/scripts/review-in-run-retry.test.mjs +0 -211
- package/scripts/review-no-vendor-dispatch.test.mjs +0 -45
- package/scripts/review-path-default.test.mjs +0 -796
- package/scripts/review-runner-spawns.test.mjs +0 -95
- package/scripts/review-runner.test.mjs +0 -166
- package/scripts/review-tier-audit.test.mjs +0 -140
- package/scripts/run-artifact-pr-prose.test.mjs +0 -341
- package/scripts/run-merge-bot-prose.test.mjs +0 -1413
- package/scripts/run-team-local-hook.test.mjs +0 -442
- package/scripts/scratch-partition-invariant-prose.test.mjs +0 -74
- package/scripts/scripts-path-citation-sweep.test.mjs +0 -73
- package/scripts/section-between-guard-prose.test.mjs +0 -379
- package/scripts/select-dimensions.test.mjs +0 -674
- package/scripts/shared-refusal.test.mjs +0 -388
- package/scripts/shell-traps-prose.test.mjs +0 -504
- package/scripts/shortlist.test.mjs +0 -380
- package/scripts/slow-transport.mjs +0 -72
- package/scripts/snapshot-repo.test.mjs +0 -1006
- package/scripts/snapshot-runner-audience-prose.test.mjs +0 -130
- package/scripts/spend-view.test.mjs +0 -312
- package/scripts/staleness-qualifier-prose.test.mjs +0 -251
- package/scripts/staleness-verdict-prose.test.mjs +0 -142
- package/scripts/staleness.test.mjs +0 -893
- package/scripts/stalled-member-liveness-prose.test.mjs +0 -219
- package/scripts/stash-prohibition-prose.test.mjs +0 -313
- package/scripts/strip-comments.mjs +0 -44
- package/scripts/temp-dir.mjs +0 -47
- package/scripts/ticket-router.test.mjs +0 -981
- package/scripts/tier-check.test.mjs +0 -828
- package/scripts/tier-outcomes-header.test.mjs +0 -518
- package/scripts/tier-outcomes.test.mjs +0 -572
- package/scripts/tier-roles.test.mjs +0 -535
- package/scripts/tracker-block-copy-prose.test.mjs +0 -288
- package/scripts/triage-labels-gloss-prose.test.mjs +0 -97
- package/scripts/unattended-git-sweep.test.mjs +0 -142
- package/scripts/verify-sha-exit2-prose.test.mjs +0 -269
- package/scripts/verify-sha.test.mjs +0 -692
- package/scripts/watcher-degraded-block.test.mjs +0 -369
- package/scripts/watcher-key-prose.test.mjs +0 -106
- package/scripts/within-run-pair-prose.test.mjs +0 -212
- package/scripts/worktree-audit.test.mjs +0 -1408
- package/scripts/worktree-head-prose.test.mjs +0 -276
- package/scripts/worktree-listing-sweep.test.mjs +0 -217
- package/scripts/worktree-model-prose.test.mjs +0 -216
- package/scripts/worktree-porcelain.mjs +0 -35
- package/scripts/worktree-porcelain.test.mjs +0 -102
|
@@ -1,572 +0,0 @@
|
|
|
1
|
-
// #2207: tier-outcomes.mjs writes the `tier` column instead of the controller
|
|
2
|
-
// typing it, and `check` compares it with what actually ran. Driven through
|
|
3
|
-
// the CLI against fixture files: the resolution order, the blank reasons and
|
|
4
|
-
// the idempotency are all observable only there, and `gh` is a PATH stub that
|
|
5
|
-
// logs every call so the no-op run can prove it never asked.
|
|
6
|
-
import { test } from "node:test";
|
|
7
|
-
import assert from "node:assert/strict";
|
|
8
|
-
import { spawnSync } from "node:child_process";
|
|
9
|
-
import { mkdtempSync, mkdirSync, rmSync, writeFileSync, readFileSync, existsSync } from "node:fs";
|
|
10
|
-
import { tmpdir } from "node:os";
|
|
11
|
-
import { join } from "node:path";
|
|
12
|
-
import { fileURLToPath } from "node:url";
|
|
13
|
-
import { COLUMNS, LEGACY_WIDTH, TIER_SWITCH_DATE } from "./tier-outcomes.mjs";
|
|
14
|
-
import { COLUMNS as MEMBER_COLUMNS } from "./member-outcomes.mjs";
|
|
15
|
-
import { writeExecStub } from "./exec-stub.mjs";
|
|
16
|
-
|
|
17
|
-
const SCRIPT = fileURLToPath(new URL("./tier-outcomes.mjs", import.meta.url));
|
|
18
|
-
const LATER = "2026-10-03";
|
|
19
|
-
assert.ok(LATER > TIER_SWITCH_DATE);
|
|
20
|
-
const PRE_SWITCH = "2026-09-17";
|
|
21
|
-
assert.ok(PRE_SWITCH < TIER_SWITCH_DATE);
|
|
22
|
-
|
|
23
|
-
const HEADER = `# ${COLUMNS.join("\t")}\n`;
|
|
24
|
-
|
|
25
|
-
// One member-outcomes.tsv row, every column present so parseTsv accepts it.
|
|
26
|
-
function memberRow({ member, ticket, type, role = "implementer" }) {
|
|
27
|
-
const r = Object.fromEntries(MEMBER_COLUMNS.map((c) => [c, ""]));
|
|
28
|
-
Object.assign(r, { session: "s1", run_date: TIER_SWITCH_DATE, role, member, ticket: String(ticket), agent: member, subagent_type: type });
|
|
29
|
-
return MEMBER_COLUMNS.map((c) => r[c]).join("\t");
|
|
30
|
-
}
|
|
31
|
-
|
|
32
|
-
function tierRow({ date = TIER_SWITCH_DATE, pr, ticket, tier, closed = "yes", minted = "no" }) {
|
|
33
|
-
return [date, pr, ticket, "routine", tier, closed, minted, "a note with spaces", "light", "production", "40", "2"].join("\t");
|
|
34
|
-
}
|
|
35
|
-
|
|
36
|
-
function ledgerText(rows = [], dispatched = []) {
|
|
37
|
-
return `# Fleet run ledger\n\n## Rows\n${rows.map((r) => `- ${r}\n`).join("")}\n## Dispatched\n${dispatched.map((d) => `- ${d}\n`).join("")}\n## Filed\n\n## Ruled\n`;
|
|
38
|
-
}
|
|
39
|
-
|
|
40
|
-
function fixture(t, { members = [], tierRows = [], ledger = null, closes = [10] } = {}) {
|
|
41
|
-
const dir = mkdtempSync(join(tmpdir(), "tier-outcomes-"));
|
|
42
|
-
t.after(() => rmSync(dir, { recursive: true, force: true }));
|
|
43
|
-
const bin = join(dir, "bin");
|
|
44
|
-
mkdirSync(bin);
|
|
45
|
-
writeExecStub(join(bin, "gh"), '#!/bin/sh\nprintf \'%s\\n\' "$*" >> "$GH_LOG"\nprintf \'%s\\n\' "$GH_JSON"\n');
|
|
46
|
-
const f = {
|
|
47
|
-
tier: join(dir, "tier-outcomes.tsv"),
|
|
48
|
-
members: join(dir, "member-outcomes.tsv"),
|
|
49
|
-
ledger: join(dir, "ledger.md"),
|
|
50
|
-
ghLog: join(dir, "gh.log"),
|
|
51
|
-
};
|
|
52
|
-
writeFileSync(f.tier, HEADER + tierRows.map((r) => `${r}\n`).join(""));
|
|
53
|
-
writeFileSync(f.members, `# member facts\n${members.map((m) => `${memberRow(m)}\n`).join("")}`);
|
|
54
|
-
if (ledger) writeFileSync(f.ledger, ledgerText(ledger.rows, ledger.dispatched));
|
|
55
|
-
f.run = (...args) => {
|
|
56
|
-
const r = spawnSync(process.execPath, [SCRIPT, ...args, "--file", f.tier, "--member-outcomes", f.members, "--ledger", f.ledger], {
|
|
57
|
-
cwd: dir,
|
|
58
|
-
encoding: "utf8",
|
|
59
|
-
env: {
|
|
60
|
-
...process.env,
|
|
61
|
-
PATH: `${bin}:${process.env.PATH}`,
|
|
62
|
-
GH_LOG: f.ghLog,
|
|
63
|
-
GH_JSON: JSON.stringify({ closingIssuesReferences: closes.map((number) => ({ number })) }),
|
|
64
|
-
},
|
|
65
|
-
});
|
|
66
|
-
return { code: r.status, stdout: r.stdout, stderr: r.stderr };
|
|
67
|
-
};
|
|
68
|
-
f.append = (pr = "20", { note = "a note with spaces" } = {}) =>
|
|
69
|
-
f.run("append", pr, "--closed-own-ticket", "yes", "--minted-false-claim", "no", "--note", note);
|
|
70
|
-
f.dataRows = () => readFileSync(f.tier, "utf8").split("\n").filter((l) => l.trim() && !l.startsWith("#")).map((l) => l.split("\t"));
|
|
71
|
-
f.ghCalls = () => (existsSync(f.ghLog) ? readFileSync(f.ghLog, "utf8").trim().split("\n").filter(Boolean) : []);
|
|
72
|
-
return f;
|
|
73
|
-
}
|
|
74
|
-
|
|
75
|
-
const col = (name) => COLUMNS.indexOf(name);
|
|
76
|
-
|
|
77
|
-
// ---------------------------------------------------------------------------
|
|
78
|
-
// append
|
|
79
|
-
// ---------------------------------------------------------------------------
|
|
80
|
-
|
|
81
|
-
const localDate = (d = new Date()) =>
|
|
82
|
-
`${d.getFullYear()}-${String(d.getMonth() + 1).padStart(2, "0")}-${String(d.getDate()).padStart(2, "0")}`;
|
|
83
|
-
|
|
84
|
-
test("append: the ledger's tier-ok token wins over member-outcomes.tsv", (t) => {
|
|
85
|
-
const f = fixture(t, {
|
|
86
|
-
ledger: { rows: ["#10 impl-10=PR#20 · class=routine · tier=alt · tier-ok=impl-10:fleet-implementer-alt"], dispatched: ["impl-10=PR#20"] },
|
|
87
|
-
// An older dispatch of the same ticket under the default definition: step 2
|
|
88
|
-
// alone would read `default`.
|
|
89
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
90
|
-
});
|
|
91
|
-
const before = localDate();
|
|
92
|
-
const r = f.append();
|
|
93
|
-
const after = localDate();
|
|
94
|
-
assert.equal(r.code, 0, r.stderr);
|
|
95
|
-
const rows = f.dataRows();
|
|
96
|
-
assert.equal(rows.length, 1);
|
|
97
|
-
assert.equal(rows[0].length, COLUMNS.length, "a new row is written to the full width");
|
|
98
|
-
assert.equal(rows[0][col("pr")], "20");
|
|
99
|
-
assert.equal(rows[0][col("ticket")], "10", "the ticket comes from gh's closingIssuesReferences");
|
|
100
|
-
assert.equal(rows[0][col("tier")], "alt");
|
|
101
|
-
assert.equal(rows[0][col("class")], "", "append writes the retired class column empty");
|
|
102
|
-
// Stamped at ruling: the day `append` ran, in local time — either side of a
|
|
103
|
-
// midnight the run straddled.
|
|
104
|
-
assert.ok([before, after].includes(rows[0][col("run_date")]), `run_date ${rows[0][col("run_date")]} is not the day append ran`);
|
|
105
|
-
assert.equal(rows[0][col("note")], "a note with spaces");
|
|
106
|
-
assert.match(r.stderr, /tier-ok=impl-10:fleet-implementer-alt/);
|
|
107
|
-
assert.deepEqual(f.ghCalls(), ["pr view 20 --json closingIssuesReferences"]);
|
|
108
|
-
});
|
|
109
|
-
|
|
110
|
-
test("append: the verdict of the member that opened the PR, not a replaced attempt's", (t) => {
|
|
111
|
-
const f = fixture(t, {
|
|
112
|
-
ledger: {
|
|
113
|
-
rows: ["#10 impl-10=released · tier-ok=impl-10:fleet-implementer · impl-10-b=PR#20 · tier-ok=impl-10-b:fleet-implementer-alt"],
|
|
114
|
-
dispatched: ["impl-10=released", "impl-10-b=PR#20"],
|
|
115
|
-
},
|
|
116
|
-
});
|
|
117
|
-
assert.equal(f.append().code, 0);
|
|
118
|
-
assert.equal(f.dataRows()[0][col("tier")], "alt");
|
|
119
|
-
});
|
|
120
|
-
|
|
121
|
-
test("append: a stale tier-ok from a member who released the ticket is not used when nobody owns this PR", (t) => {
|
|
122
|
-
const f = fixture(t, {
|
|
123
|
-
ledger: { rows: ["#10 impl-10=released · tier-ok=impl-10:fleet-implementer-alt"], dispatched: ["impl-10=released"] },
|
|
124
|
-
});
|
|
125
|
-
const r = f.append();
|
|
126
|
-
assert.equal(r.code, 0, r.stderr);
|
|
127
|
-
assert.equal(f.dataRows()[0][col("tier")], "");
|
|
128
|
-
assert.match(r.stderr, /WARNING tier left blank for PR #20 \(ticket #10\): no implementer row for #10/);
|
|
129
|
-
});
|
|
130
|
-
|
|
131
|
-
test("append: with no ledger verdict, the ticket's single fleet-implementer* row in member-outcomes.tsv supplies it", (t) => {
|
|
132
|
-
// The PR ruled in a later run than the one that dispatched it: this run's
|
|
133
|
-
// ledger has no row for the ticket at all.
|
|
134
|
-
const f = fixture(t, { members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }] });
|
|
135
|
-
const r = f.append();
|
|
136
|
-
assert.equal(r.code, 0, r.stderr);
|
|
137
|
-
assert.equal(f.dataRows()[0][col("tier")], "default");
|
|
138
|
-
assert.doesNotMatch(r.stderr, /WARNING/);
|
|
139
|
-
});
|
|
140
|
-
|
|
141
|
-
test("append: a per-cell definition's short name is its suffix, not refused", (t) => {
|
|
142
|
-
const f = fixture(t, { members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer-slow-high" }] });
|
|
143
|
-
assert.equal(f.append().code, 0);
|
|
144
|
-
assert.equal(f.dataRows()[0][col("tier")], "slow-high");
|
|
145
|
-
});
|
|
146
|
-
|
|
147
|
-
for (const [why, members, reason] of [
|
|
148
|
-
["no member row", [{ member: "impl-11", ticket: 11, type: "fleet-implementer" }], /no implementer row for #10/],
|
|
149
|
-
[
|
|
150
|
-
"several member rows",
|
|
151
|
-
[{ member: "impl-10", ticket: 10, type: "fleet-implementer" }, { member: "impl-10-b", ticket: 10, type: "fleet-implementer-alt" }],
|
|
152
|
-
/2 implementer rows for #10/,
|
|
153
|
-
],
|
|
154
|
-
["a `task` row", [{ member: "impl-10", ticket: 10, type: "task" }], /impl-10 ran as 'task', not a fleet-implementer\* definition/],
|
|
155
|
-
]) {
|
|
156
|
-
test(`append: ${why} leaves tier blank, warns why, and still writes the row`, (t) => {
|
|
157
|
-
const f = fixture(t, { members });
|
|
158
|
-
const r = f.append();
|
|
159
|
-
assert.equal(r.code, 0, r.stderr);
|
|
160
|
-
const rows = f.dataRows();
|
|
161
|
-
assert.equal(rows.length, 1);
|
|
162
|
-
assert.equal(rows[0].length, COLUMNS.length);
|
|
163
|
-
assert.equal(rows[0][col("tier")], "");
|
|
164
|
-
assert.match(r.stderr, /WARNING tier left blank for PR #20 \(ticket #10\)/);
|
|
165
|
-
assert.match(r.stderr, reason);
|
|
166
|
-
});
|
|
167
|
-
}
|
|
168
|
-
|
|
169
|
-
test("append: a tier-mismatch verdict blanks the tier instead of falling back to an older dispatch", (t) => {
|
|
170
|
-
const f = fixture(t, {
|
|
171
|
-
ledger: { rows: ["#10 impl-10=PR#20 · tier-mismatch=impl-10:fleet-implementer"], dispatched: ["impl-10=PR#20"] },
|
|
172
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
173
|
-
});
|
|
174
|
-
const r = f.append();
|
|
175
|
-
assert.equal(r.code, 0);
|
|
176
|
-
assert.equal(f.dataRows()[0][col("tier")], "");
|
|
177
|
-
assert.match(r.stderr, /tier-mismatch=impl-10:fleet-implementer/);
|
|
178
|
-
});
|
|
179
|
-
|
|
180
|
-
test("append: a member settled tier-mismatch on the ledger blanks the tier even with no free-text tier-mismatch= token", (t) => {
|
|
181
|
-
// tier-check.mjs's main path (a mismatch caught while the member is still
|
|
182
|
-
// live) settles the member as `tier-mismatch` directly and writes no
|
|
183
|
-
// free-text token — see tier-check.mjs's recordImplementer.
|
|
184
|
-
const f = fixture(t, {
|
|
185
|
-
ledger: { rows: ["#10 impl-10=tier-mismatch"], dispatched: ["impl-10=tier-mismatch"] },
|
|
186
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
187
|
-
});
|
|
188
|
-
const r = f.append();
|
|
189
|
-
assert.equal(r.code, 0, r.stderr);
|
|
190
|
-
assert.equal(f.dataRows()[0][col("tier")], "");
|
|
191
|
-
assert.match(r.stderr, /the ledger settled impl-10=tier-mismatch/);
|
|
192
|
-
});
|
|
193
|
-
|
|
194
|
-
test("append: a tier-unverifiable token is no verdict — the tier falls through to member-outcomes.tsv, never read as tier-ok", (t) => {
|
|
195
|
-
// The token's tail is definition-shaped on purpose: a reader that took
|
|
196
|
-
// `tier-unverifiable=` for a tier verdict would read `alt` off it, where
|
|
197
|
-
// tier-check's own `:no-transcript` tail names no tier and would hide that.
|
|
198
|
-
const f = fixture(t, {
|
|
199
|
-
ledger: { rows: ["#10 impl-10=PR#20 · tier-unverifiable=impl-10:fleet-implementer-alt"], dispatched: ["impl-10=PR#20"] },
|
|
200
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
201
|
-
});
|
|
202
|
-
const r = f.append();
|
|
203
|
-
assert.equal(r.code, 0, r.stderr);
|
|
204
|
-
assert.equal(f.dataRows()[0][col("tier")], "default");
|
|
205
|
-
assert.doesNotMatch(r.stderr, /tier-ok|tier-unverifiable/);
|
|
206
|
-
});
|
|
207
|
-
|
|
208
|
-
test("append: a replaced attempt's tier-unverifiable leaves the PR owner's own tier-ok standing", (t) => {
|
|
209
|
-
const f = fixture(t, {
|
|
210
|
-
ledger: {
|
|
211
|
-
rows: ["#10 impl-10=killed · tier-unverifiable=impl-10:no-transcript · impl-10-b=PR#20 · tier-ok=impl-10-b:fleet-implementer-alt"],
|
|
212
|
-
dispatched: ["impl-10=killed", "impl-10-b=PR#20"],
|
|
213
|
-
},
|
|
214
|
-
});
|
|
215
|
-
assert.equal(f.append().code, 0);
|
|
216
|
-
assert.equal(f.dataRows()[0][col("tier")], "alt");
|
|
217
|
-
});
|
|
218
|
-
|
|
219
|
-
test("append: running it twice is a no-op that names the existing row and never asks gh", (t) => {
|
|
220
|
-
const f = fixture(t, { members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }] });
|
|
221
|
-
assert.equal(f.append().code, 0);
|
|
222
|
-
const before = readFileSync(f.tier, "utf8");
|
|
223
|
-
const again = f.append("20", { note: "a different note" });
|
|
224
|
-
assert.equal(again.code, 0, again.stderr);
|
|
225
|
-
assert.equal(readFileSync(f.tier, "utf8"), before);
|
|
226
|
-
assert.match(again.stdout, /PR #20 already has a row/);
|
|
227
|
-
assert.ok(again.stdout.includes(before.trim().split("\n").at(-1)), "the existing row is printed");
|
|
228
|
-
assert.equal(f.ghCalls().length, 1, "the second run asked gh again");
|
|
229
|
-
});
|
|
230
|
-
|
|
231
|
-
test("append: a leading zero in the PR argument is normalized, not treated as a different PR", (t) => {
|
|
232
|
-
const f = fixture(t, { members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }] });
|
|
233
|
-
assert.equal(f.append("020").code, 0);
|
|
234
|
-
assert.equal(f.dataRows().length, 1);
|
|
235
|
-
assert.equal(f.dataRows()[0][col("pr")], "20", "the stored PR is normalized, not the raw '020' argument");
|
|
236
|
-
const again = f.append("20", { note: "a different note" });
|
|
237
|
-
assert.equal(again.code, 0, again.stderr);
|
|
238
|
-
assert.equal(f.dataRows().length, 1, "the normalized PR is recognized as already having a row, not duplicated");
|
|
239
|
-
});
|
|
240
|
-
|
|
241
|
-
test("append: a tab in --note is refused before anything is written", (t) => {
|
|
242
|
-
const f = fixture(t, { members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }] });
|
|
243
|
-
const before = readFileSync(f.tier, "utf8");
|
|
244
|
-
const r = f.append("20", { note: "shifted\tfields" });
|
|
245
|
-
assert.equal(r.code, 2);
|
|
246
|
-
assert.equal(readFileSync(f.tier, "utf8"), before);
|
|
247
|
-
});
|
|
248
|
-
|
|
249
|
-
test("append: a newline or carriage return in a flag value is refused, the same as a tab", (t) => {
|
|
250
|
-
const f = fixture(t, { members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }] });
|
|
251
|
-
const before = readFileSync(f.tier, "utf8");
|
|
252
|
-
for (const bad of ["shifted\nfields", "shifted\rfields"]) {
|
|
253
|
-
const r = f.append("20", { note: bad });
|
|
254
|
-
assert.equal(r.code, 2, `note ${JSON.stringify(bad)} was not refused`);
|
|
255
|
-
}
|
|
256
|
-
assert.equal(readFileSync(f.tier, "utf8"), before);
|
|
257
|
-
});
|
|
258
|
-
|
|
259
|
-
test("append: a PR closing no issue is refused, not written with a blank ticket", (t) => {
|
|
260
|
-
const f = fixture(t, { closes: [] });
|
|
261
|
-
const before = readFileSync(f.tier, "utf8");
|
|
262
|
-
const r = f.append();
|
|
263
|
-
assert.equal(r.code, 2);
|
|
264
|
-
assert.match(r.stderr, /closes no issue/);
|
|
265
|
-
assert.equal(readFileSync(f.tier, "utf8"), before);
|
|
266
|
-
});
|
|
267
|
-
|
|
268
|
-
test("append: --class is refused as an unknown flag before anything is written", (t) => {
|
|
269
|
-
const f = fixture(t, { members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }] });
|
|
270
|
-
const before = readFileSync(f.tier, "utf8");
|
|
271
|
-
const r = f.run("append", "20", "--class", "routine", "--closed-own-ticket", "yes", "--minted-false-claim", "no", "--note", "n");
|
|
272
|
-
assert.equal(r.code, 2);
|
|
273
|
-
assert.match(r.stderr, /unknown flag --class/);
|
|
274
|
-
assert.equal(readFileSync(f.tier, "utf8"), before);
|
|
275
|
-
assert.deepEqual(f.ghCalls(), [], "refused before gh was asked");
|
|
276
|
-
});
|
|
277
|
-
|
|
278
|
-
test("append: a verdict that is not exactly yes or no is refused naming the flag, before gh is asked or anything is written", (t) => {
|
|
279
|
-
for (const [flag, closed, minted] of [
|
|
280
|
-
["closed-own-ticket", "YES", "no"],
|
|
281
|
-
["closed-own-ticket", "yes ", "no"],
|
|
282
|
-
["minted-false-claim", "yes", "No"],
|
|
283
|
-
["minted-false-claim", "yes", "maybe"],
|
|
284
|
-
]) {
|
|
285
|
-
const f = fixture(t, { members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }] });
|
|
286
|
-
const before = readFileSync(f.tier, "utf8");
|
|
287
|
-
const r = f.run("append", "20", "--closed-own-ticket", closed, "--minted-false-claim", minted, "--note", "n");
|
|
288
|
-
const got = flag === "closed-own-ticket" ? closed : minted;
|
|
289
|
-
assert.equal(r.code, 2, `${flag}=${JSON.stringify(got)}\n${r.stdout}${r.stderr}`);
|
|
290
|
-
assert.ok(r.stderr.includes(`--${flag} must be yes or no, got '${got}'`), r.stderr);
|
|
291
|
-
assert.equal(readFileSync(f.tier, "utf8"), before);
|
|
292
|
-
assert.deepEqual(f.ghCalls(), [], "refused before gh was asked");
|
|
293
|
-
}
|
|
294
|
-
});
|
|
295
|
-
|
|
296
|
-
// ---------------------------------------------------------------------------
|
|
297
|
-
// check
|
|
298
|
-
// ---------------------------------------------------------------------------
|
|
299
|
-
|
|
300
|
-
test("check: a tier equal to the single implementer row's short name passes", (t) => {
|
|
301
|
-
const f = fixture(t, {
|
|
302
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer-alt" }, { member: "impl-12", ticket: 12, type: "fleet-implementer" }],
|
|
303
|
-
tierRows: [tierRow({ pr: 20, ticket: 10, tier: "alt" }), tierRow({ pr: 22, ticket: 12, tier: "default" })],
|
|
304
|
-
});
|
|
305
|
-
const r = f.run("check");
|
|
306
|
-
assert.equal(r.code, 0, r.stderr);
|
|
307
|
-
assert.match(r.stdout, /2 checked, 0 failed/);
|
|
308
|
-
});
|
|
309
|
-
|
|
310
|
-
test("check: a tier naming a different definition than ran fails", (t) => {
|
|
311
|
-
const f = fixture(t, {
|
|
312
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer-alt" }],
|
|
313
|
-
tierRows: [tierRow({ pr: 20, ticket: 10, tier: "default" })],
|
|
314
|
-
});
|
|
315
|
-
const r = f.run("check");
|
|
316
|
-
assert.equal(r.code, 1);
|
|
317
|
-
assert.match(r.stderr, /FAIL PR #20 \(ticket #10\): tier=default, but impl-10 ran as fleet-implementer-alt \(alt\)/);
|
|
318
|
-
});
|
|
319
|
-
|
|
320
|
-
test("check: a lone `task` implementer row fails a filled tier", (t) => {
|
|
321
|
-
const f = fixture(t, {
|
|
322
|
-
members: [{ member: "impl-10", ticket: 10, type: "task" }],
|
|
323
|
-
tierRows: [tierRow({ pr: 20, ticket: 10, tier: "default" })],
|
|
324
|
-
});
|
|
325
|
-
const r = f.run("check");
|
|
326
|
-
assert.equal(r.code, 1);
|
|
327
|
-
assert.match(r.stderr, /FAIL PR #20 .*ran as 'task'/);
|
|
328
|
-
});
|
|
329
|
-
|
|
330
|
-
test("check: blank, several-row and no-row rows are skipped, not failed", (t) => {
|
|
331
|
-
const f = fixture(t, {
|
|
332
|
-
members: [
|
|
333
|
-
{ member: "impl-10", ticket: 10, type: "task" },
|
|
334
|
-
{ member: "impl-11", ticket: 11, type: "fleet-implementer" },
|
|
335
|
-
{ member: "impl-11-b", ticket: 11, type: "task" },
|
|
336
|
-
// A single-member row (ticket 13) is CHECKED, not skipped — closes the
|
|
337
|
-
// boundary between this and the several-member-rows case above.
|
|
338
|
-
{ member: "impl-13", ticket: 13, type: "fleet-implementer" },
|
|
339
|
-
],
|
|
340
|
-
tierRows: [
|
|
341
|
-
tierRow({ pr: 20, ticket: 10, tier: "" }),
|
|
342
|
-
tierRow({ pr: 21, ticket: 11, tier: "default" }),
|
|
343
|
-
tierRow({ pr: 22, ticket: 12, tier: "default" }),
|
|
344
|
-
tierRow({ pr: 23, ticket: 13, tier: "default" }),
|
|
345
|
-
],
|
|
346
|
-
});
|
|
347
|
-
const r = f.run("check");
|
|
348
|
-
assert.equal(r.code, 0, r.stderr);
|
|
349
|
-
assert.match(r.stdout, /1 checked, 0 failed; skipped 0 before \S+, 1 blank, 1 with no member row, 1 with several member rows/);
|
|
350
|
-
});
|
|
351
|
-
|
|
352
|
-
test("check: rows dated before the switch are skipped, whatever they say", (t) => {
|
|
353
|
-
const f = fixture(t, {
|
|
354
|
-
members: [{ member: "impl-10", ticket: 10, type: "task" }],
|
|
355
|
-
tierRows: [tierRow({ date: PRE_SWITCH, pr: 20, ticket: 10, tier: "opus" })],
|
|
356
|
-
});
|
|
357
|
-
const r = f.run("check");
|
|
358
|
-
assert.equal(r.code, 0, r.stderr);
|
|
359
|
-
assert.match(r.stdout, /skipped 1 before/);
|
|
360
|
-
});
|
|
361
|
-
|
|
362
|
-
// The vacuous pass #2433 closes: the latest run's filled post-switch rows all
|
|
363
|
-
// lost their join to the member file, so nothing from it was compared and
|
|
364
|
-
// `0 checked` used to exit 0.
|
|
365
|
-
test("check: a run whose filled post-switch rows all lack a member row fails, naming them", (t) => {
|
|
366
|
-
// impl-327-2 is an implementer name parseMemberName leaves with a blank ticket.
|
|
367
|
-
const f = fixture(t, {
|
|
368
|
-
members: [{ member: "impl-327-2", ticket: "", type: "fleet-implementer" }],
|
|
369
|
-
tierRows: [
|
|
370
|
-
tierRow({ date: PRE_SWITCH, pr: 19, ticket: 326, tier: "opus" }),
|
|
371
|
-
tierRow({ pr: 20, ticket: 327, tier: "default" }),
|
|
372
|
-
tierRow({ pr: 21, ticket: 328, tier: "default" }),
|
|
373
|
-
tierRow({ pr: 22, ticket: 329, tier: "" }),
|
|
374
|
-
],
|
|
375
|
-
});
|
|
376
|
-
const r = f.run("check");
|
|
377
|
-
assert.equal(r.code, 1, r.stdout + r.stderr);
|
|
378
|
-
assert.match(r.stderr, new RegExp(`FAIL nothing from ${TIER_SWITCH_DATE}, .*was checked: .*PR #20 \\(ticket #327\\), PR #21 \\(ticket #328\\)$`, "m"));
|
|
379
|
-
assert.doesNotMatch(r.stderr, /PR #19|PR #22/, "a pre-switch or blank-tier row is not a lost join");
|
|
380
|
-
assert.match(r.stdout, /0 checked/);
|
|
381
|
-
});
|
|
382
|
-
|
|
383
|
-
test("check: a missing member file fails a filled post-switch row the same way", (t) => {
|
|
384
|
-
const f = fixture(t, { tierRows: [tierRow({ pr: 20, ticket: 10, tier: "default" })] });
|
|
385
|
-
rmSync(f.members);
|
|
386
|
-
const r = f.run("check");
|
|
387
|
-
assert.equal(r.code, 1, r.stdout + r.stderr);
|
|
388
|
-
assert.match(r.stderr, /FAIL nothing from .*was checked: .*PR #20/);
|
|
389
|
-
});
|
|
390
|
-
|
|
391
|
-
// The tsv is cumulative, so an earlier run that checked fine must not hide a
|
|
392
|
-
// later run that lost every join.
|
|
393
|
-
test("check: a later run that lost every join fails even though an earlier run was checked", (t) => {
|
|
394
|
-
const f = fixture(t, {
|
|
395
|
-
members: [
|
|
396
|
-
{ member: "impl-10", ticket: 10, type: "fleet-implementer" },
|
|
397
|
-
{ member: "impl-327-2", ticket: "", type: "fleet-implementer" },
|
|
398
|
-
],
|
|
399
|
-
tierRows: [
|
|
400
|
-
tierRow({ pr: 20, ticket: 10, tier: "default" }),
|
|
401
|
-
tierRow({ date: LATER, pr: 21, ticket: 327, tier: "default" }),
|
|
402
|
-
tierRow({ date: LATER, pr: 22, ticket: 328, tier: "default" }),
|
|
403
|
-
],
|
|
404
|
-
});
|
|
405
|
-
const r = f.run("check");
|
|
406
|
-
assert.equal(r.code, 1, r.stdout + r.stderr);
|
|
407
|
-
assert.match(r.stderr, new RegExp(`FAIL nothing from ${LATER}, .*PR #21 .*PR #22`));
|
|
408
|
-
assert.match(r.stdout, /1 checked, 1 failed/);
|
|
409
|
-
});
|
|
410
|
-
|
|
411
|
-
// A several-member-rows skip is by design, but it is no comparison and must
|
|
412
|
-
// not cancel the no-member-row alarm.
|
|
413
|
-
test("check: a several-member-rows row does not hide lost joins beside it", (t) => {
|
|
414
|
-
const f = fixture(t, {
|
|
415
|
-
members: [
|
|
416
|
-
{ member: "impl-11", ticket: 11, type: "task" },
|
|
417
|
-
{ member: "impl-11-b", ticket: 11, type: "task" },
|
|
418
|
-
],
|
|
419
|
-
tierRows: [
|
|
420
|
-
tierRow({ pr: 20, ticket: 327, tier: "default" }),
|
|
421
|
-
tierRow({ pr: 21, ticket: 328, tier: "default" }),
|
|
422
|
-
tierRow({ pr: 22, ticket: 329, tier: "default" }),
|
|
423
|
-
tierRow({ pr: 23, ticket: 11, tier: "default" }),
|
|
424
|
-
],
|
|
425
|
-
});
|
|
426
|
-
const r = f.run("check");
|
|
427
|
-
assert.equal(r.code, 1, r.stdout + r.stderr);
|
|
428
|
-
assert.match(r.stderr, /FAIL nothing from .*PR #20 .*PR #21 .*PR #22/);
|
|
429
|
-
assert.doesNotMatch(r.stderr, /PR #23/);
|
|
430
|
-
assert.match(r.stdout, /0 checked.*3 with no member row, 1 with several member rows/);
|
|
431
|
-
});
|
|
432
|
-
|
|
433
|
-
// What the vacuity guard must ACCEPT: 0 checked is fine whenever no filled
|
|
434
|
-
// post-switch row of the latest run is missing its member row.
|
|
435
|
-
test("check: 0 checked still passes when every row is pre-switch, blank, or has several member rows", (t) => {
|
|
436
|
-
const f = fixture(t, {
|
|
437
|
-
members: [
|
|
438
|
-
{ member: "impl-11", ticket: 11, type: "task" },
|
|
439
|
-
{ member: "impl-11-b", ticket: 11, type: "task" },
|
|
440
|
-
],
|
|
441
|
-
tierRows: [
|
|
442
|
-
tierRow({ date: PRE_SWITCH, pr: 20, ticket: 10, tier: "opus" }),
|
|
443
|
-
tierRow({ pr: 21, ticket: 10, tier: "" }),
|
|
444
|
-
tierRow({ pr: 22, ticket: 11, tier: "default" }),
|
|
445
|
-
],
|
|
446
|
-
});
|
|
447
|
-
const r = f.run("check");
|
|
448
|
-
assert.equal(r.code, 0, r.stderr);
|
|
449
|
-
assert.match(r.stdout, /0 checked, 0 failed/);
|
|
450
|
-
});
|
|
451
|
-
|
|
452
|
-
test("check: one checked row keeps a no-member-row sibling a skip, not a failure", (t) => {
|
|
453
|
-
const f = fixture(t, {
|
|
454
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
455
|
-
tierRows: [tierRow({ pr: 20, ticket: 10, tier: "default" }), tierRow({ pr: 21, ticket: 99, tier: "default" })],
|
|
456
|
-
});
|
|
457
|
-
const r = f.run("check");
|
|
458
|
-
assert.equal(r.code, 0, r.stderr);
|
|
459
|
-
assert.match(r.stdout, /1 checked, 0 failed.*1 with no member row/);
|
|
460
|
-
});
|
|
461
|
-
|
|
462
|
-
// Only the latest run is held to the guard: rows of an earlier run that lost
|
|
463
|
-
// their join stay a skip once a later run was checked.
|
|
464
|
-
test("check: an earlier run's lost joins do not fail a later run that was checked", (t) => {
|
|
465
|
-
const f = fixture(t, {
|
|
466
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
467
|
-
tierRows: [
|
|
468
|
-
tierRow({ pr: 20, ticket: 327, tier: "default" }),
|
|
469
|
-
tierRow({ date: LATER, pr: 21, ticket: 10, tier: "default" }),
|
|
470
|
-
],
|
|
471
|
-
});
|
|
472
|
-
const r = f.run("check");
|
|
473
|
-
assert.equal(r.code, 0, r.stdout + r.stderr);
|
|
474
|
-
assert.match(r.stdout, /1 checked, 0 failed.*1 with no member row/);
|
|
475
|
-
});
|
|
476
|
-
|
|
477
|
-
test("check: a missing tier-outcomes.tsv file fails loudly instead of passing 0 checked", (t) => {
|
|
478
|
-
const f = fixture(t, {
|
|
479
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
480
|
-
tierRows: [tierRow({ pr: 20, ticket: 10, tier: "default" })],
|
|
481
|
-
});
|
|
482
|
-
rmSync(f.tier);
|
|
483
|
-
const r = f.run("check");
|
|
484
|
-
assert.equal(r.code, 2);
|
|
485
|
-
assert.match(r.stderr, /no .*tier-outcomes\.tsv — no rows to check/);
|
|
486
|
-
});
|
|
487
|
-
|
|
488
|
-
// Every reader of the file judges the floor as `minted_false_claim === "yes" ||
|
|
489
|
-
// closed_own_ticket === "no"`, so any other spelling would read as a pass.
|
|
490
|
-
test("check: a verdict column that is not yes, no or blank is refused as malformed, on full and legacy rows", (t) => {
|
|
491
|
-
for (const [col, row] of [
|
|
492
|
-
["closed_own_ticket", tierRow({ pr: 21, ticket: 11, tier: "default", closed: "No" })],
|
|
493
|
-
["minted_false_claim", tierRow({ pr: 21, ticket: 11, tier: "default", minted: "YES" })],
|
|
494
|
-
["minted_false_claim", tierRow({ pr: 21, ticket: 11, tier: "default", minted: "no " })],
|
|
495
|
-
["closed_own_ticket", tierRow({ date: PRE_SWITCH, pr: 21, ticket: 11, tier: "opus", closed: "y" }).split("\t").slice(0, LEGACY_WIDTH).join("\t")],
|
|
496
|
-
]) {
|
|
497
|
-
const f = fixture(t, {
|
|
498
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
499
|
-
tierRows: [tierRow({ pr: 20, ticket: 10, tier: "default" }), row],
|
|
500
|
-
});
|
|
501
|
-
const r = f.run("check");
|
|
502
|
-
assert.equal(r.code, 2, `${row}\n${r.stdout}${r.stderr}`);
|
|
503
|
-
const value = row.split("\t")[COLUMNS.indexOf(col)];
|
|
504
|
-
assert.ok(r.stderr.includes(`malformed row: ${col} is '${value}', expected yes, no or blank`), r.stderr);
|
|
505
|
-
assert.equal(r.stdout, "");
|
|
506
|
-
}
|
|
507
|
-
});
|
|
508
|
-
|
|
509
|
-
// What the refusal must ACCEPT: the committed file carries never-ruled rows
|
|
510
|
-
// with both verdict columns blank, and every reader parses the whole file.
|
|
511
|
-
test("check: blank verdict columns and every yes/no pair parse, on full and legacy rows", (t) => {
|
|
512
|
-
const f = fixture(t, {
|
|
513
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
514
|
-
tierRows: [
|
|
515
|
-
tierRow({ date: PRE_SWITCH, pr: 19, ticket: 9, tier: "", closed: "", minted: "" }).split("\t").slice(0, LEGACY_WIDTH).join("\t"),
|
|
516
|
-
tierRow({ pr: 20, ticket: 10, tier: "default", closed: "", minted: "" }),
|
|
517
|
-
tierRow({ pr: 21, ticket: 10, tier: "default", closed: "yes", minted: "yes" }),
|
|
518
|
-
tierRow({ pr: 22, ticket: 10, tier: "default", closed: "no", minted: "no" }),
|
|
519
|
-
tierRow({ pr: 23, ticket: 10, tier: "default", closed: "no", minted: "yes" }),
|
|
520
|
-
],
|
|
521
|
-
});
|
|
522
|
-
const r = f.run("check");
|
|
523
|
-
assert.equal(r.code, 0, r.stdout + r.stderr);
|
|
524
|
-
assert.match(r.stdout, /4 checked, 0 failed/);
|
|
525
|
-
});
|
|
526
|
-
|
|
527
|
-
// A row with ONE verdict column blank is what a hand-edit leaves when it blanks
|
|
528
|
-
// a failing value; `append` never writes it and a no-ruling backfill blanks both.
|
|
529
|
-
test("check: a row with exactly one verdict column blank is refused as malformed, on full and legacy rows", (t) => {
|
|
530
|
-
for (const [closed, minted] of [["", "no"], ["", "yes"], ["yes", ""], ["no", ""]]) {
|
|
531
|
-
for (const legacy of [false, true]) {
|
|
532
|
-
const full = tierRow({ date: legacy ? PRE_SWITCH : TIER_SWITCH_DATE, pr: 21, ticket: 11, tier: "default", closed, minted });
|
|
533
|
-
const row = legacy ? full.split("\t").slice(0, LEGACY_WIDTH).join("\t") : full;
|
|
534
|
-
const f = fixture(t, {
|
|
535
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
536
|
-
tierRows: [tierRow({ pr: 20, ticket: 10, tier: "default" }), row],
|
|
537
|
-
});
|
|
538
|
-
const r = f.run("check");
|
|
539
|
-
const label = `${JSON.stringify({ closed, minted, legacy })}\n${r.stdout}${r.stderr}`;
|
|
540
|
-
assert.equal(r.code, 2, label);
|
|
541
|
-
assert.ok(r.stderr.includes(`malformed row: closed_own_ticket is '${closed}' but minted_false_claim is '${minted}', expected both blank or both yes or no`), label);
|
|
542
|
-
assert.equal(r.stdout, "");
|
|
543
|
-
}
|
|
544
|
-
}
|
|
545
|
-
});
|
|
546
|
-
|
|
547
|
-
test("check --live: warns on each reviewed PR with no row, and the warning alone never fails", (t) => {
|
|
548
|
-
const f = fixture(t, {
|
|
549
|
-
members: [{ member: "impl-10", ticket: 10, type: "fleet-implementer" }],
|
|
550
|
-
tierRows: [tierRow({ pr: 20, ticket: 10, tier: "default" })],
|
|
551
|
-
ledger: {
|
|
552
|
-
rows: [
|
|
553
|
-
"#10 impl-10=PR#20 · reviewed=abcdef1:0/0/0",
|
|
554
|
-
"#13 impl-13=PR#23 · reviewed=abcdef2:1/0/0",
|
|
555
|
-
"#30 review=member:review-pr-30 · reviewed=abcdef3:0/1/0",
|
|
556
|
-
"#14 impl-14=PR#24 · review=member:review-pr-24",
|
|
557
|
-
],
|
|
558
|
-
dispatched: ["impl-10=PR#20", "impl-13=PR#23", "impl-14=PR#24"],
|
|
559
|
-
},
|
|
560
|
-
});
|
|
561
|
-
const r = f.run("check", "--live");
|
|
562
|
-
assert.equal(r.code, 0, r.stderr);
|
|
563
|
-
const warned = [...r.stderr.matchAll(/WARNING PR #(\d+) carries reviewed=/g)].map((m) => Number(m[1]));
|
|
564
|
-
assert.deepEqual(warned, [23, 30], "a reviewed PR with a row, or an unreviewed one, was warned about");
|
|
565
|
-
});
|
|
566
|
-
|
|
567
|
-
test("check --live: a run ledger that does not exist is refused, not read as empty", (t) => {
|
|
568
|
-
const f = fixture(t, { tierRows: [tierRow({ pr: 20, ticket: 10, tier: "" })] });
|
|
569
|
-
const r = f.run("check", "--live");
|
|
570
|
-
assert.equal(r.code, 2);
|
|
571
|
-
assert.match(r.stderr, /ledger/);
|
|
572
|
-
});
|