@feigi/fleet-ctl 3.154.8 → 3.156.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/agents/fleet-finisher.agent.md +1 -1
- package/commands/review-and-fix.md +1 -1
- package/package.json +1 -1
- package/scripts/dispositions-check.mjs +211 -179
- package/scripts/evict-tree.mjs +52 -23
- package/scripts/fleet-event.mjs +7 -7
- package/scripts/fleet-tick.mjs +1 -1
- package/scripts/ledger-grammar.mjs +76 -7
- package/scripts/ledger.mjs +139 -18
- package/scripts/reclaim-scratch.mjs +11 -5
- package/scripts/review-core.mjs +6 -4
- package/scripts/tier-outcomes.mjs +1 -1
- package/skills/run-team/SKILL.md +16 -15
- package/skills/run-team/briefs/fix-applier.md +1 -1
- package/skills/run-team/references/dispositions-escalation.md +5 -5
- package/skills/run-team/references/finisher.md +1 -1
|
@@ -788,7 +788,7 @@ function nextStep(pr, state) {
|
|
|
788
788
|
if (state === "MERGED") {
|
|
789
789
|
return `the PR is merged and its evidence is not there to read — give the verdicts by hand: append ${pr} --closed-own-ticket yes|no --minted-false-claim yes|no --note "<the evidence>"`;
|
|
790
790
|
}
|
|
791
|
-
return `check the record again (\`
|
|
791
|
+
return `check the record again (\`ledger.mjs dispositions fix-pr-${pr} --scratch <scratch>\`), or dispatch the fix-applier again as a dispositions retry (\`--kind dispositions-retry\`), then run append ${pr} again`;
|
|
792
792
|
}
|
|
793
793
|
|
|
794
794
|
// The PR's state as GitHub gives it: OPEN, CLOSED (never merged) or MERGED.
|
package/skills/run-team/SKILL.md
CHANGED
|
@@ -603,13 +603,14 @@ answered by none of the first one's verdicts. A PR whose latest review counts
|
|
|
603
603
|
gated like survivors, and the tick prints `DISPATCH fix-pr PR#<M>` for it: that
|
|
604
604
|
fix-applier's `no-op` and its `ok` verdict are what open the finisher. The
|
|
605
605
|
refusal names its cause. `dispositions
|
|
606
|
-
unchecked` — no verdict answers that review: run `
|
|
607
|
-
the fix-applier that answered the review, as
|
|
608
|
-
entry states, then dispatch again. It names a
|
|
609
|
-
|
|
610
|
-
|
|
606
|
+
unchecked` — no verdict answers that review: run `ledger.mjs dispositions`
|
|
607
|
+
for the fix-applier that answered the review, as
|
|
608
|
+
`fleet-event.mjs`'s `fix-report` entry states, then dispatch again. It names a
|
|
609
|
+
`dispositions-unchecked=` verdict too —
|
|
610
|
+
no rule broke, but the verb could not read where a deferral was filed, `gh`
|
|
611
|
+
unreachable or an issue unreadable: run the verb again for that fix-applier
|
|
611
612
|
once `gh` answers (an issue that does not exist is unreadable too, and no re-run
|
|
612
|
-
answers that one: the
|
|
613
|
+
answers that one: the verb's stderr names it, and the record's issue number
|
|
613
614
|
needs correcting); the tick offers no fix-applier for it. `dispositions
|
|
614
615
|
mismatch` — no finisher: the tick prints `DISPATCH fix-pr PR#<M>` for it, and
|
|
615
616
|
the next-suffix fix-applier answers it (**Then dispatch a fix-applier**).
|
|
@@ -618,7 +619,7 @@ the next-suffix fix-applier answers it (**Then dispatch a fix-applier**).
|
|
|
618
619
|
a second mismatch only with a new review (**Dispositions escalation**). **On any PR with a
|
|
619
620
|
returned review, `0/<n>/0` included, it refuses too while a fix-applier on the
|
|
620
621
|
PR is still live, verdict or not** —
|
|
621
|
-
`fix-pr-<M>[-x] still live`: settle it, run
|
|
622
|
+
`fix-pr-<M>[-x] still live`: settle it, run `ledger.mjs dispositions` for it, then dispatch
|
|
622
623
|
again.
|
|
623
624
|
|
|
624
625
|
**It refuses a finisher, too, while the PR sits on a conflict hold no
|
|
@@ -774,18 +775,18 @@ next suffix (`fix-pr-<M>-b`) and dispatched like the first, its brief rendered w
|
|
|
774
775
|
first one's with the retry paragraph added: `--mismatched-record`, the mismatched member's record
|
|
775
776
|
`<scratch>/dispositions-<member>.json` it starts from, and `--violations`, the check's
|
|
776
777
|
violation list as printed — the lines
|
|
777
|
-
`
|
|
778
|
-
|
|
779
|
-
record, and
|
|
780
|
-
|
|
778
|
+
`ledger.mjs dispositions` printed, each naming a bucket, an index and a rule;
|
|
779
|
+
run it again for the mismatched member to reprint them. It writes its own
|
|
780
|
+
record, and you run it for that one as for the first. `ok` ends it. A second
|
|
781
|
+
failure on the same review is written as
|
|
781
782
|
`dispositions-escalate=fix-pr-<M>-b:<run>` in place of a mismatch: the tick
|
|
782
|
-
prints no `DISPATCH fix-pr` for it. Post the
|
|
783
|
+
prints no `DISPATCH fix-pr` for it. Post the verb's output with
|
|
783
784
|
`gh pr comment <M>`. A second failure is flagged for a human. A new review of
|
|
784
|
-
the PR counts again from none. An escalate whose
|
|
785
|
+
the PR counts again from none. An escalate whose verb printed no violations is
|
|
785
786
|
the maintainer's to answer instead, one yes/no per escalated finding: yes upholds
|
|
786
787
|
the deferral, no sends it back to be applied in this PR. With every finding
|
|
787
|
-
explicitly answered this session, record them with `
|
|
788
|
-
`--uphold` and `--send-back`: `ok` gets the finisher, `mismatch` the tick's
|
|
788
|
+
explicitly answered this session, record them with `ledger.mjs dispositions`
|
|
789
|
+
and its `--uphold` and `--send-back`: `ok` gets the finisher, `mismatch` the tick's
|
|
789
790
|
retry, `escalate` is a second failure. See references/dispositions-escalation.md.
|
|
790
791
|
|
|
791
792
|
### The main-gain hit
|
|
@@ -78,7 +78,7 @@ claim, never your patch.
|
|
|
78
78
|
|
|
79
79
|
**Before you report, write every ruling to `<scratch>/dispositions-<your name>.json`**,
|
|
80
80
|
`<your name>` the `fix-pr-<pr>[-x]` you were dispatched as — the record the controller checks with
|
|
81
|
-
`
|
|
81
|
+
`ledger.mjs dispositions` before it dispatches any finisher.
|
|
82
82
|
|
|
83
83
|
**Charge every standing entry of that record:** which entries stand, and the
|
|
84
84
|
`charge` and `chargeReason` fields, are in `review-and-fix.md`'s step 2. Read
|
|
@@ -1,10 +1,10 @@
|
|
|
1
1
|
# Dispositions escalation: what you do with an escalate
|
|
2
2
|
|
|
3
|
-
What SKILL.md's **Dispositions escalation** points at: the message, the records and the comment that clear a `dispositions escalate` whose
|
|
3
|
+
What SKILL.md's **Dispositions escalation** points at: the message, the records and the comment that clear a `dispositions escalate` whose verb printed no violations — a `critical`, `important` or severity-less finding a fix-applier deferred `remedy-outside-diff`, its record breaking no rule. An escalate whose verb printed violations is a second mismatch on one review: no answer clears it, you comment and flag the PR for a human, and a new review of the PR counts again from none.
|
|
4
4
|
|
|
5
5
|
## Ask the maintainer
|
|
6
6
|
|
|
7
|
-
Post the
|
|
7
|
+
Post the verb's output with `gh pr comment <M>`: it names each escalated finding, and running `ledger.mjs dispositions <member> --scratch <scratch>` again for the escalated member reprints it. Then put one message to the maintainer, with one yes/no for each escalated finding. Each finding is named by:
|
|
8
8
|
|
|
9
9
|
- its address, `<bucket>[<index>]` as the check printed it, its severity and its claim, read from `<scratch>/pr<M>/<run>/review.json`;
|
|
10
10
|
- its remedy files, as the check printed them;
|
|
@@ -18,16 +18,16 @@ Record nothing until every finding has an answer, and nothing without the mainta
|
|
|
18
18
|
|
|
19
19
|
On the answers, in this order:
|
|
20
20
|
|
|
21
|
-
1. Run `
|
|
21
|
+
1. Run `ledger.mjs dispositions <member> --scratch <scratch> --uphold '<list>' --send-back '<list>'`, `<member>` the escalated fix-applier and each list the findings answered that way, `<bucket>[<index>]` separated by commas. Quote each list — `[` opens a glob under zsh — and pass a flag only for a list that has a finding in it. One write puts an `escalation-answer=<run>:<bucket>[<index>]:upheld|sent-back` token per finding on the PR's row and replaces the escalate with the verdict the answers earn. It refuses instead, exit 2 and the ledger untouched, naming the cause: the PR's current verdict on its latest review is not an escalate from that member, a fix-applier on the PR is live, the record breaks a rule, a finding is not one the record escalates or is listed twice or both ways, or an escalated finding has no answer. No other command writes an answer: `ledger.mjs token` and `ledger.mjs row` refuse one.
|
|
22
22
|
2. Record one line per finding: `ledger.mjs ruled <M> "escalation answer <bucket>[<index>]: upheld|sent back — <reason>"`, the maintainer's reason.
|
|
23
23
|
3. Post one PR comment under the escalate comment, quoting the answers.
|
|
24
24
|
|
|
25
25
|
The verdict then decides what follows:
|
|
26
26
|
|
|
27
27
|
- `ok`: dispatch the finisher, as for any `ok`. An upheld finding passes; its deferral is judged by every other rule as before.
|
|
28
|
-
- `mismatch`: a sent-back finding is a broken rule, so the tick prints `DISPATCH fix-pr PR#<M>` and the retry runs as any mismatch's does. The retry's `--violations` are the
|
|
28
|
+
- `mismatch`: a sent-back finding is a broken rule, so the tick prints `DISPATCH fix-pr PR#<M>` and the retry runs as any mismatch's does. The retry's `--violations` are the verb's lines as printed, the sent-back ones included; run the verb again for the member to reprint them. The retry's record is judged with the answers: deferring a sent-back finding again, for any reason, is a second failure, and applying it while deferring an upheld one `remedy-outside-diff` passes.
|
|
29
29
|
- `escalate`: an earlier fix-applier on the review had already failed, so the send-back is the second failure. Comment, flag the PR for a human, and a new review of the PR counts again from none.
|
|
30
|
-
- `unchecked`: the answers are recorded, but a filing could not be read. Run the
|
|
30
|
+
- `unchecked`: the answers are recorded, but a filing could not be read. Run the verb again once `gh` answers; it reads the answers already on the row.
|
|
31
31
|
|
|
32
32
|
An answer belongs to one review. A new review counts from none, so the same finding deferred again on it escalates again.
|
|
33
33
|
|
|
@@ -170,7 +170,7 @@ What does not empty it is noticing the question and dispatching anyway.
|
|
|
170
170
|
the merge.** A deferral of a finding in the review's result is not yours to
|
|
171
171
|
re-judge when the PR's latest review counted a survived or unverified finding:
|
|
172
172
|
`ledger.mjs dispatch` then dispatched you only once the PR's ledger row held a
|
|
173
|
-
`dispositions-ok` verdict from `
|
|
173
|
+
`dispositions-ok` verdict from `ledger.mjs dispositions` on that review
|
|
174
174
|
(`dispositionsRefusal`), and that check had already read back where the
|
|
175
175
|
fix-applier's disposition record says each deferral was filed. That verdict is
|
|
176
176
|
the judgement of those homes: do not halt on a home the script accepted, and
|