@feigi/fleet-ctl 0.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/plugin.json +9 -0
- package/LICENSE +202 -0
- package/NOTICE +18 -0
- package/agents/fleet-finisher.agent.md +7 -0
- package/agents/fleet-implementer-alt.agent.md +210 -0
- package/agents/fleet-implementer.agent.md +210 -0
- package/agents/fleet-merge-bot.agent.md +7 -0
- package/agents/fleet-review-comments.agent.md +40 -0
- package/agents/fleet-review-correctness.agent.md +43 -0
- package/agents/fleet-review-runner.agent.md +73 -0
- package/agents/fleet-review-silent-failure.agent.md +49 -0
- package/agents/fleet-review-simplify.agent.md +46 -0
- package/agents/fleet-review-snapshot.agent.md +24 -0
- package/agents/fleet-review-tests.agent.md +46 -0
- package/agents/fleet-review-types.agent.md +41 -0
- package/agents/fleet-review-verifier.agent.md +29 -0
- package/commands/review-and-fix.md +98 -0
- package/commands/run-merge-bot.md +357 -0
- package/commands/run-team-help.md +17 -0
- package/package.json +23 -0
- package/scripts/agent-test-dir-prose.test.mjs +59 -0
- package/scripts/agent-test.test.mjs +1636 -0
- package/scripts/ambient-git-vars-mjs-prose.test.mjs +354 -0
- package/scripts/ambient-git-vars-prose.test.mjs +192 -0
- package/scripts/ancestry-check-position-prose.test.mjs +175 -0
- package/scripts/apply-ruleset.test.mjs +420 -0
- package/scripts/arg-header-probes-prose.test.mjs +393 -0
- package/scripts/arg.mjs +600 -0
- package/scripts/arg.test.mjs +1354 -0
- package/scripts/board-cli.test.mjs +694 -0
- package/scripts/board-identity.test.mjs +429 -0
- package/scripts/board-liveness-banner.test.mjs +119 -0
- package/scripts/board-prev-shape.test.mjs +229 -0
- package/scripts/board-tryparse-null.test.mjs +119 -0
- package/scripts/board.html +471 -0
- package/scripts/board.mjs +2037 -0
- package/scripts/board.test.mjs +3086 -0
- package/scripts/brief-after-cut-prose.test.mjs +53 -0
- package/scripts/candidates-exit3-prose.test.mjs +302 -0
- package/scripts/candidates.mjs +674 -0
- package/scripts/candidates.test.mjs +2101 -0
- package/scripts/caveat-unification-prose.test.mjs +98 -0
- package/scripts/ci-comment-rot-prose.test.mjs +2025 -0
- package/scripts/ci-completes-premise-prose.test.mjs +257 -0
- package/scripts/ci-state-prose.test.mjs +113 -0
- package/scripts/ci-state.mjs +761 -0
- package/scripts/ci-state.test.mjs +1640 -0
- package/scripts/ci-vacuous-green.test.mjs +368 -0
- package/scripts/citation-sweep-prose.test.mjs +1572 -0
- package/scripts/claim-lifecycle.test.mjs +185 -0
- package/scripts/claim-ticket.sh +417 -0
- package/scripts/claim-ticket.test.mjs +1121 -0
- package/scripts/closing-keyword-prose.test.mjs +193 -0
- package/scripts/cockpit-launch-idempotent-prose.test.mjs +165 -0
- package/scripts/cockpit-tick-nonblocking.test.mjs +210 -0
- package/scripts/compute-board.mjs +579 -0
- package/scripts/compute-board.test.mjs +1060 -0
- package/scripts/compute-spend.mjs +329 -0
- package/scripts/compute-spend.test.mjs +451 -0
- package/scripts/cross-repo-citation-prose.test.mjs +156 -0
- package/scripts/cwd-isolation-pins.mjs +83 -0
- package/scripts/dedupe-guard-prose.test.mjs +243 -0
- package/scripts/derive-testcmd.sh +239 -0
- package/scripts/derive-testcmd.test.mjs +380 -0
- package/scripts/diff-stats.mjs +231 -0
- package/scripts/diff-stats.test.mjs +408 -0
- package/scripts/dispatch-block-golden-prose.test.mjs +1024 -0
- package/scripts/dispatch-block-pins-prose.test.mjs +615 -0
- package/scripts/drop-merged-label.sh +173 -0
- package/scripts/drop-merged-label.test.mjs +480 -0
- package/scripts/expected-jobs-prose.test.mjs +80 -0
- package/scripts/filing-bar-seat-prose.test.mjs +242 -0
- package/scripts/filing-claim-bar-prose.test.mjs +166 -0
- package/scripts/finisher-dispatch-premise-prose.test.mjs +312 -0
- package/scripts/finisher-halt-prose.test.mjs +106 -0
- package/scripts/finisher-name-prose.test.mjs +134 -0
- package/scripts/finisher-own-tree-prose.test.mjs +285 -0
- package/scripts/finisher-pin-race-prose.test.mjs +339 -0
- package/scripts/fix-applier-correction-rules-prose.test.mjs +201 -0
- package/scripts/fix-applier-result-file-prose.test.mjs +100 -0
- package/scripts/fleet-bootstrap +155 -0
- package/scripts/fleet-heartbeat.mjs +272 -0
- package/scripts/fleet-heartbeat.test.mjs +450 -0
- package/scripts/fleet-provenance +207 -0
- package/scripts/fleet-provenance.test.mjs +64 -0
- package/scripts/fleet-run +148 -0
- package/scripts/fleet-run.test.mjs +90 -0
- package/scripts/fleet-state.mjs +400 -0
- package/scripts/fleet-state.test.mjs +373 -0
- package/scripts/fleet-tick-prose.test.mjs +299 -0
- package/scripts/fleet-tick.mjs +832 -0
- package/scripts/fleet-tick.test.mjs +1332 -0
- package/scripts/force-with-lease-reason-prose.test.mjs +184 -0
- package/scripts/frontmatter-allowlist.json +64 -0
- package/scripts/frontmatter-check.mjs +256 -0
- package/scripts/frontmatter-check.test.mjs +436 -0
- package/scripts/git-env.mjs +124 -0
- package/scripts/git-env.test.mjs +149 -0
- package/scripts/git-status-untracked-mode-sweep.test.mjs +216 -0
- package/scripts/gone-walk.test.mjs +213 -0
- package/scripts/gp-sep-invariant-prose.test.mjs +188 -0
- package/scripts/head-moved-after-label-prose.test.mjs +233 -0
- package/scripts/immutable-body-claim-prose.test.mjs +413 -0
- package/scripts/implementer-model-tier.test.mjs +643 -0
- package/scripts/inflight-citation-prose.test.mjs +144 -0
- package/scripts/inflight-exit2-prose.test.mjs +81 -0
- package/scripts/inflight-probe-guard-prose.test.mjs +109 -0
- package/scripts/inflight-scan-scope-prose.test.mjs +57 -0
- package/scripts/inflight.sh +1106 -0
- package/scripts/inflight.test.mjs +2984 -0
- package/scripts/injection-control-prose.test.mjs +404 -0
- package/scripts/install-root-audit.test.mjs +464 -0
- package/scripts/instrument-check-prose.test.mjs +235 -0
- package/scripts/instruments.sh +394 -0
- package/scripts/instruments.test.mjs +787 -0
- package/scripts/issue-tracker-prose.test.mjs +71 -0
- package/scripts/json.sh +248 -0
- package/scripts/json.test.mjs +364 -0
- package/scripts/ledger-dispatch.test.mjs +516 -0
- package/scripts/ledger-grammar.mjs +85 -0
- package/scripts/ledger-grammar.test.mjs +142 -0
- package/scripts/ledger-read-require-file.test.mjs +197 -0
- package/scripts/ledger.mjs +1753 -0
- package/scripts/ledger.test.mjs +3554 -0
- package/scripts/line-distance-prose.test.mjs +245 -0
- package/scripts/liveness-rationale-prose.test.mjs +83 -0
- package/scripts/locale-pin-prose.test.mjs +189 -0
- package/scripts/member-outcome-prose.test.mjs +167 -0
- package/scripts/member-outcomes-header.test.mjs +148 -0
- package/scripts/member-outcomes-prose.test.mjs +63 -0
- package/scripts/member-outcomes.mjs +231 -0
- package/scripts/member-outcomes.test.mjs +507 -0
- package/scripts/member-prompt-prose.test.mjs +161 -0
- package/scripts/member-record.mjs +605 -0
- package/scripts/member-record.test.mjs +516 -0
- package/scripts/member-write-guard.mjs +279 -0
- package/scripts/member-write-guard.test.mjs +211 -0
- package/scripts/merge-commit-probe-prose.test.mjs +122 -0
- package/scripts/merge-gate.mjs +262 -0
- package/scripts/merge-gate.test.mjs +613 -0
- package/scripts/muted-git-guard-sweep.test.mjs +493 -0
- package/scripts/net-ssh-precedence-prose.test.mjs +91 -0
- package/scripts/net-watchdog-prose.test.mjs +79 -0
- package/scripts/net.sh +409 -0
- package/scripts/net.test.mjs +211 -0
- package/scripts/no-ci-gate-prose.test.mjs +108 -0
- package/scripts/no-undo-audit.sh +1134 -0
- package/scripts/no-undo-audit.test.mjs +3965 -0
- package/scripts/no-wave.test.mjs +138 -0
- package/scripts/node-floor-sweep.test.mjs +611 -0
- package/scripts/pointer-target-prose.test.mjs +186 -0
- package/scripts/pr-overlap.mjs +417 -0
- package/scripts/pr-overlap.test.mjs +695 -0
- package/scripts/printf-die-sweep.test.mjs +384 -0
- package/scripts/prompt-renderer.mjs +39 -0
- package/scripts/prompt-renderer.test.mjs +68 -0
- package/scripts/prose-pin.mjs +808 -0
- package/scripts/prose-pin.test.mjs +1034 -0
- package/scripts/prove-merge.sh +228 -0
- package/scripts/prove-merge.test.mjs +995 -0
- package/scripts/pull-table-relabel-prose.test.mjs +60 -0
- package/scripts/quiet-payload-prose.test.mjs +222 -0
- package/scripts/reap.sh +1768 -0
- package/scripts/reap.test.mjs +4395 -0
- package/scripts/reaping-prose.test.mjs +159 -0
- package/scripts/refuter-scratch-prose.test.mjs +135 -0
- package/scripts/release-label-required-prose.test.mjs +71 -0
- package/scripts/release-label-split-prose.test.mjs +169 -0
- package/scripts/release-ticket.sh +1716 -0
- package/scripts/release-ticket.test.mjs +5106 -0
- package/scripts/renovate-release-contract.test.mjs +379 -0
- package/scripts/repo-root.mjs +544 -0
- package/scripts/repo-root.test.mjs +873 -0
- package/scripts/reporter-output-rule-prose.test.mjs +208 -0
- package/scripts/review-agent-report-only.test.mjs +49 -0
- package/scripts/review-core-cwd-isolation.test.mjs +374 -0
- package/scripts/review-core-reads.test.mjs +478 -0
- package/scripts/review-core-refuter-scratch.test.mjs +148 -0
- package/scripts/review-core-snapshot-path.test.mjs +777 -0
- package/scripts/review-core-specialist-scratch.test.mjs +189 -0
- package/scripts/review-core-testcmd.test.mjs +288 -0
- package/scripts/review-core-unrun.test.mjs +530 -0
- package/scripts/review-core-unverified-discriminant.test.mjs +208 -0
- package/scripts/review-core.mjs +1028 -0
- package/scripts/review-eval-resolver-path.test.mjs +55 -0
- package/scripts/review-eval.mjs +197 -0
- package/scripts/review-host-fixture.mjs +73 -0
- package/scripts/review-in-run-retry.test.mjs +187 -0
- package/scripts/review-no-vendor-dispatch.test.mjs +45 -0
- package/scripts/review-path-default.test.mjs +796 -0
- package/scripts/review-runner-spawns.test.mjs +93 -0
- package/scripts/review-runner.test.mjs +155 -0
- package/scripts/review-tier-audit.test.mjs +140 -0
- package/scripts/run-artifact-pr-prose.test.mjs +341 -0
- package/scripts/run-merge-bot-prose.test.mjs +1391 -0
- package/scripts/scratch-partition-invariant-prose.test.mjs +74 -0
- package/scripts/scripts-path-citation-sweep.test.mjs +73 -0
- package/scripts/section-between-guard-prose.test.mjs +378 -0
- package/scripts/select-dimensions.test.mjs +674 -0
- package/scripts/shared-refusal.test.mjs +388 -0
- package/scripts/shell-traps-prose.test.mjs +507 -0
- package/scripts/shortlist.mjs +355 -0
- package/scripts/shortlist.test.mjs +366 -0
- package/scripts/slow-transport.mjs +72 -0
- package/scripts/snapshot-repo.test.mjs +772 -0
- package/scripts/snapshot-runner-audience-prose.test.mjs +129 -0
- package/scripts/spend-view.test.mjs +312 -0
- package/scripts/staleness-qualifier-prose.test.mjs +251 -0
- package/scripts/staleness-verdict-prose.test.mjs +142 -0
- package/scripts/staleness.mjs +414 -0
- package/scripts/staleness.test.mjs +893 -0
- package/scripts/stalled-member-liveness-prose.test.mjs +219 -0
- package/scripts/stash-prohibition-prose.test.mjs +313 -0
- package/scripts/strip-comments.mjs +44 -0
- package/scripts/tier-check.mjs +468 -0
- package/scripts/tier-check.test.mjs +726 -0
- package/scripts/tier-guard-gate-prose.test.mjs +216 -0
- package/scripts/tier-outcomes-header.test.mjs +586 -0
- package/scripts/tier-outcomes.mjs +441 -0
- package/scripts/tier-outcomes.test.mjs +342 -0
- package/scripts/tier-roles.mjs +250 -0
- package/scripts/tier-roles.test.mjs +316 -0
- package/scripts/tracker-block-copy-prose.test.mjs +288 -0
- package/scripts/triage-labels-gloss-prose.test.mjs +97 -0
- package/scripts/unattended-git-sweep.test.mjs +142 -0
- package/scripts/verify-sha-exit2-prose.test.mjs +269 -0
- package/scripts/verify-sha.sh +117 -0
- package/scripts/verify-sha.test.mjs +693 -0
- package/scripts/watcher-degraded-block.test.mjs +372 -0
- package/scripts/watcher-key-prose.test.mjs +106 -0
- package/scripts/within-run-pair-prose.test.mjs +208 -0
- package/scripts/worktree-audit.sh +482 -0
- package/scripts/worktree-audit.test.mjs +1407 -0
- package/scripts/worktree-head-prose.test.mjs +276 -0
- package/scripts/worktree-listing-sweep.test.mjs +217 -0
- package/scripts/worktree-model-prose.test.mjs +216 -0
- package/scripts/worktree.sh +470 -0
- package/skills/next-ticket/SKILL.md +138 -0
- package/skills/run-team/SKILL.md +3603 -0
- package/skills/run-team/references/ci-and-staleness.md +75 -0
- package/skills/run-team/references/correction-tickets.md +37 -0
- package/skills/run-team/references/isolation.md +23 -0
- package/skills/run-team/references/member-lifecycle.md +73 -0
- package/skills/run-team/references/reaping.md +73 -0
- package/skills/sizing-a-ticket/SKILL.md +39 -0
|
@@ -0,0 +1,208 @@
|
|
|
1
|
+
import { test } from "node:test";
|
|
2
|
+
import assert from "node:assert/strict";
|
|
3
|
+
import { readFileSync } from "node:fs";
|
|
4
|
+
import { join } from "node:path";
|
|
5
|
+
import { stripComments } from "./strip-comments.mjs";
|
|
6
|
+
import { between, phrase } from "./prose-pin.mjs";
|
|
7
|
+
import { verdictFor, resumeFor } from "./review-core.mjs";
|
|
8
|
+
|
|
9
|
+
// The band `unverified` had two producers and one shape. A `suggestion` skips
|
|
10
|
+
// the adversarial pass because the workflow budgets that band 0 refuters, and a
|
|
11
|
+
// finding whose refuters were all dispatched and all died reaches the same band
|
|
12
|
+
// with the same empty vote list — so a consumer read "nothing looked, on
|
|
13
|
+
// purpose" and "nothing looked, by accident" off byte-identical objects (#591).
|
|
14
|
+
//
|
|
15
|
+
// Nothing in this suite could see that: both shapes were produced inside the
|
|
16
|
+
// verify closure, which no test can reach, and the two were equal anyway, so
|
|
17
|
+
// even a test that reached them would have had nothing to assert a difference
|
|
18
|
+
// against. This file is that missing eye — it drives BOTH shapes and asserts
|
|
19
|
+
// they differ.
|
|
20
|
+
//
|
|
21
|
+
// Pins that read source read CODE, not SOURCE: `stripComments` exists because
|
|
22
|
+
// pins in this directory were measured vacuous against a field commented out
|
|
23
|
+
// (see strip-comments.mjs), and a pin written against raw source passes with
|
|
24
|
+
// the thing it pins dead.
|
|
25
|
+
const REPO = join(import.meta.dirname, "..");
|
|
26
|
+
const SOURCE = readFileSync(join(REPO, "scripts", "review-core.mjs"), "utf8");
|
|
27
|
+
const CODE = stripComments(SOURCE);
|
|
28
|
+
|
|
29
|
+
// --- the discriminant -----------------------------------------------------
|
|
30
|
+
|
|
31
|
+
// #591's case, and the only assertion that would have caught the defect: both
|
|
32
|
+
// calls are the `unverified` band, both carry no surviving vote, and a consumer
|
|
33
|
+
// must still be able to tell them apart from the payload alone.
|
|
34
|
+
test("a policy skip and a crash reach the same band and differ on refutersDispatched", () => {
|
|
35
|
+
const skipped = verdictFor(0, []);
|
|
36
|
+
const crashed = verdictFor(2, [null, null]);
|
|
37
|
+
|
|
38
|
+
assert.equal(skipped.verdict, "unverified", "a band with 0 refuters budgeted is not unverified");
|
|
39
|
+
assert.equal(crashed.verdict, "unverified", "every refuter died and the finding did not land in unverified");
|
|
40
|
+
|
|
41
|
+
// The vote list is what a consumer had BEFORE this field, and it is equal on
|
|
42
|
+
// both — pinned here so the discriminant cannot quietly become "read the
|
|
43
|
+
// votes", which is the read that could not tell them apart.
|
|
44
|
+
assert.deepEqual(skipped.votes, [], "a policy skip carries votes that were never cast");
|
|
45
|
+
assert.deepEqual(crashed.votes, [], "a crashed refuter left a vote behind — `votes` no longer filters the dead");
|
|
46
|
+
|
|
47
|
+
assert.equal(skipped.refutersDispatched, 0, "a policy skip reports refuters it never dispatched");
|
|
48
|
+
assert.ok(
|
|
49
|
+
crashed.refutersDispatched > 0,
|
|
50
|
+
"a finding whose refuters all crashed reports none dispatched — indistinguishable from a policy skip again (#591)",
|
|
51
|
+
);
|
|
52
|
+
assert.notDeepEqual(
|
|
53
|
+
skipped,
|
|
54
|
+
crashed,
|
|
55
|
+
"the two populations are byte-identical again — this is the defect #591 fixed, restored",
|
|
56
|
+
);
|
|
57
|
+
});
|
|
58
|
+
|
|
59
|
+
// The other half, and the one a suite of only-crashed fixtures would not pin:
|
|
60
|
+
// what this must still ACCEPT. Routing both `unverified` producers through one
|
|
61
|
+
// function is a restructure, and a restructure that changed the majority rule
|
|
62
|
+
// would pass every assertion above while silently re-banding real findings.
|
|
63
|
+
test("the majority rule survives the extraction — a live vote list still bands as it did", () => {
|
|
64
|
+
const yes = { refuted: false };
|
|
65
|
+
const no = { refuted: true };
|
|
66
|
+
|
|
67
|
+
assert.equal(verdictFor(2, [yes, yes]).verdict, "survived", "an unrefuted finding no longer survives");
|
|
68
|
+
assert.equal(verdictFor(2, [no, no]).verdict, "refuted", "a unanimously refuted finding no longer refutes");
|
|
69
|
+
// The tie is `refuted * 2 >= live.length`, so a 1-1 split refutes. Pinned
|
|
70
|
+
// because it is the branch an inverted comparison keeps green on every other
|
|
71
|
+
// input, and because it is the one the controller is told to read the votes
|
|
72
|
+
// on rather than the band.
|
|
73
|
+
assert.equal(verdictFor(2, [yes, no]).verdict, "refuted", "a 1-1 split no longer refutes");
|
|
74
|
+
// A dead refuter alongside live ones is filtered, so it neither votes nor
|
|
75
|
+
// changes the denominator: one live unrefuted vote out of two dispatched is
|
|
76
|
+
// survived, not a tie.
|
|
77
|
+
assert.equal(verdictFor(2, [yes, null]).verdict, "survived", "a crashed refuter is being counted as a vote");
|
|
78
|
+
assert.equal(
|
|
79
|
+
verdictFor(3, [yes, null]).refutersDispatched,
|
|
80
|
+
3,
|
|
81
|
+
"refutersDispatched reports the surviving votes rather than the dispatch — the count that makes a crash visible",
|
|
82
|
+
);
|
|
83
|
+
});
|
|
84
|
+
|
|
85
|
+
// --- the call sites -------------------------------------------------------
|
|
86
|
+
|
|
87
|
+
// The lift proves `verdictFor` classifies correctly; it cannot prove the script
|
|
88
|
+
// calls it. Both producers of the band are pinned as text, because a call site
|
|
89
|
+
// is the half no lifted function can see — and one of the two calling it while
|
|
90
|
+
// the other keeps its own inline copy is exactly the state #591 describes.
|
|
91
|
+
//
|
|
92
|
+
// Each is pinned as the WHOLE returned expression, spread included, and not as
|
|
93
|
+
// a span that any mention of `verdictFor` inside it satisfies. A span is the
|
|
94
|
+
// weaker pin and it does not hold: `stripComments` documents its own ceiling —
|
|
95
|
+
// an inline `/* */` and a trailing `//` keep their text — so a revert that
|
|
96
|
+
// rebuilds the object inline and leaves the call named in a surviving comment
|
|
97
|
+
// puts the pinned token back where the span reads it. Measured on both spans
|
|
98
|
+
// while they were still written that way: each revert passed with its comment
|
|
99
|
+
// and failed without it, which is the pin discriminating on comment text.
|
|
100
|
+
test("both producers of the unverified band route through verdictFor", () => {
|
|
101
|
+
assert.match(
|
|
102
|
+
CODE,
|
|
103
|
+
/if \(n === 0\) return Promise\.resolve\(\{ \.\.\.f, dimension: d\.key, \.\.\.verdictFor\(0, \[\]\) \}\);/,
|
|
104
|
+
"the policy-skip branch builds its own verdict again instead of routing through verdictFor (#591)",
|
|
105
|
+
);
|
|
106
|
+
|
|
107
|
+
// #1813 (crash isolation) turned the single-argument `.then((votes) => {...})`
|
|
108
|
+
// into a two-argument `.then(onFulfilled, onRejected)`: a `retryCrashed`
|
|
109
|
+
// rejection (both dispatches of the refuter pair crashed) must still land
|
|
110
|
+
// in `unverified` through `verdictFor`, not propagate into the shared
|
|
111
|
+
// `Promise.all` and erase every OTHER finding in the dimension. Both
|
|
112
|
+
// branches are pinned in the SAME `.then(...)` call — a revert that keeps
|
|
113
|
+
// the rejected branch but drops the fulfilled one (or the reverse) fails
|
|
114
|
+
// this just as a revert to the old single-argument shape does.
|
|
115
|
+
assert.match(
|
|
116
|
+
CODE,
|
|
117
|
+
/\.then\(\s*\(votes\) => \(\{ \.\.\.f, dimension: d\.key, \.\.\.verdictFor\(n, votes\) \}\),\s*\(\) => \(\{ \.\.\.f, dimension: d\.key, \.\.\.verdictFor\(n, \[\]\) \}\),\s*\);/,
|
|
118
|
+
"the post-refuter .then() no longer routes both the fulfilled and the crashed-refuter branch through verdictFor (#591, #1813)",
|
|
119
|
+
);
|
|
120
|
+
// The dispatched count is what the discriminant IS, so a call passing a
|
|
121
|
+
// literal or a re-derived value would pin nothing. `n` is the value the
|
|
122
|
+
// policy-skip branch tests, which is what makes the field free.
|
|
123
|
+
assert.match(CODE, /const n = verifiersForRun\(f\.severity\)/, "the dispatched count is no longer `n` — update this test");
|
|
124
|
+
});
|
|
125
|
+
|
|
126
|
+
// --- the resume path ------------------------------------------------------
|
|
127
|
+
|
|
128
|
+
// A crash-heavy `unverified` is DEFERRED: omp's eval has no cached-replay
|
|
129
|
+
// mechanism (ADR 0004/0005, #1349 gap 1), so a relaunch re-dispatches every
|
|
130
|
+
// agent() live rather than resuming only the calls that died — the response
|
|
131
|
+
// is defer, reported and not acted on. That was true before this ticket and
|
|
132
|
+
// was written down nowhere a reader of the result would meet it.
|
|
133
|
+
test("the returned object carries resume alongside the three bands", () => {
|
|
134
|
+
const tail = CODE.slice(CODE.lastIndexOf("return {"));
|
|
135
|
+
for (const key of ["survived", "refuted", "unverified"]) {
|
|
136
|
+
assert.match(tail, new RegExp(`\\b${key}\\b`), `the return no longer surfaces ${key} — an existing consumer just broke`);
|
|
137
|
+
}
|
|
138
|
+
assert.match(tail, /\bresume\b/, "the return never surfaces resume — the recovery path dies in the script (#591)");
|
|
139
|
+
assert.match(
|
|
140
|
+
CODE,
|
|
141
|
+
/reported, not acted on/,
|
|
142
|
+
"the resume string no longer tells the reader what to do with a crashed population — omp has no cached-replay mechanism, so the instruction is defer, not relaunch",
|
|
143
|
+
);
|
|
144
|
+
});
|
|
145
|
+
|
|
146
|
+
// The field being present is not the field being right. This drives the real
|
|
147
|
+
// classification over both populations of the band — the half `resume` exists
|
|
148
|
+
// for and the half it must stay quiet on — because a source-text pin on the
|
|
149
|
+
// predicate that separates them passes against its own deletion: measured while
|
|
150
|
+
// the filter was still inline at the report block, deleting it left this file's
|
|
151
|
+
// tests green.
|
|
152
|
+
test("the crash population is the dispatched-refuter half of unverified, and only it arms resume", () => {
|
|
153
|
+
const skipped = { severity: "suggestion", verdict: "unverified", votes: [], refutersDispatched: 0 };
|
|
154
|
+
const crashed = { severity: "critical", verdict: "unverified", votes: [], refutersDispatched: 2 };
|
|
155
|
+
|
|
156
|
+
const quiet = resumeFor([skipped]);
|
|
157
|
+
assert.deepEqual(quiet.crashed, [], "a policy skip counts as a crashed refuter — the two populations read alike again (#591)");
|
|
158
|
+
assert.equal(quiet.resume, null, "a run where nothing died is told to relaunch — the instruction is boilerplate, not a signal");
|
|
159
|
+
|
|
160
|
+
const armed = resumeFor([skipped, crashed]);
|
|
161
|
+
assert.deepEqual(armed.crashed, [crashed], "the crash population no longer separates a dead refuter from a policy skip (#591)");
|
|
162
|
+
assert.match(
|
|
163
|
+
armed.resume,
|
|
164
|
+
/reported, not acted on/,
|
|
165
|
+
"refuters died and the payload names no way to recover them — the findings nobody looked at get deferred instead",
|
|
166
|
+
);
|
|
167
|
+
|
|
168
|
+
// The classification above is reachable from a test whether or not the report
|
|
169
|
+
// block still calls it, so the call is pinned too — dropping the call is the
|
|
170
|
+
// mutation this file stayed green against.
|
|
171
|
+
assert.match(
|
|
172
|
+
CODE,
|
|
173
|
+
/const \{ crashed, resume \} = resumeFor\(unverified\);/,
|
|
174
|
+
"the report no longer derives its crash population and resume from resumeFor (#591)",
|
|
175
|
+
);
|
|
176
|
+
});
|
|
177
|
+
|
|
178
|
+
// --- the reading rules ----------------------------------------------------
|
|
179
|
+
|
|
180
|
+
// The rule that saves a reader — a finding whose refuters ran and crashed
|
|
181
|
+
// always defers — predates the field it can now be checked against, and it
|
|
182
|
+
// lived in more than one file. A rule re-expressed in one copy and left resting
|
|
183
|
+
// on the reader in the other is the defect moved, not fixed.
|
|
184
|
+
const RULE_FILES = [
|
|
185
|
+
["commands/review-and-fix.md", "A finding in `unverified` whose refuters ran and", "Only a `survived` finding"],
|
|
186
|
+
["skills/run-team/SKILL.md", "Apply `survived` findings. A finding in `unverified`", "Severity records how much"],
|
|
187
|
+
];
|
|
188
|
+
|
|
189
|
+
for (const [rel, from, to] of RULE_FILES) {
|
|
190
|
+
test(`${rel}'s crashed-refuter rule cites the discriminant`, () => {
|
|
191
|
+
const doc = readFileSync(join(REPO, rel), "utf8");
|
|
192
|
+
const rule = between(doc, from, to, rel);
|
|
193
|
+
assert.match(
|
|
194
|
+
rule,
|
|
195
|
+
phrase("refutersDispatched"),
|
|
196
|
+
`${rel} still asks the reader to remember which population a finding is in — the rule names no field to check (#591)`,
|
|
197
|
+
);
|
|
198
|
+
});
|
|
199
|
+
}
|
|
200
|
+
|
|
201
|
+
// The controller is the other reader, and it meets the return shape rather than
|
|
202
|
+
// the apply rule. A field nobody is told to read is a field nobody reads.
|
|
203
|
+
test("run-team's Reviewers section documents the discriminant and the resume path", () => {
|
|
204
|
+
const doc = readFileSync(join(REPO, "skills/run-team/SKILL.md"), "utf8");
|
|
205
|
+
const shape = between(doc, "It returns `{pr, head, resume, testEnvironment,", "**`dimensionsRun` is the dispatch", "run-team/SKILL.md");
|
|
206
|
+
assert.match(shape, phrase("refutersDispatched"), "run-team/SKILL.md documents a return shape whose two unverified populations still read alike");
|
|
207
|
+
assert.match(shape, phrase("resume"), "run-team/SKILL.md documents the crashed band without the recovery it has");
|
|
208
|
+
});
|