@fedify/webfinger 2.3.0-dev.994 → 2.3.0-pr.809.36

package/src/lookup.test.ts

@@ -1,7 +1,7 @@
-import { test } from "@fedify/fixture";
+import { createTestMeterProvider, test } from "@fedify/fixture";
 import { withTimeout } from "es-toolkit";
 import fetchMock from "fetch-mock";
-import { deepStrictEqual } from "node:assert/strict";
+import { deepStrictEqual, ok } from "node:assert/strict";
 import type { ResourceDescriptor } from "./jrd.ts";
 import { lookupWebFinger } from "./lookup.ts";
 
@@ -15,6 +15,21 @@ test({
       deepStrictEqual(await lookupWebFinger(new URL("acct:johndoe")), null);
       deepStrictEqual(await lookupWebFinger("acct:johndoe@"), null);
       deepStrictEqual(await lookupWebFinger(new URL("acct:johndoe@")), null);
+      // Per RFC 7565, the acct: authority is bare `host`: no path,
+      // query, or fragment is allowed.  Reject such inputs rather than
+      // forwarding them to a remote WebFinger lookup.
+      deepStrictEqual(
+        await lookupWebFinger("acct:johndoe@example.com/exploit"),
+        null,
+      );
+      deepStrictEqual(
+        await lookupWebFinger("acct:johndoe@example.com?x=1"),
+        null,
+      );
+      deepStrictEqual(
+        await lookupWebFinger("acct:johndoe@example.com#frag"),
+        null,
+      );
     });
 
     await t.step("connection refused", async () => {
@@ -29,81 +44,117 @@ test({
     });
 
     fetchMock.spyGlobal();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      { status: 404 },
-    );
+    // Wrap the rest of the outer test in try/finally so the global
+    // `fetch` spy is torn down even if a t.step assertion below
+    // throws.  Matches the cleanup pattern of the metrics test
+    // further down in this file.
+    try {
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        { status: 404 },
+      );
 
-    await t.step("not found", async () => {
-      deepStrictEqual(await lookupWebFinger("acct:johndoe@example.com"), null);
-      deepStrictEqual(await lookupWebFinger("https://example.com/foo"), null);
-    });
+      await t.step("not found", async () => {
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com"),
+          null,
+        );
+        deepStrictEqual(await lookupWebFinger("https://example.com/foo"), null);
+      });
 
-    const expected: ResourceDescriptor = {
-      subject: "acct:johndoe@example.com",
-      links: [],
-    };
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "https://example.com/.well-known/webfinger?resource=acct%3Ajohndoe%40example.com",
-      { body: expected },
-    );
+      const expected: ResourceDescriptor = {
+        subject: "acct:johndoe@example.com",
+        links: [],
+      };
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "https://example.com/.well-known/webfinger?resource=acct%3Ajohndoe%40example.com",
+        { body: expected },
+      );
 
-    await t.step("acct", async () => {
-      deepStrictEqual(
-        await lookupWebFinger("acct:johndoe@example.com"),
-        expected,
+      await t.step("acct", async () => {
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com"),
+          expected,
+        );
+      });
+
+      const expected2: ResourceDescriptor = {
+        subject: "https://example.com/foo",
+        links: [],
+      };
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "https://example.com/.well-known/webfinger?resource=https%3A%2F%2Fexample.com%2Ffoo",
+        { body: expected2 },
       );
-    });
 
-    const expected2: ResourceDescriptor = {
-      subject: "https://example.com/foo",
-      links: [],
-    };
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "https://example.com/.well-known/webfinger?resource=https%3A%2F%2Fexample.com%2Ffoo",
-      { body: expected2 },
-    );
+      await t.step("https", async () => {
+        deepStrictEqual(
+          await lookupWebFinger("https://example.com/foo"),
+          expected2,
+        );
+      });
 
-    await t.step("https", async () => {
-      deepStrictEqual(
-        await lookupWebFinger("https://example.com/foo"),
-        expected2,
+      const mailtoExpected: ResourceDescriptor = {
+        subject: "mailto:juliet@example.com",
+        links: [],
+      };
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "https://example.com/.well-known/webfinger?resource=mailto%3Ajuliet%40example.com",
+        { body: mailtoExpected },
       );
-    });
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      { body: "not json" },
-    );
+      await t.step("mailto", async () => {
+        // RFC 7033 permits any URI as a WebFinger resource, and RFC 7565
+        // explicitly references `mailto:` as an example.  The opaque-path
+        // host extraction (after the last `@`) applies to `mailto:` just
+        // like `acct:`.
+        deepStrictEqual(
+          await lookupWebFinger("mailto:juliet@example.com"),
+          mailtoExpected,
+        );
+      });
 
-    await t.step("invalid response", async () => {
-      deepStrictEqual(await lookupWebFinger("acct:johndoe@example.com"), null);
-    });
+      const mailtoQueryExpected: ResourceDescriptor = {
+        subject: "mailto:juliet@example.com?subject=Hi",
+        links: [],
+      };
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "https://example.com/.well-known/webfinger?resource=mailto%3Ajuliet%40example.com%3Fsubject%3DHi",
+        { body: mailtoQueryExpected },
+      );
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://localhost/.well-known/webfinger?",
-      {
-        subject: "acct:test@localhost",
-        links: [
-          {
-            rel: "self",
-            type: "application/activity+json",
-            href: "https://localhost/actor",
-          },
-        ],
-      },
-    );
+      await t.step("mailto with hfields", async () => {
+        // RFC 6068 §2 allows `mailto:` URIs to carry `?hfields=...`
+        // header fields and fragment identifiers.  Unlike `acct:`,
+        // those components are part of the grammar, so the lookup
+        // must accept them and forward the full resource URI to the
+        // WebFinger endpoint.
+        deepStrictEqual(
+          await lookupWebFinger("mailto:juliet@example.com?subject=Hi"),
+          mailtoQueryExpected,
+        );
+      });
 
-    await t.step("private address", async () => {
-      deepStrictEqual(await lookupWebFinger("acct:test@localhost"), null);
-      deepStrictEqual(
-        await lookupWebFinger("acct:test@localhost", {
-          allowPrivateAddress: true,
-        }),
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        { body: "not json" },
+      );
+
+      await t.step("invalid response", async () => {
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com"),
+          null,
+        );
+      });
+
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://localhost/.well-known/webfinger?",
         {
           subject: "acct:test@localhost",
           links: [
@@ -115,217 +166,723 @@ test({
           ],
         },
       );
-    });
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      {
-        status: 302,
-        headers: { Location: "/.well-known/webfinger2" },
-      },
-    );
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger2",
-      { body: expected },
-    );
+      await t.step("private address", async () => {
+        deepStrictEqual(await lookupWebFinger("acct:test@localhost"), null);
+        deepStrictEqual(
+          await lookupWebFinger("acct:test@localhost", {
+            allowPrivateAddress: true,
+          }),
+          {
+            subject: "acct:test@localhost",
+            links: [
+              {
+                rel: "self",
+                type: "application/activity+json",
+                href: "https://localhost/actor",
+              },
+            ],
+          },
+        );
+      });
 
-    await t.step("redirection", async () => {
-      deepStrictEqual(
-        await lookupWebFinger("acct:johndoe@example.com"),
-        expected,
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        {
+          status: 302,
+          headers: { Location: "/.well-known/webfinger2" },
+        },
+      );
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger2",
+        { body: expected },
       );
-    });
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      {
-        status: 302,
-        headers: { Location: "/.well-known/webfinger" },
-      },
-    );
+      await t.step("redirection", async () => {
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com"),
+          expected,
+        );
+      });
 
-    await t.step("infinite redirection", async () => {
-      const result = await withTimeout(
-        () => lookupWebFinger("acct:johndoe@example.com"),
-        2000,
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        {
+          status: 302,
+          headers: { Location: "/.well-known/webfinger" },
+        },
       );
-      deepStrictEqual(result, null);
-    });
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      {
-        status: 302,
-        headers: { Location: "ftp://example.com/" },
-      },
-    );
+      await t.step("infinite redirection", async () => {
+        const result = await withTimeout(
+          () => lookupWebFinger("acct:johndoe@example.com"),
+          2000,
+        );
+        deepStrictEqual(result, null);
+      });
 
-    await t.step("redirection to different protocol", async () => {
-      deepStrictEqual(await lookupWebFinger("acct:johndoe@example.com"), null);
-    });
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        {
+          status: 302,
+          headers: { Location: "ftp://example.com/" },
+        },
+      );
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      {
-        status: 302,
-        headers: { Location: "https://localhost/" },
+      await t.step("redirection to different protocol", async () => {
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com"),
+          null,
+        );
+      });
+
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        {
+          status: 302,
+          headers: { Location: "https://localhost/" },
+        },
+      );
+
+      await t.step("redirection to private address", async () => {
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com"),
+          null,
+        );
+      });
+
+      fetchMock.removeRoutes();
+      let redirectCount = 0;
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger",
+        () => {
+          redirectCount++;
+          if (redirectCount < 3) {
+            return {
+              status: 302,
+              headers: {
+                Location: `/.well-known/webfinger?redirect=${redirectCount}`,
+              },
+            };
+          }
+          return { body: expected };
+        },
+      );
+
+      await t.step("custom maxRedirection", async () => {
+        // Test with maxRedirection: 1 (should fail; mock has 2 redirects)
+        redirectCount = 0;
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com", {
+            maxRedirection: 1,
+          }),
+          null,
+        );
+
+        // Test with maxRedirection: 2 (should succeed; mock has exactly 2
+        // redirects, and `maxRedirection: N` follows up to N redirects)
+        redirectCount = 0;
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com", {
+            maxRedirection: 2,
+          }),
+          expected,
+        );
+
+        // Test with maxRedirection: 3 (should succeed)
+        redirectCount = 0;
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com", {
+            maxRedirection: 3,
+          }),
+          expected,
+        );
+
+        // Test with default maxRedirection: 5 (should succeed)
+        redirectCount = 0;
+        deepStrictEqual(
+          await lookupWebFinger("acct:johndoe@example.com"),
+          expected,
+        );
+      });
+
+      // Regression: `maxRedirection: 1` must allow exactly one 302 to be
+      // followed.  An earlier implementation incremented the counter before
+      // the `>=` check, so `maxRedirection: 1` rejected the first redirect
+      // instead of following it.  The expected semantics is "follow up to
+      // N redirects".
+      await t.step(
+        "maxRedirection: 1 follows exactly one redirect",
+        async () => {
+          // Mock with a single redirect: 302 → 200.  Under the corrected
+          // semantics, `maxRedirection: 1` follows it and reaches the body.
+          fetchMock.removeRoutes();
+          let count = 0;
+          fetchMock.get(
+            "begin:https://example.com/.well-known/webfinger",
+            () => {
+              count++;
+              return count < 2
+                ? {
+                  status: 302,
+                  headers: { Location: "/.well-known/webfinger?after=1" },
+                }
+                : { body: expected };
+            },
+          );
+          deepStrictEqual(
+            await lookupWebFinger("acct:johndoe@example.com", {
+              maxRedirection: 1,
+            }),
+            expected,
+          );
+
+          // Mock with two redirects.  `maxRedirection: 1` rejects the
+          // second redirect.
+          fetchMock.removeRoutes();
+          count = 0;
+          fetchMock.get(
+            "begin:https://example.com/.well-known/webfinger",
+            () => {
+              count++;
+              return count < 3
+                ? {
+                  status: 302,
+                  headers: {
+                    Location: `/.well-known/webfinger?after=${count}`,
+                  },
+                }
+                : { body: expected };
+            },
+          );
+          deepStrictEqual(
+            await lookupWebFinger("acct:johndoe@example.com", {
+              maxRedirection: 1,
+            }),
+            null,
+          );
+        },
+      );
+
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        () =>
+          new Promise((resolve) => {
+            const timeoutId = setTimeout(() => {
+              resolve({ body: expected });
+            }, 1000);
+
+            return () => clearTimeout(timeoutId);
+          }),
+      );
+
+      await t.step("request cancellation", async () => {
+        // Test cancelling a request immediately using AbortController
+        const controller = new AbortController();
+        const promise = lookupWebFinger("acct:johndoe@example.com", {
+          signal: controller.signal,
+        });
+
+        // Abort the request right after starting it
+        controller.abort();
+        deepStrictEqual(await promise, null);
+      });
+
+      fetchMock.removeRoutes();
+      let redirectCount2 = 0;
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger",
+        () => {
+          redirectCount2++;
+          if (redirectCount2 === 1) {
+            return {
+              status: 302,
+              headers: { Location: "/.well-known/webfinger2" },
+            };
+          }
+          return new Promise((resolve) => {
+            const timeoutId = setTimeout(() => {
+              resolve({ body: expected });
+            }, 1000);
+
+            return () => clearTimeout(timeoutId);
+          });
+        },
+      );
+
+      await t.step("cancellation during redirection", async () => {
+        // Test cancelling a request during redirection process
+        const controller = new AbortController();
+        const promise = lookupWebFinger("acct:johndoe@example.com", {
+          signal: controller.signal,
+        });
+
+        // Cancel during the delayed second request after redirection
+        setTimeout(() => controller.abort(), 100);
+        deepStrictEqual(await promise, null);
+      });
+
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        () =>
+          new Promise((resolve) => {
+            const timeoutId = setTimeout(() => {
+              resolve({ body: expected });
+            }, 500);
+
+            return () => clearTimeout(timeoutId);
+          }),
+      );
+
+      await t.step("cancellation with immediate abort", async () => {
+        // Test starting a request with an already aborted AbortController
+        const controller = new AbortController();
+        controller.abort();
+
+        // Use a signal that was already aborted before starting the request
+        const result = await lookupWebFinger("acct:johndoe@example.com", {
+          signal: controller.signal,
+        });
+        deepStrictEqual(result, null);
+      });
+
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        { body: expected },
+      );
+
+      await t.step("successful request with signal", async () => {
+        // Test successful request with a normal AbortController signal
+        const controller = new AbortController();
+        const result = await lookupWebFinger("acct:johndoe@example.com", {
+          signal: controller.signal,
+        });
+        deepStrictEqual(result, expected);
+      });
+    } finally {
+      fetchMock.removeRoutes();
+      fetchMock.hardReset();
+    }
+  },
+});
+
+test("lookupWebFinger() records webfinger.lookup counter and duration", {
+  sanitizeOps: false,
+  sanitizeResources: false,
+}, async (t) => {
+  fetchMock.spyGlobal();
+  try {
+    const expected: ResourceDescriptor = {
+      subject: "acct:johndoe@example.com",
+      links: [],
+    };
+
+    await t.step(
+      "records result=found for a successful acct lookup",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "https://example.com/.well-known/webfinger?resource=acct%3Ajohndoe%40example.com",
+          { body: expected },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        const result = await lookupWebFinger("acct:johndoe@example.com", {
+          meterProvider,
+        });
+        deepStrictEqual(result, expected);
+
+        const counters = recorder.getMeasurements("webfinger.lookup");
+        deepStrictEqual(counters.length, 1);
+        deepStrictEqual(counters[0].type, "counter");
+        deepStrictEqual(counters[0].value, 1);
+        deepStrictEqual(
+          counters[0].attributes["webfinger.lookup.result"],
+          "found",
+        );
+        deepStrictEqual(
+          counters[0].attributes["webfinger.resource.scheme"],
+          "acct",
+        );
+        deepStrictEqual(
+          counters[0].attributes["activitypub.remote.host"],
+          "example.com",
+        );
+        deepStrictEqual(
+          counters[0].attributes["http.response.status_code"],
+          200,
+        );
+
+        const durations = recorder.getMeasurements("webfinger.lookup.duration");
+        deepStrictEqual(durations.length, 1);
+        deepStrictEqual(durations[0].type, "histogram");
+        deepStrictEqual(
+          durations[0].attributes["webfinger.lookup.result"],
+          "found",
+        );
+        deepStrictEqual(
+          durations[0].attributes["webfinger.resource.scheme"],
+          "acct",
+        );
+        ok(typeof durations[0].value === "number" && durations[0].value >= 0);
       },
     );
 
-    await t.step("redirection to private address", async () => {
-      deepStrictEqual(await lookupWebFinger("acct:johndoe@example.com"), null);
-    });
+    await t.step(
+      "records scheme=https for an https resource lookup",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "https://example.com/.well-known/webfinger?resource=https%3A%2F%2Fexample.com%2Ffoo",
+          { body: { subject: "https://example.com/foo", links: [] } },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        await lookupWebFinger("https://example.com/foo", { meterProvider });
+        const counters = recorder.getMeasurements("webfinger.lookup");
+        deepStrictEqual(counters.length, 1);
+        deepStrictEqual(
+          counters[0].attributes["webfinger.resource.scheme"],
+          "https",
+        );
+        deepStrictEqual(
+          counters[0].attributes["webfinger.lookup.result"],
+          "found",
+        );
+      },
+    );
 
-    fetchMock.removeRoutes();
-    let redirectCount = 0;
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger",
-      () => {
-        redirectCount++;
-        if (redirectCount < 3) {
-          return {
-            status: 302,
-            headers: {
-              Location: `/.well-known/webfinger?redirect=${redirectCount}`,
-            },
-          };
-        }
-        return { body: expected };
+    await t.step(
+      "records non-default ports for URL resources",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "https://example.com:8443/.well-known/webfinger?resource=https%3A%2F%2Fexample.com%3A8443%2Ffoo",
+          { body: { subject: "https://example.com:8443/foo", links: [] } },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        await lookupWebFinger("https://example.com:8443/foo", {
+          meterProvider,
+        });
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["activitypub.remote.host"],
+          "example.com:8443",
+        );
       },
     );
 
-    await t.step("custom maxRedirection", async () => {
-      // Test with maxRedirection: 2 (should fail)
-      redirectCount = 0;
+    await t.step("records result=not_found with status 404", async () => {
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        { status: 404 },
+      );
+      const [meterProvider, recorder] = createTestMeterProvider();
+      const result = await lookupWebFinger("acct:johndoe@example.com", {
+        meterProvider,
+      });
+      deepStrictEqual(result, null);
+
+      const counters = recorder.getMeasurements("webfinger.lookup");
+      deepStrictEqual(counters.length, 1);
       deepStrictEqual(
-        await lookupWebFinger("acct:johndoe@example.com", {
-          maxRedirection: 2,
-        }),
-        null,
+        counters[0].attributes["webfinger.lookup.result"],
+        "not_found",
+      );
+      deepStrictEqual(
+        counters[0].attributes["http.response.status_code"],
+        404,
+      );
+      deepStrictEqual(
+        counters[0].attributes["activitypub.remote.host"],
+        "example.com",
       );
 
-      // Test with maxRedirection: 3 (should succeed)
-      redirectCount = 0;
+      const durations = recorder.getMeasurements("webfinger.lookup.duration");
+      deepStrictEqual(durations.length, 1);
       deepStrictEqual(
-        await lookupWebFinger("acct:johndoe@example.com", {
-          maxRedirection: 3,
-        }),
-        expected,
+        durations[0].attributes["webfinger.lookup.result"],
+        "not_found",
       );
+    });
 
-      // Test with default maxRedirection: 5 (should succeed)
-      redirectCount = 0;
+    await t.step("records result=not_found with status 410", async () => {
+      fetchMock.removeRoutes();
+      fetchMock.get(
+        "begin:https://example.com/.well-known/webfinger?",
+        { status: 410 },
+      );
+      const [meterProvider, recorder] = createTestMeterProvider();
+      await lookupWebFinger("acct:johndoe@example.com", { meterProvider });
+      const counter = recorder.getMeasurement("webfinger.lookup");
+      ok(counter != null);
       deepStrictEqual(
-        await lookupWebFinger("acct:johndoe@example.com"),
-        expected,
+        counter.attributes["webfinger.lookup.result"],
+        "not_found",
       );
+      deepStrictEqual(counter.attributes["http.response.status_code"], 410);
     });
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      () =>
-        new Promise((resolve) => {
-          const timeoutId = setTimeout(() => {
-            resolve({ body: expected });
-          }, 1000);
-
-          return () => clearTimeout(timeoutId);
-        }),
+    await t.step(
+      "records result=error for non-2xx, non-404/410 HTTP responses",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "begin:https://example.com/.well-known/webfinger?",
+          { status: 500 },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        await lookupWebFinger("acct:johndoe@example.com", { meterProvider });
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.lookup.result"],
+          "error",
+        );
+        deepStrictEqual(counter.attributes["http.response.status_code"], 500);
+      },
     );
 
-    await t.step("request cancellation", async () => {
-      // Test cancelling a request immediately using AbortController
-      const controller = new AbortController();
-      const promise = lookupWebFinger("acct:johndoe@example.com", {
-        signal: controller.signal,
-      });
-
-      // Abort the request right after starting it
-      controller.abort();
-      deepStrictEqual(await promise, null);
-    });
-
-    fetchMock.removeRoutes();
-    let redirectCount2 = 0;
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger",
-      () => {
-        redirectCount2++;
-        if (redirectCount2 === 1) {
-          return {
-            status: 302,
-            headers: { Location: "/.well-known/webfinger2" },
-          };
-        }
-        return new Promise((resolve) => {
-          const timeoutId = setTimeout(() => {
-            resolve({ body: expected });
-          }, 1000);
-
-          return () => clearTimeout(timeoutId);
-        });
+    await t.step(
+      "records result=invalid for malformed JSON bodies",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "begin:https://example.com/.well-known/webfinger?",
+          { body: "not json" },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        await lookupWebFinger("acct:johndoe@example.com", { meterProvider });
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.lookup.result"],
+          "invalid",
+        );
+        deepStrictEqual(counter.attributes["http.response.status_code"], 200);
       },
     );
 
-    await t.step("cancellation during redirection", async () => {
-      // Test cancelling a request during redirection process
-      const controller = new AbortController();
-      const promise = lookupWebFinger("acct:johndoe@example.com", {
-        signal: controller.signal,
-      });
+    await t.step(
+      "records result=network_error when fetch never reaches the remote",
+      async () => {
+        fetchMock.removeRoutes();
+        const [meterProvider, recorder] = createTestMeterProvider();
+        const result = await lookupWebFinger(
+          "acct:johndoe@fedify-test.internal",
+          { meterProvider },
+        );
+        deepStrictEqual(result, null);
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.lookup.result"],
+          "network_error",
+        );
+        deepStrictEqual(
+          "http.response.status_code" in counter.attributes,
+          false,
+          "no HTTP response means no status code attribute",
+        );
+        deepStrictEqual(
+          counter.attributes["activitypub.remote.host"],
+          "fedify-test.internal",
+        );
+      },
+    );
 
-      // Cancel during the delayed second request after redirection
-      setTimeout(() => controller.abort(), 100);
-      deepStrictEqual(await promise, null);
-    });
+    await t.step(
+      "records result=invalid for malformed acct: resources",
+      async () => {
+        const [meterProvider, recorder] = createTestMeterProvider();
+        const result = await lookupWebFinger("acct:johndoe", { meterProvider });
+        deepStrictEqual(result, null);
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.lookup.result"],
+          "invalid",
+        );
+        deepStrictEqual(
+          counter.attributes["webfinger.resource.scheme"],
+          "acct",
+        );
+        deepStrictEqual(
+          "activitypub.remote.host" in counter.attributes,
+          false,
+          "a malformed acct resource has no usable remote host",
+        );
+      },
+    );
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      () =>
-        new Promise((resolve) => {
-          const timeoutId = setTimeout(() => {
-            resolve({ body: expected });
-          }, 500);
-
-          return () => clearTimeout(timeoutId);
-        }),
+    await t.step(
+      "records result=invalid when the redirect chain exceeds maxRedirection",
+      async () => {
+        fetchMock.removeRoutes();
+        // The redirect Location drops the original `?resource=...` query
+        // string, so the second hop's URL no longer contains a `?`.  The
+        // route pattern omits the trailing `?` so it still matches.
+        fetchMock.get(
+          "begin:https://example.com/.well-known/webfinger",
+          {
+            status: 302,
+            headers: { Location: "/.well-known/webfinger" },
+          },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        const result = await withTimeout(
+          () =>
+            lookupWebFinger("acct:johndoe@example.com", {
+              meterProvider,
+              maxRedirection: 3,
+            }),
+          2000,
+        );
+        deepStrictEqual(result, null);
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.lookup.result"],
+          "invalid",
+        );
+        deepStrictEqual(counter.attributes["http.response.status_code"], 302);
+        deepStrictEqual(
+          counter.attributes["activitypub.remote.host"],
+          "example.com",
+        );
+      },
     );
 
-    await t.step("cancellation with immediate abort", async () => {
-      // Test starting a request with an already aborted AbortController
-      const controller = new AbortController();
-      controller.abort();
+    await t.step(
+      "records result=invalid for cross-protocol redirects",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "begin:https://example.com/.well-known/webfinger?",
+          {
+            status: 302,
+            headers: { Location: "ftp://example.com/" },
+          },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        await lookupWebFinger("acct:johndoe@example.com", { meterProvider });
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.lookup.result"],
+          "invalid",
+        );
+        deepStrictEqual(counter.attributes["http.response.status_code"], 302);
+      },
+    );
 
-      // Use a signal that was already aborted before starting the request
-      const result = await lookupWebFinger("acct:johndoe@example.com", {
-        signal: controller.signal,
-      });
-      deepStrictEqual(result, null);
-    });
+    await t.step(
+      "records result=network_error when a redirect points to a private address",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "begin:https://example.com/.well-known/webfinger?",
+          {
+            status: 302,
+            headers: { Location: "https://localhost/" },
+          },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        await lookupWebFinger("acct:johndoe@example.com", { meterProvider });
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.lookup.result"],
+          "network_error",
+        );
+        deepStrictEqual(
+          counter.attributes["activitypub.remote.host"],
+          "localhost",
+          "remote.host reflects the latest URL we attempted, even after a redirect",
+        );
+      },
+    );
 
-    fetchMock.removeRoutes();
-    fetchMock.get(
-      "begin:https://example.com/.well-known/webfinger?",
-      { body: expected },
+    await t.step(
+      "records result=invalid for malformed Location headers",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "begin:https://example.com/.well-known/webfinger?",
+          {
+            status: 302,
+            headers: { Location: "http://[bad" },
+          },
+        );
+        const [meterProvider, recorder] = createTestMeterProvider();
+        await lookupWebFinger("acct:johndoe@example.com", { meterProvider });
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.lookup.result"],
+          "invalid",
+        );
+        deepStrictEqual(counter.attributes["http.response.status_code"], 302);
+        deepStrictEqual(
+          counter.attributes["activitypub.remote.host"],
+          "example.com",
+        );
+      },
     );
 
-    await t.step("successful request with signal", async () => {
-      // Test successful request with a normal AbortController signal
-      const controller = new AbortController();
-      const result = await lookupWebFinger("acct:johndoe@example.com", {
-        signal: controller.signal,
-      });
-      deepStrictEqual(result, expected);
-    });
+    await t.step(
+      "buckets unknown resource schemes as 'other' to keep metric cardinality bounded",
+      async () => {
+        // Lookups whose redirect chain ends on an unusual scheme (or a
+        // resource the caller passes with a non-fediverse scheme) must
+        // not leak that scheme into the metric attribute.
+        fetchMock.removeRoutes();
+        const [meterProvider, recorder] = createTestMeterProvider();
+        // `ssh:` is not a WebFinger scheme; lookupWebFingerInternal will
+        // attempt to build a host from the URL, fail, and return null.
+        // The metric still records, and its scheme attribute must be
+        // bucketed as `other`.
+        await lookupWebFinger("ssh://example.com/foo", { meterProvider });
+        const counter = recorder.getMeasurement("webfinger.lookup");
+        ok(counter != null);
+        deepStrictEqual(
+          counter.attributes["webfinger.resource.scheme"],
+          "other",
+        );
+      },
+    );
 
+    await t.step(
+      "omits measurements when no meterProvider is provided",
+      async () => {
+        fetchMock.removeRoutes();
+        fetchMock.get(
+          "https://example.com/.well-known/webfinger?resource=acct%3Ajohndoe%40example.com",
+          { body: expected },
+        );
+        const [_unused, recorder] = createTestMeterProvider();
+        await lookupWebFinger("acct:johndoe@example.com");
+        deepStrictEqual(
+          recorder.getMeasurements("webfinger.lookup").length,
+          0,
+        );
+        deepStrictEqual(
+          recorder.getMeasurements("webfinger.lookup.duration").length,
+          0,
+        );
+      },
+    );
+  } finally {
+    fetchMock.removeRoutes();
     fetchMock.hardReset();
-  },
+  }
 });
 
 // cSpell: ignore johndoe