@fedify/vocab-runtime 2.4.3 → 2.4.4

package/deno.json

@@ -1,6 +1,6 @@
 {
   "name": "@fedify/vocab-runtime",
-  "version": "2.4.3",
+  "version": "2.4.4",
   "license": "MIT",
   "exports": {
     ".": "./src/mod.ts",

package/dist/mod.cjs

@@ -16,7 +16,7 @@ let _multiformats_base_x = require("@multiformats/base-x");
 _multiformats_base_x = require_rolldown_runtime.__toESM(_multiformats_base_x, 1);
 //#region deno.json
 var name = "@fedify/vocab-runtime";
-var version = "2.4.3";
+var version = "2.4.4";
 //#endregion
 //#region src/request.ts
 /**
@@ -690,6 +690,7 @@ function getDocumentLoader({ allowPrivateAddress, maxRedirection, skipPreloadedC
 		options?.signal?.throwIfAborted();
 		const parsedUrl = new URL(url);
 		if (parsedUrl.protocol !== "http:" && parsedUrl.protocol !== "https:") throw new require_url.UrlError(`Unsupported protocol: ${parsedUrl.protocol}`);
+		if (parsedUrl.username !== "" || parsedUrl.password !== "") throw new require_url.UrlError("URLs with credentials are not allowed");
 		const currentUrl = parsedUrl.href;
 		if (!skipPreloadedContexts && currentUrl in require_contexts.preloadedContexts) {
 			logger.debug("Using preloaded context: {url}.", { url: currentUrl });

package/dist/mod.js

@@ -12,7 +12,7 @@ import { PublicKeyInfo } from "pkijs";
 import baseX from "@multiformats/base-x";
 //#region deno.json
 var name = "@fedify/vocab-runtime";
-var version = "2.4.3";
+var version = "2.4.4";
 //#endregion
 //#region src/request.ts
 /**
@@ -686,6 +686,7 @@ function getDocumentLoader({ allowPrivateAddress, maxRedirection, skipPreloadedC
 		options?.signal?.throwIfAborted();
 		const parsedUrl = new URL(url);
 		if (parsedUrl.protocol !== "http:" && parsedUrl.protocol !== "https:") throw new UrlError(`Unsupported protocol: ${parsedUrl.protocol}`);
+		if (parsedUrl.username !== "" || parsedUrl.password !== "") throw new UrlError("URLs with credentials are not allowed");
 		const currentUrl = parsedUrl.href;
 		if (!skipPreloadedContexts && currentUrl in preloadedContexts) {
 			logger.debug("Using preloaded context: {url}.", { url: currentUrl });

package/dist/tests/{body-BxgQG9WC.mjs → body-CrrDpQuG.mjs}

@@ -1,4 +1,4 @@
-import { t as FetchError } from "./request-oKt9AzpG.mjs";
+import { t as FetchError } from "./request-Cb7B8WAb.mjs";
 import { getLogger } from "@logtape/logtape";
 //#region src/body.ts
 /** Decoded JSON body limit: 16 MiB.  @internal */

package/dist/tests/{body-CvKsJb4Z.cjs → body-z_6Hg7ci.cjs}

@@ -1,4 +1,4 @@
-const require_request = require("./request-CpZhH4yT.cjs");
+const require_request = require("./request-nWurHb32.cjs");
 let _logtape_logtape = require("@logtape/logtape");
 //#region src/body.ts
 /** Decoded JSON body limit: 16 MiB.  @internal */

package/dist/tests/body.test.cjs

@@ -1,4 +1,4 @@
-const require_body = require("./body-CvKsJb4Z.cjs");
+const require_body = require("./body-z_6Hg7ci.cjs");
 let node_assert_strict = require("node:assert/strict");
 let node_test = require("node:test");
 let node_zlib = require("node:zlib");

package/dist/tests/body.test.mjs

@@ -1,4 +1,4 @@
-import { i as readBoundedText, t as BodyTooLargeError } from "./body-BxgQG9WC.mjs";
+import { i as readBoundedText, t as BodyTooLargeError } from "./body-CrrDpQuG.mjs";
 import { deepStrictEqual, ok, rejects } from "node:assert/strict";
 import { test } from "node:test";
 import { gunzipSync, gzipSync } from "node:zlib";

package/dist/tests/decimal.test.cjs

@@ -1,11 +1,11 @@
 require("./url-BNakuZ8k.cjs");
-require("./docloader-BrNGu5hc.cjs");
+require("./docloader-DUnO3Uvt.cjs");
 require("./key-C-AYkdJJ.cjs");
 require("./multibase-B5Mea7Ip.cjs");
 require("./digest-3FeH2Y-Q.cjs");
 require("./langtag-Czjvxfzx.cjs");
 require("./langstr-_PqsL1ae.cjs");
-require("./portable-media-CFeo3eUn.cjs");
+require("./portable-media-DBl1-UE5.cjs");
 let node_test = require("node:test");
 let node_assert = require("node:assert");
 //#region src/decimal.ts

package/dist/tests/decimal.test.mjs

@@ -1,11 +1,11 @@
 import "./url-DMxmp7ZG.mjs";
-import "./docloader-BVdiOb_c.mjs";
+import "./docloader-Dh8AenhB.mjs";
 import "./key-C2Db_TAJ.mjs";
 import "./multibase-BPnF_L4e.mjs";
 import "./digest-COC7xDiQ.mjs";
 import "./langtag-CUppHs_s.mjs";
 import "./langstr-DYRmJqFn.mjs";
-import "./portable-media-B1iQbOVN.mjs";
+import "./portable-media-DG7moKKk.mjs";
 import { test } from "node:test";
 import { deepStrictEqual, throws } from "node:assert";
 //#region src/decimal.ts

package/dist/tests/{docloader-BrNGu5hc.cjs → docloader-DUnO3Uvt.cjs}

@@ -1,5 +1,5 @@
-const require_request = require("./request-CpZhH4yT.cjs");
-const require_body = require("./body-CvKsJb4Z.cjs");
+const require_request = require("./request-nWurHb32.cjs");
+const require_body = require("./body-z_6Hg7ci.cjs");
 const require_contexts = require("./contexts-C9Lj11SC.cjs");
 const require_link = require("./link-DlKm8bEr.cjs");
 const require_url = require("./url-BNakuZ8k.cjs");
@@ -293,6 +293,7 @@ function getDocumentLoader({ allowPrivateAddress, maxRedirection, skipPreloadedC
 		options?.signal?.throwIfAborted();
 		const parsedUrl = new URL(url);
 		if (parsedUrl.protocol !== "http:" && parsedUrl.protocol !== "https:") throw new require_url.UrlError(`Unsupported protocol: ${parsedUrl.protocol}`);
+		if (parsedUrl.username !== "" || parsedUrl.password !== "") throw new require_url.UrlError("URLs with credentials are not allowed");
 		const currentUrl = parsedUrl.href;
 		if (!skipPreloadedContexts && currentUrl in require_contexts.preloadedContexts) {
 			logger.debug("Using preloaded context: {url}.", { url: currentUrl });

package/dist/tests/{docloader-BVdiOb_c.mjs → docloader-Dh8AenhB.mjs}

@@ -1,5 +1,5 @@
-import { a as name, i as logRequest, n as createActivityPubRequest, o as version, t as FetchError } from "./request-oKt9AzpG.mjs";
-import { i as readBoundedText, n as MAX_BODY_SIZE, r as readBoundedBytes, t as BodyTooLargeError } from "./body-BxgQG9WC.mjs";
+import { a as name, i as logRequest, n as createActivityPubRequest, o as version, t as FetchError } from "./request-Cb7B8WAb.mjs";
+import { i as readBoundedText, n as MAX_BODY_SIZE, r as readBoundedBytes, t as BodyTooLargeError } from "./body-CrrDpQuG.mjs";
 import { t as preloadedContexts } from "./contexts-duRA_dDC.mjs";
 import { t as HttpHeaderLink } from "./link-Cevmc87v.mjs";
 import { n as UrlError, x as validatePublicUrl } from "./url-DMxmp7ZG.mjs";
@@ -293,6 +293,7 @@ function getDocumentLoader({ allowPrivateAddress, maxRedirection, skipPreloadedC
 		options?.signal?.throwIfAborted();
 		const parsedUrl = new URL(url);
 		if (parsedUrl.protocol !== "http:" && parsedUrl.protocol !== "https:") throw new UrlError(`Unsupported protocol: ${parsedUrl.protocol}`);
+		if (parsedUrl.username !== "" || parsedUrl.password !== "") throw new UrlError("URLs with credentials are not allowed");
 		const currentUrl = parsedUrl.href;
 		if (!skipPreloadedContexts && currentUrl in preloadedContexts) {
 			logger.debug("Using preloaded context: {url}.", { url: currentUrl });

package/dist/tests/docloader.test.cjs

@@ -1,8 +1,8 @@
 const require_rolldown_runtime = require("./rolldown-runtime-emK7D4bc.cjs");
-const require_request = require("./request-CpZhH4yT.cjs");
+const require_request = require("./request-nWurHb32.cjs");
 const require_contexts = require("./contexts-C9Lj11SC.cjs");
 const require_url = require("./url-BNakuZ8k.cjs");
-const require_docloader = require("./docloader-BrNGu5hc.cjs");
+const require_docloader = require("./docloader-DUnO3Uvt.cjs");
 const require_jsonld = require("./jsonld-CmDhHNTx.cjs");
 let node_zlib = require("node:zlib");
 let _logtape_logtape = require("@logtape/logtape");
@@ -2376,6 +2376,52 @@ const unsupportedUrls = [
 	"file:///collection",
 	`data:application/ld+json,${encodeURIComponent(JSON.stringify({ id: "https://example.com/data" }))}`
 ];
+function isCredentialUrlError(error) {
+	return error instanceof require_url.UrlError && error.reason === "disallowed" && error.message === "URLs with credentials are not allowed";
+}
+(0, _fedify_fixture.test)("getDocumentLoader() rejects URLs with credentials", async (t) => {
+	const start = "https://8.8.8.8/start";
+	const target = "https://user:pass@8.8.8.8/document";
+	for (const allowPrivateAddress of [false, true]) {
+		const loader = require_docloader.getDocumentLoader({ allowPrivateAddress });
+		for (const path of [
+			"direct",
+			"redirect",
+			"Link",
+			"HTML"
+		]) await t.step(`${path}, allowPrivateAddress=${allowPrivateAddress}`, async () => {
+			await withFetchStub((url) => {
+				if (url !== start) return Response.json({});
+				if (path === "redirect") return Response.redirect(target, 302);
+				if (path === "HTML") return new Response(`<link rel="alternate" type="application/activity+json" href="${target}">`, { headers: { "Content-Type": "text/html" } });
+				return new Response("", { headers: {
+					"Content-Type": "text/plain",
+					Link: `<${target}>; rel="alternate"; type="application/activity+json"`
+				} });
+			}, async (fetched) => {
+				await (0, node_assert.rejects)(loader(path === "direct" ? target : start), isCredentialUrlError);
+				(0, node_assert.deepStrictEqual)(fetched, path === "direct" ? [] : [start]);
+			});
+		});
+		for (const url of [
+			"https://user@8.8.8.8/document",
+			"https://:pass@8.8.8.8/document",
+			"https://%75ser:p%40ss@8.8.8.8/document",
+			"http://user:pass@8.8.8.8/document"
+		]) await t.step(`${url}, allowPrivateAddress=${allowPrivateAddress}`, async () => {
+			await withFetchStub(() => Response.json({}), async (fetched) => {
+				await (0, node_assert.rejects)(loader(url), isCredentialUrlError);
+				(0, node_assert.deepStrictEqual)(fetched, []);
+			});
+		});
+		for (const url of ["https://:@8.8.8.8/document", "https://8.8.8.8/@user?q=@pass"]) await t.step(`allows ${url}, allowPrivateAddress=${allowPrivateAddress}`, async () => {
+			await withFetchStub(() => Response.json({ done: true }), async (fetched) => {
+				(0, node_assert.deepStrictEqual)((await loader(url)).document, { done: true });
+				(0, node_assert.deepStrictEqual)(fetched, [new URL(url).href]);
+			});
+		});
+	}
+});
 function isUnsupportedProtocolError(error, url) {
 	return error instanceof require_url.UrlError && error.message === `Unsupported protocol: ${new URL(url).protocol}` && error.reason === "disallowed";
 }

package/dist/tests/docloader.test.mjs

@@ -1,7 +1,7 @@
-import { t as FetchError } from "./request-oKt9AzpG.mjs";
+import { t as FetchError } from "./request-Cb7B8WAb.mjs";
 import { n as cid_v1_default, t as preloadedContexts } from "./contexts-duRA_dDC.mjs";
 import { n as UrlError } from "./url-DMxmp7ZG.mjs";
-import { i as withDocumentLoaderTimeout, n as getRemoteDocument, r as resolveDocumentLoaderTimeout, t as getDocumentLoader } from "./docloader-BVdiOb_c.mjs";
+import { i as withDocumentLoaderTimeout, n as getRemoteDocument, r as resolveDocumentLoaderTimeout, t as getDocumentLoader } from "./docloader-Dh8AenhB.mjs";
 import { t as jsonld_default } from "./jsonld-DweIJ07b.mjs";
 import { gzipSync } from "node:zlib";
 import { configure, reset } from "@logtape/logtape";
@@ -2394,6 +2394,52 @@ const unsupportedUrls = [
 	"file:///collection",
 	`data:application/ld+json,${encodeURIComponent(JSON.stringify({ id: "https://example.com/data" }))}`
 ];
+function isCredentialUrlError(error) {
+	return error instanceof UrlError && error.reason === "disallowed" && error.message === "URLs with credentials are not allowed";
+}
+test("getDocumentLoader() rejects URLs with credentials", async (t) => {
+	const start = "https://8.8.8.8/start";
+	const target = "https://user:pass@8.8.8.8/document";
+	for (const allowPrivateAddress of [false, true]) {
+		const loader = getDocumentLoader({ allowPrivateAddress });
+		for (const path of [
+			"direct",
+			"redirect",
+			"Link",
+			"HTML"
+		]) await t.step(`${path}, allowPrivateAddress=${allowPrivateAddress}`, async () => {
+			await withFetchStub((url) => {
+				if (url !== start) return Response.json({});
+				if (path === "redirect") return Response.redirect(target, 302);
+				if (path === "HTML") return new Response(`<link rel="alternate" type="application/activity+json" href="${target}">`, { headers: { "Content-Type": "text/html" } });
+				return new Response("", { headers: {
+					"Content-Type": "text/plain",
+					Link: `<${target}>; rel="alternate"; type="application/activity+json"`
+				} });
+			}, async (fetched) => {
+				await rejects(loader(path === "direct" ? target : start), isCredentialUrlError);
+				deepStrictEqual(fetched, path === "direct" ? [] : [start]);
+			});
+		});
+		for (const url of [
+			"https://user@8.8.8.8/document",
+			"https://:pass@8.8.8.8/document",
+			"https://%75ser:p%40ss@8.8.8.8/document",
+			"http://user:pass@8.8.8.8/document"
+		]) await t.step(`${url}, allowPrivateAddress=${allowPrivateAddress}`, async () => {
+			await withFetchStub(() => Response.json({}), async (fetched) => {
+				await rejects(loader(url), isCredentialUrlError);
+				deepStrictEqual(fetched, []);
+			});
+		});
+		for (const url of ["https://:@8.8.8.8/document", "https://8.8.8.8/@user?q=@pass"]) await t.step(`allows ${url}, allowPrivateAddress=${allowPrivateAddress}`, async () => {
+			await withFetchStub(() => Response.json({ done: true }), async (fetched) => {
+				deepStrictEqual((await loader(url)).document, { done: true });
+				deepStrictEqual(fetched, [new URL(url).href]);
+			});
+		});
+	}
+});
 function isUnsupportedProtocolError(error, url) {
 	return error instanceof UrlError && error.message === `Unsupported protocol: ${new URL(url).protocol}` && error.reason === "disallowed";
 }

package/dist/tests/{portable-media-CFeo3eUn.cjs → portable-media-DBl1-UE5.cjs}

@@ -1,5 +1,5 @@
-const require_request = require("./request-CpZhH4yT.cjs");
-const require_body = require("./body-CvKsJb4Z.cjs");
+const require_request = require("./request-nWurHb32.cjs");
+const require_body = require("./body-z_6Hg7ci.cjs");
 const require_url = require("./url-BNakuZ8k.cjs");
 const require_digest = require("./digest-3FeH2Y-Q.cjs");
 //#region src/portable-media.ts

package/dist/tests/{portable-media-B1iQbOVN.mjs → portable-media-DG7moKKk.mjs}

@@ -1,5 +1,5 @@
-import { r as getUserAgent } from "./request-oKt9AzpG.mjs";
-import { r as readBoundedBytes } from "./body-BxgQG9WC.mjs";
+import { r as getUserAgent } from "./request-Cb7B8WAb.mjs";
+import { r as readBoundedBytes } from "./body-CrrDpQuG.mjs";
 import { g as parseGatewayUrl, x as validatePublicUrl } from "./url-DMxmp7ZG.mjs";
 import { a as verifyDigestMultibase, i as parseHashlink, r as parseDigestMultibase } from "./digest-COC7xDiQ.mjs";
 //#region src/portable-media.ts

package/dist/tests/portable-media.test.cjs

@@ -1,5 +1,5 @@
 const require_digest = require("./digest-3FeH2Y-Q.cjs");
-const require_portable_media = require("./portable-media-CFeo3eUn.cjs");
+const require_portable_media = require("./portable-media-DBl1-UE5.cjs");
 let node_assert_strict = require("node:assert/strict");
 let node_test = require("node:test");
 let node_http = require("node:http");

package/dist/tests/portable-media.test.mjs

@@ -1,5 +1,5 @@
 import { n as createHashlink, t as computeDigestMultibase } from "./digest-COC7xDiQ.mjs";
-import { t as fetchPortableMedia } from "./portable-media-B1iQbOVN.mjs";
+import { t as fetchPortableMedia } from "./portable-media-DG7moKKk.mjs";
 import { deepStrictEqual, equal, rejects } from "node:assert/strict";
 import { test } from "node:test";
 import { createServer } from "node:http";

package/dist/tests/{request-oKt9AzpG.mjs → request-Cb7B8WAb.mjs}

@@ -1,7 +1,7 @@
 import process from "node:process";
 //#region deno.json
 var name = "@fedify/vocab-runtime";
-var version = "2.4.3";
+var version = "2.4.4";
 //#endregion
 //#region src/request.ts
 /**

package/dist/tests/{request-CpZhH4yT.cjs → request-nWurHb32.cjs}

@@ -3,7 +3,7 @@ let node_process = require("node:process");
 node_process = require_rolldown_runtime.__toESM(node_process, 1);
 //#region deno.json
 var name = "@fedify/vocab-runtime";
-var version = "2.4.3";
+var version = "2.4.4";
 //#endregion
 //#region src/request.ts
 /**

package/dist/tests/request.test.cjs

@@ -1,5 +1,5 @@
 const require_rolldown_runtime = require("./rolldown-runtime-emK7D4bc.cjs");
-const require_request = require("./request-CpZhH4yT.cjs");
+const require_request = require("./request-nWurHb32.cjs");
 let node_test = require("node:test");
 let node_process = require("node:process");
 node_process = require_rolldown_runtime.__toESM(node_process, 1);

package/dist/tests/request.test.mjs

@@ -1,4 +1,4 @@
-import { n as createActivityPubRequest, o as version, r as getUserAgent } from "./request-oKt9AzpG.mjs";
+import { n as createActivityPubRequest, o as version, r as getUserAgent } from "./request-Cb7B8WAb.mjs";
 import { test } from "node:test";
 import process from "node:process";
 import { deepStrictEqual } from "node:assert";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fedify/vocab-runtime",
-  "version": "2.4.3",
+  "version": "2.4.4",
   "homepage": "https://fedify.dev/",
   "repository": {
     "type": "git",

package/src/docloader.test.ts

@@ -1621,6 +1621,90 @@ const unsupportedUrls = [
   }`,
 ];
 
+function isCredentialUrlError(error: unknown): boolean {
+  return error instanceof UrlError && error.reason === "disallowed" &&
+    error.message === "URLs with credentials are not allowed";
+}
+
+test("getDocumentLoader() rejects URLs with credentials", async (t) => {
+  const start = "https://8.8.8.8/start";
+  const target = "https://user:pass@8.8.8.8/document";
+  for (const allowPrivateAddress of [false, true]) {
+    const loader = getDocumentLoader({ allowPrivateAddress });
+    for (const path of ["direct", "redirect", "Link", "HTML"]) {
+      await t.step(
+        `${path}, allowPrivateAddress=${allowPrivateAddress}`,
+        async () => {
+          await withFetchStub(
+            (url) => {
+              if (url !== start) return Response.json({});
+              if (path === "redirect") return Response.redirect(target, 302);
+              if (path === "HTML") {
+                return new Response(
+                  `<link rel="alternate" type="application/activity+json" href="${target}">`,
+                  { headers: { "Content-Type": "text/html" } },
+                );
+              }
+              return new Response("", {
+                headers: {
+                  "Content-Type": "text/plain",
+                  Link:
+                    `<${target}>; rel="alternate"; type="application/activity+json"`,
+                },
+              });
+            },
+            async (fetched) => {
+              await rejects(
+                loader(path === "direct" ? target : start),
+                isCredentialUrlError,
+              );
+              deepStrictEqual(fetched, path === "direct" ? [] : [start]);
+            },
+          );
+        },
+      );
+    }
+    for (
+      const url of [
+        "https://user@8.8.8.8/document",
+        "https://:pass@8.8.8.8/document",
+        "https://%75ser:p%40ss@8.8.8.8/document",
+        "http://user:pass@8.8.8.8/document",
+      ]
+    ) {
+      await t.step(
+        `${url}, allowPrivateAddress=${allowPrivateAddress}`,
+        async () => {
+          await withFetchStub(() => Response.json({}), async (fetched) => {
+            await rejects(loader(url), isCredentialUrlError);
+            deepStrictEqual(fetched, []);
+          });
+        },
+      );
+    }
+    for (
+      const url of [
+        "https://:@8.8.8.8/document",
+        "https://8.8.8.8/@user?q=@pass",
+      ]
+    ) {
+      await t.step(
+        `allows ${url}, allowPrivateAddress=${allowPrivateAddress}`,
+        async () => {
+          await withFetchStub(
+            () => Response.json({ done: true }),
+            async (fetched) => {
+              const document = await loader(url);
+              deepStrictEqual(document.document, { done: true });
+              deepStrictEqual(fetched, [new URL(url).href]);
+            },
+          );
+        },
+      );
+    }
+  }
+});
+
 function isUnsupportedProtocolError(error: unknown, url: string): boolean {
   return error instanceof UrlError &&
     error.message === `Unsupported protocol: ${new URL(url).protocol}` &&

package/src/docloader.ts

@@ -561,6 +561,11 @@ export function getDocumentLoader(
     if (parsedUrl.protocol !== "http:" && parsedUrl.protocol !== "https:") {
       throw new UrlError(`Unsupported protocol: ${parsedUrl.protocol}`);
     }
+    // When merging forward, keep this guard independent of allowPrivateAddress:
+    // private-address opt-in must not permit credentials on any followed URL.
+    if (parsedUrl.username !== "" || parsedUrl.password !== "") {
+      throw new UrlError("URLs with credentials are not allowed");
+    }
     const currentUrl = parsedUrl.href;
     if (!skipPreloadedContexts && currentUrl in preloadedContexts) {
       logger.debug("Using preloaded context: {url}.", { url: currentUrl });