@fedify/lint 2.2.0-pr.695.16 → 2.2.0-pr.697.18

package/deno.json

@@ -1,6 +1,6 @@
 {
   "name": "@fedify/lint",
-  "version": "2.2.0-pr.695.16+7a782334",
+  "version": "2.2.0-pr.697.18+b776632f",
   "license": "MIT",
   "exports": {
     ".": "./src/mod.ts"

package/dist/index.cjs

@@ -29,7 +29,7 @@ let _typescript_eslint_parser = require("@typescript-eslint/parser");
 _typescript_eslint_parser = __toESM(_typescript_eslint_parser);
 //#region deno.json
 var name = "@fedify/lint";
-var version = "2.2.0-pr.695.16+7a782334";
+var version = "2.2.0-pr.697.18+b776632f";
 //#endregion
 //#region src/lib/const.ts
 /**
@@ -146,7 +146,8 @@ const RULE_IDS = {
 	actorFeaturedTagsPropertyMismatch: "actor-featured-tags-property-mismatch",
 	actorInboxPropertyMismatch: "actor-inbox-property-mismatch",
 	actorSharedInboxPropertyMismatch: "actor-shared-inbox-property-mismatch",
-	collectionFilteringNotImplemented: "collection-filtering-not-implemented"
+	collectionFilteringNotImplemented: "collection-filtering-not-implemented",
+	outboxListenerDeliveryRequired: "outbox-listener-delivery-required"
 };
 //#endregion
 //#region src/lib/messages.ts
@@ -191,6 +192,7 @@ function allOf(...predicates) {
 	return (value) => predicates.every((predicate) => predicate(value));
 }
 const anyOf = (...predicates) => (value) => predicates.some((predicate) => predicate(value));
+const isNode = (obj) => (0, _fxts_core.isObject)(obj) && "type" in obj;
 /**
 * Checks if a node is of a specific type.
 */
@@ -443,7 +445,7 @@ function createRequiredRuleEslint(config) {
 	};
 }
 createRequiredRuleDeno(properties.assertionMethod);
-const eslint$20 = createRequiredRuleEslint(properties.assertionMethod);
+const eslint$21 = createRequiredRuleEslint(properties.assertionMethod);
 //#endregion
 //#region src/lib/mismatch.ts
 const isIdentifierWithName = (name) => (node) => allOf(isNodeType("Identifier"), isNodeName(name))(node);
@@ -513,43 +515,43 @@ const createMismatchRuleEslint = (config) => ({
 	}))
 });
 createMismatchRuleDeno(properties.featured);
-const eslint$19 = createMismatchRuleEslint(properties.featured);
+const eslint$20 = createMismatchRuleEslint(properties.featured);
 createRequiredRuleDeno(properties.featured);
-const eslint$18 = createRequiredRuleEslint(properties.featured);
+const eslint$19 = createRequiredRuleEslint(properties.featured);
 createMismatchRuleDeno(properties.featuredTags);
-const eslint$17 = createMismatchRuleEslint(properties.featuredTags);
+const eslint$18 = createMismatchRuleEslint(properties.featuredTags);
 createRequiredRuleDeno(properties.featuredTags);
-const eslint$16 = createRequiredRuleEslint(properties.featuredTags);
+const eslint$17 = createRequiredRuleEslint(properties.featuredTags);
 createMismatchRuleDeno(properties.followers);
-const eslint$15 = createMismatchRuleEslint(properties.followers);
+const eslint$16 = createMismatchRuleEslint(properties.followers);
 createRequiredRuleDeno(properties.followers);
-const eslint$14 = createRequiredRuleEslint(properties.followers);
+const eslint$15 = createRequiredRuleEslint(properties.followers);
 createMismatchRuleDeno(properties.following);
-const eslint$13 = createMismatchRuleEslint(properties.following);
+const eslint$14 = createMismatchRuleEslint(properties.following);
 createRequiredRuleDeno(properties.following);
-const eslint$12 = createRequiredRuleEslint(properties.following);
+const eslint$13 = createRequiredRuleEslint(properties.following);
 createMismatchRuleDeno(properties.id);
-const eslint$11 = createMismatchRuleEslint(properties.id);
+const eslint$12 = createMismatchRuleEslint(properties.id);
 createRequiredRuleDeno(properties.id);
-const eslint$10 = createRequiredRuleEslint(properties.id);
+const eslint$11 = createRequiredRuleEslint(properties.id);
 createMismatchRuleDeno(properties.inbox);
-const eslint$9 = createMismatchRuleEslint(properties.inbox);
+const eslint$10 = createMismatchRuleEslint(properties.inbox);
 createRequiredRuleDeno(properties.inbox);
-const eslint$8 = createRequiredRuleEslint(properties.inbox);
+const eslint$9 = createRequiredRuleEslint(properties.inbox);
 createMismatchRuleDeno(properties.liked);
-const eslint$7 = createMismatchRuleEslint(properties.liked);
+const eslint$8 = createMismatchRuleEslint(properties.liked);
 createRequiredRuleDeno(properties.liked);
-const eslint$6 = createRequiredRuleEslint(properties.liked);
+const eslint$7 = createRequiredRuleEslint(properties.liked);
 createMismatchRuleDeno(properties.outbox);
-const eslint$5 = createMismatchRuleEslint(properties.outbox);
+const eslint$6 = createMismatchRuleEslint(properties.outbox);
 createRequiredRuleDeno(properties.outbox);
-const eslint$4 = createRequiredRuleEslint(properties.outbox);
+const eslint$5 = createRequiredRuleEslint(properties.outbox);
 createRequiredRuleDeno(properties.publicKey);
-const eslint$3 = createRequiredRuleEslint(properties.publicKey);
+const eslint$4 = createRequiredRuleEslint(properties.publicKey);
 createMismatchRuleDeno(properties.sharedInbox);
-const eslint$2 = createMismatchRuleEslint(properties.sharedInbox);
+const eslint$3 = createMismatchRuleEslint(properties.sharedInbox);
 createRequiredRuleDeno(properties.sharedInbox);
-const eslint$1 = createRequiredRuleEslint(properties.sharedInbox);
+const eslint$2 = createRequiredRuleEslint(properties.sharedInbox);
 //#endregion
 //#region src/rules/collection-filtering-not-implemented.ts
 /**
@@ -568,7 +570,7 @@ const isFollowersDispatcherCall = (node) => "callee" in node && node.callee && n
 * CollectionDispatcher signature: (context, identifier, cursor, filter?) => ...
 */
 const hasFilterParameter = hasMinParams(4);
-const eslint = {
+const eslint$1 = {
 	meta: {
 		type: "suggestion",
 		docs: { description: "Ensure followers dispatcher implements filtering" },
@@ -593,33 +595,287 @@ const eslint = {
 	}
 };
 //#endregion
+//#region src/rules/outbox-listener-delivery-required.ts
+const MESSAGE = "Outbox listeners should deliver posted activities explicitly with ctx.sendActivity() or ctx.forwardActivity().";
+const isChainedFromOutboxListeners = (expr, federationTracker) => {
+	if (expr.type !== "CallExpression") return false;
+	if (!hasMemberExpressionCallee(expr) || !hasIdentifierProperty(expr)) return false;
+	const methodName = expr.callee.property.name;
+	if (methodName === "setOutboxListeners") return federationTracker.isFederationObject(expr.callee.object);
+	if (methodName === "authorize" || methodName === "onError" || methodName === "on") return isChainedFromOutboxListeners(expr.callee.object, federationTracker);
+	return false;
+};
+const DELIVERY_METHOD_NAMES = new Set(["sendActivity", "forwardActivity"]);
+const getMemberPropertyName = (expr) => {
+	if (expr.type !== "MemberExpression") return null;
+	const property = expr.property;
+	if (property.type === "Identifier") return property.name;
+	if (property.type === "Literal" && typeof property.value === "string") return property.value;
+	return null;
+};
+function unwrapContextParam(node) {
+	let current = node ?? null;
+	while (current?.type === "AssignmentPattern") current = current.left;
+	return current;
+}
+function escapeRegExp(value) {
+	return value.replaceAll(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}
+function stripCommentsAndStrings(code) {
+	let result = "";
+	let index = 0;
+	const skipQuotedString = (quote) => {
+		const start = index;
+		index += 1;
+		while (index < code.length) {
+			const char = code[index];
+			if (char === "\\") {
+				index += 2;
+				continue;
+			}
+			index += 1;
+			if (char === quote) break;
+		}
+		const literal = code.slice(start, index);
+		const value = literal.slice(1, -1);
+		result += DELIVERY_METHOD_NAMES.has(value) ? literal : `${quote}${quote}`;
+	};
+	const stripTemplateLiteral = () => {
+		const start = index;
+		index += 1;
+		let raw = "";
+		let hasExpression = false;
+		while (index < code.length) {
+			const char = code[index];
+			if (char === "\\") {
+				raw += char;
+				raw += code[index + 1] ?? "";
+				index += 2;
+				continue;
+			}
+			if (char === "`") {
+				index += 1;
+				if (!hasExpression && DELIVERY_METHOD_NAMES.has(raw)) result += code.slice(start, index);
+				else result += "``";
+				return;
+			}
+			if (char === "$" && code[index + 1] === "{") {
+				hasExpression = true;
+				result += "`${";
+				index += 2;
+				let depth = 1;
+				while (index < code.length && depth > 0) {
+					const exprChar = code[index];
+					const next = code[index + 1];
+					if (exprChar === "'" || exprChar === "\"") {
+						skipQuotedString(exprChar);
+						continue;
+					}
+					if (exprChar === "`") {
+						stripTemplateLiteral();
+						continue;
+					}
+					if (exprChar === "/" && next === "*") {
+						index += 2;
+						while (index < code.length) {
+							if (code[index] === "*" && code[index + 1] === "/") {
+								index += 2;
+								break;
+							}
+							index += 1;
+						}
+						continue;
+					}
+					if (exprChar === "/" && next === "/") {
+						index += 2;
+						while (index < code.length && code[index] !== "\n") index += 1;
+						continue;
+					}
+					result += exprChar;
+					index += 1;
+					if (exprChar === "{") depth += 1;
+					else if (exprChar === "}") depth -= 1;
+				}
+				continue;
+			}
+			raw += char;
+			index += 1;
+		}
+		result += "``";
+	};
+	while (index < code.length) {
+		const char = code[index];
+		const next = code[index + 1];
+		if (char === "/" && next === "*") {
+			index += 2;
+			while (index < code.length) {
+				if (code[index] === "*" && code[index + 1] === "/") {
+					index += 2;
+					break;
+				}
+				index += 1;
+			}
+			continue;
+		}
+		if (char === "/" && next === "/") {
+			index += 2;
+			while (index < code.length && code[index] !== "\n") index += 1;
+			continue;
+		}
+		if (char === "'" || char === "\"") {
+			skipQuotedString(char);
+			continue;
+		}
+		if (char === "`") {
+			stripTemplateLiteral();
+			continue;
+		}
+		result += char;
+		index += 1;
+	}
+	return result;
+}
+function getDeliveryAliasName(node) {
+	if (node.type === "Identifier") return node.name;
+	if (node.type === "AssignmentPattern" && node.left.type === "Identifier") return node.left.name;
+	return null;
+}
+function buildContextExpressionPattern(contextName) {
+	const name = escapeRegExp(contextName);
+	const boundedName = String.raw`(?<![\w$])${name}(?![\w$])`;
+	return String.raw`(?:${boundedName}|\(\s*${boundedName}(?:\s+as\s+[^)]+)?\s*\))`;
+}
+const resolveListenerReference = (expr, bindings, seen = /* @__PURE__ */ new Set()) => {
+	if (isFunction(expr)) return expr;
+	if (expr.type === "Identifier") {
+		if (seen.has(expr.name)) return null;
+		seen.add(expr.name);
+		const binding = bindings.get(expr.name);
+		if (binding == null || !isNode(binding)) return null;
+		if (isFunction(binding) || binding.type === "FunctionDeclaration") return binding;
+		if (binding.type === "Identifier") return resolveListenerReference(binding, bindings, seen);
+		return null;
+	}
+	if (expr.type === "MemberExpression" && expr.object.type === "Identifier" && !expr.computed) {
+		const binding = bindings.get(expr.object.name);
+		if (binding == null || !isNode(binding) || binding.type !== "ObjectExpression") return null;
+		const propertyName = getMemberPropertyName(expr);
+		if (propertyName == null) return null;
+		for (const prop of binding.properties) {
+			if (!isNode(prop) || prop.type !== "Property") continue;
+			if ((prop.key.type === "Identifier" ? prop.key.name : prop.key.type === "Literal" && typeof prop.key.value === "string" ? prop.key.value : null) !== propertyName || !isNode(prop.value)) continue;
+			const value = prop.value;
+			if (isFunction(value) || value.type === "FunctionDeclaration") return value;
+		}
+	}
+	return null;
+};
+const listenerCallsDeliveryMethod = (sourceCode, listener) => {
+	const code = stripCommentsAndStrings(sourceCode.getText(listener));
+	const aliases = /* @__PURE__ */ new Set();
+	const contextParam = unwrapContextParam(listener.params[0]);
+	const contextName = contextParam?.type === "Identifier" ? contextParam.name : null;
+	if (contextParam?.type === "ObjectPattern") for (const prop of contextParam.properties) {
+		if (!isNode(prop) || prop.type !== "Property") continue;
+		const keyName = prop.key.type === "Identifier" ? prop.key.name : prop.key.type === "Literal" && typeof prop.key.value === "string" ? prop.key.value : null;
+		if (keyName == null || !DELIVERY_METHOD_NAMES.has(keyName)) continue;
+		const alias = getDeliveryAliasName(prop.value);
+		if (alias != null) aliases.add(alias);
+	}
+	if (contextName != null) {
+		const contextExpr = buildContextExpressionPattern(contextName);
+		if (new RegExp(String.raw`${contextExpr}\s*(?:\?\s*\.\s*(?:sendActivity|forwardActivity)|\.\s*(?:sendActivity|forwardActivity)|\?\s*\.\s*\[\s*["'\`](?:sendActivity|forwardActivity)["'\`]\s*\]|\[\s*["'\`](?:sendActivity|forwardActivity)["'\`]\s*\])\s*\(`).test(code)) return true;
+		const destructuringPattern = new RegExp(String.raw`(?:const|let|var)\s*{([^}]*)}\s*=\s*${contextExpr}`, "g");
+		for (const match of code.matchAll(destructuringPattern)) {
+			const fields = match[1].split(",").map((field) => field.trim()).filter(Boolean);
+			for (const field of fields) {
+				const [sourceName, aliasName] = field.split(":").map((part) => part.trim());
+				if (!DELIVERY_METHOD_NAMES.has(sourceName)) continue;
+				aliases.add(aliasName ?? sourceName);
+			}
+		}
+		const aliasPattern = new RegExp(String.raw`(?:const|let|var)\s+([A-Za-z_$][\w$]*)\s*=\s*${contextExpr}\s*(?:\?\s*\.\s*(sendActivity|forwardActivity)|\.\s*(sendActivity|forwardActivity)|\?\s*\.\s*\[\s*["'\`](sendActivity|forwardActivity)["'\`]\s*\]|\[\s*["'\`](sendActivity|forwardActivity)["'\`]\s*\])`, "g");
+		for (const match of code.matchAll(aliasPattern)) aliases.add(match[1]);
+	}
+	return globalThis.Array.from(aliases).some((alias) => new RegExp(String.raw`\b${escapeRegExp(alias)}\s*\(`).test(code));
+};
+function createRule(buildReport) {
+	return (context) => {
+		const federationTracker = trackFederationVariables();
+		const bindings = /* @__PURE__ */ new Map();
+		const pendingCalls = [];
+		const sourceCode = context.sourceCode;
+		const inspectCall = (node) => {
+			if (!hasMemberExpressionCallee(node) || !hasIdentifierProperty(node) || !hasMethodName("on")(node) || node.arguments.length < 2) return;
+			if (!isChainedFromOutboxListeners(node.callee.object, federationTracker)) return;
+			const listener = node.arguments[1];
+			const resolvedListener = isNode(listener) && isFunction(listener) ? listener : isNode(listener) ? resolveListenerReference(listener, bindings) : null;
+			if (resolvedListener == null) return;
+			if (listenerCallsDeliveryMethod(sourceCode, resolvedListener)) return;
+			context.report({
+				node: resolvedListener,
+				...buildReport
+			});
+		};
+		return {
+			VariableDeclarator(node) {
+				federationTracker.VariableDeclarator(node);
+				if (node.id.type === "Identifier" && node.init != null) bindings.set(node.id.name, node.init);
+			},
+			FunctionDeclaration(node) {
+				if (node.id != null) bindings.set(node.id.name, node);
+			},
+			CallExpression(node) {
+				pendingCalls.push(node);
+			},
+			"Program:exit"() {
+				for (const node of pendingCalls) inspectCall(node);
+			}
+		};
+	};
+}
+createRule({ message: MESSAGE });
+const eslint = {
+	meta: {
+		type: "suggestion",
+		docs: { description: "Warn when an outbox listener omits explicit delivery methods" },
+		schema: [],
+		messages: { required: "{{ message }}" }
+	},
+	create: createRule({
+		messageId: "required",
+		data: { message: MESSAGE }
+	})
+};
+//#endregion
 //#region src/index.ts
 /**
 * ESLint plugin for Fedify.
 * Provides lint rules for validating Fedify federation code.
 */
 const rules = {
-	[RULE_IDS.actorIdMismatch]: eslint$11,
-	[RULE_IDS.actorIdRequired]: eslint$10,
-	[RULE_IDS.actorFollowingPropertyRequired]: eslint$12,
-	[RULE_IDS.actorFollowingPropertyMismatch]: eslint$13,
-	[RULE_IDS.actorFollowersPropertyRequired]: eslint$14,
-	[RULE_IDS.actorFollowersPropertyMismatch]: eslint$15,
-	[RULE_IDS.actorOutboxPropertyRequired]: eslint$4,
-	[RULE_IDS.actorOutboxPropertyMismatch]: eslint$5,
-	[RULE_IDS.actorLikedPropertyRequired]: eslint$6,
-	[RULE_IDS.actorLikedPropertyMismatch]: eslint$7,
-	[RULE_IDS.actorFeaturedPropertyRequired]: eslint$18,
-	[RULE_IDS.actorFeaturedPropertyMismatch]: eslint$19,
-	[RULE_IDS.actorFeaturedTagsPropertyRequired]: eslint$16,
-	[RULE_IDS.actorFeaturedTagsPropertyMismatch]: eslint$17,
-	[RULE_IDS.actorInboxPropertyRequired]: eslint$8,
-	[RULE_IDS.actorInboxPropertyMismatch]: eslint$9,
-	[RULE_IDS.actorSharedInboxPropertyRequired]: eslint$1,
-	[RULE_IDS.actorSharedInboxPropertyMismatch]: eslint$2,
-	[RULE_IDS.actorPublicKeyRequired]: eslint$3,
-	[RULE_IDS.actorAssertionMethodRequired]: eslint$20,
-	[RULE_IDS.collectionFilteringNotImplemented]: eslint
+	[RULE_IDS.actorIdMismatch]: eslint$12,
+	[RULE_IDS.actorIdRequired]: eslint$11,
+	[RULE_IDS.actorFollowingPropertyRequired]: eslint$13,
+	[RULE_IDS.actorFollowingPropertyMismatch]: eslint$14,
+	[RULE_IDS.actorFollowersPropertyRequired]: eslint$15,
+	[RULE_IDS.actorFollowersPropertyMismatch]: eslint$16,
+	[RULE_IDS.actorOutboxPropertyRequired]: eslint$5,
+	[RULE_IDS.actorOutboxPropertyMismatch]: eslint$6,
+	[RULE_IDS.actorLikedPropertyRequired]: eslint$7,
+	[RULE_IDS.actorLikedPropertyMismatch]: eslint$8,
+	[RULE_IDS.actorFeaturedPropertyRequired]: eslint$19,
+	[RULE_IDS.actorFeaturedPropertyMismatch]: eslint$20,
+	[RULE_IDS.actorFeaturedTagsPropertyRequired]: eslint$17,
+	[RULE_IDS.actorFeaturedTagsPropertyMismatch]: eslint$18,
+	[RULE_IDS.actorInboxPropertyRequired]: eslint$9,
+	[RULE_IDS.actorInboxPropertyMismatch]: eslint$10,
+	[RULE_IDS.actorSharedInboxPropertyRequired]: eslint$2,
+	[RULE_IDS.actorSharedInboxPropertyMismatch]: eslint$3,
+	[RULE_IDS.actorPublicKeyRequired]: eslint$4,
+	[RULE_IDS.actorAssertionMethodRequired]: eslint$21,
+	[RULE_IDS.collectionFilteringNotImplemented]: eslint$1,
+	[RULE_IDS.outboxListenerDeliveryRequired]: eslint
 };
 const recommendedRuleIds = [RULE_IDS.actorIdMismatch, RULE_IDS.actorIdRequired];
 /**

package/dist/index.js

@@ -2,7 +2,7 @@ import { always, every, fromEntries, head, isEmpty, isObject, keys, map, negate,
 import parser from "@typescript-eslint/parser";
 //#region deno.json
 var name = "@fedify/lint";
-var version = "2.2.0-pr.695.16+7a782334";
+var version = "2.2.0-pr.697.18+b776632f";
 //#endregion
 //#region src/lib/const.ts
 /**
@@ -119,7 +119,8 @@ const RULE_IDS = {
 	actorFeaturedTagsPropertyMismatch: "actor-featured-tags-property-mismatch",
 	actorInboxPropertyMismatch: "actor-inbox-property-mismatch",
 	actorSharedInboxPropertyMismatch: "actor-shared-inbox-property-mismatch",
-	collectionFilteringNotImplemented: "collection-filtering-not-implemented"
+	collectionFilteringNotImplemented: "collection-filtering-not-implemented",
+	outboxListenerDeliveryRequired: "outbox-listener-delivery-required"
 };
 //#endregion
 //#region src/lib/messages.ts
@@ -164,6 +165,7 @@ function allOf(...predicates) {
 	return (value) => predicates.every((predicate) => predicate(value));
 }
 const anyOf = (...predicates) => (value) => predicates.some((predicate) => predicate(value));
+const isNode = (obj) => isObject(obj) && "type" in obj;
 /**
 * Checks if a node is of a specific type.
 */
@@ -416,7 +418,7 @@ function createRequiredRuleEslint(config) {
 	};
 }
 createRequiredRuleDeno(properties.assertionMethod);
-const eslint$20 = createRequiredRuleEslint(properties.assertionMethod);
+const eslint$21 = createRequiredRuleEslint(properties.assertionMethod);
 //#endregion
 //#region src/lib/mismatch.ts
 const isIdentifierWithName = (name) => (node) => allOf(isNodeType("Identifier"), isNodeName(name))(node);
@@ -486,43 +488,43 @@ const createMismatchRuleEslint = (config) => ({
 	}))
 });
 createMismatchRuleDeno(properties.featured);
-const eslint$19 = createMismatchRuleEslint(properties.featured);
+const eslint$20 = createMismatchRuleEslint(properties.featured);
 createRequiredRuleDeno(properties.featured);
-const eslint$18 = createRequiredRuleEslint(properties.featured);
+const eslint$19 = createRequiredRuleEslint(properties.featured);
 createMismatchRuleDeno(properties.featuredTags);
-const eslint$17 = createMismatchRuleEslint(properties.featuredTags);
+const eslint$18 = createMismatchRuleEslint(properties.featuredTags);
 createRequiredRuleDeno(properties.featuredTags);
-const eslint$16 = createRequiredRuleEslint(properties.featuredTags);
+const eslint$17 = createRequiredRuleEslint(properties.featuredTags);
 createMismatchRuleDeno(properties.followers);
-const eslint$15 = createMismatchRuleEslint(properties.followers);
+const eslint$16 = createMismatchRuleEslint(properties.followers);
 createRequiredRuleDeno(properties.followers);
-const eslint$14 = createRequiredRuleEslint(properties.followers);
+const eslint$15 = createRequiredRuleEslint(properties.followers);
 createMismatchRuleDeno(properties.following);
-const eslint$13 = createMismatchRuleEslint(properties.following);
+const eslint$14 = createMismatchRuleEslint(properties.following);
 createRequiredRuleDeno(properties.following);
-const eslint$12 = createRequiredRuleEslint(properties.following);
+const eslint$13 = createRequiredRuleEslint(properties.following);
 createMismatchRuleDeno(properties.id);
-const eslint$11 = createMismatchRuleEslint(properties.id);
+const eslint$12 = createMismatchRuleEslint(properties.id);
 createRequiredRuleDeno(properties.id);
-const eslint$10 = createRequiredRuleEslint(properties.id);
+const eslint$11 = createRequiredRuleEslint(properties.id);
 createMismatchRuleDeno(properties.inbox);
-const eslint$9 = createMismatchRuleEslint(properties.inbox);
+const eslint$10 = createMismatchRuleEslint(properties.inbox);
 createRequiredRuleDeno(properties.inbox);
-const eslint$8 = createRequiredRuleEslint(properties.inbox);
+const eslint$9 = createRequiredRuleEslint(properties.inbox);
 createMismatchRuleDeno(properties.liked);
-const eslint$7 = createMismatchRuleEslint(properties.liked);
+const eslint$8 = createMismatchRuleEslint(properties.liked);
 createRequiredRuleDeno(properties.liked);
-const eslint$6 = createRequiredRuleEslint(properties.liked);
+const eslint$7 = createRequiredRuleEslint(properties.liked);
 createMismatchRuleDeno(properties.outbox);
-const eslint$5 = createMismatchRuleEslint(properties.outbox);
+const eslint$6 = createMismatchRuleEslint(properties.outbox);
 createRequiredRuleDeno(properties.outbox);
-const eslint$4 = createRequiredRuleEslint(properties.outbox);
+const eslint$5 = createRequiredRuleEslint(properties.outbox);
 createRequiredRuleDeno(properties.publicKey);
-const eslint$3 = createRequiredRuleEslint(properties.publicKey);
+const eslint$4 = createRequiredRuleEslint(properties.publicKey);
 createMismatchRuleDeno(properties.sharedInbox);
-const eslint$2 = createMismatchRuleEslint(properties.sharedInbox);
+const eslint$3 = createMismatchRuleEslint(properties.sharedInbox);
 createRequiredRuleDeno(properties.sharedInbox);
-const eslint$1 = createRequiredRuleEslint(properties.sharedInbox);
+const eslint$2 = createRequiredRuleEslint(properties.sharedInbox);
 //#endregion
 //#region src/rules/collection-filtering-not-implemented.ts
 /**
@@ -541,7 +543,7 @@ const isFollowersDispatcherCall = (node) => "callee" in node && node.callee && n
 * CollectionDispatcher signature: (context, identifier, cursor, filter?) => ...
 */
 const hasFilterParameter = hasMinParams(4);
-const eslint = {
+const eslint$1 = {
 	meta: {
 		type: "suggestion",
 		docs: { description: "Ensure followers dispatcher implements filtering" },
@@ -566,33 +568,287 @@ const eslint = {
 	}
 };
 //#endregion
+//#region src/rules/outbox-listener-delivery-required.ts
+const MESSAGE = "Outbox listeners should deliver posted activities explicitly with ctx.sendActivity() or ctx.forwardActivity().";
+const isChainedFromOutboxListeners = (expr, federationTracker) => {
+	if (expr.type !== "CallExpression") return false;
+	if (!hasMemberExpressionCallee(expr) || !hasIdentifierProperty(expr)) return false;
+	const methodName = expr.callee.property.name;
+	if (methodName === "setOutboxListeners") return federationTracker.isFederationObject(expr.callee.object);
+	if (methodName === "authorize" || methodName === "onError" || methodName === "on") return isChainedFromOutboxListeners(expr.callee.object, federationTracker);
+	return false;
+};
+const DELIVERY_METHOD_NAMES = new Set(["sendActivity", "forwardActivity"]);
+const getMemberPropertyName = (expr) => {
+	if (expr.type !== "MemberExpression") return null;
+	const property = expr.property;
+	if (property.type === "Identifier") return property.name;
+	if (property.type === "Literal" && typeof property.value === "string") return property.value;
+	return null;
+};
+function unwrapContextParam(node) {
+	let current = node ?? null;
+	while (current?.type === "AssignmentPattern") current = current.left;
+	return current;
+}
+function escapeRegExp(value) {
+	return value.replaceAll(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}
+function stripCommentsAndStrings(code) {
+	let result = "";
+	let index = 0;
+	const skipQuotedString = (quote) => {
+		const start = index;
+		index += 1;
+		while (index < code.length) {
+			const char = code[index];
+			if (char === "\\") {
+				index += 2;
+				continue;
+			}
+			index += 1;
+			if (char === quote) break;
+		}
+		const literal = code.slice(start, index);
+		const value = literal.slice(1, -1);
+		result += DELIVERY_METHOD_NAMES.has(value) ? literal : `${quote}${quote}`;
+	};
+	const stripTemplateLiteral = () => {
+		const start = index;
+		index += 1;
+		let raw = "";
+		let hasExpression = false;
+		while (index < code.length) {
+			const char = code[index];
+			if (char === "\\") {
+				raw += char;
+				raw += code[index + 1] ?? "";
+				index += 2;
+				continue;
+			}
+			if (char === "`") {
+				index += 1;
+				if (!hasExpression && DELIVERY_METHOD_NAMES.has(raw)) result += code.slice(start, index);
+				else result += "``";
+				return;
+			}
+			if (char === "$" && code[index + 1] === "{") {
+				hasExpression = true;
+				result += "`${";
+				index += 2;
+				let depth = 1;
+				while (index < code.length && depth > 0) {
+					const exprChar = code[index];
+					const next = code[index + 1];
+					if (exprChar === "'" || exprChar === "\"") {
+						skipQuotedString(exprChar);
+						continue;
+					}
+					if (exprChar === "`") {
+						stripTemplateLiteral();
+						continue;
+					}
+					if (exprChar === "/" && next === "*") {
+						index += 2;
+						while (index < code.length) {
+							if (code[index] === "*" && code[index + 1] === "/") {
+								index += 2;
+								break;
+							}
+							index += 1;
+						}
+						continue;
+					}
+					if (exprChar === "/" && next === "/") {
+						index += 2;
+						while (index < code.length && code[index] !== "\n") index += 1;
+						continue;
+					}
+					result += exprChar;
+					index += 1;
+					if (exprChar === "{") depth += 1;
+					else if (exprChar === "}") depth -= 1;
+				}
+				continue;
+			}
+			raw += char;
+			index += 1;
+		}
+		result += "``";
+	};
+	while (index < code.length) {
+		const char = code[index];
+		const next = code[index + 1];
+		if (char === "/" && next === "*") {
+			index += 2;
+			while (index < code.length) {
+				if (code[index] === "*" && code[index + 1] === "/") {
+					index += 2;
+					break;
+				}
+				index += 1;
+			}
+			continue;
+		}
+		if (char === "/" && next === "/") {
+			index += 2;
+			while (index < code.length && code[index] !== "\n") index += 1;
+			continue;
+		}
+		if (char === "'" || char === "\"") {
+			skipQuotedString(char);
+			continue;
+		}
+		if (char === "`") {
+			stripTemplateLiteral();
+			continue;
+		}
+		result += char;
+		index += 1;
+	}
+	return result;
+}
+function getDeliveryAliasName(node) {
+	if (node.type === "Identifier") return node.name;
+	if (node.type === "AssignmentPattern" && node.left.type === "Identifier") return node.left.name;
+	return null;
+}
+function buildContextExpressionPattern(contextName) {
+	const name = escapeRegExp(contextName);
+	const boundedName = String.raw`(?<![\w$])${name}(?![\w$])`;
+	return String.raw`(?:${boundedName}|\(\s*${boundedName}(?:\s+as\s+[^)]+)?\s*\))`;
+}
+const resolveListenerReference = (expr, bindings, seen = /* @__PURE__ */ new Set()) => {
+	if (isFunction(expr)) return expr;
+	if (expr.type === "Identifier") {
+		if (seen.has(expr.name)) return null;
+		seen.add(expr.name);
+		const binding = bindings.get(expr.name);
+		if (binding == null || !isNode(binding)) return null;
+		if (isFunction(binding) || binding.type === "FunctionDeclaration") return binding;
+		if (binding.type === "Identifier") return resolveListenerReference(binding, bindings, seen);
+		return null;
+	}
+	if (expr.type === "MemberExpression" && expr.object.type === "Identifier" && !expr.computed) {
+		const binding = bindings.get(expr.object.name);
+		if (binding == null || !isNode(binding) || binding.type !== "ObjectExpression") return null;
+		const propertyName = getMemberPropertyName(expr);
+		if (propertyName == null) return null;
+		for (const prop of binding.properties) {
+			if (!isNode(prop) || prop.type !== "Property") continue;
+			if ((prop.key.type === "Identifier" ? prop.key.name : prop.key.type === "Literal" && typeof prop.key.value === "string" ? prop.key.value : null) !== propertyName || !isNode(prop.value)) continue;
+			const value = prop.value;
+			if (isFunction(value) || value.type === "FunctionDeclaration") return value;
+		}
+	}
+	return null;
+};
+const listenerCallsDeliveryMethod = (sourceCode, listener) => {
+	const code = stripCommentsAndStrings(sourceCode.getText(listener));
+	const aliases = /* @__PURE__ */ new Set();
+	const contextParam = unwrapContextParam(listener.params[0]);
+	const contextName = contextParam?.type === "Identifier" ? contextParam.name : null;
+	if (contextParam?.type === "ObjectPattern") for (const prop of contextParam.properties) {
+		if (!isNode(prop) || prop.type !== "Property") continue;
+		const keyName = prop.key.type === "Identifier" ? prop.key.name : prop.key.type === "Literal" && typeof prop.key.value === "string" ? prop.key.value : null;
+		if (keyName == null || !DELIVERY_METHOD_NAMES.has(keyName)) continue;
+		const alias = getDeliveryAliasName(prop.value);
+		if (alias != null) aliases.add(alias);
+	}
+	if (contextName != null) {
+		const contextExpr = buildContextExpressionPattern(contextName);
+		if (new RegExp(String.raw`${contextExpr}\s*(?:\?\s*\.\s*(?:sendActivity|forwardActivity)|\.\s*(?:sendActivity|forwardActivity)|\?\s*\.\s*\[\s*["'\`](?:sendActivity|forwardActivity)["'\`]\s*\]|\[\s*["'\`](?:sendActivity|forwardActivity)["'\`]\s*\])\s*\(`).test(code)) return true;
+		const destructuringPattern = new RegExp(String.raw`(?:const|let|var)\s*{([^}]*)}\s*=\s*${contextExpr}`, "g");
+		for (const match of code.matchAll(destructuringPattern)) {
+			const fields = match[1].split(",").map((field) => field.trim()).filter(Boolean);
+			for (const field of fields) {
+				const [sourceName, aliasName] = field.split(":").map((part) => part.trim());
+				if (!DELIVERY_METHOD_NAMES.has(sourceName)) continue;
+				aliases.add(aliasName ?? sourceName);
+			}
+		}
+		const aliasPattern = new RegExp(String.raw`(?:const|let|var)\s+([A-Za-z_$][\w$]*)\s*=\s*${contextExpr}\s*(?:\?\s*\.\s*(sendActivity|forwardActivity)|\.\s*(sendActivity|forwardActivity)|\?\s*\.\s*\[\s*["'\`](sendActivity|forwardActivity)["'\`]\s*\]|\[\s*["'\`](sendActivity|forwardActivity)["'\`]\s*\])`, "g");
+		for (const match of code.matchAll(aliasPattern)) aliases.add(match[1]);
+	}
+	return globalThis.Array.from(aliases).some((alias) => new RegExp(String.raw`\b${escapeRegExp(alias)}\s*\(`).test(code));
+};
+function createRule(buildReport) {
+	return (context) => {
+		const federationTracker = trackFederationVariables();
+		const bindings = /* @__PURE__ */ new Map();
+		const pendingCalls = [];
+		const sourceCode = context.sourceCode;
+		const inspectCall = (node) => {
+			if (!hasMemberExpressionCallee(node) || !hasIdentifierProperty(node) || !hasMethodName("on")(node) || node.arguments.length < 2) return;
+			if (!isChainedFromOutboxListeners(node.callee.object, federationTracker)) return;
+			const listener = node.arguments[1];
+			const resolvedListener = isNode(listener) && isFunction(listener) ? listener : isNode(listener) ? resolveListenerReference(listener, bindings) : null;
+			if (resolvedListener == null) return;
+			if (listenerCallsDeliveryMethod(sourceCode, resolvedListener)) return;
+			context.report({
+				node: resolvedListener,
+				...buildReport
+			});
+		};
+		return {
+			VariableDeclarator(node) {
+				federationTracker.VariableDeclarator(node);
+				if (node.id.type === "Identifier" && node.init != null) bindings.set(node.id.name, node.init);
+			},
+			FunctionDeclaration(node) {
+				if (node.id != null) bindings.set(node.id.name, node);
+			},
+			CallExpression(node) {
+				pendingCalls.push(node);
+			},
+			"Program:exit"() {
+				for (const node of pendingCalls) inspectCall(node);
+			}
+		};
+	};
+}
+createRule({ message: MESSAGE });
+const eslint = {
+	meta: {
+		type: "suggestion",
+		docs: { description: "Warn when an outbox listener omits explicit delivery methods" },
+		schema: [],
+		messages: { required: "{{ message }}" }
+	},
+	create: createRule({
+		messageId: "required",
+		data: { message: MESSAGE }
+	})
+};
+//#endregion
 //#region src/index.ts
 /**
 * ESLint plugin for Fedify.
 * Provides lint rules for validating Fedify federation code.
 */
 const rules = {
-	[RULE_IDS.actorIdMismatch]: eslint$11,
-	[RULE_IDS.actorIdRequired]: eslint$10,
-	[RULE_IDS.actorFollowingPropertyRequired]: eslint$12,
-	[RULE_IDS.actorFollowingPropertyMismatch]: eslint$13,
-	[RULE_IDS.actorFollowersPropertyRequired]: eslint$14,
-	[RULE_IDS.actorFollowersPropertyMismatch]: eslint$15,
-	[RULE_IDS.actorOutboxPropertyRequired]: eslint$4,
-	[RULE_IDS.actorOutboxPropertyMismatch]: eslint$5,
-	[RULE_IDS.actorLikedPropertyRequired]: eslint$6,
-	[RULE_IDS.actorLikedPropertyMismatch]: eslint$7,
-	[RULE_IDS.actorFeaturedPropertyRequired]: eslint$18,
-	[RULE_IDS.actorFeaturedPropertyMismatch]: eslint$19,
-	[RULE_IDS.actorFeaturedTagsPropertyRequired]: eslint$16,
-	[RULE_IDS.actorFeaturedTagsPropertyMismatch]: eslint$17,
-	[RULE_IDS.actorInboxPropertyRequired]: eslint$8,
-	[RULE_IDS.actorInboxPropertyMismatch]: eslint$9,
-	[RULE_IDS.actorSharedInboxPropertyRequired]: eslint$1,
-	[RULE_IDS.actorSharedInboxPropertyMismatch]: eslint$2,
-	[RULE_IDS.actorPublicKeyRequired]: eslint$3,
-	[RULE_IDS.actorAssertionMethodRequired]: eslint$20,
-	[RULE_IDS.collectionFilteringNotImplemented]: eslint
+	[RULE_IDS.actorIdMismatch]: eslint$12,
+	[RULE_IDS.actorIdRequired]: eslint$11,
+	[RULE_IDS.actorFollowingPropertyRequired]: eslint$13,
+	[RULE_IDS.actorFollowingPropertyMismatch]: eslint$14,
+	[RULE_IDS.actorFollowersPropertyRequired]: eslint$15,
+	[RULE_IDS.actorFollowersPropertyMismatch]: eslint$16,
+	[RULE_IDS.actorOutboxPropertyRequired]: eslint$5,
+	[RULE_IDS.actorOutboxPropertyMismatch]: eslint$6,
+	[RULE_IDS.actorLikedPropertyRequired]: eslint$7,
+	[RULE_IDS.actorLikedPropertyMismatch]: eslint$8,
+	[RULE_IDS.actorFeaturedPropertyRequired]: eslint$19,
+	[RULE_IDS.actorFeaturedPropertyMismatch]: eslint$20,
+	[RULE_IDS.actorFeaturedTagsPropertyRequired]: eslint$17,
+	[RULE_IDS.actorFeaturedTagsPropertyMismatch]: eslint$18,
+	[RULE_IDS.actorInboxPropertyRequired]: eslint$9,
+	[RULE_IDS.actorInboxPropertyMismatch]: eslint$10,
+	[RULE_IDS.actorSharedInboxPropertyRequired]: eslint$2,
+	[RULE_IDS.actorSharedInboxPropertyMismatch]: eslint$3,
+	[RULE_IDS.actorPublicKeyRequired]: eslint$4,
+	[RULE_IDS.actorAssertionMethodRequired]: eslint$21,
+	[RULE_IDS.collectionFilteringNotImplemented]: eslint$1,
+	[RULE_IDS.outboxListenerDeliveryRequired]: eslint
 };
 const recommendedRuleIds = [RULE_IDS.actorIdMismatch, RULE_IDS.actorIdRequired];
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fedify/lint",
-  "version": "2.2.0-pr.695.16+7a782334",
+  "version": "2.2.0-pr.697.18+b776632f",
   "description": "Fedify linting rules and plugins",
   "keywords": [
     "Fedify",
@@ -47,7 +47,7 @@
   ],
   "peerDependencies": {
     "eslint": ">=9.0.0",
-    "@fedify/fedify": "^2.2.0-pr.695.16+7a782334"
+    "@fedify/fedify": "^2.2.0-pr.697.18+b776632f"
   },
   "peerDependenciesMeta": {
     "eslint": {