@fedify/fedify 2.4.0-dev.2219 → 2.4.0-dev.2233

package/dist/{middleware-C2_LcbL3.mjs → middleware-BhtaUtlt.mjs}

@@ -3,28 +3,28 @@ import "urlpattern-polyfill";
 globalThis.addEventListener = () => {};
 import { d as isPortableUri, f as isSameObjectId, i as getPortableDid, l as isPortableId, n as getCanonicalPortableId, o as hasPortableActor, r as getGatewayKeyBase, s as isCompatibleKeyId, t as getAuthenticationOrigin, u as isPortableKeyId } from "./portable-key-id-Ca30-hOa.mjs";
 import { n as isPubliclyAddressedNode, t as isInAudience } from "./audience-CHQ-FlLD.mjs";
-import { n as version, t as name } from "./deno-Dj1TFhf4.mjs";
-import { a as instrumentDocumentLoader, b as recordWebFingerHandle, c as recordCircuitBreakerStateChange, d as recordCollectionRequest, f as recordCollectionTotalItems, g as recordInboxActivity, h as recordFanoutRecipients, i as getRemoteHost, l as recordCollectionDispatchDuration, n as getDurationMs, o as isAbortError, r as getFederationMetrics, u as recordCollectionPageItems, v as recordOutboxActivity, x as registerQueueDepthGauge, y as recordOutboxEnqueue } from "./metrics-BnYleVpg.mjs";
+import { n as version, t as name } from "./deno-62DcBMwc.mjs";
+import { a as instrumentDocumentLoader, b as recordWebFingerHandle, c as recordCircuitBreakerStateChange, d as recordCollectionRequest, f as recordCollectionTotalItems, g as recordInboxActivity, h as recordFanoutRecipients, i as getRemoteHost, l as recordCollectionDispatchDuration, n as getDurationMs, o as isAbortError, r as getFederationMetrics, u as recordCollectionPageItems, v as recordOutboxActivity, x as registerQueueDepthGauge, y as recordOutboxEnqueue } from "./metrics-jr7IbGjd.mjs";
 import { t as formatAcceptSignature } from "./accept-CPVqki78.mjs";
-import { c as validateCryptoKey, n as exportJwk, s as importJwk } from "./key-Djyt1BFx.mjs";
+import { c as validateCryptoKey, n as exportJwk, s as importJwk } from "./key-CtAhsSFI.mjs";
 import { r as normalizeOutgoingActivityJsonLd } from "./outgoing-jsonld-4IJqPYos.mjs";
-import { _ as wrapContextLoaderForJsonLd, a as compactJsonLd, c as getNormalizationContextLoader, d as isClearlyMalformedContextReference, f as isInvalidUrlTypeError, l as hasSignature, m as verifyCompactJsonLd, p as signJsonLd, r as assertSafeJsonLd, s as detachSignature, t as InvalidContextReferenceError, u as hasSignatureLike } from "./ld-CNVWdooi.mjs";
-import { a as signObject, c as verifyPortableObjectProof, i as hasProofLike, s as verifyObject, t as InvalidPortableObjectIdError, u as verifyPortableObjectProofWithRoot } from "./proof-z6Prgi5I.mjs";
-import { a as listRequestSignatures, c as selectRequestSignature, d as validateMaxSignatures, f as verifyRequest, p as verifyRequestDetailed, s as parseRfc9421SignatureInput } from "./http-D-DpP4sd.mjs";
-import { t as getAuthenticatedDocumentLoader } from "./docloader-CzyJe90o.mjs";
-import { n as kvCache } from "./kv-cache-ecUXfCqW.mjs";
+import { _ as wrapContextLoaderForJsonLd, a as compactJsonLd, c as getNormalizationContextLoader, d as isClearlyMalformedContextReference, f as isInvalidUrlTypeError, l as hasSignature, m as verifyCompactJsonLd, p as signJsonLd, r as assertSafeJsonLd, s as detachSignature, t as InvalidContextReferenceError, u as hasSignatureLike } from "./ld-BuI0RakW.mjs";
+import { a as signObject, c as verifyPortableObjectProof, i as hasProofLike, s as verifyObject, t as InvalidPortableObjectIdError, u as verifyPortableObjectProofWithRoot } from "./proof-Bhsb_KYD.mjs";
+import { a as listRequestSignatures, c as selectRequestSignature, d as validateMaxSignatures, f as verifyRequest, p as verifyRequestDetailed, s as parseRfc9421SignatureInput } from "./http-SIEv_YGW.mjs";
+import { t as getAuthenticatedDocumentLoader } from "./docloader-Be9TaKa_.mjs";
+import { n as kvCache } from "./kv-cache-Fn7dxiMu.mjs";
 import { d as readBoundedText, l as BodyTooLargeError, t as getNodeInfo, u as MAX_BODY_SIZE } from "./client-CEnNz8O7.mjs";
 import { t as nodeInfoToJson } from "./types-DE_LV1JB.mjs";
-import { n as getKeyOwner, t as doesActorOwnKey } from "./owner-D_BDPwm2.mjs";
-import { t as verifyPortableObject } from "./portable-collection-hcONGyUs.mjs";
-import { a as getOrderingDestination, i as sendActivityThroughGateways, n as extractInboxes, r as sendActivity, t as SendActivityError } from "./send-Cw545L_2.mjs";
-import { n as FederationBuilderImpl, t as ACTOR_ALIAS_PREFIX } from "./builder-C5rYBZ16.mjs";
+import { n as getKeyOwner, t as doesActorOwnKey } from "./owner-CoNYVTQp.mjs";
+import { t as verifyPortableObject } from "./portable-collection-CxP30PWK.mjs";
+import { a as getOrderingDestination, i as sendActivityThroughGateways, n as extractInboxes, r as sendActivity, t as SendActivityError } from "./send-CdRJj10a.mjs";
+import { n as FederationBuilderImpl, t as ACTOR_ALIAS_PREFIX } from "./builder-BmoDmjWk.mjs";
 import { t as CircuitBreaker } from "./circuit-breaker-XJ53md4S.mjs";
 import { t as buildCollectionSynchronizationHeader } from "./collection-CnnP1UAv.mjs";
-import { a as verifyCompoundPortableObjectProofs, i as inspectCompoundPortableObjectApplicability, r as findUnsupportedCompoundProofShape, s as verifyServedPortableObjects, t as containsCompoundPortableObject } from "./compound-proof-D0xY7MBs.mjs";
+import { a as verifyCompoundPortableObjectProofs, i as inspectCompoundPortableObjectApplicability, r as findUnsupportedCompoundProofShape, s as verifyServedPortableObjects, t as containsCompoundPortableObject } from "./compound-proof-Pn8766TV.mjs";
 import { t as KvKeyCache } from "./keycache-Da8A8mZa.mjs";
 import { t as acceptsJsonLd } from "./negotiation-CCocWT_N.mjs";
-import { t as hasMalformedKnownTemporalLiteral } from "./temporal-Cy-8WCod.mjs";
+import { t as hasMalformedKnownTemporalLiteral } from "./temporal-vBRC6bwu.mjs";
 import { t as createExponentialBackoffPolicy } from "./retry-zX5xw5e0.mjs";
 import { t as TaskCodec } from "./codec-C6rTrpIp.mjs";
 import { getLogger, withContext } from "@logtape/logtape";
@@ -359,6 +359,180 @@ function serializeDataPointType(dataPointType) {
 	}
 }
 //#endregion
+//#region src/federation/compatible-id-warning.ts
+/** Returns a verified first gateway, without dereferencing the actor. */
+async function getLocalFirstGateway(context, ownerId, did) {
+	try {
+		const parsed = context.parseUri(ownerId, { portable: true });
+		if (parsed?.type !== "actor" || parsed.authority !== did) return null;
+		return firstGateway(await context.getActor(parsed.identifier), did);
+	} catch (error) {
+		getLogger([
+			"fedify",
+			"federation",
+			"object"
+		]).debug("Could not check the first gateway of {ownerId}: {error}", {
+			ownerId: ownerId.href,
+			error
+		});
+		return null;
+	}
+}
+function firstGateway(actor, did) {
+	if (actor?.id == null || getPortableDid(actor.id) !== did) return null;
+	const gateway = actor.gateway;
+	return gateway != null && isGatewayUrl(gateway) ? gateway : null;
+}
+/** Looks for an actor already embedded in the document being published. */
+function getEmbeddedFirstGateway(json, ownerId, did) {
+	const owner = getCanonicalPortableId(ownerId);
+	if (owner == null) return null;
+	return visitJsonMaps(json, (map) => {
+		const id = parseMapId(map, isJsonMap(json) ? json : null);
+		if (id == null || getCanonicalPortableId(id) !== owner) return;
+		const gateways = map.gateways ?? map["https://w3id.org/fep/ef61/gateways"];
+		const first = Array.isArray(gateways) ? gateways[0] : isJsonMap(gateways) && Array.isArray(gateways["@list"]) ? gateways["@list"][0] : null;
+		const address = typeof first === "string" ? first : isJsonMap(first) ? first.id ?? first["@id"] : null;
+		if (typeof address !== "string") return;
+		try {
+			const gateway = new URL(address);
+			if (getPortableDid(id) === did && isGatewayUrl(gateway)) return gateway;
+		} catch (error) {
+			if (!(error instanceof TypeError)) throw error;
+		}
+	}) ?? null;
+}
+function isJsonMap(value) {
+	return value != null && typeof value === "object" && !Array.isArray(value);
+}
+/** Warns only when the publisher's actual first gateway is known. */
+function warnCompatibleId(id, did, gateway, kind) {
+	if (!isCompatibleEf61Iri(id) || getPortableDid(id) !== did || id.origin === gateway.origin) return;
+	getLogger([
+		"fedify",
+		"federation",
+		kind === "activity" ? "outbox" : "object"
+	]).warn("The {kind} {id} has an FEP-ef61 compatible identifier on another gateway than its owner's first gateway, {gateway}.  FEP-ef61 requires publishers to use the first gateway in the actor's gateways.", {
+		kind,
+		id: id.href,
+		gateway: gateway.origin
+	});
+}
+/** Reads the root ID without dereferencing or expanding the document. */
+function getCompactRootId(json) {
+	return isJsonMap(json) ? parseMapId(json, json) : null;
+}
+/** Checks an activity and its embedded objects against each one's owner. */
+async function warnCompatibleIdsInJson(json, context) {
+	const root = isJsonMap(json) ? json : null;
+	const rootOwners = root == null ? [] : ownerIds(root, "actor", root);
+	const gateways = /* @__PURE__ */ new Map();
+	const maps = [];
+	visitJsonMaps(json, (map, path) => {
+		maps.push({
+			map,
+			path
+		});
+	});
+	for (const { map, path } of maps) {
+		const id = parseMapId(map, root);
+		if (id == null || !isCompatibleEf61Iri(id)) continue;
+		const type = map.type ?? map["@type"];
+		if ((Array.isArray(type) ? type : [type]).some((t) => typeof t === "string" && /(?:^|[#/:])(CryptographicKey|Multikey|JsonWebKey|Key)$/.test(t))) continue;
+		const did = getPortableDid(id);
+		if (did == null) continue;
+		const owners = path === "" ? rootOwners : [
+			...ownerIds(map, "actor", root),
+			...ownerIds(map, "attributedTo", root),
+			...rootOwners
+		];
+		for (const ownerId of owners) {
+			if (getPortableDid(ownerId) !== did) continue;
+			const key = getCanonicalPortableId(ownerId);
+			if (key == null) continue;
+			let gateway = gateways.get(key);
+			if (gateway === void 0) {
+				gateway = getEmbeddedFirstGateway(json, ownerId, did) ?? (context == null ? null : await getLocalFirstGateway(context, ownerId, did));
+				gateways.set(key, gateway);
+			}
+			if (gateway != null) {
+				warnCompatibleId(id, did, gateway, path === "" ? "activity" : "object");
+				break;
+			}
+		}
+	}
+}
+function ownerIds(map, term, root) {
+	const iri = `https://www.w3.org/ns/activitystreams#${term}`;
+	const values = [map[term], map[iri]];
+	for (const context of [map["@context"], root?.["@context"]]) for (const [alias, definition] of localContextEntries(context)) {
+		const mapped = typeof definition === "string" ? definition : isJsonMap(definition) ? definition["@id"] : null;
+		if (mapped === iri || mapped === `as:${term}`) values.push(map[alias]);
+	}
+	return values.flatMap((value) => parseOwnerIds(value, root));
+}
+function localContextEntries(context) {
+	if (Array.isArray(context)) return context.flatMap(localContextEntries);
+	return isJsonMap(context) ? Object.entries(context) : [];
+}
+function parseOwnerIds(value, root) {
+	if (Array.isArray(value)) return value.flatMap((item) => parseOwnerIds(item, root));
+	if (isJsonMap(value)) {
+		const id = parseMapId(value, root);
+		return id == null ? [] : [id];
+	}
+	if (typeof value !== "string") return [];
+	try {
+		return [parseIri(value)];
+	} catch (error) {
+		if (error instanceof TypeError) return [];
+		throw error;
+	}
+}
+function parseMapId(map, root) {
+	let raw = map["@id"] ?? map.id;
+	for (const context of [map["@context"], root?.["@context"]]) for (const [alias, definition] of localContextEntries(context)) if ((typeof definition === "string" ? definition : isJsonMap(definition) ? definition["@id"] : null) === "@id" && typeof map[alias] === "string") {
+		raw = map[alias];
+		break;
+	}
+	if (typeof raw !== "string") return null;
+	try {
+		return parseIri(raw);
+	} catch (error) {
+		if (error instanceof TypeError) return null;
+		throw error;
+	}
+}
+function visitJsonMaps(json, visit) {
+	const seen = /* @__PURE__ */ new Set();
+	const pending = [{
+		value: json,
+		path: ""
+	}];
+	while (pending.length > 0) {
+		const { value, path } = pending.pop();
+		if (value == null || typeof value !== "object" || seen.has(value)) continue;
+		seen.add(value);
+		if (Array.isArray(value)) {
+			for (let i = value.length - 1; i >= 0; i--) pending.push({
+				value: value[i],
+				path: `${path}/${i}`
+			});
+			continue;
+		}
+		const map = value;
+		const result = visit(map, path);
+		if (result !== void 0) return result;
+		for (const key of Object.keys(map).reverse()) {
+			if (key === "proof" || key === "@context") continue;
+			pending.push({
+				value: map[key],
+				path: `${path}/${key}`
+			});
+		}
+	}
+}
+//#endregion
 //#region src/federation/inbox.ts
 async function routeActivity({ context: ctx, json, originalJson, normalizedActivity, ldSignatureVerified, activity, recipient, inboxListeners, inboxContextFactory, listenerInboxContextFactory, inboxErrorHandler, kv, kvPrefixes, queue, span, meterProvider, tracerProvider, idempotencyStrategy }) {
 	const logger = getLogger([
@@ -1202,6 +1376,7 @@ async function handleObject(request, { values, context, objectDispatcher, author
 			Vary: "Accept"
 		}
 	});
+	await warnServedCompatibleObject(context, object, getCompactRootId(jsonLd));
 	return new Response(JSON.stringify(jsonLd), { headers: {
 		"Content-Type": "application/activity+json",
 		Vary: "Accept"
@@ -1305,6 +1480,7 @@ async function handlePortableObject(request, { values, context, objectDispatcher
 			return portableObjectInternalServerError(request);
 		}
 	}
+	if (!tombstone) await warnServedCompatibleObject(context, object, servedId);
 	const headers = new Headers({
 		"Content-Type": PORTABLE_OBJECT_CONTENT_TYPE,
 		Vary: "Accept"
@@ -1315,6 +1491,32 @@ async function handlePortableObject(request, { values, context, objectDispatcher
 		headers
 	});
 }
+async function warnServedCompatibleObject(context, object, serializedId) {
+	try {
+		if (isActor(object)) return;
+		const id = typeof serializedId === "string" ? parseIri(serializedId) : serializedId ?? object.id;
+		if (id == null || !isCompatibleEf61Iri(id)) return;
+		const did = getPortableDid(id);
+		if (did == null) return;
+		const ownerIds = object instanceof Activity ? object.actorIds : object.attributionIds;
+		for (const ownerId of ownerIds) {
+			if (getPortableDid(ownerId) !== did) continue;
+			const gateway = await getLocalFirstGateway(context, ownerId, did);
+			if (gateway == null) continue;
+			warnCompatibleId(id, did, gateway, object instanceof Activity ? "activity" : "object");
+			break;
+		}
+	} catch (error) {
+		getLogger([
+			"fedify",
+			"federation",
+			"object"
+		]).debug("Could not check the first gateway of {objectId}: {error}", {
+			objectId: object.id?.href,
+			error
+		});
+	}
+}
 function isRequestedPortableObject(object, canonicalId) {
 	return object.id != null && getCanonicalPortableId(object.id) === canonicalId;
 }
@@ -1418,13 +1620,13 @@ function recordCollectionMetrics(meterProvider, base, result, options = {}) {
 * @param parameters The parameters for handling the collection.
 * @returns A promise that resolves to an HTTP response.
 */
-async function handleCollection(request, { name: name$2, identifier, uriGetter, filter, filterPredicate, context, collectionCallbacks, portable, tracerProvider, meterProvider, onUnauthorized, onNotFound }) {
-	const spanName = name$2.trim().replace(/\s+/g, "_");
+async function handleCollection(request, { name: name$1, identifier, uriGetter, filter, filterPredicate, context, collectionCallbacks, portable, tracerProvider, meterProvider, onUnauthorized, onNotFound }) {
+	const spanName = name$1.trim().replace(/\s+/g, "_");
 	tracerProvider = tracerProvider ?? trace.getTracerProvider();
 	const tracer = tracerProvider.getTracer(name, version);
 	const cursor = new URL(request.url).searchParams.get("cursor");
 	const metricBase = {
-		kind: getCollectionMetricKind(name$2),
+		kind: getCollectionMetricKind(name$1),
 		page: cursor != null,
 		dispatcher: "built_in"
 	};
@@ -1470,7 +1672,7 @@ async function handleCollection(request, { name: name$2, identifier, uriGetter,
 							span.setStatus({ code: SpanStatusCode.ERROR });
 							return await onNotFound(request);
 						}
-						const items = filterCollectionItems(page.items, name$2, filterPredicate);
+						const items = filterCollectionItems(page.items, name$1, filterPredicate);
 						itemCount = items.length;
 						span.setAttribute("fedify.collection.items", itemCount);
 						return items;
@@ -1512,7 +1714,7 @@ async function handleCollection(request, { name: name$2, identifier, uriGetter,
 		} else {
 			const uri = new URL(portable == null ? baseUri : pageBase);
 			uri.searchParams.set("cursor", cursor);
-			const pageOrResponse = await tracer.startActiveSpan(`activitypub.dispatch_collection_page ${name$2}`, {
+			const pageOrResponse = await tracer.startActiveSpan(`activitypub.dispatch_collection_page ${name$1}`, {
 				kind: SpanKind.SERVER,
 				attributes: {
 					"activitypub.collection.id": uri.href,
@@ -1528,7 +1730,7 @@ async function handleCollection(request, { name: name$2, identifier, uriGetter,
 						span.setStatus({ code: SpanStatusCode.ERROR });
 						return await onNotFound(request);
 					}
-					const items = filterCollectionItems(page.items, name$2, filterPredicate);
+					const items = filterCollectionItems(page.items, name$1, filterPredicate);
 					itemCount = items.length;
 					span.setAttribute("fedify.collection.items", itemCount);
 					return {
@@ -1740,7 +1942,7 @@ async function handleOutbox(request, { identifier, context: ctx, outboxContextFa
 			headers: { "Content-Type": "text/plain; charset=utf-8" }
 		});
 	}
-	if (!activity.actorIds.every((actorId) => actorId.href === expectedActorId.href)) {
+	if (!activity.actorIds.every((actorId) => isSameObjectId(actorId, expectedActorId))) {
 		const error = /* @__PURE__ */ new Error("The activity actor does not match the outbox owner.");
 		logger.error("The posted activity actor does not match outbox owner {identifier}.", {
 			identifier,
@@ -2719,8 +2921,8 @@ var CustomCollectionHandler = class {
 	* @param CollectionPage The CollectionPage constructor.
 	* @param filterPredicate Optional filter predicate for items.
 	*/
-	constructor(name$1, values, context, callbacks, tracerProvider = trace.getTracerProvider(), meterProvider, Collection, CollectionPage, filterPredicate, portable) {
-		this.name = name$1;
+	constructor(name$2, values, context, callbacks, tracerProvider = trace.getTracerProvider(), meterProvider, Collection, CollectionPage, filterPredicate, portable) {
+		this.name = name$2;
 		this.values = values;
 		this.context = context;
 		this.callbacks = callbacks;
@@ -7144,17 +7346,26 @@ var ContextImpl = class ContextImpl {
 			activityId: activity.id?.href,
 			activity
 		});
+		const activityJsonLd = await activity.toJsonLd({
+			format: "compact",
+			contextLoader: this.contextLoader
+		});
+		try {
+			await warnCompatibleIdsInJson(activityJsonLd, this instanceof RequestContextImpl && !this.isInActorDispatcher() ? this : void 0);
+		} catch (error) {
+			logger.debug("Could not check the first gateway of activity {activityId}: {error}", {
+				activityId: activity.id?.href,
+				error
+			});
+		}
 		if (this.federation.fanoutQueue == null || options.immediate || options.fanout === "skip" || (options.fanout ?? "auto") === "auto" && globalThis.Object.keys(inboxes).length < FANOUT_THRESHOLD) {
 			await this.federation.sendActivity(keys, inboxes, activity, {
 				...opts,
+				activityJsonLd,
 				normalizeExistingProofs: proofCreated || options.normalizeExistingProofs
 			});
 			return true;
 		}
-		const activityJsonLd = await activity.toJsonLd({
-			format: "compact",
-			contextLoader: this.contextLoader
-		});
 		assertSupportedCompoundProofShape(activityJsonLd, activity.id?.href);
 		const keyJwkPairs = await Promise.all(keys.map(async ({ keyId, privateKey }) => ({
 			keyId: keyId.href,
@@ -7337,6 +7548,10 @@ var RequestContextImpl = class RequestContextImpl extends ContextImpl {
 	#invokedFromActorDispatcher;
 	#invokedFromObjectDispatcher;
 	request;
+	/** Whether a diagnostic actor lookup would re-enter the actor dispatcher. */
+	isInActorDispatcher() {
+		return this.#invokedFromActorDispatcher != null;
+	}
 	url = void 0;
 	portableRequest;
 	constructor(options) {
@@ -7787,4 +8002,4 @@ function getRequestId(request) {
 	return `req_${Date.now().toString(36)}${Math.random().toString(36).slice(2, 8)}`;
 }
 //#endregion
-export { handleNodeInfo as C, autoIdAssigner as E, handleBenchmarkTrigger as S, actorDehydrator as T, coversDelivery as _, OutboxContextImpl as a, PORTABLE_OBJECT_CONTENT_TYPE as b, assertPortableActorActivity as c, handleCustomCollection as d, handleInbox as f, respondWithObjectIfAcceptable as g, respondWithObject as h, KvSpecDeterminer as i, handleActor as l, handleOutbox as m, FederationImpl as n, createFederation as o, handleObject as p, InboxContextImpl as r, handleWebFinger as s, ContextImpl as t, handleCollection as u, forwardPortableInboxActivity as v, handleNodeInfoJrd as w, parseHashlinkGatewayRequest as x, resolvePortableInboxForwardingOptions as y };
+export { getEmbeddedFirstGateway as C, handleNodeInfoJrd as D, handleNodeInfo as E, actorDehydrator as O, getCompactRootId as S, handleBenchmarkTrigger as T, coversDelivery as _, OutboxContextImpl as a, PORTABLE_OBJECT_CONTENT_TYPE as b, assertPortableActorActivity as c, handleCustomCollection as d, handleInbox as f, respondWithObjectIfAcceptable as g, respondWithObject as h, KvSpecDeterminer as i, autoIdAssigner as k, handleActor as l, handleOutbox as m, FederationImpl as n, createFederation as o, handleObject as p, InboxContextImpl as r, handleWebFinger as s, ContextImpl as t, handleCollection as u, forwardPortableInboxActivity as v, warnCompatibleIdsInJson as w, parseHashlinkGatewayRequest as x, resolvePortableInboxForwardingOptions as y };