@fedify/fedify 2.4.0-dev.2169 → 2.4.0-dev.2193

package/dist/federation/portable-route-activity.test.mjs

@@ -0,0 +1,259 @@
+import "temporal-polyfill";
+import "urlpattern-polyfill";
+globalThis.addEventListener = () => {};
+import { t as MemoryKvStore } from "../kv-DCHkaJ9-.mjs";
+import { t as assertEquals } from "../assert_equals-Z6IcEbWU.mjs";
+import { t as assertFalse } from "../assert_false-CPdRnc3E.mjs";
+import "../std__assert-DvMDRPes.mjs";
+import { t as assert } from "../assert-D1Eafmd_.mjs";
+import { a as signObject } from "../proof-DrJWKeOl.mjs";
+import { n as ed25519PrivateKey, r as ed25519PublicKey } from "../keys-DIJNHW-Y.mjs";
+import { o as createFederation } from "../middleware-BqqycC0P.mjs";
+import { Create, Note } from "@fedify/vocab";
+import { mockDocumentLoader, test } from "@fedify/fixture";
+import { exportDidKey, formatIri, parseIri, toCompatibleEf61Id } from "@fedify/vocab-runtime";
+//#region src/federation/portable-route-activity.test.ts
+const did = await exportDidKey(ed25519PublicKey.publicKey);
+const keyId = new URL(`${did}#${did.slice(8)}`);
+const otherKeyPair = await crypto.subtle.generateKey("Ed25519", true, ["sign", "verify"]);
+const otherDid = await exportDidKey(otherKeyPair.publicKey);
+const otherKeyId = new URL(`${otherDid}#${otherDid.slice(8)}`);
+const GATEWAY = "https://gw.example";
+function portableId(authority, path) {
+	return parseIri(`ap+ef61://${authority}${path}`);
+}
+function compatibleId(authority, path, gateway = GATEWAY) {
+	return new URL(`${gateway}/.well-known/apgateway/${authority}${path}`);
+}
+async function sign(activity, signer) {
+	return await signObject(activity, signer === "did" ? ed25519PrivateKey : otherKeyPair.privateKey, signer === "did" ? keyId : otherKeyId, { contextLoader: mockDocumentLoader });
+}
+/**
+* Routes a `Create` activity with the given ID through
+* `Context.routeActivity()`.  Unless `activity` is an `Activity`, the routed
+* activity has no proof, so that it is trusted only if it can be dereferenced
+* by its ID, which serves `served`.
+* @returns Whether the activity was routed, and the IDs of the actors of
+*          the activities that reached the inbox listener.
+*/
+async function route(activity, { served, actors } = {}) {
+	const documents = /* @__PURE__ */ new Map();
+	if (served != null && activity instanceof URL) {
+		const document = await served.toJsonLd({ contextLoader: mockDocumentLoader });
+		documents.set(activity.href, document);
+		if (activity.protocol === "ap+ef61:") {
+			documents.set(formatIri(activity), document);
+			documents.set(toCompatibleEf61Id(activity, GATEWAY).href, document);
+		}
+	}
+	const documentLoader = (url, options) => {
+		if (documents.has(url)) return Promise.resolve({
+			contextUrl: null,
+			documentUrl: url,
+			document: documents.get(url)
+		});
+		return mockDocumentLoader(url, options);
+	};
+	const federation = createFederation({
+		kv: new MemoryKvStore(),
+		documentLoaderFactory: () => documentLoader,
+		contextLoaderFactory: () => mockDocumentLoader
+	});
+	const received = [];
+	federation.setInboxListeners("/users/{identifier}/inbox", "/inbox").on(Create, (_ctx, create) => {
+		received.push(...create.actorIds.map((id) => id.href));
+	});
+	return {
+		routed: await federation.createContext(new URL("https://example.com/")).routeActivity(null, activity instanceof URL ? new Create({
+			id: activity,
+			actors: [...actors ?? served?.actorIds ?? []]
+		}) : activity),
+		received
+	};
+}
+async function portableCreate(id, actors, signer = "did") {
+	return await sign(new Create({
+		id,
+		actors: [...actors],
+		object: new Note({ content: "Hello" })
+	}), signer);
+}
+test("Context.routeActivity() rejects portable activities attributed to other DIDs", async (t) => {
+	const cases = [
+		[
+			"ap+ef61: IDs",
+			portableId(did, "/activities/1"),
+			[portableId(otherDid, "/actor")]
+		],
+		[
+			"compatible identifiers on one gateway",
+			compatibleId(did, "/activities/1"),
+			[compatibleId(otherDid, "/actor")]
+		],
+		[
+			"compatible activity ID and ap+ef61: actor ID",
+			compatibleId(did, "/activities/1"),
+			[portableId(otherDid, "/actor")]
+		],
+		[
+			"ap+ef61: activity ID and compatible actor ID",
+			portableId(did, "/activities/1"),
+			[compatibleId(otherDid, "/actor")]
+		],
+		[
+			"one of multiple actors with another DID",
+			portableId(did, "/activities/1"),
+			[portableId(did, "/actor"), portableId(otherDid, "/actor")]
+		],
+		[
+			"ap+ef61: activity ID and HTTP(S) actor ID",
+			portableId(did, "/activities/1"),
+			[new URL("https://example.com/person")]
+		],
+		[
+			"compatible activity ID and HTTP(S) actor ID on the gateway",
+			compatibleId(did, "/activities/1"),
+			[new URL(`${GATEWAY}/users/alice`)]
+		]
+	];
+	for (const [name, id, actors] of cases) await t.step(name, async () => {
+		const served = await portableCreate(id, actors);
+		assertEquals(await route(id, { served }), {
+			routed: false,
+			received: []
+		});
+		assertEquals(await route(served), {
+			routed: false,
+			received: []
+		});
+	});
+});
+test("Context.routeActivity() accepts portable activities of the same DID", async (t) => {
+	const cases = [
+		[
+			"ap+ef61: IDs",
+			portableId(did, "/activities/1"),
+			[portableId(did, "/actor")]
+		],
+		[
+			"compatible identifiers on one gateway",
+			compatibleId(did, "/activities/1"),
+			[compatibleId(did, "/actor")]
+		],
+		[
+			"compatible identifiers on different gateways",
+			compatibleId(did, "/activities/1"),
+			[compatibleId(did, "/actor", "https://gw2.example")]
+		],
+		[
+			"compatible activity ID and ap+ef61: actor ID",
+			compatibleId(did, "/activities/1"),
+			[portableId(did, "/actor")]
+		],
+		[
+			"ap+ef61: activity ID and compatible actor ID",
+			portableId(did, "/activities/1"),
+			[compatibleId(did, "/actor")]
+		],
+		[
+			"actor ID with a location hint",
+			portableId(did, "/activities/1"),
+			[portableId(did, `/actor?@gateway=${encodeURIComponent(GATEWAY)}`)]
+		]
+	];
+	for (const [name, id, actors] of cases) await t.step(name, async () => {
+		const served = await portableCreate(id, actors);
+		const expected = {
+			routed: true,
+			received: actors.map((actor) => actor.href)
+		};
+		assertEquals(await route(id, { served }), expected);
+		assertEquals(await route(served), expected);
+	});
+});
+test("Context.routeActivity() compares portable activity IDs canonically", async (t) => {
+	const id = portableId(did, "/activities/1");
+	const actors = [portableId(did, "/actor")];
+	await t.step("compatible ID serving an ap+ef61: ID", async () => {
+		const served = await portableCreate(id, actors);
+		const { routed } = await route(compatibleId(did, "/activities/1"), { served });
+		assert(routed);
+	});
+	await t.step("ap+ef61: ID serving a compatible ID", async () => {
+		const served = await portableCreate(compatibleId(did, "/activities/1"), actors);
+		const { routed } = await route(id, { served });
+		assert(routed);
+	});
+	await t.step("ap+ef61: ID with a location hint", async () => {
+		const served = await portableCreate(id, actors);
+		const { routed } = await route(portableId(did, `/activities/1?@gateway=${encodeURIComponent(GATEWAY)}`), { served });
+		assert(routed);
+	});
+	await t.step("another path of the same DID", async () => {
+		const served = await portableCreate(portableId(did, "/activities/2"), actors);
+		const { routed } = await route(id, { served });
+		assertFalse(routed);
+	});
+	await t.step("another fragment of the same DID", async () => {
+		const served = await portableCreate(portableId(did, "/activities/1#other"), actors);
+		const { routed } = await route(id, { served });
+		assertFalse(routed);
+	});
+});
+test("Context.routeActivity() rejects proofs of other DIDs for portable actors", async () => {
+	const id = portableId(did, "/activities/1");
+	const actors = [portableId(did, "/actor")];
+	assertEquals(await route(await portableCreate(id, actors, "otherDid")), {
+		routed: false,
+		received: []
+	});
+	assertEquals(await route(await portableCreate(id, actors)), {
+		routed: true,
+		received: actors.map((actor) => actor.href)
+	});
+});
+test("Context.routeActivity() keeps comparing web origins of HTTP(S) IDs", async (t) => {
+	const cases = [
+		[
+			"same origin",
+			new URL("https://remote.example/activities/1"),
+			new URL("https://remote.example/users/alice"),
+			true
+		],
+		[
+			"same origin with an explicit default port",
+			new URL("https://remote.example/activities/1"),
+			new URL("https://remote.example:443/users/alice"),
+			true
+		],
+		[
+			"another origin",
+			new URL("https://remote.example/activities/1"),
+			new URL("https://other.example/users/alice"),
+			false
+		],
+		[
+			"another port",
+			new URL("https://remote.example/activities/1"),
+			new URL("https://remote.example:8443/users/alice"),
+			false
+		],
+		[
+			"compatible actor ID on the same host",
+			new URL("https://remote.example/activities/1"),
+			compatibleId(did, "/actor", "https://remote.example"),
+			false
+		]
+	];
+	for (const [name, id, actor, expected] of cases) await t.step(name, async () => {
+		const served = new Create({
+			id,
+			actor
+		});
+		const { routed, received } = await route(id, { served });
+		assertEquals(routed, expected);
+		assertEquals(received, expected ? [actor.href] : []);
+	});
+});
+//#endregion
+export {};

package/dist/federation/portable.test.mjs

@@ -8,10 +8,10 @@ import { t as assertThrows } from "../assert_throws-BYITOvPO.mjs";
 import "../std__assert-DvMDRPes.mjs";
 import { t as assertStrictEquals } from "../assert_strict_equals-CYvBmkpC.mjs";
 import { t as assert } from "../assert-D1Eafmd_.mjs";
-import { a as signObject, c as verifyPortableObjectProof } from "../proof-CQAYqWdj.mjs";
-import { l as signRequest } from "../http-Bd6rZlJX.mjs";
+import { a as signObject, c as verifyPortableObjectProof } from "../proof-DrJWKeOl.mjs";
+import { l as signRequest } from "../http-DQf9Mw4V.mjs";
 import { a as rsaPrivateKey3, c as rsaPublicKey3, i as rsaPrivateKey2, n as ed25519PrivateKey, r as ed25519PublicKey, s as rsaPublicKey2 } from "../keys-DIJNHW-Y.mjs";
-import { b as PORTABLE_OBJECT_CONTENT_TYPE, o as createFederation } from "../middleware-Coqgp-K0.mjs";
+import { b as PORTABLE_OBJECT_CONTENT_TYPE, o as createFederation } from "../middleware-BqqycC0P.mjs";
 import { configure, reset } from "@logtape/logtape";
 import { Collection, Create, Note, Object as Object$1, Person, Tombstone, lookupObject } from "@fedify/vocab";
 import { mockDocumentLoader, test } from "@fedify/fixture";
@@ -215,6 +215,11 @@ test("Federation.fetch() applies the FEP-ef61 proof policy to portable objects",
 			object.id.pathname = "/objects/mutated-id";
 			return object;
 		},
+		"actor-without-gateways": () => sign(new Person({
+			id: parseIri(`ap+ef61://${did}/objects/actor-without-gateways`),
+			inbox: parseIri(`ap+ef61://${did}/objects/actor-without-gateways/inbox`),
+			outbox: parseIri(`ap+ef61://${did}/objects/actor-without-gateways/outbox`)
+		})),
 		"unsigned-actor": () => Promise.resolve(new Person({
 			id: parseIri(`ap+ef61://${did}/objects/unsigned-actor`),
 			inbox: parseIri(`ap+ef61://${did}/objects/unsigned-actor/inbox`),
@@ -234,6 +239,7 @@ test("Federation.fetch() applies the FEP-ef61 proof policy to portable objects",
 		"activity": 200,
 		"actor": 200,
 		"mutated-id": 404,
+		"actor-without-gateways": 500,
 		"unsigned-actor": 500
 	})) await t.step(`${id} → ${status}`, async () => {
 		const response = await federation.fetch(gatewayRequest(`/objects/${id}`), { contextData: void 0 });
@@ -716,9 +722,11 @@ test("Federation.fetch() serves compatible-ID actors", async (t) => {
 		})).map((r) => r.properties.gateway), ["https://primary.example"]);
 	});
 	await t.step("warns if the actor has no gateways", async () => {
-		assertEquals((await captureWarnings(async () => {
+		const records = await captureWarnings(async () => {
 			assertEquals((await federation.fetch(new Request("https://example.com/users/nogateway", { headers: { Accept: ACCEPT } }), { contextData: void 0 })).status, 200);
-		})).map((r) => r.properties.actorId), [gatewayUrl("/actors/nogateway")]);
+		});
+		assertEquals(records.map((r) => r.properties.actorId), [gatewayUrl("/actors/nogateway")]);
+		assert(String(records[0].rawMessage).includes("gateways property"));
 	});
 	await t.step("warns if the ID is a malformed compatible identifier", async () => {
 		const records = await captureWarnings(async () => {
@@ -728,5 +736,41 @@ test("Federation.fetch() serves compatible-ID actors", async (t) => {
 		assert(String(records[0].rawMessage).includes("malformed"));
 	});
 });
+test("Federation.fetch() warns about portable actors without valid gateways", async (t) => {
+	const federation = createTestFederation();
+	const actors = {
+		valid: (ctx) => new Person({
+			id: ctx.getPortableObjectUri(Person, { name: "valid" }, did),
+			gateways: [new URL("https://example.com"), new URL("https://other.example/")]
+		}),
+		empty: (ctx) => new Person({ id: ctx.getPortableObjectUri(Person, { name: "empty" }, did) }),
+		mutated: (ctx) => {
+			const actor = new Person({
+				id: ctx.getPortableObjectUri(Person, { name: "mutated" }, did),
+				gateways: [new URL("https://example.com"), new URL("https://other.example/")]
+			});
+			actor.gateways[1].pathname = "/gateway";
+			return actor;
+		},
+		https: (ctx) => new Person({ id: ctx.getActorUri("https") }),
+		tombstone: (ctx) => new Tombstone({ id: ctx.getPortableObjectUri(Person, { name: "tombstone" }, did) })
+	};
+	federation.setActorDispatcher("/users/{identifier}", (ctx, identifier) => actors[identifier]?.(ctx) ?? null);
+	federation.setObjectDispatcher(Person, "/actors/{name}", () => null);
+	const expected = {
+		valid: [],
+		empty: [`ap+ef61://${did}/actors/empty`],
+		mutated: [`ap+ef61://${did}/actors/mutated`],
+		https: [],
+		tombstone: []
+	};
+	for (const [identifier, actorIds] of globalThis.Object.entries(expected)) await t.step(identifier, async () => {
+		const actorRecords = (await captureWarnings(async () => {
+			await federation.fetch(new Request(`https://example.com/users/${identifier}`, { headers: { Accept: ACCEPT } }), { contextData: void 0 });
+		})).filter((r) => r.category.join(".") === "fedify.federation.actor");
+		assertEquals(actorRecords.map((r) => r.properties.actorId), actorIds.map((id) => parseIri(id).href));
+		for (const record of actorRecords) assert(String(record.rawMessage).includes("gateways property"));
+	});
+});
 //#endregion
 export {};

package/dist/federation/send.test.mjs

@@ -10,10 +10,10 @@ import { t as assertNotEquals } from "../assert_not_equals-CpPK2t89.mjs";
 import "../std__assert-DvMDRPes.mjs";
 import { t as assertRejects } from "../assert_rejects-CTptdYck.mjs";
 import { t as assert } from "../assert-D1Eafmd_.mjs";
-import { d as verifyRequest } from "../http-Bd6rZlJX.mjs";
+import { f as verifyRequest } from "../http-DQf9Mw4V.mjs";
 import { i as rsaPrivateKey2, n as ed25519PrivateKey, s as rsaPublicKey2, t as ed25519Multikey } from "../keys-DIJNHW-Y.mjs";
-import { t as doesActorOwnKey } from "../owner-D3GoetXS.mjs";
-import { n as extractInboxes, r as sendActivity, t as SendActivityError } from "../send-DjkQrxt5.mjs";
+import { t as doesActorOwnKey } from "../owner-BVpZBM-V.mjs";
+import { n as extractInboxes, r as sendActivity, t as SendActivityError } from "../send-CT3a-0Vd.mjs";
 import { Activity, Application, Endpoints, Group, Person, Service } from "@fedify/vocab";
 import { createTestMeterProvider, createTestTracerProvider, mockDocumentLoader, test } from "@fedify/fixture";
 import { FetchError, UrlError } from "@fedify/vocab-runtime";

package/dist/federation/tasks/enqueue.test.mjs

@@ -4,7 +4,7 @@ globalThis.addEventListener = () => {};
 import { t as MemoryKvStore } from "../../kv-DCHkaJ9-.mjs";
 import { a as numberSchema, i as makeSchema, n as baseOptions, o as stringSchema, t as MockQueue } from "../../tasks-IG3pHfvZ.mjs";
 import "../../testing-C1itIjqW.mjs";
-import { o as createFederation } from "../../middleware-Coqgp-K0.mjs";
+import { o as createFederation } from "../../middleware-BqqycC0P.mjs";
 import { n as ParallelMessageQueue } from "../../mq-Dm1Wmtm-.mjs";
 import { configure, reset } from "@logtape/logtape";
 import { delay } from "es-toolkit";

package/dist/federation/tasks/tasks.test.mjs

@@ -4,8 +4,8 @@ globalThis.addEventListener = () => {};
 import { t as MemoryKvStore } from "../../kv-DCHkaJ9-.mjs";
 import { a as numberSchema, i as makeSchema, n as baseOptions, o as stringSchema, t as MockQueue } from "../../tasks-IG3pHfvZ.mjs";
 import "../../testing-C1itIjqW.mjs";
-import { o as createFederation } from "../../middleware-Coqgp-K0.mjs";
-import { r as createFederationBuilder } from "../../builder-B2d_Pt0j.mjs";
+import { o as createFederation } from "../../middleware-BqqycC0P.mjs";
+import { r as createFederationBuilder } from "../../builder-0onlMY4u.mjs";
 import { t as TaskCodec } from "../../codec-C6rTrpIp.mjs";
 import { t as InProcessMessageQueue } from "../../mq-Dm1Wmtm-.mjs";
 import { W3CTraceContextPropagator } from "@opentelemetry/core";

package/dist/federation/temporal.test.mjs

@@ -4,7 +4,7 @@ globalThis.addEventListener = () => {};
 import { t as assertFalse } from "../assert_false-CPdRnc3E.mjs";
 import "../std__assert-DvMDRPes.mjs";
 import { t as assert } from "../assert-D1Eafmd_.mjs";
-import { t as hasMalformedKnownTemporalLiteral } from "../temporal-oRKP803M.mjs";
+import { t as hasMalformedKnownTemporalLiteral } from "../temporal-DNqluyEc.mjs";
 import { test } from "@fedify/fixture";
 //#region src/federation/temporal.test.ts
 test("hasMalformedKnownTemporalLiteral() detects expanded proof timestamps", async () => {

package/dist/federation/webfinger.test.mjs

@@ -6,7 +6,7 @@ import { t as MemoryKvStore } from "../kv-DCHkaJ9-.mjs";
 import { t as assertEquals } from "../assert_equals-Z6IcEbWU.mjs";
 import { t as assertNotEquals } from "../assert_not_equals-CpPK2t89.mjs";
 import "../std__assert-DvMDRPes.mjs";
-import { o as createFederation, s as handleWebFinger } from "../middleware-Coqgp-K0.mjs";
+import { o as createFederation, s as handleWebFinger } from "../middleware-BqqycC0P.mjs";
 import { Image, Link, Person, Tombstone } from "@fedify/vocab";
 import { createTestMeterProvider, test } from "@fedify/fixture";
 import { parseIri } from "@fedify/vocab-runtime";