@fedify/fedify 2.1.23 → 2.1.25

package/dist/federation/send.test.mjs

@@ -3,17 +3,18 @@ import "urlpattern-polyfill";
 globalThis.addEventListener = () => {};
 import { t as esm_default } from "../esm-DVILvP5e.mjs";
 import { t as assertEquals } from "../assert_equals-Ew3jOFa3.mjs";
-import "../std__assert-Duiq_YC9.mjs";
+import "../std__assert-BUOJXi-Z.mjs";
 import { n as assertFalse, t as assertRejects } from "../assert_rejects-B-qJtC9Z.mjs";
-import { t as assertInstanceOf } from "../assert_instance_of-C4Ri6VuN.mjs";
+import { n as assertInstanceOf, t as assert } from "../assert-BhQd8QHP.mjs";
 import { t as assertNotEquals } from "../assert_not_equals--wG9hV7u.mjs";
-import { t as assert } from "../assert-ddO5KLpe.mjs";
-import { l as verifyRequest } from "../http-DIh9_s_-.mjs";
-import { i as rsaPrivateKey2, n as ed25519PrivateKey, s as rsaPublicKey2, t as ed25519Multikey } from "../keys-BAK-tUlf.mjs";
-import { t as doesActorOwnKey } from "../owner-Cygg-fHW.mjs";
-import { n as extractInboxes, r as sendActivity, t as SendActivityError } from "../send-CqaJDT2z.mjs";
+import { l as verifyRequest } from "../http-B5qAeoJd.mjs";
+import { i as rsaPrivateKey2, n as ed25519PrivateKey, s as rsaPublicKey2, t as ed25519Multikey } from "../keys-CtZLJq76.mjs";
+import { t as doesActorOwnKey } from "../owner-DklgvZXn.mjs";
+import { n as extractInboxes, r as sendActivity, t as SendActivityError } from "../send-DJmW6Z-I.mjs";
 import { createTestTracerProvider, mockDocumentLoader, test } from "@fedify/fixture";
 import { Activity, Application, Endpoints, Group, Person, Service } from "@fedify/vocab";
+import { FetchError, UrlError } from "@fedify/vocab-runtime";
+import dns from "node:dns/promises";
 //#region src/federation/send.test.ts
 test("extractInboxes()", () => {
 	const recipients = [
@@ -415,5 +416,199 @@ test("sendActivity() records OpenTelemetry span events", async (t) => {
 		esm_default.hardReset();
 	});
 });
+for (const signed of [false, true]) {
+	const keys = [{
+		privateKey: signed ? rsaPrivateKey2 : ed25519PrivateKey,
+		keyId: signed ? rsaPublicKey2.id : ed25519Multikey.id
+	}];
+	test(`sendActivity() validates destinations (signed: ${signed})`, async (t) => {
+		const activity = {
+			type: "Create",
+			id: "https://example.com/activity"
+		};
+		const publicInbox = "https://8.8.8.8/inbox";
+		const privateInbox = "http://127.0.0.1/inbox";
+		for (const target of [
+			privateInbox,
+			"http://169.254.169.254/",
+			"http://[::1]/"
+		]) await t.step(`rejects ${target} before fetching`, async () => {
+			esm_default.mockGlobal().catch(202);
+			try {
+				await assertRejects(() => sendActivity({
+					activity,
+					keys,
+					inbox: new URL(target)
+				}), UrlError);
+				assertEquals(esm_default.callHistory.calls().length, 0);
+			} finally {
+				esm_default.hardReset();
+			}
+		});
+		for (const status of [
+			301,
+			302,
+			303,
+			307,
+			308
+		]) for (const allowPrivateAddress of [false, true]) await t.step(`${status} private redirect, opt-in: ${allowPrivateAddress}`, async () => {
+			esm_default.mockGlobal();
+			esm_default.route(publicInbox, {
+				status,
+				headers: { Location: privateInbox }
+			});
+			esm_default.route(privateInbox, 202);
+			try {
+				const send = () => sendActivity({
+					activity,
+					keys,
+					inbox: new URL(publicInbox),
+					allowPrivateAddress
+				});
+				if (allowPrivateAddress) {
+					await send();
+					const calls = esm_default.callHistory.calls(privateInbox);
+					assertEquals(calls.length, 1);
+					const request = calls[0].request;
+					const preservesBody = signed || status === 307 || status === 308;
+					assertEquals(request.method, preservesBody ? "POST" : "GET");
+					assertEquals(await request.clone().text(), preservesBody ? JSON.stringify(activity) : "");
+				} else {
+					await assertRejects(send, UrlError);
+					assertEquals(esm_default.callHistory.calls(privateInbox).length, 0);
+				}
+			} finally {
+				esm_default.hardReset();
+			}
+		});
+		await t.step("rejects a private destination after a public redirect", async () => {
+			esm_default.mockGlobal().route(publicInbox, {
+				status: 307,
+				headers: { Location: "/next" }
+			}).route("https://8.8.8.8/next", {
+				status: 308,
+				headers: { Location: privateInbox }
+			}).route(privateInbox, 202);
+			try {
+				await assertRejects(() => sendActivity({
+					activity,
+					keys,
+					inbox: new URL(publicInbox)
+				}), UrlError);
+				assertEquals(esm_default.callHistory.calls(privateInbox).length, 0);
+			} finally {
+				esm_default.hardReset();
+			}
+		});
+		await t.step("limits redirect loops", async () => {
+			esm_default.mockGlobal().route(publicInbox, {
+				status: 307,
+				headers: { Location: publicInbox }
+			});
+			try {
+				await assertRejects(() => sendActivity({
+					activity,
+					keys,
+					inbox: new URL(publicInbox)
+				}));
+				assert(esm_default.callHistory.calls().length <= 21);
+			} finally {
+				esm_default.hardReset();
+			}
+		});
+		await t.step("allows a direct private inbox with opt-in", async () => {
+			esm_default.mockGlobal().route(privateInbox, 202);
+			try {
+				await sendActivity({
+					activity,
+					keys,
+					inbox: new URL(privateInbox),
+					allowPrivateAddress: true
+				});
+				assertEquals(esm_default.callHistory.calls(privateInbox).length, 1);
+			} finally {
+				esm_default.hardReset();
+			}
+		});
+		await t.step("allows relative public redirects", async () => {
+			esm_default.mockGlobal().route(publicInbox, {
+				status: 307,
+				headers: { Location: "/next" }
+			}).route("https://8.8.8.8/next", 202);
+			try {
+				await sendActivity({
+					activity,
+					keys,
+					inbox: new URL(publicInbox)
+				});
+				assertEquals(esm_default.callHistory.calls("https://8.8.8.8/next").length, 1);
+			} finally {
+				esm_default.hardReset();
+			}
+		});
+	});
+}
+for (const signed of [false, true]) test({
+	name: `sendActivity() classifies DNS failures (signed: ${signed})`,
+	ignore: "Deno" in globalThis && (await Deno.permissions.query({ name: "net" })).state !== "granted",
+	async fn(t) {
+		const activity = {
+			type: "Create",
+			id: "https://example.com/activity"
+		};
+		const destination = "https://delivery.invalid/inbox";
+		const publicInbox = "https://8.8.8.8/inbox";
+		const keys = signed ? [{
+			privateKey: rsaPrivateKey2,
+			keyId: rsaPublicKey2.id
+		}] : [];
+		for (const result of [
+			"throws",
+			"empty",
+			"cname",
+			"private"
+		]) for (const redirected of [false, true]) await t.step(`${result}, redirected: ${redirected}`, async () => {
+			const originalLookup = dns.lookup;
+			const resolverError = /* @__PURE__ */ new Error("Resolver unavailable");
+			const lookups = [];
+			dns.lookup = ((hostname, options) => {
+				lookups.push(hostname);
+				assertEquals(hostname, "delivery.invalid");
+				assertEquals(options, { all: true });
+				if (result === "throws") return Promise.reject(resolverError);
+				return Promise.resolve(result === "empty" ? [] : [{
+					address: result === "private" ? "127.0.0.1" : "alias.invalid.",
+					family: 4
+				}]);
+			});
+			try {
+				esm_default.mockGlobal().catch(202);
+				if (redirected) esm_default.route(publicInbox, {
+					status: 307,
+					headers: { Location: destination }
+				});
+				const send = () => sendActivity({
+					activity,
+					keys,
+					inbox: new URL(redirected ? publicInbox : destination)
+				});
+				if (result === "private") assertEquals((await assertRejects(send, UrlError)).reason, "disallowed");
+				else {
+					const error = await assertRejects(send, FetchError);
+					assertEquals(error.url.href, destination);
+					assertInstanceOf(error.cause, UrlError);
+					assertEquals(error.cause.reason, "dns");
+					assertEquals(error.cause.cause, result === "throws" ? resolverError : void 0);
+				}
+				assertEquals(lookups, ["delivery.invalid"]);
+				assertEquals(esm_default.callHistory.calls(destination).length, 0);
+				assertEquals(esm_default.callHistory.calls().length, redirected ? 1 : 0);
+			} finally {
+				dns.lookup = originalLookup;
+				esm_default.hardReset();
+			}
+		});
+	}
+});
 //#endregion
 export {};

package/dist/federation/temporal.test.mjs

@@ -1,10 +1,10 @@
 import "@js-temporal/polyfill";
 import "urlpattern-polyfill";
 globalThis.addEventListener = () => {};
-import "../std__assert-Duiq_YC9.mjs";
+import "../std__assert-BUOJXi-Z.mjs";
 import { n as assertFalse } from "../assert_rejects-B-qJtC9Z.mjs";
-import { t as assert } from "../assert-ddO5KLpe.mjs";
-import { t as hasMalformedKnownTemporalLiteral } from "../temporal-G_GDghC-.mjs";
+import { t as assert } from "../assert-BhQd8QHP.mjs";
+import { t as hasMalformedKnownTemporalLiteral } from "../temporal-BanFifxu.mjs";
 import { test } from "@fedify/fixture";
 //#region src/federation/temporal.test.ts
 test("hasMalformedKnownTemporalLiteral() detects expanded proof timestamps", async () => {

package/dist/federation/webfinger.test.mjs

@@ -3,9 +3,9 @@ import "urlpattern-polyfill";
 globalThis.addEventListener = () => {};
 import { n as createRequestContext } from "../context-Juj6bdHC.mjs";
 import { t as assertEquals } from "../assert_equals-Ew3jOFa3.mjs";
-import "../std__assert-Duiq_YC9.mjs";
-import { t as MemoryKvStore } from "../kv-tL2TOE9X.mjs";
-import { a as createFederation, o as handleWebFinger } from "../middleware-D2O8b03q.mjs";
+import "../std__assert-BUOJXi-Z.mjs";
+import { t as MemoryKvStore } from "../kv-BrZHNugx.mjs";
+import { a as createFederation, o as handleWebFinger } from "../middleware-DHHRwSZH.mjs";
 import { test } from "@fedify/fixture";
 import { Image, Link, Person } from "@fedify/vocab";
 //#region src/federation/webfinger.test.ts

package/dist/{http-DIh9_s_-.mjs → http-B5qAeoJd.mjs}

@@ -1,9 +1,9 @@
 import { Temporal } from "@js-temporal/polyfill";
 import "urlpattern-polyfill";
 globalThis.addEventListener = () => {};
-import { n as version, t as name } from "./deno-B_Gwkjh7.mjs";
-import { i as validateAcceptSignature, n as fulfillAcceptSignature, r as parseAcceptSignature } from "./accept-Dd__NiUL.mjs";
-import { o as validateCryptoKey, r as fetchKeyDetailed } from "./key-DywPPmb0.mjs";
+import { n as version, t as name } from "./deno-9AaebKOA.mjs";
+import { i as validateAcceptSignature, n as fulfillAcceptSignature, r as parseAcceptSignature } from "./accept-BavzedPB.mjs";
+import { i as fetchKeyDetailed, s as validateCryptoKey } from "./key-x9f-H7eO.mjs";
 import { CryptographicKey } from "@fedify/vocab";
 import { SpanStatusCode, trace } from "@opentelemetry/api";
 import { FetchError } from "@fedify/vocab-runtime";
@@ -674,6 +674,8 @@ async function verifyRequestRfc9421(request, span, { documentLoader, contextLoad
 		return invalidSignatureResult(null);
 	}
 	let failure = noSignatureResult();
+	let body = null;
+	let digestValid = null;
 	for (const sigName of signatureNames) {
 		if (!signatures[sigName]) {
 			failure = invalidSignatureResult(parseKeyId(signatureInputs[sigName]?.keyId));
@@ -725,7 +727,9 @@ async function verifyRequestRfc9421(request, span, { documentLoader, contextLoad
 				failure = invalidSignatureResult(keyId);
 				continue;
 			}
-			if (!await verifyRfc9421ContentDigest(contentDigestHeader, await request.arrayBuffer())) {
+			body ??= await request.arrayBuffer();
+			digestValid ??= await verifyRfc9421ContentDigest(contentDigestHeader, body);
+			if (!digestValid) {
 				logger.debug("Failed to verify; Content-Digest verification failed.", { contentDigest: contentDigestHeader });
 				failure = invalidSignatureResult(keyId);
 				continue;

package/dist/{http-Yoq0YGz7.cjs → http-BJEMpnnY.cjs}

@@ -5,13 +5,13 @@ let _logtape_logtape = require("@logtape/logtape");
 let _fedify_vocab = require("@fedify/vocab");
 let _opentelemetry_api = require("@opentelemetry/api");
 let byte_encodings_hex = require("byte-encodings/hex");
-let structured_field_values = require("structured-field-values");
 let _fedify_vocab_runtime = require("@fedify/vocab-runtime");
+let structured_field_values = require("structured-field-values");
 let _opentelemetry_semantic_conventions = require("@opentelemetry/semantic-conventions");
 let byte_encodings_base64 = require("byte-encodings/base64");
 //#region deno.json
 var name = "@fedify/fedify";
-var version = "2.1.23";
+var version = "2.1.25";
 //#endregion
 //#region src/sig/accept.ts
 /**
@@ -231,6 +231,118 @@ async function importJwk(jwk, type) {
 	validateCryptoKey(key, type);
 	return key;
 }
+/**
+* Fetches the document that the given actor URI dereferences to, and returns
+* the actor only if the host that served the document is authoritative for
+* the id the document claims.
+*
+* Only the origin that serves an actor id can speak for it.  Without that
+* rule any host could serve a document describing somebody else's actor—and
+* listing its own keys as that actor's.
+*
+* @param actorId The URI of the actor to fetch.
+* @param options Options for fetching the document.
+* @returns The actor, or `null` if the document cannot be fetched, is not an
+*          actor, or belongs to another origin.
+* @internal
+*/
+async function fetchActorDocument(actorId, options = {}) {
+	const logger = (0, _logtape_logtape.getLogger)([
+		"fedify",
+		"sig",
+		"key"
+	]);
+	const documentLoader = options.documentLoader ?? (0, _fedify_vocab_runtime.getDocumentLoader)();
+	const contextLoader = options.contextLoader ?? (0, _fedify_vocab_runtime.getDocumentLoader)();
+	const { tracerProvider } = options;
+	let document;
+	let documentUrl = actorId;
+	try {
+		const remoteDocument = await documentLoader(actorId.href);
+		document = remoteDocument.document;
+		documentUrl = new URL(remoteDocument.documentUrl ?? "", actorId);
+	} catch (error) {
+		logger.debug("Failed to fetch the actor {actorId}: {error}", {
+			actorId: actorId.href,
+			error
+		});
+		return null;
+	}
+	let object;
+	try {
+		object = await _fedify_vocab.Object.fromJsonLd(document, {
+			documentLoader,
+			contextLoader,
+			tracerProvider,
+			baseUrl: documentUrl
+		});
+	} catch (error) {
+		if (!(error instanceof TypeError)) throw error;
+		logger.debug("The document served at {documentUrl} is not a valid object: {error}", {
+			documentUrl: documentUrl.href,
+			error
+		});
+		return null;
+	}
+	if (!(0, _fedify_vocab.isActor)(object)) return null;
+	if (object.id == null || object.id.origin !== documentUrl.origin) {
+		logger.debug("The document served at {documentUrl} claims to be the actor {actorId}, which belongs to another origin; refusing to treat it as that actor's document.", {
+			documentUrl: documentUrl.href,
+			actorId: object.id?.href
+		});
+		return null;
+	}
+	return object;
+}
+/**
+* Resolves the owner that the given key claims, and returns it only if the
+* claim holds.
+*
+* The `owner` of a {@link CryptographicKey}, like the `controller` of
+* a {@link Multikey}, proves nothing on its own: the key document and the
+* claim inside it are served by the same host, so anyone able to serve a key
+* document can name any actor in the world as its owner.  The claim becomes
+* meaningful only once the named actor's own document is fetched and turns
+* out to link back to the key.  This function performs that mutual-link
+* check, which is the only sound way to learn a fetched key's owner.
+*
+* The claimed owner is always dereferenced, never read out of the key
+* document: an owner embedded there is written by whoever wrote the key.
+*
+* @param key The key whose ownership claim is to be verified.  It must carry
+*            an `id`, as that is what the owner has to link back to.
+* @param options Options for fetching the claimed owner.
+* @returns The verified owner, or `null` if the key claims no owner, the
+*          owner cannot be fetched, or the owner does not link back to
+*          the key.
+* @internal
+*/
+async function verifyKeyOwnership(key, options = {}) {
+	const logger = (0, _logtape_logtape.getLogger)([
+		"fedify",
+		"sig",
+		"key"
+	]);
+	const keyId = key.id;
+	if (keyId == null) return null;
+	const claimedOwnerId = key instanceof _fedify_vocab.CryptographicKey ? key.ownerId : key.controllerId;
+	if (claimedOwnerId == null) return null;
+	const owner = await fetchActorDocument(claimedOwnerId, options);
+	if (owner == null) {
+		logger.debug("The owner ({claimedOwnerId}) that key {keyId} claims could not be resolved.", {
+			keyId: keyId.href,
+			claimedOwnerId: claimedOwnerId.href
+		});
+		return null;
+	}
+	const linkedKeyIds = key instanceof _fedify_vocab.CryptographicKey ? owner.publicKeyIds : owner.assertionMethodIds;
+	for (const linkedKeyId of linkedKeyIds) if (linkedKeyId.href === keyId.href) return owner;
+	logger.debug("The owner ({claimedOwnerId}) that key {keyId} claims does not list the key as its own.", {
+		keyId: keyId.href,
+		claimedOwnerId: claimedOwnerId.href
+	});
+	return null;
+}
 async function withFetchKeySpan(keyId, tracerProvider, fetcher) {
 	tracerProvider ??= _opentelemetry_api.trace.getTracerProvider();
 	return await tracerProvider.getTracer(name, version).startActiveSpan("activitypub.fetch_key", {
@@ -358,7 +470,7 @@ async function getCachedFetchKey(cacheKey, keyId, cls, keyCache, logger) {
 async function clearFetchErrorMetadata(keyId, keyCache) {
 	await keyCache?.setFetchError?.(keyId, null);
 }
-async function resolveFetchedKey(document, cacheKey, keyId, cls, { documentLoader, contextLoader, keyCache, tracerProvider }, logger) {
+async function resolveFetchedKey(document, cacheKey, documentUrl, keyId, cls, { documentLoader, contextLoader, keyCache, tracerProvider }, logger) {
 	let object;
 	try {
 		object = await _fedify_vocab.Object.fromJsonLd(document, {
@@ -388,8 +500,22 @@ async function resolveFetchedKey(document, cacheKey, keyId, cls, { documentLoade
 		}
 	}
 	let key = null;
-	if (object instanceof cls && (object.id == null || object.id.href === keyId)) key = object;
+	let ownerDocument = null;
+	if (object instanceof cls && (object.id == null || object.id.href === keyId)) key = object.id == null ? object.clone({ id: cacheKey }) : object;
 	else if ((0, _fedify_vocab.isActor)(object)) {
+		if (object.id == null || object.id.origin !== documentUrl.origin) {
+			logger.debug("Failed to verify; the document served at {documentUrl} claims to be the actor {actorId}, which belongs to another origin.", {
+				keyId,
+				documentUrl: documentUrl.href,
+				actorId: object.id?.href
+			});
+			await keyCache?.set(cacheKey, null);
+			return {
+				key: null,
+				cached: false
+			};
+		}
+		ownerDocument = object;
 		const keys = cls === _fedify_vocab.CryptographicKey ? object.getPublicKeys({
 			documentLoader,
 			contextLoader,
@@ -451,6 +577,25 @@ async function resolveFetchedKey(document, cacheKey, keyId, cls, { documentLoade
 			cached: false
 		};
 	}
+	const claimedOwnerId = key instanceof _fedify_vocab.CryptographicKey ? key.ownerId : key.controllerId;
+	if (ownerDocument != null && claimedOwnerId == null) key = key instanceof _fedify_vocab.CryptographicKey ? key.clone({ owner: ownerDocument.id }) : key.clone({ controller: ownerDocument.id });
+	else if (claimedOwnerId != null && claimedOwnerId.href !== ownerDocument?.id?.href) {
+		if (await verifyKeyOwnership(key, {
+			documentLoader,
+			contextLoader,
+			tracerProvider
+		}) == null) {
+			logger.debug("Failed to verify; the owner {claimedOwnerId} that key {keyId} claims does not list the key as its own.", {
+				keyId,
+				claimedOwnerId: claimedOwnerId.href
+			});
+			await keyCache?.set(cacheKey, null);
+			return {
+				key: null,
+				cached: false
+			};
+		}
+	}
 	if (keyCache != null) {
 		await keyCache.set(cacheKey, key);
 		logger.debug("Key {keyId} cached.", { keyId });
@@ -474,12 +619,15 @@ async function fetchKeyWithResult(cacheKey, cls, options, onCachedUnavailable, o
 	if (cached != null) return cached;
 	logger.debug("Fetching key {keyId} to verify signature...", { keyId });
 	let document;
+	let documentUrl = cacheKey;
 	try {
-		document = (await (options.documentLoader ?? (0, _fedify_vocab_runtime.getDocumentLoader)())(keyId)).document;
+		const remoteDocument = await (options.documentLoader ?? (0, _fedify_vocab_runtime.getDocumentLoader)())(keyId);
+		document = remoteDocument.document;
+		documentUrl = new URL(remoteDocument.documentUrl ?? "", cacheKey);
 	} catch (error) {
 		return await onFetchError(error, cacheKey, keyId, keyCache, logger);
 	}
-	return await resolveFetchedKey(document, cacheKey, keyId, cls, options, logger);
+	return await resolveFetchedKey(document, cacheKey, documentUrl, keyId, cls, options, logger);
 }
 async function fetchKeyInternal(keyId, cls, options = {}) {
 	return await fetchKeyWithResult(typeof keyId === "string" ? new URL(keyId) : keyId, cls, options, (_cacheKey, _keyId, _keyCache, _logger) => {
@@ -1167,6 +1315,8 @@ async function verifyRequestRfc9421(request, span, { documentLoader, contextLoad
 		return invalidSignatureResult(null);
 	}
 	let failure = noSignatureResult();
+	let body = null;
+	let digestValid = null;
 	for (const sigName of signatureNames) {
 		if (!signatures[sigName]) {
 			failure = invalidSignatureResult(parseKeyId(signatureInputs[sigName]?.keyId));
@@ -1218,7 +1368,9 @@ async function verifyRequestRfc9421(request, span, { documentLoader, contextLoad
 				failure = invalidSignatureResult(keyId);
 				continue;
 			}
-			if (!await verifyRfc9421ContentDigest(contentDigestHeader, await request.arrayBuffer())) {
+			body ??= await request.arrayBuffer();
+			digestValid ??= await verifyRfc9421ContentDigest(contentDigestHeader, body);
+			if (!digestValid) {
 				logger.debug("Failed to verify; Content-Digest verification failed.", { contentDigest: contentDigestHeader });
 				failure = invalidSignatureResult(keyId);
 				continue;
@@ -1544,6 +1696,12 @@ Object.defineProperty(exports, "exportJwk", {
 		return exportJwk;
 	}
 });
+Object.defineProperty(exports, "fetchActorDocument", {
+	enumerable: true,
+	get: function() {
+		return fetchActorDocument;
+	}
+});
 Object.defineProperty(exports, "fetchKey", {
 	enumerable: true,
 	get: function() {
@@ -1616,6 +1774,12 @@ Object.defineProperty(exports, "validateCryptoKey", {
 		return validateCryptoKey;
 	}
 });
+Object.defineProperty(exports, "verifyKeyOwnership", {
+	enumerable: true,
+	get: function() {
+		return verifyKeyOwnership;
+	}
+});
 Object.defineProperty(exports, "verifyRequest", {
 	enumerable: true,
 	get: function() {