@fedify/fedify 1.3.14 → 1.3.16

package/CHANGES.md

@@ -3,6 +3,32 @@
 Fedify changelog
 ================
 
+Version 1.3.16
+--------------
+
+Released on March 26, 2025.
+
+ -  Fixed a `TypeError` thrown by the followers collection dispatcher when
+    the `base-url` parameter was provided.
+
+ -  Fixed a `TypeError` thrown by the `signRequest()` function on Node.js.
+    [[#222]]
+
+
+Version 1.3.15
+--------------
+
+Released on March 26, 2025.
+
+ -  Fixed a bug where the `totalItems` property of `OrderedCollection`
+    objects returned by followers collection dispatcher had been an incorrect
+    value if a `base-url` parameter was provided.
+
+ -  Fixed a bug where the `id` property of `OrderedCollection` and
+    `OrderedCollectionPage` objects returned by followers collection dispatcher
+    had been an incorrect value if a `base-url` parameter was provided.
+
+
 Version 1.3.14
 --------------
 
@@ -295,6 +321,31 @@ Released on November 30, 2024.
 [#193]: https://github.com/fedify-dev/fedify/issues/193
 
 
+Version 1.2.20
+--------------
+
+Released on March 26, 2025.
+
+ -  Fixed a `TypeError` thrown by the followers collection dispatcher when
+    the `base-url` parameter was provided.
+ -  Fixed a `TypeError` thrown by the `signRequest()` function on Node.js.
+    [[#222]]
+
+
+Version 1.2.19
+--------------
+
+Released on March 26, 2025.
+
+ -  Fixed a bug where the `totalItems` property of `OrderedCollection`
+    objects returned by followers collection dispatcher had been an incorrect
+    value if a `base-url` parameter was provided.
+
+ -  Fixed a bug where the `id` property of `OrderedCollection` and
+    `OrderedCollectionPage` objects returned by followers collection dispatcher
+    had been an incorrect value if a `base-url` parameter was provided.
+
+
 Version 1.2.18
 --------------
 
@@ -636,6 +687,31 @@ Released on October 31, 2024.
 [#118]: https://github.com/fedify-dev/fedify/issues/118
 
 
+Version 1.1.20
+--------------
+
+Released on March 26, 2025.
+
+ -  Fixed a `TypeError` thrown by the followers collection dispatcher when
+    the `base-url` parameter was provided.
+ -  Fixed a `TypeError` thrown by the `signRequest()` function on Node.js.
+    [[#222]]
+
+
+Version 1.1.19
+--------------
+
+Released on March 26, 2025.
+
+ -  Fixed a bug where the `totalItems` property of `OrderedCollection`
+    objects returned by followers collection dispatcher had been an incorrect
+    value if a `base-url` parameter was provided.
+
+ -  Fixed a bug where the `id` property of `OrderedCollection` and
+    `OrderedCollectionPage` objects returned by followers collection dispatcher
+    had been an incorrect value if a `base-url` parameter was provided.
+
+
 Version 1.1.18
 --------------
 
@@ -1018,6 +1094,33 @@ Released on October 20, 2024.
 [#150]: https://github.com/fedify-dev/fedify/issues/150
 
 
+Version 1.0.23
+--------------
+
+Released on March 26, 2025.
+
+ -  Fixed a `TypeError` thrown by the followers collection dispatcher when
+    the `base-url` parameter was provided.
+ -  Fixed a `TypeError` thrown by the `signRequest()` function on Node.js.
+    [[#222]]
+
+[#222]: https://github.com/fedify-dev/fedify/issues/222
+
+
+Version 1.0.22
+--------------
+
+Released on March 26, 2025.
+
+ -  Fixed a bug where the `totalItems` property of `OrderedCollection`
+    objects returned by followers collection dispatcher had been an incorrect
+    value if a `base-url` parameter was provided.
+
+ -  Fixed a bug where the `id` property of `OrderedCollection` and
+    `OrderedCollectionPage` objects returned by followers collection dispatcher
+    had been an incorrect value if a `base-url` parameter was provided.
+
+
 Version 1.0.21
 --------------
 

package/esm/deno.js

@@ -1,6 +1,6 @@
 export default {
     "name": "@fedify/fedify",
-    "version": "1.3.14",
+    "version": "1.3.16",
     "license": "MIT",
     "exports": {
         ".": "./mod.ts",
@@ -40,7 +40,7 @@ export default {
         "@std/async": "jsr:@std/async@^1.0.5",
         "@std/bytes": "jsr:@std/bytes@^1.0.2",
         "@std/collections": "jsr:@std/collections@^1.0.6",
-        "@std/encoding": "jsr:@std/encoding@^1.0.5",
+        "@std/encoding": "jsr:@std/encoding@1.0.7",
         "@std/fs": "jsr:@std/fs@^1.0.3",
         "@std/http": "jsr:@std/http@^1.0.6",
         "@std/path": "jsr:@std/path@^1.0.6",

package/esm/federation/collection.js

@@ -3,7 +3,7 @@ import { encodeHex } from "../deps/jsr.io/@std/encoding/1.0.7/hex.js";
 /**
  * Calculates the [partial follower collection digest][1].
  *
- * [1]: https://codeberg.org/fediverse/fep/src/branch/main/fep/8fcf/fep-8fcf.md#partial-follower-collection-digest
+ * [1]: https://w3id.org/fep/8fcf#partial-follower-collection-digest
  * @param uris The URIs to calculate the digest.  Duplicate URIs are ignored.
  * @returns The digest.
  */
@@ -27,7 +27,7 @@ export async function digest(uris) {
 /**
  * Builds [`Collection-Synchronization`][1] header content.
  *
- * [1]: https://codeberg.org/fediverse/fep/src/branch/main/fep/8fcf/fep-8fcf.md#the-collection-synchronization-http-header
+ * [1]: https://w3id.org/fep/8fcf#the-collection-synchronization-http-header
  *
  * @param collectionId The sender's followers collection URI.
  * @param actorIds The actor URIs to digest.

package/esm/federation/handler.js

@@ -84,7 +84,9 @@ export async function handleCollection(request, { name, identifier, uriGetter, f
     const baseUri = uriGetter(identifier);
     if (cursor == null) {
         const firstCursor = await collectionCallbacks.firstCursor?.(context, identifier);
-        const totalItems = await collectionCallbacks.counter?.(context, identifier);
+        const totalItems = filter == null
+            ? await collectionCallbacks.counter?.(context, identifier)
+            : undefined;
         if (firstCursor == null) {
             const itemsOrResponse = await tracer.startActiveSpan(`activitypub.dispatch_collection ${spanName}`, {
                 kind: SpanKind.SERVER,
@@ -133,7 +135,7 @@ export async function handleCollection(request, { name, identifier, uriGetter, f
             }
             collection = new OrderedCollection({
                 id: baseUri,
-                totalItems: Number(totalItems),
+                totalItems: totalItems == null ? null : Number(totalItems),
                 first,
                 last,
             });
@@ -223,7 +225,8 @@ function filterCollectionItems(items, collectionName, filterPredicate) {
             if (!logged) {
                 getLogger(["fedify", "federation", "collection"]).warn(`The ${collectionName} collection apparently does not implement ` +
                     "filtering.  This may result in a large response payload.  " +
-                    "Please consider implementing filtering for the collection.");
+                    "Please consider implementing filtering for the collection.  " +
+                    "See also: https://fedify.dev/manual/collections#filtering-by-server");
                 logged = true;
             }
             continue;

package/esm/federation/middleware.js

@@ -1393,7 +1393,13 @@ export class FederationImpl {
                 return await handleCollection(request, {
                     name: "followers",
                     identifier: route.values.identifier ?? route.values.handle,
-                    uriGetter: context.getFollowersUri.bind(context),
+                    uriGetter: baseUrl == null
+                        ? context.getFollowersUri.bind(context)
+                        : (identifier) => {
+                            const uri = context.getFollowersUri(identifier);
+                            uri.searchParams.set("base-url", baseUrl);
+                            return uri;
+                        },
                     context,
                     filter: baseUrl != null ? new URL(baseUrl) : undefined,
                     filterPredicate: baseUrl != null
@@ -1949,6 +1955,12 @@ export class ContextImpl {
             throw new Error("No first cursor dispatcher registered for followers collection.");
         }
         let cursor = await this.federation.followersCallbacks.firstCursor(this, identifier);
+        if (cursor != null) {
+            getLogger(["fedify", "federation", "outbox"]).warn("Since the followers collection dispatcher returned null for no " +
+                "cursor (i.e., one-shot dispatcher), the pagination is used to fetch " +
+                '"followers".  However, it is recommended to implement the one-shot ' +
+                "dispatcher for better performance.", { identifier });
+        }
         while (cursor != null) {
             const result = await this.federation.followersCallbacks.dispatcher(this, identifier, cursor);
             if (result == null)

package/esm/vocab/lookup.js

@@ -1,7 +1,7 @@
 import * as dntShim from "../_dnt.shims.js";
 import { getLogger } from "@logtape/logtape";
 import { SpanStatusCode, trace } from "@opentelemetry/api";
-import { delay } from "../deps/jsr.io/@std/async/1.0.11/delay.js";
+import { delay } from "../deps/jsr.io/@std/async/1.0.12/delay.js";
 import metadata from "../deno.js";
 import { getDocumentLoader, } from "../runtime/docloader.js";
 import { lookupWebFinger } from "../webfinger/lookup.js";