@fedify/botkit 0.4.0-dev.181 → 0.4.0-dev.183

package/dist/bot-impl.test.js

@@ -5,10 +5,9 @@
 import { MemoryRepository } from "./repository.js";
 import { SessionImpl } from "./session-impl.js";
 import { BotImpl } from "./bot-impl.js";
-import { parseSemVer } from "./bot.js";
 import { mention, strong, text } from "./text.js";
 import { MemoryKvStore } from "@fedify/fedify/federation";
-import { Accept, Announce, Article, Collection, Create, CryptographicKey, Emoji, EmojiReact, Follow, Image, Like, Mention, Note, PUBLIC_COLLECTION, Person, Place, PropertyValue, Question, Reject, Service, Undo, Update } from "@fedify/fedify/vocab";
+import { Accept, Announce, Article, Collection, Create, Emoji, EmojiReact, Follow, Image, Like, Mention, Note, PUBLIC_COLLECTION, Person, Place, PropertyValue, Question, Reject, Service, Undo, Update } from "@fedify/vocab";
 import assert from "node:assert";
 import { describe, test } from "node:test";
 
@@ -504,10 +503,21 @@ test("BotImpl.authorizeFollow()", async () => {
 		object: new URL("https://example.com/ap/actor/john"),
 		to: new URL("https://example.com/ap/actor/john")
 	}));
-	assert.ok(await bot.authorizeFollow(ctx, { id: "b51f6ca8-53e6-4f7d-ac1f-d039e8c6df5a" }, new CryptographicKey({}), new Person({ id: new URL("https://example.com/ap/actor/john") })));
-	assert.ok(await bot.authorizeFollow(ctx, { id: "b51f6ca8-53e6-4f7d-ac1f-d039e8c6df5a" }, new CryptographicKey({}), await new SessionImpl(bot, ctx).getActor()));
-	assert.deepStrictEqual(await bot.authorizeFollow(ctx, { id: "b51f6ca8-53e6-4f7d-ac1f-d039e8c6df5a" }, new CryptographicKey({}), new Person({ id: new URL("https://example.com/ap/actor/alice") })), false);
-	assert.deepStrictEqual(await bot.authorizeFollow(ctx, { id: crypto.randomUUID() }, new CryptographicKey({}), new Person({ id: new URL("https://example.com/ap/actor/john") })), false);
+	const setSignedKeyOwner = (owner) => {
+		Object.defineProperty(ctx, "getSignedKeyOwner", {
+			value: () => Promise.resolve(owner),
+			writable: true,
+			configurable: true
+		});
+	};
+	setSignedKeyOwner(new Person({ id: new URL("https://example.com/ap/actor/john") }));
+	assert.ok(await bot.authorizeFollow(ctx, { id: "b51f6ca8-53e6-4f7d-ac1f-d039e8c6df5a" }));
+	setSignedKeyOwner(await new SessionImpl(bot, ctx).getActor());
+	assert.ok(await bot.authorizeFollow(ctx, { id: "b51f6ca8-53e6-4f7d-ac1f-d039e8c6df5a" }));
+	setSignedKeyOwner(new Person({ id: new URL("https://example.com/ap/actor/alice") }));
+	assert.deepStrictEqual(await bot.authorizeFollow(ctx, { id: "b51f6ca8-53e6-4f7d-ac1f-d039e8c6df5a" }), false);
+	setSignedKeyOwner(new Person({ id: new URL("https://example.com/ap/actor/john") }));
+	assert.deepStrictEqual(await bot.authorizeFollow(ctx, { id: crypto.randomUUID() }), false);
 });
 test("BotImpl.dispatchCreate()", async () => {
 	const repository = new MemoryRepository();
@@ -1460,7 +1470,7 @@ test("BotImpl.dispatchNodeInfo()", () => {
 		username: "bot",
 		software: {
 			name: "test",
-			version: parseSemVer("1.2.3"),
+			version: "1.2.3",
 			homepage: new URL("https://example.com/"),
 			repository: new URL("https://git.example.com/")
 		}
@@ -1469,7 +1479,7 @@ test("BotImpl.dispatchNodeInfo()", () => {
 	assert.deepStrictEqual(bot.dispatchNodeInfo(ctx), {
 		software: {
 			name: "test",
-			version: parseSemVer("1.2.3"),
+			version: "1.2.3",
 			homepage: new URL("https://example.com/"),
 			repository: new URL("https://git.example.com/")
 		},
@@ -1505,6 +1515,72 @@ test("BotImpl.fetch()", async () => {
 	const response2 = await botBehindProxy.fetch(request);
 	assert.deepStrictEqual(response2.status, 200);
 });
+test("BotImpl.fetch() includes FEP-5711 inverse properties", async () => {
+	const repository = new MemoryRepository();
+	const bot = new BotImpl({
+		kv: new MemoryKvStore(),
+		repository,
+		username: "bot",
+		collectionWindow: 1
+	});
+	const actorId = new URL("https://example.com/ap/actor/bot");
+	await repository.addFollower(new URL("https://example.com/actor/1#follow"), new Person({
+		id: new URL("https://example.com/actor/1"),
+		preferredUsername: "john",
+		inbox: new URL("https://example.com/actor/1/inbox")
+	}));
+	await repository.addMessage("78acb1ea-4ac6-46b7-bcd4-3a8965d8126e", new Create({
+		id: new URL("https://example.com/ap/actor/bot/create/78acb1ea-4ac6-46b7-bcd4-3a8965d8126e"),
+		actor: actorId,
+		to: PUBLIC_COLLECTION,
+		cc: new URL("https://example.com/ap/actor/bot/followers"),
+		object: new Note({
+			id: new URL("https://example.com/ap/actor/bot/note/1"),
+			attribution: actorId,
+			to: PUBLIC_COLLECTION,
+			cc: new URL("https://example.com/ap/actor/bot/followers"),
+			content: "Hello, world!",
+			published: Temporal.Instant.from("2025-01-01T00:00:00Z")
+		}),
+		published: Temporal.Instant.from("2025-01-01T00:00:00Z")
+	}));
+	const actorResponse = await bot.fetch(new Request("https://example.com/ap/actor/bot", { headers: { accept: "application/activity+json" } }));
+	assert.deepStrictEqual(actorResponse.status, 200);
+	const actorJson = await actorResponse.json();
+	assert.deepStrictEqual(actorJson.id, actorId.href);
+	assert.deepStrictEqual(actorJson.followers, "https://example.com/ap/actor/bot/followers");
+	assert.deepStrictEqual(actorJson.outbox, "https://example.com/ap/actor/bot/outbox");
+	const outboxResponse = await bot.fetch(new Request("https://example.com/ap/actor/bot/outbox", { headers: { accept: "application/activity+json" } }));
+	assert.deepStrictEqual(outboxResponse.status, 200);
+	const outboxJson = await outboxResponse.json();
+	assert.deepStrictEqual(outboxJson.type, "OrderedCollection");
+	assert.deepStrictEqual(outboxJson.id, "https://example.com/ap/actor/bot/outbox");
+	assert.deepStrictEqual(outboxJson.totalItems, 1);
+	assert.deepStrictEqual(outboxJson.first, "https://example.com/ap/actor/bot/outbox?cursor=");
+	assert.deepStrictEqual(outboxJson.outboxOf, actorId.href);
+	const outboxPageResponse = await bot.fetch(new Request("https://example.com/ap/actor/bot/outbox?cursor=", { headers: { accept: "application/activity+json" } }));
+	assert.deepStrictEqual(outboxPageResponse.status, 200);
+	const outboxPageJson = await outboxPageResponse.json();
+	assert.deepStrictEqual(outboxPageJson.type, "OrderedCollectionPage");
+	assert.deepStrictEqual(outboxPageJson.id, "https://example.com/ap/actor/bot/outbox?cursor=");
+	assert.deepStrictEqual(outboxPageJson.partOf, "https://example.com/ap/actor/bot/outbox");
+	assert.deepStrictEqual(outboxPageJson.outboxOf, actorId.href);
+	const followersResponse = await bot.fetch(new Request("https://example.com/ap/actor/bot/followers", { headers: { accept: "application/activity+json" } }));
+	assert.deepStrictEqual(followersResponse.status, 200);
+	const followersJson = await followersResponse.json();
+	assert.deepStrictEqual(followersJson.type, "OrderedCollection");
+	assert.deepStrictEqual(followersJson.id, "https://example.com/ap/actor/bot/followers");
+	assert.deepStrictEqual(followersJson.totalItems, 1);
+	assert.deepStrictEqual(followersJson.first, "https://example.com/ap/actor/bot/followers?cursor=0");
+	assert.deepStrictEqual(followersJson.followersOf, actorId.href);
+	const followersPageResponse = await bot.fetch(new Request("https://example.com/ap/actor/bot/followers?cursor=0", { headers: { accept: "application/activity+json" } }));
+	assert.deepStrictEqual(followersPageResponse.status, 200);
+	const followersPageJson = await followersPageResponse.json();
+	assert.deepStrictEqual(followersPageJson.type, "OrderedCollectionPage");
+	assert.deepStrictEqual(followersPageJson.id, "https://example.com/ap/actor/bot/followers?cursor=0");
+	assert.deepStrictEqual(followersPageJson.partOf, "https://example.com/ap/actor/bot/followers");
+	assert.deepStrictEqual(followersPageJson.followersOf, actorId.href);
+});
 describe("BotImpl.addCustomEmoji(), BotImpl.addCustomEmojis()", () => {
 	const bot = new BotImpl({
 		kv: new MemoryKvStore(),
@@ -1619,7 +1695,11 @@ test("BotImpl.getFollowersFirstCursor()", () => {
 });
 function createMockInboxContext(bot, origin, recipient) {
 	const ctx = bot.federation.createContext(new URL(origin), void 0);
-	ctx.recipient = recipient ?? null;
+	Object.defineProperty(ctx, "recipient", {
+		value: recipient ?? null,
+		writable: true,
+		configurable: true
+	});
 	ctx.sentActivities = [];
 	ctx.sendActivity = (_, recipients, activity) => {
 		ctx.sentActivities.push({