@featurevisor/core 2.26.1 → 3.0.1

package/src/builder/{buildScopedConditions.spec.ts → applyContextToConditions.spec.ts}

@@ -1,13 +1,13 @@
 import type { Condition, DatafileContent } from "@featurevisor/types";
 
 import {
-  buildScopedCondition,
+  applyContextToCondition,
   removeRedundantConditions,
-  buildScopedConditions,
-} from "./buildScopedConditions";
-import { DatafileReader, createLogger } from "@featurevisor/sdk";
+  applyContextToConditions,
+} from "./applyContextToConditions";
+import { createFeaturevisor } from "@featurevisor/sdk";
 
-describe("core: buildScopedConditions", function () {
+describe("core: applyContextToConditions", function () {
   const emptyDatafile: DatafileContent = {
     schemaVersion: "2",
     revision: "unknown",
@@ -15,24 +15,24 @@ describe("core: buildScopedConditions", function () {
     features: {},
   };
 
-  const datafileReader = new DatafileReader({
+  const featurevisor = createFeaturevisor({
     datafile: emptyDatafile,
-    logger: createLogger({ level: "fatal" }),
+    logLevel: "fatal",
   });
 
-  describe("buildScopedConditions (plural)", function () {
-    test("buildScopedConditions is a function", function () {
-      expect(buildScopedConditions).toBeInstanceOf(Function);
+  describe("applyContextToConditions (plural)", function () {
+    test("applyContextToConditions is a function", function () {
+      expect(applyContextToConditions).toBeInstanceOf(Function);
     });
 
     test("simple cases", function () {
       // "*" remains "*"
-      expect(buildScopedConditions(datafileReader, "*", {})).toEqual("*");
+      expect(applyContextToConditions(featurevisor, "*", {})).toEqual("*");
 
       // Plain condition that matches
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             attribute: "platform",
             operator: "equals",
@@ -46,8 +46,8 @@ describe("core: buildScopedConditions", function () {
 
       // Plain condition that doesn't match
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             attribute: "platform",
             operator: "equals",
@@ -65,8 +65,8 @@ describe("core: buildScopedConditions", function () {
 
       // Array of conditions - partial match (redundant "*" removed)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           [
             {
               attribute: "platform",
@@ -93,8 +93,8 @@ describe("core: buildScopedConditions", function () {
 
       // Array of conditions - full match (all "*" becomes "*")
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           [
             {
               attribute: "platform",
@@ -116,8 +116,8 @@ describe("core: buildScopedConditions", function () {
 
       // Array of conditions - no match
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           [
             {
               attribute: "platform",
@@ -152,8 +152,8 @@ describe("core: buildScopedConditions", function () {
     test("AND conditions", function () {
       // AND with all matching conditions (all "*" becomes "*")
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               {
@@ -177,8 +177,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with partial match (redundant "*" removed)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               {
@@ -209,8 +209,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with no matches
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               {
@@ -247,8 +247,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with "*" in it (all "*" becomes "*")
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               "*",
@@ -271,8 +271,8 @@ describe("core: buildScopedConditions", function () {
       // Note: This would require both conditions to match, which isn't possible with same attribute
       // So testing with different attributes that both match
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             or: [
               {
@@ -296,8 +296,8 @@ describe("core: buildScopedConditions", function () {
 
       // OR with partial match (redundant "*" removed, but OR structure remains)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             or: [
               {
@@ -328,8 +328,8 @@ describe("core: buildScopedConditions", function () {
 
       // OR with no matches
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             or: [
               {
@@ -365,10 +365,10 @@ describe("core: buildScopedConditions", function () {
     });
 
     test("NOT conditions", function () {
-      // NOT with matching condition (all "*" becomes "*")
+      // NOT with matching condition remains an always-false expression
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             not: [
               {
@@ -382,12 +382,14 @@ describe("core: buildScopedConditions", function () {
             platform: "web",
           },
         ),
-      ).toEqual("*");
+      ).toEqual({
+        not: ["*"],
+      });
 
       // NOT with non-matching condition
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             not: [
               {
@@ -411,10 +413,10 @@ describe("core: buildScopedConditions", function () {
         ],
       });
 
-      // NOT with multiple conditions (all "*" becomes "*")
+      // NOT with multiple matching conditions remains an always-false expression
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             not: [
               {
@@ -434,14 +436,16 @@ describe("core: buildScopedConditions", function () {
             browser: "chrome",
           },
         ),
-      ).toEqual("*");
+      ).toEqual({
+        not: ["*"],
+      });
     });
 
     test("nested AND conditions", function () {
       // Nested AND with all matching (all "*" becomes "*")
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               {
@@ -475,8 +479,8 @@ describe("core: buildScopedConditions", function () {
 
       // Nested AND with partial match (redundant "*" removed)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               {
@@ -523,8 +527,8 @@ describe("core: buildScopedConditions", function () {
     test("nested OR conditions", function () {
       // Nested OR with outer match (redundant "*" removed, but inner OR remains)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             or: [
               {
@@ -573,8 +577,8 @@ describe("core: buildScopedConditions", function () {
 
       // Nested OR with inner match (redundant "*" removed, but outer OR remains)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             or: [
               {
@@ -623,10 +627,10 @@ describe("core: buildScopedConditions", function () {
     });
 
     test("nested NOT conditions", function () {
-      // Nested NOT (all "*" becomes "*")
+      // Nested NOT preserves non-broadening false expressions
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             not: [
               {
@@ -650,14 +654,20 @@ describe("core: buildScopedConditions", function () {
             browser: "chrome",
           },
         ),
-      ).toEqual("*");
+      ).toEqual({
+        not: [
+          {
+            not: ["*"],
+          },
+        ],
+      });
     });
 
     test("mixed nested conditions", function () {
       // AND with nested OR (redundant "*" removed, but OR structure remains if not all match)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               {
@@ -702,8 +712,8 @@ describe("core: buildScopedConditions", function () {
 
       // OR with nested AND (redundant "*" removed, but OR structure remains if not all match)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             or: [
               {
@@ -744,8 +754,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with nested NOT (redundant "*" removed)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               {
@@ -785,8 +795,8 @@ describe("core: buildScopedConditions", function () {
 
       // Complex nested structure (redundant "*" removed)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [
               {
@@ -843,8 +853,8 @@ describe("core: buildScopedConditions", function () {
     test("arrays with nested conditions", function () {
       // Array with AND condition (redundant "*" removed)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           [
             {
               attribute: "platform",
@@ -876,8 +886,8 @@ describe("core: buildScopedConditions", function () {
 
       // Array with OR condition (redundant "*" removed, but OR structure remains if not all match)
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           [
             {
               attribute: "platform",
@@ -920,8 +930,8 @@ describe("core: buildScopedConditions", function () {
     test("edge cases", function () {
       // Empty context
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             attribute: "platform",
             operator: "equals",
@@ -936,12 +946,12 @@ describe("core: buildScopedConditions", function () {
       });
 
       // Empty array (all "*" becomes "*")
-      expect(buildScopedConditions(datafileReader, [], {})).toEqual("*");
+      expect(applyContextToConditions(featurevisor, [], {})).toEqual("*");
 
       // "*" in array with matching condition (all "*" becomes "*")
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           [
             "*",
             {
@@ -958,8 +968,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with empty array (all "*" becomes "*")
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             and: [],
           },
@@ -969,8 +979,8 @@ describe("core: buildScopedConditions", function () {
 
       // OR with empty array (all "*" becomes "*")
       expect(
-        buildScopedConditions(
-          datafileReader,
+        applyContextToConditions(
+          featurevisor,
           {
             or: [],
           },
@@ -980,19 +990,19 @@ describe("core: buildScopedConditions", function () {
     });
   });
 
-  describe("buildScopedCondition (singular)", function () {
-    test("buildScopedCondition is a function", function () {
-      expect(buildScopedCondition).toBeInstanceOf(Function);
+  describe("applyContextToCondition (singular)", function () {
+    test("applyContextToCondition is a function", function () {
+      expect(applyContextToCondition).toBeInstanceOf(Function);
     });
 
     test("simple cases", function () {
       // "*" remains "*"
-      expect(buildScopedCondition(datafileReader, "*", {})).toEqual("*");
+      expect(applyContextToCondition(featurevisor, "*", {})).toEqual("*");
 
       // Plain condition that matches
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             attribute: "platform",
             operator: "equals",
@@ -1006,8 +1016,8 @@ describe("core: buildScopedConditions", function () {
 
       // Plain condition that doesn't match
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             attribute: "platform",
             operator: "equals",
@@ -1039,7 +1049,7 @@ describe("core: buildScopedConditions", function () {
 
       // Partial match
       expect(
-        buildScopedCondition(datafileReader, originalConditions, {
+        applyContextToCondition(featurevisor, originalConditions, {
           platform: "web",
         }),
       ).toEqual([
@@ -1053,7 +1063,7 @@ describe("core: buildScopedConditions", function () {
 
       // Full match
       expect(
-        buildScopedCondition(datafileReader, originalConditions, {
+        applyContextToCondition(featurevisor, originalConditions, {
           platform: "web",
           browser: "chrome",
         }),
@@ -1061,7 +1071,7 @@ describe("core: buildScopedConditions", function () {
 
       // No match
       expect(
-        buildScopedCondition(datafileReader, originalConditions, {
+        applyContextToCondition(featurevisor, originalConditions, {
           platform: "mobile",
           browser: "safari",
         }),
@@ -1082,8 +1092,8 @@ describe("core: buildScopedConditions", function () {
     test("AND conditions", function () {
       // AND with all matching conditions
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               {
@@ -1109,8 +1119,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with partial match
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               {
@@ -1142,8 +1152,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with no matches
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               {
@@ -1180,8 +1190,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with "*" in it
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               "*",
@@ -1204,8 +1214,8 @@ describe("core: buildScopedConditions", function () {
     test("OR conditions", function () {
       // OR with all matching conditions
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             or: [
               {
@@ -1230,8 +1240,8 @@ describe("core: buildScopedConditions", function () {
 
       // OR with partial match (first matches)
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             or: [
               {
@@ -1263,8 +1273,8 @@ describe("core: buildScopedConditions", function () {
 
       // OR with no matches
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             or: [
               {
@@ -1302,8 +1312,8 @@ describe("core: buildScopedConditions", function () {
     test("NOT conditions", function () {
       // NOT with matching condition (should not match)
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             not: [
               {
@@ -1323,8 +1333,8 @@ describe("core: buildScopedConditions", function () {
 
       // NOT with non-matching condition
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             not: [
               {
@@ -1350,8 +1360,8 @@ describe("core: buildScopedConditions", function () {
 
       // NOT with multiple conditions
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             not: [
               {
@@ -1379,8 +1389,8 @@ describe("core: buildScopedConditions", function () {
     test("nested AND conditions", function () {
       // Nested AND with all matching
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               {
@@ -1421,8 +1431,8 @@ describe("core: buildScopedConditions", function () {
 
       // Nested AND with partial match
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               {
@@ -1471,8 +1481,8 @@ describe("core: buildScopedConditions", function () {
     test("nested OR conditions", function () {
       // Nested OR with matching
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             or: [
               {
@@ -1522,8 +1532,8 @@ describe("core: buildScopedConditions", function () {
 
       // Nested OR with inner match
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             or: [
               {
@@ -1575,8 +1585,8 @@ describe("core: buildScopedConditions", function () {
     test("nested NOT conditions", function () {
       // Nested NOT
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             not: [
               {
@@ -1613,8 +1623,8 @@ describe("core: buildScopedConditions", function () {
     test("mixed nested conditions", function () {
       // AND with nested OR
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               {
@@ -1661,8 +1671,8 @@ describe("core: buildScopedConditions", function () {
 
       // OR with nested AND
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             or: [
               {
@@ -1706,8 +1716,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with nested NOT
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               {
@@ -1748,8 +1758,8 @@ describe("core: buildScopedConditions", function () {
 
       // Complex nested structure
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [
               {
@@ -1810,8 +1820,8 @@ describe("core: buildScopedConditions", function () {
     test("arrays with nested conditions", function () {
       // Array with AND condition
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           [
             {
               attribute: "platform",
@@ -1848,8 +1858,8 @@ describe("core: buildScopedConditions", function () {
 
       // Array with OR condition
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           [
             {
               attribute: "platform",
@@ -1894,8 +1904,8 @@ describe("core: buildScopedConditions", function () {
     test("edge cases", function () {
       // Empty context
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             attribute: "platform",
             operator: "equals",
@@ -1910,12 +1920,12 @@ describe("core: buildScopedConditions", function () {
       });
 
       // Empty array
-      expect(buildScopedCondition(datafileReader, [], {})).toEqual([]);
+      expect(applyContextToCondition(featurevisor, [], {})).toEqual([]);
 
       // "*" in array
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           [
             "*",
             {
@@ -1932,8 +1942,8 @@ describe("core: buildScopedConditions", function () {
 
       // AND with empty array
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             and: [],
           },
@@ -1945,8 +1955,8 @@ describe("core: buildScopedConditions", function () {
 
       // OR with empty array
       expect(
-        buildScopedCondition(
-          datafileReader,
+        applyContextToCondition(
+          featurevisor,
           {
             or: [],
           },
@@ -2126,7 +2136,9 @@ describe("core: buildScopedConditions", function () {
 
     test("NOT conditions", function () {
       // All "*" in NOT
-      expect(removeRedundantConditions({ not: ["*", "*", "*"] })).toEqual("*");
+      expect(removeRedundantConditions({ not: ["*", "*", "*"] })).toEqual({
+        not: ["*"],
+      });
 
       // Mixed with "*" in NOT
       expect(
@@ -2299,7 +2311,13 @@ describe("core: buildScopedConditions", function () {
             "*",
           ],
         }),
-      ).toEqual("*");
+      ).toEqual({
+        not: [
+          {
+            not: ["*"],
+          },
+        ],
+      });
 
       // Nested NOT with mixed conditions
       expect(