@featurevisor/core 2.20.0 → 2.22.1

package/lib/linter/attributeSchema.spec.js

@@ -0,0 +1,266 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const attributeSchema_1 = require("./attributeSchema");
+function parseAttribute(input) {
+    return (0, attributeSchema_1.getAttributeZodSchema)().safeParse(input);
+}
+function expectAttributeSuccess(input) {
+    const result = parseAttribute(input);
+    expect(result.success).toBe(true);
+    if (!result.success) {
+        const error = result.error;
+        const msg = error.issues.map((issue) => issue.message).join("; ");
+        throw new Error(`Expected attribute to pass: ${msg}`);
+    }
+}
+function expectAttributeFailure(input, messageSubstring) {
+    const result = parseAttribute(input);
+    expect(result.success).toBe(false);
+    if (result.success) {
+        throw new Error("Expected attribute to fail");
+    }
+    const error = result.error;
+    if (messageSubstring) {
+        const messages = error.issues.map((issue) => issue.message).join(" ");
+        expect(messages).toContain(messageSubstring);
+    }
+    return error;
+}
+describe("attributeSchema.ts :: getAttributeZodSchema", () => {
+    it("accepts flat object attributes without additional schema details", () => {
+        expectAttributeSuccess({
+            description: "Traits",
+            type: "object",
+        });
+    });
+    it("accepts flat object properties and typed arrays", () => {
+        expectAttributeSuccess({
+            description: "Account",
+            type: "object",
+            required: ["plan"],
+            properties: {
+                plan: {
+                    type: "string",
+                    enum: ["free", "pro"],
+                },
+                locale: {
+                    type: "string",
+                },
+                permissions: {
+                    type: "array",
+                    items: {
+                        type: "string",
+                        enum: ["read", "write", "admin"],
+                    },
+                },
+            },
+        });
+    });
+    it("accepts array attributes without items when they stay flat", () => {
+        expectAttributeSuccess({
+            description: "Tags",
+            type: "array",
+        });
+    });
+    it("accepts string-array enums on array attributes", () => {
+        expectAttributeSuccess({
+            description: "Permissions",
+            type: "array",
+            items: {
+                type: "string",
+            },
+            enum: [["read"], ["write", "admin"]],
+        });
+    });
+    it("accepts top-level oneOf attributes without type", () => {
+        expectAttributeSuccess({
+            description: "Version number of the app",
+            oneOf: [{ type: "string" }, { type: "double" }],
+        });
+    });
+    it("accepts top-level oneOf attributes with branch-specific enums", () => {
+        expectAttributeSuccess({
+            description: "Plan or score",
+            oneOf: [
+                { type: "string", enum: ["free", "pro"] },
+                { type: "double", minimum: 0 },
+            ],
+        });
+    });
+    it("requires items when array schema adds extra constraints", () => {
+        expectAttributeFailure({
+            description: "Permissions",
+            type: "array",
+            enum: [["read"], ["write"]],
+        }, "`items` is required");
+    });
+    it("rejects attributes without top-level type or oneOf", () => {
+        expectAttributeFailure({
+            description: "Country",
+        }, "either `type` or `oneOf`");
+    });
+    it("rejects attributes with both top-level type and oneOf", () => {
+        expectAttributeFailure({
+            description: "Version number of the app",
+            type: "string",
+            oneOf: [{ type: "string" }, { type: "double" }],
+        }, "cannot have both `type` and `oneOf`");
+    });
+    it("rejects top-level oneOf attributes when a branch enum does not match its type", () => {
+        expectAttributeFailure({
+            description: "Plan or score",
+            oneOf: [{ type: "string", enum: ["free", 1] }, { type: "double" }],
+        }, 'does not match type "string"');
+    });
+    it("rejects nested object properties inside object attributes", () => {
+        expectAttributeFailure({
+            description: "Account",
+            type: "object",
+            properties: {
+                metadata: {
+                    type: "object",
+                    properties: {
+                        locale: {
+                            type: "string",
+                        },
+                    },
+                },
+            },
+        }, "must stay flat");
+    });
+    it("rejects object additionalProperties that allow nested objects", () => {
+        expectAttributeFailure({
+            description: "Labels",
+            type: "object",
+            additionalProperties: {
+                type: "object",
+                properties: {
+                    locale: {
+                        type: "string",
+                    },
+                },
+            },
+        }, "must stay flat");
+    });
+    it("rejects object properties whose oneOf allows nested objects", () => {
+        expectAttributeFailure({
+            description: "Account",
+            type: "object",
+            properties: {
+                metadata: {
+                    oneOf: [
+                        { type: "string" },
+                        {
+                            type: "object",
+                            properties: {
+                                locale: {
+                                    type: "string",
+                                },
+                            },
+                        },
+                    ],
+                },
+            },
+        }, "must stay flat");
+    });
+    it("rejects object additionalProperties whose oneOf allows nested objects", () => {
+        expectAttributeFailure({
+            description: "Labels",
+            type: "object",
+            additionalProperties: {
+                oneOf: [
+                    { type: "string" },
+                    {
+                        type: "object",
+                        properties: {
+                            locale: {
+                                type: "string",
+                            },
+                        },
+                    },
+                ],
+            },
+        }, "must stay flat");
+    });
+    it("rejects non-string item types for array attributes", () => {
+        expectAttributeFailure({
+            description: "Scores",
+            type: "array",
+            items: {
+                type: "integer",
+            },
+        }, "items.type");
+    });
+    it("rejects non-string enum values for array attributes", () => {
+        expectAttributeFailure({
+            description: "Scores",
+            type: "array",
+            enum: [[1, 2]],
+        }, "array of strings");
+    });
+    it("rejects non-string const values for array attributes", () => {
+        expectAttributeFailure({
+            description: "Scores",
+            type: "array",
+            items: {
+                type: "string",
+            },
+            const: [1, 2],
+        }, "array of strings");
+    });
+    it("rejects required keys that are not declared in properties", () => {
+        expectAttributeFailure({
+            description: "Account",
+            type: "object",
+            required: ["plan", "tier"],
+            properties: {
+                plan: {
+                    type: "string",
+                },
+            },
+        }, "Unknown required field");
+    });
+    it("accepts required keys on flat object attributes without declared properties", () => {
+        expectAttributeSuccess({
+            description: "Traits",
+            type: "object",
+            required: ["plan"],
+        });
+    });
+    it("rejects enum values that do not match semver/date string-like types", () => {
+        expectAttributeFailure({
+            description: "Browser version",
+            type: "semver",
+            enum: ["1.0.0", 2],
+        }, 'does not match type "semver"');
+    });
+    it("rejects minimum values greater than maximum for numeric attributes", () => {
+        expectAttributeFailure({
+            description: "Score",
+            type: "double",
+            minimum: 10,
+            maximum: 5,
+        }, "minimum");
+    });
+    it("rejects minLength values greater than maxLength for string attributes", () => {
+        expectAttributeFailure({
+            description: "Country",
+            type: "string",
+            minLength: 5,
+            maxLength: 2,
+        }, "minLength");
+    });
+    it("rejects invalid string patterns nested under object properties", () => {
+        expectAttributeFailure({
+            description: "Profile",
+            type: "object",
+            properties: {
+                email: {
+                    type: "string",
+                    pattern: "[",
+                },
+            },
+        }, "valid ECMA-262");
+    });
+});
+//# sourceMappingURL=attributeSchema.spec.js.map

package/lib/linter/attributeSchema.spec.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"attributeSchema.spec.js","sourceRoot":"","sources":["../../src/linter/attributeSchema.spec.ts"],"names":[],"mappings":";;AAEA,uDAA0D;AAE1D,SAAS,cAAc,CAAC,KAAc;IACpC,OAAO,IAAA,uCAAqB,GAAE,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;AAClD,CAAC;AAED,SAAS,sBAAsB,CAAC,KAAc;IAC5C,MAAM,MAAM,GAAG,cAAc,CAAC,KAAK,CAAC,CAAC;IACrC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAClC,IAAI,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;QACpB,MAAM,KAAK,GAAI,MAAoC,CAAC,KAAK,CAAC;QAC1D,MAAM,GAAG,GAAG,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClE,MAAM,IAAI,KAAK,CAAC,+BAA+B,GAAG,EAAE,CAAC,CAAC;IACxD,CAAC;AACH,CAAC;AAED,SAAS,sBAAsB,CAAC,KAAc,EAAE,gBAAyB;IACvE,MAAM,MAAM,GAAG,cAAc,CAAC,KAAK,CAAC,CAAC;IACrC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IACnC,IAAI,MAAM,CAAC,OAAO,EAAE,CAAC;QACnB,MAAM,IAAI,KAAK,CAAC,4BAA4B,CAAC,CAAC;IAChD,CAAC;IAED,MAAM,KAAK,GAAI,MAAoC,CAAC,KAAK,CAAC;IAE1D,IAAI,gBAAgB,EAAE,CAAC;QACrB,MAAM,QAAQ,GAAG,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACtE,MAAM,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;IAC/C,CAAC;IAED,OAAO,KAAK,CAAC;AACf,CAAC;AAED,QAAQ,CAAC,6CAA6C,EAAE,GAAG,EAAE;IAC3D,EAAE,CAAC,kEAAkE,EAAE,GAAG,EAAE;QAC1E,sBAAsB,CAAC;YACrB,WAAW,EAAE,QAAQ;YACrB,IAAI,EAAE,QAAQ;SACf,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,sBAAsB,CAAC;YACrB,WAAW,EAAE,SAAS;YACtB,IAAI,EAAE,QAAQ;YACd,QAAQ,EAAE,CAAC,MAAM,CAAC;YAClB,UAAU,EAAE;gBACV,IAAI,EAAE;oBACJ,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,CAAC,MAAM,EAAE,KAAK,CAAC;iBACtB;gBACD,MAAM,EAAE;oBACN,IAAI,EAAE,QAAQ;iBACf;gBACD,WAAW,EAAE;oBACX,IAAI,EAAE,OAAO;oBACb,KAAK,EAAE;wBACL,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,CAAC,MAAM,EAAE,OAAO,EAAE,OAAO,CAAC;qBACjC;iBACF;aACF;SACF,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4DAA4D,EAAE,GAAG,EAAE;QACpE,sBAAsB,CAAC;YACrB,WAAW,EAAE,MAAM;YACnB,IAAI,EAAE,OAAO;SACd,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;QACxD,sBAAsB,CAAC;YACrB,WAAW,EAAE,aAAa;YAC1B,IAAI,EAAE,OAAO;YACb,KAAK,EAAE;gBACL,IAAI,EAAE,QAAQ;aACf;YACD,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;SACrC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,sBAAsB,CAAC;YACrB,WAAW,EAAE,2BAA2B;YACxC,KAAK,EAAE,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC;SAChD,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,sBAAsB,CAAC;YACrB,WAAW,EAAE,eAAe;YAC5B,KAAK,EAAE;gBACL,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,MAAM,EAAE,KAAK,CAAC,EAAE;gBACzC,EAAE,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,CAAC,EAAE;aAC/B;SACF,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,GAAG,EAAE;QACjE,sBAAsB,CACpB;YACE,WAAW,EAAE,aAAa;YAC1B,IAAI,EAAE,OAAO;YACb,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,CAAC,CAAC;SAC5B,EACD,qBAAqB,CACtB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,sBAAsB,CACpB;YACE,WAAW,EAAE,SAAS;SACvB,EACD,0BAA0B,CAC3B,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,sBAAsB,CACpB;YACE,WAAW,EAAE,2BAA2B;YACxC,IAAI,EAAE,QAAQ;YACd,KAAK,EAAE,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC;SAChD,EACD,qCAAqC,CACtC,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+EAA+E,EAAE,GAAG,EAAE;QACvF,sBAAsB,CACpB;YACE,WAAW,EAAE,eAAe;YAC5B,KAAK,EAAE,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,MAAM,EAAE,CAAC,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC;SACnE,EACD,8BAA8B,CAC/B,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACnE,sBAAsB,CACpB;YACE,WAAW,EAAE,SAAS;YACtB,IAAI,EAAE,QAAQ;YACd,UAAU,EAAE;gBACV,QAAQ,EAAE;oBACR,IAAI,EAAE,QAAQ;oBACd,UAAU,EAAE;wBACV,MAAM,EAAE;4BACN,IAAI,EAAE,QAAQ;yBACf;qBACF;iBACF;aACF;SACF,EACD,gBAAgB,CACjB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,sBAAsB,CACpB;YACE,WAAW,EAAE,QAAQ;YACrB,IAAI,EAAE,QAAQ;YACd,oBAAoB,EAAE;gBACpB,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,MAAM,EAAE;wBACN,IAAI,EAAE,QAAQ;qBACf;iBACF;aACF;SACF,EACD,gBAAgB,CACjB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6DAA6D,EAAE,GAAG,EAAE;QACrE,sBAAsB,CACpB;YACE,WAAW,EAAE,SAAS;YACtB,IAAI,EAAE,QAAQ;YACd,UAAU,EAAE;gBACV,QAAQ,EAAE;oBACR,KAAK,EAAE;wBACL,EAAE,IAAI,EAAE,QAAQ,EAAE;wBAClB;4BACE,IAAI,EAAE,QAAQ;4BACd,UAAU,EAAE;gCACV,MAAM,EAAE;oCACN,IAAI,EAAE,QAAQ;iCACf;6BACF;yBACF;qBACF;iBACF;aACF;SACF,EACD,gBAAgB,CACjB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,sBAAsB,CACpB;YACE,WAAW,EAAE,QAAQ;YACrB,IAAI,EAAE,QAAQ;YACd,oBAAoB,EAAE;gBACpB,KAAK,EAAE;oBACL,EAAE,IAAI,EAAE,QAAQ,EAAE;oBAClB;wBACE,IAAI,EAAE,QAAQ;wBACd,UAAU,EAAE;4BACV,MAAM,EAAE;gCACN,IAAI,EAAE,QAAQ;6BACf;yBACF;qBACF;iBACF;aACF;SACF,EACD,gBAAgB,CACjB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,sBAAsB,CACpB;YACE,WAAW,EAAE,QAAQ;YACrB,IAAI,EAAE,OAAO;YACb,KAAK,EAAE;gBACL,IAAI,EAAE,SAAS;aAChB;SACF,EACD,YAAY,CACb,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC7D,sBAAsB,CACpB;YACE,WAAW,EAAE,QAAQ;YACrB,IAAI,EAAE,OAAO;YACb,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;SACf,EACD,kBAAkB,CACnB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,GAAG,EAAE;QAC9D,sBAAsB,CACpB;YACE,WAAW,EAAE,QAAQ;YACrB,IAAI,EAAE,OAAO;YACb,KAAK,EAAE;gBACL,IAAI,EAAE,QAAQ;aACf;YACD,KAAK,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC;SACd,EACD,kBAAkB,CACnB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACnE,sBAAsB,CACpB;YACE,WAAW,EAAE,SAAS;YACtB,IAAI,EAAE,QAAQ;YACd,QAAQ,EAAE,CAAC,MAAM,EAAE,MAAM,CAAC;YAC1B,UAAU,EAAE;gBACV,IAAI,EAAE;oBACJ,IAAI,EAAE,QAAQ;iBACf;aACF;SACF,EACD,wBAAwB,CACzB,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6EAA6E,EAAE,GAAG,EAAE;QACrF,sBAAsB,CAAC;YACrB,WAAW,EAAE,QAAQ;YACrB,IAAI,EAAE,QAAQ;YACd,QAAQ,EAAE,CAAC,MAAM,CAAC;SACnB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,sBAAsB,CACpB;YACE,WAAW,EAAE,iBAAiB;YAC9B,IAAI,EAAE,QAAQ;YACd,IAAI,EAAE,CAAC,OAAO,EAAE,CAAC,CAAC;SACnB,EACD,8BAA8B,CAC/B,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oEAAoE,EAAE,GAAG,EAAE;QAC5E,sBAAsB,CACpB;YACE,WAAW,EAAE,OAAO;YACpB,IAAI,EAAE,QAAQ;YACd,OAAO,EAAE,EAAE;YACX,OAAO,EAAE,CAAC;SACX,EACD,SAAS,CACV,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,sBAAsB,CACpB;YACE,WAAW,EAAE,SAAS;YACtB,IAAI,EAAE,QAAQ;YACd,SAAS,EAAE,CAAC;YACZ,SAAS,EAAE,CAAC;SACb,EACD,WAAW,CACZ,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACxE,sBAAsB,CACpB;YACE,WAAW,EAAE,SAAS;YACtB,IAAI,EAAE,QAAQ;YACd,UAAU,EAAE;gBACV,KAAK,EAAE;oBACL,IAAI,EAAE,QAAQ;oBACd,OAAO,EAAE,GAAG;iBACb;aACF;SACF,EACD,gBAAgB,CACjB,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/lib/linter/conditionSchema.d.ts

@@ -1,3 +1,4 @@
+import type { Attribute, Schema } from "@featurevisor/types";
 import { z } from "zod";
 import { ProjectConfig } from "../config";
-export declare function getConditionsZodSchema(projectConfig: ProjectConfig, availableAttributeKeys: [string, ...string[]]): z.ZodUnion<[any, z.ZodArray<any, "many">, z.ZodLiteral<"*">]>;
+export declare function getConditionsZodSchema(projectConfig: ProjectConfig, attributesByKey: Record<string, Attribute>, schemasByKey?: Record<string, Schema>): z.ZodUnion<[any, z.ZodArray<any, "many">, z.ZodLiteral<"*">]>;