@fboes/aerofly-custom-missions 1.3.0 → 1.4.0

package/.editorconfig

@@ -10,3 +10,7 @@ charset = utf-8
 indent_style = space
 indent_size = 4
 max_line_length = 120
+
+[*.md]
+trim_trailing_whitespace = false
+indent_size = 2

package/AGENTS.md

@@ -0,0 +1,43 @@
+# AGENTS.md
+
+## Project Overview
+
+This project provides custom mission support for Aerofly flight simulators. It includes TypeScript source code, DTOs, configuration files, and supporting documentation for mission creation and management.
+
+## Coding Guidelines
+
+- **Explicit Class Properties:**
+  - All class properties must be explicitly defined in every class. Avoid using implicit or dynamic property assignment.
+- **JSDoc Comments:**
+  - Add descriptive JSDoc comments to every class property and method. This improves code readability and enables rich IntelliSense in VS Code.
+  - Example:
+    ```typescript
+    /**
+     * @property {string} name The name of the mission
+     */
+    name: string;
+    ```
+- **TypeScript Usage:**
+  - Use TypeScript types and interfaces for all data structures.
+  - Keep types up to date in the `types/` directory.
+
+## Contribution
+
+- Follow the coding guidelines above for all new code and pull requests.
+- See the `README.md` for setup and usage instructions.
+
+## Testing
+
+- TypeScript files have corresponding test files with the same filename and an added `.test` before the extension (e.g., `AeroflyMission.ts` and `AeroflyMission.test.ts`).
+- Run all tests using:
+  ```sh
+  npm test
+  ```
+- To run a single test file, specify its name:
+  ```sh
+  node --test src/dto/AeroflyMission.test.ts
+  ```
+- Create new tests by using the `node:test`
+  ```typescript
+  import { describe, it } from "node:test";
+  ```

package/CHANGELOG.md

@@ -2,22 +2,33 @@
 
 This changelog documents all notable changes to the Aerofly Custom Missions project. Each version entry includes a list of changes, with the most recent version at the top.
 
-## 1.3.0
+## [1.4.0]
+
+- Changed testing to standard Node.js testing suite
+- Added `fuel_mass` and `payload_mass` properties
+- Added `flight.mcf` / `main.mcf` DTO
+
+## [1.3.1]
+
+- Re-introduced spacers between exported missions
+- Re-introduced commented out nodes for exported missions
+
+## [1.3.0]
 
 - Changed TMC code generation with nodes
 
-## 1.2.3
+## [1.2.3]
 
 - Internal restructuring of mission generation logic
 - Optimized waypoint handling and validation
 - Improved error handling for mission parsing
 
-## 1.2.2
+## [1.2.2]
 
 - Added altitude constraint property for waypoints
 - Improved handling of cloud layers with better validation
 
-## 1.2.1
+## [1.2.1]
 
 - Changed handling of checkpoints to support missions without checkpoints
 - Improved file generation for programmatic mission creation
@@ -31,7 +42,7 @@ This changelog documents all notable changes to the Aerofly Custom Missions proj
   - `before_start`
   - `pushback`
 
-## 1.2.0
+## [1.2.0]
 
 - Added new cloud level properties:
   - `cirrus_cover` for high-altitude cloud coverage
@@ -39,13 +50,13 @@ This changelog documents all notable changes to the Aerofly Custom Missions proj
 - Added new waypoint property `fly_over` for precise waypoint navigation
 - Added `finish` property to mark mission completion points
 
-## 1.1.1
+## [1.1.1]
 
 - Fixed styling issues in mission display
 - Improved UI consistency across different mission types
 - Enhanced error message formatting
 
-## 1.1.0
+## [1.1.0]
 
 - Added new mission metadata properties:
   - `tags` for mission categorization
@@ -59,31 +70,31 @@ This changelog documents all notable changes to the Aerofly Custom Missions proj
   - `aerotow` for towed aircraft operations
 - Improved temperature property with better unit handling
 
-## 1.0.4
+## [1.0.4]
 
 - Added comprehensive documentation for known issues and workarounds
 - Added `AeroflyMissionConditions.temperature` property with Celsius support
 - Improved error handling for weather conditions
 
-## 1.0.3
+## [1.0.3]
 
 - Enhanced API documentation with examples
 - Added detailed parameter descriptions
 - Improved code documentation
 
-## 1.0.2
+## [1.0.2]
 
 - Added shorthand properties for common mission parameters
 - Improved property access methods
 - Enhanced mission validation
 
-## 1.0.1
+## [1.0.1]
 
 - Added initial API documentation
 - Improved code comments
 - Added basic usage examples
 
-## 1.0.0
+## [1.0.0]
 
 - Initial release of Aerofly Custom Missions
 - Basic mission creation and editing functionality

package/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright © 2024 Frank Boës
+Copyright © 2024-2026 Frank Boës
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 

package/README.md

@@ -4,6 +4,8 @@
 
 [Aerofly Flight Simulator 4](https://www.aerofly.com/) has a custom missions file `custom_missions_user.tmc` with a very unique format. To help you build this custom missions file, this JavaScript / TypeScript library offers Data Objects to create this file programmatically.
 
+This simulator also defines flight plans and settings in the `main.mcf`, which is automatically loaded on simulator startup. This library contains a proposal for a `flight.mcf`, which is a stripped-down version of the `main.mcf` which only contains all information necessary for flight set-up. See [the documentation for `flight.mcf`](./docs/flight-mcf.md).
+
 This library is intended to work in modern browsers as well as [Node.js](https://nodejs.org/en).
 
 ## Installation
@@ -52,6 +54,9 @@ import {
 
 You might want to enable TypeScript type checking by adding `// @ts-check` as your first line in your scripts.
 
+> [!NOTE]
+> This library also contains classes for building the yet unsupported `flight.mcf`. Please refer to the code on how to use this. See [the documentation for `flight.mcf`](./docs/flight-mcf.md).
+
 ### Basic idea
 
 All objects are basic structures needed for the missions list. The constructors tell you which properties are required, and will start with sensible defaults for all other properties.
@@ -60,7 +65,7 @@ All objects can be exported as JSON or as string via the `toString()` methods. E
 
 ### Building a missions file
 
-A mission file contains one or multiple missions. Building this file starts with the outer container, wich contains the missions:
+A `custom_missions_user.tmc` mission file contains one or multiple missions. Building this file starts with the outer container, wich contains the missions:
 
 ```javascript
 // Build a missions list

package/dist/check/TestHelpers.js

@@ -0,0 +1,13 @@
+import { strict as assert } from "node:assert";
+export const assertValidAeroflyStructure = (aeroflyString) => {
+    const openingBrackets = aeroflyString.match(/</g);
+    const closingBrackets = aeroflyString.match(/>/g);
+    const openingBrackets2 = aeroflyString.match(/\[/g);
+    const closingBrackets2 = aeroflyString.match(/\]/g);
+    assert.ok(openingBrackets?.length ?? 0 > 0, "Has opening <");
+    assert.strictEqual(openingBrackets?.length, closingBrackets?.length, "Number of <> matches");
+    assert.strictEqual(openingBrackets2?.length, closingBrackets2?.length, "Number of [] matches");
+};
+export const assertIncludes = (string, includes) => {
+    assert.ok(string.includes(includes), `Includes "${includes}"`);
+};

package/dist/check/TestHelpers.test.js

@@ -0,0 +1,8 @@
+import { assertValidAeroflyStructure } from "../check/TestHelpers.js";
+import { describe, it } from "node:test";
+describe("TestHelpers", () => {
+    it("should validate Aerofly structure correctly", () => {
+        const validString = "<>";
+        assertValidAeroflyStructure(validString);
+    });
+});

package/dist/dto/AeroflyLocalizedText.test.js

@@ -0,0 +1,16 @@
+import { AeroflyLocalizedText } from "./AeroflyLocalizedText.js";
+import { strict as assert } from "node:assert";
+import { assertValidAeroflyStructure } from "../check/TestHelpers.js";
+import { describe, it } from "node:test";
+describe("AeroflyLocalizedText", () => {
+    const localizedText = new AeroflyLocalizedText("de", "Test", "Test2");
+    it("should correctly map constructor values", () => {
+        assert.deepStrictEqual(localizedText.language, "de");
+        assert.deepStrictEqual(localizedText.title, "Test");
+        assert.deepStrictEqual(localizedText.description, "Test2");
+        assertValidAeroflyStructure(localizedText.toString());
+    });
+    it("should create a valid Aerofly mission", () => {
+        assertValidAeroflyStructure(localizedText.toString());
+    });
+});

package/dist/dto/AeroflyMission.js

@@ -1,4 +1,4 @@
-import { AeroflyConfigurationNode } from "../node/AeroflyConfigurationNode.js";
+import { AeroflyConfigurationNode, AeroflyConfigurationNodeComment } from "../node/AeroflyConfigurationNode.js";
 import { AeroflyMissionConditions } from "./AeroflyMissionConditions.js";
 export const feetPerMeter = 3.28084;
 export const meterPerStatuteMile = 1609.344;
@@ -23,6 +23,8 @@ export class AeroflyMission {
      * @param {"cold_and_dark"|"before_start"|"taxi"|"takeoff"|"cruise"|"approach"|"landing"|"winch_launch"|"aerotow"|"pushback"} [additionalAttributes.flightSetting] of aircraft, like "taxi", "cruise"
      * @param {{name:string,livery:string,icao:string}} [additionalAttributes.aircraft] for this mission
      * @param {string} [additionalAttributes.callsign] of aircraft, uppercased
+     * @param {?number} [additionalAttributes.fuelMass] in kg
+     * @param {?number} [additionalAttributes.payloadMass] in kg
      * @param {object} [additionalAttributes.origin] position of aircraft, as well as name of starting airport. Position does not have match airport.
      * @param {object} [additionalAttributes.destination] position of aircraft, as well as name of destination airport. Position does not have match airport.
      * @param {?number} [additionalAttributes.distance] in meters
@@ -36,7 +38,7 @@ export class AeroflyMission {
         name: "c172",
         icao: "",
         livery: "",
-    }, callsign = "", origin = {
+    }, callsign = "", fuelMass = null, payloadMass = null, origin = {
         icao: "",
         longitude: 0,
         latitude: 0,
@@ -60,6 +62,8 @@ export class AeroflyMission {
         this.flightSetting = flightSetting;
         this.aircraft = aircraft;
         this.callsign = callsign;
+        this.fuelMass = fuelMass;
+        this.payloadMass = payloadMass;
         this.origin = origin;
         this.destination = destination;
         this.distance = distance;
@@ -130,11 +134,17 @@ export class AeroflyMission {
         }
         element.appendChild("string8", "flight_setting", this.flightSetting);
         element.appendChild("string8u", "aircraft_name", this.aircraft.name);
-        /*if (this.aircraft.livery) {
-            mission.createChild("string8", "aircraft_livery", this.aircraft.livery);
-        }*/
         element.appendChild("stringt8c", "aircraft_icao", this.aircraft.icao);
+        if (this.aircraft.livery) {
+            element.append(new AeroflyConfigurationNodeComment("string8", "aircraft_livery", this.aircraft.livery));
+        }
         element.appendChild("stringt8c", "callsign", this.callsign);
+        if (this.fuelMass !== null) {
+            element.append(new AeroflyConfigurationNodeComment("float64", "fuel_mass", this.fuelMass, `kg`));
+        }
+        if (this.payloadMass !== null) {
+            element.append(new AeroflyConfigurationNodeComment("float64", "payload_mass", this.payloadMass, `kg`));
+        }
         element.appendChild("stringt8c", "origin_icao", this.origin.icao);
         element.appendChild("tmvector2d", "origin_lon_lat", [this.origin.longitude, this.origin.latitude]);
         element.appendChild("float64", "origin_alt", this.origin.alt, `${Math.ceil(this.origin.alt * feetPerMeter)} ft MSL`);

package/dist/dto/AeroflyMission.test.js

@@ -0,0 +1,166 @@
+import { AeroflyMission } from "./AeroflyMission.js";
+import { strict as assert } from "node:assert";
+import fs from "node:fs";
+import { assertIncludes, assertValidAeroflyStructure } from "../check/TestHelpers.js";
+import { describe, it } from "node:test";
+import { AeroflyLocalizedText } from "./AeroflyLocalizedText.js";
+import { AeroflyMissionCheckpoint } from "./AeroflyMissionCheckpoint.js";
+import { AeroflyMissionConditions } from "./AeroflyMissionConditions.js";
+import { AeroflyMissionConditionsCloud } from "./AeroflyMissionConditionsCloud.js";
+import { AeroflyMissionsList } from "./AeroflyMissionsList.js";
+import { AeroflyMissionTargetPlane } from "./AeroflyMissionTargetPlane.js";
+describe("AeroflyMission", () => {
+    const mission = new AeroflyMission("Title", {
+        origin: {
+            icao: "XXXX",
+            longitude: 0,
+            latitude: 0,
+            dir: 0,
+            alt: 0,
+        },
+        destination: {
+            icao: "XXXX",
+            longitude: 0,
+            latitude: 0,
+            dir: 0,
+            alt: 0,
+        },
+    });
+    it("should correctly map constructor values", () => {
+        assert.strictEqual(mission.title, "Title");
+    });
+    it("should create a valid Aerofly mission", () => {
+        assertValidAeroflyStructure(mission.toString());
+    });
+    it("should create a valid XML mission", () => {
+        assertValidAeroflyStructure(mission.getElement().toXmlString());
+    });
+    it("should create AeroflyMissionConditions correctly", () => {
+        const conditions = new AeroflyMissionConditions({
+            time: new Date(Date.UTC(2024, 5, 14, 13, 15, 38)),
+            wind: {
+                direction: 190,
+                speed: 11,
+                gusts: 22,
+            },
+            turbulenceStrength: 1,
+            temperature: 21,
+            visibility: 14484.096000000001,
+            clouds: [
+                AeroflyMissionConditionsCloud.createInFeet(0.1, 5000),
+                AeroflyMissionConditionsCloud.createInFeet(0.2, 7500),
+                AeroflyMissionConditionsCloud.createInFeet(0.1, 9500),
+            ],
+        });
+        assert.strictEqual(conditions.wind.direction, 190);
+        assert.strictEqual(conditions.wind.speed, 11);
+        assert.strictEqual(conditions.wind.gusts, 22);
+        assert.strictEqual(conditions.turbulenceStrength, 1);
+        assert.strictEqual(conditions.temperature, 21);
+        assert.strictEqual(conditions.visibility, 14484.096000000001);
+        const checkpoints = [
+            new AeroflyMissionCheckpoint("KCCR", "origin", -122.057, 37.9897, {
+                altitude: 8,
+            }),
+            new AeroflyMissionCheckpoint("19L", "departure_runway", -122.05504061196366, 37.993168229891225, {
+                length: 844.2959729825288,
+            }),
+            new AeroflyMissionCheckpoint("24", "destination_runway", -70.60730234370952, 41.399093035543366, {
+                altitude: 20,
+                length: 1677.6191463161874,
+                frequency: 108700000,
+            }),
+            new AeroflyMissionCheckpoint("KMVY", "destination", -70.6139, 41.3934, {
+                altitude: 20,
+                flyOver: false,
+            }),
+        ];
+        const mission = new AeroflyMission("KCCR #1: Concord / Buchanan Field", {
+            checkpoints,
+            conditions,
+            description: `It is a gusty, clear early morning, and you are 8 NM to the north of the towered airport Concord / Buchanan Field (27ft). As the wind is 11 kts from 190°, the main landing runway is 19L (191° / 844m). Fly the pattern and land safely.
+
+- Local tower / CTAF frequency: 123.90
+- Local navigational aids: VOR/DME CCR (117.00) 3.4 NM to the north`,
+            flightSetting: "cruise",
+            aircraft: {
+                name: "c172",
+                livery: "default",
+                icao: "C172",
+            },
+            callsign: "N51911",
+            origin: {
+                icao: "KCCR",
+                longitude: -122.0736009331662,
+                latitude: 38.122300745843944,
+                dir: 174.37511511143452,
+                alt: 1066.799965862401,
+            },
+            destination: {
+                icao: "KMVY",
+                longitude: -70.6139,
+                latitude: 41.3934,
+                dir: 221,
+                alt: 20,
+            },
+        });
+        const missionList = new AeroflyMissionsList([mission]);
+        assert.strictEqual(missionList.missions.length, 1);
+        assert.strictEqual(missionList.missions[0].aircraft.name, "c172");
+        assert.strictEqual(missionList.missions[0].aircraft.icao, "C172");
+        let missionListString = missionList.toString();
+        assert.strictEqual(missionListString, missionList.toString());
+        assertIncludes(missionListString, "[origin]");
+        assertIncludes(missionListString, "[tmmission_definition]");
+        assertIncludes(missionListString, "[list_tmmission_checkpoint]");
+        assertIncludes(missionListString, "[tmmission_checkpoint]");
+        assertIncludes(missionListString, "[departure_runway]");
+        assertIncludes(missionListString, "[cloud_cover]");
+        assertIncludes(missionListString, "[cirrus_cover]");
+        assertIncludes(missionListString, "[tmmission_checkpoint][element][0]");
+        assertIncludes(missionListString, "[tmmission_checkpoint][element][1]");
+        assertIncludes(missionListString, "[tmmission_checkpoint][element][2]");
+        assertIncludes(missionListString, "[tmmission_checkpoint][element][3]");
+        assertIncludes(missionListString, "<[float64][length][844.2959729825288]>");
+        assert.ok(!missionListString.includes("[tags]"));
+        assert.ok(!missionListString.includes("[difficulty]"));
+        assert.ok(!missionListString.includes("[is_featured]"));
+        assert.ok(!missionListString.includes("[tmmission_definition_localized]"));
+        assert.ok(!missionListString.includes("[distance]"));
+        assert.ok(!missionListString.includes("[duration]"));
+        assert.ok(!missionListString.includes("[alt_cst]"));
+        assertValidAeroflyStructure(missionListString);
+        //console.log(missionListString);
+        mission.difficulty = 1.0;
+        mission.isFeatured = true;
+        mission.localizedTexts.push(new AeroflyLocalizedText("de", "Landeübung #1", "Probier die Landung"));
+        mission.distance = 1400;
+        mission.duration = 2 * 60 * 60;
+        mission.tags.push("approach");
+        mission.tags.push("pattern");
+        mission.finish = new AeroflyMissionTargetPlane(0, 1, 2);
+        mission.tutorialName = "c172";
+        mission.isScheduled = true;
+        missionListString = missionList.toString();
+        assertIncludes(missionListString, "[tags]");
+        assertIncludes(missionListString, "[difficulty]");
+        assertIncludes(missionListString, "[is_featured]");
+        assertIncludes(missionListString, "true");
+        assertIncludes(missionListString, "[tmmission_definition_localized]");
+        assertIncludes(missionListString, "Landeübung");
+        assertIncludes(missionListString, "[distance]");
+        assertIncludes(missionListString, "[duration]");
+        assertIncludes(missionListString, "[finish]");
+        assertIncludes(missionListString, "[tutorial_name]");
+        assertIncludes(missionListString, "[is_scheduled]");
+        assertValidAeroflyStructure(missionListString);
+        //console.dir(missionList.missions[0], { depth: null });
+        //console.log(missionListString);
+        //console.log(missionList.getElement().toXmlString());
+        const file = new AeroflyMissionsList([mission]);
+        const fileContent = file.toString();
+        fs.writeFileSync("docs/custom_missions_user.tmc", fileContent);
+        const xmlContent = file.toXmlString();
+        fs.writeFileSync("docs/custom_missions_user.xml", xmlContent);
+    });
+});

package/dist/dto/AeroflyMissionCheckpoint.js

@@ -15,7 +15,7 @@ export class AeroflyMissionCheckpoint {
      * @param {"origin"|"departure_runway"|"departure"|"waypoint"|"arrival"|"approach"|"destination_runway"|"destination"} type Type of checkpoint, like "departure_runway"
      * @param {number} longitude easting, using the World Geodetic
      *    System 1984 (WGS 84) [WGS84] datum, with longitude and latitude units
-     *    of decimal degrees; -180..180
+     *    of decimal degrees; [-180,180]
      * @param {number} latitude northing, using the World Geodetic
      *    System 1984 (WGS 84) [WGS84] datum, with longitude and latitude units
      *    of decimal degrees; -90..90

package/dist/dto/AeroflyMissionCheckpoint.test.js

@@ -0,0 +1,41 @@
+import { AeroflyMissionCheckpoint } from "./AeroflyMissionCheckpoint.js";
+import { strict as assert } from "node:assert";
+import { assertValidAeroflyStructure, assertIncludes } from "../check/TestHelpers.js";
+import { describe, it } from "node:test";
+describe("AeroflyMissionCheckpoint", () => {
+    it("should correctly map constructor values", () => {
+        const checkpoint = new AeroflyMissionCheckpoint("TEST", "waypoint", 15, 20, {
+            altitude_feet: 1000,
+            flyOver: true,
+            length_feet: 500,
+        });
+        assert.strictEqual(checkpoint.name, "TEST");
+        assert.strictEqual(checkpoint.type, "waypoint");
+        assert.strictEqual(checkpoint.longitude, 15);
+        assert.strictEqual(checkpoint.latitude, 20);
+        assert.strictEqual(checkpoint.flyOver, true);
+        assert.strictEqual(Math.round(checkpoint.altitude_feet), 1000);
+        assert.strictEqual(Math.round(checkpoint.altitude), Math.round(1000 * 0.3048));
+        assert.strictEqual(Math.round(checkpoint.length_feet), 500);
+        assert.strictEqual(Math.round(checkpoint.length ?? 0), Math.round(500 * 0.3048));
+    });
+    it("should correctly map values from properties", () => {
+        const checkpoint = new AeroflyMissionCheckpoint("TEST", "waypoint", 15, 20);
+        let checkpointString = checkpoint.toString();
+        assertIncludes(checkpointString, "[type]");
+        assertIncludes(checkpointString, "[name]");
+        assertIncludes(checkpointString, "[lon_lat]");
+        assertIncludes(checkpointString, "15 20");
+        assertIncludes(checkpointString, "[altitude]");
+        assert.ok(!checkpointString.includes("[fly_over]"));
+        assert.ok(!checkpointString.includes("[alt_cst]"));
+        checkpoint.altitudeConstraint = false;
+        checkpoint.flyOver = false;
+        checkpoint.altitude_feet = 1000;
+        checkpoint.length_feet = 500;
+        checkpointString = checkpoint.toString();
+        assertIncludes(checkpointString, "[fly_over]");
+        assertIncludes(checkpointString, "[alt_cst]");
+        assertValidAeroflyStructure(checkpointString);
+    });
+});

package/dist/dto/AeroflyMissionConditions.js

@@ -15,8 +15,8 @@ export class AeroflyMissionConditions {
      * @param {Date} [additionalAttributes.time]  of flight plan. Relevant is the UTC part, so
      *    consider setting this date in UTC.
      * @param {{direction: number, speed: number, gusts: number}} [additionalAttributes.wind] state
-     * @param {number} [additionalAttributes.turbulenceStrength] 0..1, percentage
-     * @param {number} [additionalAttributes.thermalStrength] 0..1, percentage
+     * @param {number} [additionalAttributes.turbulenceStrength] normalized value [0,1]
+     * @param {number} [additionalAttributes.thermalStrength] normalized value [0,1]
      * @param {number} [additionalAttributes.visibility] in meters
      * @param {?number} [additionalAttributes.visibility_sm] in statute miles, will overwrite visibility
      * @param {?number} [additionalAttributes.temperature] in °C, will overwrite thermalStrength
@@ -26,7 +26,7 @@ export class AeroflyMissionConditions {
         direction: 0,
         speed: 0,
         gusts: 0,
-    }, turbulenceStrength = 0, thermalStrength = 0, visibility = 25000, visibility_sm = 0, temperature = 0, clouds = [], } = {}) {
+    }, turbulenceStrength = 0, thermalStrength = 0, visibility = 25_000, visibility_sm = 0, temperature = 0, clouds = [], } = {}) {
         /**
          * @property {AeroflyMissionConditionsCloud[]} clouds for the whole flight
          */
@@ -90,9 +90,7 @@ export class AeroflyMissionConditions {
      * @returns {AeroflyConfigurationNode[]} cloud elements
      */
     getCloudElements() {
-        return this.clouds
-            .slice(0, 2) // Aerofly FS4 supports max 2 cloud layers
-            .flatMap((c, index) => c.getElements(index));
+        return this.clouds.flatMap((c, index) => c.getElements(index));
     }
     /**
      * @returns {string} to use in Aerofly FS4's `custom_missions_user.tmc`

package/dist/dto/AeroflyMissionConditions.test.js

@@ -0,0 +1,33 @@
+import { AeroflyMissionConditions } from "./AeroflyMissionConditions.js";
+import { strict as assert } from "node:assert";
+import { assertValidAeroflyStructure } from "../check/TestHelpers.js";
+import { describe, it } from "node:test";
+describe("AeroflyMissionConditions", () => {
+    it("should handle visibility in meters correctly when set via property", () => {
+        const conditions = new AeroflyMissionConditions();
+        conditions.visibility = 15_000;
+        assert.deepStrictEqual(conditions.visibility, 15_000);
+    });
+    it("should handle visibility in statute miles correctly when set via property", () => {
+        const conditions = new AeroflyMissionConditions();
+        conditions.visibility_sm = 10;
+        assert.notDeepStrictEqual(conditions.visibility, 10);
+        assert.deepStrictEqual(Math.round(conditions.visibility_sm), 10);
+        assertValidAeroflyStructure(conditions.toString());
+    });
+    it("should handle visibility in meters correctly when set via constructor", () => {
+        const conditions = new AeroflyMissionConditions({
+            visibility: 15_000,
+        });
+        assert.deepStrictEqual(conditions.visibility, 15_000);
+        assertValidAeroflyStructure(conditions.toString());
+    });
+    it("should handle visibility in statute miles correctly when set via constructor", () => {
+        const conditions = new AeroflyMissionConditions({
+            visibility_sm: 10,
+        });
+        assert.notDeepStrictEqual(conditions.visibility, 10);
+        assert.deepStrictEqual(Math.round(conditions.visibility_sm), 10);
+        assertValidAeroflyStructure(conditions.toString());
+    });
+});

package/dist/dto/AeroflyMissionConditionsCloud.js

@@ -1,4 +1,4 @@
-import { AeroflyConfigurationNode } from "../node/AeroflyConfigurationNode.js";
+import { AeroflyConfigurationNode, AeroflyConfigurationNodeComment } from "../node/AeroflyConfigurationNode.js";
 import { feetPerMeter } from "./AeroflyMission.js";
 /**
  * @class
@@ -10,7 +10,7 @@ import { feetPerMeter } from "./AeroflyMission.js";
  */
 export class AeroflyMissionConditionsCloud {
     /**
-     * @param {number} cover 0..1, percentage
+     * @param {number} cover normalized value [0,1]
      * @param {number} base altitude in meters AGL
      */
     constructor(cover, base) {
@@ -18,7 +18,7 @@ export class AeroflyMissionConditionsCloud {
         this.base = base;
     }
     /**
-     * @param {number} cover 0..1, percentage
+     * @param {number} cover normalized value [0,1]
      * @param {number} base_feet altitude, but in feet AGL instead of meters AGL
      * @returns {AeroflyMissionConditionsCloud} self
      */
@@ -73,10 +73,15 @@ export class AeroflyMissionConditionsCloud {
             }
         };
         const indexString = getIndexString(index);
-        return [
-            new AeroflyConfigurationNode("float64", `${indexString}_cover`, this.cover ?? 0, this.cover_code),
-            new AeroflyConfigurationNode("float64", `${indexString}_base`, this.base, `${this.base_feet} ft AGL`),
-        ];
+        return index <= 1
+            ? [
+                new AeroflyConfigurationNode("float64", `${indexString}_cover`, this.cover ?? 0, this.cover_code),
+                new AeroflyConfigurationNode("float64", `${indexString}_base`, this.base, `${this.base_feet} ft AGL`),
+            ]
+            : [
+                new AeroflyConfigurationNodeComment("float64", `${indexString}_cover`, this.cover ?? 0, this.cover_code),
+                new AeroflyConfigurationNodeComment("float64", `${indexString}_base`, this.base, `${this.base_feet} ft AGL`),
+            ];
     }
     /**
      * @param {number} index if used in an array will set the array index

package/dist/dto/AeroflyMissionConditionsCloud.test.js

@@ -0,0 +1,25 @@
+import { AeroflyMissionConditionsCloud } from "./AeroflyMissionConditionsCloud.js";
+import { strict as assert } from "node:assert";
+import { assertValidAeroflyStructure } from "../check/TestHelpers.js";
+import { describe, it } from "node:test";
+describe("AeroflyMissionConditionsCloud", () => {
+    it("should create clouds with indentation", () => {
+        const cloud = new AeroflyMissionConditionsCloud(0, 0);
+        assert.deepStrictEqual(cloud.cover, 0);
+        assert.deepStrictEqual(cloud.base, 0);
+        assertValidAeroflyStructure(cloud.toString());
+        assertValidAeroflyStructure(cloud.toString(0));
+        assertValidAeroflyStructure(cloud.toString(1));
+        assertValidAeroflyStructure(cloud.toString(2));
+        assertValidAeroflyStructure(cloud.toString(3));
+    });
+    it("should assign values correctly from constructor and properties", () => {
+        const cloud = new AeroflyMissionConditionsCloud(1, 1000);
+        assert.deepStrictEqual(cloud.cover, 1);
+        assert.deepStrictEqual(cloud.base, 1000);
+        cloud.base_feet = 1000;
+        assert.notDeepStrictEqual(cloud.base, 1000);
+        assert.deepStrictEqual(Math.round(cloud.base_feet), 1000);
+        assertValidAeroflyStructure(cloud.toString());
+    });
+});

package/dist/dto/AeroflyMissionTargetPlane.js

@@ -8,7 +8,7 @@ export class AeroflyMissionTargetPlane {
      *
      * @param {number} longitude easting, using the World Geodetic
      *    System 1984 (WGS 84) [WGS84] datum, with longitude and latitude units
-     *    of decimal degrees; -180..180
+     *    of decimal degrees; [-180,180]
      * @param {number}latitude northing, using the World Geodetic
      *    System 1984 (WGS 84) [WGS84] datum, with longitude and latitude units
      *    of decimal degrees; -90..90