@fayz-ai/plugin-forms 0.2.0 → 0.8.1

package/src/migrations/002_document_archetype.sql

@@ -1,16 +1,26 @@
 -- ============================================================
--- Document Archetype — saas_core.documents
+-- Document Archetype — public.documents
 -- A document is any record associated with a person (or standalone):
 -- forms, images, attachments, prescriptions, contracts, etc.
 -- The `kind` column discriminates the type.
+--
+-- DATA SAFETY (converted pools): plg_forms_documents may already hold REAL
+-- rows in its PRE-archetype shape (its own `id` PK, no `document_id` column —
+-- see 001_frm_base.sql). This migration MIGRATES those rows into the new
+-- document archetype instead of dropping them:
+--   * pre-archetype + rows   -> copy each legacy row into public.documents
+--                               (reusing its id) + into the new extension
+--                               table, migrate its files, then drop legacy.
+--   * pre-archetype + empty  -> plain drop + create (fresh shape).
+--   * already new shape      -> no-op.
 -- ============================================================
 
-CREATE TABLE IF NOT EXISTS saas_core.documents (
+CREATE TABLE IF NOT EXISTS public.documents (
   id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
-  tenant_id uuid NOT NULL REFERENCES saas_core.tenants(id) ON DELETE CASCADE,
+  tenant_id uuid NOT NULL REFERENCES public.tenants(id) ON DELETE CASCADE,
   kind text NOT NULL DEFAULT 'attachment',
   -- kind: 'form', 'image', 'attachment', 'prescription', 'contract', etc.
-  person_id uuid REFERENCES saas_core.persons(id) ON DELETE SET NULL,
+  person_id uuid REFERENCES public.people(id) ON DELETE SET NULL,
   title text,
   description text,
   status text NOT NULL DEFAULT 'draft',
@@ -29,39 +39,63 @@ CREATE TABLE IF NOT EXISTS saas_core.documents (
   updated_at timestamptz NOT NULL DEFAULT now()
 );
 
-ALTER TABLE saas_core.documents ENABLE ROW LEVEL SECURITY;
+ALTER TABLE public.documents ENABLE ROW LEVEL SECURITY;
 
-CREATE INDEX IF NOT EXISTS idx_documents_tenant ON saas_core.documents(tenant_id, kind);
-CREATE INDEX IF NOT EXISTS idx_documents_person ON saas_core.documents(person_id);
-CREATE INDEX IF NOT EXISTS idx_documents_status ON saas_core.documents(tenant_id, status);
+CREATE INDEX IF NOT EXISTS idx_documents_tenant ON public.documents(tenant_id, kind);
+CREATE INDEX IF NOT EXISTS idx_documents_person ON public.documents(person_id);
+CREATE INDEX IF NOT EXISTS idx_documents_status ON public.documents(tenant_id, status);
 
-CREATE POLICY "documents_select" ON saas_core.documents
+DROP POLICY IF EXISTS "documents_select" ON public.documents;
+CREATE POLICY "documents_select" ON public.documents
   FOR SELECT TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "documents_insert" ON saas_core.documents
+DROP POLICY IF EXISTS "documents_insert" ON public.documents;
+CREATE POLICY "documents_insert" ON public.documents
   FOR INSERT TO authenticated
   WITH CHECK (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "documents_update" ON saas_core.documents
+DROP POLICY IF EXISTS "documents_update" ON public.documents;
+CREATE POLICY "documents_update" ON public.documents
   FOR UPDATE TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "documents_delete" ON saas_core.documents
+DROP POLICY IF EXISTS "documents_delete" ON public.documents;
+CREATE POLICY "documents_delete" ON public.documents
   FOR DELETE TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
 
 -- ============================================================
--- Alter frm_documents to become extension table for 'form' kind
+-- Reconcile plg_forms_documents / plg_forms_document_files with the archetype.
 -- ============================================================
 
--- Drop old frm_documents and recreate as extension
-DROP VIEW IF EXISTS public.v_frm_documents;
-DROP TABLE IF EXISTS public.frm_document_files;
-DROP TABLE IF EXISTS public.frm_documents;
+-- Step 1: if a PRE-archetype plg_forms_documents is present (no document_id
+-- column), rename it (and its files table + dependent view) out of the way so
+-- the new archetype-shaped tables can be created and — when it holds rows —
+-- its data copied across. Fully guarded, so already-migrated pools skip this.
+DO $$
+BEGIN
+  IF to_regclass('public.plg_forms_documents') IS NOT NULL
+     AND NOT EXISTS (
+       SELECT 1 FROM information_schema.columns
+       WHERE table_schema = 'public'
+         AND table_name = 'plg_forms_documents'
+         AND column_name = 'document_id'
+     ) THEN
+    DROP VIEW IF EXISTS public.v_frm_documents;
+    ALTER TABLE public.plg_forms_documents RENAME TO plg_forms_documents_legacy;
+    IF to_regclass('public.plg_forms_document_files') IS NOT NULL THEN
+      ALTER TABLE public.plg_forms_document_files RENAME TO plg_forms_document_files_legacy;
+    END IF;
+  END IF;
+END $$;
 
--- frm_documents: extension table for form-type documents
-CREATE TABLE public.frm_documents (
-  document_id uuid PRIMARY KEY REFERENCES saas_core.documents(id) ON DELETE CASCADE,
-  tenant_id uuid NOT NULL REFERENCES saas_core.tenants(id) ON DELETE CASCADE,
-  template_id uuid NOT NULL REFERENCES public.frm_templates(id),
+-- Step 2: create the new archetype-shaped extension tables. IF NOT EXISTS makes
+-- this a no-op on pools already migrated to the new shape; after Step 1 the
+-- names are free on pre-archetype pools.
+
+-- plg_forms_documents: extension table for form-type documents
+CREATE TABLE IF NOT EXISTS public.plg_forms_documents (
+  document_id uuid PRIMARY KEY REFERENCES public.documents(id) ON DELETE CASCADE,
+  tenant_id uuid NOT NULL REFERENCES public.tenants(id) ON DELETE CASCADE,
+  template_id uuid NOT NULL REFERENCES public.plg_forms_templates(id),
   data jsonb NOT NULL DEFAULT '{}',
   signed_at timestamptz,
   signed_by uuid,
@@ -69,28 +103,32 @@ CREATE TABLE public.frm_documents (
   updated_at timestamptz NOT NULL DEFAULT now()
 );
 
-ALTER TABLE public.frm_documents ENABLE ROW LEVEL SECURITY;
+ALTER TABLE public.plg_forms_documents ENABLE ROW LEVEL SECURITY;
 
-CREATE INDEX IF NOT EXISTS idx_frm_documents_template ON public.frm_documents(template_id);
+CREATE INDEX IF NOT EXISTS idx_plg_forms_documents_template ON public.plg_forms_documents(template_id);
 
-CREATE POLICY "frm_documents_select" ON public.frm_documents
+DROP POLICY IF EXISTS "plg_forms_documents_select" ON public.plg_forms_documents;
+CREATE POLICY "plg_forms_documents_select" ON public.plg_forms_documents
   FOR SELECT TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "frm_documents_insert" ON public.frm_documents
+DROP POLICY IF EXISTS "plg_forms_documents_insert" ON public.plg_forms_documents;
+CREATE POLICY "plg_forms_documents_insert" ON public.plg_forms_documents
   FOR INSERT TO authenticated
   WITH CHECK (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "frm_documents_update" ON public.frm_documents
+DROP POLICY IF EXISTS "plg_forms_documents_update" ON public.plg_forms_documents;
+CREATE POLICY "plg_forms_documents_update" ON public.plg_forms_documents
   FOR UPDATE TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "frm_documents_delete" ON public.frm_documents
+DROP POLICY IF EXISTS "plg_forms_documents_delete" ON public.plg_forms_documents;
+CREATE POLICY "plg_forms_documents_delete" ON public.plg_forms_documents
   FOR DELETE TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
 
--- frm_document_files: file attachments for form fields
-CREATE TABLE public.frm_document_files (
+-- plg_forms_document_files: file attachments for form fields
+CREATE TABLE IF NOT EXISTS public.plg_forms_document_files (
   id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
-  tenant_id uuid NOT NULL REFERENCES saas_core.tenants(id) ON DELETE CASCADE,
-  document_id uuid NOT NULL REFERENCES saas_core.documents(id) ON DELETE CASCADE,
+  tenant_id uuid NOT NULL REFERENCES public.tenants(id) ON DELETE CASCADE,
+  document_id uuid NOT NULL REFERENCES public.documents(id) ON DELETE CASCADE,
   field_key text NOT NULL,
   file_url text NOT NULL,
   file_name text,
@@ -101,23 +139,73 @@ CREATE TABLE public.frm_document_files (
   created_at timestamptz NOT NULL DEFAULT now()
 );
 
-ALTER TABLE public.frm_document_files ENABLE ROW LEVEL SECURITY;
+ALTER TABLE public.plg_forms_document_files ENABLE ROW LEVEL SECURITY;
 
-CREATE INDEX IF NOT EXISTS idx_frm_document_files_document ON public.frm_document_files(document_id);
+CREATE INDEX IF NOT EXISTS idx_plg_forms_document_files_document ON public.plg_forms_document_files(document_id);
 
-CREATE POLICY "frm_document_files_select" ON public.frm_document_files
+DROP POLICY IF EXISTS "plg_forms_document_files_select" ON public.plg_forms_document_files;
+CREATE POLICY "plg_forms_document_files_select" ON public.plg_forms_document_files
   FOR SELECT TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "frm_document_files_insert" ON public.frm_document_files
+DROP POLICY IF EXISTS "plg_forms_document_files_insert" ON public.plg_forms_document_files;
+CREATE POLICY "plg_forms_document_files_insert" ON public.plg_forms_document_files
   FOR INSERT TO authenticated
   WITH CHECK (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "frm_document_files_update" ON public.frm_document_files
+DROP POLICY IF EXISTS "plg_forms_document_files_update" ON public.plg_forms_document_files;
+CREATE POLICY "plg_forms_document_files_update" ON public.plg_forms_document_files
   FOR UPDATE TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
-CREATE POLICY "frm_document_files_delete" ON public.frm_document_files
+DROP POLICY IF EXISTS "plg_forms_document_files_delete" ON public.plg_forms_document_files;
+CREATE POLICY "plg_forms_document_files_delete" ON public.plg_forms_document_files
   FOR DELETE TO authenticated
   USING (tenant_id IN (SELECT public.user_tenant_ids()));
 
+-- Step 3: if legacy rows exist, migrate them, then drop the quarantined legacy
+-- tables. Reusing each legacy id as the documents.id keeps every legacy file's
+-- document_id FK valid after the copy. ON CONFLICT DO NOTHING makes a partial
+-- re-run safe.
+DO $$
+BEGIN
+  IF to_regclass('public.plg_forms_documents_legacy') IS NOT NULL THEN
+    -- 3a. base document (one per legacy form document; is_active mirrors NOT is_deleted)
+    INSERT INTO public.documents (
+      id, tenant_id, kind, person_id, title, status, notes, metadata,
+      is_active, created_by, updated_by, created_at, updated_at
+    )
+    SELECT
+      id, tenant_id, 'form', person_id, title, status, notes, metadata,
+      NOT COALESCE(is_deleted, false), created_by, updated_by, created_at, updated_at
+    FROM public.plg_forms_documents_legacy
+    ON CONFLICT (id) DO NOTHING;
+
+    -- 3b. form extension row (keyed by the reused document id)
+    INSERT INTO public.plg_forms_documents (
+      document_id, tenant_id, template_id, data, signed_at, signed_by, created_at, updated_at
+    )
+    SELECT
+      id, tenant_id, template_id, data, signed_at, signed_by, created_at, updated_at
+    FROM public.plg_forms_documents_legacy
+    ON CONFLICT (document_id) DO NOTHING;
+
+    -- 3c. file attachments (document_id already points at the reused id)
+    IF to_regclass('public.plg_forms_document_files_legacy') IS NOT NULL THEN
+      INSERT INTO public.plg_forms_document_files (
+        id, tenant_id, document_id, field_key, file_url, file_name,
+        file_size, mime_type, sort_order, metadata, created_at
+      )
+      SELECT
+        id, tenant_id, document_id, field_key, file_url, file_name,
+        file_size, mime_type, sort_order, metadata, created_at
+      FROM public.plg_forms_document_files_legacy
+      ON CONFLICT (id) DO NOTHING;
+    END IF;
+  END IF;
+
+  -- Drop legacy remnants now that any data has been copied across.
+  DROP TABLE IF EXISTS public.plg_forms_document_files_legacy;
+  DROP TABLE IF EXISTS public.plg_forms_documents_legacy;
+END $$;
+
 -- View: all documents for a person with form data joined when applicable
 CREATE OR REPLACE VIEW public.v_documents AS
 SELECT
@@ -129,7 +217,7 @@ SELECT
   t.name AS template_name,
   t.category AS template_category,
   p.name AS person_name
-FROM saas_core.documents d
-LEFT JOIN public.frm_documents f ON f.document_id = d.id
-LEFT JOIN public.frm_templates t ON t.id = f.template_id
-LEFT JOIN saas_core.persons p ON p.id = d.person_id;
+FROM public.documents d
+LEFT JOIN public.plg_forms_documents f ON f.document_id = d.id
+LEFT JOIN public.plg_forms_templates t ON t.id = f.template_id
+LEFT JOIN public.people p ON p.id = d.person_id;

package/src/migrations/003_agent_rpcs.sql

@@ -0,0 +1,174 @@
+-- ============================================================================
+-- plugin-forms 003: server-plane agent write RPC.
+--
+-- public.agent_forms_upsert_template — the assistant BUILDS or EDITS a form
+-- template from any surface or channel (in-app FAB, WhatsApp, MCP). Same
+-- contract as every agent_* RPC (agenda 005, financial 009):
+--   (p_tenant_id, p_actor_user_id, p_payload jsonb) → jsonb
+--   {ok:true, id, record:{...}} | {ok:false, denial:{...}} | {ok:false, error}
+--
+-- The grid layout is computed HERE (col 0, sequential rows, full-width span) so
+-- the model only ever sends {type,label,required?,options?} — never positions.
+--
+-- Payload:
+--   template_id?   uuid  — omit to CREATE, provide to EDIT
+--   name?          text  — required on create
+--   category?      text  — anamnesis|evolution|report|contract|general
+--   description?   text
+--   fields?        [{type,label,required?,placeholder?,options?[]}] — REPLACE all
+--   append_fields? [{...}]                                          — APPEND to existing
+--
+-- GRANT authenticated+service_role — NEVER anon (the broker calls with the pool
+-- service key and injects tenant/actor; in-browser the signed-in user calls it
+-- directly and spine RLS/actor guards bind them to their own tenant).
+-- ============================================================================
+
+CREATE OR REPLACE FUNCTION public.agent_forms_upsert_template(
+  p_tenant_id uuid,
+  p_actor_user_id uuid,
+  p_payload jsonb
+) RETURNS jsonb
+LANGUAGE plpgsql SECURITY DEFINER
+SET search_path = public
+AS $$
+DECLARE
+  v_denial jsonb;
+  v_used int;
+  v_template_id uuid;
+  v_is_update boolean;
+  v_name text;
+  v_category text;
+  v_description text;
+  v_existing jsonb;
+  v_input jsonb;
+  v_merged jsonb;
+  v_fields jsonb;
+  v_schema jsonb;
+  v_final_id uuid;
+BEGIN
+  -- ── payload ──────────────────────────────────────────────────────────────
+  BEGIN
+    v_template_id := NULLIF(p_payload->>'template_id','')::uuid;
+  EXCEPTION WHEN OTHERS THEN
+    RETURN jsonb_build_object('ok', false, 'error', 'invalid template_id');
+  END;
+  v_is_update   := v_template_id IS NOT NULL;
+  v_name        := btrim(p_payload->>'name');
+  v_category    := lower(COALESCE(NULLIF(p_payload->>'category',''), 'general'));
+  v_description := left(p_payload->>'description', 1000);
+  IF v_category NOT IN ('anamnesis','evolution','report','contract','general') THEN
+    v_category := 'general';
+  END IF;
+
+  IF NOT v_is_update AND (v_name IS NULL OR v_name = '') THEN
+    RETURN jsonb_build_object('ok', false, 'error', 'name is required to create a form');
+  END IF;
+
+  -- ── authorization: role → plan → form_templates cap ──────────────────────
+  SELECT count(*) INTO v_used FROM plg_forms_templates
+   WHERE tenant_id = p_tenant_id AND is_deleted = false;
+  v_denial := agent_guard(p_tenant_id, p_actor_user_id, 'custom_forms',
+                CASE WHEN v_is_update THEN 'update' ELSE 'create' END,
+                'form_templates', v_used, CASE WHEN v_is_update THEN 0 ELSE 1 END);
+  IF v_denial IS NOT NULL THEN
+    RETURN jsonb_build_object('ok', false, 'denial', v_denial);
+  END IF;
+
+  -- ── current fields (for APPEND / to reject an unknown id) ────────────────
+  IF v_is_update THEN
+    SELECT COALESCE(schema->'fields','[]'::jsonb) INTO v_existing
+    FROM plg_forms_templates
+    WHERE id = v_template_id AND tenant_id = p_tenant_id AND is_deleted = false;
+    IF v_existing IS NULL THEN
+      RETURN jsonb_build_object('ok', false, 'error', 'unknown template for this tenant');
+    END IF;
+  ELSE
+    v_existing := '[]'::jsonb;
+  END IF;
+
+  -- ── normalize the incoming fields to the builder's FormFieldDef shape ────
+  -- (id, type, label, required, placeholder, col, colSpan, options) — row is
+  -- assigned last, across the merged list.
+  WITH src AS (
+    SELECT CASE
+             WHEN p_payload ? 'fields'        THEN COALESCE(p_payload->'fields','[]'::jsonb)
+             WHEN p_payload ? 'append_fields' THEN COALESCE(p_payload->'append_fields','[]'::jsonb)
+             ELSE '[]'::jsonb
+           END AS arr
+  ),
+  norm AS (
+    SELECT f.ord, jsonb_strip_nulls(jsonb_build_object(
+      'id',    COALESCE(NULLIF(f.value->>'id',''), gen_random_uuid()::text),
+      'type',  COALESCE(NULLIF(f.value->>'type',''), 'text'),
+      'label', COALESCE(NULLIF(f.value->>'label',''), 'Campo'),
+      'required', COALESCE((f.value->>'required')::boolean, false),
+      'placeholder', NULLIF(f.value->>'placeholder',''),
+      'col', 0,
+      'colSpan', 12,
+      'options', CASE
+        WHEN jsonb_typeof(f.value->'options') = 'array' AND jsonb_array_length(f.value->'options') > 0
+        THEN (SELECT jsonb_agg(jsonb_build_object(
+                'label', opt,
+                'value', lower(regexp_replace(btrim(opt), '\s+', '_', 'g'))))
+              FROM jsonb_array_elements_text(f.value->'options') opt)
+        ELSE NULL END
+    )) AS field
+    FROM src, jsonb_array_elements(src.arr) WITH ORDINALITY AS f(value, ord)
+  )
+  SELECT COALESCE(jsonb_agg(field ORDER BY ord), '[]'::jsonb) INTO v_input FROM norm;
+
+  -- REPLACE with `fields`; otherwise APPEND onto what's already there.
+  IF p_payload ? 'fields' THEN
+    v_merged := v_input;
+  ELSE
+    v_merged := v_existing || v_input;
+  END IF;
+
+  -- sequential rows across the final list
+  SELECT COALESCE(jsonb_agg(jsonb_set(e.value, '{row}', to_jsonb((e.ord - 1))) ORDER BY e.ord), '[]'::jsonb)
+    INTO v_fields
+  FROM jsonb_array_elements(v_merged) WITH ORDINALITY AS e(value, ord);
+
+  v_schema := jsonb_build_object('layout', jsonb_build_object('columns', 12), 'fields', v_fields);
+
+  -- ── write + audit ────────────────────────────────────────────────────────
+  IF v_is_update THEN
+    UPDATE plg_forms_templates SET
+      name        = COALESCE(NULLIF(v_name,''), name),
+      category    = v_category,
+      description = COALESCE(v_description, description),
+      schema      = v_schema,
+      updated_by  = p_actor_user_id,
+      updated_at  = now()
+    WHERE id = v_template_id AND tenant_id = p_tenant_id AND is_deleted = false
+    RETURNING id INTO v_final_id;
+  ELSE
+    INSERT INTO plg_forms_templates (tenant_id, name, category, description, schema, created_by, updated_by)
+    VALUES (p_tenant_id, v_name, v_category, v_description, v_schema, p_actor_user_id, p_actor_user_id)
+    RETURNING id INTO v_final_id;
+  END IF;
+
+  INSERT INTO audit_logs (tenant_id, user_id, action, entity_type, entity_id, metadata)
+  VALUES (p_tenant_id, p_actor_user_id,
+          CASE WHEN v_is_update THEN 'agent.updateFormTemplate' ELSE 'agent.createFormTemplate' END,
+          'form_template', v_final_id::text,
+          jsonb_build_object('payload', p_payload));
+
+  RETURN jsonb_build_object(
+    'ok', true,
+    'id', v_final_id,
+    'record', jsonb_build_object(
+      'ref', jsonb_build_object('id', v_final_id, 'resource', 'plg_forms_templates',
+                                'archetype', 'custom_forms:template'),
+      'name', COALESCE(NULLIF(v_name,''), (SELECT name FROM plg_forms_templates WHERE id = v_final_id)),
+      'category', v_category,
+      'fieldCount', jsonb_array_length(v_fields)
+    )
+  );
+END;
+$$;
+
+REVOKE ALL ON FUNCTION public.agent_forms_upsert_template(uuid, uuid, jsonb) FROM public;
+REVOKE EXECUTE ON FUNCTION public.agent_forms_upsert_template(uuid, uuid, jsonb) FROM anon;
+GRANT EXECUTE ON FUNCTION public.agent_forms_upsert_template(uuid, uuid, jsonb)
+  TO authenticated, service_role;