@faststore/core 2.2.37 → 2.2.39

package/.turbo/turbo-test.log

@@ -1,25 +1,25 @@
 $ tsdx test
 ts-jest[versions] (WARN) Version 29.1.0 of jest installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=25.0.0 <26.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
 ts-jest[versions] (WARN) Version 4.9.4 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=3.4.0 <4.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
-PASS test/server/index.test.ts (12.693s)
+PASS test/server/index.test.ts (6.103s)
   FastStore GraphQL Layer
     @faststore/api
       ✓ should return a valid GraphQL schema (5ms)
-      ✓ should return a valid GraphQL schema contain all expected types (4ms)
+      ✓ should return a valid GraphQL schema contain all expected types (11ms)
       ✓ should return a valid GraphQL schema contain all expected queries (1ms)
-      ✓ should return a valid GraphQL schema contain all expected mutations (1ms)
+      ✓ should return a valid GraphQL schema contain all expected mutations
     VTEX API Extension
       ✓ getTypeDefsFromFolder function should return an Array (6ms)
     Third Party API Extension
-      ✓ getTypeDefsFromFolder function should return an Array (9ms)
+      ✓ getTypeDefsFromFolder function should return an Array (5ms)
     Final Schema after merging
       ✓ should return a valid merged GraphQL schema (26ms)
     Envelop
-      ✓ should exist with its plugins (26ms)
-      ✓ should handle options and execute (141ms)
+      ✓ should exist with its plugins (25ms)
+      ✓ should handle options and execute (340ms)
 
 Test Suites: 1 passed, 1 total
 Tests:       9 passed, 9 total
 Snapshots:   0 total
-Time:        13.33s
+Time:        6.529s
 Ran all test suites.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@faststore/core",
-  "version": "2.2.37",
+  "version": "2.2.39",
   "license": "MIT",
   "repository": "vtex/faststore",
   "browserslist": "supports es6-module and not dead",
@@ -37,11 +37,11 @@
     "@envelop/graphql-jit": "^1.1.1",
     "@envelop/parser-cache": "^2.2.0",
     "@envelop/validation-cache": "^2.2.0",
-    "@faststore/api": "^2.2.36",
-    "@faststore/components": "^2.2.37",
-    "@faststore/graphql-utils": "^2.2.36",
-    "@faststore/sdk": "^2.2.35",
-    "@faststore/ui": "^2.2.37",
+    "@faststore/api": "^2.2.38",
+    "@faststore/components": "^2.2.38",
+    "@faststore/graphql-utils": "^2.2.38",
+    "@faststore/sdk": "^2.2.38",
+    "@faststore/ui": "^2.2.38",
     "@graphql-codegen/cli": "^3.3.1",
     "@graphql-codegen/typescript": "^3.0.4",
     "@graphql-codegen/typescript-operations": "^3.0.4",
@@ -78,8 +78,8 @@
   "devDependencies": {
     "@cypress/code-coverage": "^3.12.1",
     "@envelop/testing": "^6.0.0",
-    "@faststore/cli": "^2.2.36",
-    "@faststore/eslint-config": "^2.2.36",
+    "@faststore/cli": "^2.2.38",
+    "@faststore/eslint-config": "^2.2.38",
     "@faststore/lighthouse": "^1.12.32",
     "@lhci/cli": "^0.9.0",
     "@testing-library/cypress": "^10.0.1",
@@ -119,5 +119,5 @@
   "msw": {
     "workerDirectory": "public"
   },
-  "gitHead": "f82966c103d0c3ed9e7a89944878ad9eb6a919c1"
+  "gitHead": "6d758aec1c4e6cd3f4bc48a3f69457f9f577d527"
 }

package/src/components/ui/ProductGallery/ProductGallery.tsx

@@ -91,8 +91,8 @@ function ProductGallery({
   useProductsPrefetch(prev ? prev.cursor : null)
   useProductsPrefetch(next ? next.cursor : null)
 
-  const hasFacets =
-    Boolean(data?.search?.facets) && data.search.facets.length > 0
+  const hasFacetsLoaded = Boolean(data?.search?.facets)
+  const hasProductsLoaded = Boolean(data?.search?.products)
 
   return (
     <section data-testid="product-gallery" data-fs-product-listing>
@@ -111,8 +111,10 @@ function ProductGallery({
         data-fs-content="product-gallery"
       >
         <div data-fs-product-listing-filters>
-          <FilterSkeleton loading={facets?.length === 0}>
-            <Filter facets={facets} filter={filter} />
+          <FilterSkeleton loading={!hasFacetsLoaded}>
+            {hasFacetsLoaded && facets?.length > 0 && (
+              <Filter facets={facets} filter={filter} />
+            )}
           </FilterSkeleton>
         </div>
         <div data-fs-product-listing-results-count data-count={totalCount}>
@@ -122,7 +124,7 @@ function ProductGallery({
             {...ResultsCountSkeleton.props}
             // Dynamic props shouldn't be overridable
             // This decision can be reviewed later if needed
-            loading={!data?.search}
+            loading={!hasProductsLoaded}
           >
             <h2 data-testid="total-product-count">
               {totalCount} {totalCountLabel}
@@ -136,7 +138,7 @@ function ProductGallery({
             {...SortSkeleton.props}
             // Dynamic props shouldn't be overridable
             // This decision can be reviewed later if needed
-            loading={facets?.length === 0}
+            loading={!hasProductsLoaded}
           >
             <Sort
               label={sortBySelector?.label}
@@ -149,34 +151,36 @@ function ProductGallery({
             {...FilterButtonSkeleton.props}
             // Dynamic props shouldn't be overridable
             // This decision can be reviewed later if needed
-            loading={facets?.length === 0}
+            loading={!hasFacetsLoaded}
           >
-            <MobileFilterButton.Component
-              variant="tertiary"
-              data-testid="open-filter-button"
-              icon={
-                <FilterIcon.Component
-                  width={16}
-                  height={16}
-                  {...FilterIcon.props}
-                  name={
-                    filter?.mobileOnly?.filterButton?.icon?.icon ??
-                    FilterIcon.props.name
-                  }
-                  aria-label={
-                    filter?.mobileOnly?.filterButton?.icon?.alt ??
-                    FilterIcon.props['aria-label']
-                  }
-                />
-              }
-              iconPosition="left"
-              {...MobileFilterButton.props}
-              // Dynamic props shouldn't be overridable
-              // This decision can be reviewed later if needed
-              onClick={openFilter}
-            >
-              {filter?.mobileOnly?.filterButton?.label}
-            </MobileFilterButton.Component>
+            {hasFacetsLoaded && facets?.length > 0 && (
+              <MobileFilterButton.Component
+                variant="tertiary"
+                data-testid="open-filter-button"
+                icon={
+                  <FilterIcon.Component
+                    width={16}
+                    height={16}
+                    {...FilterIcon.props}
+                    name={
+                      filter?.mobileOnly?.filterButton?.icon?.icon ??
+                      FilterIcon.props.name
+                    }
+                    aria-label={
+                      filter?.mobileOnly?.filterButton?.icon?.alt ??
+                      FilterIcon.props['aria-label']
+                    }
+                  />
+                }
+                iconPosition="left"
+                {...MobileFilterButton.props}
+                // Dynamic props shouldn't be overridable
+                // This decision can be reviewed later if needed
+                onClick={openFilter}
+              >
+                {filter?.mobileOnly?.filterButton?.label}
+              </MobileFilterButton.Component>
+            )}
           </FilterButtonSkeleton.Component>
         </div>
         <div data-fs-product-listing-results>
@@ -219,7 +223,7 @@ function ProductGallery({
             </div>
           )}
           {/* Render ALL products */}
-          {hasFacets ? (
+          {hasProductsLoaded ? (
             <Suspense fallback={GalleryPageSkeleton}>
               {pages.map((page) => (
                 <ProductGalleryPage

package/.next/BUILD_ID

@@ -1 +0,0 @@
-pVGOsmYTXFPMzLlXhIM3h

package/.next/build-manifest.json

@@ -1,126 +0,0 @@
-{
-  "polyfillFiles": [
-    "static/chunks/polyfills-c67a75d1b6f99dc8.js"
-  ],
-  "devFiles": [],
-  "ampDevFiles": [],
-  "lowPriorityFiles": [
-    "static/pVGOsmYTXFPMzLlXhIM3h/_buildManifest.js",
-    "static/pVGOsmYTXFPMzLlXhIM3h/_ssgManifest.js"
-  ],
-  "rootMainFiles": [],
-  "pages": {
-    "/": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/css/dfbdb0f27fd64782.css",
-      "static/chunks/783-fbcb7a3216c40744.js",
-      "static/css/a2eefb25a4608343.css",
-      "static/chunks/pages/index-4767c1028f4df135.js"
-    ],
-    "/404": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/css/df588bb98c0b0ca6.css",
-      "static/chunks/pages/404-6763ce07878a1456.js"
-    ],
-    "/500": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/css/df588bb98c0b0ca6.css",
-      "static/chunks/pages/500-0f4374f30595d27c.js"
-    ],
-    "/[...slug]": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/css/dfbdb0f27fd64782.css",
-      "static/chunks/783-fbcb7a3216c40744.js",
-      "static/css/723835bce380750d.css",
-      "static/chunks/400-8a0173291a21a213.js",
-      "static/css/a2eefb25a4608343.css",
-      "static/css/527e334fa69cf40a.css",
-      "static/chunks/pages/[...slug]-a81fd568b3032a9e.js"
-    ],
-    "/[slug]/p": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/css/dfbdb0f27fd64782.css",
-      "static/chunks/783-fbcb7a3216c40744.js",
-      "static/css/d7bbfbd552f407e9.css",
-      "static/chunks/pages/[slug]/p-46e7cb105136dc7a.js"
-    ],
-    "/_app": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/css/5d1f64b61ea581f4.css",
-      "static/chunks/pages/_app-fea7ed14d8f4d0c6.js"
-    ],
-    "/_error": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/pages/_error-a7a0c1d9bfbb4f38.js"
-    ],
-    "/account": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/chunks/pages/account-9eb6fab139286c66.js"
-    ],
-    "/checkout": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/chunks/pages/checkout-7cd7b110c7cf2f10.js"
-    ],
-    "/login": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/css/df588bb98c0b0ca6.css",
-      "static/chunks/pages/login-5fd09e6402f47896.js"
-    ],
-    "/s": [
-      "static/chunks/webpack-4ccaf6613cbd7224.js",
-      "static/chunks/framework-dfd14d7ce6600b03.js",
-      "static/chunks/main-e4e873ee741162eb.js",
-      "static/chunks/742-e32d18d91fe6f08b.js",
-      "static/css/29868543c76bc6fd.css",
-      "static/chunks/469-7259b855711d4ad3.js",
-      "static/css/723835bce380750d.css",
-      "static/chunks/400-8a0173291a21a213.js",
-      "static/chunks/pages/s-8e32a9b170819fa9.js"
-    ]
-  },
-  "ampFirstPages": []
-}