@faststore/core 2.1.95 → 2.1.98

package/.turbo/turbo-build.log

@@ -1,16 +1,10 @@
 $ yarn partytown && next build
 $ partytown copylib ./public/~partytown
-Partytown lib copied to: /home/runner/work/faststore/faststore/packages/core/public/~partytown
-warn  - No build cache found. Please configure build caching for faster rebuilds. Read more: https://nextjs.org/docs/messages/no-cache
-Attention: Next.js now collects completely anonymous telemetry regarding usage.
-This information is used to shape Next.js' roadmap and prioritize features.
-You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
-https://nextjs.org/telemetry
-
+Partytown lib copied to: /Users/emersonlaurentino/develop/vtex/faststore/packages/core/public/~partytown
 info  - Linting and checking validity of types...
 info  - Creating an optimized production build...
 info  - Disabled SWC as replacement for Babel because of custom Babel configuration ".babelrc" https://nextjs.org/docs/messages/swc-disabled
-info  - Using external babel configuration from /home/runner/work/faststore/faststore/packages/core/.babelrc
+info  - Using external babel configuration from /Users/emersonlaurentino/develop/vtex/faststore/packages/core/.babelrc
 info  - Compiled successfully
 info  - Collecting page data...
 info  - Generating static pages (0/7)
@@ -40,8 +34,8 @@ Route (pages)                              Size     First Load JS
 + First Load JS shared by all              81 kB
   ├ chunks/framework-dfd14d7ce6600b03.js   45.3 kB
   ├ chunks/main-fd466221927468fd.js        23.9 kB
-  ├ chunks/pages/_app-6d0e6ab9a4dd8106.js  6.45 kB
-  ├ chunks/webpack-6580be4a27ecdd75.js     2.29 kB
+  ├ chunks/pages/_app-40cff0982559d0b8.js  6.46 kB
+  ├ chunks/webpack-34aa83cb25f3f792.js     2.29 kB
   └ css/9e76fef1c9ca89af.css               3.06 kB
 
 λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)

package/README.md

@@ -100,7 +100,7 @@ A quick look at the top-level files and directories you'll see in a NextJS proje
     ├── __generated__
     ├── babel.config.js
     ├── cypress
-    ├── cypress.json
+    ├── cypress.config.ts
     ├── lighthouserc.js
     ├── public
     ├── pull_request_template.md
@@ -136,7 +136,7 @@ A quick look at the top-level files and directories you'll see in a NextJS proje
 
 15. **`cypress`**: End to End(e2e) tests using Cypress. Most of the scenarios are covered here. Add your custom flows to avoid regressions
 
-16. **`cypress.json`**: [Cypress configuration file](https://docs.cypress.io/guides/references/configuration)
+16. **`cypress.config.ts`**: [Cypress configuration file](https://docs.cypress.io/guides/references/configuration)
 
 17. **`lighthouserc.js`**: Configures [Google Lighthouse CI](https://github.com/GoogleChrome/lighthouse-ci). This is where you can turn on/off lighthouse assertions to be used by Lighthouse CI Bot/hook
 
@@ -412,7 +412,7 @@ Looking for more guidance? Full documentation for FastStore lives [on this GitHu
 
 ## ⚡ Performance & QA
 
-This project has strict performance budgets. Right out of the box, this project performs around 95 on Google's Page Speed Insights website, which usually is way more strict than your laptop's chrome lighthouse. Every time you commit to the repository, our QA bots will run and evaluate your code quality. We recommend you NEVER put in production a code that breaks any of the bots. If a bot breaks and still you need to put the code into production, change the bot config (`lighthouserc.js`, `cypress.json`) to make it pass and merge. This way you ensure your website will keep performing well during the years to come.
+This project has strict performance budgets. Right out of the box, this project performs around 95 on Google's Page Speed Insights website, which usually is way more strict than your laptop's chrome lighthouse. Every time you commit to the repository, our QA bots will run and evaluate your code quality. We recommend you NEVER put in production a code that breaks any of the bots. If a bot breaks and still you need to put the code into production, change the bot config (`lighthouserc.js`, `cypress.config.ts`) to make it pass and merge. This way you ensure your website will keep performing well during the years to come.
 
 ## Adding third party scripts
 

package/cypress/global.js

@@ -13,3 +13,11 @@ export const options = {
     }
   },
 }
+
+// TODO: Bring back these rules when the components with missing/wrong role is found.
+export const disabledA11yRules = {
+  rules: {
+    region: { enabled: false },
+    'aria-allowed-role': { enabled: false },
+  },
+}

package/cypress/integration/a11y.test.js

@@ -4,6 +4,7 @@
  * Cypress tests for a11y (accessibility)
  */
 
+import { disabledA11yRules } from '../global'
 import { cypress } from '../../faststore.config'
 
 const { pages } = cypress
@@ -13,7 +14,7 @@ describe('Accessibility tests', () => {
     cy.clearIDB()
   })
 
-  it.skip('checks a11y for collection page', () => {
+  it('checks a11y for collection page', () => {
     cy.visit(pages.collection)
     cy.waitForHydration()
 
@@ -21,16 +22,10 @@ describe('Accessibility tests', () => {
     cy.getById('product-link').should('exist')
 
     cy.injectAxe()
-
-    // TODO: Bring back the `aria-allowed-role` when the component with the missing/wrong role is found.
-    cy.checkA11y(null, {
-      rules: {
-        'aria-allowed-role': { enabled: false },
-      },
-    })
+    cy.checkA11y(null, disabledA11yRules)
   })
 
-  it.skip('checks a11y for product page', () => {
+  it('checks a11y for product page', () => {
     cy.visit(pages.pdp)
     cy.waitForHydration()
 
@@ -38,26 +33,14 @@ describe('Accessibility tests', () => {
     cy.getById('buy-button').should('exist')
 
     cy.injectAxe()
-
-    // TODO: Bring back the `aria-allowed-role` when the component with the missing/wrong role is found.
-    cy.checkA11y(null, {
-      rules: {
-        'aria-allowed-role': { enabled: false },
-      },
-    })
+    cy.checkA11y(null, disabledA11yRules)
   })
 
-  it.skip('checks a11y for home page', () => {
+  it('checks a11y for home page', () => {
     cy.visit(pages.home)
     cy.waitForHydration()
 
     cy.injectAxe()
-
-    // TODO: Bring back the `aria-allowed-role` when the component with the missing/wrong role is found.
-    cy.checkA11y(null, {
-      rules: {
-        'aria-allowed-role': { enabled: false },
-      },
-    })
+    cy.checkA11y(null, disabledA11yRules)
   })
 })

package/cypress/integration/analytics.test.js

@@ -65,68 +65,60 @@ describe('add_to_cart event', () => {
   }
 
   context('when adding a product to the cart', () => {
-    it.skip('adds add_to_cart event in the data layer at product description page', () => {
+    it('adds add_to_cart event in the data layer at product description page', () => {
       cy.visit(pages.pdp, options)
       cy.waitForHydration()
 
       cy.itemsInCart(0)
 
       // Add to cart
-      cy.getById('buy-button')
-        .should('be.visible')
-        .scrollIntoView({ duration: 500 })
-        .then(() => {
-          cy.getById('buy-button')
-            .click({ force: true })
-            .then(($btn) => {
-              cy.itemsInCart(1)
-              const skuId = $btn.attr('data-sku')
-
-              testAddToCartEvent({ skuId, numberOfEvents: 1 })
-            })
+      cy.getById('buy-button').as('buy-button')
+      cy.get('@buy-button').contains('Add to Cart').and('be.visible')
+      cy.get('@buy-button')
+        .trigger('click', { force: true, cancelable: false })
+        .then(($btn) => {
+          cy.itemsInCart(1)
+
+          const skuId = $btn.attr('data-sku')
+          testAddToCartEvent({ skuId, numberOfEvents: 1 })
         })
     })
   })
 
   context('when increasing product quantity', () => {
-    it.skip('adds add_to_cart event in the data layer at quantity increase in the minicart', () => {
+    it('adds add_to_cart event in the data layer at quantity increase in the minicart', () => {
       cy.visit(pages.pdp, options)
       cy.waitForHydration()
 
       cy.itemsInCart(0)
 
       // Add to cart
-      cy.getById('buy-button')
-        .should('be.visible')
-        .scrollIntoView({ duration: 500 })
-        .then(() => {
-          cy.getById('buy-button')
-            .click({ force: true })
-            .then(($btn) => {
-              cy.itemsInCart(1)
-              const skuId = $btn.attr('data-sku')
+      cy.getById('buy-button').as('buy-button')
+      cy.get('@buy-button').contains('Add to Cart').and('be.visible')
+      cy.get('@buy-button')
+        .trigger('click', { force: true, cancelable: false })
+        .then(($btn) => {
+          cy.itemsInCart(1)
+          const skuId = $btn.attr('data-sku')
+
+          testAddToCartEvent({ skuId, numberOfEvents: 1 })
+        })
 
-              testAddToCartEvent({ skuId, numberOfEvents: 1 })
+      cy.get(
+        '[data-testid=fs-cart-item] [data-testid=fs-quantity-selector-right-button]'
+      ).trigger('click', { force: true, cancelable: false })
 
-              cy.get(
-                '[data-testid=fs-cart-item] [data-testid=fs-quantity-selector-right-button]'
-              )
-                .click()
-                .then(() => {
-                  cy.itemsInCart(2)
+      cy.get('@buy-button').then(($btn) => {
+        cy.itemsInCart(2)
+        const skuId = $btn.attr('data-sku')
 
-                  testAddToCartEvent({ skuId, numberOfEvents: 2 })
-                })
-            })
-        })
+        testAddToCartEvent({ skuId, numberOfEvents: 2 })
+      })
     })
   })
 })
 
 describe('remove_from_cart event', () => {
-  beforeEach(() => {
-    cy.clearIDB()
-  })
   const testRemoveFromCartEvent = ({ skuId, numberOfEvents, quantity }) => {
     cy.window().then((window) => {
       const { dataLayer } = window
@@ -152,46 +144,41 @@ describe('remove_from_cart event', () => {
   }
 
   context('when removing a product from cart', () => {
-    it.skip('adds remove_from_cart event in the data layer', () => {
+    it('adds remove_from_cart event in the data layer', () => {
       cy.visit(pages.pdp, options)
       cy.waitForHydration()
 
       cy.itemsInCart(0)
 
       // Add item to cart
-      cy.getById('buy-button')
-        .should('be.visible')
-        .scrollIntoView({ duration: 500 })
-        .then(() => {
-          cy.getById('buy-button')
-            .click({ force: true })
-            .then(() => {
-              cy.itemsInCart(1)
-              cy.getById('checkout-button')
-                .should('be.visible')
-                .should('be.enabled')
-              cy.itemsInCart(1)
+      cy.getById('buy-button').as('buy-button')
+      cy.get('@buy-button').contains('Add to Cart').should('be.visible')
+      cy.get('@buy-button').trigger('click')
 
-              // Remove the added item
-              cy.getById('remove-from-cart-button')
-                .click({ force: true })
-                .then(($btn) => {
-                  cy.itemsInCart(0)
-                  const skuId = $btn.attr('data-sku')
+      cy.getById('fs-cart-sidebar').should('be.visible')
 
-                  testRemoveFromCartEvent({
-                    skuId,
-                    numberOfEvents: 1,
-                    quantity: 1,
-                  })
-                })
-            })
+      cy.itemsInCart(1)
+
+      // Remove the added item
+      cy.getById('remove-from-cart-button').as('remove-from-cart-button')
+      cy.get('@remove-from-cart-button')
+        .click({ force: true })
+        .then(($btn) => {
+          cy.itemsInCart(0)
+
+          const skuId = $btn.attr('data-sku')
+
+          testRemoveFromCartEvent({
+            skuId,
+            quantity: 1,
+            numberOfEvents: 1,
+          })
         })
     })
   })
 
   context('when decreasing product quantity', () => {
-    it.skip('adds remove_from_cart event in the data layer at quantity decrease in the minicart', () => {
+    it('adds remove_from_cart event in the data layer at quantity decrease in the minicart', () => {
       cy.visit(pages.pdp, options)
       cy.waitForHydration()
 
@@ -238,7 +225,7 @@ describe('remove_from_cart event', () => {
 })
 
 describe('view_item event', () => {
-  it.skip('add view_item event in data layer', () => {
+  it('add view_item event in data layer', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -253,7 +240,7 @@ describe('view_item event', () => {
 })
 
 describe('select_item event', () => {
-  it.skip('select_item has the right properties', () => {
+  it('select_item has the right properties', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -284,7 +271,7 @@ describe('select_item event', () => {
 })
 
 describe('view_item_list event', () => {
-  it.skip('is sent when viewing the PLP', () => {
+  it('is sent when viewing the PLP', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -306,7 +293,7 @@ describe('view_item_list event', () => {
     })
   })
 
-  it.skip('is sent when viewing a products shelf', () => {
+  it('is sent when viewing a products shelf', () => {
     cy.visit(pages.home, options)
     cy.waitForHydration()
 
@@ -325,7 +312,7 @@ describe('view_item_list event', () => {
       })
   })
 
-  it.skip('is sent when viewing a product tiles', () => {
+  it('is sent when viewing a product tiles', () => {
     cy.visit(pages.home, options)
     cy.waitForHydration()
 
@@ -346,7 +333,7 @@ describe('view_item_list event', () => {
 })
 
 describe('search event', () => {
-  it.skip('raises search', () => {
+  it('raises search', () => {
     cy.visit(pages.home, options)
     cy.waitForHydration()
 
@@ -366,7 +353,7 @@ describe('search event', () => {
 })
 
 describe('view_cart event', () => {
-  it.skip('is fired when the minicart is opened (without items)', () => {
+  it('is fired when the minicart is opened (without items)', () => {
     cy.visit(pages.pdp, options)
     cy.waitForHydration()
 
@@ -375,6 +362,8 @@ describe('view_cart event', () => {
 
     dataLayerHasEvent('view_cart')
 
+    cy.itemsInCart(0)
+
     cy.window().then((window) => {
       const event = window.dataLayer.find(
         ({ event: eventName }) => eventName === 'view_cart'
@@ -385,27 +374,29 @@ describe('view_cart event', () => {
     })
   })
 
-  it.skip('is fired when the minicart is opened (with items)', () => {
+  it('is fired when the minicart is opened (with items)', () => {
     cy.visit(pages.pdp, options)
     cy.waitForHydration()
 
-    cy.getById('buy-button')
-      .should('be.visible')
-      .scrollIntoView({ duration: 500 })
-      .then(() => {
-        cy.getById('buy-button').click({ force: true })
-        cy.getById('fs-cart-sidebar').should('be.visible')
+    cy.itemsInCart(0)
 
-        dataLayerHasEvent('view_cart')
+    cy.getById('buy-button').as('buy-button')
+    cy.get('@buy-button').contains('Add to Cart').should('be.visible')
+    cy.get('@buy-button').trigger('click', { force: true, cancelable: false })
 
-        cy.window().then((window) => {
-          const event = window.dataLayer.find(
-            ({ event: eventName }) => eventName === 'view_cart'
-          )
+    cy.getById('fs-cart-sidebar').should('be.visible')
 
-          expect(event.ecommerce.value).to.equal(950)
-          expect(event.ecommerce.items.length).to.equal(1)
-        })
-      })
+    dataLayerHasEvent('view_cart')
+
+    cy.itemsInCart(1)
+
+    cy.window().then((window) => {
+      const event = window.dataLayer.find(
+        ({ event: eventName }) => eventName === 'view_cart'
+      )
+
+      expect(event.ecommerce.value).to.equal(950)
+      expect(event.ecommerce.items.length).to.equal(1)
+    })
   })
 })

package/cypress/integration/cart.test.js

@@ -14,7 +14,7 @@ describe('Cart Sidebar', () => {
     cy.clearIDB()
   })
 
-  it.skip('toggles cart sidebar', () => {
+  it('toggles cart sidebar', () => {
     cy.visit(pages.home, options)
     cy.waitForHydration()
 
@@ -25,7 +25,7 @@ describe('Cart Sidebar', () => {
   })
 
   context('when opening the cart sidebar', () => {
-    it.skip('should not scroll the background page', () => {
+    it('should not scroll the background page', () => {
       cy.visit(pages.home, options)
       cy.waitForHydration()
 
@@ -49,7 +49,7 @@ describe('On product description pages', () => {
   })
 
   context('when adding a product to cart', () => {
-    it.skip('successfully adds the product', () => {
+    it('successfully adds the product', () => {
       cy.visit(pages.pdp, options)
       cy.waitForHydration()
 
@@ -85,7 +85,7 @@ describe('On product description pages', () => {
   })
 
   context('when removing a product from cart', () => {
-    it.skip('successfully removes the product', () => {
+    it('successfully removes the product', () => {
       cy.visit(pages.pdp, options)
       cy.waitForHydration()
 

package/cypress/integration/plp.test.js

@@ -14,7 +14,7 @@ describe('Search page Filters and Sorting options', () => {
     cy.clearIDB()
   })
 
-  it.skip('Applies filters after click', () => {
+  it('Applies filters after click', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -56,7 +56,7 @@ describe('Search page Filters and Sorting options', () => {
       })
   })
 
-  it.skip('Sort products by price_asc', () => {
+  it('Sort products by price_asc', () => {
     cy.visit(pages.collection_2, options)
     cy.waitForHydration()
 
@@ -81,7 +81,7 @@ describe('Search page Filters and Sorting options', () => {
     })
   })
 
-  it.skip('Sort products by price_desc', () => {
+  it('Sort products by price_desc', () => {
     cy.visit(pages.collection_2, options)
     cy.waitForHydration()
     const priceId = '[data-fs-product-grid] [data-testid="price"]'
@@ -111,7 +111,7 @@ describe('Infinite Scroll pagination', () => {
     cy.clearIDB()
   })
 
-  it.skip('Shows more products when requested', () => {
+  it('Shows more products when requested', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -138,7 +138,7 @@ describe('Infinite Scroll pagination', () => {
     })
   })
 
-  it.skip('Sticks to last seen page on plp pagination', () => {
+  it('Sticks to last seen page on plp pagination', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -209,7 +209,7 @@ describe('Infinite Scroll pagination', () => {
   })
 
   // Tests: https://developers.google.com/search/blog/2014/02/infinite-scroll-search-friendly
-  it.skip('Changes the page being viewed on scroll', () => {
+  it('Changes the page being viewed on scroll', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 

package/cypress/integration/search.test.js

@@ -15,7 +15,7 @@ describe('Search input', () => {
   })
 
   context('when search for generic term', () => {
-    it.skip('opens the search page', () => {
+    it('opens the search page', () => {
       const term = 'shirt'
 
       cy.visit(pages.home, options)

package/cypress/integration/seo.test.js

@@ -16,7 +16,7 @@ describe('Home Page Seo', () => {
     cy.clearIDB()
   })
 
-  it.skip('has meta/canonical/link tags', () => {
+  it('has meta/canonical/link tags', () => {
     cy.visit(pages.home, options)
     cy.waitForHydration()
 
@@ -34,7 +34,7 @@ describe('Home Page Seo', () => {
       })
   })
 
-  it.skip('has structured data', () => {
+  it('has structured data', () => {
     cy.visit(pages.home, options)
     cy.waitForHydration()
 
@@ -48,7 +48,7 @@ describe('Home Page Seo', () => {
       })
   })
 
-  it.skip('has OpenGraph tags', () => {
+  it('has OpenGraph tags', () => {
     cy.visit(pages.home, options)
     cy.waitForHydration()
 
@@ -77,7 +77,7 @@ describe('Product Page Seo', () => {
     cy.clearIDB()
   })
 
-  it.skip('has meta/canonical/link tags', () => {
+  it('has meta/canonical/link tags', () => {
     cy.visit(pages.pdp, options)
     cy.waitForHydration()
 
@@ -95,7 +95,7 @@ describe('Product Page Seo', () => {
       })
   })
 
-  it.skip('has structured data', () => {
+  it('has structured data', () => {
     cy.visit(pages.pdp, options)
     cy.waitForHydration()
 
@@ -115,7 +115,7 @@ describe('Product Page Seo', () => {
       })
   })
 
-  it.skip('has OpenGraph tags', () => {
+  it('has OpenGraph tags', () => {
     cy.visit(pages.pdp, options)
     cy.waitForHydration()
 
@@ -162,7 +162,7 @@ describe('Collection Page Seo', () => {
     cy.clearIDB()
   })
 
-  it.skip('has meta/canonical/link tags', () => {
+  it('has meta/canonical/link tags', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -182,7 +182,7 @@ describe('Collection Page Seo', () => {
       })
   })
 
-  it.skip('has structured data', () => {
+  it('has structured data', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -201,7 +201,7 @@ describe('Collection Page Seo', () => {
       })
   })
 
-  it.skip('has OpenGraph tags', () => {
+  it('has OpenGraph tags', () => {
     cy.visit(pages.collection, options)
     cy.waitForHydration()
 
@@ -226,7 +226,7 @@ describe('Collection Page Seo', () => {
 })
 
 describe('Filtered Collection Page Seo', () => {
-  it.skip('has canonical pointing to parent url', () => {
+  it('has canonical pointing to parent url', () => {
     cy.visit(pages.collection_filtered, options)
     cy.waitForHydration()
 
@@ -239,7 +239,7 @@ describe('Filtered Collection Page Seo', () => {
       })
   })
 
-  it.skip('has structured data', () => {
+  it('has structured data', () => {
     cy.visit(pages.collection_filtered, options)
     cy.waitForHydration()
 
@@ -258,7 +258,7 @@ describe('Filtered Collection Page Seo', () => {
       })
   })
 
-  it.skip('has OpenGraph tags', () => {
+  it('has OpenGraph tags', () => {
     cy.visit(pages.collection_filtered, options)
     cy.waitForHydration()
 
@@ -283,7 +283,7 @@ describe('Filtered Collection Page Seo', () => {
 })
 
 describe('Search Page Seo', () => {
-  it.skip('has meta/canonical/link tags', () => {
+  it('has meta/canonical/link tags', () => {
     cy.visit(pages.search, options)
     cy.waitForHydration()
 
@@ -297,7 +297,7 @@ describe('Search Page Seo', () => {
     cy.get('link[rel="canonical"]').should('not.exist')
   })
 
-  it.skip('has OpenGraph tags', () => {
+  it('has OpenGraph tags', () => {
     cy.visit(pages.search, options)
     cy.waitForHydration()
 

package/cypress.config.ts

@@ -0,0 +1,19 @@
+import { defineConfig } from 'cypress'
+
+export default defineConfig({
+  retries: 0,
+  video: true,
+  trashAssetsBeforeRuns: true,
+  screenshotOnRunFailure: true,
+  viewportWidth: 1000,
+  viewportHeight: 600,
+  e2e: {
+    supportFile: 'cypress/support/index.js',
+    specPattern: 'cypress/integration/**/*.test.{js,jsx,ts,tsx}',
+    setupNodeEvents(on, config) {
+      return require('cypress/plugins/index.js')(on, config)
+    },
+    baseUrl: 'http://localhost:3000/',
+    experimentalRunAllSpecs: true,
+  },
+})

package/faststore.config.js

@@ -89,6 +89,7 @@ module.exports = {
   },
 
   experimental: {
+    cypressVersion: 12,
     enableCypressExtension: false,
   },
 }