@faststore/api 4.7.0-dev.7 → 4.7.0-dev.9

package/src/platforms/vtex/resolvers/product.ts

@@ -77,7 +77,15 @@ export async function getLocalizedProductEntry(
         categories: result.categories ?? [],
         availableLinkIds: result.availableLinkIds ?? {},
       }
-    } catch {
+    } catch (err) {
+      // Without this the fallback is silent: the breadcrumb renders the IS
+      // category names, always in the default language, and the page can be
+      // frozen in that state by `revalidate: false`.
+      console.warn(
+        `[getLocalizedProductEntry] failed to load product ${productId} for locale ${locale}:`,
+        err
+      )
+
       return null
     }
   })()
@@ -314,7 +322,6 @@ export const StoreProduct: Record<string, GraphqlResolver<Root>> & {
     const productId = root.isVariantOf.productId
     const itemId = root.itemId
     const locale = ctx.storage.locale
-    const defaultLocale = getDefaultLocale(ctx)
 
     // availableLinkIds returns localized slug for every locale,
     // we fetch for the current locale (reusing the request-scoped cache shared with the slug and
@@ -324,29 +331,56 @@ export const StoreProduct: Record<string, GraphqlResolver<Root>> & {
     if (!entry?.availableLinkIds) return null
 
     const { availableLinkIds } = entry
-    const { linkText } = root.isVariantOf
 
     return configuredLocales
       .map((configuredLocale) => {
-        // The default locale always uses the canonical IS linkText: it is always
-        // present and matches the Query.product `slug.startsWith(linkText)` fast
-        // path, so the fallback URL resolves cleanly even when the catalog has no
-        // default-locale entry in availableLinkIds.
-        if (configuredLocale === defaultLocale) {
-          return { locale: configuredLocale, slug: getSlug(linkText, itemId) }
-        }
-
-        // Non-default locales only appear when they have a registered localized slug
-        // in availableLinkIds. Untranslated locales are omitted so they are never
-        // advertised as hreflang alternates — this keeps the hreflang cluster
-        // symmetric across all locale variants of the product (every variant emits
-        // the same set: default + translated locales). The LocalizationSelector
-        // falls back to the default slug under the target prefix for omitted locales.
+        // availableLinkIds is identical whichever locale the Dataplane is queried
+        // with, so deriving every slug from it keeps the hreflang cluster
+        // reciprocal. The Intelligent Search linkText cannot stand in for a
+        // missing entry: it is localized to the locale being browsed, which would
+        // both point other locales at a 404 and make the advertised set depend on
+        // which locale served the request.
         const linkId = availableLinkIds[configuredLocale]
+
+        // Locales with no registered localized slug are omitted rather than
+        // guessed, so an alternate is only ever advertised for a slug the catalog
+        // actually resolves. A product with no translations advertises no
+        // alternates at all, from any locale. Navigating to an omitted locale is
+        // served by `defaultLocaleSlug`, which is free to guess precisely because
+        // it never reaches an hreflang annotation.
         return linkId
           ? { locale: configuredLocale, slug: getSlug(linkId, itemId) }
           : null
       })
       .filter((e): e is { locale: string; slug: string } => e !== null)
   },
+  defaultLocaleSlug: async (root, _args, ctx) => {
+    if (!isLocalizationEnabled(ctx)) return null
+
+    const defaultLocale = getDefaultLocale(ctx)
+
+    if (!defaultLocale) return null
+
+    const { productId, linkText } = root.isVariantOf
+    const itemId = root.itemId
+
+    // Reuses the request-scoped entry `otherLocales` already loads, so serving
+    // both fields costs a single Dataplane call.
+    const entry = await getLocalizedProductEntry(
+      ctx,
+      productId,
+      ctx.storage.locale
+    )
+
+    // linkText is localized to the locale being browsed, which is what makes it
+    // unusable for hreflang. It is acceptable here because an untranslated
+    // product carries the same slug in every locale, so linkText *is* the
+    // default-locale slug in the exact case where availableLinkIds is empty.
+    // A product translated for the browsed locale but not for the default one
+    // still yields a wrong guess; that URL 404s, which is the pre-existing
+    // behavior and still better than dropping the shopper on the locale root.
+    const linkId = entry?.availableLinkIds?.[defaultLocale] ?? linkText
+
+    return getSlug(linkId, itemId)
+  },
 }

package/src/platforms/vtex/resolvers/query.ts

@@ -109,10 +109,11 @@ const shouldFallbackToProductRoute = (error: unknown) =>
  * guards that the fetched sku is the one we actually asked for, throwing
  * SLUG_MISMATCH_ERROR (caught by the caller) when it isn't.
  *
- * When localization is enabled, the slug prefix may be a localized LinkId
- * that differs from the IS linkText (always in the default locale). In that
- * case we validate against the Catalog Dataplane API before rejecting the
- * slug.
+ * When localization is enabled, the slug prefix may be a localized LinkId that
+ * differs from the IS linkText. linkText follows the locale being browsed
+ * rather than the default one, so a mismatch is not by itself evidence of a
+ * wrong sku. We validate against the Catalog Dataplane API before rejecting
+ * the slug.
  */
 async function assertSkuMatchesSlug(
   ctx: GraphqlContext,

package/src/platforms/vtex/typeDefs/product.graphql

@@ -99,6 +99,14 @@ type StoreProduct {
   Only populated when localization is enabled.
   """
   otherLocales: [StoreProductLocale!]
+  """
+  Slug for the store's default locale, including the SKU ID suffix.
+  Navigation fallback for the locale selector when the target locale is absent
+  from `otherLocales`. Best-effort: it may point at a slug the catalog has not
+  registered for the default locale, so it must never be used to build hreflang
+  annotations. Only populated when localization is enabled.
+  """
+  defaultLocaleSlug: String
 }
 
 """